⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 25, 2006:

9:33 PM Changeset in webkit [14071] by justing
  • 15 edits
    13 adds
    1 delete in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8583>
Moving paste code around and some small fixes

Disabling until the bug it illustrates is fixed (8459):

  • editing/deleting/merge-whitespace-pre.html: Removed.
  • editing/deleting/merge-whitespace-pre.html-disabled: Added.


This illustrates the need to do mergeEnd in the opposite direction:

  • editing/pasteboard/merge-end-borders-expected.checksum: Added.
  • editing/pasteboard/merge-end-borders-expected.png: Added.
  • editing/pasteboard/merge-end-borders-expected.txt: Added.
  • editing/pasteboard/merge-end-borders.html: Added.


These illustrate the need to do the special case checks for list content and Mail
blockquote content at the top of shouldMergeStart:

  • editing/pasteboard/merge-start-blockquote-expected.checksum: Added.
  • editing/pasteboard/merge-start-blockquote-expected.png: Added.
  • editing/pasteboard/merge-start-blockquote-expected.txt: Added.
  • editing/pasteboard/merge-start-blockquote.html: Added.
  • editing/pasteboard/merge-start-list-expected.checksum: Added.
  • editing/pasteboard/merge-start-list-expected.png: Added.
  • editing/pasteboard/merge-start-list-expected.txt: Added.
  • editing/pasteboard/merge-start-list.html: Added.


In these tests, the caret was blown away because it was in content that
participated in the end merge. Now the end merge happens in the opposite
direction (incoming content is what is moved when merging paragraphs), so
the caret is no longer blown away:

  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:


Acceptable change to a complicated paste-a-selection-over-itself:

  • editing/pasteboard/paste-text-003-expected.checksum:
  • editing/pasteboard/paste-text-003-expected.png:
  • editing/pasteboard/paste-text-003-expected.txt:

WebCore:

Reviewed by harrison

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8583>
Moving paste code around and some small fixes


Moved code to make it easier to do the start merge after the fact,
with moveParagraph, instead of in the middle of the paste operation.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::shouldMergeStart): Moved code to make this decision to its own function. Moved special case checks to the top. Added m_forceMergeStart to override the special cases because moveParagraph uses ReplaceSelectionCommand and expects a merge.


(WebCore::ReplaceSelectionCommand::shouldMergeEnd):
No functional changes, just moved code here.
(WebCore::ReplaceSelectionCommand::doApply):
Do the end merge in the opposite direction. Merging two paragraphs destroys
the moved one's block level styles, and we prefer to use the styles of the
one that was in the document, not the one that's being pasted.


  • editing/ReplaceSelectionCommand.h:
  • editing/Selection.h: (WebCore::Selection::visibleStart): Added. (WebCore::Selection::visibleEnd): Added.
  • editing/htmlediting.cpp: (WebCore::enclosingList): Added. (WebCore::isMailBlockquote): Don't require a renderer so that this can be used on nodes in fragments.


  • editing/htmlediting.h:
4:12 PM Changeset in webkit [14070] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc]
running layout tests

  • Plugins/WebPluginPackage.m: (-[WebPluginPackage unload]): Clear isLoaded here. It turns out that only WebNetscapePluginPackage cleared its isLoaded flag in -unload. We need to also do it here, because the superclass (WebBasePluginPackage) asserts in -dealloc that -unload has been called.
3:58 PM Changeset in webkit [14069] by ggaren
  • 9 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for the DOM properties supported by object, embed, attribute:

  • fast/dom/plugin-attributes-enumeration-expected.txt: Added.
  • fast/dom/plugin-attributes-enumeration.html: Added.


Test for setting attributes through DOM properties:

  • plugins/embed-attributes-setting-expected.txt: Added.
  • plugins/embed-attributes-setting.html: Added.


Test for the special attribute-to-style mappings on embed.

  • plugins/embed-attributes-style-expected.txt: Added.
  • plugins/embed-attributes-style.html: Added.

WebCore:

Reviewed by Maciej.

  • Removed special handling of attributes in the DOM. To match WinIE, we used to make all attributes available as properties of their elements in the DOM, but that has caused us more compatibility woes than it has solved, so, after talking with Darin and Maciej, I'm taking it out. (Firefox does not support it.)

A layout test regression caused by this change led me to do the
following as well:


  • Implemented DOM properties missing on EMBED elements: align, height, name, width, src, type. Since align, height, name, and width are common to all plugin elements, I factored them and some other common functionality out into a new abstract base class, HTMLPlugInElement.
  • Removed extraneous attribute-to-style mappings on EMBED elements: valign, border. Why they were there in the first place is a question for the ages. Neither FF nor IE supports them.
  • bindings/js/kjs_dom.cpp: (KJS::getRuntimeObject):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::embedGetter): (KJS::JSHTMLElement::embedSetter):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Element.idl:
  • html/html_objectimpl.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): (WebCore::HTMLPlugInElement::align): (WebCore::HTMLPlugInElement::setAlign): (WebCore::HTMLPlugInElement::height): (WebCore::HTMLPlugInElement::setHeight): (WebCore::HTMLPlugInElement::name): (WebCore::HTMLPlugInElement::setName): (WebCore::HTMLPlugInElement::width): (WebCore::HTMLPlugInElement::setWidth): (WebCore::HTMLPlugInElement::mapToEntry): (WebCore::HTMLPlugInElement::parseMappedAttribute): (WebCore::HTMLPlugInElement::checkDTD): (WebCore::HTMLAppletElement::HTMLAppletElement): (WebCore::HTMLAppletElement::~HTMLAppletElement): (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::insertedIntoDocument): (WebCore::HTMLAppletElement::removedFromDocument): (WebCore::HTMLAppletElement::getInstance): (WebCore::HTMLAppletElement::closeRenderer): (WebCore::HTMLAppletElement::detach): (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::~HTMLEmbedElement): (WebCore::HTMLEmbedElement::getInstance): (WebCore::HTMLEmbedElement::mapToEntry): (WebCore::HTMLEmbedElement::parseMappedAttribute): (WebCore::HTMLEmbedElement::attach): (WebCore::HTMLEmbedElement::detach): (WebCore::HTMLEmbedElement::insertedIntoDocument): (WebCore::HTMLEmbedElement::removedFromDocument): (WebCore::HTMLEmbedElement::src): (WebCore::HTMLEmbedElement::setSrc): (WebCore::HTMLEmbedElement::type): (WebCore::HTMLEmbedElement::setType): (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::closeRenderer): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::insertedIntoDocument): (WebCore::HTMLObjectElement::removedFromDocument): (WebCore::HTMLObjectElement::recalcStyle):
  • html/html_objectimpl.h: (WebCore::HTMLPlugInElement::endTagRequirement): (WebCore::HTMLAppletElement::tagPriority): (WebCore::HTMLEmbedElement::tagPriority): (WebCore::HTMLObjectElement::tagPriority):
3:42 PM Changeset in webkit [14068] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/4526120> -[WebBasePluginPackage finalize] leaks the CFBundle (under GC only)

  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage finalize]): Release the CFBundle here.
3:35 PM Changeset in webkit [14067] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Maciej.

Fix for <rdar://problem/4518632> getComputedStyle returns 'auto'
for dimensions like 'margin-left'

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For margin and padding, to match Firefox we now go to the renderer to get the property value instead of calling valueForLength() on the style attribute. valueForLength() will return the string 'auto' if that was what was specified in the CSS, or a percentage if it was specified as a percent. But to match Firefox, we always want to return a pixel value for margin and padding.
3:02 PM Changeset in webkit [14066] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-31 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Hatcher.


  • fixed <rdar://problem/4372842> 10.4.4 Regression: control-clicking on a misspelled word doesn't select it or offer corrections (first click only)
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): Rolled in this one-line change that Hyatt wrote ages ago.
2:51 PM Changeset in webkit [14065] by thatcher
  • 8 edits
    1 add in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-04-25 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4472037>


Private extensions to the WebPlugin interface. A plugin may implement these methods to receive loading callbacks
for its main resource. Plug-ins that implement this SPI show better loading progress in the browser, can be saved
to disk, and are more efficient by avoiding making duplicate GET or POST requests for the plug-in's main resource.

I want to provide a solid API for plug-in networking, but time constraints require that I first provide this simple
SPI for internal clients.

  • Plugins/WebPluginViewFactoryPrivate.h: Added a new plugin argument, WebPlugInShouldLoadMainResourceKey. If YES, the plugin is responsible for loading its own content. If NO, the plugin should wait for WebKit to send it the data via the new request-sharing SPI.
  • Plugins/WebPluginPrivate.h: Added. Request-sharing SPI. See comments in code.
  • Plugins/WebPluginDocumentView.h: Hang onto the plugin view as an ivar so we can call the new resource loading methods on it.
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): Release pluginView ivar. (-[WebPluginDocumentView setDataSource:]): Pass NO for WebPlugInShouldLoadMainResourceKey to indicate to the plugin that it should not load its own main resource -- the data will come from WebKit. This is only necessary for plugin documents. By the time we create the view for a plugin document, we already have fetched some of its main resource's data. Embedded plugins do not have this issue because WebKit is not involved in loading their content. Call -webPlugInMainResourceDidReceivResponse: on the plugin if necessary. This lets the plugin know how much and what kind of data is going to be received. (-[WebPluginDocumentView dataSourceUpdated:]): If the plugin implements the new request-sharing SPI, don't cancel the in-progress request. (-[WebPluginDocumentView receivedData:withDataSource:]): Forward to the plugin via the new request-sharing SPI. (-[WebPluginDocumentView receivedError:withDataSource:]): ditto (-[WebPluginDocumentView finishedLoadingWithDataSource:]): ditto
  • Plugins/WebPluginPackage.m: Added WebPlugInShouldLoadMainResourceKey, tweaked some style a bit.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): Pass YES for WebPlugInShouldLoadMainResourceKey. Embedded plugins must load their own data. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): ditto


  • WebKit.xcodeproj/project.pbxproj: Added WebPluginPrivate.h
2:47 PM Changeset in webkit [14064] by brmorris
  • 1 copy in S60/tags/s60-051212

S60: Tagging initial migration at S60/tags/s60-051212

2:44 PM Changeset in webkit [14063] by brmorris
  • 1 delete in S60/trunks

S60: Removed svn/webkit/s60/trunkS

2:34 PM Changeset in webkit [14062] by brmorris
  • 574 edits
    235 adds
    205 deletes in S60/trunk

S60: populated s60/trunk with s60-051212 release.

2:26 PM Changeset in webkit [14061] by eseidel
  • 2 edits in trunk/WebKitTools

2006-04-26 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

  • DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController display]):
2:24 PM Changeset in webkit [14060] by tomernic
  • 8 edits
    1 add in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4472037>


Private extensions to the WebPlugin interface. A plugin may implement these methods to receive loading callbacks
for its main resource. Plug-ins that implement this SPI show better loading progress in the browser, can be saved
to disk, and are more efficient by avoiding making duplicate GET or POST requests for the plug-in's main resource.

I want to provide a solid API for plug-in networking, but time constraints require that I first provide this simple
SPI for internal clients.

  • Plugins/WebPluginViewFactoryPrivate.h: Added a new plugin argument, WebPlugInShouldLoadMainResourceKey. If YES, the plugin is responsible for loading its own content. If NO, the plugin should wait for WebKit to send it the data via the new request-sharing SPI.
  • Plugins/WebPluginPrivate.h: Added. Request-sharing SPI. See comments in code.
  • Plugins/WebPluginDocumentView.h: Hang onto the plugin view as an ivar so we can call the new resource loading methods on it.
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): Release pluginView ivar. (-[WebPluginDocumentView setDataSource:]): Pass NO for WebPlugInShouldLoadMainResourceKey to indicate to the plugin that it should not load its own main resource -- the data will come from WebKit. This is only necessary for plugin documents. By the time we create the view for a plugin document, we already have fetched some of its main resource's data. Embedded plugins do not have this issue because WebKit is not involved in loading their content. Call -webPlugInMainResourceDidReceivResponse: on the plugin if necessary. This lets the plugin know how much and what kind of data is going to be received. (-[WebPluginDocumentView dataSourceUpdated:]): If the plugin implements the new request-sharing SPI, don't cancel the in-progress request. (-[WebPluginDocumentView receivedData:withDataSource:]): Forward to the plugin via the new request-sharing SPI. (-[WebPluginDocumentView receivedError:withDataSource:]): ditto (-[WebPluginDocumentView finishedLoadingWithDataSource:]): ditto
  • Plugins/WebPluginPackage.m: Added WebPlugInShouldLoadMainResourceKey, tweaked some style a bit.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): Pass YES for WebPlugInShouldLoadMainResourceKey. Embedded plugins must load their own data. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): ditto


  • WebKit.xcodeproj/project.pbxproj: Added WebPluginPrivate.h
2:23 PM Changeset in webkit [14059] by eseidel
  • 2 edits
    3 adds in trunk

2006-04-26 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

Test: fast/frames/empty-cols-attribute.html

  • platform/StringImpl.cpp: (WebCore::StringImpl::toLengthArray): If the string is empty, return 0 but set len to 1. This gives the same behavior you get if you don't specify the attribute at all, matching WinIE and Firefox. Previously, the empty string resulted in len being set to 0 (and a memory smasher in RenderFrameSet::layout()).
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::layout): Added an assert.
2:22 PM Changeset in webkit [14058] by eseidel
  • 12 edits
    50 adds in trunk

2006-04-26 Oliver Hunt <​ojh16@student.canterbury.ac.nz>

Reviewed by eseidel. Landed by eseidel.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasFilters.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasFilters.h: (WebCore::KCComponentTransferFunction::KCComponentTransferFunction):
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::getVectorForChannel): (WebCore::genImageFromTable): (WebCore::filterForComponentFunc): (WebCore::setParametersForComponentFunc): (WebCore::getFilterForFunc): (WebCore::KCanvasFEComponentTransferQuartz::getFunctionFilter): (WebCore::KCanvasFEComponentTransferQuartz::getCIFilter):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/filters/WKComponentMergeFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKComponentMergeFilter.h: Added.
  • kcanvas/device/quartz/filters/WKComponentMergeFilter.m: Added. (+[WKComponentMergeFilter initialize]): (+[WKComponentMergeFilter filterWithName:]): (-[WKComponentMergeFilter init]): (-[WKComponentMergeFilter outputImage]):
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m: Added. (+[WKDiscreteTransferFilter initialize]): (+[WKDiscreteTransferFilter filterWithName:]): (-[WKDiscreteTransferFilter init]): (-[WKDiscreteTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKGammaTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKGammaTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKGammaTransferFilter.m: Added. (+[WKGammaTransferFilter initialize]): (+[WKGammaTransferFilter filterWithName:]): (-[WKGammaTransferFilter init]): (-[WKGammaTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKIdentityTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKIdentityTransferFilter.m: Added. (+[WKIdentityTransferFilter initialize]): (+[WKIdentityTransferFilter filterWithName:]): (-[WKIdentityTransferFilter init]): (-[WKIdentityTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKLinearTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKLinearTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKLinearTransferFilter.m: Added. (+[WKLinearTransferFilter initialize]): (+[WKLinearTransferFilter filterWithName:]): (-[WKLinearTransferFilter init]): (-[WKLinearTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKTableTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKTableTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKTableTransferFilter.m: Added. (+[WKTableTransferFilter initialize]): (+[WKTableTransferFilter filterWithName:]): (-[WKTableTransferFilter init]): (-[WKTableTransferFilter outputImage]):
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::parseMappedAttribute): (SVGComponentTransferFunctionElement::transferFunction):
2:21 PM Changeset in webkit [14057] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

New export symbols for a change in JavaScriptGlue.

2:20 PM Changeset in webkit [14056] by thatcher
  • 4 edits in branches/Safari-2-0-branch/JavaScriptGlue

Merged fix from TOT to Safari-2-0-branch

2006-03-31 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin.

  • Fixed <rdar://problem/4430836> JavaScript patch crashing Quartz Composer

JSValueWrappers used to hold on to the ExecState that pertained at
the time of their creation. Since ExecStates are transient, that
design was totally bogus, and it would crash once the ExecState had
been deallocated.

Unfortunately, there's no clean solution to this problem, since
the JSGlue API has no notion of state. The solution here is to use
a shared, global ExecState for the purpose of JSGlue calls. Given
the pre-existing limitations in the JSGlue API, this design
shouldn't actually introduce any new limitations (see comments in
JSValueWrapper.cpp).

I tested with Quartz Composer and PAC files, neither of which are
layout-testable.


  • JSUtils.cpp: (KJSValueToJSObject):
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (getProcessGlobalExecState): (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
  • JSValueWrapper.h:

Also added a test harness file. It was helpful while I was testing,
and may come in handy in the future:


  • JavaScriptGlue.xcodeproj/project.pbxproj: testjsglue.cpp: Added.
12:33 PM Changeset in webkit [14055] by eseidel
  • 4 edits in branches/Safari-2-0-branch/WebCore

2006-04-25 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fixes for our 3rd and 5th most common crashtracers:
<rdar://problem/4233435> CrashTracer: 2698 crashes in Safari at com.apple.WebCore: khtml::RenderBlock::addChildToFlow + 156
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test case landed on trunk but not on branch.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): use m_inDetach bool copied from trunk
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::detach): set m_inDetach (NodeImpl::createRendererIfNeeded): (NodeBaseImpl::removeChildren): remove node from tree before calling detach.
  • khtml/xml/dom_nodeimpl.h:
12:32 PM Changeset in webkit [14054] by eseidel
  • 2 edits in trunk/WebCore

2006-04-25 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fixes for our 3rd and 5th most common crashtracers:
<rdar://problem/4233435> CrashTracer: 2698 crashes in Safari at com.apple.WebCore: khtml::RenderBlock::addChildToFlow + 156
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test case landed on trunk but not on branch.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): use m_inDetach bool copied from trunk
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::detach): set m_inDetach (NodeImpl::createRendererIfNeeded): (NodeBaseImpl::removeChildren): remove node from tree before calling detach.
  • khtml/xml/dom_nodeimpl.h:
12:16 PM Changeset in webkit [14053] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren & TimH.

<rdar://problem/4473288> XSL file containing <xsl:include href="../Styles/EscapeString.xsl" /> fails to load file
XML_DTD_NODE objects in the tree were causing loadChildSheets to
fail to preload child stylesheets, this patch causes us to
correctly ignore all nodes besides the first XML_ELEMENT_NODE at
the root level when searching the tree for xsl:include statements
to pre-load.

Test: fast/xsl/xslt-second-level-import.xml

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::loadChildSheets):
11:53 AM Changeset in webkit [14052] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

changelog fixup

11:38 AM Changeset in webkit [14051] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • don't have a fini method, since trying to call it will actually call the subclass method and mess up the bridge count.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge finalize]):
11:05 AM Changeset in webkit [14050] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-20 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.


<rdar://problem/4458568> WebCore should not disclose https referrers

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canLoadURL:fromReferrer:hideReferrer:]): Don't send https URLs as referrers to non-secure http sites.
10:59 AM Changeset in webkit [14049] by sfalken
  • 3 edits in trunk/WebCore

2006-04-25 Steve Falkenburg <​sfalkenburg@apple.com>

Reviewed by eseidel.

No test case needed

  • platform/win/TemporaryLinkStubs.cpp: (KWQFileButton::setFrameGeometry):
1:51 AM Changeset in webkit [14048] by eseidel
  • 3 edits
    2 adds in trunk

2006-04-25 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix reproducible crash in html parser code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7137

Test: fast/parser/remove-current-node-parent.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
1:11 AM Changeset in webkit [14047] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Add a missing release
12:18 AM Changeset in webkit [14046] by hyatt
  • 2 edits in trunk/WebCore

Fix for 8336, focus ring redrawing on top of itself. Make sure
not to include empty rects when doing the focus ring drawing, since
that results in a draw with no clip set.

Reviewed by adele

  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):

Apr 24, 2006:

10:24 PM Changeset in webkit [14045] by eseidel
  • 3 edits
    2 adds in trunk

2006-04-24 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix for 5th worst unresolved crasher:
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test: fast/dom/remove-style-element.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
10:01 PM Changeset in webkit [14044] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Geoff.


<rdar://problem/4525364> REGRESSION (yesterday?): LOG() mechanism is broken


  • initialize WebKit's log channels
  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m: (initializeLogChannel): (WebKitInitializeLoggingChannelsIfNecessary):
  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
  • WebView/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
10:00 PM Changeset in webkit [14043] by eseidel
  • 4 edits in trunk/WebCore

2006-04-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Speculative fix for our 7th worst crasher.
Also added ASSERTs to help us better understand the issue.
<rdar://problem/4153404> CrashTracer: 2412 crashes in Safari at com.apple.WebCore: khtml::RenderStyle::RenderStyle[unified] + 44

  • dom/Document.cpp: (WebCore::Document::recalcStyle): (WebCore::Document::setInPageCache):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
5:30 PM Changeset in webkit [14042] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4503438> REGRESSION (NativeTextField): Can't insert caret when
selection is active in field (Business/Unit)

  • css/html4.css: Added -webkit-user-select:text for input elements.
5:22 PM Changeset in webkit [14041] by mjs
  • 6 edits in trunk

WebCore:

Build fix:


  • move some prematurely code back
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fini]):

WebKit:

Build fix:


  • move some prematurely code back
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge fini]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): (-[WebFrameBridge keyboardUIMode]):
4:54 PM Changeset in webkit [14040] by brmorris
  • 1 copy in S60/trunk

Creating trunk in S60 branch from r9049

4:33 PM Changeset in webkit [14039] by brmorris
  • 1 delete in S60/tags/s60-051212

Reversed s60-051212 import ('svn copy' is better)

3:56 PM Changeset in webkit [14038] by mjs
  • 6 edits in trunk

WebCore:

Reviewed by Darin.

  • move more code from WebFrameBridge to WebCoreFrameBridge
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge domain]): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge fini]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge finalize]): (_getPreSmartSet): (_getPostSmartSet): (-[WebCoreFrameBridge isCharacterSmartReplaceExempt:isPreviousCharacter:]): (-[WebCoreFrameBridge _retrieveKeyboardUIModeFromPreferences:]): (-[WebCoreFrameBridge keyboardUIMode]):

WebKit:

Reviewed by Darin.

  • move more code from WebFrameBridge to WebCoreFrameBridge
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge fini]): (-[WebFrameBridge expiresTimeForResponse:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge valueForKey:keys:values:]): (-[WebFrameBridge _preferences]):
3:33 PM Changeset in webkit [14037] by brmorris
  • 1174 adds in S60/tags/s60-051212

Populated S60/tags/s60-051212

2:59 PM Changeset in webkit [14036] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tim O.

Fix to send textFieldDidBeginEditing on the first editing change instead of on focus.
This matches our old behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::subtreeHasChanged):
2:10 PM Changeset in webkit [14035] by ggaren
  • 5 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/dom/prototype-chain-expected.txt: Updated now that 'JS' is no longer used as a prefix when serializing DOM elements to string.
  • fast/events/event-view-toString.html: ditto

WebCore:

Reviewed by Eric.

Fix for <rdar://problem/4513383> REGRESSION: Crash in
WebCore::shouldEmitTabBeforeNode() when iterating through document
text

  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.
2:05 PM Changeset in webkit [14034] by brmorris
  • 4 adds in S60

S60: Added toplevel repository layout

11:50 AM Changeset in webkit [14033] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

Fix for <rdar://problem/4513383> REGRESSION: Crash in
WebCore::shouldEmitTabBeforeNode() when iterating through document
text

  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.
2:30 AM Changeset in webkit [14032] by mjs
  • 27 edits in trunk/WebKit

Reviewed by Anders.



I removed all use of these, now objects get at each other via
actual pointers, not using the view hierarchy. However, I left two
of the calls in because other clients rely on them as SPI (ugh).

  • History/WebHistoryItem.m:
  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:]): (-[NSView _web_parentWebFrameView]):
  • Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView layout]):
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView setWebFrame:]): (-[WebNetscapePluginEmbeddedView dataSource]):
  • Plugins/WebNullPluginView.h:
  • Plugins/WebNullPluginView.m: (-[WebNullPluginView setWebFrame:]): (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.m: (-[WebPluginController setDataSource:]): (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController webPlugInContainerShowStatus:]): (-[WebPluginController webPlugInContainerSelectionColor]): (-[WebPluginController webFrame]):
  • Plugins/WebPluginDocumentView.h:
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): (-[WebPluginDocumentView layout]): (-[WebPluginDocumentView currentWindow]): (-[WebPluginDocumentView viewWillMoveToWindow:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge formControlIsBecomingFirstResponder:]): (-[WebFrameBridge formControlIsResigningFirstResponder:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory bridgeForView:]):
  • WebView/WebClipView.m: (-[NSView initWithFrame:]):
  • WebView/WebFrameView.m: (-[WebFrameView _shouldDrawBorder]): (-[WebFrameView webCoreBridge]):
  • WebView/WebHTMLView.m: (-[WebTextCompleteController dealloc]): (-[WebHTMLView _dataSource]): (-[WebHTMLView _bridge]): (-[WebHTMLView _webView]): (-[WebHTMLView _frameView]): (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): (-[NSArray becomeFirstResponder]): (-[NSArray setDataSource:]): (-[NSArray pageUp:]): (-[NSArray pageDown:]): (-[NSArray pageUpAndModifySelection:]): (-[NSArray pageDownAndModifySelection:]): (-[WebHTMLView _frame]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebImageView.h:
  • WebView/WebImageView.m: (-[WebImageView drawRect:]): (-[WebImageView adjustFrameSize]): (-[WebImageView setDataSource:]): (-[WebImageView webView]): (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView copy:]): (-[WebImageView elementAtPoint:]): (-[WebImageView mouseDragged:]):
  • WebView/WebPDFView.h:
  • WebView/WebPDFView.m: (-[WebPDFView _applyPDFDefaults]): (-[WebPDFView _trackFirstResponder]): (-[PDFPrefUpdatingProxy forwardInvocation:]):
  • WebView/WebRenderNode.m: (-[WebRenderNode initWithWebFrameView:]):
  • WebView/WebTextView.h:
  • WebView/WebTextView.m: (-[WebTextView _textSizeMultiplierFromWebView]): (-[WebTextView _preferences]): (-[WebTextView setDataSource:]): (-[WebTextView _webFrame]): (-[WebTextView dragSelectionWithEvent:offset:slideBack:]): (-[WebTextView menuForEvent:]): (-[WebTextView resignFirstResponder]): (-[WebTextView drawPageBorderWithSize:]): (-[WebTextView knowsPageRange:]):
  • WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): (containingFrameView): (-[WebView _focusedFrame]): (-[WebView _frameViewAtWindowPoint:]):
Note: See TracTimeline for information about the timeline view.