Context Navigation

I haven't figured out how to construct a test for this, but this does seem to fix the
problem; Mitz mentioned that a double-destroy was occurring in these functions.

kxmlcore/HashMap.h: (KXMLCore::HashMap::remove): Use RefCounter::deref instead of calling ~ValueType, because ~ValueType often results in a double-destroy, since the HashTable also destroys the element based on the storage type. The RefCounter template correctly does work only in cases where ValueType and ValueStorageType differe and this class is what's used elsewhere for the same purpose; I somehow missed this case when optimizing HashMap.
kxmlcore/HashSet.h: (KXMLCore::HashSet::remove): Ditto.

WebCore:

Suggested by Mitz. Reviewed and landed by Maciej.

dom/Document.cpp: (WebCore::Document::formElementsState): Fixed mistake where the vector has an initial size and instead should have an initial capacity. Harmless in a way, but hurts performance.

9:18 PM Changeset in webkit [14220] by hyatt

82 edits in trunk/LayoutTests/fast/table

Land new results for fast/table to account for bug 8060.

9:14 PM Changeset in webkit [14219] by hyatt

2 edits in trunk/WebCore

Fix for bugzilla bug 8060.

Fixed width table cells weren't having their border widths
included in the effective width of the column (and thus could end up being
too small).

Reviewed by darin

Added fast/tables/fixed-cell-growth.html

rendering/table_layout.cpp: (WebCore::AutoTableLayout::recalcColumn):

11:07 AM Changeset in webkit [14218] by ap

1 edit in trunk/WebCore/ChangeLog

Fix a typo in te ChangeLog.

11:01 AM Changeset in webkit [14217] by ap

4 edits
2 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8769 TextEncoding::fromUnicode() - support non-BMP characters and convert to NFC

Tests:

fast/forms/form-data-encoding.html
fast/forms/form-data-encoding-2.html

platform/mac/TextEncodingMac.cpp: (WebCore::TextEncoding::fromUnicode): Normalize the string; handle surrogate pairs.

May 6, 2006:

1:40 AM Changeset in webkit [14216] by hyatt

16 edits
2 moves
1 delete in trunk/WebCore

Rename WebCoreFont to FontPlatformData and WebTextRenderer to FontData. Merge them into the
headers (uncleanly with ifdefs at the moment, so I can see what I'm working towards).

Reviewed by mjs

ChangeLog:
WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bridge/mac/WebCoreStringTruncator.mm: (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
kwq/KWQComboBox.mm: (QComboBox::sizeHint):
kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
kwq/KWQListBox.mm: (itemTextRenderer): (groupLabelTextRenderer): (QListBox::sizeForNumberOfLines): (-[KWQTableView drawRow:clipRect:]):
platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::update): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch):
platform/Font.h: (WebCore::Font::getNSFont):
platform/FontData.h: (WebCore::FontData::ascent): (WebCore::FontData::descent): (WebCore::FontData::lineSpacing): (WebCore::FontData::lineGap): (WebCore::FontData::misspellingLineThickness): (WebCore::FontData::misspellingLinePatternWidth): (WebCore::FontData::misspellingLinePatternGapWidth):
platform/FontDataSet.h: Removed.
platform/FontFallbackList.h: Added.
platform/FontPlatformData.h:
platform/mac/FontData.mm: Added. (WebCore::WebCoreInitializeFont): (WebCore::WebCoreInitializeEmptyTextGeometry): (WebCore::widthForGlyph): (WebCore::overrideLayoutOperation): (WebCore::FontData::~FontData): (WebCore::FontData::xHeight): (WebCore::FontData::drawRun): (WebCore::FontData::floatWidthForRun): (WebCore::FontData::drawLineForCharacters): (WebCore::FontData::selectionRectForRun): (WebCore::FontData::drawHighlightForRun): (WebCore::FontData::drawLineForMisspelling): (WebCore::FontData::pointToOffset): (WebCore::FontData::setAlwaysUseATSU): (WebCore::getSmallCapsRenderer): (WebCore::findSubstituteFont): (WebCore::rendererForAlternateFont): (WebCore::findSubstituteRenderer): (WebCore::computeWidthForSpace): (WebCore::setUpFont): (WebCore::CG_drawHighlight): (WebCore::CG_selectionRect): (WebCore::CG_draw): (WebCore::CG_floatWidthForRun): (WebCore::updateGlyphMapEntry): (WebCore::extendGlyphMap): (WebCore::extendWidthMap): (WebCore::initializeATSUStyle): (WebCore::createATSULayoutParameters): (WebCore::getTextBounds): (WebCore::ATSU_floatWidthForRun): (WebCore::ATSU_drawHighlight): (WebCore::ATSU_selectionRect): (WebCore::ATSU_draw): (WebCore::ATSU_pointToOffset): (WebCore::advanceWidthIteratorOneCharacter): (WebCore::CG_pointToOffset): (WebCore::glyphForCharacter): (WebCore::initializeWidthIterator): (WebCore::advanceWidthIterator):
platform/mac/FontMac.mm: (WebCore::m_font): (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::platformFont): (WebCore::FontFallbackList::primaryFont): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::invalidate): (WebCore::Font::platformFont): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth): (WebCoreSetAlwaysUseATSU):
platform/mac/WebTextRenderer.h: Removed.
platform/mac/WebTextRenderer.mm: Removed.
platform/mac/WebTextRendererFactory.h:
platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory isFontFixedPitch:]): (-[WebTextRendererFactory init]): (-[WebTextRendererFactory rendererWithFont:]): (-[WebTextRendererFactory fontWithFamilies:traits:size:]):
platform/win/FontWin.cpp: (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::primaryFont): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::selectionRectForText): (WebCore::Font::checkSelectionPoint):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed