⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 10, 2006:

10:32 PM Changeset in webkit [14296] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-10 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

  • Misc.subproj/WebNSWindowExtras.h:
  • Misc.subproj/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Overrides certain NSWindow methods so that window autodisplay can be throttled to 60Hz.

(disableWindowDisplayThrottleApplierFunction):
CFDictionary applier function for when the throttle is disabled. Cancels all pending window displays,
and calls -displayIfNeeded on each window with a pending display.

(+[NSWindow _webkit_disableWindowDisplayThrottle]):
Restores default NSWindow method implementations and clears pending window displays.

(swizzleInstanceMethod):
Helper function to swizzle ObjC method implementations.

(replacementPostWindowNeedsDisplay):
Don't call into -[NSWindow _postWindowNeedsDisplay] if requestWindowDisplay() returns NO (this is the
function that throttles display).

(replacementClose):
Clean up the WindowDisplayInfo struct for the window, since it's about to go away.

(getWindowDisplayInfo):
Gets the WindowDisplayInfo struct for the window, or creates it if absent.

(requestWindowDisplay):
Returns YES if a display is allowed right now. Returns NO otherwise, and schedules a timer to try the
display again.

(cancelPendingWindowDisplay):
Cancels the pending display for the window, if any.

(-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]):
Try to call _postWindowNeedsDisplay again.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView initWithFrame:]): If the secret "WebKitThrottleWindowDisplay" default is set, then enable the NSWindow throttle.
7:52 PM Changeset in webkit [14295] by justing
  • 1 edit in trunk/WebCore/ChangeLog

Fixed my incorrect wording.

6:26 PM Changeset in webkit [14294] by justing
  • 16 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

Fixed a select-after-replacement problem:

  • editing/pasteboard/drag-drop-modifies-page-expected.checksum:
  • editing/pasteboard/drag-drop-modifies-page-expected.png:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt:


The trailing interchange newline used to be lost:

  • editing/pasteboard/paste-text-012-expected.checksum:
  • editing/pasteboard/paste-text-012-expected.png:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-012.html:
  • editing/pasteboard/paste-text-016-expected.checksum:
  • editing/pasteboard/paste-text-016-expected.png:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.checksum:
  • editing/pasteboard/paste-text-017-expected.png:
  • editing/pasteboard/paste-text-017-expected.txt:


Illustrates the bug fixed in smart replace whitespace handling:

  • editing/pasteboard/smart-paste-008.html
  • editing/pasteboard/smart-paste-008-expected.txt
  • editing/pasteboard/smart-paste-008-expected.png
  • editing/pasteboard/smart-paste-008-expected.checksum

WebCore:

Reviewed by darin

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed the code to find out if we must later add smart replace whitespace. We can wait until we've done the insertion to figure it out, and the position sampled (startPos) to make the decision about trailing whitespace was wrong. Changed the order that work is done during a paste: 1) Insert everything 2) Do one of the following: a) handle a trailing interchange newline, b) uncollapse the last incoming br if it has been collapsed because of quirks mode, c) do an end merge 3) Add smart replace whitespace (2 and 3 were reversed because the end merge must happen before we can know whether or not we need to add a trailing space). Don't do an end merge if the last node inserted was a br because the end merge will clobber it.


(WebCore::ReplaceSelectionCommand::removeEndBRIfNeeded):
brs that are at the end of a block and not at the start of a block are not the one brs
that are collapsed because of quirks mode.

6:04 PM Changeset in webkit [14293] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Overrides certain NSWindow methods so that window autodisplay can be throttled to 60Hz.

(disableWindowDisplayThrottleApplierFunction):
CFDictionary applier function for when the throttle is disabled. Cancels all pending window displays,
and calls -displayIfNeeded on each window with a pending display.

(+[NSWindow _webkit_disableWindowDisplayThrottle]):
Restores default NSWindow method implementations and clears pending window displays.

(swizzleInstanceMethod):
Helper function to swizzle ObjC method implementations.

(replacementPostWindowNeedsDisplay):
Don't call into -[NSWindow _postWindowNeedsDisplay] if requestWindowDisplay() returns NO (this is the
function that throttles display).

(replacementClose):
Clean up the WindowDisplayInfo struct for the window, since it's about to go away.

(getWindowDisplayInfo):
Gets the WindowDisplayInfo struct for the window, or creates it if absent.

(requestWindowDisplay):
Returns YES if a display is allowed right now. Returns NO otherwise, and schedules a timer to try the
display again.

(cancelPendingWindowDisplay):
Cancels the pending display for the window, if any.

(-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]):
Try to call _postWindowNeedsDisplay again.

  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): If the secret "WebKitThrottleWindowDisplay" default is set, then enable the NSWindow throttle.
2:08 PM Changeset in webkit [14292] by hyatt
  • 5 edits in trunk/WebCore

Rename isSpace to treatAsSpace. Move it and the rounding hack function into
Font and make them static methods (inlined in the header). Make the rounding
hack character table a static member as well. Remove the redundant space/rounding
functions from FontData.mm.

Reviewed by darin

  • platform/Font.cpp: (WebCore::): (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance):
  • platform/Font.h: (WebCore::Font::treatAsSpace): (WebCore::Font::isRoundingHackCharacter):
  • platform/mac/FontData.mm: (WebCore::overrideLayoutOperation): (WebCore::createATSULayoutParameters): (WebCore::initializeWidthIterator): (WebCore::advanceWidthIterator):
  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize):
1:49 PM Changeset in webkit [14291] by darin
  • 1 edit
    1 delete in trunk/WebCore
  • WebCore: Removed an extra WebCore subtree that somehow got checked in.
1:27 PM Changeset in webkit [14290] by hyatt
  • 1 edit in trunk/WebCore/platform/Font.cpp

Fix typo from the removal of the inline keyword from some functions.

11:59 AM Changeset in webkit [14289] by thatcher
  • 1 copy in tags/WebCore-418.3/WebCore

Tag for WebCore 418.3 (part 2 of 2.)

11:59 AM Changeset in webkit [14288] by thatcher
  • 1 add in tags/WebCore-418.3

Tag for WebCore 418.3 (part 1 of 2.)

11:55 AM Changeset in webkit [14287] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

11:09 AM Changeset in webkit [14286] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Darin, landed by Timothy.

  • platform/Font.cpp: (WebCore::isSpace):
  • platform/mac/FontData.mm: (WebCore::widthForGlyph): (WebCore::isRoundingHackCharacter): (WebCore::glyphForCharacter):
10:28 AM Changeset in webkit [14285] by ap
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by Anders.

The problem itself was fixed by Anders in bug 8808 (WebCore should handle text files).

  • http/tests/misc/resources: Added.
  • http/tests/misc/resources/200.html: Added.
  • http/tests/misc/resources/text-refresh.pl: Added.
  • http/tests/misc/text-refresh-expected.txt: Added.
  • http/tests/misc/text-refresh.html: Added.
8:11 AM Changeset in webkit [14284] by andersca
  • 2 edits in trunk/WebCore

2006-05-10 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.

Already covered by several pixel tests in fast/text

  • platform/Font.cpp: (WebCore::Font::drawSimpleText):
1:49 AM Changeset in webkit [14283] by hyatt
  • 8 edits
    1 add in trunk/WebCore

Fix for bug 8809, lift the Mac-specific WebTextRenderer code for
drawing and measuring of runs up into the Font class. The fast code
path is in Font.cpp and is designed to be mostly cross-platform. The
slow code path is in FontMac.cpp and is Mac-specific.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::isSpace): (WebCore::): (WebCore::isRoundingHackCharacter): (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks): (WebCore::Font::primaryFont): (WebCore::Font::setAlwaysUseComplexPath): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h:
  • platform/FontData.h: (WebCore::FontData::platformData):
  • platform/GlyphBuffer.h: Added. (WebCore::GlyphBuffer::GlyphBuffer): (WebCore::GlyphBuffer::isEmpty): (WebCore::GlyphBuffer::size): (WebCore::GlyphBuffer::glyphs): (WebCore::GlyphBuffer::advances): (WebCore::GlyphBuffer::fontDataAt): (WebCore::GlyphBuffer::swap): (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
  • platform/mac/FontData.mm: (WebCore::isSpace): (WebCore::isRoundingHackCharacter): (WebCore::FontData::widthForGlyph): (WebCore::m_ATSUMirrors): (WebCore::FontData::xHeight): (WebCore::FontData::smallCapsFontData): (WebCore::findSubstituteFont): (WebCore::rendererForAlternateFont): (WebCore::findSubstituteRenderer): (WebCore::FontData::findSubstituteFontData): (WebCore::computeWidthForSpace): (WebCore::FontData::updateGlyphMapEntry): (WebCore::extendGlyphMap): (WebCore::extendWidthMap): (WebCore::createATSULayoutParameters): (WebCore::FontData::glyphForCharacter): (WebCore::advanceWidthIterator): (WebCore::shouldUseATSU):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::m_padPerSpace): (WebCore::addDirectionalOverride): (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::disposeATSULayoutParameters): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUseATSU):
1:18 AM Changeset in webkit [14282] by andersca
  • 2 edits in trunk/WebKit

2006-05-10 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

  • WebView/WebHTMLView.m: (+[WebHTMLView unsupportedTextMIMETypes]): Add text/rtf
12:20 AM Changeset in webkit [14281] by darin
  • 1 edit
    1 add in trunk/WebCore
  • another try at fixing the Windows build
  • platform/win/FontWin.cpp: (WebCore::getFontData): Use characters() instead of unicode().
12:19 AM Changeset in webkit [14280] by darin
  • 2 edits
    1 move in trunk/WebCore

Cut change log.

12:12 AM Changeset in webkit [14279] by darin
  • 2 edits in trunk/WebCore

Reviewed, tweaked, and landed by Darin.

Optimization of [DOMNode _nodeWith:] to look up the obj-c wrapperClass
for each HTMLElement using a HashMap instead of by repeated calls to
htmlElt->hasLocalName(someTag).

  • bindings/objc/DOM.mm: (addElementClass): Added. (createHTMLElementClassMap): (elementClass): (+[DOMNode _nodeWith:]): Added code to call elementClass.

May 9, 2006:

11:56 PM Changeset in webkit [14278] by darin
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Hyatt.

  • manual-tests/first-line-style-crash.html: Added.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::createStyleForElement): Changed to not return the shared styleNotYetAvailable if allowSharing is off.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): In the FIRST_LINE_INHERITED case, set the styleType on the style returned from createStyleForElement().
  • rendering/render_style.h: (WebCore::RenderStyle::setStyleType): Added. Called from RenderObject::getPseudoStyle().
11:42 PM Changeset in webkit [14277] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

No test possible (no functionality change).

  • dom/Node.cpp: (WebCore::Node::diff): When checking if :before or :after has changed, return NoInherit unless both pseudoStyles are known and equal.
  • rendering/render_style.cpp: (WebCore::RenderStyle::getPseudoStyle): Fixed to match the requested type against the pseudoStyle's styleType instead of our own.
11:04 PM Changeset in webkit [14276] by darin
  • 4 edits in trunk/WebCore
  • another attempt to fix the Windows build
  • bindings/js/kjs_window.cpp: (KJS::isSeparator): Take a UChar, not a KJS::UChar.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::runJavaScriptAlert): Use UChar instead of QChar. (WebCore::FrameWin::runJavaScriptConfirm): Ditto.
  • editing/TextIterator.h: Include DeprecatedString.h.
10:43 PM Changeset in webkit [14275] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

  • fast/replaced/image-map.html: Added.
  • fast/replaced/image-map-expected.txt: Added.

WebCore:

Reviewed by Hyatt.

  • html/html_imageimpl.cpp: (WebCore::HTMLAreaElement::getRegion): Remove extra Path definition that was shadowing the real one.
10:26 PM Changeset in webkit [14274] by darin
  • 12 edits in trunk

WebCore:

  • fix build
  • rendering/render_style.cpp: (WebCore::RenderStyle::getPseudoStyle): Fix a typo.
  • attempt to fix Windows build
  • css/maketokenizer: Use UChar instead of unsigned short.
  • platform/win/FontWin.cpp: (WebCore::getFontData): Removed cast to QChar. (WebCore::hackishExtentForString): Use UChar. (WebCore::Font::floatWidth): Use UChar. (WebCore::Font::drawText): Use UChar. (WebCore::Font::drawHighlightForText): Use UChar. (WebCore::Font::selectionRectForText): Use UChar. (WebCore::Font::checkSelectionPoint): Use UChar.
  • platform/win/KeyEventWin.cpp: (WebCore::singleCharacterString): Added. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use above function.
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::findNextSentenceFromIndex): Use UChar. (WebCore::findSentenceBoundary): Use UChar. (WebCore::findNextWordFromIndex): Use UChar. (WebCore::findWordBoundary): Use UChar.
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start): Use a different String constructor.
  • rendering/RenderTable.h: Added an include of DeprecatedArray.h.
  • rendering/RenderText.cpp: Added an include of DeprecatedString.h.
  • rendering/render_list.h: Ditto.

WebKitWin:

  • attempt to fix the Windows build
  • WebView.cpp: (WebKit::WebViewWndProc): Convert to String explicitly via UChar instead of implicitly via QChar.
9:59 PM Changeset in webkit [14273] by darin
  • 104 edits
    2 adds in trunk

LayoutTests:

  • fast/css/case-transform.html: Added.
  • fast/css/case-transform-expected.txt: Added.

WebCore:

Rubber stamped by Hyatt.

Test: fast/css/case-transform.html

By using ICU more, this fixes some bugs in a few places.

  • bindings/js/JSXMLSerializer.cpp:
  • css/css_valueimpl.h:
  • kwq/KWQTextStream.cpp:
  • loader/CachedObject.h:
  • platform/Color.cpp: Add includes of DeprecatedString.h as needed, now that StringImpl.h no longer includes it.
  • bindings/js/kjs_css.cpp: (KJS::cssPropertyName): Eliminate use of QChar::latin1() in a case where it's not helpful.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Use characters() function instead of the old unicode() function.
  • bindings/js/kjs_window.cpp: (KJS::isSeparator): Use UChar instead of QChar.
  • bindings/objc/DOMInternal.mm: (StringImpl::operator NSString*): Remove typecast that's no longer needed. (String::String): Ditto. Also use Vector for local buffer to make code read simpler.
  • bridge/mac/FrameMac.mm: (WebCore::selectorForKeyEvent): Remove call to unicode() function, no longer needed. (WebCore::FrameMac::setTitle): Remove QChar cast, no longer needed. (WebCore::FrameMac::setStatusBarText): Ditto. (WebCore::FrameMac::advanceToNextMisspelling): Use UChar instead of QChar. (WebCore::FrameMac::runJavaScriptAlert): Remove QChar cast, no longer needed. (WebCore::FrameMac::runJavaScriptConfirm): Ditto. (WebCore::FrameMac::runJavaScriptPrompt): Ditto. (WebCore::FrameMac::attributedString): Replaces calls of QChar::direction() with calls to u_charDirection and use ICU constants instead of QChar ones. (WebCore::FrameMac::markMisspellings): Remove QChar cast, no longer needed. Added a QChar cast so we can call isSpace -- slated to be removed later. (WebCore::FrameMac::shouldClose): Remove QChar cast, no longer needed.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectedString]): Remove QChar cast, no longer needed. (-[WebCoreFrameBridge stringForRange:]): Ditto.
  • css/CSSGrammar.y: Update for field name change from string to characters. Use UChar instead of unsigned short.
  • css/css_valueimpl.cpp: (WebCore::propertyID): Use UChar instead of unsigned short and get rid of call to unicode() function, no longer needed. (WebCore::quoteStringIfNeeded): Use strings when building up a resulting string, instead of depending on the feature where you can append characters to a string.
  • css/csshelper.cpp: (WebCore::parseURL): Remove calls to unicode() function and rewrite to obviate the need to call lower() just to check for a few constant character values. Also remove a now-unneeded type cast.
  • css/cssparser.h: Changed ParseString field to use UChar and to be named characters instead of string. Changed many other fields to be UChar instead of unsigned short. (WebCore::domString): Update for that. (WebCore::atomicString): Ditto.
  • css/cssparser.cpp: (WebCore::ParseString::lower): Use u_tolower instead of QChar::lower(). Also change name to characters from string. (WebCore::CSSParser::setupParser): Use UChar instead of unsigned short. (WebCore::CSSParser::lex): Ditto. Also update for characters name change. (WebCore::CSSParser::text): Use UChar instead of unsigned short. Also tweak some of the code a little bit to handle a couple of overflow cases better and reduce type casting. (WebCore::deprecatedString): Moved here so we don't have to include DeprecatedString.h in the header file.
  • css/cssstyleselector.cpp: (WebCore::checkPseudoState): Added a type cast since this code now bridges the world between modern code and QChar/DeprecatedString.
  • dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): Changed QChar to UChar.
  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::isValidName): Updated for name change from unicode to characters. (WebCore::Document::parseQualifiedName): Ditto. (WebCore::Document::backslashAsCurrencySymbol): Changed return type to UChar.
  • dom/NamedMappedAttrMap.cpp: (WebCore::isClassWhitespace): Changed parameter to UChar from QChar. (WebCore::NamedMappedAttrMap::parseClassAttribute): Changed from UChar to QChar and from unicode to characters.
  • dom/Position.cpp: (WebCore::Position::leadingWhitespacePosition): Changed from QChar to UChar. (WebCore::Position::trailingWhitespacePosition): Ditto.
  • dom/StyledElement.cpp: (WebCore::isClassWhitespace): Changed from QChar to UChar. (WebCore::StyledElement::addCSSLength): Changed from QChar to UChar, and remove one case where latin1() was used and was not helpful. (WebCore::StyledElement::addCSSColor): Removed unicode() function call, no longer needed.
  • dom/dom2_eventsimpl.cpp: (WebCore::KeyboardEvent::charCode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue): Removed unicode() function call, no longer needed.
  • dom/xml_tokenizer.h: Removed default parameter for xmlDocPtrForString so we don't have to include the DeprecatedString.h header in this file (and since no one uses it).
  • editing/HTMLInterchange.cpp: (convertHTMLTextToInterchangeFormat): Added a couple calls to the unicode() function to bridge the gap from QChar/DeprecatedString back to modern code.
  • editing/InsertTextCommand.cpp: Removed unused function.
  • editing/TextIterator.h: Changed from QChar to UChar.
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Initialize m_lastCharacter since it's now a UChar (which is just a typedef) rather than a QChar (which was a class with a default value of 0). (WebCore::TextIterator::handleTextNode): Updated to use characters() instead of unicode(). (WebCore::TextIterator::handleTextBox): Removed unicode() call since it's now a UChar instead of a QChar. (WebCore::TextIterator::emitCharacter): More of the same. (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto. (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto. (WebCore::CharacterIterator::string): Ditto. (WebCore::WordAwareIterator::advance): Ditto. (WebCore::WordAwareIterator::length): Ditto. (WebCore::WordAwareIterator::characters): Ditto. (WebCore::CircularSearchBuffer::CircularSearchBuffer): Changed to use UChar instead of QChar, but also to use foldCase() instead of lower(), because we want case folding here, not lowercasing. (WebCore::CircularSearchBuffer::append): Ditto, with u_foldCase. (WebCore::CircularSearchBuffer::isMatch): Ditto. (WebCore::plainText): Added type cast since this bridges the gap from the modern stuff to QChar/DeprecatedString.
  • editing/VisiblePosition.h: Changed from QChar to UChar.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Ditto.
  • editing/markup.cpp: (WebCore::escapeTextForMarkup): Changed code that used latin1() for no good reason to use unicode() instead.


  • html/HTMLTokenizer.h: Changed from QChar to UChar.
  • html/HTMLTokenizer.cpp: Changed from QChar to UChar, including removing the KHTML_ALLOC_QCHAR_VEC and KHTML_DELETE_QCHAR_VEC macros, which weren't being used consistently anyway. (WebCore::fixUpChar): More of the same. (WebCore::tagMatch): Ditto. (WebCore::HTMLTokenizer::reset): Ditto. (WebCore::HTMLTokenizer::begin): Ditto. Also corrected anomaly where buffer size was not the same as the size value -- this was only true in the initial allocation, so I believe there was no value in it. (WebCore::HTMLTokenizer::parseSpecial): Ditto. Also removed a use of latin1() that was unnnecessary extra work. (WebCore::HTMLTokenizer::scriptHandler): More of the same. (WebCore::HTMLTokenizer::parseComment): Ditto. (WebCore::HTMLTokenizer::parseServer): Ditto. (WebCore::HTMLTokenizer::parseProcessingInstruction): Ditto. Another unnecessary use of latin1() removed. (WebCore::HTMLTokenizer::parseText): Ditto. (WebCore::HTMLTokenizer::parseEntity): Ditto. Changed hex-parsing code to handle uppercase hex a more-efficient way than calling QChar::lower() on each character. Also changed surrogate code logic to fix a couple things -- reject character codes

    0x10FFFF as it should and use U16_LEAD and U16_TRAIL instead of writing our

    own versions of these. (WebCore::HTMLTokenizer::parseTag): Ditto. (WebCore::HTMLTokenizer::write): Ditto. (WebCore::HTMLTokenizer::end): Ditto. (WebCore::HTMLTokenizer::finish): Ditto. (WebCore::HTMLTokenizer::enlargeBuffer): Ditto. (WebCore::HTMLTokenizer::enlargeScriptBuffer): Ditto. (WebCore::HTMLTokenizer::notifyFinished): (WebCore::decodeNamedEntity): Ditto.
  • html/html_inlineimpl.cpp: (WebCore::parseFontSizeNumber): Changed from QChar to UChar, including using u_isdigit and u_charDigitValue instead of QChar::isNumber and QChar::digitValue. Also removed unneeded range checking that's already done by WebCore::String.
  • kwq/KWQLoader.mm: (KWQIsResponseURLEqualToURL): Rewrote to use Vector and UChar, removing all the type casts and making the whole function much shorter.
  • kwq/WebCoreAXObject.mm: (AXAttributedStringAppendText): Use UChar instead of QChar. (-[WebCoreAXObject doAXAttributedStringForTextMarkerRange:]): More of the same.
  • loader/Cache.h: Remove unnecessary default parameters, preventing the need to include the DeprecatedString.h header in this header. Cleaned up the header structure a bit, removing some obsolete and redundant comments and fixing typos.
  • loader/Cache.cpp: Removed unused preload functions.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): Added explicit arguments. This was the only caller anywhere that took advantage of the default parameter values in one of the Cache class request functions. (WebCore::Frame::backslashAsCurrencySymbol): Changed QChar to UChar.
  • platform/AtomicString.h: Changed QChar to UChar. Removed constructor that makes an AtomicString from a single character. Renamed unicode() function to characters(). Renamed KHTML_ATOMICSTRING_HIDE_GLOBALS to ATOMICSTRING_HIDE_GLOBALS.
  • platform/AtomicString.cpp: (WebCore::CStringTranslator::equal): Changed QChar to UChar. (WebCore::operator==): Changed unicode() to characters(). (WebCore::UCharBufferTranslator::hash): More of the same. (WebCore::UCharBufferTranslator::equal): Ditto. (WebCore::UCharBufferTranslator::translate): Ditto. (WebCore::AtomicString::add): Ditto. (WebCore::AtomicString::operator Identifier): Ditto. (WebCore::AtomicString::operator UString): Ditto. (WebCore::AtomicString::AtomicString): Moved here so we don't need DeprecatedString.h in the header. (WebCore::AtomicString::deprecatedString): Ditto.
  • platform/DeprecatedString.h: Removed QChar::Direction enum and all the DirXXX values, isDigit, isLetter, isNumber, isLetterOrNumber, isPunct, digitValue, and direction functions. (QChar::isSpace): Changed to use u_charDirection instead of QChar::direction.
  • platform/Font.h: (WebCore::Font::width): Changed QChar to UChar.
  • platform/Font.cpp: (WebCore::Font::width): Ditto.
  • platform/GraphicsContext.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): Changed QChar to UChar. Removed horizontalAlignment parameter from simplified string drawing entry point, since it's not used. (WebCore::GraphicsContext::drawHighlightForText): Changed QChar to UChar.
  • platform/PlatformString.h: Changed QChar to UChar. Removed constructor that makes a String from a single character. Renamed unicode() function to characters(). Added an append function and changed += operator to just call that. Added a foldCase() function. Removed the concatenation operators that add individual strings before or after.
  • platform/String.cpp: (WebCore::String::String): Changed QChar to UChar. (WebCore::String::append): Renamed from operator+= and removed the return value. (WebCore::String::operator[]): Changed QChar to UChar. (WebCore::String::foldCase): Added. (WebCore::String::percentage): More of the same. (WebCore::String::characters): Renamed from unicode(). (WebCore::String::deprecatedString): More of the same. (WebCore::String::sprintf): Fixed mistakes in the comments. (WebCore::String::isEmpty): Tweaked a bit. (WebCore::operator==): More of the same. (WebCore::String::operator Identifier): Ditto. (WebCore::String::operator UString): Ditto.
  • platform/SegmentedString.h: Changed from QChar to UChar. Had to initialize data members that are now UChar.
  • platform/SegmentedString.cpp: (WebCore::SegmentedString::length): Updated for change from QChar to UChar. (WebCore::SegmentedString::append): Ditto. (WebCore::SegmentedString::prepend): Ditto. (WebCore::SegmentedString::toString): Ditto.
  • platform/StringHash.h: Updated to use UChar instead of QChar and for name changes. Also changed to use case folding intead of lowercasing for case insensitive hashing.
  • platform/StringImpl.h:
  • platform/StringImpl.cpp: (WebCore::newUCharVector): Changed to UChar from QChar. (WebCore::deleteUCharVector): Ditto. (WebCore::StringImpl::StringImpl): Ditto. (WebCore::StringImpl::init): Ditto. Also renamed from initWithChar and initWithQChar. (WebCore::StringImpl::~StringImpl): Ditto. (WebCore::StringImpl::append): Ditto. (WebCore::StringImpl::insert): Ditto. (WebCore::StringImpl::truncate): Ditto. (WebCore::StringImpl::remove): Ditto. (WebCore::StringImpl::split): Ditto. (WebCore::StringImpl::containsOnlyWhitespace): Ditto. Also added comment because this function seems a little broken. (WebCore::parseLength): More of the same. (WebCore::StringImpl::toCoordsArray): Ditto. (WebCore::StringImpl::toLengthArray): Ditto. (WebCore::StringImpl::isLower): Ditto. (WebCore::StringImpl::lower): Rewrote to use u_strToLower. (WebCore::StringImpl::upper): Rewrote to use u_strToUpper. (WebCore::StringImpl::foldCase): Added. Uses u_strFoldCase. (WebCore::getWordBreakIterator): Changed to use U_FAILURE instead of accepting only U_ZERO_ERROR as a success code. (WebCore::StringImpl::capitalize): More QChar to UChar changes. (WebCore::StringImpl::toInt): Ditto. (WebCore::equal): Changed from QChar to UChar and was careful to preserve the old semantics where "high ASCII" is treated as U+0080-U+00FF even though I don't know if this feature is important. (WebCore::equalIgnoringCase): Ditto, but used case folding instead of lowercasing by using the u_foldCase and u_memcasecmp functions. Also renamed from equalCaseInsensitive for more-consistent naming. (WebCore::StringImpl::find): Ditto. Use case folding for the case insensitive branch. (WebCore::StringImpl::replace): More of the same. (WebCore::StringImpl::computeHash): Ditto. (WebCore::StringImpl::ascii): Ditto.
  • platform/TextBoundaries.h: Changed from QChar to UChar.
  • platform/mac/TextBoundaries.mm: (WebCore::findWordBoundary): Made the change to UChar and removed some type casts. (WebCore::findNextWordFromIndex): Ditto. (WebCore::findSentenceBoundary): Ditto. (WebCore::findNextSentenceFromIndex): Ditto.
  • platform/TextEncoding.h:
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::backslashAsCurrencySymbol): Changed from QChar to UChar. (WebCore::TextEncoding::fromUnicode): More of the same.
  • platform/mac/TextEncodingMac.cpp: (WebCore::TextEncoding::fromUnicode): More of the same.
  • platform/mac/FontFamilyMac.mm: (WebCore::FontFamily::getNSFamily): Removed a now-unneeded type cast.
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint): Changed QChar to UChar and removed some now-unneeded type casts.
  • editing/RebalanceWhitespaceCommand.cpp: (WebCore::isWhitespace):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::startWordBoundary): (WebCore::endWordBoundary): (WebCore::previousWordPositionBoundary): (WebCore::nextWordPositionBoundary): (WebCore::startSentenceBoundary): (WebCore::endSentenceBoundary): (WebCore::previousSentencePositionBoundary): (WebCore::nextSentencePositionBoundary): (WebCore::startOfParagraph): (WebCore::endOfParagraph):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::backslashAsCurrencySymbol):
  • rendering/RenderTreeAsText.cpp: (quoteAndEscapeNonPrintables):
  • rendering/break_lines.cpp: (WebCore::nextBreakablePosition):
  • rendering/break_lines.h: (WebCore::isBreakable):
  • rendering/render_style.h: (WebCore::RenderStyle::isCollapsibleWhiteSpace):
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
  • xml/xmlhttprequest.cpp: (WebCore::getMIMEType): (WebCore::getCharset): Changed QChar to UChar.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): Changed QChar to UChar. (WebCore::RenderImage::paint): Changed callers of drawText to no-longer pass 0 for the horizontal alignment, since I removed that parameters.
  • rendering/RenderText.h: Changed QChar to UChar.
  • rendering/RenderText.cpp: (WebCore::characterBreakIterator): Update for name change. (WebCore::RenderText::RenderText): Ditto. (WebCore::RenderText::allAscii): Remove uneeded unicode() and allow the value U+007F to count as ASCII. (WebCore::RenderText::cacheWidths): Changed QChar to UChar. (WebCore::RenderText::widthFromCache): Changed code that deals with direction to use the ICU direction calls. (WebCore::RenderText::trimmedMinMaxWidth): Changed QChar to UChar. (WebCore::RenderText::calcMinMaxWidth): Ditto. (WebCore::RenderText::containsOnlyWhitespace): Ditto. (WebCore::RenderText::setText): Ditto. (WebCore::RenderText::width): Ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement): Removed unneeded QChar cast. (WebCore::RenderTextField::calcMinMaxWidth): Changed from QChar to UChar.
  • rendering/bidi.h:
  • rendering/bidi.cpp: (WebCore::BidiIterator::BidiIterator): (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::current): (WebCore::BidiIterator::direction): (WebCore::addRun): (WebCore::checkMidpoints): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::tabWidth): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::skipWhitespace): (WebCore::RenderBlock::findNextLineBreak): (WebCore::RenderBlock::checkLinesForTextOverflow): Changed from QChar to UChar and all direction from QChar constants to the ones from ICU.
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::updateFromElement): (WebCore::RenderSelect::updateFromElement): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::text): (WebCore::RenderTextArea::textWithHardLineBreaks): Got rid of now-unneeded QChar type casts.
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Updated for change from QChar to UChar. (WebCore::EllipsisBox::paint): Updated for unicode() -> characters() name change.
  • rendering/render_list.cpp: (WebCore::toRoman): Updated from QChar to UChar. (WebCore::toLetterString): Ditto. (WebCore::toHebrew): More of the same, also cleaned up the logic a bit. (WebCore::RenderListMarker::paint): Removed the alignment parameters from the various functions. Also removed all reliance on the width-measuring functions that take a string. (WebCore::RenderListMarker::calcMinMaxWidth): More of the same. (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
9:08 PM Changeset in webkit [14272] by sfalken
  • 2 edits in trunk/WebKitTools

2006-05-10 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej.

Fix registry usage from perl script. Turns out libwin32's
SetRegValueEx, even for REG_DWORD, always takes its value as a string!


  • Scripts/install-win-extras:
8:00 PM Changeset in webkit [14271] by tomernic
  • 3 edits in trunk/WebCore

Reviewed by/co-written by Darin.

Performance improvement when drawing large numbers of animated images.

Instead of removing the "first" object from a set on each next(),
copy the clients into a vector once and keep track of the current index.

  • loader/CachedObjectClientWalker.h:
  • loader/CachedObjectClientWalker.cpp: (WebCore::CachedObjectClientWalker::CachedObjectClientWalker): (WebCore::CachedObjectClientWalker::next):
6:10 PM Changeset in webkit [14270] by lweintraub
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by justin.

<rdar:/problem/4442395>
Tiny MCE: Link isn't inserted after dragging into textarea field
Created tests to test drag-and-dropped links.


  • editing/pasteboard/drop-link-expected.checksum: Added.
  • editing/pasteboard/drop-link-expected.png: Added.
  • editing/pasteboard/drop-link-expected.txt: Added.
  • editing/pasteboard/drop-link.html: Added.

WebKit:

Reviewed by justin.

<rdar://problem/4442395>
Tiny MCE: Link isn't inserted after dragging into textarea field


  • WebView/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:chosePlainText:]): Modified to create an anchor object with a title as opposed to just the URL as text.
4:29 PM Changeset in webkit [14269] by sfalken
  • 2 edits in trunk/WebCore

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build. Added TextDocument.cpp to vcproj.


Reviewed by adele.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
3:54 PM Changeset in webkit [14268] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin.

<rdar://problem/4540011> Random crash occurs at when loading espn.go.com (khtml::RenderObject::PaintInfo&, int, int)


The crash occured because the document element was cached but later replaced by a script.
So the render object was accessing the old document element that no longer had a renderer.
When the document's children change we now invalidate the document element in case it is replaced.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::childrenChanged):
  • khtml/xml/dom_docimpl.h:
3:53 PM Changeset in webkit [14267] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderObject.cpp

Missed a dir.

2:57 PM Changeset in webkit [14266] by sfalken
  • 5 edits in trunk/WebKitTools

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.
Add load ended callback.


Reviewed by kevin.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Fix include paths
  • Scripts/build-webkit: Build WebKitWin instead of WebCore/JavaScriptCore (WebKitWin builds those indirectly).
  • Spinneret/Spinneret/Spinneret.cpp: (SpinneretWebHost::loadEnd): Add callback for loadEnd() to determine success/failure of page load. (_tWinMain): Load built-in test content here instead of in lower-level code.
  • Spinneret/Spinneret/Spinneret.h: Add loadEnd() callback.
2:56 PM Changeset in webkit [14265] by sfalken
  • 5 edits in trunk/WebKitWin

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Add host calback so caller can determine success/failure of a page load.


Reviewed by kevin.

  • WebFramePrivate.cpp: (WebKit::WebFramePrivate::loadFilePath): Style fix. (WebKit::WebFramePrivate::loadHTMLString): Style fix. (WebKit::WebFramePrivate::receivedAllData): Call host->loadEnd() with data indicating success/failure of load.
  • WebKitWin.vcproj/WebKitWin/WebKitWin.vcproj: Fix include paths.
  • WebView.cpp: (WebKit::WebView::WebView): Don't load boilerplate test HTML from core code.
  • public/WebHost.h: Add host callback for loadEnd().
2:54 PM Changeset in webkit [14264] by sfalken
  • 12 edits
    1 add in trunk/WebCore

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.
Add host calback so caller can determine success/failure of a page load.


Reviewed by kevin.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Fix paths, add missing files
  • loader/CachedResource.h: Fix include path.
  • loader/CachedResourceClientWalker.h: Fix include path.
  • platform/FontPlatformData.h: Fix include path.
  • platform/TransferJobClient.h: Make PlatformData, PlatformResponse an opaque struct.
  • platform/image-decoders/ImageDecoder.h: Fix include path.
  • platform/win/SharedTimerWin.cpp: Fix include path.
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): Add host callback for success/failure of load.
  • platform/win/TransferJobWin.h: Added. Windows version of PlatformData/PlatformResponse.
  • xpath/impl/XPathFunctions.cpp: Work around missing math functions in MSVC. (round): Work around missing math functions in MSVC.
  • xpath/impl/XPathPredicate.cpp: Work around missing math functions in MSVC.
  • xpath/impl/XPathValue.cpp: Work around missing math functions in MSVC.
2:50 PM Changeset in webkit [14263] by sfalken
  • 5 edits in trunk/JavaScriptCore

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.
Minor fixes to WTF headers.


Reviewed by kevin.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Fix include dirs, paths to files.
  • JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Fix include dirs.
  • wtf/Assertions.h: include Platform.h to get definition for COMPILER()
  • wtf/Vector.h: include FastMalloc.h for definition of fastMalloc, fastFree
2:49 PM Changeset in webkit [14262] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison.

<rdar://problem/4523432> safari crashed right after disabling "block pop up windows" (or
other WebPreferences changes)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]): When the plugin view is removed from both its window and its hostWindow, stop observing WebPreferences.
2:44 PM Changeset in webkit [14261] by hyatt
  • 10 edits in trunk/WebCore

Revert styleForElement, pseudoStyleForElement, styleForRenderer back to
their old names, since the term "create" is not accurate.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement):
  • css/cssstyleselector.h:
  • dom/Element.cpp: (WebCore::Element::styleForRenderer): (WebCore::Element::recalcStyle):
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::styleForRenderer):
  • dom/Node.h:
  • ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
2:15 PM Changeset in webkit [14260] by andersca
  • 4 edits in trunk/LayoutTests

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Hyatt.


  • http/tests/incremental/slow-utf8-text-expected.checksum:
  • http/tests/incremental/slow-utf8-text-expected.png:
  • http/tests/incremental/slow-utf8-text-expected.txt: Update tests now that we wrap plain text differently.
2:09 PM Changeset in webkit [14259] by andersca
  • 2 edits in trunk/WebCore

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write): Use the correct variable to prevent crashes.
12:03 PM Changeset in webkit [14258] by andersca
  • 14 edits
    2 adds
    4 deletes in trunk

WebCore:

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8808
WebCore should handle text files


  • WebCore.xcodeproj/project.pbxproj: Add TextDocument.cpp and TextDocument.h


  • bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge supportedMIMETypes]): Add text types here.


  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createTextDocument): (WebCore::DOMImplementation::isTextMIMEType):
  • dom/DOMImplementation.h: New functions for creating a TextDocument and determining if a mime type is a text MIME type.


  • loader/TextDocument.cpp: Added. (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write): (WebCore::TextTokenizer::finish): (WebCore::TextTokenizer::isWaitingForScripts): Special tokenizer which will put text inside a <pre> tag in a document.


(WebCore::TextDocument::TextDocument):
(WebCore::TextDocument::createTokenizer):
Create a TextTokenizer.


  • loader/TextDocument.h: Added.


  • page/Frame.cpp: (WebCore::Frame::begin): Create a TextDocument if the MIME type is of type text.

WebKit:

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8808
WebCore should handle text files

  • WebKit.exp: Remove WebTextView.


  • WebKit.xcodeproj/project.pbxproj: Get rid of WebTextView and WebTextRepresentation.


  • WebView/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
  • WebView/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
  • WebView/WebHTMLView.m: The text MIME types are now handled by WebHTMLView.


(+[WebHTMLView unsupportedTextMIMETypes]):
New function, moved here from WebTextView.


  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebTextRepresentation.h: Removed.
  • WebView/WebTextRepresentation.m: Removed.
  • WebView/WebTextView.h: Removed.
  • WebView/WebTextView.m: Removed.


  • WebView/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): Now special-case WebHTMLView instead of WebTextView for MIME types that shouldn't be shown.
2:32 AM Changeset in webkit [14257] by mjs
  • 4 edits in trunk

Fixed ChangeLog comments.

2:27 AM Changeset in webkit [14256] by mjs
  • 193 edits
    3 moves in trunk

JavaScriptCore:

Rubber stamped by Anders.


  • renamed kxmlcore to wtf


kxmlcore --> wtf
KXMLCore --> WTF
WKC --> WTF

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/c/c_instance.cpp:
  • bindings/objc/WebScriptObject.mm:
  • kjs/JSImmediate.h:
  • kjs/Parser.cpp:
  • kjs/Parser.h:
  • kjs/array_object.cpp:
  • kjs/collector.cpp: (KJS::Collector::registerThread):
  • kjs/collector.h:
  • kjs/config.h:
  • kjs/function.cpp: (KJS::isStrWhiteSpace):
  • kjs/function.h:
  • kjs/identifier.cpp:
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/lexer.cpp: (Lexer::shift): (Lexer::isWhiteSpace): (Lexer::isIdentStart): (Lexer::isIdentPart):
  • kjs/lookup.cpp:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/number_object.cpp:
  • kjs/object.h:
  • kjs/property_map.cpp:
  • kjs/property_map.h:
  • kjs/string_object.cpp: (StringProtoFunc::callAsFunction):
  • kjs/testkjs.cpp: (testIsInteger):
  • kjs/ustring.cpp:
  • kjs/ustring.h:
  • kxmlcore: Removed.
  • kxmlcore/AlwaysInline.h: Removed.
  • kxmlcore/Assertions.cpp: Removed.
  • kxmlcore/Assertions.h: Removed.
  • kxmlcore/FastMalloc.cpp: Removed.
  • kxmlcore/FastMalloc.h: Removed.
  • kxmlcore/FastMallocInternal.h: Removed.
  • kxmlcore/Forward.h: Removed.
  • kxmlcore/HashCountedSet.h: Removed.
  • kxmlcore/HashFunctions.h: Removed.
  • kxmlcore/HashMap.h: Removed.
  • kxmlcore/HashSet.h: Removed.
  • kxmlcore/HashTable.cpp: Removed.
  • kxmlcore/HashTable.h: Removed.
  • kxmlcore/HashTraits.h: Removed.
  • kxmlcore/ListRefPtr.h: Removed.
  • kxmlcore/Noncopyable.h: Removed.
  • kxmlcore/OwnArrayPtr.h: Removed.
  • kxmlcore/OwnPtr.h: Removed.
  • kxmlcore/PassRefPtr.h: Removed.
  • kxmlcore/Platform.h: Removed.
  • kxmlcore/RefPtr.h: Removed.
  • kxmlcore/TCPageMap.h: Removed.
  • kxmlcore/TCSpinLock.h: Removed.
  • kxmlcore/TCSystemAlloc.cpp: Removed.
  • kxmlcore/TCSystemAlloc.h: Removed.
  • kxmlcore/UnusedParam.h: Removed.
  • kxmlcore/Vector.h: Removed.
  • kxmlcore/VectorTraits.h: Removed.
  • kxmlcore/unicode: Removed.
  • kxmlcore/unicode/Unicode.h: Removed.
  • kxmlcore/unicode/UnicodeCategory.h: Removed.
  • kxmlcore/unicode/icu: Removed.
  • kxmlcore/unicode/icu/UnicodeIcu.h: Removed.
  • kxmlcore/unicode/posix: Removed.
  • kxmlcore/unicode/qt3: Removed.
  • kxmlcore/unicode/qt4: Removed.
  • kxmlcore/unicode/qt4/UnicodeQt4.h: Removed.
  • pcre/pcre_get.c:
  • wtf: Added.
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::Scavenge): (WTF::do_malloc): (WTF::do_free): (WTF::TCMallocGuard::TCMallocGuard): (WTF::malloc): (WTF::free): (WTF::calloc): (WTF::cfree): (WTF::realloc):
  • wtf/FastMalloc.h:
  • wtf/FastMallocInternal.h:
  • wtf/Forward.h:
  • wtf/HashCountedSet.h:
  • wtf/HashFunctions.h:
  • wtf/HashMap.h:
  • wtf/HashSet.h:
  • wtf/HashTable.cpp:
  • wtf/HashTable.h:
  • wtf/HashTraits.h:
  • wtf/ListRefPtr.h:
  • wtf/Noncopyable.h:
  • wtf/OwnArrayPtr.h:
  • wtf/OwnPtr.h:
  • wtf/PassRefPtr.h:
  • wtf/RefPtr.h:
  • wtf/TCSystemAlloc.cpp: (TCMalloc_SystemAlloc):
  • wtf/Vector.h:
  • wtf/VectorTraits.h:
  • wtf/unicode/UnicodeCategory.h:
  • wtf/unicode/icu/UnicodeIcu.h:

JavaScriptGlue:

Rubber stamped by Anders.


  • renamed kxmlcore to wtf


kxmlcore --> wtf
KXMLCore --> WTF
WKC --> WTF

  • config.h:
  • kxmlcore: Removed.
  • kxmlcore/AlwaysInline.h: Removed.
  • kxmlcore/Assertions.h: Removed.
  • kxmlcore/FastMalloc.h: Removed.
  • kxmlcore/Forward.h: Removed.
  • kxmlcore/HashCountedSet.h: Removed.
  • kxmlcore/HashSet.h: Removed.
  • kxmlcore/Noncopyable.h: Removed.
  • kxmlcore/OwnArrayPtr.h: Removed.
  • kxmlcore/OwnPtr.h: Removed.
  • kxmlcore/PassRefPtr.h: Removed.
  • kxmlcore/Platform.h: Removed.
  • kxmlcore/RefPtr.h: Removed.
  • kxmlcore/Vector.h: Removed.
  • wtf: Added.

WebCore:

Rubber stamped by Anders.


  • renamed kxmlcore to wtf


kxmlcore --> wtf
KXMLCore --> WTF
WKC --> WTF

  • ForwardingHeaders/kxmlcore: Removed.
  • ForwardingHeaders/kxmlcore/AlwaysInline.h: Removed.
  • ForwardingHeaders/kxmlcore/Assertions.h: Removed.
  • ForwardingHeaders/kxmlcore/FastMalloc.h: Removed.
  • ForwardingHeaders/kxmlcore/Forward.h: Removed.
  • ForwardingHeaders/kxmlcore/HashCountedSet.h: Removed.
  • ForwardingHeaders/kxmlcore/HashMap.h: Removed.
  • ForwardingHeaders/kxmlcore/HashSet.h: Removed.
  • ForwardingHeaders/kxmlcore/HashTraits.h: Removed.
  • ForwardingHeaders/kxmlcore/Noncopyable.h: Removed.
  • ForwardingHeaders/kxmlcore/OwnArrayPtr.h: Removed.
  • ForwardingHeaders/kxmlcore/OwnPtr.h: Removed.
  • ForwardingHeaders/kxmlcore/PassRefPtr.h: Removed.
  • ForwardingHeaders/kxmlcore/Platform.h: Removed.
  • ForwardingHeaders/kxmlcore/RefPtr.h: Removed.
  • ForwardingHeaders/kxmlcore/Vector.h: Removed.
  • ForwardingHeaders/wtf: Added.
  • bindings/js/JSHTMLElementWrapperFactory.h:
  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_window.h:
  • bindings/objc/DOMImplementationFront.h:
  • bridge/JavaAppletWidget.h:
  • bridge/mac/WebCoreFrameNamespaces.mm:
  • bridge/mac/WebCorePageBridge.mm: (initializeLogChannel):
  • bridge/mac/WebCoreStringTruncator.mm:
  • bridge/mac/WebCoreViewFactory.m:
  • config.h:
  • css/css_base.h:
  • css/css_valueimpl.h:
  • css/csshelper.cpp:
  • css/cssparser.h:
  • dom/DOMImplementation.h:
  • dom/Document.h:
  • dom/NamedNodeMap.h:
  • dom/Node.h:
  • dom/NodeList.h:
  • dom/QualifiedName.cpp:
  • dom/Range.h:
  • dom/StyledElement.cpp:
  • dom/dom2_traversalimpl.h:
  • dom/xml_tokenizer.h:
  • editing/RebalanceWhitespaceCommand.cpp:
  • editing/RemoveCSSPropertyCommand.cpp:
  • editing/RemoveNodeAttributeCommand.cpp:
  • editing/RemoveNodeCommand.cpp:
  • editing/RemoveNodePreservingChildrenCommand.cpp:
  • editing/ReplaceSelectionCommand.h:
  • editing/Selection.cpp:
  • editing/SetNodeAttributeCommand.cpp:
  • editing/SplitElementCommand.cpp:
  • editing/SplitTextNodeCommand.cpp:
  • editing/SplitTextNodeContainingElementCommand.cpp:
  • editing/TextIterator.h:
  • editing/htmlediting.h:
  • editing/markup.h:
  • html/CanvasGradient.h:
  • html/CanvasRenderingContext2D.h:
  • html/CanvasStyle.cpp:
  • html/HTMLCollection.h:
  • html/HTMLElementFactory.h:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasPath.h:
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/RenderSVGText.cpp:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KSVGTimeScheduler.h:
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/scripts/make_names.pl:
  • ksvg2/svg/SVGDOMImplementation.cpp:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • ksvg2/svg/SVGForeignObjectElement.cpp:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGTests.h:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformable.cpp:
  • kwq/AccessibilityObjectCache.h:
  • kwq/KWQCString.cpp:
  • kwq/KWQFormData.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQResourceLoader.mm:
  • kwq/KWQTextEdit.mm:
  • loader/Cache.h:
  • loader/CachedObject.h:
  • loader/CachedObjectClientWalker.h:
  • loader/Decoder.h:
  • loader/DocLoader.h:
  • loader/loader.cpp:
  • loader/loader.h:
  • page/DOMWindow.h:
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTree.cpp:
  • page/Page.cpp:
  • page/Page.h:
  • page/Plugin.h:
  • platform/Arena.cpp:
  • platform/ArrayImpl.h:
  • platform/AtomicString.cpp:
  • platform/CharsetNames.cpp:
  • platform/Color.cpp:
  • platform/DeprecatedPtrListImpl.cpp:
  • platform/DeprecatedValueListImpl.h:
  • platform/FontFallbackList.h:
  • platform/GraphicsContext.h:
  • platform/GraphicsTypes.cpp:
  • platform/Image.h:
  • platform/KURL.cpp:
  • platform/Logging.cpp:
  • platform/Logging.h:
  • platform/PlatformString.h:
  • platform/PlugInInfoStore.h:
  • platform/StreamingTextDecoder.cpp:
  • platform/StreamingTextDecoder.h:
  • platform/String.cpp:
  • platform/StringHash.h:
  • platform/StringImpl.cpp:
  • platform/StringImpl.h:
  • platform/TextEncoding.cpp:
  • platform/Timer.cpp:
  • platform/Timer.h:
  • platform/TransferJob.h:
  • platform/TransferJobInternal.h:
  • platform/mac/BlockExceptions.mm:
  • platform/mac/ColorMac.mm:
  • platform/mac/FontData.mm:
  • platform/mac/KURLMac.mm:
  • platform/mac/QStringMac.mm:
  • platform/mac/SharedTimerMac.cpp:
  • platform/mac/TextEncodingMac.cpp:
  • platform/mac/WebCoreImageRendererFactory.m:
  • platform/mac/WebCoreKeyGenerator.m:
  • platform/mac/WebCoreTextArea.mm:
  • platform/mac/WebCoreTextField.mm:
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm:
  • platform/win/TemporaryLinkStubs.cpp: (JavaAppletWidget::JavaAppletWidget):
  • rendering/InlineTextBox.cpp:
  • rendering/RenderText.cpp:
  • rendering/RenderTreeAsText.cpp:
  • rendering/bidi.cpp:
  • xml/XSLTProcessor.h:
  • xpath/impl/XPathExpressionNode.h:
  • xpath/impl/XPathParser.h:
  • xpath/impl/XPathPath.h:
  • xpath/impl/XPathUtil.h:

WebKit:

Rubber stamped by Anders.


  • renamed kxmlcore to wtf


kxmlcore --> wtf
KXMLCore --> WTF
WKC --> WTF

  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m: (initializeLogChannel):
1:35 AM Changeset in webkit [14255] by mjs
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

  • Scripts/extract-localizable-strings: Update for correct names of log macros.
1:19 AM Changeset in webkit [14254] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8803
XPath query for empty attributes crashes in XPath::StringExpression::StringExpression


  • xpath/impl/XPathParser.cpp: (WebCore::XPath::Parser::lexString): Make sure an empty string is returned instead of a null string.


(WebCore::XPath::Parser::lex):
Only assign the string if it isn't null.

LayoutTests:

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8803
XPath query for empty attributes crashes in XPath::StringExpression::StringExpression


  • xpath/impl/XPathParser.cpp: (WebCore::XPath::Parser::lexString): Make sure an empty string is returned instead of a null string.


(WebCore::XPath::Parser::lex):
Only assign the string if it isn't null.

1:03 AM Changeset in webkit [14253] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix the ICU code path, too (currently unused on the Mac).

  • platform/TextEncoding.cpp: (WebCore::TextEncoding::fromUnicode): Normalize the string.
12:47 AM Changeset in webkit [14252] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Anders.

Bug 8804: Inspector should support searching by Xpath query
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8804

12:23 AM Changeset in webkit [14251] by mjs
  • 19 edits
    5 copies in trunk

WebCore:

Reviewed by Tim Hatcher.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • loader/Cache.cpp: (WebCore::Cache::updateCacheStatus): (WebCore::Cache::requestImage): (WebCore::Cache::requestStyleSheet): (WebCore::Cache::requestScript): (WebCore::Cache::requestXSLStyleSheet): (WebCore::Cache::requestXBLDocument):
  • loader/Cache.h:
  • loader/CachedResource.cpp: Added.
  • loader/CachedResource.h: Added.
  • loader/CachedResourceClient.h: Added.
  • loader/CachedResourceClientWalker.cpp: Added.
  • loader/CachedResourceClientWalker.h: Added.
  • loader/DocLoader.cpp: (WebCore::DocLoader::setAutoloadImages): (WebCore::DocLoader::removeCachedObject):
  • loader/DocLoader.h: (WebCore::DocLoader::cachedObject): (WebCore::DocLoader::allCachedObjects):

WebKit:

Reviewed by Tim Hatcher.


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]):
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource _archivedSubresourceForURL:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource subresources]): (-[WebDataSource subresourceForURL:]): (-[WebDataSource addSubresource:]):
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m:
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m: (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol didFinishLoading]):
  • WebView/WebUnarchivingState.h:
  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState addResource:]):
Note: See TracTimeline for information about the timeline view.