⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 11, 2006:

9:51 PM Changeset in webkit [14320] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

Test: fast/loader/url-strip-cr-lf-tab.html

  • platform/KURL.cpp: (appendEscapingBadChars): Strip CR, LF and TAB, as Firefox and IE do.
9:43 PM Changeset in webkit [14319] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

Bug 8856: Web Inspector should show the Xpath for the selected node
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8856


Adds an Xpath area to the Node panel.

5:23 PM Changeset in webkit [14318] by hyatt
  • 10 edits in trunk/WebCore

Remove the misspelling drawing code from Font and FontData. Implement it
natively in GraphicContext instead.

Reviewed by maciej

  • platform/FontData.h:
  • platform/GraphicsContext.cpp:
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/win/FontWin.cpp:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingMarker):
5:04 PM Changeset in webkit [14317] by hyatt
  • 12 edits in trunk/WebCore

Remove drawLineForText from the Font API. Implement it natively in
the two GraphicsContexts (CG and Cairo) instead.

Reviewed by maciej

  • platform/Font.h:
  • platform/FontData.h:
  • platform/GraphicsContext.cpp:
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm:
  • platform/win/FontWin.cpp: (WebCore::Font::drawLineForText):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintDecorations):
4:57 PM Changeset in webkit [14316] by bdakin
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4539954> 10.4.7 regression:DHTML menu
closes prematurely when hovering over it at ​http://
www.shopping.hp.com/

This fix already exists on TOT, though I am not sure when it was
checked in, nor am I aure what in particular caused this regression
on the branch. Whatever the cause of the badness, though, we need
to take borderTopExtra() and borderBottomExtra() into consideration
when hitTesting the background of a RenderBlock.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::nodeAtPoint):
4:55 PM Changeset in webkit [14315] by sfalken
  • 2 edits in trunk/WebCore

2006-05-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

Fix last fix.

  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName):
4:31 PM Changeset in webkit [14314] by sfalken
  • 2 edits in trunk/WebCore

2006-05-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

Fix crash on static constructors builds at exit due to qualified name default constructor not
initializing m_impl.

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::deref):
4:24 PM Changeset in webkit [14313] by hyatt
  • 4 edits in trunk/WebCore

Reviewed by hyatt

Already covered by several tests in fast/text

  • platform/Font.h: (WebCore::TextRun::TextRun): Added length parameter.
  • rendering/InlineTextBox.cpp: Pass the length to the TextRun constructor. (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): Pass length and from instead of from and to to the TextRun constructor. (WebCore::RenderText::width): Ditto.
3:45 PM Changeset in webkit [14312] by harrison
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin.


<rdar://problem/4543847> 10.4.7 regression: Mail: selecting the bottom of a message and deleting it leaves a stray newline


Merged most of the DeleteSelectionCommand parts of r14143.

  • khtml/editing/htmlediting.cpp: (DeleteSelectionCommand::initializePositionData): Removed erroneous check that disabled merging based on paragraph boundaries.


(DeleteSelectionCommand::mergeParagraphs):
Return early if upstreamStart and downstreamEnd are flipped, or startblock == endblock.

3:31 PM Changeset in webkit [14311] by hyatt
  • 2 edits in trunk/WebCore

Fix a regression from the TextRun landing. Delete the characters in
the adjustedRun, not the ones in the original run!

Reviewed by beth

  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText):
3:21 PM Changeset in webkit [14310] by justing
  • 18 edits in trunk

LayoutTests:

Reviewed by thatcher, levi


Inserting an <hr> into <div>foobar</div> now produces
<div>foo</div><hr><div>bar</div>, instead of <div>foo<hr>bar</div>,
which means that removing an inserted <hr> programmatically from
javascript produces a different visual result than before (the
new result is arguably more correct):

  • editing/execCommand/insertHorizontalRule.html:
  • editing/execCommand/insertHorizontalRule-expected.checksum:
  • editing/execCommand/insertHorizontalRule-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.txt:


Equivalent render trees or changes in the editing delegate
notifications that reflect the fact that we are doing an end
merge more often:

  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:

WebCore:

Reviewed by thatcher, levi

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed a use fragment.hasMoreThanOneBlock to decide if the paragraph containing the position pasted into must be split to avoid block nesting. We now split unnecessarily some times, but the end merge cleans up for us.
3:20 PM Changeset in webkit [14309] by hyatt
  • 3 edits in trunk/LayoutTests/tables/mozilla_expected_failures/bugs

More 8060 layout test fun.

3:18 PM Changeset in webkit [14308] by hyatt
  • 3 edits in trunk/LayoutTests/tables/mozilla/bugs

More 8060 layout test fun.

3:03 PM Changeset in webkit [14307] by hyatt
  • 3 edits in trunk/LayoutTests/fast/text/international

Fix bidi line break layout test to account for bug 8060.

3:02 PM Changeset in webkit [14306] by hyatt
  • 3 edits in trunk/LayoutTests/fast/block/margin-collapse

Fix margin-collapsing layout test to account for bug 8060.

3:01 PM Changeset in webkit [14305] by hyatt
  • 3 edits in trunk/LayoutTests/fast/block/float

Fix float layout test to account for bug 8060.

2:56 PM Changeset in webkit [14304] by hyatt
  • 11 edits in trunk/WebCore

This patch makes drawHighlightForText a completely cross-platform method
implemented by the GraphicsContext. The platform-specific implementations
of the method in the Font class have been eliminated.

Reviewed by andersca

  • platform/Font.h:
  • platform/FontData.h: Remove the drawHighlight methods. Change the selectionRect method in Font to return a FloatRect so that the GraphicsContext can do an accurate fill.
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawHighlightForText): Implement the drawHighlightFunction in terms of the cross-platform Font selectionRect functions and a new float-based fillRect graphics context function.
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): Add the new float-based fillRect function for Cairo and CG.
  • platform/mac/FontData.mm: (WebCore::CG_draw): (WebCore::ATSU_draw): Removed the CG and ATSU drawHighlight methods. Remove the drawing of the background from the deprecated draw methods (they'll be removed soon).
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForText):
  • platform/win/FontWin.cpp: (WebCore::Font::selectionRectForText): Change selectionRectForText to return a FloatRect instead of an IntRect, so that the GraphicsContext can do a precise fill.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::positionForOffset): Modify the callers who expect an int-based selection rect so that they call enclosingIntRect.
12:05 PM Changeset in webkit [14303] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Anders.

Fixes <rdar://problem/4411845> lots of SPOD trying to scroll through
Markup & Content inspecting body at apple.com (6614)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6614

Removed the Markup & Content pane when viewing a element.
This pane was not that useful and made the inspector really slow
when the markup was large. Only show this pane for text nodes.

11:34 AM Changeset in webkit [14302] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Timothy.

Patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8810>
Bug 8810: Scrollbars in WebInspector rendered incorrectly

  • WebInspector/webInspector/inspector.css: Make scroll bars absolutely positioned.
10:47 AM Changeset in webkit [14301] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

  • fast/forms/double-focus-expected.txt: Added.
  • fast/forms/double-focus.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/double-focus.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Changed to only call setFocusNode, select, and revealSelection if the element is not already focused. Also changed to use return a bit more rather than else.
10:44 AM Changeset in webkit [14300] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebKit/Misc.subproj/WebNSWindowExtras.m

Build fix.

10:23 AM Changeset in webkit [14299] by darin
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher (earlier version).

  • bindings/scripts/IDLParser.pm: Invoke the preprocessor via the "gcc" driver script, passing "-E" so we only preprocess, "-P" so we don't get "#line" directives, and "-x c++" so we handle both C and C++ comments. Removed the code to eliminate comments since the preprocessor handles that.
  • css/make-css-file-arrays.pl: This already invoked the preprocessor, but updated it to do the same way as above.
4:38 AM Changeset in webkit [14298] by andersca
  • 14 edits
    3 adds in trunk

WebCore:

2006-05-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7838
Add support for mozilla-style node constructors as properties of the window object


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj: Add new generated files.


  • bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction):
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSWrapper): Specify the KJS namespace for JSHTMLElmement.


  • bindings/js/kjs_dom.cpp: (KJS::toJS): Create a WebCore::JSHTMLDocument for document nodes. Also, create JSDocumentFragments for document fragments (instead of plain node objects).


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocumentProtoFunc::callAsFunction): (KJS::JSHTMLDocument::JSHTMLDocument): (KJS::JSHTMLDocument::getOwnPropertySlot): Add a prototype for JSHTMLDocument and move all functions there.


(KJS::JSHTMLElement::JSHTMLElement):
(KJS::JSHTMLElement::getOwnPropertySlot):
Update since JSHTMLElement now inherits from WebCore::JSHTMLElement.


(KJS::JSHTMLElement::getValueProperty):
(KJS::JSHTMLElement::putValueProperty):
Remove title setter and getter. Those are autogenerated now.


  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Inherit from WebCore::JSHTMLElement. Clarify the inheritance chain.


  • bindings/scripts/CodeGeneratorJS.pm: Always generate a prototype object, regardless of whether the object has any functions or constants.


Use the type of generator attributes to determine what constructor to use. This is useful for
the XMLDocument property in DOMWindow.idl, since that's just an alias for the Document constructor.


  • dom/DocumentFragment.idl: Added.
  • html/HTMLDocument.idl: Added.
  • html/HTMLElement.idl: Added.


  • page/DOMWindow.idl: Add constructors for DocumentFragment, HTMLElement, HTMLDocument and XMLDocument. XMLDocument is just an alias for the Document constructor.


LayoutTests:

2006-05-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7838
Add support for mozilla-style node constructors as properties of the window object

  • fast/dom/prototype-chain-expected.txt: Update prototype chains.
  • fast/dom/global-constructors-expected.txt:
  • fast/dom/global-constructors.html: Test new constructor objects.
3:19 AM Changeset in webkit [14297] by hyatt
  • 16 edits in trunk/WebCore

Bug 8845. Define a TextRun (similar to the old WebCoreTextRun) and
make it the new API for Font and GraphicsContext when drawing/measuring
text.

Reviewed by andersca

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks): (WebCore::Font::width): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h: (WebCore::TextRun::m_to): (WebCore::TextRun::operator[]): (WebCore::TextRun::data): (WebCore::TextRun::adjustFrom): (WebCore::TextRun::adjustTo): (WebCore::TextRun::characters): (WebCore::TextRun::length): (WebCore::TextRun::from): (WebCore::TextRun::to):
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForText): (WebCore::Font::drawComplexText): (WebCore::Font::drawHighlightForText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::checkSelectionPoint):
  • platform/win/FontWin.cpp: (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::selectionRectForText): (WebCore::Font::checkSelectionPoint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
  • rendering/RenderText.cpp: (WebCore::RenderText::cacheWidths): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/bidi.cpp: (WebCore::RenderBlock::tabWidth): (WebCore::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_line.cpp: (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::getRelativeMarkerRect):

May 10, 2006:

10:32 PM Changeset in webkit [14296] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-10 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

  • Misc.subproj/WebNSWindowExtras.h:
  • Misc.subproj/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Overrides certain NSWindow methods so that window autodisplay can be throttled to 60Hz.

(disableWindowDisplayThrottleApplierFunction):
CFDictionary applier function for when the throttle is disabled. Cancels all pending window displays,
and calls -displayIfNeeded on each window with a pending display.

(+[NSWindow _webkit_disableWindowDisplayThrottle]):
Restores default NSWindow method implementations and clears pending window displays.

(swizzleInstanceMethod):
Helper function to swizzle ObjC method implementations.

(replacementPostWindowNeedsDisplay):
Don't call into -[NSWindow _postWindowNeedsDisplay] if requestWindowDisplay() returns NO (this is the
function that throttles display).

(replacementClose):
Clean up the WindowDisplayInfo struct for the window, since it's about to go away.

(getWindowDisplayInfo):
Gets the WindowDisplayInfo struct for the window, or creates it if absent.

(requestWindowDisplay):
Returns YES if a display is allowed right now. Returns NO otherwise, and schedules a timer to try the
display again.

(cancelPendingWindowDisplay):
Cancels the pending display for the window, if any.

(-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]):
Try to call _postWindowNeedsDisplay again.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView initWithFrame:]): If the secret "WebKitThrottleWindowDisplay" default is set, then enable the NSWindow throttle.
7:52 PM Changeset in webkit [14295] by justing
  • 1 edit in trunk/WebCore/ChangeLog

Fixed my incorrect wording.

6:26 PM Changeset in webkit [14294] by justing
  • 16 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

Fixed a select-after-replacement problem:

  • editing/pasteboard/drag-drop-modifies-page-expected.checksum:
  • editing/pasteboard/drag-drop-modifies-page-expected.png:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt:


The trailing interchange newline used to be lost:

  • editing/pasteboard/paste-text-012-expected.checksum:
  • editing/pasteboard/paste-text-012-expected.png:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-012.html:
  • editing/pasteboard/paste-text-016-expected.checksum:
  • editing/pasteboard/paste-text-016-expected.png:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.checksum:
  • editing/pasteboard/paste-text-017-expected.png:
  • editing/pasteboard/paste-text-017-expected.txt:


Illustrates the bug fixed in smart replace whitespace handling:

  • editing/pasteboard/smart-paste-008.html
  • editing/pasteboard/smart-paste-008-expected.txt
  • editing/pasteboard/smart-paste-008-expected.png
  • editing/pasteboard/smart-paste-008-expected.checksum

WebCore:

Reviewed by darin

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed the code to find out if we must later add smart replace whitespace. We can wait until we've done the insertion to figure it out, and the position sampled (startPos) to make the decision about trailing whitespace was wrong. Changed the order that work is done during a paste: 1) Insert everything 2) Do one of the following: a) handle a trailing interchange newline, b) uncollapse the last incoming br if it has been collapsed because of quirks mode, c) do an end merge 3) Add smart replace whitespace (2 and 3 were reversed because the end merge must happen before we can know whether or not we need to add a trailing space). Don't do an end merge if the last node inserted was a br because the end merge will clobber it.


(WebCore::ReplaceSelectionCommand::removeEndBRIfNeeded):
brs that are at the end of a block and not at the start of a block are not the one brs
that are collapsed because of quirks mode.

6:04 PM Changeset in webkit [14293] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Overrides certain NSWindow methods so that window autodisplay can be throttled to 60Hz.

(disableWindowDisplayThrottleApplierFunction):
CFDictionary applier function for when the throttle is disabled. Cancels all pending window displays,
and calls -displayIfNeeded on each window with a pending display.

(+[NSWindow _webkit_disableWindowDisplayThrottle]):
Restores default NSWindow method implementations and clears pending window displays.

(swizzleInstanceMethod):
Helper function to swizzle ObjC method implementations.

(replacementPostWindowNeedsDisplay):
Don't call into -[NSWindow _postWindowNeedsDisplay] if requestWindowDisplay() returns NO (this is the
function that throttles display).

(replacementClose):
Clean up the WindowDisplayInfo struct for the window, since it's about to go away.

(getWindowDisplayInfo):
Gets the WindowDisplayInfo struct for the window, or creates it if absent.

(requestWindowDisplay):
Returns YES if a display is allowed right now. Returns NO otherwise, and schedules a timer to try the
display again.

(cancelPendingWindowDisplay):
Cancels the pending display for the window, if any.

(-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]):
Try to call _postWindowNeedsDisplay again.

  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): If the secret "WebKitThrottleWindowDisplay" default is set, then enable the NSWindow throttle.
2:08 PM Changeset in webkit [14292] by hyatt
  • 5 edits in trunk/WebCore

Rename isSpace to treatAsSpace. Move it and the rounding hack function into
Font and make them static methods (inlined in the header). Make the rounding
hack character table a static member as well. Remove the redundant space/rounding
functions from FontData.mm.

Reviewed by darin

  • platform/Font.cpp: (WebCore::): (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance):
  • platform/Font.h: (WebCore::Font::treatAsSpace): (WebCore::Font::isRoundingHackCharacter):
  • platform/mac/FontData.mm: (WebCore::overrideLayoutOperation): (WebCore::createATSULayoutParameters): (WebCore::initializeWidthIterator): (WebCore::advanceWidthIterator):
  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize):
1:49 PM Changeset in webkit [14291] by darin
  • 1 edit
    1 delete in trunk/WebCore
  • WebCore: Removed an extra WebCore subtree that somehow got checked in.
1:27 PM Changeset in webkit [14290] by hyatt
  • 1 edit in trunk/WebCore/platform/Font.cpp

Fix typo from the removal of the inline keyword from some functions.

11:59 AM Changeset in webkit [14289] by thatcher
  • 1 copy in tags/WebCore-418.3/WebCore

Tag for WebCore 418.3 (part 2 of 2.)

11:59 AM Changeset in webkit [14288] by thatcher
  • 1 add in tags/WebCore-418.3

Tag for WebCore 418.3 (part 1 of 2.)

11:55 AM Changeset in webkit [14287] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

11:09 AM Changeset in webkit [14286] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Darin, landed by Timothy.

  • platform/Font.cpp: (WebCore::isSpace):
  • platform/mac/FontData.mm: (WebCore::widthForGlyph): (WebCore::isRoundingHackCharacter): (WebCore::glyphForCharacter):
10:28 AM Changeset in webkit [14285] by ap
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by Anders.

The problem itself was fixed by Anders in bug 8808 (WebCore should handle text files).

  • http/tests/misc/resources: Added.
  • http/tests/misc/resources/200.html: Added.
  • http/tests/misc/resources/text-refresh.pl: Added.
  • http/tests/misc/text-refresh-expected.txt: Added.
  • http/tests/misc/text-refresh.html: Added.
8:11 AM Changeset in webkit [14284] by andersca
  • 2 edits in trunk/WebCore

2006-05-10 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.

Already covered by several pixel tests in fast/text

  • platform/Font.cpp: (WebCore::Font::drawSimpleText):
1:49 AM Changeset in webkit [14283] by hyatt
  • 8 edits
    1 add in trunk/WebCore

Fix for bug 8809, lift the Mac-specific WebTextRenderer code for
drawing and measuring of runs up into the Font class. The fast code
path is in Font.cpp and is designed to be mostly cross-platform. The
slow code path is in FontMac.cpp and is Mac-specific.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::isSpace): (WebCore::): (WebCore::isRoundingHackCharacter): (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks): (WebCore::Font::primaryFont): (WebCore::Font::setAlwaysUseComplexPath): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h:
  • platform/FontData.h: (WebCore::FontData::platformData):
  • platform/GlyphBuffer.h: Added. (WebCore::GlyphBuffer::GlyphBuffer): (WebCore::GlyphBuffer::isEmpty): (WebCore::GlyphBuffer::size): (WebCore::GlyphBuffer::glyphs): (WebCore::GlyphBuffer::advances): (WebCore::GlyphBuffer::fontDataAt): (WebCore::GlyphBuffer::swap): (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
  • platform/mac/FontData.mm: (WebCore::isSpace): (WebCore::isRoundingHackCharacter): (WebCore::FontData::widthForGlyph): (WebCore::m_ATSUMirrors): (WebCore::FontData::xHeight): (WebCore::FontData::smallCapsFontData): (WebCore::findSubstituteFont): (WebCore::rendererForAlternateFont): (WebCore::findSubstituteRenderer): (WebCore::FontData::findSubstituteFontData): (WebCore::computeWidthForSpace): (WebCore::FontData::updateGlyphMapEntry): (WebCore::extendGlyphMap): (WebCore::extendWidthMap): (WebCore::createATSULayoutParameters): (WebCore::FontData::glyphForCharacter): (WebCore::advanceWidthIterator): (WebCore::shouldUseATSU):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::m_padPerSpace): (WebCore::addDirectionalOverride): (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::disposeATSULayoutParameters): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUseATSU):
1:18 AM Changeset in webkit [14282] by andersca
  • 2 edits in trunk/WebKit

2006-05-10 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

  • WebView/WebHTMLView.m: (+[WebHTMLView unsupportedTextMIMETypes]): Add text/rtf
12:20 AM Changeset in webkit [14281] by darin
  • 1 edit
    1 add in trunk/WebCore
  • another try at fixing the Windows build
  • platform/win/FontWin.cpp: (WebCore::getFontData): Use characters() instead of unicode().
12:19 AM Changeset in webkit [14280] by darin
  • 2 edits
    1 move in trunk/WebCore

Cut change log.

12:12 AM Changeset in webkit [14279] by darin
  • 2 edits in trunk/WebCore

Reviewed, tweaked, and landed by Darin.

Optimization of [DOMNode _nodeWith:] to look up the obj-c wrapperClass
for each HTMLElement using a HashMap instead of by repeated calls to
htmlElt->hasLocalName(someTag).

  • bindings/objc/DOM.mm: (addElementClass): Added. (createHTMLElementClassMap): (elementClass): (+[DOMNode _nodeWith:]): Added code to call elementClass.
Note: See TracTimeline for information about the timeline view.