⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 14, 2006:

11:59 PM Changeset in webkit [14374] by andersca
  • 2 edits in trunk/WebCore

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

9:57 PM Changeset in webkit [14373] by hyatt
  • 246 edits in trunk/LayoutTests/svg/W3C-SVG-1.1

Update svg layout tests.

9:42 PM Changeset in webkit [14372] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/repaint/table-collapsed-border-expected.checksum: Added.
  • fast/repaint/table-collapsed-border-expected.png: Added.
  • fast/repaint/table-collapsed-border-expected.txt: Added.
  • fast/repaint/table-collapsed-border.html: Added.

WebCore:

Reviewed by Hyatt.


This patch updates the implementation of collapsing borders to match
the current spec.

Test: fast/repaint/table-collapsed-border.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::layout): Calculate horizontal overflows. (WebCore::RenderTable::calcMinMaxWidth): Added call to recalcHorizontalBorders. (WebCore::RenderTable::colElement): Made const. (WebCore::RenderTable::calcBorderLeft): Calculates the left border. In the collapsing borders model, this is the left border of the leftmost cell of the first row. (WebCore::RenderTable::calcBorderRight): Ditto for the right border. (WebCore::RenderTable::recalcHorizontalBorders): Added. (WebCore::RenderTable::borderTop): Changed to return outerBorderTop in the collapsing case. (WebCore::RenderTable::borderBottom): Changed to return outerBorderBottom in the collapsing case. (WebCore::RenderTable::outerBorderTop): Added. Returns the table half of the top border, which is half the widest top border on the first row. (WebCore::RenderTable::outerBorderBottom): Added. Returns the table half of the bottom border, which is half the widest bottom border on the last row. (WebCore::RenderTable::outerBorderLeft): Added. Returns the table half of the left border, which is half the widest left border on the leftmost column. (WebCore::RenderTable::outerBorderRight): Added. Returns the table half of the right border, which is half the widest right border on the rightmost column. (WebCore::RenderTable::cellAbove): Return 0 if the cell is in the first row of the header. (WebCore::RenderTable::cellBelow): Return 0 if the cell is in the last row of the footer.
  • rendering/RenderTable.h: (WebCore::RenderTable::borderLeft): (WebCore::RenderTable::borderRight): (WebCore::RenderTable::overflowHeight):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::borderLeft): Removed unnecessary use of floats. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::paint): Account for the table half of the vertical borders. (WebCore::RenderTableCell::paintCollapsedBorder): Removed unnecessary use of floats.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Added call to recalcOuterBorder. (WebCore::RenderTableSection::calcOuterBorderTop): Added. Calculates the outer half of the section's top border, which is half the widest top border on the first row. (WebCore::RenderTableSection::calcOuterBorderBottom): Ditto for the bottom border. (WebCore::RenderTableSection::calcOuterBorderLeft): Ditto for the left border. (WebCore::RenderTableSection::calcOuterBorderRight): Ditto for the right border. (WebCore::RenderTableSection::recalcOuterBorder): Added. (WebCore::RenderTableSection::paint): Account for the table half of the borders.
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::outerBorderTop): (WebCore::RenderTableSection::outerBorderBottom): (WebCore::RenderTableSection::outerBorderLeft): (WebCore::RenderTableSection::outerBorderRight):
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff): Changed to return Layout if a border style changed from 'hidden' to 'none' or vice versa in the collapsing borders model, since 'hidden' suppresses other borders.
9:37 PM Changeset in webkit [14371] by darin
  • 5 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • manual-tests/dom-manipulation-on-resize.html: Added.

WebKit:

Reviewed by Darin.

Manual test: manual-tests/dom-manipulation-on-resize.html

  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.
9:33 PM Changeset in webkit [14370] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

  • fast/forms/file-input-disabled.html: Added.
  • fast/forms/file-input-disabled-expected.txt: Added.
  • fast/forms/file-input-disabled-expected.png: Added.
  • fast/forms/file-input-disabled-expected.checksum: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

Be sure to call setDisabled on the file button when in
RenderFileButton::updateFromElement.

  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (-[WebFileChooserButton setEnabled:]): (KWQFileButton::setDisabled):
  • rendering/render_form.cpp: (WebCore::RenderFileButton::updateFromElement):
3:12 PM Changeset in webkit [14369] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.

  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::fontDataAt): (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
2:26 PM Changeset in webkit [14368] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

2:25 PM Changeset in webkit [14367] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

1:38 PM Changeset in webkit [14366] by hyatt
  • 100 edits
    8 adds in trunk

Bug 8895. Rework font substitution and fallback. Lift the concept of
substitution and fallback out of FontData and up into the FontFallbackList.
See the bug for details of issues fixed in the fallback code.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::Font::primaryFont): (WebCore::Font::fontDataAt): (WebCore::Font::fontDataForCharacters): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch):
  • platform/Font.h: (WebCore::Font::getNSFont):
  • platform/FontCache.h: Added.
  • platform/FontData.h: (WebCore::FontData::pitch): (WebCore::FontData::getNSFont): (WebCore::):
  • platform/FontFallbackList.cpp: Added. (WebCore::m_pitch): (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
  • platform/FontFallbackList.h: (WebCore::FontFallbackList::isFixedPitch): (WebCore::FontFallbackList::primaryFont):
  • platform/FontFamily.h:
  • platform/mac/FontCacheMac.mm: Added. (WebCore::FontCache::getFontData): (WebCore::FontCache::getFontDataForCharacters):
  • platform/mac/FontData.mm: (WebCore::FontData::containsCharacters):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::initialize):
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory fallbackFontWithTraits:size:]): (-[WebTextRendererFactory fontWithDescription:WebCore::familyIndex:]):
  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::primaryFont): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
9:39 AM Changeset in webkit [14365] by ap
  • 3 edits
    4 adds in trunk

2006-05-14 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by Hyatt, landed by ap.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8387>
"border-left/padding-Left do not show up on multiline rtl inline boxes"

Test: fast/inline/inline-borders-with-bidi-override.html: added

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
12:12 AM Changeset in webkit [14364] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Fix the Windows build the rest of the way

  • WebCore.vcproj/WebCore/WebCore.vcproj:

May 13, 2006:

9:52 PM Changeset in webkit [14363] by sfalken
  • 2 edits in trunk/WebKitWin

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Update to new file paths

  • WebFramePrivate.cpp:
9:42 PM Changeset in webkit [14362] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Get FontWin.cpp compiling.
WebCore and JSCore now build, but Spinneret still gets link errors.

  • platform/win/FontWin.cpp: (WebCore::Font::offsetForPosition):
8:58 PM Changeset in webkit [14361] by sfalken
  • 4 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by maciej.

Fix Windows build except for fontwin.cpp.

  • WebCore/platform/win/FontWin.cpp:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
9:58 AM Changeset in webkit [14360] by ap
  • 3 edits in trunk/LayoutTests/fast/block/positioning/auto

Commit the remaining updated results for bug 7604.

9:47 AM Changeset in webkit [14359] by ap
  • 3 edits
    22 adds in trunk

2006-05-13 Kevin M. Ollivier <​kevino@theolliviers.com>

Reviewed by Darin, landed by ap.

JavaScriptCore:

  • make-generated-sources.sh: Added script to configure environment to run DerivedSources.make


  • JavaScriptCoreSources.bkl: Added JavaScriptCore sources list for Bakefile.


  • jscore.bkl: Bakefile used to generate JavaScriptCore project files (currently only used by wx and gdk ports)

WebCore:

  • make-generated-sources.sh: Added script to configure environment to run DerivedSources.make


  • move-js-headers.sh: Added script to copy JavaScriptCore includes into one dir so that Framework-style includes will work on all OSes. (written by Mike Emmel)


  • platform/wx: New dir, home for the wxWidgets port
  • platform/wx/wx-encodings.txt: Added temp. stub for wx encodings file.


  • Projects: New dir, for various project files for ports.


  • Projects/gdk: New dir, GDK port files.
  • Projects/webcore-gdk.bkl: Bakefile to generate GDK port project files


  • Projects/wx: New dir, wxWidgets port files.
  • Projects/webcore-wx.bkl: Bakefile to generate wxWidgets port project files

WebKitTools:

  • Scripts/install-unix-extras: Added.
  • Scripts/regenerate-makefiles: Added.
9:28 AM Changeset in webkit [14358] by ap
  • 3 edits
    4 adds in trunk

2006-05-13 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin, landed by ap.

Test: fast/text/midword-break-hang.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): If this is a mid-word break, ignore breakOnlyAfterWhiteSpace.
9:19 AM Changeset in webkit [14357] by ap
  • 2 edits in trunk/WebCore

Ok, now RenderBox.cpp actually compiles for me.

8:57 AM Changeset in webkit [14356] by ap
  • 2 edits in trunk/WebCore

Same fix for calcAbsoluteVerticalValues().

8:50 AM Changeset in webkit [14355] by ap
  • 2 edits in trunk/WebCore

Try to fix release build.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): Initialize leftValue. This value will never be used, because 'left' and 'right' cannot both be 'auto'.
8:28 AM Changeset in webkit [14354] by ap
  • 1 edit
    1 delete in trunk/WebCore/rendering

Re-applied the fix for bug 8835 (REGRESSION: Line moves but selection
highlight stays behind) to a correct file; removed the stale one.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::adjustPosition): Adjust m_selectionTop and m_selectionBottom.
  • rendering/render_line.cpp: Removed.
8:12 AM Changeset in webkit [14353] by ap
  • 1 edit in trunk/WebCore/ChangeLog

Corrected a path in ChangeLog.

8:11 AM Changeset in webkit [14352] by ap
  • 6 edits
    4 adds in trunk

2006-05-13 Rob Buis <​buis@kde.org>

Reviewed by Darin, landed by ap.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8132
CSS parser sometimes accepts real number as integer

Add a boolean variable per css value to catch whether values
are specified as floats or integers.

Test: fast/css/rgb-float.html

  • css/CSSGrammar.y:
  • css/cssparser.cpp: (WebCore::CSSParser::validUnit): (WebCore::CSSParser::lex):
  • css/cssparser.h:
  • css/tokenizer.flex:
7:58 AM Changeset in webkit [14351] by ap
  • 7 edits
    8 adds in trunk

2006-05-13 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by Hyatt, landed by ap.

WebCore:

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7604
calcAbsoluteHorizontalValues() is being getting passed arguments
in the wrong order in calcAbsoluteHorizontal()

Cleans up the RenderBox code for absolutely positioned elements
and adds new functions for replaced absolutely positioned
elements. Now uses Length so that magic number -666666 for
auto lengths is no longer used.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Handle replaced case separately. (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto.
  • rendering/RenderBox.h:

LayoutTests:

  • fast/block/positioning/absolute-length-of-neg-666666.html: Added.
  • fast/block/positioning/absolute-positioned-overconstrained.html: Added.
  • fast/block/positioning/auto/006.html: Updated to reflect that the containing block's direction, not the parent's is used.
  • fast/css/absolute-poition-in-rtl-parent.html: Updated and cleaned up.
Note: See TracTimeline for information about the timeline view.