⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 15, 2006:

10:33 PM Changeset in webkit [14407] by eseidel
  • 54 edits
    42 copies
    4 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Split css_valueimpl.* and css_ruleimpl.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8934

  • WebCore+SVG/RGBColor.cpp: (WebCore::RGBColor::RGBColor):
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::classInfo):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_window.cpp:
  • bindings/objc/DOMCSS.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSBorderImageValue.cpp: Added. (WebCore::CSSBorderImageValue::CSSBorderImageValue):
  • css/CSSBorderImageValue.h: Added.
  • css/CSSCharsetRule.h: Added. (WebCore::CSSCharsetRule::CSSCharsetRule):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): (WebCore::):
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSFontFaceRule.cpp: Added. (WebCore::CSSFontFaceRule::CSSFontFaceRule):
  • css/CSSFontFaceRule.h: Added. (WebCore::CSSFontFaceRule::isFontFaceRule):
  • css/CSSGrammar.y:
  • css/CSSImageValue.cpp: Added. (WebCore::CSSImageValue::CSSImageValue):
  • css/CSSImageValue.h: Added.
  • css/CSSImportRule.cpp: Added.
  • css/CSSImportRule.h: Added.
  • css/CSSInheritedValue.cpp: Added.
  • css/CSSInheritedValue.h: Added.
  • css/CSSInitialValue.cpp: Added.
  • css/CSSInitialValue.h: Added.
  • css/CSSMediaRule.cpp: Added. (WebCore::CSSMediaRule::CSSMediaRule): (WebCore::CSSMediaRule::~CSSMediaRule): (WebCore::CSSMediaRule::append): (WebCore::CSSMediaRule::deleteRule): (WebCore::CSSMediaRule::cssText):
  • css/CSSMediaRule.h: Added. (WebCore::CSSMediaRule::media): (WebCore::CSSMediaRule::cssRules):
  • css/CSSMutableStyleDeclaration.cpp: Added. (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::setChanged):
  • css/CSSMutableStyleDeclaration.h: Added.
  • css/CSSPageRule.cpp: Added. (WebCore::CSSPageRule::CSSPageRule):
  • css/CSSPageRule.h: Added. (WebCore::CSSPageRule::isPageRule):
  • css/CSSPrimitiveValue.cpp: Added.
  • css/CSSPrimitiveValue.h: Added.
  • css/CSSProperty.cpp: Added. (WebCore::CSSProperty::cssText):
  • css/CSSProperty.h: Added. (WebCore::CSSProperty::CSSProperty):
  • css/CSSQuirkPrimitiveValue.h: Added.
  • css/CSSRule.cpp: Added.
  • css/CSSRule.h: Added. (WebCore::CSSRule::CSSRule):
  • css/CSSRuleList.cpp: Added. (WebCore::CSSRuleList::CSSRuleList): (WebCore::CSSRuleList::~CSSRuleList): (WebCore::CSSRuleList::deleteRule): (WebCore::CSSRuleList::append): (WebCore::CSSRuleList::insertRule):
  • css/CSSRuleList.h: Added. (WebCore::CSSRuleList::item):
  • css/CSSStyleDeclaration.cpp: Added. (WebCore::CSSStyleDeclaration::CSSStyleDeclaration): (WebCore::CSSStyleDeclaration::diff):
  • css/CSSStyleDeclaration.h: Added.
  • css/CSSStyleRule.cpp: Added. (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::selectorText):
  • css/CSSStyleRule.h: Added.
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::ownerRule):
  • css/CSSUnknownRule.h: Added. (WebCore::CSSUnknownRule::CSSUnknownRule):
  • css/CSSValue.h: Added.
  • css/CSSValueList.cpp: Added.
  • css/CSSValueList.h: Added.
  • css/Counter.h: Added.
  • css/DashboardRegion.h: Added.
  • css/FontFamilyValue.cpp: Added.
  • css/FontFamilyValue.h: Added. (WebCore::FontFamilyValue::genericFamilyType):
  • css/FontValue.cpp: Added. (WebCore::FontValue::cssText):
  • css/FontValue.h: Added.
  • css/MediaList.cpp:
  • css/Pair.h: Added. (WebCore::Pair::~Pair):
  • css/RectImpl.h: Added. (WebCore::RectImpl::~RectImpl):
  • css/ShadowValue.cpp: Added. (WebCore::ShadowValue::ShadowValue):
  • css/ShadowValue.h: Added.
  • css/css_base.cpp:
  • css/css_ruleimpl.cpp: Removed.
  • css/css_ruleimpl.h: Removed.
  • css/css_valueimpl.cpp: Removed.
  • css/css_valueimpl.h: Removed.
  • css/cssparser.cpp: (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseFontFamily):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundImage):
  • css/cssstyleselector.h:
  • dom/CSSMappedAttributeDeclaration.h: (WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
  • dom/Document.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/EditCommand.cpp:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertLineBreakCommand.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): (WebCore::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):
  • editing/RemoveCSSPropertyCommand.h: (WebCore::RemoveCSSPropertyCommand::styleDeclaration):
  • html/HTMLBodyElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLScriptElement.h:
  • html/HTMLTokenizer.h:
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEColorMatrix::values): (WebCore::KCanvasFEColorMatrix::setValues): (WebCore::KCanvasFEConvolveMatrix::kernel): (WebCore::KCanvasFEConvolveMatrix::setKernel):
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasTreeDebug.h: (WebCore::operator<<):
  • kcanvas/RenderPath.h:
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGColor.cpp:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::filterEffect):
  • page/DOMWindow.cpp:
  • page/Frame.cpp:
  • page/FramePrivate.h:
  • platform/DeprecatedValueList.h:
  • rendering/RenderTextField.cpp:
9:38 PM Changeset in webkit [14406] by ap
  • 5 edits in trunk

JavaScriptCore:

  • make-generated-sources.sh: Changed to be executable and removed text in the file generated by "svn diff".

WebKitTools:

  • Scripts/install-unix-extras: Changed to be executable and removed text in the file generated by "svn diff".
  • Scripts/regenerate-makefiles: Ditto.
9:30 PM Changeset in webkit [14405] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Removed duplicate files that were screwing up Xcode.
8:11 PM Changeset in webkit [14404] by eseidel
  • 1 edit in trunk/WebCore/bindings/js/kjs_css.h

Fix typo causing build failure.

7:54 PM Changeset in webkit [14403] by ggaren
  • 4 edits
    6 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4534904> please do not treat "debugger" as a reserved word while parsing JavaScript (and other ECMA reserved words)

AKA

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6179
We treat "char" as a reserved word in JavaScript and firefox/IE do
not

(1) I unreserved most of the spec's "future reserved words" because
they're not reserved in IE or FF. (Most, but not all, because IE
somewhat randomly *does* reserve a few of them.)
(2) I made 'debugger' a legitimate statement that acts like an empty
statement because FF and IE support it.


  • kjs/grammar.y:
  • kjs/keywords.table:

LayoutTests:

  • fast/js/debugger-expected.txt: Added.
  • fast/js/debugger.html: Added.
  • fast/js/reserved-words-expected.txt: Added.
  • fast/js/reserved-words.html: Added.
  • fast/js/resources/debugger.js: Added.
  • fast/js/resources/reserved-words.js: Added.
7:21 PM Changeset in webkit [14402] by eseidel
  • 1 edit in trunk/WebCore/bindings/js/kjs_css.h

A few more style cleanup changes I missed in my last commit.

7:08 PM Changeset in webkit [14401] by eseidel
  • 33 edits
    6 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Split css_stylesheetimpl.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8933

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSheet.cpp: Added. (WebCore::CSSStyleSheet::CSSStyleSheet): (WebCore::CSSStyleSheet::addRule): (WebCore::CSSStyleSheet::deleteRule): (WebCore::CSSStyleSheet::parseString): (WebCore::CSSStyleSheet::docLoader):
  • css/CSSStyleSheet.h: Added.
  • css/MediaList.cpp: Added. (WebCore::MediaList::MediaList): (WebCore::MediaList::contains): (WebCore::MediaList::parentStyleSheet): (WebCore::MediaList::parentRule): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::setMediaText):
  • css/MediaList.h: Added.
  • css/StyleSheet.cpp: Added. (WebCore::StyleSheet::StyleSheet): (WebCore::StyleSheet::parentStyleSheet): (WebCore::StyleSheet::setMedia):
  • css/StyleSheet.h: Added. (WebCore::StyleSheet::ownerNode):
  • css/StyleSheetList.cpp: Added. (WebCore::StyleSheetList::~StyleSheetList): (WebCore::StyleSheetList::add): (WebCore::StyleSheetList::remove): (WebCore::StyleSheetList::item):
  • css/StyleSheetList.h: Added.
  • css/css_stylesheetimpl.cpp: Removed.
  • css/css_stylesheetimpl.h: Removed.
7:00 PM Changeset in webkit [14400] by darin
  • 3 edits in trunk/WebCore
  • make-generated-sources.sh: Changed to be executable and removed text in the file generated by "svn diff".
  • move-js-headers.sh: Ditto.
6:04 PM Changeset in webkit [14399] by bdakin
  • 121 edits in trunk/LayoutTests

Reviewed by Darin.

These tests have new expected results after the fix for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6838 Incomplete
repaint of collapsed table borders

5:43 PM Changeset in webkit [14398] by thatcher
  • 3 edits in trunk/WebCore/platform/mac

64-bit build fixes.

5:04 PM Changeset in webkit [14397] by tomernic
  • 5 edits in trunk

JavaScriptCore:

Reviewed by John Sullivan.

Part of <rdar://problem/4466508> Add 64-bit support to the Netscape Plugin API

Added to the Netscape Plugin API the concept of "plugin drawing models". The drawing model
determines the kind of graphics context created by the browser for the plugin, as well as
the Mac types of various Netscape Plugin API data structures.

There is a drawing model to represent the old QuickDraw-based API. It is used by default
if QuickDraw is available on the system, unless the plugin specifies another drawing model.

The big change is the addition of the CoreGraphics drawing model. A plugin may request this
drawing model to obtain access to a CGContextRef for drawing, instead of a QuickDraw CGrafPtr.

  • bindings/npapi.h: Define NP_NO_QUICKDRAW when compiling 64-bit; there is no 64-bit QuickDraw. Added NPNVpluginDrawingModel, NPNVsupportsQuickDrawBool, and NPNVsupportsCoreGraphicsBool variables. Added NPDrawingModel enumeration. Currently the only drawing models are QuickDraw and CoreGraphics. NPRegion's type now depends on the drawing model specified by the plugin. NP_Port is now only defined when QuickDraw is available. Added NP_CGContext, which is the type of the NPWindow's "window" member in CoreGraphics mode.

WebKit:

Reviewed by John Sullivan.

Part of <rdar://problem/4466508> Add 64-bit support to the Netscape Plugin API

Added to the Netscape Plugin API the concept of "plugin drawing models". The drawing model
determines the kind of graphics context created by the browser for the plugin, as well as
the Mac types of various Netscape Plugin API data structures.

There is a drawing model to represent the old QuickDraw-based API. It is used by default
if QuickDraw is available on the system, unless the plugin specifies another drawing model.

The big change is the addition of the CoreGraphics drawing model. A plugin may request this
drawing model to obtain access to a CGContextRef for drawing, instead of a QuickDraw CGrafPtr.

  • Plugins/WebBaseNetscapePluginView.h: Added PluginPort union, which wraps a NP_Port and a NP_CGContext. This is to make access to the nPort and lastSetPort ivars more convenient now that the port type differs based on the drawing model. Changed types of nPort and lastSetPort to PluginPort so they can be used with any drawing model. Added drawingModel ivar.
  • Plugins/WebBaseNetscapePluginView.m: Renamed PortState to PortState_QD. PortState is now an opaque pointer. PortState_QD cannot be used if QuickDraw is unavailable. (-[WebBaseNetscapePluginView fixWindowPort]): Cannot be used if QuickDraw is unavailable. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Only fix window port if drawing model is QuickDraw. Re-ordered some code so I could group QuickDraw-specific stuff into switch and if blocks (that's why the diff here is so terrible). Now returns a malloc()'ed PortState that the caller is responsible for freeing. Renamed to better reflect this behavior. Support for the CoreGraphics drawing model -- fill PortState_CG struct, save CGContext state. (-[WebBaseNetscapePluginView restorePortState:]): Switch based on drawing model. Support for the CoreGraphics drawing model -- restore CGContext state saved earlier. (-[WebBaseNetscapePluginView sendEvent:]): Formatting. Don't set save/set port state or set the window in CoreGraphics mode unless the event being sent is an updateEvt. We can't provide the plugin with a CGContext outside of our view display cycle. Don't restore PortState if it's NULL (didn't used to be a pointer). Free when we're done with it. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): Formatting. Switch how we compare ports based on the drawing model. (-[WebBaseNetscapePluginView updateAndSetWindow]): Fixed for CoreGraphics by triggering a redisplay instead of sending an update event to the plugin outside of the view display cycle. Don't restore PortState if it's NULL (didn't used to be a pointer). Free when we're done with it. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Assert that the window is only set when updating in CoreGraphics mode. Log differently depending on the drawing model. (-[WebBaseNetscapePluginView start]): Fall back on QuickDraw if the plugin does not specify a drawing model. (-[WebBaseNetscapePluginView tellQuickTimeToChill]): Cannot be used if QuickDraw is unavailable. (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Only call -tellQuickTimeToChill in QuickDraw mode. (-[WebBaseNetscapePluginView viewHasMoved:]): ditto (-[WebBaseNetscapePluginView invalidateRegion:]): NPRegion is a CGPathRef in CoreGraphics mode. (-[WebBaseNetscapePluginView getVariable:value:]): Added support for retriveing the NPNVpluginDrawingModel, NPNVsupportsQuickDrawBool, and NPNVsupportsCoreGraphicsBool browser variables. (-[WebBaseNetscapePluginView setVariable:value:]): Added support for setting the NPNVpluginDrawingModel variable.
5:04 PM Changeset in webkit [14396] by eseidel
  • 2 edits in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

  • WebCore.xcodeproj/project.pbxproj: build fix.
4:53 PM Changeset in webkit [14395] by eseidel
  • 11 edits
    6 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Split dom_xmlimpl.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Entity.cpp: Added. (WebCore::Entity::Entity):
  • dom/Entity.h: Added.
  • dom/EntityReference.cpp: Added. (WebCore::EntityReference::EntityReference):
  • dom/EntityReference.h: Added.
  • dom/Notation.cpp: Added. (WebCore::Notation::Notation):
  • dom/Notation.h: Added.
  • dom/ProcessingInstruction.cpp: Added. (WebCore::ProcessingInstruction::ProcessingInstruction):
  • dom/ProcessingInstruction.h: Added.
  • dom/dom_xmlimpl.cpp: Removed.
  • dom/dom_xmlimpl.h: Removed.
4:30 PM Changeset in webkit [14394] by thatcher
  • 1 edit in trunk/WebCore/kwq/KWQListBox.mm

build fix

4:23 PM Changeset in webkit [14393] by eseidel
  • 24 edits
    6 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by Tim Hatcher.

Split html_imageimpl.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8929

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCanvasRenderingContext2DBase.cpp:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • dom/Document.cpp:
  • editing/JSEditor.cpp:
  • html/CanvasRenderingContext2D.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAreaElement.cpp: Added. (WebCore::HTMLAreaElement::HTMLAreaElement): (WebCore::HTMLAreaElement::mapMouseEvent): (WebCore::HTMLAreaElement::getRect): (WebCore::HTMLAreaElement::getRegion):
  • html/HTMLAreaElement.h: Added.
  • html/HTMLCanvasElement.h:
  • html/HTMLDocument.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLFormCollection.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLImageElement.cpp: Added. (WebCore::HTMLImageElement::HTMLImageElement):
  • html/HTMLImageElement.h: Added.
  • html/HTMLImageLoader.cpp: Added. (WebCore::HTMLImageLoader::HTMLImageLoader):
  • html/HTMLImageLoader.h: Added.
  • html/HTMLInputElement.cpp:
  • html/HTMLMapElement.cpp: Added. (WebCore::HTMLMapElement::mapMouseEvent): (WebCore::HTMLMapElement::parseMappedAttribute):
  • html/HTMLMapElement.h: Added.
  • html/HTMLObjectElement.cpp:
  • html/HTMLParser.cpp:
  • html/html_imageimpl.cpp: Removed.
  • html/html_imageimpl.h: Removed.
  • ksvg2/misc/SVGImageLoader.h:
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject addChildrenToArray:]):
  • page/Frame.cpp:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::nodeAtPoint):
3:22 PM Changeset in webkit [14392] by tomernic
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix and follow-up fix from TOT to Safari-2-0-branch

2006-05-15 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

Safari's Page Load Test (PLT) saturates the runloop with so many sources that timers are not allowed to fire
as frequently as they should. This is a general problem with the PLT -- because of this, it does not measure
work done in timer callbacks during/after the page load process.

Unfortunately, this aspect of the PLT interferes with our window display throttle hack. Because we throttle
display using timers, and the PLT starves timers, most of the pages loaded by the PLT do not actually display.
This makes the PLT run "too fast", yielding ridiculously fast numbers compared to when throttling is disabled.

I've added a new method that the PLT can call after each page load to force any starved display throttle timers
to fire. By doing this, Safari's PLT will be guaranteed to display each page at least once.

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: Added a special internal runloop mode for the throttle timers. (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop in our special internal mode until there are no more sources to handle. (requestWindowDisplay): Schedule the timer in the new mode as well as the standard modes.

2006-05-15 Tim Omernick <​timo@apple.com>

Reviewed by Kevin Decker.

Follow-up to my previous PLT fix. I found upon further testing (by dramatically decreasing the
allowed display rate) that +_webkit_displayThrottledWindows did not always force a display when
necessary. The reason is that I was not giving a proper timeout to CFRunLoopRunInMode(). I was
passing 0, which was causing only "expired" timers to fire. This method is actually supposed to
block until all currently scheduled display timers fire.

I tested this change and found that it did not affect my PLT times when the display rate was
capped to 60 fps. It also behaves as expected when the display rate is set much lower (say, 1
display per second); my previous fix did not work well at such display rates.

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop for an amount of time equal to the minimum allowed interval between displays. This ensures that we'll block until all currently scheduled display timers fire (but we won't block for future display timers).
3:18 PM Changeset in webkit [14391] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

Follow-up to my previous PLT fix. I found upon further testing (by dramatically decreasing the
allowed display rate) that +_webkit_displayThrottledWindows did not always force a display when
necessary. The reason is that I was not giving a proper timeout to CFRunLoopRunInMode(). I was
passing 0, which was causing only "expired" timers to fire. This method is actually supposed to
block until all currently scheduled display timers fire.

I tested this change and found that it did not affect my PLT times when the display rate was
capped to 60 fps. It also behaves as expected when the display rate is set much lower (say, 1
display per second); my previous fix did not work well at such display rates.

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop for an amount of time equal to the minimum allowed interval between displays. This ensures that we'll block until all currently scheduled display timers fire (but we won't block for future display timers).
2:57 PM Changeset in webkit [14390] by eseidel
  • 9 edits
    12 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Split html_blockimpl.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8927

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • html/HTMLBlockquoteElement.cpp: Added. (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  • html/HTMLBlockquoteElement.h: Added.
  • html/HTMLDivElement.cpp: Added.
  • html/HTMLDivElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLHRElement.cpp: Added.
  • html/HTMLHRElement.h: Added.
  • html/HTMLHeadingElement.cpp: Added.
  • html/HTMLHeadingElement.h: Added.
  • html/HTMLMarqueeElement.cpp: Added. (WebCore::HTMLMarqueeElement::HTMLMarqueeElement): (WebCore::HTMLMarqueeElement::parseMappedAttribute):
  • html/HTMLMarqueeElement.h: Added.
  • html/HTMLParagraphElement.cpp: Added.
  • html/HTMLParagraphElement.h: Added.
  • html/HTMLParser.cpp:
  • html/HTMLPreElement.cpp: Added. (WebCore::HTMLPreElement::HTMLPreElement): (WebCore::HTMLPreElement::setWrap):
  • html/HTMLPreElement.h: Added.
  • html/HTMLTextFieldInnerElement.h:
  • html/html_blockimpl.cpp: Removed.
  • html/html_blockimpl.h: Removed.
  • rendering/RenderLayer.cpp:
2:16 PM Changeset in webkit [14389] by eseidel
  • 16 edits
    14 copies
    4 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Split render_list.* and html_listimpl.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
  • html/HTMLDListElement.cpp: Added. (WebCore::HTMLDListElement::HTMLDListElement):
  • html/HTMLDListElement.h: Added.
  • html/HTMLDirectoryElement.cpp: Added. (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
  • html/HTMLDirectoryElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLLIElement.cpp: Added. (WebCore::HTMLLIElement::HTMLLIElement): (WebCore::HTMLLIElement::parseMappedAttribute): (WebCore::HTMLLIElement::attach): (WebCore::HTMLLIElement::setType):
  • html/HTMLLIElement.h: Added.
  • html/HTMLMenuElement.cpp: Added. (WebCore::HTMLMenuElement::HTMLMenuElement):
  • html/HTMLMenuElement.h: Added.
  • html/HTMLOListElement.cpp: Added. (WebCore::HTMLOListElement::HTMLOListElement): (WebCore::HTMLOListElement::parseMappedAttribute): (WebCore::HTMLOListElement::setType):
  • html/HTMLOListElement.h: Added. (WebCore::HTMLOListElement::start):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::checkDTD): (WebCore::HTMLOptionElement::text): (WebCore::HTMLOptionElement::setText): (WebCore::HTMLOptionElement::getSelect): (WebCore::HTMLOptionElement::setLabel):
  • html/HTMLOptionElement.h:
  • html/HTMLParser.cpp:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement):
  • html/HTMLUListElement.cpp: Added. (WebCore::HTMLUListElement::HTMLUListElement):
  • html/HTMLUListElement.h: Added.
  • html/html_listimpl.cpp: Removed.
  • html/html_listimpl.h: Removed.
  • kwq/WebCoreAXObject.mm:
  • rendering/InlineFlowBox.cpp:
  • rendering/ListMarkerBox.cpp: Added. (WebCore::ListMarkerBox::ListMarkerBox): (WebCore::ListMarkerBox::isText):
  • rendering/ListMarkerBox.h: Added.
  • rendering/RenderContainer.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChild): (WebCore::RenderContainer::layout): (WebCore::RenderContainer::removeLeftoverAnonymousBoxes): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::lineBoxRects):
  • rendering/RenderListItem.cpp: Added. (WebCore::RenderListItem::RenderListItem): (WebCore::RenderListItem::setStyle): (WebCore::RenderListItem::calcValue): (WebCore::RenderListItem::markerStringValue):
  • rendering/RenderListItem.h: Added. (WebCore::RenderListItem::renderName): (WebCore::RenderListItem::setValue): (WebCore::RenderListItem::setNotInList): (WebCore::RenderListItem::notInList):
  • rendering/RenderListMarker.cpp: Added. (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::setStyle): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::calcMinMaxWidth):
  • rendering/RenderListMarker.h: Added. (WebCore::RenderListMarker::renderName):
  • rendering/RenderObject.cpp:
  • rendering/render_list.cpp: Removed.
  • rendering/render_list.h: Removed.
2:12 PM Changeset in webkit [14388] by hyatt
  • 1 edit in trunk/LayoutTests/editing/input/attributed-substring-from-range-lines-expected.txt

Land updated results.

1:49 PM Changeset in webkit [14387] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • followup to previous fix; I hadn't tested quitting adequately
  • WebView/WebHTMLView.m: (-[WebHTMLView dealloc]): call removeAllToolTips before clearing _private so that removeTrackingRect: override can work properly. Normally removeAllToolTips would be called by super, but that's too late. (-[WebHTMLView finalize]): ditto
1:25 PM Changeset in webkit [14386] by thatcher
  • 1 copy in tags/WebKit-418.4/WebKit

Tag for WebKit 418.4 (part 2 of 2.)

1:25 PM Changeset in webkit [14385] by thatcher
  • 1 add in tags/WebKit-418.4

Tag for WebKit 418.4 (part 1 of 2.)

1:25 PM Changeset in webkit [14384] by thatcher
  • 1 delete in tags/WebCore-418.4/WebCore/WebCore

Removing a bad tag.

1:23 PM Changeset in webkit [14383] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Darin.


  • fixed <rdar://problem/4503016> TOT assertion failure in -[WebHTMLView(WebPrivate) removeTrackingRect:]


We have some tricky code to deal with tracking rects, which succumbed to a fix in AppKit. Updated our
tricky code to work with the AppKit fix.

  • WebView/WebHTMLViewInternal.h: new instance variable lastToolTipTag


  • WebView/WebHTMLView.m: (-[WebHTMLView removeTrackingRect:]): handle removing lastToolTipTag by calling super (-[WebHTMLView _setToolTip:]): save tool tip tag in lastToolTipTag; this apparently used to always return 0, so we formerly had no way to distinguish it from the no-tool-tips-yet case.
  • WebKit.xcodeproj/project.pbxproj: Xcode removed some old cruft
12:15 PM Changeset in webkit [14382] by eseidel
  • 17 edits
    18 copies
    2 moves in trunk/WebCore

2006-05-15 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by eseidel.

Split render_form.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8889

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement):
  • html/HTMLFieldSetElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLInputElement.cpp:
  • html/HTMLLabelElement.cpp:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::createRenderer):
  • html/HTMLOptionElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): (WebCore::HTMLTextAreaElement::selectionEnd): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::createRenderer): (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setDefaultValue): (WebCore::HTMLTextAreaElement::setAccessKey):
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQSlider.mm:
  • platform/mac/WebCoreTextField.mm:
  • rendering/RenderFieldset.cpp: Added. (WebCore::RenderFieldset::RenderFieldset): (WebCore::RenderFieldset::findLegend): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderFieldset::setStyle):
  • rendering/RenderFieldset.h: Added. (WebCore::RenderFieldset::renderName):
  • rendering/RenderFileButton.cpp: Added. (WebCore::RenderFileButton::RenderFileButton): (WebCore::RenderFileButton::calcMinMaxWidth): (WebCore::RenderFileButton::updateFromElement): (WebCore::RenderFileButton::click):
  • rendering/RenderFileButton.h: Added. (WebCore::RenderFileButton::renderName): (WebCore::RenderFileButton::calcReplacedHeight): (WebCore::RenderFileButton::isEditable):
  • rendering/RenderFormElement.cpp: Added. (WebCore::RenderFormElement::RenderFormElement): (WebCore::RenderFormElement::baselinePosition): (WebCore::RenderFormElement::layout):
  • rendering/RenderFormElement.h: Added. (WebCore::RenderFormElement::renderName): (WebCore::RenderFormElement::isFormElement): (WebCore::RenderFormElement::borderTop): (WebCore::RenderFormElement::borderBottom): (WebCore::RenderFormElement::borderLeft): (WebCore::RenderFormElement::borderRight): (WebCore::RenderFormElement::paddingTop): (WebCore::RenderFormElement::paddingBottom): (WebCore::RenderFormElement::paddingLeft): (WebCore::RenderFormElement::paddingRight): (WebCore::RenderFormElement::canHaveIntrinsicMargins): (WebCore::RenderFormElement::intrinsicMargin): (WebCore::RenderFormElement::isEditable):
  • rendering/RenderImageButton.cpp: Added. (WebCore::RenderImageButton::RenderImageButton):
  • rendering/RenderImageButton.h: Added. (WebCore::RenderImageButton::renderName): (WebCore::RenderImageButton::isImageButton):
  • rendering/RenderLabel.cpp: Added. (WebCore::RenderLabel::RenderLabel):
  • rendering/RenderLabel.h: Added. (WebCore::RenderLabel::renderName):
  • rendering/RenderLegend.cpp: Added. (WebCore::RenderLegend::RenderLegend):
  • rendering/RenderLegend.h: Added. (WebCore::RenderLegend::renderName):
  • rendering/RenderLineEdit.cpp: Added. (WebCore::RenderLineEdit::RenderLineEdit):
  • rendering/RenderLineEdit.h: Added. (WebCore::RenderLineEdit::renderName): (WebCore::RenderLineEdit::calcReplacedHeight): (WebCore::RenderLineEdit::canHaveIntrinsicMargins): (WebCore::RenderLineEdit::isTextField): (WebCore::RenderLineEdit::isEditable):
  • rendering/RenderSelect.cpp: Added. (WebCore::RenderSelect::RenderSelect): (WebCore::RenderSelect::setWidgetWritingDirection): (WebCore::RenderSelect::setStyle): (WebCore::RenderSelect::updateFromElement): (WebCore::RenderSelect::baselinePosition): (WebCore::RenderSelect::calcMinMaxWidth): (WebCore::RenderSelect::layout): (WebCore::RenderSelect::valueChanged): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::updateSelection):
  • rendering/RenderSelect.h: Added. (WebCore::RenderSelect::renderName): (WebCore::RenderSelect::calcReplacedHeight): (WebCore::RenderSelect::canHaveIntrinsicMargins): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::setSelectionChanged):
  • rendering/RenderSlider.cpp: Added. (WebCore::RenderSlider::calcMinMaxWidth): (WebCore::RenderSlider::updateFromElement):
  • rendering/RenderSlider.h: Added. (WebCore::RenderSlider::renderName): (WebCore::RenderSlider::canHaveIntrinsicMargins):
  • rendering/RenderTextArea.cpp: Added. (WebCore::RenderTextArea::RenderTextArea): (WebCore::RenderTextArea::calcMinMaxWidth): (WebCore::RenderTextArea::setStyle): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::selectionStart): (WebCore::RenderTextArea::selectionEnd): (WebCore::RenderTextArea::setSelectionStart): (WebCore::RenderTextArea::setSelectionEnd): (WebCore::RenderTextArea::select): (WebCore::RenderTextArea::setSelectionRange):
  • rendering/RenderTextArea.h: Added. (WebCore::RenderTextArea::renderName): (WebCore::RenderTextArea::isTextArea): (WebCore::RenderTextArea::isEdited): (WebCore::RenderTextArea::canHaveIntrinsicMargins): (WebCore::RenderTextArea::isEditable):
  • rendering/render_form.cpp: Removed.
  • rendering/render_form.h: Removed.
12:10 PM Changeset in webkit [14381] by thatcher
  • 1 copy in tags/WebCore-418.4/WebCore/WebCore

Tag for WebCore 418.4 (part 2 of 2.)

12:08 PM Changeset in webkit [14380] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

12:05 PM Changeset in webkit [14379] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Safari's Page Load Test (PLT) saturates the runloop with so many sources that timers are not allowed to fire
as frequently as they should. This is a general problem with the PLT -- because of this, it does not measure
work done in timer callbacks during/after the page load process.

Unfortunately, this aspect of the PLT interferes with our window display throttle hack. Because we throttle
display using timers, and the PLT starves timers, most of the pages loaded by the PLT do not actually display.
This makes the PLT run "too fast", yielding ridiculously fast numbers compared to when throttling is disabled.

I've added a new method that the PLT can call after each page load to force any starved display throttle timers
to fire. By doing this, Safari's PLT will be guaranteed to display each page at least once.

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: Added a special internal runloop mode for the throttle timers. (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop in our special internal mode until there are no more sources to handle. (requestWindowDisplay): Schedule the timer in the new mode as well as the standard modes.
11:17 AM Changeset in webkit [14378] by andersca
  • 10 edits in trunk/WebCore

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Eric.

Remove the XPath log calls. They were causing leaks and were never
really useful.


  • bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary):
  • platform/Logging.cpp:
  • platform/Logging.h:
  • xpath/XPathResult.cpp: (WebCore::XPathResult::convertTo):
  • xpath/impl/XPathFunctions.cpp: (round): (WebCore::XPath::FunCount::doEvaluate): (WebCore::XPath::FunSum::doEvaluate): (WebCore::XPath::FunctionLibrary::createFunction):
  • xpath/impl/XPathPath.cpp: (WebCore::XPath::Filter::doEvaluate): (WebCore::XPath::LocationPath::doEvaluate):
  • xpath/impl/XPathPredicate.cpp: (WebCore::XPath::Negative::doEvaluate): (WebCore::XPath::NumericOp::doEvaluate): (WebCore::XPath::Union::doEvaluate):
  • xpath/impl/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeTestMatches):
  • xpath/impl/XPathValue.cpp: (WebCore::XPath::Value::toNodeVector):
10:14 AM Changeset in webkit [14377] by eseidel
  • 2 edits in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Fix linux build.

  • html/HTMLBodyElement.cpp: Fix case of #include "cssstyleselector.h"
1:47 AM Changeset in webkit [14376] by andersca
  • 6 edits in trunk

WebCore:

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8913
REGRESSION: Can view source for text files


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canProvideDocumentSource]): (-[WebCoreFrameBridge canSaveAsWebArchive]):

WebKit:

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8913
REGRESSION: Can view source for text files

  • WebView/WebDocumentPrivate.h: Add canSaveAsWebArchive.


  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation canProvideDocumentSource]): Call the bridge.


(-[WebHTMLRepresentation canSaveAsWebArchive]):
New function. This will be used in Safari ToT to determine if a page can be saved as an archive.

1:03 AM Changeset in webkit [14375] by hyatt
  • 10 edits in trunk/WebCore

Remove the .forPrinter boolean from FontPlatformData. After the initial
acquisition of an NSFont, the font is then adjusted to printer or screen
when put into a FontPlatformData. Then it can simply be used in the hash
lookup to get a FontData.

Reviewed by mjs

  • platform/Font.cpp: (WebCore::WidthIterator::advance):
  • platform/FontData.h:
  • platform/FontDescription.h: (WebCore::FontDescription::bold):
  • platform/FontPlatformData.h: (WebCore::FontPlatformData::syntheticOblique):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
  • platform/mac/FontData.mm: (WebCore::FontData::smallCapsFontData): (WebCore::getSmallCapsFontData): (WebCore::setUpFont):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::initialize):
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory rendererWithFont:]): (-[WebTextRendererFactory fontWithDescription:WebCore::familyIndex:]):

May 14, 2006:

11:59 PM Changeset in webkit [14374] by andersca
  • 2 edits in trunk/WebCore

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

9:57 PM Changeset in webkit [14373] by hyatt
  • 246 edits in trunk/LayoutTests/svg/W3C-SVG-1.1

Update svg layout tests.

9:42 PM Changeset in webkit [14372] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/repaint/table-collapsed-border-expected.checksum: Added.
  • fast/repaint/table-collapsed-border-expected.png: Added.
  • fast/repaint/table-collapsed-border-expected.txt: Added.
  • fast/repaint/table-collapsed-border.html: Added.

WebCore:

Reviewed by Hyatt.


This patch updates the implementation of collapsing borders to match
the current spec.

Test: fast/repaint/table-collapsed-border.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::layout): Calculate horizontal overflows. (WebCore::RenderTable::calcMinMaxWidth): Added call to recalcHorizontalBorders. (WebCore::RenderTable::colElement): Made const. (WebCore::RenderTable::calcBorderLeft): Calculates the left border. In the collapsing borders model, this is the left border of the leftmost cell of the first row. (WebCore::RenderTable::calcBorderRight): Ditto for the right border. (WebCore::RenderTable::recalcHorizontalBorders): Added. (WebCore::RenderTable::borderTop): Changed to return outerBorderTop in the collapsing case. (WebCore::RenderTable::borderBottom): Changed to return outerBorderBottom in the collapsing case. (WebCore::RenderTable::outerBorderTop): Added. Returns the table half of the top border, which is half the widest top border on the first row. (WebCore::RenderTable::outerBorderBottom): Added. Returns the table half of the bottom border, which is half the widest bottom border on the last row. (WebCore::RenderTable::outerBorderLeft): Added. Returns the table half of the left border, which is half the widest left border on the leftmost column. (WebCore::RenderTable::outerBorderRight): Added. Returns the table half of the right border, which is half the widest right border on the rightmost column. (WebCore::RenderTable::cellAbove): Return 0 if the cell is in the first row of the header. (WebCore::RenderTable::cellBelow): Return 0 if the cell is in the last row of the footer.
  • rendering/RenderTable.h: (WebCore::RenderTable::borderLeft): (WebCore::RenderTable::borderRight): (WebCore::RenderTable::overflowHeight):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::borderLeft): Removed unnecessary use of floats. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::paint): Account for the table half of the vertical borders. (WebCore::RenderTableCell::paintCollapsedBorder): Removed unnecessary use of floats.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Added call to recalcOuterBorder. (WebCore::RenderTableSection::calcOuterBorderTop): Added. Calculates the outer half of the section's top border, which is half the widest top border on the first row. (WebCore::RenderTableSection::calcOuterBorderBottom): Ditto for the bottom border. (WebCore::RenderTableSection::calcOuterBorderLeft): Ditto for the left border. (WebCore::RenderTableSection::calcOuterBorderRight): Ditto for the right border. (WebCore::RenderTableSection::recalcOuterBorder): Added. (WebCore::RenderTableSection::paint): Account for the table half of the borders.
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::outerBorderTop): (WebCore::RenderTableSection::outerBorderBottom): (WebCore::RenderTableSection::outerBorderLeft): (WebCore::RenderTableSection::outerBorderRight):
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff): Changed to return Layout if a border style changed from 'hidden' to 'none' or vice versa in the collapsing borders model, since 'hidden' suppresses other borders.
9:37 PM Changeset in webkit [14371] by darin
  • 5 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • manual-tests/dom-manipulation-on-resize.html: Added.

WebKit:

Reviewed by Darin.

Manual test: manual-tests/dom-manipulation-on-resize.html

  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.
9:33 PM Changeset in webkit [14370] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

  • fast/forms/file-input-disabled.html: Added.
  • fast/forms/file-input-disabled-expected.txt: Added.
  • fast/forms/file-input-disabled-expected.png: Added.
  • fast/forms/file-input-disabled-expected.checksum: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

Be sure to call setDisabled on the file button when in
RenderFileButton::updateFromElement.

  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (-[WebFileChooserButton setEnabled:]): (KWQFileButton::setDisabled):
  • rendering/render_form.cpp: (WebCore::RenderFileButton::updateFromElement):
3:12 PM Changeset in webkit [14369] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.

  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::fontDataAt): (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
2:26 PM Changeset in webkit [14368] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

2:25 PM Changeset in webkit [14367] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

1:38 PM Changeset in webkit [14366] by hyatt
  • 100 edits
    8 adds in trunk

Bug 8895. Rework font substitution and fallback. Lift the concept of
substitution and fallback out of FontData and up into the FontFallbackList.
See the bug for details of issues fixed in the fallback code.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::Font::primaryFont): (WebCore::Font::fontDataAt): (WebCore::Font::fontDataForCharacters): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch):
  • platform/Font.h: (WebCore::Font::getNSFont):
  • platform/FontCache.h: Added.
  • platform/FontData.h: (WebCore::FontData::pitch): (WebCore::FontData::getNSFont): (WebCore::):
  • platform/FontFallbackList.cpp: Added. (WebCore::m_pitch): (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
  • platform/FontFallbackList.h: (WebCore::FontFallbackList::isFixedPitch): (WebCore::FontFallbackList::primaryFont):
  • platform/FontFamily.h:
  • platform/mac/FontCacheMac.mm: Added. (WebCore::FontCache::getFontData): (WebCore::FontCache::getFontDataForCharacters):
  • platform/mac/FontData.mm: (WebCore::FontData::containsCharacters):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::initialize):
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory fallbackFontWithTraits:size:]): (-[WebTextRendererFactory fontWithDescription:WebCore::familyIndex:]):
  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::primaryFont): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
9:39 AM Changeset in webkit [14365] by ap
  • 3 edits
    4 adds in trunk

2006-05-14 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by Hyatt, landed by ap.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8387>
"border-left/padding-Left do not show up on multiline rtl inline boxes"

Test: fast/inline/inline-borders-with-bidi-override.html: added

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
12:12 AM Changeset in webkit [14364] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Fix the Windows build the rest of the way

  • WebCore.vcproj/WebCore/WebCore.vcproj:
Note: See TracTimeline for information about the timeline view.