⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 20, 2006:

11:58 PM Changeset in webkit [14507] by hyatt
  • 14 edits
    1 move
    2 adds in trunk/WebCore

Switch on Cairo-based text rendering on win32.

11:55 PM Changeset in webkit [14506] by hyatt
  • 1 add in trunk/JavaScriptCore/wtf/MathExtras.h

Add mathextras.h to wtf to give win32 roundf/lroundf support.

7:09 PM Changeset in webkit [14505] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Beth.


  • fix assertion failure on layout tests
  • WebView/WebDataSource.m: (-[WebDataSource _mainReceivedError:complete:]): Don't do anything if this data source is no longer connected to a frame. Used to be this couldn't happen because the WebView would have been nil, but we no longer go through the WebView.
3:42 PM Changeset in webkit [14504] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders.

Bug 9018: REGRESSION: resizing the top area of the inspector does not grow as expected
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9018


Use clientHeight now that offsetHeight includes the border and padding.
clientHeight should have been used initially.

2:22 PM Changeset in webkit [14503] by hyatt
  • 2 edits in trunk/WebKitWin

Fix Cairo double buffering.

1:19 PM Changeset in webkit [14502] by andersca
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2006-05-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8993
Support function declaration in case statements


  • kjs/grammar.y: Get rid of StatementList and use SourceElements instead.


  • kjs/nodes.cpp: (CaseClauseNode::evalStatements): (CaseClauseNode::processVarDecls): (CaseClauseNode::processFuncDecl): (ClauseListNode::processFuncDecl): (CaseBlockNode::processFuncDecl): (SwitchNode::processFuncDecl):
  • kjs/nodes.h: (KJS::CaseClauseNode::CaseClauseNode): (KJS::ClauseListNode::ClauseListNode): (KJS::ClauseListNode::getClause): (KJS::ClauseListNode::getNext): (KJS::ClauseListNode::releaseNext): (KJS::SwitchNode::SwitchNode): Add processFuncDecl for the relevant nodes.
  • kjs/nodes2string.cpp: (CaseClauseNode::streamTo): next got renamed to source.

LayoutTests:

2006-05-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • fast/js/function-declarations-in-switch-statement-expected.txt: Added.
  • fast/js/function-declarations-in-switch-statement.html: Added.
  • fast/js/resources/function-declarations-in-switch-statement.js: Added.
1:57 AM Changeset in webkit [14501] by ap
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • page/FrameView.cpp: (WebCore::selectCursor): Fallback to CURSOR_AUTO if the image is an error image.
  • manual-tests/custom-cursors.html: Added.
1:47 AM Changeset in webkit [14500] by ap
  • 3 edits
    4 adds in trunk

2006-05-20 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by ap.

Test: fast/table/empty-section-crash.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): Return immediately if the section has 0 rows or 0 columns.

May 19, 2006:

10:52 PM Changeset in webkit [14499] by hyatt
  • 1 edit in trunk/WebCore/platform/cairo/ImageCairo.cpp

Fix Win32 bustage caused by image document. supportsType is not implemented yet for ImageCairo, so we'll return false rather than true to keep every document from being an image document.

5:21 PM Changeset in webkit [14498] by lweintraub
  • 7 edits
    5 adds in trunk

LayoutTests:

Reviewed by justin.


Tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8931>
Drag caret not painted for editable sub-frames

  • editing/resources/select-and-drag-iframe.html: Added.
  • editing/selection/drag-in-iframe-expected.checksum: Added.
  • editing/selection/drag-in-iframe-expected.png: Added.
  • editing/selection/drag-in-iframe-expected.txt: Added.
  • editing/selection/drag-in-iframe.html: Added.

WebCore:

Reviewed by justin.


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8931>
Drag caret not painted for editable sub-frames


Moved the drag caret out of Frame and into Page.
Only the Frame that contains the drag caret will paint it.

  • editing/SelectionController.h:
  • page/Frame.cpp: (WebCore::Frame::dragCaret): (WebCore::Frame::setDragCaret): (WebCore::Frame::paintDragCaret):
  • page/FramePrivate.h:
  • page/Page.cpp: (WebCore::Page::dragCaret): (WebCore::Page::setDragCaret):
  • page/Page.h:
4:16 PM Changeset in webkit [14497] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • html/HTMLButtonElement.idl: added support for HTMLButtonElement.click()
2:18 PM Changeset in webkit [14496] by aliceli1
  • 2 adds in trunk/LayoutTests/fast/forms
12:35 PM Changeset in webkit [14495] by ggaren
  • 9 edits
    2 adds in trunk

LayoutTests:

  • Test for overriding non-autogenerated global constructors.
  • fast/dom/constructors-overriding-expected.txt: Added.
  • fast/dom/constructors-overriding.html: Added.

WebCore:

Reviewed by Eric.

  • Fixed non-autogenerated global constructors to match autogenerated ones and FF. (Found this bug while @ the GOOG.)

(1) They're no longer read-only, so they can be overridden.
(2) They now have the default object prototype, so they can do things
like 'toString' and 'valueOf', necessary for general functionality,
including my layout test.
(3) Their prototype properties are now enumerable and not read-only.


  • bindings/js/JSDOMParser.cpp: (KJS::DOMParserConstructorImp::DOMParserConstructorImp):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXMLSerializer.cpp: (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp):
  • bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
  • bindings/js/kjs_html.cpp: (KJS::OptionConstructorImp::OptionConstructorImp): (KJS::ImageConstructorImp::ImageConstructorImp):
  • bindings/js/kjs_window.cpp:
12:07 PM Changeset in webkit [14494] by thatcher
  • 1 copy in tags/JavaScriptCore-418.2/JavaScriptCore

Tag for JavaScriptCore 418.2 (part 2 of 2.)

12:07 PM Changeset in webkit [14493] by thatcher
  • 1 add in tags/JavaScriptCore-418.2

Tag for JavaScriptCore 418.2 (part 1 of 2.)

12:06 PM Changeset in webkit [14492] by thatcher
  • 1 copy in tags/WebCore-418.8/WebCore

Tag for WebCore 418.8 (part 2 of 2.)

12:06 PM Changeset in webkit [14491] by thatcher
  • 1 add in tags/WebCore-418.8

Tag for WebCore 418.8 (part 1 of 2.)

12:05 PM Changeset in webkit [14490] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning

12:01 PM Changeset in webkit [14489] by thatcher
  • 9 edits in branches/Safari-2-0-branch

JavaScriptCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4543569> 10.4.7 regression: Crash occurs when attempting to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)
  • Major fix: On alternate threads, DOMObjects remain in the ScriptInterpreter's cache because they're not collected. So, they need an opportunity to mark their children.
  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/internal.cpp: (InterpreterImp::mark):
  • kjs/internal.h:
  • kjs/interpreter.h: (KJS::Interpreter::mark):

WebCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4543569> 10.4.7 regression: Crash occurs when attempting to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)
  • Minor fix: DOMParserConstructor needed to inherit from DOMObject to prevent collection on alternate threads.
  • Major fix: On alternate threads, DOMObjects remain in the ScriptInterpreter's cache because they're not collected. So, they need an opportunity to mark their children.
  • khtml/ecma/domparser.h:
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::mark):
  • khtml/ecma/kjs_binding.h:
11:42 AM Changeset in webkit [14488] by lweintraub
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by justin.

When the paste performance fix was merged over, uses of isCandidate
were changed to isRenderedContent. isRenderedContent on the branch
is incorrect in a few ways.

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init):
11:17 AM Changeset in webkit [14487] by thatcher
  • 1 copy in tags/WebKit-418.6/WebKit

Tag for WebKit 418.6 (part 2 of 2.)

11:17 AM Changeset in webkit [14486] by thatcher
  • 1 add in tags/WebKit-418.6

Tag for WebKit 418.6 (part 1 of 2.)

11:16 AM Changeset in webkit [14485] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

10:55 AM Changeset in webkit [14484] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-18 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4551938> More options needed for window display throttle

We decided to play it safe and leave our window flushing behavior unchanged from the previous
public release. By default, CoreGraphics deferred updates are once again OFF, and the window
display throttle is OFF.

Individual applications should set the WebKitThrottleWindowDisplayPreferenceKey and
WebKitEnableDeferredUpdatesPreferenceKey defaults to suit their needs.

Old behavior (like 10.4.6): WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
WebKitEnableDeferredUpdatesPreferenceKey (or unset).

Tear-free scrolling/animations: WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
WebKitEnableDeferredUpdatesPreferenceKey=1. While this configuration fixes the tearing issues
caused by over-flushing, some applications will experience performance problems as over-flushing
with CG deferred updates enabled will cause the app to block.

Tear-free scrolling/animations, high performance: WebKitThrottleWindowDisplayPreferenceKey=1,
WebKitEnableDeferredUpdatesPreferenceKey=1. This is the riskiest configuration in that it
enables the window display throttle "feature", potentially breaking applications' assumptions
about when displays occur. However, it provides the "best of both worlds", in that updates
are tear-free, and performance impact should me minimal.

  • WebView/WebPreferenceKeysPrivate.h: Declared WebKitThrottleWindowDisplayPreferenceKey and WebKitEnableDeferredUpdatesPreferenceKey.
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Turn off CG deferred updates if WebKitEnableDeferredUpdatesPreferenceKey is NO or has no value. Added some comments.
3:53 AM Changeset in webkit [14483] by andersca
  • 11 edits
    22 adds in trunk/WebCore

2006-05-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8983
Autogenerate another 22 HTML classes


Already covered by existing DOM tests.

  • DerivedSources.make:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Add new IDL files and generated sources.


  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::createPattern): Use JSHTMLImageElement::info in inherits.


  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSWrapper): Add macros for the functions and the code to populate the hash set.


  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Delete old cruft.


  • bindings/scripts/CodeGeneratorJS.pm: Add support for creating a JS object from a HTMLCollection.


  • html/HTMLAreaElement.idl: Added.
  • html/HTMLBRElement.idl: Added.
  • html/HTMLBaseFontElement.idl: Added.
  • html/HTMLBlockquoteElement.idl: Added.


  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):
  • html/HTMLBodyElement.h: Add new functions that used to be implemented in kjs_html.cpp


  • html/HTMLBodyElement.idl: Added.
  • html/HTMLFieldSetElement.idl: Added.
  • html/HTMLFontElement.idl: Added.
  • html/HTMLHRElement.idl: Added.
  • html/HTMLHeadingElement.idl: Added.
  • html/HTMLImageElement.idl: Added.
  • html/HTMLIsIndexElement.idl: Added.
  • html/HTMLLIElement.idl: Added.
  • html/HTMLLabelElement.idl: Added.
  • html/HTMLLegendElement.idl: Added.
  • html/HTMLMapElement.idl: Added.
  • html/HTMLMenuElement.idl: Added.
  • html/HTMLModElement.idl: Added.
  • html/HTMLParagraphElement.idl: Added.
  • html/HTMLParamElement.idl: Added.
  • html/HTMLPreElement.idl: Added.
  • html/HTMLQuoteElement.idl: Added.
  • html/HTMLScriptElement.idl: Added.
Note: See TracTimeline for information about the timeline view.