Timeline

May 22, 2006:

6:36 PM Changeset in webkit [14532] by eseidel

• 2 edits in trunk/WebCore

2006-05-22 Eric Seidel <​eric@eseidel.com>

Rubber-stamped by adele.

• bindings/js/kjs_html.h: simple style cleanup.

4:55 PM Changeset in webkit [14531] by thatcher

• 1 copy in tags/Safari-521.10

Tag for 521.10

4:46 PM Changeset in webkit [14530] by thatcher

• 8 edits in /

Versioning.

4:30 PM Changeset in webkit [14529] by thatcher

• 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix when doing 'xcodebuild install'.

3:18 PM Changeset in webkit [14528] by thatcher

• 1 edit in trunk/WebCore/platform/mac/WebCoreSystemInterface.h

Build fix.

3:10 PM Changeset in webkit [14527] by justing

• 4 edits
  1 add
  1 delete in trunk/LayoutTests

Reviewed by levi

Fixed and reenabled this test.

• editing/selection/drag-to-contenteditable-iframe-expected.checksum:
• editing/selection/drag-to-contenteditable-iframe-expected.png:
• editing/selection/drag-to-contenteditable-iframe-expected.txt:
• editing/selection/drag-to-contenteditable-iframe.html: Added.
• editing/selection/drag-to-contenteditable-iframe.html-disabled: Removed.

2:51 PM Changeset in webkit [14526] by thatcher

• 1 copy in tags/WebKit-418.7/WebKit

Tag for WebKit 418.7 (part 2 of 2.)

2:51 PM Changeset in webkit [14525] by thatcher

• 1 add in tags/WebKit-418.7

Tag for WebKit 418.7 (part 1 of 2.)

2:51 PM Changeset in webkit [14524] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

2:41 PM Changeset in webkit [14523] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-22 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
opening file from file open dialog

Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's
machine.

• Misc/WebNSWindowExtras.m: (replacementDealloc): Cancel display timer before dealloc, not after. Cancelling the timer can cause a message to be sent to the window; best to do that before the window deallocates. (replacementFinalize): ditto

2:39 PM Changeset in webkit [14522] by thatcher

• 1 edit in trunk/JavaScriptCore/wtf/MathExtras.h

Removes svn:executable from MathExtras.h. Caused a build verification failure.

2:20 PM Changeset in webkit [14521] by sullivan

• 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

• fixed Bug 9038: Rework Document::TextMarker mechanism to not use deprecated data structures

Changed Document::markersForNode and Document::MarkerMap to use Vector rather than
DeprecatedValueList and DeprecatedValueListIterator.

• dom/Document.h:
• dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::copyMarkers): (WebCore::Document::removeMarkers): (WebCore::Document::markersForNode): (WebCore::Document::repaintMarkers): (WebCore::Document::shiftMarkers):

• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintAllMarkersOfType):

2:00 PM Changeset in webkit [14520] by thatcher

• 5 edits in trunk/WebCore/platform

64-bit build fix, and removes the workaround for <rdar://problem/4294625>.

1:55 PM Changeset in webkit [14519] by tomernic

• 2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
opening file from file open dialog

Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's
machine.

• Misc/WebNSWindowExtras.m: (replacementDealloc): Cancel display timer before dealloc, not after. Cancelling the timer can cause a message to be sent to the window; best to do that before the window deallocates. (replacementFinalize): ditto

1:21 PM Changeset in webkit [14518] by sfalken

• 2 edits in trunk/WebKitTools

2006-05-22 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.

Fix build.

• Spinneret/Spinneret.sln:

1:16 PM Changeset in webkit [14517] by sfalken

• 2 edits in trunk/WebKitWin

2006-05-22 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.

Fix build.

• WebKitWin.vcproj/WebKitWin.sln:

11:34 AM Changeset in webkit [14516] by lweintraub

• 11 edits
  2 adds in trunk

LayoutTests:

Reviewed by eric.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8393 <br>s created by createMarkup aren't valid xhtml Changes in case from innerHTML

• editing/execCommand/createLink-expected.txt:
• editing/execCommand/unlink-expected.txt:
• editing/input/attributed-substring-from-range-lines-expected.txt:
• fast/dom/Range/range-exceptions-expected.txt:
• fast/dom/Range/resources/range-exceptions.js:
• fast/innerHTML/005-expected.txt:
• fast/innerHTML/innerHTML-custom-tag-expected.txt:
• fast/innerHTML/innerHTML-cast.html: Added.
• fast/innerHTML/innerHTML-cast-expected.txt: Added.
• fast/xsl/xslt-processer-expected.txt:

WebCore:

Reviewed by Eric.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8393 <br>s created by createMarkup aren't valid xhtml Fixed uppered output from innerHTML

• editing/markup.cpp: (WebCore::startMarkup): (WebCore::endMarkup):

11:20 AM Changeset in webkit [14515] by thatcher

• 4 edits in trunk/JavaScriptCore

Reviewed by Eric, Kevin and Geoff.

Merge open source build fixes. <rdar://problem/4555500>

• kjs/collector.cpp: look at the rsp register in x86_64 (KJS::Collector::markOtherThreadConservatively):
• wtf/Platform.h: add x86_64 to the platform list

1:04 AM Changeset in webkit [14514] by hyatt

• 1 edit in trunk/WebCore/platform/mac/FontCacheMac.mm

Fix Mac bustage.

May 21, 2006:

11:19 PM Changeset in webkit [14513] by hyatt

• 1 edit in trunk/WebCore/platform/win/FontDataWin.cpp

Fix win32 bustage.

11:18 PM Changeset in webkit [14512] by hyatt

• 5 edits
  3 adds in trunk/WebCore

Fix win32 bustage.

4:42 PM Changeset in webkit [14511] by adele

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9016 crash loading live.com in TreeShared::ref because accessing RenderTextField::text() can destroy the RenderTextField

• rendering/RenderTextField.cpp: (WebCore::RenderTextField::text): Reverting recent change to user innerText instead of textContent. For textareas, we need a better solution than textContent that also takes newlines into account, but this should fix this crasher.

12:51 AM Changeset in webkit [14510] by andersca

• 1 edit
  1 add in trunk/WebCore

2006-05-21 Anders Carlsson <​acarlsson@apple.com>

Fix build.

• ForwardingHeaders/wtf/MathExtras.h: Added.

12:18 AM Changeset in webkit [14509] by hyatt

• 1 edit in trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Add mathextras to javascrtipcore project.

12:05 AM Changeset in webkit [14508] by hyatt

• 1 edit in trunk/WebCore/platform/mac/FontPlatformData.h

Fix mac bustage. Minor snafu in constructor.