Context Navigation

bindings/js/kjs_html.cpp: added bindings (KJS::HTMLElementFunction::callAsFunction): added case to handle namedItem for select elements
bindings/js/kjs_html.h: added enum value for bindings (KJS::JSHTMLElement::):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): implemented namedItem method
html/HTMLSelectElement.h: added prototype for namedItem method

4:45 PM Changeset in webkit [14601] by hyatt

2 edits in trunk/WebCore

Add soft hyphen support for Win32.

4:18 PM Changeset in webkit [14600] by hyatt

2 edits in trunk/WebCore

Implement containsCharacters method on Win32 for determining if a fallback font has the necessary glyphs to be used.

3:42 PM Changeset in webkit [14599] by hyatt

7 edits
1 add
1 delete in trunk/WebCore

Remove the logical scale factor from Cairo Win32 fonts.

3:17 PM Changeset in webkit [14598] by eseidel

5 edits
3 adds in trunk

2006-05-25 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8848 TFOOT borders are copied to THEAD and TBODY

Test: fast/table/border-collapsing/border-collapsing-head-foot.html

rendering/RenderTable.cpp: (WebCore::RenderTable::sectionAbove): Added. (WebCore::RenderTable::sectionBelow): Added. (WebCore::RenderTable::cellAbove): Changed to call sectionAbove. (WebCore::RenderTable::cellBelow): Changed to call sectionBelow.
rendering/RenderTable.h:
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedTopBorder): Changed to call sectionAbove. (WebCore::RenderTableCell::collapsedBottomBorder): Changed to call sectionBelow.

3:11 PM Changeset in webkit [14597] by eseidel

39 edits in trunk

2006-05-25 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3297 height property is not honored on table rows

rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Assign the row renderer to the grid row. (WebCore::RenderTableSection::calcRowHeight): Fix off-by-one index bug and add vertical spacing only for grid rows that have a renderer. (WebCore::RenderTableSection::recalcCells): Assign row renderers to grid rows.

3:05 PM Changeset in webkit [14596] by eseidel

1 delete in trunk/WebCore/WebCore

Remove bogus directory

3:00 PM Changeset in webkit [14595] by eseidel

9 edits in trunk/WebCore

2006-05-19 Rob Buis <buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5978
WebKIt+SVG should use SVGDocumentImpl for image/svg+xml

Make sure SVGDocument is created for standalone svg
documents.

ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::instance): (SVGDOMImplementation::createDocument):
ksvg2/svg/SVGDOMImplementation.h:
ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument): (WebCore::SVGDocument::~SVGDocument):
ksvg2/svg/SVGDocument.h:
ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
ksvg2/svg/SVGTitleElement.cpp:
ksvg2/svg/SVGTitleElement.h:
page/Frame.cpp: (WebCore::Frame::begin):

2:55 PM Changeset in webkit [14594] by eseidel

5 edits
6 adds
2 deletes in trunk/WebCore

2006-05-17 Rob Buis <buis@kde.org>

Reviewed by darin. Landed by eseidel.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5889
HTMLNames.* should be generated using make_names.pl

Use a patched make_names.pl to autogenerate HTMLNames.*

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
html/HTMLNames.cpp: Removed.
html/HTMLNames.h: Removed.
html/HTMLTagNames.in: Added.
html/HTMLAttributeNames.in: Added.
ksvg2/scripts/make_names.pl:

2:41 PM Changeset in webkit [14593] by eseidel

24 edits
5 adds in trunk

2006-05-23 Eric Seidel <eric@eseidel.com>

Reviewed by andersca.

Add "HasIndexGetter" support to bindings autogen system.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9057

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLInputElementBase.cpp:
bindings/js/kjs_css.cpp: (KJS::toJS):
bindings/js/kjs_css.h:
bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::getOwnPropertySlot):
bindings/scripts/CodeGeneratorJS.pm:
css/CSSValueList.idl: Added.

1:15 PM Changeset in webkit [14592] by thatcher

1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix

12:10 PM Changeset in webkit [14591] by thatcher

3 copies in tags/WebKit-521.11.1/WebKit

Tag for WebKit 521.11.1 (part 2 of 2.)

12:09 PM Changeset in webkit [14590] by thatcher

1 delete in tags/WebKit-521.11.1/WebKit

Bad tag.

12:09 PM Changeset in webkit [14589] by thatcher

1 copy in tags/WebKit-521.11.1/WebKit

Tag for WebKit 521.11.1 (part 2 of 2.)

12:07 PM Changeset in webkit [14588] by thatcher

1 add in tags/WebKit-521.11.1

Tag for WebKit 521.11.1 (part 1 of 2.)

12:06 PM Changeset in webkit [14587] by thatcher

2 edits in /

Versioning

12:00 PM Changeset in webkit [14586] by thatcher

27 edits
1 add in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4559808> WebKit fails to compile for ppc64
<rdar://problem/4522085> 64-bit: WebKit uses FSSpec which is not available in 64-bit
Gets WebKit building under 64-bit. Rename WebNSInt and WebNSUInt to WebNSInteger and WebNSUInteger.
Start using WebNSInteger where we need to match AppKit API usage of NSInteger.

HIWebView and a couple of helper functions are disabled until they can be moved off of QuickDraw.
<rdar://problem/4561772> HIWebView needs to be reworked to not use QuickDraw, needed for 64-bit

Carbon/CarbonUtils.m: disabled this file in 64-bit <rdar://problem/4561772>
Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
Carbon/CarbonWindowFrame.m: (+[CarbonWindowFrame frameRectForContentRect:styleMask:]): (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame frameRectForContentRect:styleMask:]): (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]):
Carbon/HIViewAdapter.m: disabled this file in 64-bit <rdar://problem/4561772>
Carbon/HIWebView.m: disabled this file in 64-bit <rdar://problem/4561772> (HIWebViewEventHandler):
DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
History/WebBackForwardList.m: (-[WebBackForwardList removeItem:]): (-[WebBackForwardList goToItem:]):
Misc/WebDownload.m: (-[WebDownloadInternal download:didReceiveDataOfLength:]):
Misc/WebFileDatabase.m: (UniqueFilePathForKey):
Misc/WebIconDatabase.m: (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _totalRetainCountForIconURLString:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]):
Misc/WebSearchableTextView.m: (-[NSString selectionRect]):
Misc/WebTypesInternal.h: Added.
Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _destroyStream]): (CarbonPathFromPOSIXPath):
Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (TSMEventHandler): (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]): (-[NSData _web_locationAfterFirstBlankLine]):
Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage hash]):
Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (functionPointerForTVector):
WebInspector/WebInspector.m: (-_updateSystemColors):
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (-[WebDataSource _didReceiveData:contentLength:forResource:]):
WebView/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
WebView/WebHTMLView.m: (-[NSArray drawRect:]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView conversationIdentifier]):
WebView/WebResourceLoadDelegate.h:
WebView/WebUIDelegate.h:
WebView/WebView.h:
WebView/WebView.m: (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView spellCheckerDocumentTag]):
WebView/WebViewInternal.h:
WebView/WebViewPrivate.h:

10:57 AM Changeset in webkit [14585] by brmorris

1 edit in S60/trunk/runATF.bat

S60Webkit:

2006-05-25 Bradley <bradley.morrison@nokia.com>

Reviewed by Franklin.

runATF.bat sets compile environment
(fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9106)

1:08 AM Changeset in webkit [14584] by hyatt

1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

Modify DumpRenderTree so it will be able to spit out expected-win.txt files for win32 layout test results.

12:35 AM Changeset in webkit [14583] by hyatt

2 edits in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree

Fix DumpRenderTree so that it works again.

May 24, 2006:

10:52 PM Changeset in webkit [14582] by hyatt

4 edits in trunk/WebCore

Implement font aliasing of family names for Courier/Courier New,
Arial/Helvetica, and Times/Times New Roman. This behavior matches
WinIE and Firefox.

Reviewed by maciej

Test cases not really possible, since they would have to rely on people
not having the fonts installed (so not having installed Office).

platform/FontCache.cpp: (WebCore::alternateFamilyName): (WebCore::FontCache::getCachedFontPlatformData):
platform/FontCache.h:
rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeLeftoverAnonymousBoxes):

5:43 PM Changeset in webkit [14581] by bdakin

1 edit
1 move
3 adds
3 deletes in trunk/LayoutTests

Reviewed by Geoff.

This layout test is now correct, so I moved it into the expected
successes directory and generated new results.

tables/mozilla/bugs/bug222846-expected.checksum: Added.
tables/mozilla/bugs/bug222846-expected.png: Added.
tables/mozilla/bugs/bug222846-expected.txt: Added.
tables/mozilla/bugs/bug222846.html: Added.
tables/mozilla_expected_failures/bugs/bug222846- expected.checksum: Removed.
tables/mozilla_expected_failures/bugs/bug222846-expected.png: Removed.
tables/mozilla_expected_failures/bugs/bug222846-expected.txt: Removed.
tables/mozilla_expected_failures/bugs/bug222846.html: Removed.

5:40 PM Changeset in webkit [14580] by thatcher

8 copies in tags/Safari-521.11

Tag

5:34 PM Changeset in webkit [14579] by thatcher

6 edits in /

Versioning

4:49 PM Changeset in webkit [14578] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by levi

editing/selection/designmode-no-caret-expected.checksum: Added.
editing/selection/designmode-no-caret-expected.png: Added.
editing/selection/designmode-no-caret-expected.txt: Added.
editing/selection/designmode-no-caret.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4549610> REGRESSION: No initial cursor in Mail reply or Blot document
<rdar://problem/4560698> Mail is very crashy in Leopard9A182, WebCore::Range::compareBoundaryPoints(WebCore::Node*, int, WebCore::Node*, int)

page/Frame.cpp: (WebCore::Frame::setSelectionFromNone): Find the body and stick a caret in it.

4:41 PM Changeset in webkit [14577] by sullivan

2 edits in trunk/WebKitSite

Reviewed by John Sullivan.

quality/lifecycle.html: mentions case of PlatformOnly bugs

and 'other' bug databases.

4:33 PM Changeset in webkit [14576] by hyatt

4 edits in trunk/WebCore/platform

Add support for IMLangFontLink2 to map to a similar font that has missing characters on Win32.

4:18 PM Changeset in webkit [14575] by ggaren

4 edits in trunk/WebCore

Rubber stamped by Anders.

Removed meaningless 'dom::' prefix in IDL files.

dom/Range.idl:
html/CanvasRenderingContext2D.idl:
html/HTMLOptionElement.idl:

4:13 PM Changeset in webkit [14574] by ggaren

3 edits
2 adds in trunk

LayoutTests:

Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9095 regression: can't select by setting option.selected to true

fast/dom/option-properties-expected.txt: Added.
fast/dom/option-properties.html: Added.

WebCore:

Reviewed by andersca.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9095 regression: can't select by setting option.selected to true

'text' and 'selected' were erroneously marked read-only for option elements.

html/HTMLOptionElement.idl:

4:02 PM Changeset in webkit [14573] by brmorris

7 edits in S60/trunk

S60Webkit:

2006-05-25 Mario Borges

Reviewed by bradleym.

better support for SISX using ARMV5
updated def files

3:57 PM Changeset in webkit [14572] by thatcher

1 copy in tags/WebCore-418.9/WebCore

Tag for WebCore 418.9 (part 2 of 2.)

3:56 PM Changeset in webkit [14571] by thatcher

1 add in tags/WebCore-418.9

Tag for WebCore 418.9 (part 1 of 2.)

3:56 PM Changeset in webkit [14570] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:42 PM Changeset in webkit [14569] by ggaren

19 edits
6 adds in trunk

JavaScriptCore:

Reviewed by mjs.

JSC half of fix for <rdar://problem/4557926> TOT REGRESSSION: Crash occurs when attempting to view image in slideshow mode at http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)

On alternate threads, DOMObjects remain in the
ScriptInterpreter's cache because they're not collected. So, they
need an opportunity to mark their children.

I'm not particularly happy with this solution because it fails to
resolve many outstanding issues with the DOM object cache. Since none
of those issues is a crasher or a serious compatibility concern,
and since the behavior of other browsers is not much to go on in this
case, I've filed <rdar://problem/4561439> about that, and I'm moving on
with my life.

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/collector.cpp: (KJS::Collector::collect):
kjs/internal.cpp: (KJS::InterpreterImp::mark):
kjs/internal.h:
kjs/interpreter.cpp: (KJS::Interpreter::mark):
kjs/interpreter.h:

LayoutTests:

Layout tests for DOM object cache and garbage collection,
<rdar://problem/4557926> TOT REGRESSION: Crash occurs when attempting
to view image in slideshow mode at http://d.smugmug.com/gallery/581716
( KJS::IfNode::execute (KJS::ExecState*) + 312) if you use a PAC file

fast/dom/gc-8-expected.txt: Added.
fast/dom/gc-8.html: Added.
fast/dom/gc-9-expected.txt: Added.
fast/dom/gc-9.html: Added.

WebCore:

Reviewed by mjs.

WebCore half of fix for <rdar://problem/4557926> TOT REGRESSION: Crash occurs when attempting to view image in slideshow mode at http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)

On alternate threads, DOMObjects remain in the
ScriptInterpreter's cache because they're not collected. So, they
need an opportunity to mark their children.

I'm not particularly happy with this solution because it fails to
resolve many outstanding issues with the DOM object cache. Since none
of those issues is a crasher or a serious compatibility concern,
and since the behavior of other browsers is not much to go on in this
case, I've filed <rdar://problem/4561439> about that, and I'm moving
on with my life.

Also added functionality for testing garbage collection from inside
DumpRenderTree.

Also removed XMLHttpRequest from the DOM object cache because XMLHttpRequest
objects aren't accessed through the DOM.

Also added JS locking around access to some shared data structures in
WebCoreJavaScript, even though it probably doesn't matter in practice.

bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::mark):
bindings/js/kjs_binding.h:
bridge/mac/WebCoreJavaScript.h:
bridge/mac/WebCoreJavaScript.mm: (collect): (+[WebCoreJavaScript objectCount]): (+[WebCoreJavaScript interpreterCount]): (+[WebCoreJavaScript protectedObjectCount]): (+[WebCoreJavaScript garbageCollect]): (+[WebCoreJavaScript garbageCollectOnAlternateThread:]): (+[WebCoreJavaScript shouldPrintExceptions]): (+[WebCoreJavaScript setShouldPrintExceptions:]):

WebKitTools:

Reviewed by mjs.

Added 'GCController' to DRT to support garbage collection layout tests.

GCController.collect() and GCController.collectOnAlternateThread() do
what you would expect. The latter takes a boolean argument sepcifying
whether to wait for garbage collection to finish before continuing to
execute script.

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/GCController.h: Added.
DumpRenderTree/GCController.mm: Added. (+[GCController isSelectorExcludedFromWebScript:]): (+[GCController webScriptNameForSelector:]): (-[GCController collect]): (-[GCController collectOnAlternateThread:]):

3:39 PM Changeset in webkit [14568] by kdecker

2 edits in branches/Safari-2-0-branch/WebCore

3:32 PM Changeset in webkit [14567] by jdevalk

3 edits in trunk/WebKitSite

Adding Google Analytics code, to create visitor stats of our site.

2:54 PM Changeset in webkit [14566] by hyatt

3 edits in trunk/WebCore

Move font destruction for HFONTs and cairo objects into FontData.

1:48 PM Changeset in webkit [14565] by brmorris

1 edit in S60/trunk/WebKit/Plugin/inc/jri.h

S60WebKit:

Reviewed by bradleym

2006-05-24 Pat

Removing JRE dependency in Plugin/inc/jri.h

12:26 PM Changeset in webkit [14564] by andersca

7 edits
2 adds in trunk

WebCore:

2006-05-24 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
Implement document.scripts

bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty): Return document.scripts() instead of a placeholder object.

dom/Document.cpp: (WebCore::Document::scripts):
dom/Document.h: Add Document::scripts.

html/HTMLCollection.cpp: (WebCore::HTMLCollection::traverseNextItem):
html/HTMLCollection.h: (WebCore::HTMLCollection::): Add scripts collection type which traverses all script elements.

LayoutTests:

2006-05-24 Anders Carlsson <acarlsson@apple.com>