⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 30, 2006:

9:12 PM Changeset in webkit [14641] by thatcher
  • 1 copy in tags/WebCore-418.11/WebCore

Tag for WebCore 418.11 (part 2 of 2.)

9:12 PM Changeset in webkit [14640] by thatcher
  • 1 add in tags/WebCore-418.11

Tag for WebCore 418.11 (part 1 of 2.)

9:11 PM Changeset in webkit [14639] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

6:48 PM Changeset in webkit [14638] by hyatt
  • 41 edits
    1 copy
    2 moves in trunk/WebCore

Rename RenderCanvas to RenderView. Rename canvas(), isCanvas()
to view(), isView(). Rename the frame view accessor on the old canvas
from view() to frameView() (to avoid view()->view(), since that just looks
stupid). :)

Reviewed by andersca

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_window.cpp:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _setupRootForPrinting:]): (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreFrameBridge selectionColor]): (-[WebCoreFrameBridge accessibilityTree]):
  • dom/Document.cpp: (WebCore::Document::attach): (WebCore::Document::updateSelection): (WebCore::Document::prepareMouseEvent):
  • editing/SelectionController.cpp:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
  • ksvg2/svg/SVGHelper.cpp: (SVGHelper::PercentageOfViewport):
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentTranslate):
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::view): (WebCore::SVGStyledElement::pushAttributeContext):
  • ksvg2/svg/SVGStyledElement.h:
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityShouldUseUniqueId]): (-[WebCoreAXObject role]): (-[WebCoreAXObject value]): (-[WebCoreAXObject position]): (-[WebCoreAXObject accessibilityIsIgnored]): (-[WebCoreAXObject accessibilityAttributeNames]): (-[WebCoreAXObject topView]): (-[WebCoreAXObject accessibilityAttributeValue:]):
  • page/Frame.cpp: (WebCore::Frame::selectionRect): (WebCore::Frame::paint): (WebCore::Frame::adjustPageHeight): (WebCore::Frame::forceLayoutWithPageWidthRange):
  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::layout):
  • page/FrameView.h:
  • rendering/AutoTableLayout.cpp: (WebCore::shouldScaleColumns):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::MarginInfo::MarginInfo): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::fillInlineSelectionGaps): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::calcBlocminMaxWidth): (WebCore::RenderBlock::inRootBlockContext):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::availableHeightUsing):
  • rendering/RenderCanvas.cpp: Removed.
  • rendering/RenderCanvas.h: Removed.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode):
  • rendering/RenderFileButton.cpp: (WebCore::RenderFileButton::RenderFileButton):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::paintLines):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::userResize): (WebCore::RenderFrameSet::setResizing):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::scrollToOffset): (WebCore::isSubframeCanvas): (WebCore::RenderLayer::intersectsDamageRect):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::isStackingContext):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::scroll): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::selectionStartEnd): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::viewRect): (WebCore::RenderObject::view): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::maximalOutlineSize):
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderView):
  • rendering/RenderTextArea.cpp: (WebCore::RenderTextArea::RenderTextArea):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::paintButton):
  • rendering/RenderTreeAsText.cpp: (externalRepresentation):
  • rendering/RenderView.cpp: Added. (WebCore::RenderView::RenderView): (WebCore::RenderView::~RenderView): (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): (WebCore::RenderView::calcMinMaxWidth): (WebCore::RenderView::layout): (WebCore::RenderView::absolutePosition): (WebCore::RenderView::paint): (WebCore::RenderView::paintBoxDecorations): (WebCore::RenderView::repaintViewRectangle): (WebCore::RenderView::getAbsoluteRepaintRect): (WebCore::RenderView::computeAbsoluteRepaintRect): (WebCore::RenderView::absoluteRects): (WebCore::RenderView::selectionRect): (WebCore::RenderView::setSelection): (WebCore::RenderView::clearSelection): (WebCore::RenderView::selectionStartEnd): (WebCore::RenderView::updateWidgetPositions): (WebCore::RenderView::addWidget): (WebCore::RenderView::removeWidget): (WebCore::RenderView::viewRect): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth): (WebCore::RenderView::setBestTruncatedAt):
  • rendering/RenderView.h: Added. (WebCore::RenderView::renderName): (WebCore::RenderView::isRenderView): (WebCore::RenderView::frameView):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::RenderWidget): (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::updateWidgetPosition):
  • rendering/RenderWidget.h: (WebCore::RenderWidget::widget):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
6:31 PM Changeset in webkit [14637] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4567776> REGRESSION: window.open() links do not work at www.newarchery.com

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Set the URL in the ResourceRequest; otherwise, it'll be uninitialized and createNewWindow() will not be able to load the URL into a pre-existing frame.
2:56 PM Changeset in webkit [14636] by lweintraub
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by justin.

<rdar://problem/4039661> crash in ApplyStyleCommand::applyBlockStyle(DOM::CSSMutableStyleDeclarationImpl*, DOM::Position const&, DOM::Position const&) pasting contents of webpage into Mail or Blot
<rdar://problem/4029632> Mail crashes in DOM::NodeImpl::isBlockFlow() after pasting text with alignment style and BR element from Safari

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::applyBlockStyle): Swap reversed start and end selection points to avoid null dereference. (khtml::ApplyStyleCommand::removeInlineStyle): Modified assert to not complain about caret selections.
2:53 PM Changeset in webkit [14635] by brmorris
  • 1 edit
    1 add in S60/trunk

S60WebKit:

2006-05-30 Bradley Morrison <bradley.morrison@nokia.com>

Reviewed by Antti K/Zalan


2:10 PM Changeset in webkit [14634] by bdakin
  • 3 edits
    8 adds in trunk

Reviewed by Maciej, landed by Beth.

Adds special case.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing):
1:47 PM Changeset in webkit [14633] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Hyatt, landed by Beth.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
11:57 AM Changeset in webkit [14632] by thatcher
  • 1 copy in tags/JavaScriptCore-418.3/JavaScriptCore

Tag for JavaScriptCore 418.3 (part 2 of 2.)

11:57 AM Changeset in webkit [14631] by thatcher
  • 1 add in tags/JavaScriptCore-418.3

Tag for JavaScriptCore 418.3 (part 1 of 2.)

11:56 AM Changeset in webkit [14630] by thatcher
  • 1 copy in tags/WebCore-418.10/WebCore

Tag for WebCore 418.10 (part 2 of 2.)

11:56 AM Changeset in webkit [14629] by thatcher
  • 1 add in tags/WebCore-418.10

Tag for WebCore 418.10 (part 1 of 2.)

11:55 AM Changeset in webkit [14628] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning

11:32 AM Changeset in webkit [14627] by thatcher
  • 3 copies in tags/WebKit-521.12/WebKit

New tag (part 2)

11:31 AM Changeset in webkit [14626] by thatcher
  • 1 add in tags/WebKit-521.12

New tag

11:30 AM Changeset in webkit [14625] by thatcher
  • 2 copies in tags/WebCore-521.12/WebCore

New tag (part 2)

11:28 AM Changeset in webkit [14624] by thatcher
  • 1 add in tags/WebCore-521.12

New tag

11:20 AM Changeset in webkit [14623] by thatcher
  • 4 edits in /

Versioning

9:22 AM Changeset in webkit [14622] by thatcher
  • 8 edits in branches/Safari-2-0-branch

JavaScriptCore:

Reviewed by Maciej.


  • Rolling out the 'currentThreadIsMainThread' argument passed to Interpreter::mark because the fix for <rdar://problem/4562599> makes it superfluous.


  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/internal.cpp: (InterpreterImp::mark):
  • kjs/internal.h:
  • kjs/interpreter.h: (KJS::Interpreter::mark):

WebCore:

Reviewed by Maciej.


  • Fixed <rdar://problem/4562599> 10.4.7 regression: After closing a window that contains macworld.com, creating a new window results in crash (KJS::PropertyMap::mark() )

ScriptInterpreter used to be responsible for marking cached DOM objects.
That was insufficient because once all the windows are closed, there's
no ScriptInterpreter left to do the marking.


The solution here is to allocate a static, protected 'DOMObjectsMarker'
object that takes care of marking the DOM object caches.


  • khtml/ecma/kjs_binding.cpp: (KJS::DOMObjectsMarker::mark): (KJS::ScriptInterpreter::domObjects): (KJS::ScriptInterpreter::domNodesPerDocument):
  • khtml/ecma/kjs_binding.h:
1:34 AM Changeset in webkit [14621] by eseidel
  • 6 edits in trunk/WebCore

2006-05-30 Eric Seidel <eric@eseidel.com>

Reviewed by andersca.

Small amount of svg-related code cleanup.
No test case possible.

  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGLength.cpp: (SVGLength::SVGLength): (SVGLength::value):
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMatrix.cpp: (SVGMatrix::SVGMatrix): (SVGMatrix::copy): (SVGMatrix::postMultiply): (SVGMatrix::inverse): (SVGMatrix::postTranslate): (SVGMatrix::postScale): (SVGMatrix::postScaleNonUniform): (SVGMatrix::postRotate): (SVGMatrix::postRotateFromVector): (SVGMatrix::postFlipX): (SVGMatrix::postFlipY): (SVGMatrix::postSkewX): (SVGMatrix::postSkewY): (SVGMatrix::multiply): (SVGMatrix::translate): (SVGMatrix::scale): (SVGMatrix::scaleNonUniform): (SVGMatrix::rotate): (SVGMatrix::rotateFromVector): (SVGMatrix::flipX): (SVGMatrix::flipY): (SVGMatrix::skewX): (SVGMatrix::skewY): (SVGMatrix::setMatrix): (SVGMatrix::qmatrix): (SVGMatrix::removeScale):
  • ksvg2/svg/SVGMatrix.h:
1:30 AM Changeset in webkit [14620] by eseidel
  • 5 edits in trunk/WebCore

2006-05-30 Eric Seidel <eric@eseidel.com>

Reviewed by andersca.

Small ammount of bindings-related code cleanup.
No test case possible.

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSXMLSerializer.cpp: (WebCore::JSXMLSerializerConstructorImp::JSXMLSerializerConstructorImp): (WebCore::JSXMLSerializerConstructorImp::implementsConstruct): (WebCore::JSXMLSerializerConstructorImp::construct): (WebCore::): (WebCore::JSXMLSerializer::JSXMLSerializer): (WebCore::JSXMLSerializerProtoFunc::callAsFunction):
  • bindings/js/JSXMLSerializer.h: (WebCore::JSXMLSerializer::toBoolean): (WebCore::JSXMLSerializer::classInfo): (WebCore::JSXMLSerializer::):
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
Note: See TracTimeline for information about the timeline view.