Timeline
Jun 7, 2006:
- 9:04 PM Changeset in webkit [14768] by
-
- 17 edits in trunk
LayoutTests:
Reviewed by levi
- editing/deleting/delete-4038408-fix-expected.txt:
- editing/input/attributed-substring-from-range-lines-expected.txt:
- editing/inserting/insert-3654864-fix-expected.txt:
- editing/inserting/insert-3659587-fix-expected.txt:
- editing/inserting/insert-3775316-fix-expected.txt:
- editing/inserting/insert-at-end-01-expected.txt:
- editing/inserting/insert-at-end-02-expected.txt:
- editing/inserting/insert-br-001-expected.txt:
- editing/inserting/insert-br-005-expected.txt:
WebCore:
Reviewed by levi
Fixed some comments and removed an unused variable.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeBlockPlaceholder): Don't remove a br if it isn't at the start of a block, since it isn't really a "block placeholder".
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
- editing/htmlediting.cpp:
- 6:43 PM Changeset in webkit [14767] by
-
- 5 edits in trunk/WebKit
Add support for custom highlighting to WebKit.
Reviewed by justin
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:]):
- WebView/WebHTMLView.m: (-[WebHTMLView _highlighterForType:]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebHTMLViewPrivate.h:
- 6:41 PM Changeset in webkit [14766] by
-
- 8 edits in trunk/WebCore
Add support for custom highlighting. This is all ifdefed to be Mac-only.
Reviewed by justin
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::paintCustomHighlight):
- bridge/mac/WebCoreFrameBridge.h:
- platform/mac/ClipboardMac.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight):
- rendering/InlineTextBox.h:
- 6:25 PM Changeset in webkit [14765] by
-
- 17 edits2 adds in trunk
WebCore:
Reviewed by Hyatt
Added support for cross-platform resize property.
- platform/PlatformMouseEvent.h: Removed isMouseButtonDown, since we already cache this info when we handle mouse down and mouse up.
- platform/mac/MouseEventMac.mm: ditto.
- platform/win/TemporaryLinkStubs.cpp: ditto.
- page/Frame.cpp: (WebCore::Frame::autoscrollTimerFired): Use d->m_bMousePressed instead of isMouseButtonDown.
- page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent): Passes event to layer resize method. (WebCore::FrameView::mousePressed): Added.
- page/FrameView.h: Added mousePressed.
- rendering/RenderTheme.h: Removed paintResizeControl. Since its not dependent on the theme, the layer can just paint this.
- rendering/RenderTheme.cpp: ditto.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): Initializes m_resizeCornerImage. (WebCore::RenderLayer::~RenderLayer): Deletes m_resizeCornerImage. (WebCore::RenderLayer::resize): Uses passed in event instead of creating a new one. (WebCore::RenderLayer::paintResizeControl): Now loads and paints the resize image.
- rendering/RenderLayer.h: Added m_resizeCornerImage. Important to have one per-layer for when we allow more customization.
- platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource): Loads image resources.
WebKit:
Reviewed by Hyatt.
Added resources for missingImage and textAreaResizeCorner.
- COM/WebKitDLL.cpp: (loadResourceIntoArray): Added. Returns a DeprecatedByteArray with the resource's data.
- WebKit.vcproj/WebKit.rc: Added missing image and resize pngs as resources.
- WebKit.vcproj/WebKit.vcproj: Added pngs.
- WebKit.vcproj/missingImage.png: Added.
- WebKit.vcproj/resource.h: Added entries for pngs.
- WebKit.vcproj/textAreaResizeCorner.png: Added.
- 5:18 PM Changeset in webkit [14764] by
-
- 4 edits in trunk/WebKit
Add SPI for setting and removing custom highlighters.
Reviewed by Tim H
- WebView/WebHTMLView.m: (-[WebTextCompleteController dealloc]): (-[WebHTMLView _setHighlighter:ofType:]): (-[WebHTMLView _removeHighlighterOfType:]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebHTMLViewPrivate.h:
- 4:08 PM Changeset in webkit [14763] by
-
- 7 edits in trunk/WebCore
Add support for a new property for custom highlighting. This patch just
adds support for the parsing of the property. It doesn't do anything yet.
Reviewed by beth
- css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSPropertyNames.in:
- css/cssparser.cpp: (WebCore::CSSParser::parseValue):
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- rendering/render_style.cpp: (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): (WebCore::StyleCSS3InheritedData::operator==): (WebCore::RenderStyle::diff):
- rendering/render_style.h: (WebCore::RenderStyle::highlight): (WebCore::RenderStyle::setHighlight): (WebCore::RenderStyle::initialHighlight):
- 3:59 PM Changeset in webkit [14762] by
-
- 1 edit1 delete in trunk/JavaScriptCore
Removed API directory I prematurely/accidentally added.
- API: Removed.
- 9:33 AM Changeset in webkit [14761] by
-
- 2 edits4 adds in trunk
Fix suggested by Rob Buis. Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9341 REGRESSION: Repro crash caused by style="font:bold"
Test: fast/css/font-shorthand-weight-only.html
- css/cssparser.cpp: (WebCore::CSSParser::parseFont): Revert part of the change made to fix bug 5564.
- 9:29 AM Changeset in webkit [14760] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt, tweaked by Mitz.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9122 REGRESSION: Incorrect vertical position for text fields in a "display: table" block
- fast/table/text-field-baseline-expected.checksum: Added.
- fast/table/text-field-baseline-expected.png: Added.
- fast/table/text-field-baseline-expected.txt: Added.
- fast/table/text-field-baseline.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9122 REGRESSION: Incorrect vertical position for text fields in a "display: table" block
Test: fast/table/text-field-baseline.html
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::baselinePosition): Do not descend into replaced objects, just use their baseline.
- 9:26 AM Changeset in webkit [14759] by
-
- 5 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt.
- pixel test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4334 REGRESSION: Flickering when css-hover should change opacity on floating elements
- fast/block/float/nopaint-after-layer-destruction-expected.checksum: Added.
- fast/block/float/nopaint-after-layer-destruction-expected.png: Added.
- fast/block/float/nopaint-after-layer-destruction-expected.txt: Added.
- fast/block/float/nopaint-after-layer-destruction.html: Added.
WebCore:
Reviewed by Hyatt (concept) and Darin (some coding details).
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4334 REGRESSION: Flickering when css-hover should change opacity on floating elements
Pixel test: fast/block/float/nopaint-after-layer-destruction.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::setPaintsFloatingObject): Added. Changes the noPaint flag in the block's FloatingObject for the given float and calls setChildNeedsLayout.
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::blockThatPaintsFloat): Added this helper function. (WebCore::RenderBox::setStyle): Added. Calls to setPaintsFloatingObject when a float gains or loses its layer.
Jun 6, 2006:
- 8:14 PM Changeset in webkit [14758] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9322
Teach svn-create-patch to sort its output
- Scripts/svn-create-patch: Clean up perl code. Sort patch output alphabetically by text files first, then by binary files.
- 8:13 PM Changeset in webkit [14757] by
-
- 7 edits5 adds in trunk
LayoutTests:
Reviewed by Hyatt.
- repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9121 REGRESSION: [Incremental Repaint] DHTML movement test failures
- fast/repaint/containing-block-position-change-expected.checksum: Added.
- fast/repaint/containing-block-position-change-expected.png: Added.
- fast/repaint/containing-block-position-change-expected.txt: Added.
- fast/repaint/containing-block-position-change.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9121 REGRESSION: [Incremental Repaint] DHTML movement test failures
Test (repaint): fast/repaint/containing-block-position-change.html
- manual-tests/containing-block-position-chage.html: Added.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Unrelated change: fixed typo from the RenderCanvas to RenderView rename. (WebCore::RenderBlock::removePositionedObject): Added a return immediately after removing the object. (WebCore::RenderBlock::removePositionedObjects): Added.
- rendering/RenderBlock.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Added code to remove absolutely positioned descendants from the positioned objects list of their current containing block when they are going to have a new one as a result of this block's position property changing.
- rendering/RenderObject.h: (WebCore::RenderObject::removePositionedObjects):
- 8:12 PM Changeset in webkit [14756] by
-
- 4 edits in trunk/LayoutTests
- fast/repaint/table-extra-bottom-grow.html: Removed unneeded line of code.
- fast/repaint/table-extra-bottom-grow-expected.png: Regenerated.
- fast/repaint/table-extra-bottom-grow-expected.checksum: Regenerated.
- 5:25 PM Changeset in webkit [14755] by
-
- 1 copy in tags/WebCore-418.13/WebCore
Tag for WebCore 418.13 (part 2 of 2.)
- 5:25 PM Changeset in webkit [14754] by
-
- 1 add in tags/WebCore-418.13
Tag for WebCore 418.13 (part 1 of 2.)
- 5:19 PM Changeset in webkit [14753] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning
- 5:13 PM Changeset in webkit [14752] by
-
- 5 edits in branches/Safari-2-0-branch/WebCore
Fix by Maciej, reviewed by Darin. I provided desk space.
- Fixed <rdar://problem/4573918> 10.4.7 Regression: Hang randomly occurs when attempting to load http://www.apple.com/pro/profiles/ if you use a PAC file
Because the garbage collector suspends a thread while marking its stack,
mark methods must not call malloc, because they may end up stuck,
trying to acquire the malloc lock from a suspended thread.
The fix here is:
(1) Use a data member rather than a dictionary to track nodes that are
in the process of marking their subtrees.
(2) Avoid the case wheter calling getDOMNodeForDocument might allocate
the staticDOMNodesPerDocument dictionary.
- khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::domObjects): (KJS::ScriptInterpreter::domNodesPerDocument): (KJS::ScriptInterpreter::getDOMNodeForDocument):
- khtml/ecma/kjs_dom.cpp: (DOMNode::mark):
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl):
- khtml/xml/dom_nodeimpl.h:
- 5:09 PM Changeset in webkit [14751] by
-
- 86 edits12 adds in trunk
LayoutTests:
Reviewed by levi
Added to demonstrate fixes:
- editing/pasteboard/merge-after-delete-expected.checksum: Added.
- editing/pasteboard/merge-after-delete-expected.png: Added.
- editing/pasteboard/merge-after-delete-expected.txt: Added.
- editing/pasteboard/merge-after-delete.html: Added.
- editing/inserting/line-break-expected.checksum: Added.
- editing/inserting/line-break-expected.png: Added.
- editing/inserting/line-break-expected.txt: Added.
- editing/inserting/line-break.html: Added.
- editing/inserting/multiple-lines-selected-expected.checksum: Added.
- editing/inserting/multiple-lines-selected-expected.png: Added.
- editing/inserting/multiple-lines-selected-expected.txt: Added.
- editing/inserting/multiple-lines-selected.html: Added.
Fixed:
- editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- editing/deleting/delete-3775172-fix-expected.txt:
- editing/deleting/delete-3928305-fix-expected.txt:
- editing/deleting/delete-3959464-fix-expected.checksum:
- editing/deleting/delete-3959464-fix-expected.png:
- editing/deleting/delete-3959464-fix-expected.txt:
- editing/deleting/delete-4038408-fix-expected.checksum:
- editing/deleting/delete-4038408-fix-expected.png:
- editing/deleting/delete-4038408-fix-expected.txt:
- editing/deleting/delete-4038408-fix.html:
- editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
- editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
- editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- editing/deleting/delete-block-contents-001-expected.txt:
- editing/deleting/delete-block-contents-002-expected.txt:
- editing/deleting/delete-block-contents-003-expected.txt:
- editing/deleting/delete-br-011-expected.checksum:
- editing/deleting/delete-br-011-expected.png:
- editing/deleting/delete-br-011-expected.txt:
- editing/deleting/delete-image-004-expected.txt:
- editing/deleting/delete-line-010-expected.txt:
- editing/deleting/delete-line-015-expected.txt:
- editing/deleting/delete-select-all-001-expected.checksum:
- editing/deleting/delete-select-all-001-expected.png:
- editing/deleting/delete-select-all-001-expected.txt:
- editing/deleting/delete-select-all-002-expected.txt:
- editing/deleting/delete-select-all-003-expected.checksum:
- editing/deleting/delete-select-all-003-expected.png:
- editing/deleting/delete-select-all-003-expected.txt:
- editing/execCommand/insertImage-expected.checksum:
- editing/execCommand/insertImage-expected.png:
- editing/input/attributed-substring-from-range-lines-expected.txt:
- editing/input/text-input-controller-expected.txt:
- editing/inserting/insert-3654864-fix-expected.txt:
- editing/inserting/insert-3659587-fix-expected.txt:
- editing/inserting/insert-3775316-fix-expected.txt:
- editing/inserting/insert-after-delete-001-expected.txt:
- editing/inserting/insert-at-end-01-expected.txt:
- editing/inserting/insert-at-end-02-expected.txt:
- editing/inserting/insert-br-001-expected.txt:
- editing/inserting/insert-br-005-expected.txt:
- editing/pasteboard/4076267-3-expected.txt:
- editing/pasteboard/4076267-expected.txt:
- editing/pasteboard/drag-drop-modifies-page-expected.txt:
- editing/pasteboard/paste-4035648-fix-expected.txt:
- editing/pasteboard/paste-4039777-fix-expected.checksum:
- editing/pasteboard/paste-4039777-fix-expected.png:
- editing/pasteboard/paste-4039777-fix-expected.txt:
- editing/pasteboard/paste-match-style-001-expected.txt:
- editing/pasteboard/paste-match-style-002-expected.txt:
- editing/pasteboard/smart-paste-006-expected.txt:
- editing/pasteboard/smart-paste-007-expected.txt:
- editing/selection/drag-to-contenteditable-iframe-expected.txt:
- editing/style/block-style-005-expected.txt:
- editing/style/typing-style-002-expected.txt:
- editing/unsupported-content/list-delete-001-expected.checksum:
- editing/unsupported-content/list-delete-001-expected.png:
- editing/unsupported-content/list-delete-001-expected.txt:
- editing/unsupported-content/list-delete-002-expected.checksum:
- editing/unsupported-content/list-delete-002-expected.png:
- editing/unsupported-content/list-delete-002-expected.txt:
- editing/unsupported-content/table-delete-001-expected.checksum:
- editing/unsupported-content/table-delete-001-expected.png:
- editing/unsupported-content/table-delete-001-expected.txt:
- editing/unsupported-content/table-delete-003-expected.checksum:
- editing/unsupported-content/table-delete-003-expected.png:
- editing/unsupported-content/table-delete-003-expected.txt:
- fast/text/attributed-substring-from-range.html:
WebCore:
Reviewed by levi
- dom/Node.cpp: (WebCore::Node::firstDescendant): Added.
- dom/Node.h:
- dom/Range.cpp: Added a constructor that takes in Positions. (WebCore::Range::Range):
- dom/Range.h:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): Let this function insert children into empty containers. Calls canHaveChildrenForEditing. (WebCore::CompositeEditCommand::appendNode): Assert that the parent canHaveChildrenForEditing. (WebCore::CompositeEditCommand::moveParagraph): Tell ReplaceSelectionCommand to select the replacement so that moveParagraph's callers have a valid destination after the move.
- editing/CompositeEditCommand.h: Moved removeFullySelectedNode to DeleteSelectionCommand, made deleteTextFromNode virtual so that DeleteSelectionCommand can update it's endingPosition.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Removed m_startNode, used a local variable. (WebCore::DeleteSelectionCommand::initializeStartEnd): Fixed special element expansion. (WebCore::DeleteSelectionCommand::initializePositionData): Compute the endingPosition up front and keep track of it as nodes and text are removed. (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Removed use of m_startNode. (WebCore::DeleteSelectionCommand::removeFullySelectedNode): Moved from CompositeEditCommand. Update m_endingPosition as we remove nodes. (WebCore::DeleteSelectionCommand::deleteTextFromNode): Update m_endingPosition as we delete text. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Retain the start block. Cleaned up. (WebCore::DeleteSelectionCommand::mergeParagraphs): Recompute m_endingPosition since moveParagraph clobbers the old one. (WebCore::DeleteSelectionCommand::doApply): Fixed the logic for placeholder insertion after deletion. Make the placeholder decision before we do special element expansion.
- editing/DeleteSelectionCommand.h:
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Fixed a bug where an extra br was inserted and cleaned up the code.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Deletion of the current selection should do a merge (added a testcase).
- editing/RebalanceWhitespaceCommand.cpp: (WebCore::RebalanceWhitespaceCommand::doUnapply): Remove/insert in a way that will trigger a layout.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto. Merge even when the incoming fragment has interchange newlines (added a testcase). Merge when the selection being pasted into starts at the start of a block because not doing so would leave one or more hanging empty blocks. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Rebalance whitespace using rebalanceWhitespaceAt because rebalanceWhitespace requires a selection, and a selection can't be created until whitespace has been rebalanced.
- editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added.
- editing/htmlediting.h:
- 5:03 PM Changeset in webkit [14750] by
-
- 6 edits in trunk/WebCore
Reviewed by Maciej.
Fix for <rdar://problem/4570475> Dashboard regions do not scale for
non-1.0 scale factors.
No test cases added since this only affects non-1.0 resolution
scale factors.
- platform/FloatRect.cpp: (WebCore::FloatRect::scale): Added new function that scales a rect's origin and size by a given factor.
- platform/FloatRect.h:
- platform/IntRect.cpp: (WebCore::IntRect::scale): Same as above.
- platform/IntRect.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::addDashboardRegions): After the bounds and clip rects on the Dashboard region have been calculated, get the user space scale factor, and if it is not 1.0, scale the rects.
- 4:12 PM Changeset in webkit [14749] by
-
- 4 edits in S60/trunk
2006-06-06 Bradley <bradley.morrison@nokia.com>
Reviewed by dacarson
- WebKit\group\icons.mk
Added tabs back to icons.mk
- JavaScriptCore\group\Bwinscw\JAVASCRIPTCOREU.DEF
- WebCore\BWINS\WEBCOREU.DEF
Regenerated def files
- 3:58 PM Changeset in webkit [14748] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
- fixed <rdar://problem/4566087> REGRESSION (420+): Crash occurs while completing a find again query at http://www.apple.com/ (RenderObject::repaint(bool))
This wasn't a new problem in the code, but the recent use of DocumentMarkers for find results brought
it to the surface.
- dom/Document.h: Use a RefPtr<Node> instead of a Node* in MarkerMap, so the node will be retained
- dom/Document.cpp: (WebCore::Document::removeMarkers): Add a .get() to compensate for using RefPtr. Also, only repaint if this node actually had a marker removed. (WebCore::Document::repaintMarkers): Add a .get() to compensate for using RefPtr.
- 3:28 PM Changeset in webkit [14747] by
-
- 2 edits in trunk/WebKit
Reviewed by Justin.
- COM/WebView.cpp: (WebView::keyPress): Added case for VK_RETURN.
- 1:28 PM Changeset in webkit [14746] by
-
- 2 edits in S60/trunk
2006-06-06 Sachin <sachin.padma@nokia.com>
Reviewed by Zalan/Bradley
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9332
- WebKit\group\icons.mk
Search for GCCE in $(PLATFORM), not ARMV5.
- 12:10 PM Changeset in webkit [14745] by
-
- 5 edits in S60/trunk
2006-06-06 Sachin <sachin.padma@nokia.com>
Reviewed by Zalan/Bradley
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9332
- WebKit\group\icons.mk
- WebKit\group\webkit.mmp
- S60WebUi\WebUi\group\WebUi.mmp
Remove relative include paths for data_caging_paths.hrh,
rely on include path instead.
- S60Internals\S60Headers.zip
Moved data_caging_paths.hrh out of oem to \epoc32\include.
- 11:26 AM Changeset in webkit [14744] by
-
- 3 edits2 adds in trunk
WebCore:
2006-06-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
clientWidth/clientHeight on document element in strict mode should return visible frame size
- dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): If we're the document element, and in strict mode, return the visible size of the frame.
LayoutTests:
2006-06-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
clientWidth/clientHeight on document element in strict mode should return visible frame size
- fast/dom/client-width-height-expected.txt: Added.
- fast/dom/client-width-height.html: Added.
- 10:55 AM Changeset in webkit [14743] by
-
- 7 edits in trunk
WebCore:
2006-06-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge containsPlugins]):
- page/Frame.cpp: (WebCore::Frame::containsPlugins):
- page/Frame.h: Add containsPlugins function which returns whether a frame contains plugins or not.
WebKit:
2006-06-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
- WebView/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): Don't traverse the view hierarchy looking for plugin views. Instead, just ask the frame whether it contains any plugins.