⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 9, 2006:

9:52 PM Changeset in webkit [14801] by ggaren
  • 3 edits in trunk/JavaScriptCore

Build fix -- I think :).

9:34 PM Changeset in webkit [14800] by ggaren
  • 2 edits in trunk/WebCore
  • Build fix after last JSC check-in (oops!)


  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
8:57 PM Changeset in webkit [14799] by ggaren
  • 10 edits
    1 copy in trunk/JavaScriptCore

Reviewed by Eric (yay!).


  • Removed Context wrapper for ContextImp, renamed ContextImp to Context, split Context into its own file -- Context.cpp -- renamed _var to m_var, change ' *' to '* '.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/Context.cpp: Added. (KJS::Context::Context): (KJS::Context::~Context): (KJS::Context::mark):
  • kjs/context.h: (KJS::Context::scopeChain): (KJS::Context::variableObject): (KJS::Context::setVariableObject): (KJS::Context::thisValue): (KJS::Context::callingContext): (KJS::Context::activationObject): (KJS::Context::currentBody): (KJS::Context::function): (KJS::Context::arguments): (KJS::Context::pushScope): (KJS::Context::seenLabels):
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::argumentsGetter): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/internal.cpp: (KJS::InterpreterImp::evaluate):
  • kjs/internal.h: (KJS::InterpreterImp::setContext): (KJS::InterpreterImp::context):
  • kjs/interpreter.cpp:
  • kjs/interpreter.h: (KJS::ExecState::context): (KJS::ExecState::ExecState):
  • kjs/nodes.cpp: (currentSourceId): (currentSourceURL): (ThisNode::evaluate): (ResolveNode::evaluate): (FunctionCallResolveNode::evaluate): (PostfixResolveNode::evaluate): (DeleteResolveNode::evaluate): (TypeOfResolveNode::evaluate): (PrefixResolveNode::evaluate): (AssignResolveNode::evaluate): (VarDeclNode::evaluate): (VarDeclNode::processVarDecls): (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): (ForInNode::execute): (ContinueNode::execute): (BreakNode::execute): (ReturnNode::execute): (WithNode::execute): (SwitchNode::execute): (LabelNode::execute): (TryNode::execute): (FuncDeclNode::processFuncDecl): (FuncExprNode::evaluate):
8:09 PM Changeset in webkit [14798] by justing
  • 1 edit in trunk/WebCore/ChangeLog
5:16 PM Changeset in webkit [14797] by thatcher
  • 1 copy in tags/WebCore-418.15/WebCore

Tag for WebCore 418.15 (part 2 of 2.)

5:16 PM Changeset in webkit [14796] by thatcher
  • 1 add in tags/WebCore-418.15

Tag for WebCore 418.15 (part 1 of 2.)

5:01 PM Changeset in webkit [14795] by hyatt
  • 1 edit in trunk/WebCore/page/Frame.cpp

Fix win32 build bustage.

4:37 PM Changeset in webkit [14794] by hyatt
  • 3 edits in trunk/WebKit

Rename updateFocusState to updateActiveState.

  • WebView/WebHTMLView.m: (-[WebHTMLView _updateActiveState]): (-[NSArray viewDidMoveToWindow]): (-[NSArray windowDidBecomeKey:]): (-[NSArray windowDidResignKey:]): (-[NSArray becomeFirstResponder]): (-[NSArray resignFirstResponder]): (-[WebHTMLView _formControlIsBecomingFirstResponder:]): (-[WebHTMLView _formControlIsResigningFirstResponder:]):
  • WebView/WebHTMLViewPrivate.h:
4:33 PM Changeset in webkit [14793] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/khtml/xml/dom_nodeimpl.cpp

Correcting a merge problem.

4:30 PM Changeset in webkit [14792] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes the regression from <rdar://problem/4578533> REGRESSION: vbulletin search box closes when clicked

2006-02-23 Vicki Murley <​vicki@apple.com>

Reviewed by Hyatt.

  • fix <rdar://problem/4456004> onbeforeunload should cancel, and <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window event, so we should be using handleWindowEvent rather than dispatching a generic event on the body. It seems this only worked before because of incorrect code in other parts of the tree.
  • dom/dom2_eventsimpl.cpp: (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor, pass true for the cancel parameter
4:26 PM Changeset in webkit [14791] by hyatt
  • 5 edits in trunk/WebCore

Rename m_isFocused on the frame to m_isActive, since it isn't really
about focus but is instead about whether or not the top-level window is
active.

Pull code that was incorrectly factored into Mac-only code out of FrameMac
and back up into Frame.

Reviewed by andersca

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • page/Frame.cpp: (WebCore::Frame::setFocusNodeIfNeeded): (WebCore::Frame::isActive): (WebCore::Frame::setIsActive):
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
4:07 PM Changeset in webkit [14790] by hyatt
  • 1 edit in trunk/WebKit/COM/WebView.cpp

Fix Win32 build bustage.

3:04 PM Changeset in webkit [14789] by thatcher
  • 1 copy in tags/WebCore-418.14/WebCore

Tag for WebCore 418.14 (part 2 of 2.)

3:04 PM Changeset in webkit [14788] by thatcher
  • 1 add in tags/WebCore-418.14

Tag for WebCore 418.14 (part 1 of 2.)

3:03 PM Changeset in webkit [14787] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:01 PM Changeset in webkit [14786] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Rolling out this fix, this caused a Mail regression.
<rdar://problem/4578653> Forwarding loses the attached images

2006-04-26 Tim Omernick <​timo@apple.com>


Reviewed by Hyatt.


<rdar://problem/4068375> Flash inserted via innerHTML Fails to Show when CSS Display
Style is Toggled via Javascript


  • html/html_objectimpl.cpp: (WebCore::HTMLObjectElement::setComplete): Set needWidgetUpdate when finished parsing, even if the object element is not in a document. That way, when the element attaches to a document, it will update its widget (creating the plug-in view if necessary). This is important when the object is being inserted via setInnerHTML, since the parsed nodes are not added to the document until the whole HTML string is parsed.
2:25 PM Changeset in webkit [14785] by thatcher
  • 1 edit in trunk/WebKitSite/coding/bsd-license.html

Removes some control characters that snuck in.

1:20 PM Changeset in webkit [14784] by hyatt
  • 34 edits in trunk

WebCore:

Rework selection coloring. Rename displaysWithFocusAttributes
to isActive. Move the white-blending code onto the Color API to make
it more convenient to mutate colors for selection blending. Eliminate all
the selection state from the GraphicsContext and move it to the RenderTheme.
Implement both Win32 and Mac theme selection colors.

Reviewed by sfalken

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setIsActive):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]): (-[WebCoreFrameBridge setIsActive:]): (-[WebCoreFrameBridge selectionColor]):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
  • page/Frame.cpp: (WebCore::Frame::isActive): (WebCore::Frame::setIsActive):
  • page/Frame.h:
  • platform/Color.cpp: (WebCore::blend): (WebCore::Color::blendWithWhite):
  • platform/Color.h: (WebCore::Color::hasAlpha):
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
  • platform/GraphicsContext.h:
  • platform/mac/GraphicsContextMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::endTransparencyLayer):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionColor):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:
  • rendering/RenderReplaced.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionColor): (WebCore::RenderTheme::inactiveSelectionColor): (WebCore::RenderTheme::platformActiveSelectionColor): (WebCore::RenderTheme::platformInactiveSelectionColor):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformActiveSelectionColor): (WebCore::RenderThemeMac::platformInactiveSelectionColor):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::platformActiveSelectionColor): (WebCore::RenderThemeWin::platformInactiveSelectionColor):
  • rendering/RenderThemeWin.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):

WebKit:

Rename displaysWithFocusAttributes to isActive.

Reviewed by sfalken

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState]):
1:14 PM Changeset in webkit [14783] by thatcher
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4578533> REGRESSION: vbulletin search box closes when clicked

2006-02-08 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

  • Fixed <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)

Tests:

  • fast/events/window-events-bubble.html
  • fast/events/window-events-bubble2.html
  • fast/events/window-events-capture.html
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::handleWindowEvent): Added to send events directly to the window. This code used to be in defaultEventHandler, but that wasn't sending them at the right time. (WebCore::DocumentImpl::defaultEventHandler): Moved code to send window events to handleWindowEvent.
  • khtml/xml/DocumentImpl.h: Added handleWindowEvent.
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): fire window events in capture and bubble phases. (WebCore::NodeImpl::dispatchWindowEvent): call handleWindowEvent.
12:14 PM Changeset in webkit [14782] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4549980>
REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

  • editing/execCommand/findString-expected.checksum: Added.
  • editing/execCommand/findString-expected.png: Added.
  • editing/execCommand/findString-expected.txt: Added.
  • editing/execCommand/findString.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4549980>
REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

  • bridge/mac/FrameMac.h: Moved findString to Frame.
  • bridge/mac/FrameMac.mm: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:]): Convert the NSString to a String.
  • editing/JSEditor.cpp: Added execCommand(FindString, ...)
  • editing/Selection.cpp: Added a constructor for Ranges (WebCore::Selection::Selection):
  • editing/Selection.h:
  • page/Frame.cpp: (WebCore::Frame::findString): Moved from FrameMac. Compare a selection created using the found range with the current selection in case the current selection is the found range minus some collapsed whitespace on the edges.
  • page/Frame.h:
12:06 PM Changeset in webkit [14781] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Darin, landed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9350
Use pathcmp() when sorting paths in svn-create-patch

  • Scripts/run-webkit-tests: Fixed splitpath() to use File::Basename subroutines instead of regex.
  • Scripts/svn-create-patch: Copied numericcmp(), pathcmp() and splitpath() from run-webkit-tests. Changed sort() functions to use pathcmp(). Added subroutine prototypes. Added -h command-line switch and printUsage() subroutine.
11:40 AM Changeset in webkit [14780] by sfalken
  • 4 edits in trunk/WebCore

2006-06-09 Steve Falkenburg <​sfalken@apple.com>

Fix build break

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • css/MediaQueryEvaluator.cpp:
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::addRoundedRectClip): (GraphicsContext::addInnerRoundedRectClip): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
10:09 AM Changeset in webkit [14779] by bdakin
  • 23 edits
    234 adds in trunk

Reviewed by Hyatt. Tweaked by Maciej. Tweaks reviewed by Beth.
Landed by Beth.

CSS3 Media Queries implementation.
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4127>

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction):
  • bindings/objc/DOMCSS.mm: (-[DOMMediaList setMediaText:]): (-[DOMMediaList deleteMedium:]): (-[DOMMediaList appendMedium:]):
  • css/CSSGrammar.y:
  • css/MediaFeatureNames.cpp: Added. (WebCore::MediaFeatureNames::init):
  • css/MediaFeatureNames.h: Added.
  • css/MediaList.cpp: (WebCore::MediaList::MediaList): (WebCore::MediaList::~MediaList): (WebCore::parseMediaDescriptor): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::mediaText): (WebCore::MediaList::setMediaText): (WebCore::MediaList::item): (WebCore::MediaList::appendMedium): (WebCore::MediaList::appendMediaQuery):
  • css/MediaList.h: (WebCore::MediaList::MediaList): (WebCore::MediaList::length): (WebCore::MediaList::mediaQueries):
  • css/MediaQuery.cpp: Added. (WebCore::MediaQuery::MediaQuery): (WebCore::MediaQuery::~MediaQuery): (WebCore::MediaQuery::operator==): (WebCore::MediaQuery::cssText):
  • css/MediaQuery.h: Added. (WebCore::MediaQuery::): (WebCore::MediaQuery::restrictor): (WebCore::MediaQuery::expressions): (WebCore::MediaQuery::mediaType): (WebCore::MediaQuery::append):
  • css/MediaQueryEvaluator.cpp: Added. (WebCore::): (WebCore::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::~MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::mediaTypeMatch): (WebCore::applyRestrictor): (WebCore::MediaQueryEvaluator::eval): (WebCore::parseAspectRatio): (WebCore::cmpvalue): (WebCore::numberValue): (WebCore::colorMediaFeatureEval): (WebCore::monochromeMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval): (WebCore::min_colorMediaFeatureEval): (WebCore::max_colorMediaFeatureEval): (WebCore::min_monochromeMediaFeatureEval): (WebCore::max_monochromeMediaFeatureEval): (WebCore::min_device_aspect_ratioMediaFeatureEval): (WebCore::max_device_aspect_ratioMediaFeatureEval): (WebCore::min_heightMediaFeatureEval): (WebCore::max_heightMediaFeatureEval): (WebCore::min_widthMediaFeatureEval): (WebCore::max_widthMediaFeatureEval): (WebCore::min_device_heightMediaFeatureEval): (WebCore::max_device_heightMediaFeatureEval): (WebCore::min_device_widthMediaFeatureEval): (WebCore::max_device_widthMediaFeatureEval): (WebCore::createFunctionMap):
  • css/MediaQueryEvaluator.h: Added.
  • css/MediaQueryExp.cpp: Added. (WebCore::MediaQueryExp::MediaQueryExp): (WebCore::MediaQueryExp::~MediaQueryExp):
  • css/MediaQueryExp.h: Added. (WebCore::MediaQueryExp::mediaFeature): (WebCore::MediaQueryExp::value): (WebCore::MediaQueryExp::operator==):
  • css/StyleSheet.cpp: (WebCore::StyleSheet::setMedia):
  • css/cssparser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseMediaQuery): (WebCore::CSSParser::createFloatingMediaQueryExp): (WebCore::CSSParser::sinkFloatingMediaQueryExp): (WebCore::CSSParser::createFloatingMediaQueryExpList): (WebCore::CSSParser::sinkFloatingMediaQueryExpList): (WebCore::CSSParser::createFloatingMediaQuery): (WebCore::CSSParser::sinkFloatingMediaQuery):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSStyleSelector::cacheBorderAndBackground): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet):
  • css/cssstyleselector.h:
  • css/maketokenizer:
  • css/tokenizer.flex:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createCSSStyleSheet):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
  • ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::createCSSStyleSheet):
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • platform/Screen.h:
  • platform/mac/ScreenMac.mm: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):

Jun 8, 2006:

11:14 PM Changeset in webkit [14778] by justing
  • 1 edit in trunk/WebCore/ChangeLog

Tweaked ChangeLog

9:57 PM Changeset in webkit [14777] by justing
  • 39 edits
    26 adds in trunk

LayoutTests:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)

Added:

  • editing/execCommand/create-list-from-range-selection-expected.checksum: Added.
  • editing/execCommand/create-list-from-range-selection-expected.png: Added.
  • editing/execCommand/create-list-from-range-selection-expected.txt: Added.
  • editing/execCommand/create-list-from-range-selection.html: Added.
  • editing/execCommand/insert-list-and-stitch-expected.checksum: Added.
  • editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • editing/execCommand/insert-list-and-stitch-expected.txt: Added.
  • editing/execCommand/insert-list-and-stitch.html: Added.
  • editing/execCommand/insert-list-with-id-expected.checksum: Added.
  • editing/execCommand/insert-list-with-id-expected.png: Added.
  • editing/execCommand/insert-list-with-id-expected.txt: Added.
  • editing/execCommand/insert-list-with-id.html: Added.
  • editing/execCommand/remove-list-from-range-selection-expected.checksum: Added.
  • editing/execCommand/remove-list-from-range-selection-expected.png: Added.
  • editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
  • editing/execCommand/remove-list-from-range-selection.html: Added.
  • editing/execCommand/remove-list-items-expected.checksum: Added.
  • editing/execCommand/remove-list-items-expected.png: Added.
  • editing/execCommand/remove-list-items-expected.txt: Added.
  • editing/execCommand/remove-list-items.html: Added.
  • editing/execCommand/switch-list-type-expected.checksum: Added.
  • editing/execCommand/switch-list-type-expected.png: Added.
  • editing/execCommand/switch-list-type-expected.txt: Added.
  • editing/execCommand/switch-list-type.html: Added.


Fixes:

  • editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.checksum:
  • editing/selection/drag-to-contenteditable-iframe-expected.png:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • fast/text/textIteratorNilRenderer-expected.checksum:
  • fast/text/textIteratorNilRenderer-expected.png:
  • fast/text/textIteratorNilRenderer-expected.txt:
  • editing/deleting/delete-line-016-expected.checksum:
  • editing/deleting/delete-line-016-expected.png:
  • editing/deleting/delete-line-016-expected.txt:

WebCore:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)

  • WebCore.xcodeproj/project.pbxproj: Added InsertListCommand.{h,cpp} to the project.
  • dom/Position.cpp: (WebCore::hasRenderedNonAnonymousDescendantsWithHeight): Added. A block with height is only a candidate if this is false. This should fix the problems getting carets into empty blocks. (WebCore::Position::inRenderedContent):
  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply):
  • editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant): (WebCore::CompositeEditCommand::prune): A node can have DOM descendants that are rendered, yet have no rendered descendants. Fixed the pruning rule to avoid removing a node like this. (WebCore::CompositeEditCommand::mergeIdenticalElements): Put the two elements next to each other if they aren't already, as a convenience. (WebCore::CompositeEditCommand::moveParagraph): Added code to preserve the current selection. (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Expansion for special elements should continue to happen until it is no longer possible. (WebCore::DeleteSelectionCommand::handleGeneralDelete): The code to adjust the start node wouldn't always avoid removing the start block.
  • editing/InsertListCommand.cpp: Added. (WebCore::InsertListCommand::fixOrphanedListChild): Puts a list item that isn't inside a list into a list. (WebCore::InsertListCommand::InsertListCommand): (WebCore::InsertListCommand::modifyRange): (WebCore::InsertListCommand::doApply):
  • editing/InsertListCommand.h: Added. (WebCore::InsertListCommand::):
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/JSEditor.cpp:
  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't handle a node if the end of the range used to create the iterator ends at the start of that node. used to create the iterator.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous):
  • editing/VisiblePosition.h: Added a parameter to next/previous to prevent them from going outside the current editable region.
  • editing/htmlediting.cpp: (WebCore::highestAncestor): (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::outermostEnclosingList): (WebCore::createListItemElement):
  • editing/htmlediting.h:
  • page/Frame.cpp: (WebCore::Frame::selectionListState): Added.
  • page/Frame.h:

WebKit:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)

  • WebView/WebFrame.m: (-[WebFrame _findFrameWithSelection]): Removed an assertion that we only have one frame with a selection.
  • WebView/WebView.m: (-[WebView selectedFrame]): Ditto.
6:06 PM Changeset in webkit [14776] by thatcher
  • 2 edits
    2 adds in trunk/WebKitSite

Reviewed by Darin.

Include our own copies of the BSD and LGPL licenses.

  • coding/bsd-license.html: Added.
  • coding/lgpl-license.html: Added.
  • nav.inc: link to our copies of the licenses
3:10 PM Changeset in webkit [14775] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoff and John.

<rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)

  • fast/dom/setPrimitiveValue-expected.checksum: Added.
  • fast/dom/setPrimitiveValue-expected.png: Added.
  • fast/dom/setPrimitiveValue-expected.txt: Added.
  • fast/dom/setPrimitiveValue.html: Added.

WebCore:

Reviewed by Geoff and John.

<rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)


Problem was the primitive value was getting reset to a generic state before the parameter
check that relies on that state.

Test: fast/dom/setPrimitiveValue.html

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::setFloatValue): (WebCore::CSSPrimitiveValue::setStringValue): Move parameter checks ahead of call to cleanup().
2:38 PM Changeset in webkit [14774] by aliceli1
  • 4 adds in trunk/LayoutTests/fast/dom/Range

added tests for Range.isPointInRange and Range.comparePoint

2:35 PM Changeset in webkit [14773] by aliceli1
  • 4 edits in trunk/WebCore

Reviewed by Justin.

  • fixed <rdar://problem/4578115> support Range.isPointInRange
  • fixed <rdar://problem/4578123> support Range.comparePoint
  • dom/Range.cpp: (WebCore::Range::isPointInRange): added implementation (WebCore::Range::comparePoint): added implementation
  • dom/Range.h: added prototypes
  • dom/Range.idl: added bindings
2:20 PM Changeset in webkit [14772] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebView.m

Build fix.

2:05 PM Changeset in webkit [14771] by thatcher
  • 6 edits in trunk/WebKit

Reviewed by Darin and John.

<rdar://problem/3600734> API: please add a way to turn vertical scrollbar
always on (for Mail, to avoid reflow when typing)

Adds new methods to lock the scrolling mode on WebDynamicScrollBarsView.
Locking the scroll mode prevents WebCore from changing it as needed.
Also adds an SPI on WebView that will lock the "always on" mode
for each scroller.

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]): (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setScrollingModesLocked:]): (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]): (-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
  • WebView/WebView.m: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]):
  • WebView/WebViewPrivate.h:
9:43 AM Changeset in webkit [14770] by darin
  • 6 edits in trunk

WebCore:

Reviewed by Justin.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]): Changed to call nodeInfoAtPoint directly. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Changed to call nodeInfoAtPoint directly. Also added code to convert coordinates so it works for points that are in nodes in subframes.
  • page/Frame.cpp: (WebCore::Frame::setMark): Added assertions to catch if we attempt to set selection endpoints in another document. (WebCore::Frame::setSelection): Ditto.

WebKit:

Reviewed by Justin.

  • WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]): Added. (-[WebHTMLView _isTopHTMLView]): Added. (-[WebHTMLView _insideAnotherHTMLView]): Changed to use _topHTMLView. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Forward to the top HTML view, so that only the top view ever starts a dragging operation. Change dragging code to not assume that the dragged node is in the current view's document. Added checks that the node is an element in a couple places and coordinate conversions. (-[WebHTMLView _mayStartDragAtEventLocation:]): Forward to the top HTML view. (-[NSArray addMouseMovedObserver]): Change to do nothing when the dataSource field is 0, since we now use the dataSource field to get to the WebView. (-[NSArray removeMouseMovedObserver]): Added a comment. (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Forward to the top HTML view. (-[NSArray draggingSourceOperationMaskForLocal:]): Assert that it's the top HTML view. (-[NSArray draggedImage:movedTo:]): Ditto. (-[NSArray draggedImage:endedAt:operation:]): Ditto. (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): Ditto. (-[NSArray _canProcessDragWithDraggingInfo:]): Ditto. (-[NSArray _isMoveDrag]): Ditto. (-[NSArray draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[NSArray draggingCancelledWithDraggingInfo:]): Ditto. (-[NSArray concludeDragForDraggingInfo:actionMask:]): Ditto. Also added code to work with the appropriate bridge when receiving a drag. This fixes the problem where the top level frame got a selection intended for the inner frame; the source of the bug. (-[NSArray elementAtPoint:allowShadowContent:]): Added code to convert the coordinates so this works properly when returning an element from an inner frame. (-[NSArray setDataSource:]): Added a call to addMouseMovedObserver, needed now that addMouseMovedObserver won't do anything if called when dataSource is nil. (-[WebHTMLView _delegateDragSourceActionMask]): Forward to the top HTML view.
  • WebView/WebView.m: (-[WebViewPrivate dealloc]): Removed code to release dragCaretBridge since that field is now gone. (-[WebView moveDragCaretToPoint:]): Always call the main frame's bridge, since the drag caret is now a page-level item. Later we'll move it to the page bridge. (-[WebView removeDragCaret]): Ditto.
9:36 AM Changeset in webkit [14769] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Added change log entry that I apparently forgot.

Note: See TracTimeline for information about the timeline view.