⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 14, 2006:

5:14 PM Changeset in webkit [14871] by thatcher
  • 1 copy in tags/WebCore-418.18/WebCore

New tag part 2.

5:12 PM Changeset in webkit [14870] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/pasteboard/copy-paste-bidi-expected.checksum: Added.
  • editing/pasteboard/copy-paste-bidi-expected.png: Added.
  • editing/pasteboard/copy-paste-bidi-expected.txt: Added.
  • editing/pasteboard/copy-paste-bidi.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/markup.cpp: (WebCore::renderedText): Use plainText so that we'll pull rendered text but in DOM order.
5:12 PM Changeset in webkit [14869] by thatcher
  • 1 add in tags/WebCore-418.18

Tag for WebCore 418.18 (part 1 of 2.)

4:23 PM Changeset in webkit [14868] by justing
  • 22 edits
    10 adds in trunk

LayoutTests:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.txt:
  • editing/deleting/delete-ws-fixup-002.html:
  • editing/execCommand/format-block-expected.checksum: Added.
  • editing/execCommand/format-block-expected.png: Added.
  • editing/execCommand/format-block-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection-expected.checksum: Added.
  • editing/execCommand/format-block-from-range-selection-expected.png: Added.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection.html: Added.
  • editing/execCommand/format-block.html: Added.

WebCore:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • WebCore.xcodeproj/project.pbxproj: Added FormatBlock.{h,cpp} to the project.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Added WebUndoActions
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): Added a preserveStyle bool. (WebCore::CompositeEditCommand::moveParagraphs): Ditto. downstream() the start or else we'll move collapsed whitespace and uncollapse it.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Don't update m_endingPosition because that's removeNode's responsibility. (WebCore::updatePositionForNodeRemoval): Added. (WebCore::DeleteSelectionCommand::removeNode): Turned removeFullySelectedNode into a virtual overload of removeNode so that we can update positions as we remove nodes. (WebCore::updatePositionForTextRemoval): Added. (WebCore::DeleteSelectionCommand::deleteTextFromNode): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace): Got rid of m_trailingWhitespaceValid since m_trailingWhitespace is always valid (we update it as we remove nodes). (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply): Leading and trailing spaces should be fixed if they have collapsed before merging paragraphs.
  • editing/DeleteSelectionCommand.h:
  • editing/EditAction.h: (WebCore::):
  • editing/FormatBlockCommand.cpp: Added. (WebCore::FormatBlockCommand::FormatBlockCommand): (WebCore::FormatBlockCommand::modifyRange): Similar to InsertListCommand::modifyRange(). (WebCore::FormatBlockCommand::doApply):
  • editing/FormatBlockCommand.h: Added. (WebCore::FormatBlockCommand::editingAction):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::editingAction):
  • editing/JSEditor.cpp:
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::validBlockTag): (WebCore::createElement):
  • editing/htmlediting.h:

WebKit:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)


  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):
3:59 PM Changeset in webkit [14867] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4577988> GC: WebPluginController uses inefficient resurrecting enumeration

  • Plugins/WebPluginController.m: (cancelOutstandingCheck): (-[WebPluginController _cancelOutstandingChecks]): Use CFSetApplyFunction() instead of an enumerator to guard against modifications to the set while enumerating.
3:50 PM Changeset in webkit [14866] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:21 PM Changeset in webkit [14865] by mjs
  • 3 edits
    1 add in trunk

LayoutTests:

Test case by Anders, reviewed and tweaked by Maciej.


  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work


  • fast/events/window-load-capture.html: Added.

WebCore:

Reviewed by Anders.

  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWindowEvent):
2:51 PM Changeset in webkit [14864] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Written by mjs, reviewed by Tim H.

<rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Call window capturing event handlers, not just bubbling event handlers.
2:45 PM Changeset in webkit [14863] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Beth.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/runtime_root.h: Changed "Interpreter.h" to "interpreter.h"
2:17 PM Changeset in webkit [14862] by hyatt
  • 4 edits
    2 moves in trunk/WebCore

Rename RenderSlider to DeprecatedSlider, so that I can start work on
the new NSView-less slider.

Reviewed by john

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer):
  • rendering/DeprecatedSlider.cpp: Added. (WebCore::DeprecatedSlider::DeprecatedSlider): (WebCore::DeprecatedSlider::calcMinMaxWidth): (WebCore::DeprecatedSlider::updateFromElement): (WebCore::DeprecatedSlider::valueChanged):
  • rendering/DeprecatedSlider.h: Added. (WebCore::DeprecatedSlider::renderName):
  • rendering/RenderSlider.cpp: Removed.
  • rendering/RenderSlider.h: Removed.
10:04 AM Changeset in webkit [14861] by antti
  • 4 edits
    1 delete in S60/trunk

Reviewed by dacarson.

  • S60Internals/S60Headers.zip:
  • S60Internals/S60Libs.zip:
  • S60Internals/S60LibsGcce.zip:
  • S60Internals/SDK_GCCE_Patch.zip: Removed.

Jun 13, 2006:

10:54 PM Changeset in webkit [14860] by ggaren
  • 6 edits
    2 adds in trunk

LayoutTests:

Test for createHTMLDocument.

  • fast/dom/implementation-createHTMLDocument-expected.txt: Added.
  • fast/dom/implementation-createHTMLDocument.html: Added.

WebCore:

Reviewed by Maciej.


  • Fixed <rdar://problem/4562192> Creating a new DOMHTMLDocument appears challenging.


  • Added createHTMLDocument to Objc bindings, fixed up implementation to comply with the DOM 2 Candidate Recommendation in which is was defined. (It never made the final spec.) Also removed use of deprecatedString, to avoid unnecessary killing of puppies.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMImplementation createHTMLDocument:]):
  • bindings/objc/DOMPrivate.h:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
10:03 PM Changeset in webkit [14859] by mjs
  • 2 edits
    1 add in trunk/LayoutTests
  • fixed up results of the layout test I committed for 4583892, they were guaranteed to fail
  • fast/events/no-window-load-expected.txt:
  • fast/events/resources/greenbox.png: Added.
10:01 PM Changeset in webkit [14858] by ggaren
  • 1 edit
    1 add in trunk/LayoutTests

RS by MacDome. Added missing results for this test.

  • fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Added.
6:35 PM Changeset in webkit [14857] by aliceli1
  • 2 edits
    2 adds in trunk

Reviewed by Adele.

fixed <rdar://problem/4457902> HTMLSelectElement.remove() can't handle an option obj being passed to it, results in hang on ​http://www.ibc-solar.de/www_ibc/fst_solarmonitoring.jsp

  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction): support this by converting the argument to an options object before passing to remove()
6:33 PM Changeset in webkit [14856] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

  • test for <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page
  • fast/events/event-listener-html-non-html-confusion-expected.txt: Added.
  • fast/events/event-listener-html-non-html-confusion.html: Added.

WebCore:

Reviewed by Geoff.

  • fix <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page

This patch fixes a bug where the event listener cache does not distinguish
HTML and non-HTML listeners. Incorrect behavior where stopPropagation also
prevented default masked a case of this bug on the yahoo.com home page until
we fixed bug 5180 on 2005-10-03.

Test: fast/events/event-listener-html-non-html-confusion.html

  • bindings/js/kjs_window.h: Add additional listener maps for HTML event listeners.
  • bindings/js/kjs_window.cpp: (KJS::Window::~Window): Go through the additional maps when clearing the window object pointer in event listeners. (KJS::Window::getJSEventListener): Look in the HTML or non-HTML map depending on the argument passed. (KJS::Window::getJSUnprotectedEventListener): Ditto.
  • bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Add to either the HTML or non-HTML map depending on the argument passed. (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Remove from either the HTML or non-HTML map depending on whether the HTML flag is set. (KJS::JSEventListener::JSEventListener): More of the same. (KJS::JSEventListener::~JSEventListener): Ditto. (KJS::JSLazyEventListener::parseCode): Same thing here. In a lazy event listener there is not a listener at construction time, thus the code here to put the listener into a map needs the HTML vs. non-HTML logic.
6:25 PM Changeset in webkit [14855] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.


  • test case for <rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load search results at mapquest.com
  • fast/events/no-window-load-expected.txt: Added.
  • fast/events/no-window-load.html: Added.

WebCore:

Reviewed by Darin.


<rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load search results at mapquest.com

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Don't allow "load" events to propagate up to the window. We need this quirk to avoid site hangs, because they depend on an old Mozilla bug.
6:11 PM Changeset in webkit [14854] by thatcher
  • 1 delete in tags/WebCore-418.7/WebCore

Bad tag.

5:56 PM Changeset in webkit [14853] by thatcher
  • 1 copy in tags/WebCore-418.17/WebCore

New tag.

5:56 PM Changeset in webkit [14852] by thatcher
  • 1 delete in tags/WebCore-418.17/WebCore

Bad tag.

5:53 PM Changeset in webkit [14851] by thatcher
  • 1 copy in tags/WebCore-418.7/WebCore

New tag.

5:53 PM Changeset in webkit [14850] by thatcher
  • 1 delete in tags/WebCore-418.7/WebCore

Bad tag.

5:52 PM Changeset in webkit [14849] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/ChangeLog

Versioning

5:46 PM Changeset in webkit [14848] by ggaren
  • 4 edits in branches/Safari-2-0-branch/WebCore

Patch by Darin, tweaked by me, reviewed by Harrison.

  • Fixed <rdar://problem/4584598> 10.4.7 regression: Changing location for weather on yahoo.com home page redirects to another page


We need to keep separate caches for HTML and non-HTML event listeners
so that, if you add one of each to the same node, the two don't clobber
each other.

  • khtml/ecma/kjs_events.cpp: (JSUnprotectedEventListener::JSUnprotectedEventListener): (JSUnprotectedEventListener::~JSUnprotectedEventListener): (JSEventListener::JSEventListener): (JSEventListener::~JSEventListener): (JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_window.cpp: (Window::~Window): (Window::getJSEventListener): (Window::getJSUnprotectedEventListener):
  • khtml/ecma/kjs_window.h:
4:19 PM Changeset in webkit [14847] by antti
  • 7 edits
    12 adds in trunk

LayoutTests:

Reviewed by Hyatt

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9314

  • fast/block/positioning/relative-overflow-block-expected.checksum: Added.
  • fast/block/positioning/relative-overflow-block-expected.png: Added.
  • fast/block/positioning/relative-overflow-block-expected.txt: Added.
  • fast/block/positioning/relative-overflow-block.html: Added.
  • fast/block/positioning/relative-overflow-replaced-expected.checksum: Added.
  • fast/block/positioning/relative-overflow-replaced-expected.png: Added.
  • fast/block/positioning/relative-overflow-replaced-expected.txt: Added.
  • fast/block/positioning/relative-overflow-replaced-float-expected.checksum: Added.
  • fast/block/positioning/relative-overflow-replaced-float-expected.png: Added.
  • fast/block/positioning/relative-overflow-replaced-float-expected.txt: Added.
  • fast/block/positioning/relative-overflow-replaced-float.html: Added.
  • fast/block/positioning/relative-overflow-replaced.html: Added.

WebCore:

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9314
Relative positioned block size doesnt update root layer size

  • take relative positioning into account in leftmost/rightmost/lowestPosition()
  • ignore zero width/height boxes in leftmost/rightmost/lowestPosition()
  • split relativePositionOffset() to x and y functions


  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::relativePositionOffsetX): (WebCore::RenderBox::relativePositionOffsetY): (WebCore::RenderBox::lowestPosition): (WebCore::RenderBox::rightmostPosition): (WebCore::RenderBox::leftmostPosition):
  • rendering/RenderBox.h:
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): (WebCore::RenderObject::offsetTop):
3:20 PM Changeset in webkit [14846] by andersca
  • 4 edits
    2 adds in trunk

WebCore:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9427
xml-stylesheet processing instructions outside of the prolog should have no effect.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Remove todo comment.


  • dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::processingInstruction): Only check for style sheet if the root element hasn't yet been encountered.

LayoutTests:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9427


  • fast/css/resources/xml-stylesheet-pi-not-in-prolog.css: Added.
  • fast/css/xml-stylesheet-pi-not-in-prolog.xml: Added.
3:19 PM Changeset in webkit [14845] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.


  • fixed <rdar://problem/4498606> REGRESSION (417.8-420+): 3 missing items (but extra separators) in context menu in Mail message body
  • WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]): Add special-case hackery to recover from this SPI -> API mismatch.
2:58 PM Changeset in webkit [14844] by tomernic
  • 1 edit in trunk/WebKit/ChangeLog

Clarified my previous ChangeLog entry.

2:56 PM Changeset in webkit [14843] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Anders.

Fixed a recently-introduced assertion failure when handling 404 errors.

  • WebView/WebDataSource.m: (-[WebDataSource _handleFallbackContent]): Use the -[WebFrame _bridge] instead of -[WebDataSource _bridge]. The former is not valid until the data source has been committed, as is the case when the resource fails to load. The latter is safe to call at any time. This broke last night with Maciej's change to WebFrameResourceLoader. The old code used to call -[WebFrame _bridge].
1:17 PM Changeset in webkit [14842] by thatcher
  • 1 copy in tags/WebCore-418.17/WebCore

Tag for WebCore 418.17 (part 2 of 2.)

1:17 PM Changeset in webkit [14841] by thatcher
  • 1 add in tags/WebCore-418.17

Tag for WebCore 418.17 (part 1 of 2.)

1:15 PM Changeset in webkit [14840] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

12:56 PM Changeset in webkit [14839] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Harrison, landed by Tim H.

Handle window events for capture phase, except load events, this quirk is needed because
Mozilla used to not do the bubble or capture phase for image load events and sites mistakenly
put capturing load event listeners on the window

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent):
6:37 AM Changeset in webkit [14838] by andersca
  • 6 edits in trunk

WebCore:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
REGRESSION: fix for bug 9390 broke two layout tests


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Call finished() after setting up the document structure so we'll emit onload events.

WebKit:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
REGRESSION: fix for bug 9390 broke two layout tests

  • Plugins/WebPluginDatabase.h: (-[WebPluginDatabase isMIMETypeRegistered:]): Add new function isMIMETypeRegistered which returns whether a given MIME type has a plugin registered.
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase init]): Init set of registered MIME types.


(-[WebPluginDatabase refresh]):
Add and remove MIME types from the set of registered MIME types when registering and unregistering
plugin MIME types.


(-[WebPluginDatabase dealloc]):
Release set of registered MIME types.


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge determineObjectFromMIMEType:URL:]): Use isMIMETypeRegistered here.
Note: See TracTimeline for information about the timeline view.