⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 15, 2006:

5:45 PM Changeset in webkit [14886] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by levi

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
REGRESSION (11-16-05): Selection gaps left behind after delete

  • fast/repaint/selection-after-delete-expected.checksum: Added.
  • fast/repaint/selection-after-delete-expected.png: Added.
  • fast/repaint/selection-after-delete-expected.txt: Added.
  • fast/repaint/selection-after-delete.html: Added.
  • fast/repaint/selection-after-remove-expected.checksum: Added.
  • fast/repaint/selection-after-remove-expected.png: Added.
  • fast/repaint/selection-after-remove-expected.txt: Added.
  • fast/repaint/selection-after-remove.html: Added.

WebCore:

Reviewed by levi

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
REGRESSION (11-16-05): Selection gaps left behind after delete

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Invalidate the selection so that selection gaps are invalidated.
3:44 PM Changeset in webkit [14885] by thatcher
  • 1 copy in tags/WebCore-418.19/WebCore

Tag for WebCore 418.19 (part 2 of 2.)

3:44 PM Changeset in webkit [14884] by thatcher
  • 1 add in tags/WebCore-418.19

Tag for WebCore 418.19 (part 1 of 2.)

3:33 PM Changeset in webkit [14883] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

JavaScriptGlue:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • WebKit.xcodeproj/project.pbxproj:
3:31 PM Changeset in webkit [14882] by jdevalk
  • 4 edits in trunk/LayoutTests/fast/css

And now with the ugly line gone, and the proper expected test results

3:28 PM Changeset in webkit [14881] by jdevalk
  • 1 edit
    2 adds in trunk/LayoutTests/fast/css

update testresults

3:26 PM Changeset in webkit [14880] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/deleting/pruning-after-merge-2-expected.checksum: Added.
  • editing/deleting/pruning-after-merge-2-expected.png: Added.
  • editing/deleting/pruning-after-merge-2-expected.txt: Added.
  • editing/deleting/pruning-after-merge-2.html: Added.

WebCore:

Reviewed by harrison


  • editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant): (WebCore::CompositeEditCommand::prune): Ascend using the DOM (WebCore::CompositeEditCommand::moveParagraphs): Placeholder insertion during deletion is fixed, removing the fall back.
2:37 PM Changeset in webkit [14879] by jdevalk
  • 8 edits
    2 adds in trunk

Adding :lang support, patch by Nicholas Shanks, review by Hyatt

2:09 PM Changeset in webkit [14878] by jdevalk
  • 2 edits in trunk/WebKitSite

Improve wording of first paragraph of index.html

1:05 PM Changeset in webkit [14877] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

  • editing/execCommand/findString-2-expected.checksum: Added.
  • editing/execCommand/findString-2-expected.png: Added.
  • editing/execCommand/findString-2-expected.txt: Added.
  • editing/execCommand/findString-2.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E


  • page/Frame.cpp: (WebCore::Frame::findString): When comparing the found range with what's currently selected a) build a selection with the found range to remove collapsed whitespace and b) compare ranges instead of selection objects to ignore the way that the current selection was made (to ignore the base and extent).
11:56 AM Changeset in webkit [14876] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

11:51 AM Changeset in webkit [14875] by justing
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by thatcher, harrison


<rdar://problem/4585175> 10.4.7 regression: Text from end of signature unexpectedly removed


Merged fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8459>
REGRESSION: Content lost during a delete/merge of whitespace:pre text

  • khtml/editing/htmlediting.cpp: (khtml::hasARenderedDescendant): Added. (khtml::CompositeEditCommand::prune): Don't prune a leaf, the root editable element, or a container with one or more rendered descendants.
10:37 AM Changeset in webkit [14874] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.


Fixed bug in WebKit support for computing but not highlighting rects for text matches.

  • WebView/WebView.m: (-[WebView rectsForTextMatches]): leave out empty rects, and convert rects to WebView coordinates. Since this makes a batch of autoreleased NSValue objects, use a local autorelease pool
6:37 AM Changeset in webkit [14873] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Plugins/WebPluginController.m: (-[WebPluginController _cancelOutstandingChecks]): add nil check before calling CFSetApplyFunction
4:12 AM Changeset in webkit [14872] by ddkilzer
  • 108 edits in trunk/WebCore

WebCore:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9382
IDL files missing copyright/license headers

Add Apple BSD license and copyright to IDL files.

  • ksvg2/bindings/idl/svg/GetSVGDocument.idl:
  • ksvg2/bindings/idl/svg/SVGAElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedRect.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedString.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimationElement.idl:
  • ksvg2/bindings/idl/svg/SVGCircleElement.idl:
  • ksvg2/bindings/idl/svg/SVGClipPathElement.idl:
  • ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl:
  • ksvg2/bindings/idl/svg/SVGCursorElement.idl:
  • ksvg2/bindings/idl/svg/SVGDOMImplementation.idl:
  • ksvg2/bindings/idl/svg/SVGDefsElement.idl:
  • ksvg2/bindings/idl/svg/SVGDescElement.idl:
  • ksvg2/bindings/idl/svg/SVGElementInstance.idl:
  • ksvg2/bindings/idl/svg/SVGElementInstanceList.idl:
  • ksvg2/bindings/idl/svg/SVGEllipseElement.idl:
  • ksvg2/bindings/idl/svg/SVGEvent.idl:
  • ksvg2/bindings/idl/svg/SVGException.idl:
  • ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl:
  • ksvg2/bindings/idl/svg/SVGFEBlendElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl:
  • ksvg2/bindings/idl/svg/SVGFECompositeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFloodElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEImageElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEMergeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl:
  • ksvg2/bindings/idl/svg/SVGFETileElement.idl:
  • ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl:
  • ksvg2/bindings/idl/svg/SVGFilterElement.idl:
  • ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl:
  • ksvg2/bindings/idl/svg/SVGFitToViewBox.idl:
  • ksvg2/bindings/idl/svg/SVGGElement.idl:
  • ksvg2/bindings/idl/svg/SVGGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGICCColor.idl:
  • ksvg2/bindings/idl/svg/SVGImageElement.idl:
  • ksvg2/bindings/idl/svg/SVGLangSpace.idl:
  • ksvg2/bindings/idl/svg/SVGLengthList.idl:
  • ksvg2/bindings/idl/svg/SVGLineElement.idl:
  • ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGLocatable.idl:
  • ksvg2/bindings/idl/svg/SVGMarkerElement.idl:
  • ksvg2/bindings/idl/svg/SVGNumberList.idl:
  • ksvg2/bindings/idl/svg/SVGPaint.idl:
  • ksvg2/bindings/idl/svg/SVGPathElement.idl:
  • ksvg2/bindings/idl/svg/SVGPathSeg.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegArc.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLineto.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegList.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl:
  • ksvg2/bindings/idl/svg/SVGPatternElement.idl:
  • ksvg2/bindings/idl/svg/SVGPointList.idl:
  • ksvg2/bindings/idl/svg/SVGPolygonElement.idl:
  • ksvg2/bindings/idl/svg/SVGPolylineElement.idl:
  • ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl:
  • ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGRectElement.idl:
  • ksvg2/bindings/idl/svg/SVGRenderingIntent.idl:
  • ksvg2/bindings/idl/svg/SVGScriptElement.idl:
  • ksvg2/bindings/idl/svg/SVGSetElement.idl:
  • ksvg2/bindings/idl/svg/SVGStopElement.idl:
  • ksvg2/bindings/idl/svg/SVGStringList.idl:
  • ksvg2/bindings/idl/svg/SVGStylable.idl:
  • ksvg2/bindings/idl/svg/SVGStyleElement.idl:
  • ksvg2/bindings/idl/svg/SVGSwitchElement.idl:
  • ksvg2/bindings/idl/svg/SVGSymbolElement.idl:
  • ksvg2/bindings/idl/svg/SVGTSpanElement.idl:
  • ksvg2/bindings/idl/svg/SVGTests.idl:
  • ksvg2/bindings/idl/svg/SVGTextContentElement.idl:
  • ksvg2/bindings/idl/svg/SVGTextElement.idl:
  • ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl:
  • ksvg2/bindings/idl/svg/SVGTitleElement.idl:
  • ksvg2/bindings/idl/svg/SVGTransformList.idl:
  • ksvg2/bindings/idl/svg/SVGTransformable.idl:
  • ksvg2/bindings/idl/svg/SVGURIReference.idl:
  • ksvg2/bindings/idl/svg/SVGUnitTypes.idl:
  • ksvg2/bindings/idl/svg/SVGUseElement.idl:
  • ksvg2/bindings/idl/svg/SVGViewElement.idl:
  • ksvg2/bindings/idl/svg/SVGZoomAndPan.idl:
  • ksvg2/bindings/idl/svg/SVGZoomEvent.idl:
  • ksvg2/svg/SVGAnimatedLength.idl:

Jun 14, 2006:

5:14 PM Changeset in webkit [14871] by thatcher
  • 1 copy in tags/WebCore-418.18/WebCore

New tag part 2.

5:12 PM Changeset in webkit [14870] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/pasteboard/copy-paste-bidi-expected.checksum: Added.
  • editing/pasteboard/copy-paste-bidi-expected.png: Added.
  • editing/pasteboard/copy-paste-bidi-expected.txt: Added.
  • editing/pasteboard/copy-paste-bidi.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/markup.cpp: (WebCore::renderedText): Use plainText so that we'll pull rendered text but in DOM order.
5:12 PM Changeset in webkit [14869] by thatcher
  • 1 add in tags/WebCore-418.18

Tag for WebCore 418.18 (part 1 of 2.)

4:23 PM Changeset in webkit [14868] by justing
  • 22 edits
    10 adds in trunk

LayoutTests:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.txt:
  • editing/deleting/delete-ws-fixup-002.html:
  • editing/execCommand/format-block-expected.checksum: Added.
  • editing/execCommand/format-block-expected.png: Added.
  • editing/execCommand/format-block-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection-expected.checksum: Added.
  • editing/execCommand/format-block-from-range-selection-expected.png: Added.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection.html: Added.
  • editing/execCommand/format-block.html: Added.

WebCore:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • WebCore.xcodeproj/project.pbxproj: Added FormatBlock.{h,cpp} to the project.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Added WebUndoActions
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): Added a preserveStyle bool. (WebCore::CompositeEditCommand::moveParagraphs): Ditto. downstream() the start or else we'll move collapsed whitespace and uncollapse it.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Don't update m_endingPosition because that's removeNode's responsibility. (WebCore::updatePositionForNodeRemoval): Added. (WebCore::DeleteSelectionCommand::removeNode): Turned removeFullySelectedNode into a virtual overload of removeNode so that we can update positions as we remove nodes. (WebCore::updatePositionForTextRemoval): Added. (WebCore::DeleteSelectionCommand::deleteTextFromNode): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace): Got rid of m_trailingWhitespaceValid since m_trailingWhitespace is always valid (we update it as we remove nodes). (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply): Leading and trailing spaces should be fixed if they have collapsed before merging paragraphs.
  • editing/DeleteSelectionCommand.h:
  • editing/EditAction.h: (WebCore::):
  • editing/FormatBlockCommand.cpp: Added. (WebCore::FormatBlockCommand::FormatBlockCommand): (WebCore::FormatBlockCommand::modifyRange): Similar to InsertListCommand::modifyRange(). (WebCore::FormatBlockCommand::doApply):
  • editing/FormatBlockCommand.h: Added. (WebCore::FormatBlockCommand::editingAction):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::editingAction):
  • editing/JSEditor.cpp:
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::validBlockTag): (WebCore::createElement):
  • editing/htmlediting.h:

WebKit:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)


  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):
3:59 PM Changeset in webkit [14867] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4577988> GC: WebPluginController uses inefficient resurrecting enumeration

  • Plugins/WebPluginController.m: (cancelOutstandingCheck): (-[WebPluginController _cancelOutstandingChecks]): Use CFSetApplyFunction() instead of an enumerator to guard against modifications to the set while enumerating.
3:50 PM Changeset in webkit [14866] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:21 PM Changeset in webkit [14865] by mjs
  • 3 edits
    1 add in trunk

LayoutTests:

Test case by Anders, reviewed and tweaked by Maciej.


  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work


  • fast/events/window-load-capture.html: Added.

WebCore:

Reviewed by Anders.

  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWindowEvent):
2:51 PM Changeset in webkit [14864] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Written by mjs, reviewed by Tim H.

<rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Call window capturing event handlers, not just bubbling event handlers.
2:45 PM Changeset in webkit [14863] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Beth.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/runtime_root.h: Changed "Interpreter.h" to "interpreter.h"
2:17 PM Changeset in webkit [14862] by hyatt
  • 4 edits
    2 moves in trunk/WebCore

Rename RenderSlider to DeprecatedSlider, so that I can start work on
the new NSView-less slider.

Reviewed by john

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer):
  • rendering/DeprecatedSlider.cpp: Added. (WebCore::DeprecatedSlider::DeprecatedSlider): (WebCore::DeprecatedSlider::calcMinMaxWidth): (WebCore::DeprecatedSlider::updateFromElement): (WebCore::DeprecatedSlider::valueChanged):
  • rendering/DeprecatedSlider.h: Added. (WebCore::DeprecatedSlider::renderName):
  • rendering/RenderSlider.cpp: Removed.
  • rendering/RenderSlider.h: Removed.
10:04 AM Changeset in webkit [14861] by antti
  • 4 edits
    1 delete in S60/trunk

Reviewed by dacarson.

  • S60Internals/S60Headers.zip:
  • S60Internals/S60Libs.zip:
  • S60Internals/S60LibsGcce.zip:
  • S60Internals/SDK_GCCE_Patch.zip: Removed.
Note: See TracTimeline for information about the timeline view.