⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 22, 2006:

9:43 PM Changeset in webkit [14986] by ap
  • 2 edits in trunk/JavaScriptCore

Build fix.

  • API/JSObjectRef.cpp: Changed "identifier.h" to "Identifier.h"
9:37 PM Changeset in webkit [14985] by ap
  • 4 edits in trunk

Reviewed by darin and ggaren.

WebKitTools:

  • Scripts/webkitdirs.pm: Building WebKit now requires Xcode 2.3.

WebKitSite:

  • building/build.html: Ditto.
9:18 PM Changeset in webkit [14984] by thatcher
  • 10 edits in trunk/WebKitTools

Reviewed by Eric.

Adds a native toolbar to Drosera to be a good citizen.
Adds a Debug menu with key-commands for Continue, Pause and Step Into.
Fixes a dragging bug from an earlier fix to the divider code.
Fixes some poor indenting in debugger.js.

  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument stepInto]): (-[DebuggerDocument pause:]): (-[DebuggerDocument resume:]): (-[DebuggerDocument stepInto:]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[DebuggerDocument toolbarDefaultItemIdentifiers:]): (-[DebuggerDocument toolbarAllowedItemIdentifiers:]): (-[DebuggerDocument validateUserInterfaceItem:]):
  • Drosera/English.lproj/MainMenu.nib/classes.nib:
  • Drosera/English.lproj/MainMenu.nib/info.nib:
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
  • Drosera/debugger.css:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
  • Drosera/viewer.html:
9:07 PM Changeset in webkit [14983] by ddkilzer
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • fast/repaint/clipped-relative-expected.checksum: Added.
  • fast/repaint/clipped-relative-expected.png: Added.
  • fast/repaint/clipped-relative-expected.txt: Added.
  • fast/repaint/clipped-relative.html: Added.
  • fast/repaint/containing-block-position-change-expected.checksum: Updated.
  • fast/repaint/containing-block-position-change-expected.png: Updated.

WebCore:

Reviewed by Hyatt. Patch by Mitz.

Test: fast/repaint/clipped-relative.html

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removePositionedObjects): Removed call to computeRepaintRects(). Previously, it was needed to update the cached rects before RenderBox::setStyle() called updateLayerPositions().
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Changed to call updateLayerPositions() for a newly- created layer only if it does not need layout. Otherwise, updateLayerPositions() will be called after layout. This saves a repaint in some cases.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::checkForRepaintOnResize): Renamed computeRepaintRects() to this and deleted the code that cached the absolute position and repaint rects. (WebCore::RenderLayer::updateLayerPositions): Added code to cache the absolute position and repaint rects right after updating the layer's position.
  • rendering/RenderLayer.h:
7:25 PM Changeset in webkit [14982] by thatcher
  • 2 edits in trunk/WebKitTools/Drosera

Adding an image that wasn't added to the project earlier.

7:00 PM Changeset in webkit [14981] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4599015> REGRESSION: Hand on clock widget
don't appear at all

This regression was caused by <rdar://problem/4567520> HIDPI: pixel
cracks in weather widget at 1.83 scaling

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Do the contains check before rounding to integral device pixels.
4:12 PM Changeset in webkit [14980] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)


  • dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.

LayoutTests:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)


  • dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.
2:31 PM Changeset in webkit [14979] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

  • WebView/WebFrameLoader.m: Import WebMainResourceLoader instead of using @class so that we can call WebMainResourceLoader methods.
2:10 PM Changeset in webkit [14978] by thatcher
  • 8 edits in /

Versioning

12:01 PM Changeset in webkit [14977] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

  • WebView/WebFrameLoader.m: Import JavaScriptCore/Assertions.h instead of WebKit/WebAssertions.h (which no longer exists)
11:48 AM Changeset in webkit [14976] by mjs
  • 5 edits
    2 adds in trunk/WebKit

Reviewed by Adele.


  • start moving loading logic to new WebFrameLoader class; move management of WebLoaders there
  • Misc/WebIconLoader.h:
  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _iconLoaderReceivedPageIcon:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource dealloc]): (-[WebDataSource finalize]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
  • WebView/WebFrameLoader.h: Added.
  • WebView/WebFrameLoader.m: Added. (-[WebFrameLoader initWithDataSource:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader hasIconLoader]): (-[WebFrameLoader loadIconWithRequest:]): (-[WebFrameLoader stopLoadingIcon]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoading]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]):
11:34 AM Changeset in webkit [14975] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0

  • html/HTMLParser.cpp: (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::canvasCreateErrorCheck): (WebCore::HTMLParser::isInline): Add null-checks for document->frame() since it can be 0 for documents created using createHTMLDocument.

LayoutTests:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0


  • fast/dom/noscript-canvas-in-created-html-document-expected.txt: Added.
  • fast/dom/noscript-canvas-in-created-html-document.html: Added.
10:48 AM Changeset in webkit [14974] by kdecker
  • 3 edits
    1 add in trunk/WebKitTools
10:46 AM Changeset in webkit [14973] by andersca
  • 6 edits
    4 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown


  • dom/xml_tokenizer.cpp: (WebCore::shouldAllowExternalLoad): Use correct path for the catalog.


(WebCore::errorFunc):
Add error function to keep parser errors from going to the console.


(WebCore::XMLTokenizer::write):
Remove if (0 &&)


(WebCore::XMLTokenizer::end):
Pass DocLoader to xmlDocPtrForString.


(WebCore::xmlDocPtrForString):

  • dom/xml_tokenizer.h: Add DocLoader argument to xmlDocPtrForString so external DTDs and entities can be loaded.


  • xml/XSLTProcessor.cpp: (WebCore::xmlDocPtrFromNode): Pass DocLoader to xmlDocPtrForString


LayoutTests:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown

  • fast/xsl/dtd-in-source-document-expected.txt: Added.
  • fast/xsl/dtd-in-source-document.xml: Added.
  • fast/xsl/resources/dtd-in-source-document.dtd: Added.
  • fast/xsl/resources/dtd-in-source-document.xsl: Added.
10:34 AM Changeset in webkit [14972] by thatcher
  • 8 edits in trunk/WebKitTools

Reviewed by Kevin Decker.

Code clean up. Adds the stackframe and makes only the body
of the tables scrollable keeping the header visible.
Shows the current function stack when paused or stepping.

  • Drosera/DebuggerApplication.m: (-[DebuggerApplication awakeFromNib]): (-[DebuggerApplication numberOfRowsInTableView:]): (-[DebuggerApplication tableView:objectValueForTableColumn:row:]):
  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument dealloc]): (-[DebuggerDocument currentFrame]): (-[DebuggerDocument currentFrameFunctionName]): (-[DebuggerDocument currentFunctionStack]): (-[DebuggerDocument log:]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/debugger.css:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
10:18 AM Changeset in webkit [14971] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

Teach run-webkit-httpd to properly look for webkitdirs.pm.

  • Scripts/run-webkit-httpd:
8:01 AM Changeset in webkit [14970] by kdecker
  • 5 edits
    5 adds in trunk/WebKitTools
3:38 AM Changeset in webkit [14969] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Build fix.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9539
Another case error preventing build

  • API/APICast.h: Changed "UString.h" to "ustring.h".

Jun 21, 2006:

5:58 PM Changeset in webkit [14968] by hyatt
  • 5 edits in trunk/WebCore

Back out -webkit-overlay and just rename it back to overlay.

Reviewed by darin

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
5:26 PM Changeset in webkit [14967] by thatcher
  • 1 copy in tags/WebCore-315.14.3/WebCore

Tag for WebCore 315.14.3 (part 2 of 2.)

5:26 PM Changeset in webkit [14966] by thatcher
  • 1 add in tags/WebCore-315.14.3

Tag for WebCore 315.14.3 (part 1 of 2.)

5:26 PM Changeset in webkit [14965] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

5:22 PM Changeset in webkit [14964] by thatcher
  • 1 copy in tags/WebCore-418.19.1/WebCore

Tag for WebCore 418.19.1 (part 2 of 2.)

5:22 PM Changeset in webkit [14963] by thatcher
  • 1 add in tags/WebCore-418.19.1

Tag for WebCore 418.19.1 (part 1 of 2.)

5:20 PM Changeset in webkit [14962] by justing
  • 4 edits
    12 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/deleting/table-cells-expected.checksum: Added.
  • editing/deleting/table-cells-expected.png: Added.
  • editing/deleting/table-cells-expected.txt: Added.
  • editing/deleting/table-cells.html: Added.
  • editing/inserting/paragraph-separator-in-table-1-expected.checksum: Added.
  • editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
  • editing/inserting/paragraph-separator-in-table-1-expected.txt: Added.
  • editing/inserting/paragraph-separator-in-table-1.html: Added.
  • editing/inserting/paragraph-separator-in-table-2-expected.checksum: Added.
  • editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
  • editing/inserting/paragraph-separator-in-table-2-expected.txt: Added.
  • editing/inserting/paragraph-separator-in-table-2.html: Added.

WebCore:

Reviewed by levi

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Fix a bug in the code to stop merges across table cells. (WebCore::DeleteSelectionCommand::mergeParagraphs): Move the code to stop merges across table cells to initializePositionData so that its changes to m_mergeBlocksAfterDelete can take effect on the endingPosition.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Turn into an InsertLineBreak instead of splitting/cloning a table cell.
5:13 PM Changeset in webkit [14961] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

5:00 PM Changeset in webkit [14960] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4571273> WebCore crash in khtml::RenderObject::getAbsoluteRepaintRectWithOutline

2005-10-21 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Fix for <rdar://problem/3947202> certain sequence of DOM
method calls involving CSS outline and display crashes Safari
(in repaint code).

  • khtml/rendering/render_flow.cpp: (RenderFlow::destroy): Need to set m_continuation to 0 after it is destroyed to prevent possible crashes.
4:50 PM Changeset in webkit [14959] by hyatt
  • 4 adds in trunk/LayoutTests/fast/overflow

Add overflow-x and overflow-y tests.

4:40 PM Changeset in webkit [14958] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4571273> WebCore crash in khtml::RenderObject::getAbsoluteRepaintRectWithOutline

2005-10-21 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Fix for <rdar://problem/3947202> certain sequence of DOM
method calls involving CSS outline and display crashes Safari
(in repaint code).

  • khtml/rendering/render_flow.cpp: (RenderFlow::destroy): Need to set m_continuation to 0 after it is destroyed to prevent possible crashes.
4:38 PM Changeset in webkit [14957] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by John.

Fix for <rdar://problem/3914965> Misspelled text underline doesn't
look right at non-standard scale factors

  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling): We need to call into our previously-created SPI for pattern-drawing so that the phase is right at all scale factors.
4:15 PM Changeset in webkit [14956] by thatcher
  • 4 edits in trunk

Switching to Stabs debugging format for Production builds.

4:13 PM Changeset in webkit [14955] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Maciej

The WebCoreIconDatabaseBridge was getting messages sent to it after it had been closed, resulting in a crash
on an ASSERT(). After closing the databaseBridge, we simply set it to nil so this can't happen.
anymore.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]):
4:10 PM Changeset in webkit [14954] by ggaren
  • 4 edits in trunk/JavaScriptCore

Fixed release build, fixed accidental infinite recursion due to
last minute global replace gone awry.


  • API/APICast.h: (toRef):
  • API/testapi.c: (assertEqualsAsBoolean): (assertEqualsAsNumber): (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr):
  • JavaScriptCore.xcodeproj/project.pbxproj:
3:45 PM Changeset in webkit [14953] by hyatt
  • 18 edits in trunk/WebCore

Fix for 7362, implement the CSS3 overflow-x and overflow-y properties.

Reviewed by adele

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::calcMinMaxWidth):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::shouldAutoscroll): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasAutoVerticalScrollbar): (WebCore::RenderObject::hasAutoHorizontalScrollbar): (WebCore::RenderObject::scrollsOverflow): (WebCore::RenderObject::scrollsOverflowX): (WebCore::RenderObject::scrollsOverflowY): (WebCore::RenderObject::includeVerticalScrollbarSize): (WebCore::RenderObject::includeHorizontalScrollbarSize):
  • rendering/RenderTextArea.cpp: (WebCore::RenderTextArea::setStyle):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): (WebCore::RenderTextField::calcHeight): (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff):
  • rendering/render_style.h: (WebCore::): (WebCore::RenderStyle::NonInheritedFlags::operator==): (WebCore::RenderStyle::setBitDefaults): (WebCore::RenderStyle::overflowX): (WebCore::RenderStyle::overflowY): (WebCore::RenderStyle::setOverflowX): (WebCore::RenderStyle::setOverflowY): (WebCore::RenderStyle::initialOverflowX): (WebCore::RenderStyle::initialOverflowY):
2:22 PM Changeset in webkit [14952] by justing
  • 37 edits
    9 adds
    1 delete in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4590366>
REGRESSION: Selection incorrectly paints gaps on TOT


Added:

  • editing/selection/line-wrap-1-expected.checksum: Added.
  • editing/selection/line-wrap-1-expected.png: Added.
  • editing/selection/line-wrap-1-expected.txt: Added.
  • editing/selection/line-wrap-1.html: Added.
  • editing/selection/line-wrap-2-expected.checksum: Added.
  • editing/selection/line-wrap-2-expected.png: Added.
  • editing/selection/line-wrap-2-expected.txt: Added.
  • editing/selection/line-wrap-2.html: Added. Fixes:
  • editing/execCommand/findString-expected.checksum:
  • editing/execCommand/findString-expected.png:
  • editing/execCommand/findString-expected.txt:
  • editing/inserting/editing-empty-divs-expected.checksum:
  • editing/inserting/editing-empty-divs-expected.png:
  • editing/inserting/editing-empty-divs-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-tab-002-expected.txt:
  • editing/inserting/insert-text-with-newlines-expected.txt:
  • editing/inserting/typing-001-expected.txt:
  • editing/inserting/typing-003-expected.txt:
  • editing/inserting/typing-around-br-001-expected.txt:
  • editing/style/remove-underline-across-paragraph-expected.txt:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-after-paragraph-expected.txt:
  • editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-expected.txt:
  • editing/style/remove-underline-from-stylesheet-expected.txt:
  • editing/style/remove-underline-in-bold-expected.txt:
  • editing/style/typing-style-002-expected.txt:
  • editing/style/typing-style-003-expected.txt:
  • editing/style/unbold-in-bold-expected.txt:
  • editing/style/underline-expected.txt: Disabled (9337):
  • editing/input/attributed-substring-from-range-lines.html

WebCore:

Reviewed by levi


<rdar://problem/4590366>
REGRESSION: Selection incorrectly paints gaps on TOT

  • dom/Document.cpp: (WebCore::Document::updateSelection): Use the leftmost candidate for the end of the selection and the rightmost candidate for the start of the selection.
  • dom/Position.cpp: (WebCore::Position::upstream): Cross line wraps so that we can use upstream/downstream to get to candidates before/after linewraps. (WebCore::Position::downstream): (WebCore::Position::inRenderedContent):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::mergeParagraphs):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ensure that the leftmost candidate is used. We should sample the style from that one. When the block to insert is after a br, a br should be inserted even in strict mode.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Insert at the leftmost candidate, get rid of a use of trailingWhitespacePosition. Don't apply a style if its unnecessary.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): "pos" can be invalidated, don't use it.
  • editing/VisiblePosition.cpp: Renamed initDeepPosition and made it return the canonical position. (WebCore::VisiblePosition::init): (WebCore::VisiblePosition::canonicalPosition):
  • editing/VisiblePosition.h: (WebCore::VisiblePosition::characterBefore): Added.
  • editing/visible_units.cpp: (WebCore::startOfParagraph):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): When a selection ends at a line wrap, it shouldn't extend onto the next line.
2:09 PM Changeset in webkit [14951] by ggaren
  • 20 edits
    19 adds in trunk

JavaScriptCore:

Reviewed by Anders.


  • First cut at C API to JavaScript. Includes a unit test, 'testapi.c', and the outline of a test app, 'minidom.c'.


Includes one change to JSC internals: Rename propList to getPropertyList and have it
take its target property list by reference so that subclasses can
add properties to the list before calling through to their superclasses.


Also, I just ran prepare-ChangeLog in about 10 seconds, and I would like
to give a shout-out to that.


  • API/APICast.h: Added. (toJS): (toRef):
  • API/JSBase.h: Added.
  • API/JSCallbackObject.cpp: Added. (KJS::): (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::~JSCallbackObject): (KJS::JSCallbackObject::className): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::implementsConstruct): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::implementsCall): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString): (KJS::JSCallbackObject::setPrivate): (KJS::JSCallbackObject::getPrivate): (KJS::JSCallbackObject::cachedValueGetter): (KJS::JSCallbackObject::callbackGetter):
  • API/JSCallbackObject.h: Added. (KJS::JSCallbackObject::classInfo):
  • API/JSCharBufferRef.cpp: Added. (JSStringMake): (JSCharBufferCreate): (JSCharBufferCreateUTF8): (JSCharBufferRetain): (JSCharBufferRelease): (JSValueCopyStringValue): (JSCharBufferGetLength): (JSCharBufferGetCharactersPtr): (JSCharBufferGetCharacters): (JSCharBufferGetMaxLengthUTF8): (JSCharBufferGetCharactersUTF8): (JSCharBufferIsEqual): (JSCharBufferIsEqualUTF8): (JSCharBufferCreateWithCFString): (CFStringCreateWithJSCharBuffer):
  • API/JSCharBufferRef.h: Added.
  • API/JSContextRef.cpp: Added. (JSContextCreate): (JSContextDestroy): (JSContextGetGlobalObject): (JSEvaluate): (JSCheckSyntax): (JSContextHasException): (JSContextGetException): (JSContextClearException): (JSContextSetException):
  • API/JSContextRef.h: Added.
  • API/JSObjectRef.cpp: Added. (JSValueToObject): (JSObjectMake): (JSFunctionMake): (JSObjectGetDescription): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSObjectGetPrivate): (JSObjectSetPrivate): (JSObjectIsFunction): (JSObjectCallAsFunction): (JSObjectIsConstructor): (JSObjectCallAsConstructor): (JSPropertyListEnumerator::JSPropertyListEnumerator): (JSObjectCreatePropertyEnumerator): (JSPropertyEnumeratorGetNext): (JSPropertyEnumeratorRetain): (JSPropertyEnumeratorRelease): (JSPropertyListAdd):
  • API/JSObjectRef.h: Added.
  • API/JSValueRef.cpp: Added. (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsEqual): (JSValueIsStrictEqual): (JSUndefinedMake): (JSNullMake): (JSBooleanMake): (JSNumberMake): (JSValueToBoolean): (JSValueToNumber): (JSGCProtect): (JSGCUnprotect): (JSGCCollect):
  • API/JSValueRef.h: Added.
  • API/JavaScriptCore.h: Added.
  • API/minidom.c: Added. (main):
  • API/minidom.html: Added.
  • API/minidom.js: Added.
  • API/testapi.c: Added. (assertEqualsAsBoolean): (assertEqualsAsNumber): (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_initialize): (MyObject_copyDescription): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_callAsFunction): (MyObject_callAsConstructor): (MyObject_convertToType): (MyObject_finalize): (print_callAsFunction): (main): (createStringWithContentsOfFile):
  • API/testapi.js: Added.
  • ChangeLog:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/npruntime_impl.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::getPropertyList):
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
  • kjs/nodes.cpp: (ForInNode::execute):
  • kjs/object.cpp: (KJS::JSObject::put): (KJS::JSObject::canPut): (KJS::JSObject::deleteProperty): (KJS::JSObject::propertyIsEnumerable): (KJS::JSObject::getPropertyAttributes): (KJS::JSObject::getPropertyList):
  • kjs/object.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::get):
  • kjs/property_map.h:
  • kjs/scope_chain.cpp: (KJS::ScopeChain::print):
  • kjs/string_object.cpp: (StringInstance::getPropertyList):
  • kjs/string_object.h:
  • kjs/ustring.h: (KJS::UString::Rep::ref):

JavaScriptGlue:

Reviewed by Anders.


  • Required for JS API: Rename propList to getPropertyList and have it take its target property list by reference so that subclasses can add properties to the list before calling through to their superclasses.
  • JSUtils.cpp: (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
  • UserObjectImp.cpp: (UserObjectImp::getPropertyList):
  • UserObjectImp.h:
1:46 PM Changeset in webkit [14950] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

Fixing ChangeLog.

1:44 PM Changeset in webkit [14949] by bdakin
  • 2 edits in trunk/WebCore

Reviewed and committed by Beth.

Fix for <rdar://problem/4595337> Resizing a containing block
strictly vertically does not cause contained height:100% element to
also be resized.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Also layout if the child's min or max height is a percent.
1:35 PM Changeset in webkit [14948] by andersca
  • 9 edits
    3 adds in trunk

WebCore:

2006-06-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered


  • dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Initialize new members.


(WebCore::XMLTokenizer::endElementNs):
If we've encountered a script tag, execute the script here. If the script
tag refers to an external resource, pause the parser while loading it.


(WebCore::XMLTokenizer::end):
Move code from finish() to here


(WebCore::XMLTokenizer::finish):
Only call end() if the parser isn't paused.


(WebCore::XMLTokenizer::notifyFinished):
Evaluate the script here and resume the parser.


(WebCore::XMLTokenizer::resumeParsing):
If finish() was called, call end() after writing all data.

LayoutTests:

2006-06-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered

  • dom/svg/level3/xpath/svgunit.js: The XPath tests depend on the document being loaded before running the tests. Add a "load" event listener and run the test in the handler.


  • fast/canvas/quadraticCurveTo.xml: Add onload handler and run tests there.


  • fast/innerHTML/004-expected.txt:
  • fast/innerHTML/004.xhtml: Add load event listener and run test there.


  • fast/parser/external-entities-expected.txt: This now dumps as text because the script is ran before the parse error is encountered.


  • fast/parser/resources/xhtml-scripts.js: Added.
  • fast/parser/xhtml-scripts-expected.txt: Added.
  • fast/parser/xhtml-scripts.xhtml: Added. Add new tests.


  • svg/custom/text-hit-test.svg: Run test in onload handler.
12:29 PM Changeset in webkit [14947] by tomernic
  • 9 edits in trunk/WebKit

Reviewed by Geoff Garen.

<rdar://problem/4564131> WebPluginDatabase setAdditionalWebPlugInPaths needs to be per WebView

Added some WebView SPI so that individual WebViews may have different plugin search paths. There are some
limitations with the approach taken here:

  • JavaScript may only access the global plugin DB.
  • When this SPI is in use, certain WebView methods may not give accurate results, such as +canShowMIMEType:.
  • This only works for plugins referenced using the <object> or <embed> tags; plugins that reside in non-standard file system locations may not be loaded directly into frames.


None of these issues are important to the client that needs this SPI. Rather than re-architect our entire
plugin database, I think it is better to simply accept these limitations for now.

  • Plugins/WebPluginDatabase.h: Added "plugInPaths" ivar, so different plugin databases can have different search paths.
  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): Give the global plugin database the default plugin search paths. (+[WebPluginDatabase setAdditionalWebPlugInPaths:]): Removed static global; this method now sets the plugin paths on the global plugin database. (-[WebPluginDatabase setPlugInPaths:]): Setter method for plugin paths. (-[WebPluginDatabase close]): New method; called when the plugin database is no longer needed (when its WebView is being destroyed). (-[WebPluginDatabase init]): Don't refresh in -init, so that callers can set the DB's plugin path array before it refreshes. (-[WebPluginDatabase dealloc]): Moved here from near the bottom of the file. Release new ivar. (-[WebPluginDatabase refresh]): Use the plugInPaths ivar instead of calling pluginLocations(). Notify plugin packages when they are added to and removed from a plugin database. A plugin package will unload itself when it is removed from all of its plugin databases. The only really tricky thing here is that the global MIME <-> view class registrations are only modified by the shared plugin DB. (+[WebPluginDatabase _defaultPlugInPaths]): Refactored from the old pluginLocations() function; returns the default set of plugin search paths.
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Assert that this package has been removed from all of its containing plugin databases. (-[WebBasePluginPackage finalize]): ditto (-[WebBasePluginPackage wasAddedToPluginDatabase:]): Add plugin database to set. (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]): Remove plugin database from set. If it was the last DB, then unload the plugin package.
  • WebView/WebViewInternal.h: Added instance methods to find the view class or plugin package, given a MIME type or file extension.
  • WebView/WebViewPrivate.h: Added SPI to set plugin search paths per WebView.
  • WebView/WebView.m: (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): New method; tries the global MIME <-> view map first; failing that, it checks the WebView's plugin DB. (-[WebView _close]): Close the plugin DB. (-[WebView _setAdditionalWebPlugInPaths:]): Create the plugin DB if necessary, and set its plugin paths. (-[WebView _pluginForMIMEType:]): Checks global plugin DB, falls back on WebView DB. (-[WebView _pluginForExtension:]): ditto (-[WebView _isMIMETypeRegisteredAsPlugin:]): ditto
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Use new WebView instance methods to look for plugins. (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): ditto (-[WebFrameBridge determineObjectFromMIMEType:URL:]): ditto
10:47 AM Changeset in webkit [14946] by sfalken
  • 2 edits in trunk/WebCore

2006-06-21 Steve Falkenburg <​sfalken@apple.com>

Fix build break

  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript):
9:21 AM Changeset in webkit [14945] by ap
  • 1 edit
    1 add in trunk/WebKitTools

Reviewed by Anders.

  • Scripts/run-webkit-httpd: Added.
8:27 AM Changeset in webkit [14944] by andersca
  • 2 edits in trunk/WebKitSite

2006-06-21 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed and landed by Anders.

  • blog/wp-content/themes/webkit/sidebar.php: Add link to Wiki in the navigation menu here too.
6:50 AM Changeset in webkit [14943] by andersca
  • 2 edits in trunk/WebKitSite

2006-06-21 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed and landed by Anders.

  • nav.inc: Add link to Wiki in the navigation menu.
6:24 AM Changeset in webkit [14942] by andersca
  • 3 edits in trunk/WebCore

2006-06-21 Anders Carlsson <​acarlsson@apple.com>

Move FrameWin::shouldInterruptJavaScript to TemporaryLinkStubs.cpp


  • bridge/win/FrameWin.cpp:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript):
1:40 AM Changeset in webkit [14941] by adele
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9523
More Win32 build bustage.


  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::shouldInterruptJavaScript):
  • bridge/win/FrameWin.h:
12:45 AM Changeset in webkit [14940] by thatcher
  • 7 edits
    3 adds in trunk/WebKitTools

Reviewed by Eric.

Builds Drosera and a launcher to include with the nightly.

  • BuildSlaveSupport/build-launcher-app:
  • BuildSlaveSupport/build-launcher-dmg:
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/Info.plist:
  • Drosera/LauncherInfo.plist: Added.
  • Drosera/launcher.m: Added. (displayErrorAndQuit): (checkMacOSXVersion): (myExecve): (main):
  • Scripts/build-drosera
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/main.m: (main):
12:27 AM Changeset in webkit [14939] by mjs
  • 16 edits in trunk/LayoutTests

No review - updated results for earlier patch.


  • updated SVG test results where my recent fix affected bounding boxes


I think the new results are more accurate bounding boxes and in
any case there is no actual difference in rendered output.

  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/custom/foreign-object-skew-expected.txt:
  • svg/custom/image-with-transform-clip-filter-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
12:27 AM Changeset in webkit [14938] by adele
  • 4 edits in trunk/LayoutTests/dom

Updated results for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

12:26 AM Changeset in webkit [14937] by adele
  • 9 edits in trunk/LayoutTests/tables/mozilla/bugs

Updated results for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

12:23 AM Changeset in webkit [14936] by adele
  • 94 edits in trunk/LayoutTests

Reviewed by Anders.

Updated results for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

Changes include some size differences since the new textareas have 4 pixels less horizontal padding,
and the renderer name for textareas has changed from RenderTextArea to RenderTextField.

  • dom/html/level2/html/HTMLTextAreaElement14-expected.txt:
  • dom/html/level2/html/HTMLTextAreaElement15-expected.txt:
  • dom/xhtml/level2/html/HTMLTextAreaElement14-expected.txt:
  • dom/xhtml/level2/html/HTMLTextAreaElement15-expected.txt:
  • fast/block/margin-collapse/103-expected.checksum:
  • fast/block/margin-collapse/103-expected.png:
  • fast/block/margin-collapse/103-expected.txt:
  • fast/dynamic/008-expected.checksum:
  • fast/dynamic/008-expected.png:
  • fast/dynamic/008-expected.txt:
  • fast/forms/001-expected.checksum:
  • fast/forms/002-expected.checksum:
  • fast/forms/003-expected.checksum:
  • fast/forms/004-expected.checksum:
  • fast/forms/005-expected.checksum:
  • fast/forms/006-expected.checksum:
  • fast/forms/007-expected.checksum:
  • fast/forms/8250-expected.checksum:
  • fast/forms/blankbuttons-expected.checksum:
  • fast/forms/button-cannot-be-nested-expected.checksum:
  • fast/forms/button-default-title-expected.checksum:
  • fast/forms/button-inner-block-reuse-expected.checksum:
  • fast/forms/button-positioned-expected.checksum:
  • fast/forms/button-sizes-expected.checksum:
  • fast/forms/button-table-styles-expected.checksum:
  • fast/forms/button-white-space-expected.checksum:
  • fast/forms/checkbox-radio-onchange-expected.checksum:
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/double-focus-expected.txt:
  • fast/forms/file-input-disabled-expected.checksum:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/form-hides-table-expected.checksum:
  • fast/forms/formmove-expected.checksum:
  • fast/forms/formmove2-expected.checksum:
  • fast/forms/formmove3-expected.checksum:
  • fast/forms/indeterminate-expected.checksum:
  • fast/forms/input-appearance-bkcolor-expected.checksum:
  • fast/forms/input-appearance-default-bkcolor-expected.checksum:
  • fast/forms/input-appearance-disabled-expected.checksum:
  • fast/forms/input-appearance-focus-expected.checksum:
  • fast/forms/input-appearance-minWidth-expected.checksum:
  • fast/forms/input-appearance-preventDefault-expected.checksum:
  • fast/forms/input-appearance-readonly-expected.checksum:
  • fast/forms/input-appearance-selection-expected.checksum:
  • fast/forms/input-appearance-visibility-expected.checksum:
  • fast/forms/input-appearance-width-expected.checksum:
  • fast/forms/input-baseline-expected.checksum:
  • fast/forms/input-disabled-color-expected.checksum:
  • fast/forms/input-double-click-selection-gap-bug-expected.checksum:
  • fast/forms/input-maxlength-2-expected.checksum:
  • fast/forms/input-no-renderer-expected.checksum:
  • fast/forms/input-paste-undo-expected.checksum:
  • fast/forms/input-readonly-dimmed-expected.checksum:
  • fast/forms/input-readonly-empty-expected.checksum:
  • fast/forms/input-spaces-expected.checksum:
  • fast/forms/input-table-expected.checksum:
  • fast/forms/input-text-click-inside-expected.checksum:
  • fast/forms/input-text-click-outside-expected.checksum:
  • fast/forms/input-text-double-click-expected.checksum:
  • fast/forms/input-text-drag-down-expected.checksum:
  • fast/forms/input-text-maxlength-expected.checksum:
  • fast/forms/input-text-option-delete-expected.checksum:
  • fast/forms/input-text-paste-maxlength-expected.checksum:
  • fast/forms/input-text-scroll-left-on-blur-expected.checksum:
  • fast/forms/input-text-self-emptying-click-expected.checksum:
  • fast/forms/input-value-expected.checksum:
  • fast/forms/input-width-expected.checksum:
  • fast/forms/minWidthPercent-expected.checksum:
  • fast/forms/negativeLineHeight-expected.checksum:
  • fast/forms/negativeLineHeight-expected.png:
  • fast/forms/negativeLineHeight-expected.txt:
  • fast/forms/option-index-expected.checksum:
  • fast/forms/option-script-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/plaintext-mode-2-expected.checksum:
  • fast/forms/radio-attr-order-expected.checksum:
  • fast/forms/radio_checked-expected.checksum:
  • fast/forms/radio_checked_dynamic-expected.checksum:
  • fast/forms/selection-functions-expected.txt:
  • fast/forms/tabbing-input-iframe-expected.checksum:
  • fast/forms/textAreaLineHeight-expected.checksum:
  • fast/forms/textAreaLineHeight-expected.png:
  • fast/forms/textAreaLineHeight-expected.txt:
  • fast/forms/textarea-crlf-expected.txt:
  • fast/forms/textarea-setinnerhtml-expected.checksum:
  • fast/forms/textarea-setinnerhtml-expected.png:
  • fast/forms/textarea-setinnerhtml-expected.txt:
  • fast/forms/textarea-setvalue-submit-expected.txt:
  • fast/forms/visual-hebrew-text-field-expected.checksum:
  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/replaced/width100percent-expected.txt:
  • fast/table/003-expected.checksum:
  • fast/table/003-expected.png:
  • fast/table/003-expected.txt:
  • tables/mozilla/bugs/bug194024-expected.checksum:
  • tables/mozilla/bugs/bug194024-expected.png:
  • tables/mozilla/bugs/bug194024-expected.txt:
  • tables/mozilla/bugs/bug30559-expected.checksum:
  • tables/mozilla/bugs/bug30559-expected.png:
  • tables/mozilla/bugs/bug30559-expected.txt:
  • tables/mozilla/bugs/bug30692-expected.checksum:
  • tables/mozilla/bugs/bug30692-expected.png:
  • tables/mozilla/bugs/bug30692-expected.txt:
12:23 AM Changeset in webkit [14935] by adele
  • 3 edits in trunk/WebCore

Reviewed by Anders.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

  • css/html4.css:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): (WebCore::HTMLTextAreaElement::selectionEnd): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::createRenderer): (WebCore::HTMLTextAreaElement::appendFormData): (WebCore::HTMLTextAreaElement::isKeyboardFocusable): (WebCore::HTMLTextAreaElement::isMouseFocusable): (WebCore::HTMLTextAreaElement::focus): (WebCore::HTMLTextAreaElement::defaultEventHandler): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::setValue):
Note: See TracTimeline for information about the timeline view.