⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 26, 2006:

4:53 PM Changeset in webkit [15050] by hyatt
  • 18 edits
    3 adds in trunk/WebCore

Fix for 9538, support syntax highlighted HTML source. Lots of loose
ends still (script/style/comments/doctype/entities/accurate whitespace).

Reviewed by darin

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setInViewSourceMode:]): (-[WebCoreFrameBridge inViewSourceMode]):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchUARules):
  • css/cssstyleselector.h:
  • css/view-source.css: Added.
  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • dom/xml_tokenizer.h: (WebCore::Tokenizer::Tokenizer): (WebCore::Tokenizer::~Tokenizer): (WebCore::Tokenizer::inViewSourceMode): (WebCore::Tokenizer::setInViewSourceMode):
  • html/HTMLAttributeNames.in:
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::init): (WebCore::HTMLFrameElement::parseMappedAttribute): (WebCore::HTMLFrameElement::attach):
  • html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::viewSourceMode):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::continueProcessing): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::end): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h:
  • html/HTMLViewSourceDocument.cpp: Added. (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addViewSourceAttribute): (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
  • html/HTMLViewSourceDocument.h: Added.
  • page/Frame.cpp: (WebCore::Frame::begin): (WebCore::Frame::inViewSourceMode): (WebCore::Frame::setInViewSourceMode):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
4:48 PM Changeset in webkit [15049] by hyatt
  • 4 edits in trunk/WebKit

Fix for 9538, support syntax highlighting for HTML source.

Reviewed by darin

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]):
  • WebView/WebViewPrivate.h:
2:26 PM Changeset in webkit [15048] by andersca
  • 4 edits in trunk/WebCore

2006-06-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
REGRESSION: Crash when closing tabs on newegg.com


  • page/Frame.cpp: (WebCore::Frame::pageDestroyed):
  • page/Frame.h: Add new method which is invoked when the frame's page has been destroyed. Currently this function disassociates the JS Window object with the frame, stopping any running JS timers.


  • page/Page.cpp: (WebCore::Page::~Page): Call pageDestroyed on all frames.
9:38 AM Changeset in webkit [15047] by darin
  • 10 edits in trunk/WebCore

Reviewed and reworked by Darin.

Code cleanup, calculate clientX/clientY in one central place.

  • dom/EventTargetNode.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): Renamed parameters to pageX/Y since they aren't clientX/Y values. Removed code to compute clientX/Y (was a bit confused in naming before), because that's now done inside MouseEvent.
  • dom/MouseEvent.h:
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): Removed clientX/Y parameters. (WebCore::MouseEvent::initMouseEvent): Added comments about problems I noticed. (WebCore::MouseEvent::which): Fixed comment that confusingly mentioned KHTML, when it was talking about the DOM standard.
  • dom/MouseRelatedEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::contentsX): Added helper function. (WebCore::contentsY): Ditto. (WebCore::MouseRelatedEvent::MouseRelatedEvent): Removed clientX/Y parameter, and added code to compute clientX/Y based on pageX/Y. (WebCore::MouseRelatedEvent::receivedTarget): Fixed comments.
  • dom/WheelEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Removed clientX/Y parameter.
  • page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): Removed the code to compute coordinates, and renamed the confusingly named clientPos (which was a page-relative position) to contentsPos.
8:26 AM Changeset in webkit [15046] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Darin.

  • LayoutTests/fast/events/objc-event-api-expected.txt: Updated to reflect flipped coordinates dumped by the layout tests.

WebKitTools:

Reviewed by Darin.

Bug 9579: LayoutTests/fast/events/objc-event-api.html failing due to screenY output
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9579

Report screenY values as (height of zero screen - screenY)

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController handleEvent:]):

Jun 25, 2006:

10:09 PM Changeset in webkit [15045] by thatcher
  • 3 edits in trunk/WebKitTools

Reviewed by Geoff.

Bug 9591: [Drosera] breakpoints should be dragable and deletable by dragging off the gutter
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9591


Makes breakpoints dragable. If dragged off the gutter they are deleted.

  • Drosera/debugger.js:
  • Drosera/viewer.css:
9:51 PM Changeset in webkit [15044] by darin
  • 5 edits
    11 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9185

  • fast/forms/input-appearance-height-expected.png: Added.
  • fast/forms/input-appearance-height-expected.txt: Added.
  • fast/forms/input-appearance-height.html: Added. Tests the height attribute on all input types
  • fast/forms/input-type-change-expected.checksum: Added.
  • fast/forms/input-type-change-expected.png: Added.
  • fast/forms/input-type-change-expected.txt: Added.
  • fast/forms/input-type-change.html: Added. Tests changing an input type=TEXT to type=IMAGE with a height and width specified on the element.
  • fast/forms/input-type-change2-expected.checksum: Added.
  • fast/forms/input-type-change2-expected.png: Added.
  • fast/forms/input-type-change2-expected.txt: Added.
  • fast/forms/input-type-change2.html: Added. Tests changing an input type=IMAGE to type=TEXT with a height and width specified on the element.

WebCore:

Reviewed and tweaked by Darin.

  • dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::getAttributeItem): Added to static_cast method.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Update the style decl if input type has changed. (WebCore::HTMLInputElement::mapToEntry): Only Cache height and width if it is an IMAGE or HIDDEN (WebCore::HTMLInputElement::parseMappedAttribute): Check type before adding height and width style. (WebCore::HTMLInputElement::attach): Remove code for discarding width.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::respectHeightAndWidthAttrs): New method added to report if this input type uses height & width.
8:12 PM Changeset in webkit [15043] by ggaren
  • 6 edits in trunk/JavaScriptCore

Reviewed by Adele.


  • Added JSConstructorMake to match JSFunctionMake, along with test code.


[ I checked in the ChangeLog before without the actual files. ]

  • API/JSObjectRef.cpp: (JSConstructorMake):
  • API/JSObjectRef.h:
  • API/testapi.c: (myConstructor_callAsConstructor): (main):
  • API/testapi.js:
  • ChangeLog:
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi target -- this was an oversight in my earlier check-in.
7:17 PM Changeset in webkit [15042] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.


Bug 9568: assertion failure in Safari after quitting Drosera
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9568

Call switchToServerNamed:nil and not removeLister to make sure
the server object is set to nil to prevent further removeListener calls.

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument applicationTerminating:]):
5:28 PM Changeset in webkit [15041] by ddkilzer
  • 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

  • fast/forms/textarea-hard-linewrap-empty.html: Submit form without setTimeout().
  • fast/forms/textarea-hard-linewrap.html: Ditto.
4:55 PM Changeset in webkit [15040] by ddkilzer
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/forms/textarea-hard-linewrap-empty.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks): Added null check for m_div->firstChild()->renderer().

LayoutTests:

Reviewed by Darin.

  • fast/forms/textarea-hard-linewrap-empty-expected.txt: Added.
  • fast/forms/textarea-hard-linewrap-empty.html: Added.
  • fast/forms/textarea-hard-linewrap.html: Reduced timeout from 200ms to 0ms and renamed function from foo() to submitForm().
4:28 PM Changeset in webkit [15039] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-apply: Speed up isDirectoryEmptyForRemoval() by returning as soon as we find that the directory is not empty instead of reading in every single file and directory first, then checking the count. Avoid warning in removeDirectoriesIfNeeded() if $svnOutput is not defined.
4:17 PM Changeset in webkit [15038] by ddkilzer
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/repaint/outline-shrinking.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Always repaint with the old style if the outline is becoming narrower, even if we are going to relayout.

LayoutTests:

Reviewed by Darin.

  • fast/repaint/outline-shrinking-expected.checksum: Added.
  • fast/repaint/outline-shrinking-expected.png: Added.
  • fast/repaint/outline-shrinking-expected.txt: Added.
  • fast/repaint/outline-shrinking.html: Added.
2:45 PM Changeset in webkit [15037] by thatcher
  • 4 edits in tags/Safari-521.13.1/WebKit

Adds an SPI Mail needs, and versioning.

2:42 PM Changeset in webkit [15036] by thatcher
  • 4 edits in tags/Safari-521.13.1/WebCore

Build fix, and versioning.

2:38 PM Changeset in webkit [15035] by thatcher
  • 1 copy in tags/Safari-521.13.1

New tag.

1:56 PM Changeset in webkit [15034] by thatcher
  • 3 edits in trunk/WebCore

Build fix for for GCC 5406

1:37 PM Changeset in webkit [15033] by thatcher
  • 1 edit in trunk/WebCore/dom/Document.cpp

Rolls out a build fix I made on Friday, this was correctly fixed by adding a long version of operator[] to Vector.

1:37 PM Changeset in webkit [15032] by ddkilzer
  • 9 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
event.clientX and event.clientY should be relative to the viewport, not the canvas

Make sure clientX and clientY take into account the scroll offsets
of the view.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
  • dom/MouseRelatedEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):
  • page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent):

LayoutTests:

Reviewed by Darin.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
event.clientX and event.clientY should be relative to the viewport, not the canvas

  • fast/dom/window-xy-properties-expected.txt: Added.
  • fast/dom/window-xy-properties.html: Added.
1:32 PM Changeset in webkit [15031] by thatcher
  • 1 edit in trunk/WebKit/DefaultDelegates/WebScriptDebugServer.m

Leak fix

1:01 PM Changeset in webkit [15030] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/svn-apply: Tweak comments.
  • Scripts/svn-create-patch: Ditto.
  • Scripts/svn-unapply: Ditto.
12:42 PM Changeset in webkit [15029] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Formatting fix per Bug 9571 Comment #2. Reviewed by NOBODY.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9571#c2

  • Scripts/svn-apply: Formatting fix.
12:39 PM Changeset in webkit [15028] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9571
Teach svn-apply and svn-unapply to handle directory adds and removes better

  • Scripts/svn-apply: Handle directory adds more intelligently. Handle directory removes.
  • Scripts/svn-unapply: Handle undoing both directory adds and removes.
11:59 AM Changeset in webkit [15027] by thatcher
  • 20 edits in trunk/LayoutTests

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9560


This fix converted the resize corner image to a B/W tiff.
The pixel tests showed 0.0% changes but still said it had differences.
Updating the tests that use CSS3 resize or textarea.

  • fast/forms/floating-textfield-relayout-expected.checksum:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/negativeLineHeight-expected.checksum:
  • fast/forms/negativeLineHeight-expected.png:
  • fast/forms/textAreaLineHeight-expected.checksum:
  • fast/forms/textAreaLineHeight-expected.png:
  • fast/forms/textarea-setinnerhtml-expected.checksum:
  • fast/forms/textarea-setinnerhtml-expected.png:
  • fast/overflow/overflow-x-y-expected.checksum:
  • fast/overflow/overflow-x-y-expected.png:
  • fast/table/003-expected.checksum:
  • fast/table/003-expected.png:
  • tables/mozilla/bugs/bug194024-expected.checksum:
  • tables/mozilla/bugs/bug194024-expected.png:
  • tables/mozilla/bugs/bug30559-expected.checksum:
  • tables/mozilla/bugs/bug30559-expected.png:
  • tables/mozilla/bugs/bug30692-expected.checksum:
  • tables/mozilla/bugs/bug30692-expected.png:
10:53 AM Changeset in webkit [15026] by thatcher
  • 22 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Pass the starting line number and error message to the debugger.

  • kjs/debugger.cpp: (Debugger::sourceParsed):
  • kjs/debugger.h:
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):

WebCore:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

  • Pass the starting line number and error message to the debugger.
  • Call parsedSource even if there was a script parse error so the debugger can show the parse error.
  • Pass NSURL objects to the ObjC delegate for the script URLs.
  • bridge/mac/WebCoreScriptDebugger.h:
  • bridge/mac/WebCoreScriptDebugger.mm: (toNSURL): (WebCoreScriptDebuggerImp::sourceParsed):

WebKit:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

  • Adds a new version of the didParseSource delegate callback with base line number.
  • Adds a new delegate callback for when a script fails to parse.
  • These new callbacks use NSURLs for the url parameter.
  • Adds a new script listener callback to notify when the main resource loads.
  • Adds a WebScriptErrorDomian and other keys for use with NSError.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: (-[WebDefaultScriptDebugDelegate webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServer.h:
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]): (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
  • WebKit.exp:
  • WebView/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]):
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):

WebKitTools:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Refactor the JavaScript code to have a distinction between files
and scripts. Show the script in the context of the HTML file if
it's URL is the same as the frame's main resource. At the time of
the disParseScript callback the main resource might not be completely
loaded, but Drosera needs to show whatever we have at the time. Once
the main resource is finished, update the file source and reload the file.

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument pause]): (-[DebuggerDocument webView:didLoadMainResourceForDataSource:]): (-[DebuggerDocument webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[DebuggerDocument webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • Drosera/debugger.css:
  • Drosera/debugger.js:
Note: See TracTimeline for information about the timeline view.