⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 28, 2006:

5:32 PM Changeset in webkit [15090] by hyatt
  • 11 edits in trunk

WebCore:

Add support for custom highlighting to paint at the root line box level
(and to inflate the box it uses so that it can go outside the bounds of
the line if necessary).

Reviewed by harrison

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::customHighlightLineRect): (WebCore::FrameMac::paintCustomHighlight):
  • bridge/mac/WebCoreFrameBridge.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:

WebKit:

Fix custom highlighting so that you can paint the entire line (and go
outside the bounds of the line).

Reviewed by harrison

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge customHighlightRect:forLine:]): (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLViewPrivate.h:
5:20 PM Changeset in webkit [15089] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


  • fix Frame leak on layout tests
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge outerView]): Return WebFrameView for main frame instead of WebView to avoid reference cycle between WebView and Page.
4:44 PM Changeset in webkit [15088] by lweintraub
  • 5 edits
    16 adds in trunk

LayoutTests:

Reviewed by justin

<rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
<rdar://problem/4590763> FormatBlock for paragraph style doesn't work

  • editing/execCommand/format-block-with-braces-expected.checksum: Added.
  • editing/execCommand/format-block-with-braces-expected.png: Added.
  • editing/execCommand/format-block-with-braces-expected.txt: Added.
  • editing/execCommand/format-block-with-braces.html: Added.
  • editing/execCommand/indent-list-item-expected.checksum: Added.
  • editing/execCommand/indent-list-item-expected.png: Added.
  • editing/execCommand/indent-list-item-expected.txt: Added.
  • editing/execCommand/indent-list-item.html: Added.
  • editing/execCommand/indent-selection-expected.checksum: Added.
  • editing/execCommand/indent-selection-expected.png: Added.
  • editing/execCommand/indent-selection-expected.txt: Added.
  • editing/execCommand/indent-selection.html: Added.
  • editing/execCommand/outdent-selection-expected.checksum: Added.
  • editing/execCommand/outdent-selection-expected.png: Added.
  • editing/execCommand/outdent-selection-expected.txt: Added.
  • editing/execCommand/outdent-selection.html: Added.

WebCore:

Reviewed by justin

<rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
<rdar://problem/4590763> FormatBlock for paragraph style doesn't work

  • dom/Node.cpp: (WebCore::Node::rootEditableElement): Return inline nodes
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Keep from inserting before editable content
  • editing/JSEditor.cpp: Support html braces (<>) around tag names
4:18 PM Changeset in webkit [15087] by justing
  • 3 edits in trunk/WebCore

Reviewed by levi


svg/custom/text-hit-test.svg was failing

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Don't skip child renderers that have a height of 0 when looking for the closest child renderer, they may contain content that overflows.
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Fixed typos.
1:43 PM Changeset in webkit [15086] by hyatt
  • 3 edits in trunk/WebCore

Make the view source document properly handle <script>. We don't syntax
highlight the JS yet, but it shows up properly now.

Reviewed by john

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
1:32 PM Changeset in webkit [15085] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

JavaScriptGlue:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

  • WebKit.xcodeproj/project.pbxproj:
1:18 PM Changeset in webkit [15084] by justing
  • 4 edits in trunk/WebCore

Reviewed by levi


Fixed EditActions for InsertHorizontalRule and RemoveFormat.


  • editing/JSEditor.cpp:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::editingAction):
  • editing/ReplaceSelectionCommand.h:
1:09 PM Changeset in webkit [15083] by aliceli1
  • 1 edit in trunk/WebKitSite/projects/compat/hitlist.html

added google spreadsheets and yahoo mail beta, moved google calendar and yahoo preview to alumni list.

11:58 AM Changeset in webkit [15082] by lweintraub
  • 1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.h

Build Fix

11:36 AM Changeset in webkit [15081] by lweintraub
  • 2 edits in trunk/WebCore

Build Fix. Reviewed by NOBODY

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion):
11:17 AM Changeset in webkit [15080] by lweintraub
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by justin

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent

  • editing/execCommand/indent-list-item-expected.checksum: Added.
  • editing/execCommand/indent-list-item-expected.png: Added.
  • editing/execCommand/indent-list-item-expected.txt: Added.
  • editing/execCommand/indent-list-item.html: Added.
  • editing/execCommand/indent-selection-expected.checksum: Added.
  • editing/execCommand/indent-selection-expected.png: Added.
  • editing/execCommand/indent-selection-expected.txt: Added.
  • editing/execCommand/indent-selection.html: Added.
  • editing/execCommand/outdent-selection.html: Added.

WebCore:

Reviewed by justin

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent

  • WebCore.vcproj/WebCore/WebCore.vcproj: Added IndentOutdentCommand.h/cpp
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • editing/IndentOutdentCommand.cpp: Added. (WebCore::IndentOutdentCommand::IndentOutdentCommand): (WebCore::enclosingListOrBlockquote): (WebCore::IndentOutdentCommand::splitTreeToNode): Splits the DOM tree from a descendent node to an ending ancestor, duplicating nodes when necessary. Returns the last node split. Used to insert blockquotes at the topmost level. (WebCore::IndentOutdentCommand::indentRegion): (WebCore::IndentOutdentCommand::outdentParagraph): (WebCore::IndentOutdentCommand::outdentRegion): (WebCore::IndentOutdentCommand::doApply):
  • editing/IndentOutdentCommand.h: Added. (WebCore::IndentOutdentCommand::):
  • editing/JSEditor.cpp: Added the execCommands Indent and Outdent
  • editing/htmlediting.cpp: (WebCore::enclosingNodeWithTag): Finds the enclosing node with any specified tag. (WebCore::enclosingListChild): Added checks for nill and editable boundaries. (WebCore::outermostEnclosingListChild): Returns the highest ancestor list child. (WebCore::highestAncestor): Added. (WebCore::createElement): Changed the passed in string to a const reference.
  • editing/htmlediting.h:

WebKit:

Reviewed by justin

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent
Added undo action strings and enum values

  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):
8:42 AM Changeset in webkit [15079] by darin
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin and Hyatt.

  • fast/forms/button-generated-content-expected.checksum: Added.
  • fast/forms/button-generated-content-expected.png: Added.
  • fast/forms/button-generated-content-expected.txt: Added.
  • fast/forms/button-generated-content.html: Added.

WebCore:

Reviewed by Darin and Hyatt.

Test: fast/forms/button-generated-content.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updatePseudoChild): Added. Calls updatePseudoChildForObject() on the button itself or on its inner div, if it has one.
  • rendering/RenderButton.h: (WebCore::RenderButton::createsAnonymousWrapper): Added. Returns true.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::pseudoChild): Added. Returns the child containing generated content of the requested type if there is one, or otherwise the child before/after which such generated content should come. (WebCore::RenderContainer::updatePseudoChild): Removed the child parameter and moved the guts of this method into updatePseudoChildForObject, which this method calls unless the object is an anonymous wrapper. (WebCore::RenderContainer::updatePseudoChildForObject): Added. Does the what updatePseudoChildForObject did previously, but fetches the pseudo style from the styledObject parameter.
  • rendering/RenderContainer.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow):
  • rendering/RenderObject.h: (WebCore::RenderObject::createsAnonymousWrapper): Added. This method replaces allowsReusingAnonymousChild and returns the opposite of what that method used to return. Returns true if the object creates an anonymous child to contain all its other children.
7:39 AM Changeset in webkit [15078] by darin
  • 3 edits in trunk/LayoutTests

Reviewed by Darin.

Improved test to check offsetX/Y after dispatching instead of before.

  • fast/dom/window-xy-properties.html:
  • fast/dom/window-xy-properties-expected.txt:
12:18 AM Changeset in webkit [15077] by beidson
  • 10 edits
    1 add in trunk

WebCore:

Reviewed by Maciej

Hookup the new semi-functional SQLite icon database.
For now, it is living side-by-side with the old DB so one can compare the
two for debugging purposes. Also, it is disabled (in WebKit) by default unless you
compile with ICONDEBUG #defined.

  • WebCore.xcodeproj/project.pbxproj: Added file SiteIcon.cpp
  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
  • icon/IconDatabase.cpp: (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::createPrivateTables): (WebCore::IconDatabase::deletePrivateTables): (WebCore::IconDatabase::imageDataForIconID): (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::imageDataForPageURL): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::iconURLForURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL):
  • icon/IconDatabase.h: (WebCore::SiteIcon::getIconURL): (WebCore::IconDatabase::getPrivateBrowsingEnabled):


  • icon/SiteIcon.cpp: Added. (SiteIcon::SiteIcon): (SiteIcon::~SiteIcon): (SiteIcon::getImage): (SiteIcon::resetExpiration): (SiteIcon::getExpiration):

WebKit:

Reviewed by Maciej

Hookup the new semi-functional SQLite icon database.
For now, it is living side-by-side with the old DB so one can compare the
two for debugging purposes. Also, it is disabled (in WebKit) by default unless you
compile with ICONDEBUG #defined.
Note: To repeat that, if you want to try the new DB, #define ICONDEBUG (WebKitPrefix.h is a good place to do it)

  • Misc/WebIconDatabase.m: (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasIconForIconURL:]): (-[WebIconDatabase _resetCachedWebPreferences:]):
  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • WebKit.xcodeproj/project.pbxproj:

Jun 27, 2006:

8:52 PM Changeset in webkit [15076] by darin
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

Updated test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9605

  • fast/dom/window-xy-properties.html:
  • fast/dom/window-xy-properties-expected.txt:

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9605
REGRESSION: pageX and pageY are both 0 for events created with initMouseEvent

Calculate pageX/pageY and clientX/clientY values when using initMouseEvent.

  • dom/MouseEvent.cpp: (WebCore::MouseEvent::initMouseEvent):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::initCoordinates):
  • dom/MouseRelatedEvent.h:
8:32 PM Changeset in webkit [15075] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/tokenizer/write-unclosed-script-expected.txt: Added.
  • fast/tokenizer/write-unclosed-script.html: Added.

WebCore:

Reviewed by Maciej and Darin.

Test: fast/tokenizer/write-unclosed-script.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Changed to reset the inScript flag and scriptCodeSize before possible script execution, but not afterwards. This way, if script execution write()s a <script> tag without closing it, the tokenizer is left in inScript state. Added code to set the requestingScript flag around the request for the cached script, to let notifiyFinished() know that it's being called under scriptHandler(). (WebCore::HTMLTokenizer::scriptExecution): Removed code that saved and restored the inScript flag. This function is always entered now with inScript being false. (WebCore::HTMLTokenizer::notifyFinished): Changed to use the new requestingScript state flag instead of the inScript flag, which is always false now when entering this function.
  • html/HTMLTokenizer.h: Added the requestingScript state bit, used to tell notifyFinished() that it is being called under scriptHandler() (which happens when the script is already in cache).
7:26 PM Changeset in webkit [15074] by justing
  • 1 edit in trunk/LayoutTests/editing/execCommand/remove-formatting.html

Fixed some typos.

7:23 PM Changeset in webkit [15073] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/execCommand/remove-formatting-expected.checksum: Added.
  • editing/execCommand/remove-formatting-expected.png: Added.
  • editing/execCommand/remove-formatting-expected.txt: Added.
  • editing/execCommand/remove-formatting.html: Added.

WebCore:

Reviewed by levi

  • editing/JSEditor.cpp: Added RemoveFormat.
7:17 PM Changeset in webkit [15072] by kdecker
  • 2 edits in trunk/WebCore
5:18 PM Changeset in webkit [15071] by thatcher
  • 9 edits in trunk/JavaScriptCore

Reviewed by Tim O.

<rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore, WebKit and WebBrowser

Switch to the new ObjC 2 API, ifdefed the old code around OBJC_API_VERSION so it still works on Tiger.
Removed the use of the old stringWithCString, switched to the new Tiger version that accepts an encoding.
Lots of code style cleanup.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::~ObjcClass): (KJS::Bindings::_createClassesByIsAIfNecessary): (KJS::Bindings::ObjcClass::classForIsA): (KJS::Bindings::ObjcClass::name): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed): (KJS::Bindings::ObjcClass::fallbackObject):
  • bindings/objc/objc_header.h:
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): (ObjcInstance::~ObjcInstance): (ObjcInstance::operator=): (ObjcInstance::begin): (ObjcInstance::end): (ObjcInstance::getClass): (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfField): (ObjcInstance::supportsSetValueOfUndefinedField): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfField): (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue): (ObjcInstance::stringValue): (ObjcInstance::numberValue): (ObjcInstance::booleanValue): (ObjcInstance::valueOf):
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcMethod::ObjcMethod): (ObjcMethod::name): (ObjcMethod::getMethodSignature): (ObjcMethod::setJavaScriptName): (ObjcField::name): (ObjcField::type): (ObjcField::valueFromInstance): (convertValueToObjcObject): (ObjcField::setValueToInstance): (ObjcArray::operator=): (ObjcArray::setValueAt): (ObjcArray::valueAt): (ObjcFallbackObjectImp::ObjcFallbackObjectImp): (ObjcFallbackObjectImp::callAsFunction): (ObjcFallbackObjectImp::defaultValue):
4:59 PM Changeset in webkit [15070] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-06-28 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8636
REGRESSION: JavaScript access to Java applet causes hang (_webViewURL not implemented)


  • bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall): Just pass nil as the calling URL. This will cause the Java plugin to use the URL of the page containing the applet (which is what we used to do).
4:58 PM Changeset in webkit [15069] by andersca
  • 3 edits in trunk/WebCore

2006-06-28 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Move FIXME comment here.


  • page/DOMWindow.cpp: (WebCore::DOMWindow::getComputedStyle): Don't do a null check on the renderer here. Everything's handled by CSSComputedStyleDeclaration anyway.
3:56 PM Changeset in webkit [15068] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin

  • rendering/RenderContainer.cpp: Fixed #include formatting.
3:26 PM Changeset in webkit [15067] by justing
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work


Added:

  • editing/selection/click-before-and-after-table-expected.txt: Added.
  • editing/selection/click-before-and-after-table.html: Added. Updated to reflect fix:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:

WebCore:

Reviewed by levi


<rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): In the fall through case, where we can't find a child block that contains (x, y), pass to RenderFlow instead of the last visible child block.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Don't pass to the closest child renderer if this is a table and (x, y) is outside the table. Return a VisiblePosition before or after the table. Fixed the code that finds the closest child renderer.
3:04 PM Changeset in webkit [15066] by hyatt
  • 3 edits in trunk/WebCore

Preserve entity text in view source mode. This patch doesn't highlight the
the entities yet, but it at least prevents their resolution and removal.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseEntity):
2:30 PM Changeset in webkit [15065] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-27 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
REGRESSION: getComputedStyle should do a relayout


  • page/DOMWindow.cpp: (WebCore::DOMWindow::getComputedStyle): Do a relayout.

LayoutTests:

2006-06-27 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
REGRESSION: getComputedStyle should do a relayout

  • fast/css/getComputedStyle-relayout-expected.txt: Added.
  • fast/css/getComputedStyle-relayout.html: Added.
2:13 PM Changeset in webkit [15064] by thatcher
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.exp

Adding symbols for debug builds.

2:03 PM Changeset in webkit [15063] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/JavaScriptCore

JavaScriptCore 10.4.7 release.

2:02 PM Changeset in webkit [15062] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/WebCore

WebCore 10.4.7 release.

2:02 PM Changeset in webkit [15061] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/WebKit

WebKit 10.4.7 release.

2:00 PM Changeset in webkit [15060] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/JavaScriptGlue

JavaScriptGlue 10.4.7 release.

1:59 PM Changeset in webkit [15059] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.7

10.4.7 release tag.

1:53 PM Changeset in webkit [15058] by thatcher
  • 2 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/4406785> Add an export file to TOT JavaScriptCore like the Safari-2-0-branch

1:36 PM Changeset in webkit [15057] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Adele

  • fixed <rdar://problem/4550473> Reproducible hang on www.digg.com


  • dom/NodeList.cpp: (WebCore::NodeList::recursiveItem): Make NodeList caching also work for backwards iteration - if the requested index is before the last cached, but closer to it than to the start of the list, then search backwards from there. (WebCore::NodeList::itemForwardsFromCurrent): Split this out as a helper method. (WebCore::NodeList::itemBackwardsFromCurrent): New helper, similar to the above.
  • dom/NodeList.h:
12:07 PM Changeset in webkit [15056] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Levi

Some SQLDatabase cleanup (style stuff) and enhancements

  • icon/SQLDatabase.cpp: (SQLDatabase::open): (SQLDatabase::executeCommand): (SQLDatabase::returnsAtLeastOneResult): Accessor to see if this query returns results (SQLDatabase::lastInsertRowID): Accessor for the rowid of the last insert
  • icon/SQLDatabase.h: (WebCore::SQLStatement::prepareAndStep):
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::bindInt64): -All of the following used to require the user to manually prepare and step a statement before asking for the result. Now it will prepare and step itself so you can use a temporary object to get a quick result (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): (WebCore::SQLStatement::getColumnDouble): (WebCore::SQLStatement::getColumnInt): (WebCore::SQLStatement::getColumnInt64): (WebCore::SQLStatement::getColumnBlobAsVector): (WebCore::SQLStatement::getColumnBlob):
11:15 AM Changeset in webkit [15055] by adachan
  • 2 edits in trunk/WebCore

2006-06-27 Ada Chan <​adachan@apple.com>

Reviewed by sfalken.

Fixed build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
10:56 AM Changeset in webkit [15054] by bdakin
  • 4 edits
    15 adds in trunk

Reviewed by Hyatt.

Fix for <rdar://problem/4602635> Media queries must be extended to
address CSS pixel scaling factor

  • css/MediaFeatureNames.h: Add -webkit-device-pixel-ratio, -webkit- min-device-pixel-ratio, and -webkit-max-device-pixel-ratio to the list of feature names.
  • css/MediaQueryEvaluator.cpp: (WebCore::cmpvalue): Added a version of cmpvalue that compares floats. (WebCore::device_pixel_ratioMediaFeatureEval): (WebCore::min_device_pixel_ratioMediaFeatureEval): (WebCore::max_device_pixel_ratioMediaFeatureEval):
10:44 AM Changeset in webkit [15053] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Change to use pageX/Y, but this really doesn't matter since framesets can't be scrolled -- it's the frames that are scrolled. So this change has no user-visible effect, but it's still better this way.
10:22 AM Changeset in webkit [15052] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Tests for fix for 2/3 of ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
REGRESSION: some callers are still using clientX/Y to get pageX/Y

  • fast/events/anchor-image-scrolled-x-y-expected.txt: Added.
  • fast/events/anchor-image-scrolled-x-y.html: Added.
  • fast/events/input-image-scrolled-x-y-expected.txt: Added.
  • fast/events/input-image-scrolled-x-y.html: Added.

WebCore:

Reviewed by Geoff.

Test: fast/events/anchor-image-scrolled-x-y.html
Test: fast/events/input-image-scrolled-x-y.html

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Use pageX/Y.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
12:35 AM Changeset in webkit [15051] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Added functionality to WebCore::Image to get multiple representations/sizes into TIFF data

  • platform/mac/ImageMac.mm: (WebCore::Image::getTIFFRepresentation):
Note: See TracTimeline for information about the timeline view.