Timeline



Jun 29, 2006:

11:36 PM Changeset in webkit [15105] by ddkilzer
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Hyatt.

Note: patch originally from Mitz, spruced up by Weinig.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteVerticalValues):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):

LayoutTests:

Reviewed by Hyatt.

Note: test case originally from Mitz.

  • fast/table/absolute-table-at-bottom-expected.checksum: Added.
  • fast/table/absolute-table-at-bottom-expected.png: Added.
  • fast/table/absolute-table-at-bottom-expected.txt: Added.
  • fast/table/absolute-table-at-bottom.html: Added.
10:56 PM Changeset in webkit [15104] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by mjs and timo.


Fixed: <rdar://problem/4609119> handleAuthenticationFromResource was removed; needed by the Dashboard

  • WebView/WebViewPrivate.h: Added handleAuthenticationFromResource back into the header. Needed by the Dashboard, but was removed in r.14028 on 2006-04-23.
10:35 PM Changeset in webkit [15103] by ddkilzer
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Justin.

  • editing/CompositeEditCommand.cpp: Added sanity checking to prevent modifying nodes outside of where we should be (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):

LayoutTests:

Reviewed by Justin.

  • editing/pasteboard/paste-table-002.html: Added.
  • editing/pasteboard/paste-table-002-expected.checksum: Added.
  • editing/pasteboard/paste-table-002-expected.png: Added.
  • editing/pasteboard/paste-table-002-expected.txt: Added.
9:45 PM Changeset in webkit [15102] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Levi.

In addition to a few small details, logging changes, and style cleanups, this is a stop-gap hack
for a problem in SQLite's blob handling. Querying for a blob in a void* form is reproducibly
returning a corrupt buffer. The temporary solution is to query for the blob as "quoted text" and
manually convert the return string into a character buffer.

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::createPrivateTables):

(WebCore::hexToUnsignedChar): These two functions are the text-to-character-data converters for the time being
(WebCore::hexStringToVector):

(WebCore::IconDatabase::imageDataForIconID):
(WebCore::IconDatabase::imageDataForIconURL):
(WebCore::IconDatabase::imageDataForPageURL):
(WebCore::IconDatabase::iconForPageURL):
(WebCore::IconDatabase::hasIconForIconURL):

  • icon/IconDatabase.h: changes the icon data accessors to return a Vector<unsigned char> instead of void*
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::columnCount): (WebCore::SQLStatement::getColumnBlob):
  • icon/SiteIcon.cpp: (SiteIcon::getImage):
9:39 PM Changeset in webkit [15101] by ddkilzer
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/table/rtl-cell-display-none-assert.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): Corrected the index used as the last index in the columnPos vector.

LayoutTests:

Reviewed by Darin.

  • fast/table/rtl-cell-display-none-assert-expected.checksum: Added.
  • fast/table/rtl-cell-display-none-assert-expected.png: Added.
  • fast/table/rtl-cell-display-none-assert-expected.txt: Added.
  • fast/table/rtl-cell-display-none-assert.html: Added.
9:31 PM Changeset in webkit [15100] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4608487> REGRESSION: reproducible crash in +[WebCoreFrameBridge supportedImageMIMETypes]

  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase setAdditionalWebPlugInPaths:]): One might be tempted to add additionalWebPlugInPaths to the global WebPluginDatabase here. For backward compatibility with earlier versions of the +setAdditionalWebPlugInPaths: SPI, we need to save a copy of the additional paths and not cause a refresh of the plugin DB at this time. (-[WebPluginDatabase _plugInPaths]): Include additionalWebPlugInPaths if this is the global DB. (-[WebPluginDatabase refresh]): Call -_plugInPaths to get the modified array of paths. This is similar to what the old code (before we had per-WebView plugin search paths).
9:24 PM Changeset in webkit [15099] by ddkilzer
  • 1 edit
    14 adds in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Bug 9615: Buildbot configuration should be in SVN repository
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9615

Import BuildBot configuration files as used by build.webkit.org.
auth.py has been stubbed out so that slave passwords are not disclosed.

  • BuildSlaveSupport/build.webkit.org-config/Makefile: Added.
  • BuildSlaveSupport/build.webkit.org-config/buildbot.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/buildbot.tac: Added.
  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/init.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/auth.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Added.
9:20 PM Changeset in webkit [15098] by ddkilzer
  • 6 edits
    1 add in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Bug 9614: Nightly builds should notify user if a newer build is available
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9614

  • BuildSlaveSupport/build-launcher-app: Write revision number to WebKit.app's VERSION file.
  • BuildSlaveSupport/build-launcher-dmg: Pass revision number to server-side nightly maintenance script so it can keep track of the latest revision.
  • Scripts/run-webkit-tests: Pass build-dumprendertree's exit status through correctly.
  • WebKitLauncher/VERSION: Added. Placeholder for SVN revision number
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/start.html: Retrieve revision number from VERSION file, and pass it through to the nightly start page.
7:56 PM Changeset in webkit [15097] by darin
  • 6 edits
    2 adds in trunk/WebCore

Reviewed by Anders.

  • manual-tests/modal-dialog.html: Added.
  • manual-tests/show-modal-dialog-test.html: Added.
  • page/Frame.cpp: (WebCore::Frame::clear): Call KJSProxy::clear with the clearWindowProperties parameter instead of not calling it at all when clearWindowProperties is false.
  • bindings/js/kjs_proxy.h: Add boolean clearWindowProperties parameter.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clear): Pass clearWindowProperties variable through to Window::clear instead of not calling it at all.
  • bindings/js/kjs_window.h: Add boolean clearWindowProperties parameter.
  • bindings/js/kjs_window.cpp: (KJS::Window::clear): If clearWindowProperties is false, do only the returnValue work, not the rest of the work.
  • manual-tests/modal-dialog.html: Added.
  • manual-tests/show-modal-dialog-test.html: Added.
4:32 PM Changeset in webkit [15096] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.


  • add headerdoc comments to some of the new JS API headers
  • API/JSBase.h:
  • API/JSValueRef.h:
4:18 PM Changeset in webkit [15095] by bdakin
  • 17 edits
    5 adds in trunk

Reviewed by Hyatt.

Fix for <rdar://problem/4450615> Add composite mode to background
styles

-webkit-background-composite will set a composite mode on a
background image.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in: Add -webkit-background-composite
  • css/CSSValueKeywords.in: Add all possible values (clear, copy, source-over, source-in, source-out, source-atop, destination-over, destination-in, destination-out, destination-atop, xor, plus- darker, highlight, and plus-lighter)
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundProperty):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundComposite):
  • css/cssstyleselector.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
  • platform/GraphicsContext.h: drawTiledImage() now takes a composite operator.
  • platform/Image.h: drawTiled() now takes a composite operator.
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::drawTiled): Set the composite operator.
  • platform/mac/ImageMac.mm: (WebCore::Image::drawTiled): Set the composite operator.
  • platform/win/TemporaryLinkStubs.cpp: (Image::drawTiled):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended): Send the composite operator in the render style over to the graphics context.
  • rendering/render_style.cpp: (WebCore::BackgroundLayer::BackgroundLayer): (WebCore::BackgroundLayer::operator=): (WebCore::BackgroundLayer::operator==): (WebCore::BackgroundLayer::fillUnsetProperties): (WebCore::BackgroundLayer::cullEmptyLayers):
  • rendering/render_style.h: (WebCore::BackgroundLayer::backgroundComposite): (WebCore::BackgroundLayer::isBackgroundCompositeSet): (WebCore::BackgroundLayer::setBackgroundComposite): (WebCore::BackgroundLayer::clearBackgroundComposite): (WebCore::RenderStyle::backgroundComposite): (WebCore::RenderStyle::initialBackgroundComposite):
12:28 PM Changeset in webkit [15094] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

WebHistoryItem now supports getting and setting arbitrary properties via _transientPropertyForKey: and
-_setTransientProperty:forKey:.
For now, these properties do not persist with the rest of the history data. They are intended to hold transient
per-history-item state, which is something that was until now difficult for a WebKit client app to do.


  • History/WebHistoryItemPrivate.h:
  • History/WebHistoryItem.m: (-[WebHistoryItemPrivate dealloc]): (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]):
11:18 AM Changeset in webkit [15093] by thatcher
  • 6 edits in trunk/WebKit

Reviewed by Harrison.

Smart insert and delete, continuous spell checking and autoscroll
can now be used for any WebView, not just editable ones. All of
these make sense for documents that might contain content editable
areas or our new text fields. Autoscroll is usefull for dragging
for file input controls also.

Added a SPI to toggle WebViews tab key behavior, tabKeyCyclesThroughElements.
WebHTMLView's _interceptEditingKeyEvent now uses WebView's
tabKeyCyclesThroughElements state to determine whether or not
to process tab key events. The idea here is that tabKeyCyclesThroughElements
will be YES when this WebView is being used in a browser, and we
desire the behavior where tab moves to the next element in tab order.
If tabKeyCyclesThroughElements is NO, it is likely that the WebView
is being embedded as the whole view, as in Mail, and tabs should input
tabs as expected in a text editor. Using Option-Tab always cycles
through elements.

  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
  • WebView/WebHTMLView.m: (-[NSArray _interceptEditingKeyEvent:]):
  • WebView/WebView.m: (-[WebViewPrivate init]): (-[WebView _autoscrollForDraggingInfo:timeDelta:]): (-[WebView _shouldAutoscrollForDraggingInfo:]): (-[WebView validateUserInterfaceItem:]): (-[WebView toggleSmartInsertDelete:]): (-[WebView toggleContinuousSpellChecking:]): (-[WebView setTabKeyCyclesThroughElements:]): (-[WebView tabKeyCyclesThroughElements]):
  • WebView/WebViewPrivate.h:
8:28 AM Changeset in webkit [15092] by ddkilzer
  • 6 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9649
The no-svg build broke after r15091

  • bindings/objc/DOMInternal.h: Added #if XPATH_SUPPORT/#endif.
  • bindings/objc/DOMInternal.mm: Ditto. (raiseDOMException):
  • bindings/objc/DOMXPath.h: Ditto.
  • bindings/objc/DOMXPath.mm: Ditto.
  • bindings/objc/DOMXPathInternal.h: Ditto.
12:54 AM Changeset in webkit [15091] by andersca
  • 6 edits
    3 adds in trunk

WebCore:

2006-06-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

<rdar://problem/4599760> Objective-C XPath support


  • WebCore.xcodeproj/project.pbxproj: Add files.


  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm: (raiseDOMException): Handle XPath exceptions


  • bindings/objc/DOMXPath.h: Added. (-[DOMXPathNSResolver lookupNamespaceURI:]):
  • bindings/objc/DOMXPath.mm: Added. (-[DOMNativeXPathNSResolver dealloc]): (-[DOMNativeXPathNSResolver finalize]): (-[DOMNativeXPathNSResolver _xpathNSResolver]): (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:]): (-[DOMNativeXPathNSResolver lookupNamespaceURI:]): (-[DOMXPathResult dealloc]): (-[DOMXPathResult finalize]): (-[DOMXPathResult resultType]): (-[DOMXPathResult numberValue]): (-[DOMXPathResult stringValue]): (-[DOMXPathResult booleanValue]): (-[DOMXPathResult singleNodeValue]): (-[DOMXPathResult invalidIteratorState]): (-[DOMXPathResult snapshotLength]): (-[DOMXPathResult iterateNext]): (-[DOMXPathResult snapshotItem:]): (-[DOMXPathResult _xpathResult]): (-[DOMXPathResult _initWithXPathResult:]): (+[DOMXPathResult _xpathResultWith:]): (-[DOMXPathExpression evaluate:::]): (-[DOMXPathExpression _xpathExpression]): (-[DOMXPathExpression _initWithXPathExpression:]): (+[DOMXPathExpression _xpathExpressionWith:]): (-[DOMDocument createExpression::]): (-[DOMDocument createNSResolver:]): (-[DOMDocument evaluate:::::]):
  • bindings/objc/DOMXPathInternal.h: Added. Add Objective-C XPath API.

WebKit:

2006-06-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

  • WebKit.xcodeproj/project.pbxproj: Add DOMXPath.h header.

Jun 28, 2006:

5:32 PM Changeset in webkit [15090] by hyatt
  • 11 edits in trunk

WebCore:

Add support for custom highlighting to paint at the root line box level
(and to inflate the box it uses so that it can go outside the bounds of
the line if necessary).

Reviewed by harrison

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::customHighlightLineRect): (WebCore::FrameMac::paintCustomHighlight):
  • bridge/mac/WebCoreFrameBridge.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:

WebKit:

Fix custom highlighting so that you can paint the entire line (and go
outside the bounds of the line).

Reviewed by harrison

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge customHighlightRect:forLine:]): (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLViewPrivate.h:
5:20 PM Changeset in webkit [15089] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


  • fix Frame leak on layout tests
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge outerView]): Return WebFrameView for main frame instead of WebView to avoid reference cycle between WebView and Page.
4:44 PM Changeset in webkit [15088] by lweintraub
  • 5 edits
    16 adds in trunk

LayoutTests:

Reviewed by justin

<rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
<rdar://problem/4590763> FormatBlock for paragraph style doesn't work

  • editing/execCommand/format-block-with-braces-expected.checksum: Added.
  • editing/execCommand/format-block-with-braces-expected.png: Added.
  • editing/execCommand/format-block-with-braces-expected.txt: Added.
  • editing/execCommand/format-block-with-braces.html: Added.
  • editing/execCommand/indent-list-item-expected.checksum: Added.
  • editing/execCommand/indent-list-item-expected.png: Added.
  • editing/execCommand/indent-list-item-expected.txt: Added.
  • editing/execCommand/indent-list-item.html: Added.
  • editing/execCommand/indent-selection-expected.checksum: Added.
  • editing/execCommand/indent-selection-expected.png: Added.
  • editing/execCommand/indent-selection-expected.txt: Added.
  • editing/execCommand/indent-selection.html: Added.
  • editing/execCommand/outdent-selection-expected.checksum: Added.
  • editing/execCommand/outdent-selection-expected.png: Added.
  • editing/execCommand/outdent-selection-expected.txt: Added.
  • editing/execCommand/outdent-selection.html: Added.

WebCore:

Reviewed by justin

<rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
<rdar://problem/4590763> FormatBlock for paragraph style doesn't work

  • dom/Node.cpp: (WebCore::Node::rootEditableElement): Return inline nodes
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Keep from inserting before editable content
  • editing/JSEditor.cpp: Support html braces (<>) around tag names
4:18 PM Changeset in webkit [15087] by justing
  • 3 edits in trunk/WebCore

Reviewed by levi


svg/custom/text-hit-test.svg was failing

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Don't skip child renderers that have a height of 0 when looking for the closest child renderer, they may contain content that overflows.
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Fixed typos.
1:43 PM Changeset in webkit [15086] by hyatt
  • 3 edits in trunk/WebCore

Make the view source document properly handle <script>. We don't syntax
highlight the JS yet, but it shows up properly now.

Reviewed by john

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
1:32 PM Changeset in webkit [15085] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

JavaScriptGlue:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

  • WebKit.xcodeproj/project.pbxproj:
1:18 PM Changeset in webkit [15084] by justing
  • 4 edits in trunk/WebCore

Reviewed by levi


Fixed EditActions for InsertHorizontalRule and RemoveFormat.


  • editing/JSEditor.cpp:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::editingAction):
  • editing/ReplaceSelectionCommand.h:
1:09 PM Changeset in webkit [15083] by aliceli1
  • 1 edit in trunk/WebKitSite/projects/compat/hitlist.html

added google spreadsheets and yahoo mail beta, moved google calendar and yahoo preview to alumni list.

11:58 AM Changeset in webkit [15082] by lweintraub
  • 1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.h

Build Fix

11:36 AM Changeset in webkit [15081] by lweintraub
  • 2 edits in trunk/WebCore

Build Fix. Reviewed by NOBODY

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion):
11:17 AM Changeset in webkit [15080] by lweintraub
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by justin

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent

  • editing/execCommand/indent-list-item-expected.checksum: Added.
  • editing/execCommand/indent-list-item-expected.png: Added.
  • editing/execCommand/indent-list-item-expected.txt: Added.
  • editing/execCommand/indent-list-item.html: Added.
  • editing/execCommand/indent-selection-expected.checksum: Added.
  • editing/execCommand/indent-selection-expected.png: Added.
  • editing/execCommand/indent-selection-expected.txt: Added.
  • editing/execCommand/indent-selection.html: Added.
  • editing/execCommand/outdent-selection.html: Added.

WebCore:

Reviewed by justin

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent

  • WebCore.vcproj/WebCore/WebCore.vcproj: Added IndentOutdentCommand.h/cpp
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • editing/IndentOutdentCommand.cpp: Added. (WebCore::IndentOutdentCommand::IndentOutdentCommand): (WebCore::enclosingListOrBlockquote): (WebCore::IndentOutdentCommand::splitTreeToNode): Splits the DOM tree from a descendent node to an ending ancestor, duplicating nodes when necessary. Returns the last node split. Used to insert blockquotes at the topmost level. (WebCore::IndentOutdentCommand::indentRegion): (WebCore::IndentOutdentCommand::outdentParagraph): (WebCore::IndentOutdentCommand::outdentRegion): (WebCore::IndentOutdentCommand::doApply):
  • editing/IndentOutdentCommand.h: Added. (WebCore::IndentOutdentCommand::):
  • editing/JSEditor.cpp: Added the execCommands Indent and Outdent
  • editing/htmlediting.cpp: (WebCore::enclosingNodeWithTag): Finds the enclosing node with any specified tag. (WebCore::enclosingListChild): Added checks for nill and editable boundaries. (WebCore::outermostEnclosingListChild): Returns the highest ancestor list child. (WebCore::highestAncestor): Added. (WebCore::createElement): Changed the passed in string to a const reference.
  • editing/htmlediting.h:

WebKit:

Reviewed by justin

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent
Added undo action strings and enum values

  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):
8:42 AM Changeset in webkit [15079] by darin
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin and Hyatt.

  • fast/forms/button-generated-content-expected.checksum: Added.
  • fast/forms/button-generated-content-expected.png: Added.
  • fast/forms/button-generated-content-expected.txt: Added.
  • fast/forms/button-generated-content.html: Added.

WebCore:

Reviewed by Darin and Hyatt.

Test: fast/forms/button-generated-content.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updatePseudoChild): Added. Calls updatePseudoChildForObject() on the button itself or on its inner div, if it has one.
  • rendering/RenderButton.h: (WebCore::RenderButton::createsAnonymousWrapper): Added. Returns true.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::pseudoChild): Added. Returns the child containing generated content of the requested type if there is one, or otherwise the child before/after which such generated content should come. (WebCore::RenderContainer::updatePseudoChild): Removed the child parameter and moved the guts of this method into updatePseudoChildForObject, which this method calls unless the object is an anonymous wrapper. (WebCore::RenderContainer::updatePseudoChildForObject): Added. Does the what updatePseudoChildForObject did previously, but fetches the pseudo style from the styledObject parameter.
  • rendering/RenderContainer.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow):
  • rendering/RenderObject.h: (WebCore::RenderObject::createsAnonymousWrapper): Added. This method replaces allowsReusingAnonymousChild and returns the opposite of what that method used to return. Returns true if the object creates an anonymous child to contain all its other children.
7:39 AM Changeset in webkit [15078] by darin
  • 3 edits in trunk/LayoutTests

Reviewed by Darin.

Improved test to check offsetX/Y after dispatching instead of before.

  • fast/dom/window-xy-properties.html:
  • fast/dom/window-xy-properties-expected.txt:
12:18 AM Changeset in webkit [15077] by beidson
  • 10 edits
    1 add in trunk

WebCore:

Reviewed by Maciej

Hookup the new semi-functional SQLite icon database.
For now, it is living side-by-side with the old DB so one can compare the
two for debugging purposes. Also, it is disabled (in WebKit) by default unless you
compile with ICONDEBUG #defined.

  • WebCore.xcodeproj/project.pbxproj: Added file SiteIcon.cpp
  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
  • icon/IconDatabase.cpp: (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::createPrivateTables): (WebCore::IconDatabase::deletePrivateTables): (WebCore::IconDatabase::imageDataForIconID): (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::imageDataForPageURL): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::iconURLForURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL):
  • icon/IconDatabase.h: (WebCore::SiteIcon::getIconURL): (WebCore::IconDatabase::getPrivateBrowsingEnabled):


  • icon/SiteIcon.cpp: Added. (SiteIcon::SiteIcon): (SiteIcon::~SiteIcon): (SiteIcon::getImage): (SiteIcon::resetExpiration): (SiteIcon::getExpiration):

WebKit:

Reviewed by Maciej

Hookup the new semi-functional SQLite icon database.
For now, it is living side-by-side with the old DB so one can compare the
two for debugging purposes. Also, it is disabled (in WebKit) by default unless you
compile with ICONDEBUG #defined.
Note: To repeat that, if you want to try the new DB, #define ICONDEBUG (WebKitPrefix.h is a good place to do it)

  • Misc/WebIconDatabase.m: (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasIconForIconURL:]): (-[WebIconDatabase _resetCachedWebPreferences:]):
  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • WebKit.xcodeproj/project.pbxproj:
Note: See TracTimeline for information about the timeline view.