⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 4, 2006:

11:17 PM Changeset in webkit [15159] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

Bug 9731: [Drosera] crash when trying to access the scope chain
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9731

Because of <rdar://problem/4608404> the WebScriptObject, _globalObj, that
WebCoreScriptDebugger holds is unprotected each time the page changes.
This causes Drosera to crash Safari when trying to access the scope chain.
We simply need to detach and re-attach the debugger when the window script
object is cleared until 4608404 is fixed. This change also attaches the
debugger before we call the windowScriptObjectAvailable: delegate method,
so the debugger is ready before anyone might use the window object.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
9:52 PM Changeset in webkit [15158] by mjs
  • 67 edits in trunk

LayoutTests:

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9734

  • change SVG XPath DOM tests to dump as text, and update expected results


This should stop the random failures in Attribute_Nodes.svg

  • dom/svg/level3/xpath/Attribute_Nodes-expected.txt:
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns-expected.txt:
  • dom/svg/level3/xpath/Comment_Nodes-expected.txt:
  • dom/svg/level3/xpath/Conformance_Expressions-expected.txt:
  • dom/svg/level3/xpath/Conformance_hasFeature_3-expected.txt:
  • dom/svg/level3/xpath/Conformance_hasFeature_empty-expected.txt:
  • dom/svg/level3/xpath/Conformance_hasFeature_null-expected.txt:
  • dom/svg/level3/xpath/Conformance_isSupported_3-expected.txt:
  • dom/svg/level3/xpath/Conformance_isSupported_empty-expected.txt:
  • dom/svg/level3/xpath/Conformance_isSupported_null-expected.txt:
  • dom/svg/level3/xpath/Element_Nodes-expected.txt:
  • dom/svg/level3/xpath/Processing_Instruction_Nodes-expected.txt:
  • dom/svg/level3/xpath/Text_Nodes-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluatorCast01-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_document-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml-expected.txt:
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathResult_booleanValue_false-expected.txt:
  • dom/svg/level3/xpath/XPathResult_booleanValue_true-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_numberValue-expected.txt:
  • dom/svg/level3/xpath/XPathResult_resultType-expected.txt:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_stringValue-expected.txt:
  • dom/svg/level3/xpath/svgunit.js:

WebKitTools:

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9734

  • add support for dumping non-HTML as text - in this case use textContent instead of innerText
  • DumpRenderTree/DumpRenderTree.m: (dump):
9:34 PM Changeset in webkit [15157] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Bug 9732: [Drosera] calling removeListener to many times will cause

WebKit's listener count to underflow/wraparound

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9732

Adds a check to make sure the listener was in our listeners set before
decrementing the global listener count. Also checks for nil in addListner
to prevent a possible exception when adding the object to the set.

  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]):
9:25 PM Changeset in webkit [15156] by darin
  • 2 edits in trunk/JavaScriptCore
  • fixed build
  • wtf/MathExtras.h: Oops. Added missing #endif.
9:13 PM Changeset in webkit [15155] by darin
  • 7 edits in trunk/JavaScriptCore

Reviewed by Maciej.
Tweaked a bit by Darin.

  • wtf/MathExtras.h: Added include of <float.h>. (isinf): Fix to return false for NAN. (wtf_fmod): Added. An inline that works around the bug.
  • kjs/nodes.cpp:
  • kjs/number_object.cpp:
  • kjs/operations.cpp:
  • kjs/value.cpp: Added includes of MathExtras.h to all files using fmod.
  • JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode 2.3 have its way with the project.
9:04 PM Changeset in webkit [15154] by darin
  • 10 edits
    3 adds in trunk/WebCore

Reviewed by Maciej, reworked a bit by Darin.

Compile fixes for wx port / gcc 4.0.2


  • platform/PlatformString.h:
  • platform/StringImpl.h: Include CoreFoundation for CF-specific code.


  • dom/DocPtr.h:
  • doc/EventTargetNode.h: Silence warnings about 'extra tokens' after #endif on gcc 4.0.2. (Not an error but warnings appear frequently.)


  • WebCoreSources.bkl:
  • webcore-base.bkl: Synching ports sources file with TOT. Also, making sure SRCDIR variable overrides any previous values.


  • loader/ImageDocument.cpp: Use PLATFORM(MAC) for the parts that are specific to the Macintosh version, and move the Objective-C parts to another file.
  • loader/mac/ImageDocumentMac.h: Added.
  • loader/mac/ImageDocumentMac.mm: Added.
6:05 PM Changeset in webkit [15153] by darin
  • 2 edits in trunk/LayoutTests
  • updated test result to reflect window without scroll bars

1) this test should not have scroll bars
2) on the buildbot the result is the non-scroll-bar one

  • dom/svg/level3/xpath/Attribute_Nodes-expected.txt: Changed text node width to 800.
4:40 PM Changeset in webkit [15152] by weinig
  • 2 edits in trunk/WebCore

Build fix.

  • platform/Color.cpp: (WebCore::makeRGBAFromHSLA):
3:14 PM Changeset in webkit [15151] by weinig
  • 6 edits
    8 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/css/hsl-color-expected.checksum: Added.
  • fast/css/hsl-color-expected.png: Added.
  • fast/css/hsl-color-expected.txt: Added.
  • fast/css/hsl-color.html: Added.
  • fast/css/hsla-color-expected.checksum: Added.
  • fast/css/hsla-color-expected.png: Added.
  • fast/css/hsla-color-expected.txt: Added.
  • fast/css/hsla-color.html: Added.

WebCore:

Reviewed by Darin.


  • css/cssparser.cpp: (WebCore::CSSParser::parseColorParameters): Moved common code to parse RGB/RGBA values into it's own function. This code was duplicated in the parseColorFromValue() method. (WebCore::CSSParser::parseHSLParameters): Common code to parse HSL/HSLA values. (WebCore::CSSParser::parseColorFromValue): Moved RGB/RGBA parsing out to seperate function as the code was duplicated. Added parsing support for hsl( and hsla(
  • css/cssparser.h: Added two new functions parseColorParameters() and parseHSLParameters().
  • platform/Color.cpp: (WebCore::calcHue): Added Hue parameter to RGB color. (WebCore::makeRGBAFromHSLA): New function to convert HSLA to RGBA.
  • platform/Color.h: Added new functions makeRGBAFromHSLA() and calcHue().
9:45 AM Changeset in webkit [15150] by ap
  • 6 edits
    3 adds in trunk

Reviewed by Maciej.

Test: http/tests/xmlhttprequest/cache-override.html

  • Misc/WebNSURLRequestExtras.h: Added _web_isConditionalRequest
  • Misc/WebNSURLRequestExtras.m: (-[NSURLRequest _web_isConditionalRequest]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Bypass the cache for conditional requests.
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): Ditto.

Jul 3, 2006:

7:35 PM Changeset in webkit [15149] by ggaren
  • 13 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • Refined value conversions in the API:
    • failed toNumber returns NaN
    • failed toObject returns NULL
    • failed toString returns empty string


  • Refined excpetion handling in the API:
    • failed value conversions do not throw exceptions
    • uncaught exceptions in JSEvaluate, JSObjectCallAsFunction, and JSObjectCallAsConstructor are returned through a JSValueRef* exception argument
    • removed JSContextHasException, because JSContextGetException does the same job


  • API/JSBase.h:
  • API/JSCharBufferRef.cpp: (JSValueCopyStringValue):
  • API/JSContextRef.cpp: (JSEvaluate):
  • API/JSContextRef.h:
  • API/JSNodeList.c: Added test code demonstrating how you would use toNumber, and why you probably don't need toUInt32, etc. (JSNodeListPrototype_item): (JSNodeList_getProperty):
  • API/JSObjectRef.cpp: (JSValueToObject): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
  • API/JSObjectRef.h:
  • API/JSValueRef.cpp: (JSValueToNumber):
  • API/JSValueRef.h:
  • API/minidom.c: (main):
  • API/testapi.c: (main): Added tests for new rules, and call to JSGCProtect to fix Intel crash
  • JavaScriptCore.exp:
6:42 PM Changeset in webkit [15148] by darin
  • 2 edits in trunk/JavaScriptCore
  • Rolled out HashMap implementation of NPRuntime, at least temporarily.

Fixes hang in the bindings section of layout tests seen on the
buildbot.

This code was using HashMap<const char*, PrivateIdentifier*>.
But that hashes based on pointer identity, not string value.
The default hash for any pointer type is to hash based on the pointer.
And WTF doesn't currently have a string hash for char*.
We'll need to fix that before re-landing this patch.

(Formatting was also incorrect -- extra spaces in parentheses.)

  • bindings/npruntime.cpp: Rolled out last change.
11:46 AM Changeset in webkit [15147] by thatcher
  • 1 edit in trunk/WebKit/Misc/WebNSDataExtras.m

Build fix.

10:36 AM Changeset in webkit [15146] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed, tweaked, landed by ggaren.

  • Port NPRuntime from CFDictionary to HashMap.
  • bindings/npruntime.cpp: (getStringIdentifierDictionary): (getIntIdentifierDictionary): (_NPN_GetStringIdentifier): (_NPN_GetIntIdentifier):
  • bindings/npruntime.h:
1:27 AM Changeset in webkit [15145] by thatcher
  • 3 edits in trunk/WebKitTools/Drosera/English.lproj/MainMenu.nib

Forgot the NIB file change for step over and step out.

1:20 AM Changeset in webkit [15144] by thatcher
  • 7 edits
    1 add in trunk/WebKitTools

Reviewed by Eric.

Bug 9631: [Drosera] Add "Step Over" and "Step Out"
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9631


Adds step over and step out. Along with a little code cleanup
that was minor enough to piggyback on this fix.

  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument stepOver:]): (-[DebuggerDocument stepOut:]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[DebuggerDocument toolbarDefaultItemIdentifiers:]): (-[DebuggerDocument toolbarAllowedItemIdentifiers:]): (-[DebuggerDocument validateUserInterfaceItem:]):
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
  • Drosera/viewer.css:
1:03 AM Changeset in webkit [15143] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

Bug 9628: [Drosera] Split Views acting oddly
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9628


Only update the last X or Y coordinate if the new
size was not constrained. Also adds the resize cursor to
the body during the drag incase there is a constrained
over drag off of the resizer element.

  • Drosera/debugger.js:
12:42 AM Changeset in webkit [15142] by thatcher
  • 2 edits in tags/WebKit-521.14.2/WebKit

Build fix and versioning.

12:37 AM Changeset in webkit [15141] by thatcher
  • 1 copy in tags/WebKit-521.14.2

New tag.

Note: See TracTimeline for information about the timeline view.