⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 5, 2006:

11:39 PM Changeset in webkit [15181] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adele.


  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::createsAnonymousWrapper): This method replaces allowsReusingAnonymousChild() and has the opposite meaning.
11:35 PM Changeset in webkit [15180] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Maciej

Small fix that prevents an assertion from triggering if the DB is being cleaned up
(ie, the app being shut down)

  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary init]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _releaseIconForIconURLString:]):
11:19 PM Changeset in webkit [15179] by adele
  • 6 edits in trunk/WebCore

Build fixes.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcMinMaxWidth):
  • rendering/RenderPopupMenuWin.h: (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
  • rendering/RenderThemeWin.cpp:
10:55 PM Changeset in webkit [15178] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • fix 308 Node leaks on the editing layout tests
  • dom/Document.cpp: (WebCore::Document::removedLastRef): Clear the markers once there are no real refs on the document, otherwise a self-only reference cycle w/ the document can occur.
10:47 PM Changeset in webkit [15177] by adele
  • 28 edits
    7 adds in trunk

WebCore:

Reviewed by Maciej and Hyatt.

Initial implementation of popup menu control. This can be turned on by setting -webkit-appearance: menulist on a select element.

  • WebCore.xcodeproj/project.pbxproj: Added RenderMenuList.h, RenderMenuList.cpp, RenderPopupMenu.h, RenderPopupMenu.cpp, RenderPopupMenuWin.h, RenderPopupMenuMac.h, RenderPopupMenuMac.mm,


  • dom/Node.cpp: (WebCore::Node::renderStyle): Added. Returns the renderer's style. If there's no renderer, returns's a RenderStyle that's kept by the node. This is important for HTMLOptGroupElement and HTMLOptionElement, which don't have renderers. (WebCore::Node::setRenderStyle): Added.
  • dom/Node.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle): Updated to use renderStyle so recalcStyle will work for HTMLOptionElements and HTMLOptGroupElements.


  • css/cssstyleselector.cpp: Updated to call renderStyle method on the node, so resolving style works on elements w/o renderers that cache style. (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::checkOneSelector):
  • css/html4.css: Removed display:none from options and optgroups, since we're now caching style for these elements. Added font-weight styles for option and optgroup.


  • html/HTMLOptGroupElement.h: Added m_style to keep track of a RenderStyle for the element, even though we aren't creating a renderer. This will allow us to honor style for optgroups and options for popup menus (and eventually list boxes too). (WebCore::HTMLOptGroupElement::rendererIsNeeded): Added. (WebCore::HTMLOptGroupElement::renderStyle): Added.
  • html/HTMLOptionElement.h: ditto. (WebCore::HTMLOptionElement::rendererIsNeeded): Added. (WebCore::HTMLOptionElement::renderStyle): Added.


  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::HTMLOptGroupElement): Initialize m_style. (WebCore::HTMLOptGroupElement::attach): Set the renderStyle. (WebCore::HTMLOptGroupElement::detach): Clear m_style. (WebCore::HTMLOptGroupElement::setRenderStyle): Added. (WebCore::HTMLOptGroupElement::groupLabelText): Added.
  • html/HTMLOptionElement.cpp: ditto. (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::attach): (WebCore::HTMLOptionElement::detach): (WebCore::HTMLOptionElement::setRenderStyle): (WebCore::HTMLOptionElement::optionText):
  • html/HTMLSelectElement.cpp: Added code to use the new RenderMenuList if the appearance is set to MenuListAppearance, and if we're not creating a list box renderer. (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler):
  • html/HTMLSelectElement.h:
  • WebCore.exp: Added _wkPopupMenu.
  • platform/mac/WebCoreSystemInterface.h: Added wkPopupMenu to get the NSMenu to pop up.
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/win/TemporaryLinkStubs.cpp: Added stubs for RenderPopupMenuWin. (RenderPopupMenuWin::RenderPopupMenuWin): (RenderPopupMenuWin::~RenderPopupMenuWin): (RenderPopupMenuWin::clear): (RenderPopupMenuWin::populate): (RenderPopupMenuWin::showPopup): (RenderPopupMenuWin::addSeparator): (RenderPopupMenuWin::addGroupLabel): (RenderPopupMenuWin::addOption):
  • rendering/RenderPopupMenuWin.h: Added.
  • rendering/RenderPopupMenu.cpp: Added. (WebCore::RenderPopupMenu::RenderPopupMenu): (WebCore::RenderPopupMenu::~RenderPopupMenu): (WebCore::RenderPopupMenu::clear): (WebCore::RenderPopupMenu::populate): Walks the DOM tree, and adds separators, options, and group labels to the RenderPopupMenu. (WebCore::RenderPopupMenu::showPopup): (WebCore::RenderPopupMenu::addSeparator): (WebCore::RenderPopupMenu::addGroupLabel): (WebCore::RenderPopupMenu::addOption):
  • rendering/RenderPopupMenu.h: Added. (WebCore::RenderPopupMenu::renderName): (WebCore::RenderPopupMenu::getRenderMenuList):
  • rendering/RenderPopupMenuMac.h: Added.
  • rendering/RenderPopupMenuMac.mm: Added. (WebCore::RenderPopupMenuMac::RenderPopupMenuMac): (WebCore::RenderPopupMenuMac::~RenderPopupMenuMac): (WebCore::RenderPopupMenuMac::clear): Removes all items from the menu. (WebCore::RenderPopupMenuMac::populate): Disables menuChangedMessages before populating the menu. (WebCore::RenderPopupMenuMac::showPopup): Calculates the right position, and calls wkPopupMenu. (WebCore::RenderPopupMenuMac::addSeparator): (WebCore::RenderPopupMenuMac::addGroupLabel): (WebCore::RenderPopupMenuMac::addOption):


  • rendering/RenderMenuList.cpp: Added. (WebCore::RenderMenuList::RenderMenuList): (WebCore::RenderMenuList::addChild): (WebCore::RenderMenuList::removeChild): (WebCore::RenderMenuList::setStyle): (WebCore::RenderMenuList::updateFromElement): If the options have changed, iterate through the children to find the menu item with the widest text. Set the button text to the selected item's text. (WebCore::RenderMenuList::setText): (WebCore::RenderMenuList::paintObject): (WebCore::RenderMenuList::baselinePosition): (WebCore::RenderMenuList::calcMinMaxWidth): (WebCore::RenderMenuList::showPopup): (WebCore::RenderMenuList::layout): (WebCore::RenderMenuList::updateSelection): (WebCore::RenderMenuList::valueChanged):
  • rendering/RenderMenuList.h: Added. (WebCore::RenderMenuList::removeLeftoverAnonymousBoxes): (WebCore::RenderMenuList::allowsReusingAnonymousChild): (WebCore::RenderMenuList::canHaveChildren): (WebCore::RenderMenuList::renderName): (WebCore::RenderMenuList::setOptionsChanged): (WebCore::RenderMenuList::selectionChanged): (WebCore::RenderMenuList::setSelectionChanged): (WebCore::RenderMenuList::hasPopupMenu):
  • rendering/RenderTheme.cpp: Added cases for MenuListAppearance. (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::adjustMenuListStyle): (WebCore::RenderTheme::createPopupMenu): creates platform-specific RenderPopupMenu.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::sizeOfArrowControl): Added. (WebCore::RenderTheme::paintMenuList): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::setPopupButtonCellState): (WebCore::RenderThemeMac::createPopupMenu): (WebCore::RenderThemeMac::sizeOfArrowControl):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::createPopupMenu):
  • rendering/RenderThemeWin.h:

WebKit:

Reviewed by Maciej and Hyatt.

WebKit part of initial popup menu implementation.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize WKPopupMenu.

WebKitLibraries:

Reviewed by Maciej and Hyatt.

  • WebKitSystemInterface.h: Updated.
  • libWebKitSystemInterface.a: Updated.
7:57 PM Changeset in webkit [15176] by aliceli1
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4600166> REGRESSION: Safari crash while loading web pages ( ​http://www.yahoo.com/ )

2005-10-16 David Hyatt <​hyatt@apple.com>

Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.


Reviewed by bdakin

  • khtml/rendering/render_container.cpp: (RenderContainer::detach): this was renamed on the branch, from RenderContainer::destroy (RenderContainer::detachLeftoverChildren): this was renamed on the branch, from RenderContainer::destroyLeftoverChildren
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::detach): this was renamed on the branch, from RenderContainer::destroy
4:45 PM Changeset in webkit [15175] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Tim Omernick.

IconDatabase now respects private browsing via the use of in memory, temporary tables

  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): Renamed WebCore::IconDatabase methods, changes reflected here
  • icon/IconDatabase.cpp: (WebCore::IconDatabase::clearDatabase): (WebCore::IconDatabase::deletePrivateTables): (WebCore::IconDatabase::imageDataForIconID): (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::imageDataForPageURL): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::iconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::performSetIconDataForIconID): (WebCore::IconDatabase::establishTemporaryIconIDForEscapedIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::performSetIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL): -Some style/comment cleanups, but mainly putting private browsing handling in place
  • icon/IconDatabase.h: Some methods added, others renamed, some comments added
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): -The above 4 had changes to return String() for empty results instead of "" as it's less expensive;
4:30 PM Changeset in webkit [15174] by sullivan
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Adele.


  • layout test for <rdar://problem/4609162> REGRESSION: When tabbing between links on a page, the window doesn't scroll to link that's not in view


The test verifies that focusing a link will scroll the link into view.

  • fast/events/reveal-link-when-focused-expected.checksum: Added.
  • fast/events/reveal-link-when-focused-expected.png: Added.
  • fast/events/reveal-link-when-focused-expected.txt: Added.
  • fast/events/reveal-link-when-focused.html: Added.
4:27 PM Changeset in webkit [15173] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Darin and Adele.


  • fixed <rdar://problem/4609162> REGRESSION: When tabbing between links on a page, the window doesn't scroll to link that's not in view
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAnchorElement.h: removed HTMLAnchorElement::focus and HTMLAnchorElement::blur.


HTMLAnchorElement::focus just called document()->setFocusNode(). The scroll-to-reveal
code used to be inside document()->setFocusNode(), but now it's in Element::focus, and this override
was preventing that code from running.


HTMLAnchorElement::blur was exactly the same implementation as Element::blur (and there aren't any
other implementations of ::blur in the class hierarchy in between). This change has no practical
effect, other than removing duplicate code.


Adele and I think that it was an oversight not to remove these two methods on 12/20/05
these methods were removed from HTMLButtonElementImpl and HTMLInputElementImpl.

3:24 PM Changeset in webkit [15172] by andersca
  • 4 edits in trunk/WebCore

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::createFrame): Fix Win32 build.
2:37 PM Changeset in webkit [15171] by andersca
  • 2 edits in trunk/WebCore

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

  • WebCore.xcodeproj/project.pbxproj: Revert accidental change of debug format to DWARF.
2:29 PM Changeset in webkit [15170] by andersca
  • 24 edits
    5 adds in trunk

WebCore:

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::createFrame):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge installInFrame:]): Modify to pass the owner element instead of the owner renderer.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): Dispatch the node inserted events before attaching the nodes. This is what the tokenizer does.


  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach): Pass the element to requestFrame.


(WebCore::HTMLFrameElement::setLocation):
Don't call attach/detach on an iframe.

  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::insertedIntoDocument): Load the frame here (using openURL).


(WebCore::HTMLIFrameElement::removedFromDocument):
Call frameDetached.


(WebCore::HTMLIFrameElement::attach):
If there's a renderer, attach the content frame to it.


(WebCore::HTMLIFrameElement::detach):
Reset the renderer's frame.


(WebCore::HTMLIFrameElement::openURL):
Modify to request the frame.


  • html/HTMLIFrameElement.h: Add detach.


  • page/Frame.cpp: (WebCore::parentFromOwnerElement): (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::loadSubframe): (WebCore::Frame::ownerElement): (WebCore::Frame::ownerRenderer): (WebCore::Frame::disconnectOwnerElement):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::setFrame): Modify to keep an owner element around instead of the renderer.


  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Don't do anything for iframes.

WebKit:

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]): Modify to pass the owner element instead of the owner renderer.


  • WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]): Remove assertion, it's not valid anymore.

LayoutTests:

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array

  • fast/events/mouseover-mouseout2-expected.txt:
  • fast/events/mouseover-mouseout2.html: Update expected result. Since we now keep the frame around, the mouseout event is now dispatched to the element in the frame.
  • fast/events/onloadFrameCrash-expected.checksum:
  • fast/events/onloadFrameCrash-expected.png:
  • fast/events/onloadFrameCrash-expected.txt: This does hide the frame now.


  • fast/frames/iframe-display-none-expected.txt: Added.
  • fast/frames/iframe-display-none.html: Added.
  • fast/frames/resources/iframe-display-none-child.html: Added. New test that tests JS interaction with frames.


  • fast/frames/iframe-double-attach-expected.txt: Added.
  • fast/frames/iframe-double-attach.html: Added.
1:05 PM Changeset in webkit [15169] by thatcher
  • 2 edits
    1 add in trunk/WebKit

Reviewed by Harrison.

<rdar://problem/4608423> HIViewAdapter used but not defined
Adds a new export file to fix the build.

  • WebKit.LP64.exp: Added.
  • WebKit.xcodeproj/project.pbxproj:
12:10 PM Changeset in webkit [15168] by ggaren
  • 16 edits
    2 moves in trunk/JavaScriptCore

RS by Beth.


Renamed JSCharBufferRef, which was universally unpopular, to JSStringBufferRef,
which, hopefully, will be less unpopular.

  • API/APICast.h: (toJS): (toRef):
  • API/JSBase.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
  • API/JSCharBufferRef.cpp: Removed.
  • API/JSCharBufferRef.h: Removed.
  • API/JSContextRef.cpp: (JSEvaluate): (JSCheckSyntax):
  • API/JSContextRef.h:
  • API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild):
  • API/JSNodeList.c: (JSNodeList_length): (JSNodeList_getProperty):
  • API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectGetDescription): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSPropertyEnumeratorGetNext): (JSPropertyListAdd):
  • API/JSObjectRef.h:
  • API/JSStringBufferRef.cpp: Added. (JSStringMake): (JSStringBufferCreate): (JSStringBufferCreateUTF8): (JSStringBufferRetain): (JSStringBufferRelease): (JSValueCopyStringValue): (JSStringBufferGetLength): (JSStringBufferGetCharactersPtr): (JSStringBufferGetCharacters): (JSStringBufferGetMaxLengthUTF8): (JSStringBufferGetCharactersUTF8): (JSStringBufferIsEqual): (JSStringBufferIsEqualUTF8): (JSStringBufferCreateWithCFString): (CFStringCreateWithJSStringBuffer):
  • API/JSStringBufferRef.h: Added.
  • API/JSValueRef.h:
  • API/JavaScriptCore.h:
  • API/minidom.c: (main): (print):
  • API/testapi.c: (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
11:54 AM Changeset in webkit [15167] by thatcher
  • 3 edits in tags/WebKit-521.14.3/WebKit

Build fixes and versioning.

11:35 AM Changeset in webkit [15166] by thatcher
  • 1 copy in tags/WebKit-521.14.3

New tag.

11:07 AM Changeset in webkit [15165] by ggaren
  • 6 edits in trunk/JavaScriptCore

RS by Beth.


Moved some code around for more logical file separation.

  • API/JSBase.h:
  • API/JSContextRef.h:
  • API/JSObjectRef.cpp:
  • API/JSValueRef.cpp: (JSValueToObject):
  • API/JSValueRef.h:
10:46 AM Changeset in webkit [15164] by ggaren
  • 6 edits in trunk/JavaScriptCore

Reviewed by Maciej.


Implemented JSFunctionMakeWithBody, which parses a script as a function body
in the global scope, and returns the resulting anonymous function.


I also removed private data from JSCallbackFunction. It never worked,
since JSCallbackFunction doesn't inherit from JSCallbackObject.

  • API/JSCallbackConstructor.cpp: Removed.
  • API/JSCallbackConstructor.h: Removed.
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction): (KJS::JSCallbackFunction::implementsConstruct): (KJS::JSCallbackFunction::construct): (KJS::JSCallbackFunction::implementsCall): (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSFunctionMake): (JSFunctionMakeWithCallbacks):
  • API/JSObjectRef.h:
  • API/JSValueRef.h:
  • API/minidom.c: (main):
  • API/testapi.c: (main):
  • JavaScriptCore.exp: Programmatically added all symbols exported by API object files, and sorted results
  • JavaScriptCore.xcodeproj/project.pbxproj:
9:52 AM Changeset in webkit [15163] by ggaren
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • Return syntax error in JSCheckSyntax through a JSValueRef* exception argument


  • API/JSBase.h:
  • API/JSContextRef.cpp: (JSCheckSyntax):
  • API/testapi.c: (main):
  • JavaScriptCore.exp:
  • kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax):
  • kjs/interpreter.h:

JavaScriptGlue:

Reviewed by Maciej.


  • JSRun.cpp: (JSRun::CheckSyntax): Updated to use new checkSyntax syntax in JSC.
  • JavaScriptGlue.xcodeproj/project.pbxproj:
9:35 AM Changeset in webkit [15162] by thatcher
  • 1 edit in trunk/WebKit/Carbon/CarbonWindowAdapter.m

Build fix.

9:35 AM Changeset in webkit [15161] by thatcher
  • 1 edit in trunk/WebKit/Carbon/CarbonWindowAdapter.m

Build fix to work with the new linker.

9:27 AM Changeset in webkit [15160] by thatcher
  • 1 edit in trunk/WebKit/Misc/WebNSDataExtras.m

Fixes backwards if statement logic.

Jul 4, 2006:

11:17 PM Changeset in webkit [15159] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

Bug 9731: [Drosera] crash when trying to access the scope chain
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9731

Because of <rdar://problem/4608404> the WebScriptObject, _globalObj, that
WebCoreScriptDebugger holds is unprotected each time the page changes.
This causes Drosera to crash Safari when trying to access the scope chain.
We simply need to detach and re-attach the debugger when the window script
object is cleared until 4608404 is fixed. This change also attaches the
debugger before we call the windowScriptObjectAvailable: delegate method,
so the debugger is ready before anyone might use the window object.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
9:52 PM Changeset in webkit [15158] by mjs
  • 67 edits in trunk

LayoutTests:

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9734

  • change SVG XPath DOM tests to dump as text, and update expected results


This should stop the random failures in Attribute_Nodes.svg

  • dom/svg/level3/xpath/Attribute_Nodes-expected.txt:
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns-expected.txt:
  • dom/svg/level3/xpath/Comment_Nodes-expected.txt:
  • dom/svg/level3/xpath/Conformance_Expressions-expected.txt:
  • dom/svg/level3/xpath/Conformance_hasFeature_3-expected.txt:
  • dom/svg/level3/xpath/Conformance_hasFeature_empty-expected.txt:
  • dom/svg/level3/xpath/Conformance_hasFeature_null-expected.txt:
  • dom/svg/level3/xpath/Conformance_isSupported_3-expected.txt:
  • dom/svg/level3/xpath/Conformance_isSupported_empty-expected.txt:
  • dom/svg/level3/xpath/Conformance_isSupported_null-expected.txt:
  • dom/svg/level3/xpath/Element_Nodes-expected.txt:
  • dom/svg/level3/xpath/Processing_Instruction_Nodes-expected.txt:
  • dom/svg/level3/xpath/Text_Nodes-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluatorCast01-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document-expected.txt:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_document-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml-expected.txt:
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathResult_booleanValue_false-expected.txt:
  • dom/svg/level3/xpath/XPathResult_booleanValue_true-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_numberValue-expected.txt:
  • dom/svg/level3/xpath/XPathResult_resultType-expected.txt:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_stringValue-expected.txt:
  • dom/svg/level3/xpath/svgunit.js:

WebKitTools:

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9734

  • add support for dumping non-HTML as text - in this case use textContent instead of innerText
  • DumpRenderTree/DumpRenderTree.m: (dump):
9:34 PM Changeset in webkit [15157] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Bug 9732: [Drosera] calling removeListener to many times will cause

WebKit's listener count to underflow/wraparound

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9732

Adds a check to make sure the listener was in our listeners set before
decrementing the global listener count. Also checks for nil in addListner
to prevent a possible exception when adding the object to the set.

  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]):
9:25 PM Changeset in webkit [15156] by darin
  • 2 edits in trunk/JavaScriptCore
  • fixed build
  • wtf/MathExtras.h: Oops. Added missing #endif.
9:13 PM Changeset in webkit [15155] by darin
  • 7 edits in trunk/JavaScriptCore

Reviewed by Maciej.
Tweaked a bit by Darin.

  • wtf/MathExtras.h: Added include of <float.h>. (isinf): Fix to return false for NAN. (wtf_fmod): Added. An inline that works around the bug.
  • kjs/nodes.cpp:
  • kjs/number_object.cpp:
  • kjs/operations.cpp:
  • kjs/value.cpp: Added includes of MathExtras.h to all files using fmod.
  • JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode 2.3 have its way with the project.
9:04 PM Changeset in webkit [15154] by darin
  • 10 edits
    3 adds in trunk/WebCore

Reviewed by Maciej, reworked a bit by Darin.

Compile fixes for wx port / gcc 4.0.2


  • platform/PlatformString.h:
  • platform/StringImpl.h: Include CoreFoundation for CF-specific code.


  • dom/DocPtr.h:
  • doc/EventTargetNode.h: Silence warnings about 'extra tokens' after #endif on gcc 4.0.2. (Not an error but warnings appear frequently.)


  • WebCoreSources.bkl:
  • webcore-base.bkl: Synching ports sources file with TOT. Also, making sure SRCDIR variable overrides any previous values.


  • loader/ImageDocument.cpp: Use PLATFORM(MAC) for the parts that are specific to the Macintosh version, and move the Objective-C parts to another file.
  • loader/mac/ImageDocumentMac.h: Added.
  • loader/mac/ImageDocumentMac.mm: Added.
6:05 PM Changeset in webkit [15153] by darin
  • 2 edits in trunk/LayoutTests
  • updated test result to reflect window without scroll bars

1) this test should not have scroll bars
2) on the buildbot the result is the non-scroll-bar one

  • dom/svg/level3/xpath/Attribute_Nodes-expected.txt: Changed text node width to 800.
4:40 PM Changeset in webkit [15152] by weinig
  • 2 edits in trunk/WebCore

Build fix.

  • platform/Color.cpp: (WebCore::makeRGBAFromHSLA):
3:14 PM Changeset in webkit [15151] by weinig
  • 6 edits
    8 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/css/hsl-color-expected.checksum: Added.
  • fast/css/hsl-color-expected.png: Added.
  • fast/css/hsl-color-expected.txt: Added.
  • fast/css/hsl-color.html: Added.
  • fast/css/hsla-color-expected.checksum: Added.
  • fast/css/hsla-color-expected.png: Added.
  • fast/css/hsla-color-expected.txt: Added.
  • fast/css/hsla-color.html: Added.

WebCore:

Reviewed by Darin.


  • css/cssparser.cpp: (WebCore::CSSParser::parseColorParameters): Moved common code to parse RGB/RGBA values into it's own function. This code was duplicated in the parseColorFromValue() method. (WebCore::CSSParser::parseHSLParameters): Common code to parse HSL/HSLA values. (WebCore::CSSParser::parseColorFromValue): Moved RGB/RGBA parsing out to seperate function as the code was duplicated. Added parsing support for hsl( and hsla(
  • css/cssparser.h: Added two new functions parseColorParameters() and parseHSLParameters().
  • platform/Color.cpp: (WebCore::calcHue): Added Hue parameter to RGB color. (WebCore::makeRGBAFromHSLA): New function to convert HSLA to RGBA.
  • platform/Color.h: Added new functions makeRGBAFromHSLA() and calcHue().
9:45 AM Changeset in webkit [15150] by ap
  • 6 edits
    3 adds in trunk

Reviewed by Maciej.

Test: http/tests/xmlhttprequest/cache-override.html

  • Misc/WebNSURLRequestExtras.h: Added _web_isConditionalRequest
  • Misc/WebNSURLRequestExtras.m: (-[NSURLRequest _web_isConditionalRequest]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Bypass the cache for conditional requests.
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): Ditto.
Note: See TracTimeline for information about the timeline view.