Context Navigation

← Previous Period
Next Period →

Timeline

Jul 6, 2006:

9:48 PM Changeset in webkit [15197] by mjs

3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

fix 26 Node leaks on fast/dom tests

dom/Document.cpp: (WebCore::Document::removedLastRef): delete tokenizer - if we are still parsing at this point, we don't want nodes held by the parser to keep the document alive.
html/HTMLParser.cpp: (WebCore::RefNonDocNodePtr::RefNonDocNodePtr): Smart pointer that acts like RefPtr for Node, but avoids refing document nodes to avoid cycles. (WebCore::RefNonDocNodePtr::~RefNonDocNodePtr): (WebCore::RefNonDocNodePtr::get): (WebCore::RefNonDocNodePtr::operator*): (WebCore::RefNonDocNodePtr::operator->): (WebCore::RefNonDocNodePtr::operator!): (WebCore::RefNonDocNodePtr::operator UnspecifiedBoolType): (WebCore::RefNonDocNodePtr::operator=): (WebCore::operator==): (WebCore::operator!=): (WebCore::HTMLStackElem): Use a RefNonDocNodePtr instead of RefPtr<Node> (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Use a RefPtr here to avoid crashing

7:29 PM Changeset in webkit [15196] by adele

6 edits in trunk/WebCore

Reviewed by Maciej.

Fixed new popup control to open up when the spacebar and the up and down arrows are pressed.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9762 [Native pop up] Highlighted item text is black instead of white

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::isKeyboardFocusable): Added. (WebCore::HTMLSelectElement::isMouseFocusable): Added. (WebCore::HTMLSelectElement::defaultEventHandler): Updated to showPopup for up and down arrow keys and spacebar.
html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Made this const.
rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Added FIXME.
rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::showPopup): Updated to save the NSEvent that triggers the popup, so we can send fake mouseUp and keyUp events when the NSMenu returns. (WebCore::RenderPopupMenuMac::addGroupLabel): Only set the NSForegroundColorAttributeName attribute if the text isn't black. Follow-up bug about other colors: http://bugzilla.opendarwin.org/show_bug.cgi?id=9769 (WebCore::RenderPopupMenuMac::addOption): ditto.
bridge/mac/FrameMac.h: (WebCore::FrameMac::currentEvent): Returns the current NSEvent.

7:13 PM Changeset in webkit [15195] by justing

7 edits
8 adds in trunk

LayoutTests:

Reviewed by levi

<rdar://problem/4609184>
Mail crashes at WebCore::Selection::adjustForEditableContent
<rdar://problem/4609140>
Crash at WebCore::Range::compareBoundaryPoints

editing/selection/mixed-editability-1-expected.checksum: Added.
editing/selection/mixed-editability-1-expected.png: Added.
editing/selection/mixed-editability-1-expected.txt: Added.
editing/selection/mixed-editability-1.html: Added.
editing/selection/mixed-editability-2-expected.checksum: Added.
editing/selection/mixed-editability-2-expected.png: Added.
editing/selection/mixed-editability-2-expected.txt: Added.
editing/selection/mixed-editability-2.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4609184>
Mail crashes at WebCore::Selection::adjustForEditableContent
<rdar://problem/4609140>
Crash at WebCore::Range::compareBoundaryPoints

editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Moved code into a helper function. (WebCore::VisiblePosition::previous): Ditto.
editing/htmlediting.cpp: (WebCore::comparePositions): Moved from Selection.cpp. (WebCore::lowestEditableAncestor): Added. Returns rootEditableElement for a node in editable content and the rootEditableElement for the first ancestor that's editable for a node in non-editable content. (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot):
editing/htmlediting.h:

6:00 PM Changeset in webkit [15194] by andersca

6 edits
2 adds in trunk

WebCore:

2006-07-06 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adele.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9528
REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes

Patch by Darin, tweaked by Anders.

html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): Convert newline characters to <br> elements. I've verified that what's done here is what WinIE does when setting innerText.

(WebCore::HTMLElement::setOuterText):
Fix comment.

rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks): Remove assert. m_div->firstChild() can be null now because setInnerText doesn't create text nodes for empty strings anymore.

LayoutTests:

2006-07-06 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adele.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9528
REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes

fast/dom/css-selectorText-expected.txt:
fast/dom/css-shortHands-expected.txt: Update tests.

fast/dom/set-inner-text-newlines-expected.txt: Added.
fast/dom/set-inner-text-newlines.html: Added.

5:22 PM Changeset in webkit [15193] by adele

3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with 10.4.6 too)

page/FrameView.cpp: (WebCore::FrameView::layout): Ref's the view during layout, since a recalcStyle could cause the view to be deleted. If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exit layout.
page/FrameView.h: (WebCore::FrameView::hasOneRef): Added.

5:12 PM Changeset in webkit [15192] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with 10.4.6 too)

khtml/khtmlview.cpp: (KHTMLView::layout): Ref's the view during layout, since a recalcStyle could cause the view to be deleted. If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exit layout.
khtml/khtmlview.h: (KHTMLView::hasOneRef): Added.

4:11 PM Changeset in webkit [15191] by andersca

14 edits
5 adds in trunk

WebCore:

2006-07-06 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4610891> Support overflow events

DerivedSources.make: Add generated sources.

WebCore.xcodeproj/project.pbxproj: Add new files.

bindings/js/kjs_events.cpp: (KJS::toJS): Support creating wrappers for overflow events..

bindings/objc/DOMEvents.h:
bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:]): (-[DOMOverflowEvent _overflowEvent]): (-[DOMOverflowEvent orient]): (-[DOMOverflowEvent horizontalOverflow]): (-[DOMOverflowEvent verticalOverflow]): Add Objective-C wrapper for overflow events.

dom/Event.cpp: (WebCore::Event::isOverflowEvent):
dom/Event.h:
dom/EventNames.h:
dom/OverflowEvent.cpp: Added. (WebCore::OverflowEvent::OverflowEvent): (WebCore::OverflowEvent::isOverflowEvent):
dom/OverflowEvent.h: Added. (WebCore::OverflowEvent::): (WebCore::OverflowEvent::orient): (WebCore::OverflowEvent::horizontalOverflow): (WebCore::OverflowEvent::verticalOverflow):
dom/OverflowEvent.idl: Added. Add overflow events.

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout): Dispatch any scheduled events when layout is done.

(WebCore::FrameView::scheduleEvent):
New function which schedules an event.

(WebCore::FrameView::updateOverflowStatus):
Update overflow status for the viewport.

(WebCore::FrameView::dispatchScheduledEvents):
New function which dispatches all scheduled events.

page/FrameView.h: Add declarations.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
rendering/RenderLayer.h: Schedule overflow events when overflow status changes.

LayoutTests:

2006-07-06 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4610891> Support overflow events

fast/events/overflow-events-expected.txt: Added.
fast/events/overflow-events.html: Added.

3:47 PM Changeset in webkit [15190] by thatcher

3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4610881> Expose scroll-related JS properties to ObjC DOM interface
<rdar://problem/4519675> offsetLeft, offsetTop, offsetHeight, and offsetWidth
properties are not exposed to ObjC

bindings/objc/DOMPrivate.h:
bindings/objc/DOMHTML.mm: (-[DOMHTMLElement offsetLeft]): (-[DOMHTMLElement offsetTop]): (-[DOMHTMLElement offsetWidth]): (-[DOMHTMLElement offsetHeight]): (-[DOMHTMLElement offsetParent]): (-[DOMHTMLElement clientWidth]): (-[DOMHTMLElement clientHeight]): (-[DOMHTMLElement scrollLeft]): (-[DOMHTMLElement setScrollLeft:]): (-[DOMHTMLElement scrollTop]): (-[DOMHTMLElement setScrollTop:]): (-[DOMHTMLElement scrollWidth]): (-[DOMHTMLElement scrollHeight]):

3:45 PM Changeset in webkit [15189] by brmorris

3 edits in S60/trunk

S60WebKit:

2006-07-06 brmorris <bradley.morrison@nokia.com>

Reviewed by dacarson. Fix for:

http://bugzilla.opendarwin.org/show_bug.cgi?id=9754

S60Tools/patch.exe: Updated to version 2.5.
S60Tools/prepare-ChangeLog.bat: Force forwardslashes.

3:30 PM Changeset in webkit [15188] by brmorris

1 edit
5 adds in S60/trunk

S60WebKit:

2006-07-06 brmorris <bradley.morrison@nokia.com>

Reviewed by dacarson.

S60Tools\patch.exe: Added.
S60Tools\prepare-ChangeLog.bat: Added.
S60Tools\svn-apply.bat: Added.
S60Tools\svn-create-patch.bat: Added.
S60Tools\svn-unapply.bat: Added.

2:41 PM Changeset in webkit [15187] by mjs

2 edits in trunk/WebCore

Reviewed by Adele.

fix 435 more layout tests Node leaks

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): fix more instances of leaked DOM ranges

11:39 AM Changeset in webkit [15186] by beidson

2 edits in trunk/WebKit

Reviewed by John.

Small fix to my previous small fix that only lets the ASSERT off the hook if the DB
is closing

Misc/WebIconDatabase.m: (-[WebIconDatabase _releaseIconForIconURLString:]):

9:45 AM Changeset in webkit [15185] by harrison

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/4565031> innerHTML of XMP tag returns special characters like '>' instead of '>'

fast/innerHTML/006-expected.checksum: Added.
fast/innerHTML/006-expected.png: Added.
fast/innerHTML/006-expected.txt: Added.
fast/innerHTML/006.html: Added.

WebCore:

Reviewed by Geoff

<rdar://problem/4565031> innerHTML of XMP tag returns special characters like '>' instead of '>'

Test: fast/innerHTML/006.html

editing/markup.cpp: (WebCore::startMarkup): (WebCore::createMarkup): Do not special quote content of XMP nodes.

4:37 AM Changeset in webkit [15184] by mjs

3 edits in trunk/WebCore

Not reviewed - build fix.

back out earlier leak fix, as it caused a crash on one of the fast/invalid layout tests

dom/Document.cpp: (WebCore::Document::removedLastRef):
html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLParser::popNestedHeaderTag): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags): (WebCore::HTMLParser::popBlock): (WebCore::HTMLParser::popOneBlock):

2:50 AM Changeset in webkit [15183] by mjs

2 edits in trunk/WebCore

Reviewed by Anders.

fix ~3000 Node leaks on the editing tests

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): put a newly created Range in a RefPtr to avoid leaking it, as this leaks the whole document.

2:39 AM Changeset in webkit [15182] by mjs

3 edits in trunk/WebCore

Reviewed by Anders.

fix 26 Node leaks on various fast/dom tests

dom/Document.cpp: (WebCore::Document::removedLastRef): Delete the tokenizer here, since if we are in mid-parse, the parser might hold refs on some of our children that have self-only refs.
html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): don't ref the node if it is a document to avoid ref cycles (WebCore::HTMLStackElem::~HTMLStackElem): ditto (WebCore::HTMLStackElem::node): changed interface a bit to support the above (WebCore::HTMLStackElem::setNode): ditto (WebCore::HTMLParser::popNestedHeaderTag): use new interface to HTMLStackElem (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): ditto (WebCore::HTMLParser::reopenResidualStyleTags): ditto (WebCore::HTMLParser::popBlock): ditto (WebCore::HTMLParser::popOneBlock): ditto

Jul 5, 2006:

11:39 PM Changeset in webkit [15181] by adele

2 edits in trunk/WebCore

Reviewed by Adele.

rendering/RenderMenuList.h: (WebCore::RenderMenuList::createsAnonymousWrapper): This method replaces allowsReusingAnonymousChild() and has the opposite meaning.

11:35 PM Changeset in webkit [15180] by beidson

3 edits in trunk/WebKit

Reviewed by Maciej

Small fix that prevents an assertion from triggering if the DB is being cleaned up
(ie, the app being shut down)

Misc/WebIconDatabase.h:
Misc/WebIconDatabase.m: (-[NSMutableDictionary init]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _releaseIconForIconURLString:]):

11:19 PM Changeset in webkit [15179] by adele

6 edits in trunk/WebCore

Build fixes.

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/win/TemporaryLinkStubs.cpp:
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcMinMaxWidth):
rendering/RenderPopupMenuWin.h: (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
rendering/RenderThemeWin.cpp:

10:55 PM Changeset in webkit [15178] by mjs

2 edits in trunk/WebCore

Reviewed by Adele.

fix 308 Node leaks on the editing layout tests

dom/Document.cpp: (WebCore::Document::removedLastRef): Clear the markers once there are no real refs on the document, otherwise a self-only reference cycle w/ the document can occur.

10:47 PM Changeset in webkit [15177] by adele

28 edits
7 adds in trunk

WebCore:

Reviewed by Maciej and Hyatt.

Initial implementation of popup menu control. This can be turned on by setting -webkit-appearance: menulist on a select element.

WebCore.xcodeproj/project.pbxproj: Added RenderMenuList.h, RenderMenuList.cpp, RenderPopupMenu.h, RenderPopupMenu.cpp, RenderPopupMenuWin.h, RenderPopupMenuMac.h, RenderPopupMenuMac.mm,

dom/Node.cpp: (WebCore::Node::renderStyle): Added. Returns the renderer's style. If there's no renderer, returns's a RenderStyle that's kept by the node. This is important for HTMLOptGroupElement and HTMLOptionElement, which don't have renderers. (WebCore::Node::setRenderStyle): Added.
dom/Node.h:
dom/Element.cpp: (WebCore::Element::recalcStyle): Updated to use renderStyle so recalcStyle will work for HTMLOptionElements and HTMLOptGroupElements.

css/cssstyleselector.cpp: Updated to call renderStyle method on the node, so resolving style works on elements w/o renderers that cache style. (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::checkOneSelector):

css/html4.css: Removed display:none from options and optgroups, since we're now caching style for these elements. Added font-weight styles for option and optgroup.

html/HTMLOptGroupElement.h: Added m_style to keep track of a RenderStyle for the element, even though we aren't creating a renderer. This will allow us to honor style for optgroups and options for popup menus (and eventually list boxes too). (WebCore::HTMLOptGroupElement::rendererIsNeeded): Added. (WebCore::HTMLOptGroupElement::renderStyle): Added.
html/HTMLOptionElement.h: ditto. (WebCore::HTMLOptionElement::rendererIsNeeded): Added. (WebCore::HTMLOptionElement::renderStyle): Added.

html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::HTMLOptGroupElement): Initialize m_style. (WebCore::HTMLOptGroupElement::attach): Set the renderStyle. (WebCore::HTMLOptGroupElement::detach): Clear m_style. (WebCore::HTMLOptGroupElement::setRenderStyle): Added. (WebCore::HTMLOptGroupElement::groupLabelText): Added.
html/HTMLOptionElement.cpp: ditto. (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::attach): (WebCore::HTMLOptionElement::detach): (WebCore::HTMLOptionElement::setRenderStyle): (WebCore::HTMLOptionElement::optionText):

html/HTMLSelectElement.cpp: Added code to use the new RenderMenuList if the appearance is set to MenuListAppearance, and if we're not creating a list box renderer. (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler):
html/HTMLSelectElement.h:

WebCore.exp: Added _wkPopupMenu.
platform/mac/WebCoreSystemInterface.h: Added wkPopupMenu to get the NSMenu to pop up.
platform/mac/WebCoreSystemInterface.mm:

platform/win/TemporaryLinkStubs.cpp: Added stubs for RenderPopupMenuWin. (RenderPopupMenuWin::RenderPopupMenuWin): (RenderPopupMenuWin::~RenderPopupMenuWin): (RenderPopupMenuWin::clear): (RenderPopupMenuWin::populate): (RenderPopupMenuWin::showPopup): (RenderPopupMenuWin::addSeparator): (RenderPopupMenuWin::addGroupLabel): (RenderPopupMenuWin::addOption):
rendering/RenderPopupMenuWin.h: Added.

rendering/RenderPopupMenu.cpp: Added. (WebCore::RenderPopupMenu::RenderPopupMenu): (WebCore::RenderPopupMenu::~RenderPopupMenu): (WebCore::RenderPopupMenu::clear): (WebCore::RenderPopupMenu::populate): Walks the DOM tree, and adds separators, options, and group labels to the RenderPopupMenu. (WebCore::RenderPopupMenu::showPopup): (WebCore::RenderPopupMenu::addSeparator): (WebCore::RenderPopupMenu::addGroupLabel): (WebCore::RenderPopupMenu::addOption):
rendering/RenderPopupMenu.h: Added. (WebCore::RenderPopupMenu::renderName): (WebCore::RenderPopupMenu::getRenderMenuList):
rendering/RenderPopupMenuMac.h: Added.
rendering/RenderPopupMenuMac.mm: Added. (WebCore::RenderPopupMenuMac::RenderPopupMenuMac): (WebCore::RenderPopupMenuMac::~RenderPopupMenuMac): (WebCore::RenderPopupMenuMac::clear): Removes all items from the menu. (WebCore::RenderPopupMenuMac::populate): Disables menuChangedMessages before populating the menu. (WebCore::RenderPopupMenuMac::showPopup): Calculates the right position, and calls wkPopupMenu. (WebCore::RenderPopupMenuMac::addSeparator): (WebCore::RenderPopupMenuMac::addGroupLabel): (WebCore::RenderPopupMenuMac::addOption):

rendering/RenderMenuList.cpp: Added. (WebCore::RenderMenuList::RenderMenuList): (WebCore::RenderMenuList::addChild): (WebCore::RenderMenuList::removeChild): (WebCore::RenderMenuList::setStyle): (WebCore::RenderMenuList::updateFromElement): If the options have changed, iterate through the children to find the menu item with the widest text. Set the button text to the selected item's text. (WebCore::RenderMenuList::setText): (WebCore::RenderMenuList::paintObject): (WebCore::RenderMenuList::baselinePosition): (WebCore::RenderMenuList::calcMinMaxWidth): (WebCore::RenderMenuList::showPopup): (WebCore::RenderMenuList::layout): (WebCore::RenderMenuList::updateSelection): (WebCore::RenderMenuList::valueChanged):
rendering/RenderMenuList.h: Added. (WebCore::RenderMenuList::removeLeftoverAnonymousBoxes): (WebCore::RenderMenuList::allowsReusingAnonymousChild): (WebCore::RenderMenuList::canHaveChildren): (WebCore::RenderMenuList::renderName): (WebCore::RenderMenuList::setOptionsChanged): (WebCore::RenderMenuList::selectionChanged): (WebCore::RenderMenuList::setSelectionChanged): (WebCore::RenderMenuList::hasPopupMenu):

rendering/RenderTheme.cpp: Added cases for MenuListAppearance. (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::adjustMenuListStyle): (WebCore::RenderTheme::createPopupMenu): creates platform-specific RenderPopupMenu.
rendering/RenderTheme.h: (WebCore::RenderTheme::sizeOfArrowControl): Added. (WebCore::RenderTheme::paintMenuList): Added.
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::setPopupButtonCellState): (WebCore::RenderThemeMac::createPopupMenu): (WebCore::RenderThemeMac::sizeOfArrowControl):
rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::createPopupMenu):
rendering/RenderThemeWin.h:

WebKit:

Reviewed by Maciej and Hyatt.

WebKit part of initial popup menu implementation.

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize WKPopupMenu.

WebKitLibraries:

Reviewed by Maciej and Hyatt.

WebKitSystemInterface.h: Updated.
libWebKitSystemInterface.a: Updated.

7:57 PM Changeset in webkit [15176] by aliceli1

4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4600166> REGRESSION: Safari crash while loading web pages ( http://www.yahoo.com/ )

2005-10-16 David Hyatt <hyatt@apple.com>

Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.

Reviewed by bdakin

khtml/rendering/render_container.cpp: (RenderContainer::detach): this was renamed on the branch, from RenderContainer::destroy (RenderContainer::detachLeftoverChildren): this was renamed on the branch, from RenderContainer::destroyLeftoverChildren
khtml/rendering/render_container.h:
khtml/rendering/render_flow.cpp: (RenderFlow::detach): this was renamed on the branch, from RenderContainer::destroy

4:45 PM Changeset in webkit [15175] by beidson

5 edits in trunk/WebCore

Reviewed by Tim Omernick.

IconDatabase now respects private browsing via the use of in memory, temporary tables

bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): Renamed WebCore::IconDatabase methods, changes reflected here

icon/IconDatabase.cpp: (WebCore::IconDatabase::clearDatabase): (WebCore::IconDatabase::deletePrivateTables): (WebCore::IconDatabase::imageDataForIconID): (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::imageDataForPageURL): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::iconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::performSetIconDataForIconID): (WebCore::IconDatabase::establishTemporaryIconIDForEscapedIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::performSetIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL): -Some style/comment cleanups, but mainly putting private browsing handling in place

icon/IconDatabase.h: Some methods added, others renamed, some comments added

icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): -The above 4 had changes to return String() for empty results instead of "" as it's less expensive;

4:30 PM Changeset in webkit [15174] by sullivan

1 edit
4 adds in trunk/LayoutTests

Reviewed by Adele.

layout test for <rdar://problem/4609162> REGRESSION: When tabbing between links on a page, the window doesn't scroll to link that's not in view

The test verifies that focusing a link will scroll the link into view.

fast/events/reveal-link-when-focused-expected.checksum: Added.
fast/events/reveal-link-when-focused-expected.png: Added.
fast/events/reveal-link-when-focused-expected.txt: Added.
fast/events/reveal-link-when-focused.html: Added.

4:27 PM Changeset in webkit [15173] by sullivan

3 edits in trunk/WebCore

Reviewed by Darin and Adele.

fixed <rdar://problem/4609162> REGRESSION: When tabbing between links on a page, the window doesn't scroll to link that's not in view

html/HTMLAnchorElement.cpp:
html/HTMLAnchorElement.h: removed HTMLAnchorElement::focus and HTMLAnchorElement::blur.

HTMLAnchorElement::focus just called document()->setFocusNode(). The scroll-to-reveal
code used to be inside document()->setFocusNode(), but now it's in Element::focus, and this override
was preventing that code from running.

HTMLAnchorElement::blur was exactly the same implementation as Element::blur (and there aren't any
other implementations of ::blur in the class hierarchy in between). This change has no practical
effect, other than removing duplicate code.

Adele and I think that it was an oversight not to remove these two methods on 12/20/05
these methods were removed from HTMLButtonElementImpl and HTMLInputElementImpl.

3:24 PM Changeset in webkit [15172] by andersca

4 edits in trunk/WebCore

2006-07-05 Anders Carlsson <acarlsson@apple.com>

bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (FrameWin::createFrame): Fix Win32 build.

2:37 PM Changeset in webkit [15171] by andersca

2 edits in trunk/WebCore

2006-07-05 Anders Carlsson <acarlsson@apple.com>

WebCore.xcodeproj/project.pbxproj: Revert accidental change of debug format to DWARF.

2:29 PM Changeset in webkit [15170] by andersca

24 edits
5 adds in trunk

WebCore:

2006-07-05 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::createFrame):
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge installInFrame:]): Modify to pass the owner element instead of the owner renderer.

dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): Dispatch the node inserted events before attaching the nodes. This is what the tokenizer does.

html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach): Pass the element to requestFrame.

(WebCore::HTMLFrameElement::setLocation):
Don't call attach/detach on an iframe.

html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::insertedIntoDocument): Load the frame here (using openURL).

(WebCore::HTMLIFrameElement::removedFromDocument):
Call frameDetached.

(WebCore::HTMLIFrameElement::attach):
If there's a renderer, attach the content frame to it.

(WebCore::HTMLIFrameElement::detach):
Reset the renderer's frame.

(WebCore::HTMLIFrameElement::openURL):
Modify to request the frame.

html/HTMLIFrameElement.h: Add detach.

page/Frame.cpp: (WebCore::parentFromOwnerElement): (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::loadSubframe): (WebCore::Frame::ownerElement): (WebCore::Frame::ownerRenderer): (WebCore::Frame::disconnectOwnerElement):
page/Frame.h:
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
rendering/RenderPart.cpp: (WebCore::RenderPart::setFrame): Modify to keep an owner element around instead of the renderer.

rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Don't do anything for iframes.

WebKit:

2006-07-05 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]): Modify to pass the owner element instead of the owner renderer.

WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]): Remove assertion, it's not valid anymore.

LayoutTests:

2006-07-05 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array

fast/events/mouseover-mouseout2-expected.txt:
fast/events/mouseover-mouseout2.html: Update expected result. Since we now keep the frame around, the mouseout event is now dispatched to the element in the frame.

fast/events/onloadFrameCrash-expected.checksum:
fast/events/onloadFrameCrash-expected.png:
fast/events/onloadFrameCrash-expected.txt: This does hide the frame now.

fast/frames/iframe-display-none-expected.txt: Added.
fast/frames/iframe-display-none.html: Added.
fast/frames/resources/iframe-display-none-child.html: Added. New test that tests JS interaction with frames.

fast/frames/iframe-double-attach-expected.txt: Added.
fast/frames/iframe-double-attach.html: Added.

1:05 PM Changeset in webkit [15169] by thatcher

2 edits
1 add in trunk/WebKit

Reviewed by Harrison.

<rdar://problem/4608423> HIViewAdapter used but not defined
Adds a new export file to fix the build.

WebKit.LP64.exp: Added.
WebKit.xcodeproj/project.pbxproj:

12:10 PM Changeset in webkit [15168] by ggaren

16 edits
2 moves in trunk/JavaScriptCore

RS by Beth.

Renamed JSCharBufferRef, which was universally unpopular, to JSStringBufferRef,
which, hopefully, will be less unpopular.

API/APICast.h: (toJS): (toRef):
API/JSBase.h:
API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
API/JSCharBufferRef.cpp: Removed.
API/JSCharBufferRef.h: Removed.
API/JSContextRef.cpp: (JSEvaluate): (JSCheckSyntax):
API/JSContextRef.h:
API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild):
API/JSNodeList.c: (JSNodeList_length): (JSNodeList_getProperty):
API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectGetDescription): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSPropertyEnumeratorGetNext): (JSPropertyListAdd):
API/JSObjectRef.h:
API/JSStringBufferRef.cpp: Added. (JSStringMake): (JSStringBufferCreate): (JSStringBufferCreateUTF8): (JSStringBufferRetain): (JSStringBufferRelease): (JSValueCopyStringValue): (JSStringBufferGetLength): (JSStringBufferGetCharactersPtr): (JSStringBufferGetCharacters): (JSStringBufferGetMaxLengthUTF8): (JSStringBufferGetCharactersUTF8): (JSStringBufferIsEqual): (JSStringBufferIsEqualUTF8): (JSStringBufferCreateWithCFString): (CFStringCreateWithJSStringBuffer):
API/JSStringBufferRef.h: Added.
API/JSValueRef.h:
API/JavaScriptCore.h:
API/minidom.c: (main): (print):
API/testapi.c: (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:

11:54 AM Changeset in webkit [15167] by thatcher

3 edits in tags/WebKit-521.14.3/WebKit

Build fixes and versioning.

11:35 AM Changeset in webkit [15166] by thatcher

1 copy in tags/WebKit-521.14.3

New tag.

11:07 AM Changeset in webkit [15165] by ggaren

6 edits in trunk/JavaScriptCore

RS by Beth.

Moved some code around for more logical file separation.

API/JSBase.h:
API/JSContextRef.h:
API/JSObjectRef.cpp:
API/JSValueRef.cpp: (JSValueToObject):
API/JSValueRef.h:

10:46 AM Changeset in webkit [15164] by ggaren

6 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Implemented JSFunctionMakeWithBody, which parses a script as a function body
in the global scope, and returns the resulting anonymous function.

I also removed private data from JSCallbackFunction. It never worked,
since JSCallbackFunction doesn't inherit from JSCallbackObject.

API/JSCallbackConstructor.cpp: Removed.
API/JSCallbackConstructor.h: Removed.
API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction): (KJS::JSCallbackFunction::implementsConstruct): (KJS::JSCallbackFunction::construct): (KJS::JSCallbackFunction::implementsCall): (KJS::JSCallbackFunction::callAsFunction):
API/JSCallbackFunction.h:
API/JSCallbackObject.cpp: (KJS::JSCallbackObject::staticFunctionGetter):
API/JSObjectRef.cpp: (JSFunctionMake): (JSFunctionMakeWithCallbacks):
API/JSObjectRef.h:
API/JSValueRef.h:
API/minidom.c: (main):
API/testapi.c: (main):
JavaScriptCore.exp: Programmatically added all symbols exported by API object files, and sorted results
JavaScriptCore.xcodeproj/project.pbxproj:

9:52 AM Changeset in webkit [15163] by ggaren