⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 7, 2006:

8:36 PM Changeset in webkit [15227] by ggaren
  • 3 edits in trunk/JavaScriptGlue
  • build fix
  • JSUtils.cpp: (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
7:32 PM Changeset in webkit [15226] by justing
  • 12 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/selection/editable-non-editable-crash-expected.checksum: Added.
  • editing/selection/editable-non-editable-crash-expected.png: Added.
  • editing/selection/editable-non-editable-crash-expected.txt: Added.
  • editing/selection/editable-non-editable-crash.html: Added.
  • editing/selection/skip-non-editable-1-expected.txt:
  • editing/selection/skip-non-editable-1.html:

WebCore:

Reviewed by levi


Fix Mail ToDo crashers.

  • dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Added an ASSERT that both containers are non-null and an early return.
  • editing/Selection.cpp: (WebCore::Selection::validate): Fix a dangling start/end. (WebCore::Selection::adjustForEditableContent): Added an early return if m_start or m_end are null. (WebCore::Selection::isContentEditable): Use isRichlyEditablePosition. (WebCore::Selection::isContentRichlyEditable): Ditto.
  • editing/Selection.h:
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Use the new highestEditableRoot. (WebCore::VisiblePosition::previous): Ditto.
  • editing/htmlediting.cpp: (WebCore::highestEditableRoot): Takes in a position. (WebCore::isEditablePosition): Added. (WebCore::isRichlyEditablePosition): Added. (WebCore::rootEditableElement): Added. (WebCore::nextCandidate): Moved and split out from nextVisiblePosition. (WebCore::nextVisuallyDistinctCandidate): Ditto. (WebCore::previousCandidate): Moved and split out from previousVisiblePosition. (WebCore::previousVisuallyDistinctCandidate): Ditto. (WebCore::firstEditablePositionAfterPositionInRoot): Iterate over positions, using nextVisuallyDistinctCandidate, skipping atomic nodes that are non-editable. (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
  • editing/htmlediting.h:
  • editing/visible_units.cpp: (WebCore::startOfWord): Added a FIXME.
7:25 PM Changeset in webkit [15225] by ggaren
  • 14 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Standardized which functions take a JSContext as an argument. The rule is: if you might execute JavaScript, you take a JSContext, otherwise you don't.


The FIXME in JSObjectRef.h requires refactoring some parts of Interpreter,
but not API changes, so I'm putting it off until later.

  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::init):
  • API/JSCallbackObject.h:
  • API/JSContextRef.cpp: (JSContextCreate):
  • API/JSContextRef.h:
  • API/JSObjectRef.cpp: (JSObjectMake): (JSPropertyEnumeratorGetNext):
  • API/JSObjectRef.h:
  • API/testapi.c: (MyObject_initialize): (main):
  • JavaScriptCore.exp:
  • kjs/array_object.cpp: (ArrayInstance::setLength): (ArrayInstance::pushUndefinedObjectsToEnd):
  • kjs/nodes.cpp: (ForInNode::execute):
  • kjs/reference.cpp: (KJS::Reference::getPropertyName): (KJS::Reference::getValue):
  • kjs/reference.h:
  • kjs/scope_chain.cpp: (KJS::ScopeChain::print):
7:02 PM Changeset in webkit [15224] by ggaren
  • 21 edits in trunk/JavaScriptCore

Reviewed by Maciej.


More API action.


  • Headerdoc finished

Semantic Changes:

  • Added a JSContextRef argument to many functions, because you need a JSContextRef for doing virtually anything. I expect to add this argument to even more functions in a future patch.


  • Removed the globalObjectPrototype argument to JSContextCreate because you can't create an object until you have a context, so it's impossible to pass a prototype object to JSContextCreate. That's OK because (1) there's no reason to give the global object a prototype and (2) if you really want to, you can just use a separate call to JSObjectSetPrototype.


  • Removed the JSClassRef argument to JSClassCreate because it was unnecessary, and you need to be able to make the global object's class before you've created a JSContext.


  • Added an optional exception parameter to JSFunctionMakeWithBody because anything less would be uncivilized.


  • Made the return value parameter to JSObjectGetProperty optional to match all other return value parameters in the API.


  • Made JSObjectSetPrivate/JSObjectGetPrivate work on JSCallbackFunctions and JSCallbackConstructors. You could use an abstract base class or strategic placement of m_privateData in the class structure to implement this, but the former seemed like overkill, and the latter seemed too dangerous.


  • Fixed a bug where JSPropertyEnumeratorGetNext would skip the first property.

Cosmetic Changes:

  • Reversed the logic of the JSChar #ifdef to avoid confusing headerdoc


  • Removed function names from @function declarations because headeroc can parse them automatically, and I wanted to rule out manual mismatch.
  • Changed Error::create to take a const UString& instead of a UString* because it was looking at me funny.


  • Renamed JSStringBufferCreateWithCFString to JSStringBufferCreateCF because the latter is more concise and it matches JSStringBufferCreateUTF8.


  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString):
  • API/JSClassRef.cpp: (JSClassCreate):
  • API/JSContextRef.cpp: (JSContextCreate): (JSContextSetException):
  • API/JSContextRef.h:
  • API/JSNode.c: (JSNodePrototype_class): (JSNode_class):
  • API/JSNodeList.c: (JSNodeListPrototype_class): (JSNodeList_class):
  • API/JSObjectRef.cpp: (JSObjectGetProperty): (JSObjectGetPrivate): (JSObjectSetPrivate): (JSObjectCallAsFunction): (JSObjectCallAsConstructor): (JSPropertyEnumeratorGetNext):
  • API/JSObjectRef.h:
  • API/JSStringBufferRef.cpp: (JSStringBufferCreateCF):
  • API/JSStringBufferRef.h:
  • API/JSValueRef.cpp: (JSValueIsInstanceOf):
  • API/JSValueRef.h:
  • API/minidom.c: (main):
  • API/minidom.js:
  • API/testapi.c: (MyObject_hasProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_convertToType): (MyObject_class): (main):
  • JavaScriptCore.exp:
6:45 PM Changeset in webkit [15223] by lweintraub
  • 4 edits in trunk/LayoutTests

Reviewed by NOBODY

Missed a few in the last update...

  • fast/forms/input-delete-expected.txt:
  • fast/repaint/inline-outline-repaint-expected.txt:
  • fast/repaint/selection-after-delete-expected.txt:
5:46 PM Changeset in webkit [15222] by lweintraub
  • 156 edits in trunk

LayoutTests:

Reviewed by justin

Deletion editing deligates now show up!

  • editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • editing/deleting/delete-3608430-fix-expected.txt:
  • editing/deleting/delete-3608445-fix-expected.txt:
  • editing/deleting/delete-3608462-fix-expected.txt:
  • editing/deleting/delete-3775172-fix-expected.txt:
  • editing/deleting/delete-3800834-fix-expected.txt:
  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-3865854-fix-expected.txt:
  • editing/deleting/delete-3928305-fix-expected.txt:
  • editing/deleting/delete-3959464-fix-expected.txt:
  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/deleting/delete-4083333-fix-expected.txt:
  • editing/deleting/delete-after-span-ws-001-expected.txt:
  • editing/deleting/delete-after-span-ws-002-expected.txt:
  • editing/deleting/delete-after-span-ws-003-expected.txt:
  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-and-undo-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • editing/deleting/delete-block-contents-001-expected.txt:
  • editing/deleting/delete-block-contents-002-expected.txt:
  • editing/deleting/delete-block-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-block-merge-contents-022-expected.txt:
  • editing/deleting/delete-block-merge-contents-023-expected.txt:
  • editing/deleting/delete-block-merge-contents-024-expected.txt:
  • editing/deleting/delete-br-001-expected.txt:
  • editing/deleting/delete-br-002-expected.txt:
  • editing/deleting/delete-br-003-expected.txt:
  • editing/deleting/delete-br-004-expected.txt:
  • editing/deleting/delete-br-005-expected.txt:
  • editing/deleting/delete-br-006-expected.txt:
  • editing/deleting/delete-br-007-expected.txt:
  • editing/deleting/delete-br-008-expected.txt:
  • editing/deleting/delete-br-009-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-br-011-expected.txt:
  • editing/deleting/delete-character-001-expected.txt:
  • editing/deleting/delete-contiguous-ws-001-expected.txt:
  • editing/deleting/delete-image-001-expected.txt:
  • editing/deleting/delete-image-002-expected.txt:
  • editing/deleting/delete-image-003-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/deleting/delete-leading-ws-001-expected.txt:
  • editing/deleting/delete-line-001-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-003-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-005-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-009-expected.txt:
  • editing/deleting/delete-line-010-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-line-013-expected.txt:
  • editing/deleting/delete-line-014-expected.txt:
  • editing/deleting/delete-line-015-expected.txt:
  • editing/deleting/delete-line-016-expected.txt:
  • editing/deleting/delete-line-017-expected.txt:
  • editing/deleting/delete-line-end-ws-001-expected.txt:
  • editing/deleting/delete-line-end-ws-002-expected.txt:
  • editing/deleting/delete-listitem-001-expected.txt:
  • editing/deleting/delete-listitem-002-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/deleting/delete-select-all-002-expected.txt:
  • editing/deleting/delete-select-all-003-expected.txt:
  • editing/deleting/delete-selection-001-expected.txt:
  • editing/deleting/delete-tab-001-expected.txt:
  • editing/deleting/delete-tab-002-expected.txt:
  • editing/deleting/delete-tab-003-expected.txt:
  • editing/deleting/delete-tab-004-expected.txt:
  • editing/deleting/delete-trailing-ws-001-expected.txt:
  • editing/deleting/delete-trailing-ws-002-expected.txt:
  • editing/deleting/delete-ws-fixup-001-expected.txt:
  • editing/deleting/delete-ws-fixup-002-expected.txt:
  • editing/deleting/delete-ws-fixup-003-expected.txt:
  • editing/deleting/delete-ws-fixup-004-expected.txt:
  • editing/deleting/forward-delete-expected.txt:
  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/merge-endOfParagraph-expected.txt:
  • editing/deleting/merge-into-empty-block-1-expected.txt:
  • editing/deleting/merge-into-empty-block-2-expected.txt:
  • editing/deleting/merge-no-br-expected.txt:
  • editing/deleting/merge-unrendered-space-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/deleting/smart-delete-001-expected.txt:
  • editing/deleting/smart-delete-002-expected.txt:
  • editing/deleting/table-cells-expected.txt:
  • editing/execCommand/insertHTML-expected.txt:
  • editing/input/text-input-controller-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-3851164-fix-expected.txt:
  • editing/inserting/insert-after-delete-001-expected.txt:
  • editing/inserting/insert-div-021-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/paste-table-002-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/selection/move-between-blocks-no-001-expected.txt:
  • editing/selection/select-all-iframe-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/style-3681552-fix-002-expected.txt:
  • editing/style/typing-style-001-expected.txt:
  • editing/style/typing-style-002-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:
  • editing/unsupported-content/list-delete-002-expected.txt:
  • editing/unsupported-content/list-delete-003-expected.txt:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-delete-002-expected.txt:
  • editing/unsupported-content/table-delete-003-expected.txt:
  • fast/forms/input-text-option-delete-expected.checksum:
  • fast/forms/input-text-option-delete-expected.txt:

WebCore:

Reviewed by justin

Allowed deletion typing commands to take in a granularity

  • bridge/mac/WebCoreFrameBridge.h: Pass granularity across the bridge
  • bridge/mac/WebCoreFrameBridge.mm: Ditto (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
  • editing/TypingCommand.cpp: Constructors take in a granularity (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/TypingCommand.h: ditto
  • page/Frame.h: Fixed bug that shouldDeleteSelection wasn't virtual

WebKit:

Reviewed by justin

Finished moving deletion selection expansion across the bridge... say that 3 times fast.

  • WebView/WebHTMLView.m: Pass granularity to WebCore to handle expansion (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]): (-[WebHTMLView _deleteSelection]): (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]): (-[NSArray deleteToMark:]):
5:27 PM Changeset in webkit [15221] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Anders and Tim Hatcher

Added an accessor to a SQLite config option to change its disk-syncing behavior.
Used this accessor to significantly speed up writes to the Icon DB.

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Disable full syncing to the SQLite db to speed up writes to the icondb
  • icon/SQLDatabase.cpp: (SQLDatabase::setFullsync): (SQLDatabase::setSynchronous):
  • icon/SQLDatabase.h: (WebCore::SQLDatabase::): Added accessor to the SQLite config pragma "synchronous"
5:21 PM Changeset in webkit [15220] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed a storage leak noticed by the buildbot
  • dom/Document.cpp: (WebCore::Document::removedLastRef): Call delete on the markers before clearing the map containing them.
4:46 PM Changeset in webkit [15219] by andersca
  • 5 edits in trunk/WebCore

2006-07-08 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Brady.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9777
Reproducible crash in Loading/Frames in ToT.


The problem was that the renderpart destructor resets the frame's
owner element. For iframes, this should only be done when the element is
going to be removed from the document.


  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::~HTMLIFrameElement): (WebCore::HTMLIFrameElement::willRemove): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::detach):
  • html/HTMLIFrameElement.h: Remove the frame in willRemove instead.


  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): (WebCore::RenderPart::~RenderPart):
  • rendering/RenderPart.h: Don't call setFrame(0) in the destructor when the element is an iframe element.
4:01 PM Changeset in webkit [15218] by darin
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • fixed a storage leak noticed by the buildbot
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::~FrameViewPrivate): Delete m_scheduledEvents.
3:39 PM Changeset in webkit [15217] by sullivan
  • 1 edit in trunk/WebKit/ChangeLog

Added a bug number to an existing entry.

3:33 PM Changeset in webkit [15216] by darin
  • 3 edits in trunk/WebCore

Reviewed by Adele.

  • fixed a couple of storage leaks noticed by the buildbot
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach): Call deref on the style after calling setRenderStyle, since styleForRenderer returns us a "ref'd" RenderStyle object.
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.
3:18 PM Changeset in webkit [15215] by darin
  • 6 edits in trunk/WebCore

Reviewed by Adele.

  • fix some license mistakes
  • LICENSE-APPLE: Added more years of publication to the copyright here.
  • html/CanvasGradient.idl: Corrected license on this file. It had the wrong one.
  • html/CanvasPattern.idl: Ditto.
  • html/CanvasRenderingContext2D.idl: Ditto.
  • html/HTMLCanvasElement.idl: Ditto.
2:13 PM Changeset in webkit [15214] by beidson
  • 2 edits in trunk/WebKit

Reviewed by John

Changed an ASSERT to a LOG_ERROR for an error that could be handled gracefully, but
whose assertion was reproducibly causing a build bot failure

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _releaseIconForIconURLString:]):
1:41 PM Changeset in webkit [15213] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.


  • Fixed a few crashes resulting from NULL parameters to JSClassCreate.
  • API/JSClassRef.cpp: (JSClassCreate): (JSClassRelease):
  • API/testapi.c: Added test for NULL parameters. (main):
1:39 PM Changeset in webkit [15212] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by John, mocked by Darin.


  • Changed JSEvaluate to take a JSObjectRef instead of a JSValueRef as "this," since "this" must be an object.
  • API/JSContextRef.cpp: (JSEvaluate):
  • API/JSContextRef.h:
1:38 PM Changeset in webkit [15211] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.


  • More headerdoc
12:57 PM Changeset in webkit [15210] by thatcher
  • 1 copy in tags/WebCore-315.14.4/WebCore

New tag (part 2).

12:56 PM Changeset in webkit [15209] by thatcher
  • 1 add in tags/WebCore-315.14.4

New tag.

12:55 PM Changeset in webkit [15208] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

12:54 PM Changeset in webkit [15207] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
This fixes <rdar://problem/4600166> REGRESSION: Safari crash while loading web pages ( ​http://www.yahoo.com/ )

2005-10-16 David Hyatt <​hyatt@apple.com>

Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.


Reviewed by bdakin

  • khtml/rendering/render_container.cpp: (RenderContainer::detach): this was renamed on the branch, from RenderContainer::destroy (RenderContainer::detachLeftoverChildren): this was renamed on the branch, from RenderContainer::destroyLeftoverChildren
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::detach): this was renamed on the branch, from RenderContainer::destroy
12:33 PM Changeset in webkit [15206] by lweintraub
  • 12 edits
    4 adds in trunk

LayoutTests:

Reviewed by justin

Improved table editing

  • editing/deleting/delete-to-select-table-expected.checksum: Added.
  • editing/deleting/delete-to-select-table-expected.png: Added.
  • editing/deleting/delete-to-select-table-expected.txt: Added.
  • editing/deleting/delete-to-select-table.html: Added.
  • editing/input/text-input-controller-expected.txt:

WebCore:

Reviewed by justin

Improved table editing: pressing delete directly before or after a table will now select
the table first, then delete it, instead of just deleting it. Useful for when the table's
existence is non-obvious.

  • bridge/mac/FrameMac.h: Added shouldDeleteSelection, which allows WebCore to trigger deletion editing deligates
  • bridge/mac/FrameMac.mm: ditto (WebCore::FrameMac::shouldDeleteSelection):
  • bridge/mac/WebCoreFrameBridge.h: ditto
  • editing/TypingCommand.cpp: Implemented check for a caret position next to a table, and subsequent selection (as opposed to removal) (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • page/Frame.cpp: shouldDeleteSelection added (WebCore::Frame::shouldDeleteSelection):
  • page/Frame.h: ditto

WebKit:

Reviewed by justin

Improved table editing

  • WebCoreSupport/WebFrameBridge.m: Added method to allow WebCore to trigger deletion editing delegate (-[WebFrameBridge shouldDeleteSelectedDOMRange:]):
  • WebView/WebHTMLView.m: Moved code that expanded a selection when the delete key is pressed over to WebCore so we can be more intelligent about how to handle it (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
12:29 PM Changeset in webkit [15205] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/ChangeLog

Versioning

12:21 PM Changeset in webkit [15204] by thatcher
  • 2 copies in tags/WebCore-418.20/WebCore

New tag (part 2).

12:20 PM Changeset in webkit [15203] by thatcher
  • 1 add in tags/WebCore-418.20

New tag.

12:19 PM Changeset in webkit [15202] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/Info.plist

Versioning

11:24 AM Changeset in webkit [15201] by weinig
  • 4 edits
    2 copies in trunk/WebCore

Reviewed by Eric.

  • WebCore.xcodeproj/project.pbxproj:
  • xml/XSLImportRule.cpp: Added. (WebCore::XSLImportRule::XSLImportRule): (WebCore::XSLImportRule::parentStyleSheet): (WebCore::XSLImportRule::loadSheet):
  • xml/XSLImportRule.h: Added.
  • xml/XSLStyleSheet.cpp:
  • xml/XSLStyleSheet.h:
10:22 AM Changeset in webkit [15200] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-07-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8300
REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons


  • css/html4.css: Set "-webkit-user-select: ignore" on radio buttons and check boxes .


LayoutTests:

2006-07-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8300
REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons

  • fast/forms/radio-check-click-and-drag-expected.txt: Added.
  • fast/forms/radio-check-click-and-drag.html: Added.
10:09 AM Changeset in webkit [15199] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • WebKit.exp: added surprisingly missing _WebPreferencesChangedNotification, defined in WebPreferences.h
1:36 AM Changeset in webkit [15198] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • fix 20 Node leaks on fast/events tests - these should be the last ones
  • bindings/objc/DOMEvents.mm: (-[DOMEvent dealloc]): implement - deref the event! (-[DOMEvent finalize]): ditto

Jul 6, 2006:

9:48 PM Changeset in webkit [15197] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • fix 26 Node leaks on fast/dom tests
  • dom/Document.cpp: (WebCore::Document::removedLastRef): delete tokenizer - if we are still parsing at this point, we don't want nodes held by the parser to keep the document alive.
  • html/HTMLParser.cpp: (WebCore::RefNonDocNodePtr::RefNonDocNodePtr): Smart pointer that acts like RefPtr for Node, but avoids refing document nodes to avoid cycles. (WebCore::RefNonDocNodePtr::~RefNonDocNodePtr): (WebCore::RefNonDocNodePtr::get): (WebCore::RefNonDocNodePtr::operator*): (WebCore::RefNonDocNodePtr::operator->): (WebCore::RefNonDocNodePtr::operator!): (WebCore::RefNonDocNodePtr::operator UnspecifiedBoolType): (WebCore::RefNonDocNodePtr::operator=): (WebCore::operator==): (WebCore::operator!=): (WebCore::HTMLStackElem): Use a RefNonDocNodePtr instead of RefPtr<Node> (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Use a RefPtr here to avoid crashing
7:29 PM Changeset in webkit [15196] by adele
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

Fixed new popup control to open up when the spacebar and the up and down arrows are pressed.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::isKeyboardFocusable): Added. (WebCore::HTMLSelectElement::isMouseFocusable): Added. (WebCore::HTMLSelectElement::defaultEventHandler): Updated to showPopup for up and down arrow keys and spacebar.
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Made this const.
  • rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Added FIXME.
  • rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::showPopup): Updated to save the NSEvent that triggers the popup, so we can send fake mouseUp and keyUp events when the NSMenu returns. (WebCore::RenderPopupMenuMac::addGroupLabel): Only set the NSForegroundColorAttributeName attribute if the text isn't black. Follow-up bug about other colors: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9769 (WebCore::RenderPopupMenuMac::addOption): ditto.
  • bridge/mac/FrameMac.h: (WebCore::FrameMac::currentEvent): Returns the current NSEvent.
7:13 PM Changeset in webkit [15195] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4609184>
Mail crashes at WebCore::Selection::adjustForEditableContent
<rdar://problem/4609140>
Crash at WebCore::Range::compareBoundaryPoints

  • editing/selection/mixed-editability-1-expected.checksum: Added.
  • editing/selection/mixed-editability-1-expected.png: Added.
  • editing/selection/mixed-editability-1-expected.txt: Added.
  • editing/selection/mixed-editability-1.html: Added.
  • editing/selection/mixed-editability-2-expected.checksum: Added.
  • editing/selection/mixed-editability-2-expected.png: Added.
  • editing/selection/mixed-editability-2-expected.txt: Added.
  • editing/selection/mixed-editability-2.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4609184>
Mail crashes at WebCore::Selection::adjustForEditableContent
<rdar://problem/4609140>
Crash at WebCore::Range::compareBoundaryPoints


  • editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Moved code into a helper function. (WebCore::VisiblePosition::previous): Ditto.
  • editing/htmlediting.cpp: (WebCore::comparePositions): Moved from Selection.cpp. (WebCore::lowestEditableAncestor): Added. Returns rootEditableElement for a node in editable content and the rootEditableElement for the first ancestor that's editable for a node in non-editable content. (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot):
  • editing/htmlediting.h:
6:00 PM Changeset in webkit [15194] by andersca
  • 6 edits
    2 adds in trunk

WebCore:

2006-07-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9528
REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes


Patch by Darin, tweaked by Anders.


  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): Convert newline characters to <br> elements. I've verified that what's done here is what WinIE does when setting innerText.


(WebCore::HTMLElement::setOuterText):
Fix comment.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks): Remove assert. m_div->firstChild() can be null now because setInnerText doesn't create text nodes for empty strings anymore.

LayoutTests:

2006-07-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9528
REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes

  • fast/dom/css-selectorText-expected.txt:
  • fast/dom/css-shortHands-expected.txt: Update tests.


  • fast/dom/set-inner-text-newlines-expected.txt: Added.
  • fast/dom/set-inner-text-newlines.html: Added.
5:22 PM Changeset in webkit [15193] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with 10.4.6 too)
  • page/FrameView.cpp: (WebCore::FrameView::layout): Ref's the view during layout, since a recalcStyle could cause the view to be deleted. If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exit layout.
  • page/FrameView.h: (WebCore::FrameView::hasOneRef): Added.
5:12 PM Changeset in webkit [15192] by adele
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

  • Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with 10.4.6 too)
  • khtml/khtmlview.cpp: (KHTMLView::layout): Ref's the view during layout, since a recalcStyle could cause the view to be deleted. If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exit layout.
  • khtml/khtmlview.h: (KHTMLView::hasOneRef): Added.
4:11 PM Changeset in webkit [15191] by andersca
  • 14 edits
    5 adds in trunk

WebCore:

2006-07-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4610891> Support overflow events


  • DerivedSources.make: Add generated sources.


  • WebCore.xcodeproj/project.pbxproj: Add new files.


  • bindings/js/kjs_events.cpp: (KJS::toJS): Support creating wrappers for overflow events..


  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:]): (-[DOMOverflowEvent _overflowEvent]): (-[DOMOverflowEvent orient]): (-[DOMOverflowEvent horizontalOverflow]): (-[DOMOverflowEvent verticalOverflow]): Add Objective-C wrapper for overflow events.


  • dom/Event.cpp: (WebCore::Event::isOverflowEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • dom/OverflowEvent.cpp: Added. (WebCore::OverflowEvent::OverflowEvent): (WebCore::OverflowEvent::isOverflowEvent):
  • dom/OverflowEvent.h: Added. (WebCore::OverflowEvent::): (WebCore::OverflowEvent::orient): (WebCore::OverflowEvent::horizontalOverflow): (WebCore::OverflowEvent::verticalOverflow):
  • dom/OverflowEvent.idl: Added. Add overflow events.


  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout): Dispatch any scheduled events when layout is done.


(WebCore::FrameView::scheduleEvent):
New function which schedules an event.


(WebCore::FrameView::updateOverflowStatus):
Update overflow status for the viewport.


(WebCore::FrameView::dispatchScheduledEvents):
New function which dispatches all scheduled events.


  • page/FrameView.h: Add declarations.


  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderLayer.h: Schedule overflow events when overflow status changes.

LayoutTests:

2006-07-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4610891> Support overflow events


  • fast/events/overflow-events-expected.txt: Added.
  • fast/events/overflow-events.html: Added.
3:47 PM Changeset in webkit [15190] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4610881> Expose scroll-related JS properties to ObjC DOM interface
<rdar://problem/4519675> offsetLeft, offsetTop, offsetHeight, and offsetWidth
properties are not exposed to ObjC

  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLElement offsetLeft]): (-[DOMHTMLElement offsetTop]): (-[DOMHTMLElement offsetWidth]): (-[DOMHTMLElement offsetHeight]): (-[DOMHTMLElement offsetParent]): (-[DOMHTMLElement clientWidth]): (-[DOMHTMLElement clientHeight]): (-[DOMHTMLElement scrollLeft]): (-[DOMHTMLElement setScrollLeft:]): (-[DOMHTMLElement scrollTop]): (-[DOMHTMLElement setScrollTop:]): (-[DOMHTMLElement scrollWidth]): (-[DOMHTMLElement scrollHeight]):
3:45 PM Changeset in webkit [15189] by brmorris
  • 3 edits in S60/trunk

S60WebKit:

2006-07-06 brmorris <​bradley.morrison@nokia.com>

Reviewed by dacarson. Fix for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9754

  • S60Tools/patch.exe: Updated to version 2.5.
  • S60Tools/prepare-ChangeLog.bat: Force forwardslashes.
3:30 PM Changeset in webkit [15188] by brmorris
  • 1 edit
    5 adds in S60/trunk

S60WebKit:

2006-07-06 brmorris <​bradley.morrison@nokia.com>

Reviewed by dacarson.

  • S60Tools\patch.exe: Added.
  • S60Tools\prepare-ChangeLog.bat: Added.
  • S60Tools\svn-apply.bat: Added.
  • S60Tools\svn-create-patch.bat: Added.
  • S60Tools\svn-unapply.bat: Added.
2:41 PM Changeset in webkit [15187] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • fix 435 more layout tests Node leaks
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): fix more instances of leaked DOM ranges
11:39 AM Changeset in webkit [15186] by beidson
  • 2 edits in trunk/WebKit

Reviewed by John.

Small fix to my previous small fix that only lets the ASSERT off the hook if the DB
is closing

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _releaseIconForIconURLString:]):
9:45 AM Changeset in webkit [15185] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/4565031> innerHTML of XMP tag returns special characters like '&gt;' instead of '>'

  • fast/innerHTML/006-expected.checksum: Added.
  • fast/innerHTML/006-expected.png: Added.
  • fast/innerHTML/006-expected.txt: Added.
  • fast/innerHTML/006.html: Added.

WebCore:

Reviewed by Geoff

<rdar://problem/4565031> innerHTML of XMP tag returns special characters like '&gt;' instead of '>'


Test: fast/innerHTML/006.html


  • editing/markup.cpp: (WebCore::startMarkup): (WebCore::createMarkup): Do not special quote content of XMP nodes.
4:37 AM Changeset in webkit [15184] by mjs
  • 3 edits in trunk/WebCore

Not reviewed - build fix.

  • back out earlier leak fix, as it caused a crash on one of the fast/invalid layout tests
  • dom/Document.cpp: (WebCore::Document::removedLastRef):
  • html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLParser::popNestedHeaderTag): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags): (WebCore::HTMLParser::popBlock): (WebCore::HTMLParser::popOneBlock):
2:50 AM Changeset in webkit [15183] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • fix ~3000 Node leaks on the editing tests
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): put a newly created Range in a RefPtr to avoid leaking it, as this leaks the whole document.
2:39 AM Changeset in webkit [15182] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Anders.

  • fix 26 Node leaks on various fast/dom tests
  • dom/Document.cpp: (WebCore::Document::removedLastRef): Delete the tokenizer here, since if we are in mid-parse, the parser might hold refs on some of our children that have self-only refs.
  • html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): don't ref the node if it is a document to avoid ref cycles (WebCore::HTMLStackElem::~HTMLStackElem): ditto (WebCore::HTMLStackElem::node): changed interface a bit to support the above (WebCore::HTMLStackElem::setNode): ditto (WebCore::HTMLParser::popNestedHeaderTag): use new interface to HTMLStackElem (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): ditto (WebCore::HTMLParser::reopenResidualStyleTags): ditto (WebCore::HTMLParser::popBlock): ditto (WebCore::HTMLParser::popOneBlock): ditto
Note: See TracTimeline for information about the timeline view.