Context Navigation

WebCore.vcproj/WebCore/WebCore.vcproj: Added JSHTMLOptionsCollection.cpp/h and JSHTMLOptionsCollectionCuston.cpp. VC++ Express realphabetized the file list.

7:55 PM Changeset in webkit [15367] by darin

10 edits in trunk/WebCore

Reviewed by Adele.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9809 <rdar://problem/4619515> focus ring fails to appear on select element after choosing item from popup

includes http://bugzilla.opendarwin.org/show_bug.cgi?id=9853 improvements to select element, including some storage leak fixes

html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::index): Use a const reference for the list items, so we don't have to copy a vector.
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectedIndex): Ditto. (WebCore::HTMLSelectElement::setSelectedIndex): Ditto. (WebCore::HTMLSelectElement::length): Ditto. (WebCore::HTMLSelectElement::remove): Ditto. (WebCore::HTMLSelectElement::value): Ditto. (WebCore::HTMLSelectElement::setValue): Ditto. (WebCore::HTMLSelectElement::stateValue): Ditto. (WebCore::HTMLSelectElement::restoreState): Ditto. (WebCore::HTMLSelectElement::appendFormData): Ditto. (WebCore::HTMLSelectElement::optionToListIndex): Ditto. (WebCore::HTMLSelectElement::listToOptionIndex): Ditto. (WebCore::HTMLSelectElement::recalcListItems): Made const, with the appropriate fields mutable. (WebCore::HTMLSelectElement::reset): Use a const reference for the list items, so we don't have to copy the vector. Remove the call to setSelectionChanged for the RenderMenuList case. (WebCore::HTMLSelectElement::notifyOptionSelected): Ditto, on both counts. (WebCore::HTMLSelectElement::defaultEventHandler): Call focus() before showing the pop-up.
html/HTMLSelectElement.h: The RenderMenuList class is no longer a friend. Changed the listItems function to return a const reference to the vector so it no longer copies the vector. Removed the const_cast to the call to recalcListItems and changed it to a const member function. Made m_recalcListItems mutable.
rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::updateFromElement): Removed an unnecessary call to recalcListItems, which is called automatically. Use a const reference for the list items so we don't have to copy a vector. (WebCore::DeprecatedRenderSelect::layout): Ditto. (WebCore::DeprecatedRenderSelect::selectionChanged): Ditto. (WebCore::DeprecatedRenderSelect::updateSelection): Ditto.
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): Updated for renamed data members. (WebCore::RenderMenuList::createInnerBlock): Ditto. (WebCore::RenderMenuList::addChild): Ditto. (WebCore::RenderMenuList::removeChild): Ditto. (WebCore::RenderMenuList::setStyle): Ditto. Also removed code to set the style on the pop-up menu, because it's created with the correct style and destroyed before it a style change could occur. (WebCore::RenderMenuList::updateFromElement): Rearranged code to compute the maximum width in a simpler fashion, and to not bother trying to maintain the "selected" flags on the elements, since the HTMLSelectElement class takes care of that. Store the width as an int. Call setText to set the text based on the selected element's option text. (WebCore::RenderMenuList::paintObject): Don't check m_inner when setting up the clip -- always set up the clip. (WebCore::RenderMenuList::calcMinMaxWidth): Use m_optionsWidth directly instead of calling ceilf on m_longestWidth. (WebCore::RenderMenuList::showPopup): Don't use m_popupMenu to store the menu -- instead keep the pointer in a local variable. Get the selected index from the HTMLSelectElement. (WebCore::RenderMenuList::valueChanged): Call HTMLSelectElement::setSelectedIndex to do most of the work.
rendering/RenderMenuList.h: Renamed m_inner to m_innerBlock. Removed m_popupMenu, m_size, m_selectionChanged, and m_selectedIndex. Renamed m_longestWidth to m_optionsWidth and changed it to be an int. Removed unneeded override of removeLeftoverAnonymousBoxes function. Removed unneeded selectionChanged, setSelectionChanged, updateSelection, and hasPopupMenu functions. Removed extra includes.
rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Change to iterate the list items instead of iterating all children of the select node.
rendering/RenderPopupMenu.h: Renamed getRenderMenuList to menuList.
rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::populate): Moved code to clear and create the pop-up here from the caller. Removed an extra retain that would cause the NSPopUpButtonCell to leak. (WebCore::RenderPopupMenuMac::showPopup): Removed unnecessary code to create the pop-up, which is now in populate, and also the call to the clear function, for the same reason. Reorganized code to make it a bit more readable. Removed an unnecessary if to check if frame is nil. Used a RefPtr to make sure we don't make a call on a frame after it's deleted. As part of the reorganization fixed a problem where we'd retain the event and then return early without releasing it in one case. (WebCore::RenderPopupMenuMac::addSeparator): Tweaked a little. (WebCore::RenderPopupMenuMac::addGroupLabel): Grouped all the code to manage the NSMenu at the bottom of the function. (WebCore::RenderPopupMenuMac::addOption): Ditto.

7:21 PM Changeset in webkit [15366] by justing

14 edits in trunk

LayoutTests:

Reviewed by levi

<rdar://problem/4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

editing/deleting/delete-after-span-ws-001-expected.checksum:
editing/deleting/delete-after-span-ws-001-expected.png:
editing/deleting/delete-after-span-ws-002-expected.checksum:
editing/deleting/delete-after-span-ws-002-expected.png:
editing/deleting/delete-after-span-ws-003-expected.checksum:
editing/deleting/delete-after-span-ws-003-expected.png:
editing/deleting/delete-block-merge-contents-010-expected.checksum:
editing/deleting/delete-block-merge-contents-010-expected.png:
editing/deleting/merge-unrendered-space-expected.checksum:
editing/deleting/merge-unrendered-space-expected.png:

WebCore:

Reviewed by levi

<rdar://problem/4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

bridge/mac/FrameMac.mm: (WebCore::FrameMac::respondToChangedSelection): Remove markers from newAdjacentWords even if oldAdjacentWords is equal to newAdjacentWords. This happens during a deletion.

5:45 PM Changeset in webkit [15365] by thatcher

2 edits in trunk/WebCore/bindings/objc

better build fix since other projects that include DOMPrivate.h can't included JavaScriptCore/npruntime.h.

5:40 PM Changeset in webkit [15364] by tomernic

2 edits in trunk/WebCore

Reviewed by NOBODY (build fix)

bindings/objc/DOMPrivate.h: Don't @class NPObject; that breaks files that actually #import <JavaScriptCore/npruntime.h>, since the NPObject there is of a different type. Also clarified a highly misleading comment from my last commit. I meant to clarify the comment before landing.

5:27 PM Changeset in webkit [15363] by andersca

2 edits
3 adds in trunk/WebCore

2006-07-12 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9635
REGRESSION: Crash when adding to cart at <http://www.yemeksepeti.com/>

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Don't load external scripts if the parser is stopped.

manual-tests/open-close-tokenizer-crash.html: Added.
manual-tests/resources/empty-file.js: Added.
manual-tests/resources/open-close-tokenizer-crash.html: Added. Add manual test.

5:00 PM Changeset in webkit [15362] by sullivan

5 edits in trunk/WebKit

Reviewed by Kevin and Tim O

added support for creating a selection image with white text

WebView/WebDocumentPrivate.h: added -selectionImageForcingWhiteText: and -selectionImageRect to the private <WebDocumentSelection> protocol

Misc/WebSearchableTextView.m: (-[NSString selectionImageForcingWhiteText:]): added stub for this new method to this obsolete class to satisfy the compiler (-[NSString selectionImageRect]): ditto

WebView/WebHTMLView.m: (-[WebHTMLView _selectionDraggingImage]): now calls -selectionImageForcingWhiteText:NO instead of just -selectionImage (-[WebHTMLView _selectionDraggingRect]): now calls selectionImageRect, to which the implementation moved (-[WebHTMLView selectionImageForcingWhiteText:]): implemented this new method by calling through to new bridge method selectionImageForcingWhiteText: (-[WebHTMLView selectionImageRect]): implemented this new method by using existing _selectionDraggingRect implementation

WebView/WebPDFView.m: (-[WebPDFView selectionImageForcingWhiteText:]): implemented by using code that was formerly in Safari (-[WebPDFView selectionImageRect]): implemented by returning selectionRect

4:59 PM Changeset in webkit [15361] by sullivan

15 edits in trunk/WebCore

Reviewed by Kevin, Timo O, Brady, Darin, and Hyatt (whee!)

added support for creating a selection image with white text

rendering/RenderObject.h: (WebCore::): add PaintRestriction enum (WebCore::RenderObject::PaintInfo::PaintInfo): add forceWhiteText boolean to PaintInfo struct

page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): replaced m_selectionOnly bool with m_paintRestriction, which also handles forcing the text to white

page/Frame.cpp: (WebCore::Frame::paint): updated to use & pass m_paintRestriction where it used to use & pass just m_selectionOnly

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::selectionImage): now takes forceWhiteText parameter, stored in FramePrivate as part of PaintRestriction

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectionImageForcingWhiteText:]): renamed from selectionImage, now takes forceWhiteText parameter, which is passed down into Frame

rendering/RenderLayer.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): use a PaintRestriction value where we used to use a selectionOnly bool (WebCore::RenderLayer::paintLayer): ditto; also stores forceWhiteText in PaintInfo struct

kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw): updated for changed signature of PaintInfo constructor

ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): ditto

ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::drawPatternContentIntoTile): ditto

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): paint with white text color if forceWhiteText is set in PaintInfo struct

4:58 PM Changeset in webkit [15360] by tomernic

18 edits
4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Test case for <http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element

plugins/netscape-dom-access-expected.checksum: Added.
plugins/netscape-dom-access-expected.png: Added.
plugins/netscape-dom-access-expected.txt: Added.
plugins/netscape-dom-access.html: Added.

WebCore:

Reviewed by Anders.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element

html/HTMLPlugInElement.h: Just import JSC headers on Mac. The NPObject and Bindings::Instance stuff is only used on Mac anyway. Changed APPLE to PLATFORM(MAC). Added m_NPObject ivar.
html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize the NPObject. (WebCore::HTMLPlugInElement::~HTMLPlugInElement): Release the NPObject when the element is destroyed. (WebCore::HTMLPlugInElement::createNPObject): Creates an NPObject for the element. (WebCore::HTMLPlugInElement::getNPObject): Returns the NPObject for the element, creating and caching it if necessary.

html/HTMLAppletElement.h: Changed APPLE to PLATFORM(MAC).
html/HTMLAppletElement.cpp: ditto
html/HTMLEmbedElement.h: ditto
html/HTMLEmbedElement.cpp: ditto
html/HTMLObjectElement.h: ditto
html/HTMLObjectElement.cpp: ditto

bindings/objc/DOMPrivate.h: Added -[DOMElement _NPObject].

bindings/objc/DOM.mm: (-[DOMElement _NPObject]): Returns the NPObject for the element. Since this is only needed by the Netscape plug-in API, you can only get the NPObject for applet, embed, and object elements.

WebKit:

Reviewed by Geoff.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): Release DOM element. (-[WebBaseNetscapePluginView getVariable:value:]): Return NPObject for plugin DOM element.

Plugins/WebNetscapePluginEmbeddedView.h:
Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): Now takes a DOMElement, in much the same way that WebKit plug-in views take a DOMElement.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Pass DOMElement to Netscape plug-ins. (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): ditto

4:32 PM Changeset in webkit [15359] by adele

8 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9861
REGRESSION: Can't dynamically change list box to popup

fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
fast/forms/select-change-listbox-to-popup-expected.png: Added.
fast/forms/select-change-listbox-to-popup-expected.txt: Added.
fast/forms/select-change-listbox-to-popup.html: Added.
fast/forms/select-change-popup-to-listbox.html:

WebCore:

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9861 REGRESSION: Can't dynamically change list box to popup

and updated fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box

The original fix for 9859 was in the renderer, and I think we can catch the change
earlier in the element to detach and reattach.

I also did some cleanup to remove the PopupButton code path from DeprecatedRenderSelect

Test: fast/forms/select-change-listbox-to-popup.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the new attribute value is going to require us to change from listbox to popup or vice versa, and we're already attached, then detach and reattach to create the correct renderer. If we're not attached, then we'll create the correct renderer when we attach. (WebCore::HTMLSelectElement::recalcStyle): Updated shouldUseMenuList since it no longer takes a RenderStyle. (WebCore::HTMLSelectElement::isKeyboardFocusable): ditto. (WebCore::HTMLSelectElement::isMouseFocusable): ditto. (WebCore::HTMLSelectElement::createRenderer): ditto. (WebCore::HTMLSelectElement::setRecalcListItems): ditto. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::notifyOptionSelected): ditto. (WebCore::HTMLSelectElement::defaultEventHandler): ditto.

html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): This method no longer takes a RenderStyle. That was leftover from when we used to use the appearance to determine whether or not to use the new menu list implementation.

rendering/DeprecatedRenderSelect.h: Removed PopupButton code path.
rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect): (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection): (WebCore::DeprecatedRenderSelect::updateFromElement): (WebCore::DeprecatedRenderSelect::baselinePosition): (WebCore::DeprecatedRenderSelect::layout): (WebCore::DeprecatedRenderSelect::updateSelection):

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Backed out previous fix since this is now done in HTMLSelectElement.

3:35 PM Changeset in webkit [15358] by justing

5 edits
4 adds in trunk

LayoutTests:

Reviewed by levi & thatcher

<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

editing/selection/drag-to-contenteditable-iframe-expected.txt:
editing/selection/subframe-with-selection-expected.checksum: Added.
editing/selection/subframe-with-selection-expected.png: Added.
editing/selection/subframe-with-selection-expected.txt: Added.
editing/selection/subframe-with-selection.html: Added.

WebKit:

Reviewed by levi & thatcher

<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection when resigning as first responder if the selection is editable or if the WebView tells us to.
WebView/WebView.m: (-[WebView maintainsInactiveSelection]): Just because a WebView is editable doesn't mean selections inside subframes will be. Return NO by default.

3:13 PM Changeset in webkit [15357] by thatcher

1 copy in tags/WebCore-315.14.5/WebCore

Tag for WebCore 315.14.5 (part 2 of 2.)

3:13 PM Changeset in webkit [15356] by thatcher

1 add in tags/WebCore-315.14.5

Tag for WebCore 315.14.5 (part 1 of 2.)

3:13 PM Changeset in webkit [15355] by thatcher

1 delete in tags/WebCore-===

bad tag.

3:13 PM Changeset in webkit [15354] by thatcher

1 delete in tags/WebCore-315.14.4/WebCore/WebCore

bad tag.

3:12 PM Changeset in webkit [15353] by thatcher

1 copy in tags/WebCore-315.14.4/WebCore/WebCore

Tag for WebCore 315.14.4 (part 2 of 2.)

3:11 PM Changeset in webkit [15352] by thatcher

1 add in tags/WebCore-===

Tag for WebCore === (part 1 of 2.)

3:10 PM Changeset in webkit [15351] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Versioning

3:08 PM Changeset in webkit [15350] by thatcher

3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-07-06 Adele Peterson <adele@apple.com>

Reviewed by Tim Hatcher.

Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with $

khtml/khtmlview.cpp: (KHTMLView::layout): Ref's the view during layout, since a recalcStyle could cause the view to $ If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exi$
khtml/khtmlview.h: (KHTMLView::hasOneRef): Added.

2:42 PM Changeset in webkit [15349] by adele

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box

fast/forms/select-change-popup-to-listbox-expected.checksum: Added.
fast/forms/select-change-popup-to-listbox-expected.png: Added.
fast/forms/select-change-popup-to-listbox-expected.txt: Added.
fast/forms/select-change-popup-to-listbox.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box

Test: fast/forms/select-change-popup-to-listbox.html

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): If the select element has the multiple property set, or has a size > 1, then it really should be a list box, so we detach and attach the element so it creates the correct type of renderer.

2:31 PM Changeset in webkit [15348] by sullivan

2 edits in trunk/WebCore

Reviewed by Beth Dakin and Tim Omernick

fixed <rdar://problem/4622794> HiDPI: dragging the selection in Safari can show pixel cracks at non-integral scale factors

bridge/mac/FrameMac.mm: (WebCore::FrameMac::imageFromRect): round image rect in window coordinate space

2:30 PM Changeset in webkit [15347] by thatcher

1 copy in tags/WebCore-418.20.1/WebCore

New tag (part 2).

2:28 PM Changeset in webkit [15346] by thatcher

1 add in tags/WebCore-418.20.1

Tag for WebCore 418.20.1 (part 1 of 2.)

2:23 PM Changeset in webkit [15345] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning

2:08 PM Changeset in webkit [15344] by thatcher

2 edits in tags/WebKit-521.16.1/WebKit

Build fix.

2:06 PM Changeset in webkit [15343] by thatcher

1 copy in tags/WebKit-521.16.1/WebKit

New tag (part 2)

2:05 PM Changeset in webkit [15342] by thatcher

1 add in tags/WebKit-521.16.1

New tag.

1:58 PM Changeset in webkit [15341] by tomernic

2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/4622748> WebKit now uses deprecated AGL functions

Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _createWindowedAGLContext]): aglSetDrawable() is deprecated in AGL 3.0. Use aglSetWindowRef() instead. (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): aglSetOffScreen() is deprecated in AGL 3.0. Use CGLSetOffScreen(), which does the same thing.

12:07 PM Changeset in webkit [15340] by ap

1 edit
2 adds in trunk/LayoutTests

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9572 Add application/xhtml+xml to the Accept header

The fix itself was landed on 2006-07-09, but I forgot about the test.

http/tests/misc/xhtml-expected.txt: Added.
http/tests/misc/xhtml.php: Added.

11:54 AM Changeset in webkit [15339] by bdakin

4 edits in trunk/LayoutTests

Reviewed by Adele.

Adele checked in new results for this test when you could style
selects, but the styling of selects is turned off for now, so back
to the original results.

fast/forms/001-expected.checksum:
fast/forms/001-expected.png:
fast/forms/001-expected.txt:

11:40 AM Changeset in webkit [15338] by thatcher

1 edit in trunk/WebCore/ChangeLog

Adding the radar to a change.

11:21 AM Changeset in webkit [15337] by ap

5 edits
2 adds in trunk

Reviewed by Tim O.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7808 Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL

WebKit:

Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): Remove the early return when requesting an invalid (unsupported) URL.

WebKitTools:

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): treat getURL() with one parameter as if the second parameter were NULL - should open a new stream and deliver the data to the current instance.

LayoutTests:

plugins/get-empty-url-expected.txt: Added.
plugins/get-empty-url.html: Added.

11:13 AM Changeset in webkit [15336] by thatcher

6 edits
4 adds in trunk/WebKitTools

Reviewed by Darin.

Bug 9598: [Drosera] add a JavaScript evaluator console
http://bugzilla.opendarwin.org/show_bug.cgi?id=9598

Drosera/DebuggerApplication.h:
Drosera/DebuggerApplication.m: (-[DebuggerApplication knownServers]):
Drosera/DebuggerDocument.h:
Drosera/DebuggerDocument.m: (-[WebScriptObject evaluateScript:inCallFrame:]): (-[WebScriptObject showConsole:]): (-[WebScriptObject toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[WebScriptObject toolbarDefaultItemIdentifiers:]): (-[WebScriptObject toolbarAllowedItemIdentifiers:]): (-[WebScriptObject webView:createWebViewWithRequest:]): (-[WebScriptObject webViewShow:]): (-[WebScriptObject webViewAreToolbarsVisible:]): (-[WebScriptObject webView:setToolbarsVisible:]): (-[WebScriptObject webView:setResizable:]): (-[WebScriptObject webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): (-[WebScriptObject scriptConfirmSheetDidEnd:returnCode:contextInfo:]): (-[WebScriptObject webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): (-[WebScriptObject webView:windowScriptObjectAvailable:]): (-[WebScriptObject webView:didFinishLoadForFrame:]): (-[WebScriptObject webView:didReceiveTitle:forFrame:]):
Drosera/Drosera.xcodeproj/project.pbxproj:
Drosera/Images/console.png: Added.
Drosera/console.css: Added.
Drosera/console.html: Added.
Drosera/console.js: Added.

11:02 AM Changeset in webkit [15335] by spadma

2 edits
1 add in S60/trunk/WebKit

2006-07-11 zalan <zbujtas@gmail.com>

Reviewed by Sachin/David. Fix for:

http://bugzilla.opendarwin.org/show_bug.cgi?id=9401

Fix resource file directories. Missing #include <data_caging_paths.hrh>

8:00 AM Changeset in webkit [15334] by zbujtas

2 edits in S60/trunk

2006-07-07 brmorris <bradley.morrison@nokia.com>

Reviewed by zbujtas@gmail.com.

S60Internals/S60Headers.zip: data_caging_paths to \epoc32\include

Fix for:

http://bugzilla.opendarwin.org/show_bug.cgi?id=9776

7:21 AM Changeset in webkit [15333] by zbujtas

2 edits in S60/trunk

2006-07-07 brmorris <bradley.morrison@nokia.com>

Reviewed by zbujtas@gmail.com

build.bat: Now supports SDK 3rd ed maintenance release. Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9512

12:51 AM Changeset in webkit [15332] by thatcher

5 edits in trunk/WebKitTools

Reviewed by a tired Geoff.

Bug 9597: [Drosera] hook up the variables table to show stack variables
http://bugzilla.opendarwin.org/show_bug.cgi?id=9597

Drosera/DebuggerDocument.m: (-[WebScriptObject isSelectorExcludedFromWebScript:]): (-[WebScriptObject webScriptAttributeKeysForScriptObject:]): (-[WebScriptObject localScopeVariableNamesForCallFrame:]): (-[WebScriptObject valueForScopeVariableNamed:inCallFrame:]): (-[WebScriptObject webView:didReceiveTitle:forFrame:]): (-[WebScriptObject webView:didLoadMainResourceForDataSource:]): (-[WebScriptObject webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptObject webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptObject webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptObject webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
Drosera/debugger.css:
Drosera/debugger.html:
Drosera/debugger.js:

12:30 AM Changeset in webkit [15331] by tomernic

2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=9844>:
Add DOM access test to DumpRenderTree's Netscape plug-in

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (testDOMAccess): (pluginInvoke):

Jul 10, 2006:

11:04 PM Changeset in webkit [15330] by darin

3 edits in trunk/WebCore

Reviewed by Geoff.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9811 rdar://problem/4619572 OPTION text contained in OPTGROUP appears at the wrong size

dom/Node.h:
dom/Node.cpp: (WebCore::Node::renderStyle): Made a const member function. The derived classes were overriding with const member functions, and I could change either this or the derived -- decided to do this.

10:48 PM Changeset in webkit [15329] by darin

3 edits in trunk/WebCore

Reviewed by Geoff.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9810 OPTGROUP label text is using the default font instead of Lucida Grande

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Code wants the family name, but was calling fontName, which is not the same thing. Also removed the unneeded conversion to DeprecatedString.

10:37 PM Changeset in webkit [15328] by ggaren

10 edits in trunk/JavaScriptCore

Reviewed by Darin.

Changed public header includes to the <JavaScriptCore/ style.
Changed instances of 'buffer' to 'string' since we decided on JSInternalString instead of JSStringBuffer.

API/JSContextRef.h:
API/JSInternalStringRef.cpp: (JSStringMake): (JSInternalStringRetain): (JSInternalStringRelease): (JSValueCopyStringValue): (JSInternalStringGetLength): (JSInternalStringGetCharactersPtr): (JSInternalStringGetCharacters): (JSInternalStringGetMaxLengthUTF8): (JSInternalStringGetCharactersUTF8): (CFStringCreateWithJSInternalString):
API/JSInternalStringRef.h:
API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType):
API/JSObjectRef.cpp: (JSObjectCallAsConstructor):
API/JSValueRef.h:
API/JavaScriptCore.h:
API/minidom.c: (main): (print):
API/testapi.c: (MyObject_getPropertyList): (myConstructor_callAsConstructor): (main): I noticed that we were prematurely releasing some string buffers, so I moved their release calls to the end of main(). I got rid of 'Buf' in *Buf (sometimes changing to 'IString', when necessary to differentiate a variable) to match the buffer->string change.

9:36 PM Changeset in webkit [15327] by ddkilzer

2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9839 Bug 9839: Nightly launcher fails to detect extensions when extension causes crash on load

Now track three states: initializing, running, and closed. If we are launched and the previous
state was initializing then we likely just experienced a crash on launch.

WebKitLauncher/WebKitNightlyEnabler.m: (myApplicationWillFinishLaunching): Improve wording of dialog. Update to set new running state. (myApplicationWillTerminate): Update to use new states. (cleanUpAfterOurselves): Display alert if previous state was initializing. Set state as initializing as early as practical. (symbol_lookup): Bring code up to speed with formatting guidelines. (GDSymbolLookup): Ditto.

8:40 PM Changeset in webkit [15326] by thatcher

5 copies in tags/Safari-521.16

New tag.

8:37 PM Changeset in webkit [15325] by darin

2 edits in trunk/JavaScriptCore

kjs/value.cpp: (KJS::JSValue::toInt32Inline): Added inline keyword one more place. Just in case.

8:36 PM Changeset in webkit [15324] by thatcher

1 edit in trunk/JavaScriptCore/ChangeLog

Move the release tag.

8:34 PM Changeset in webkit [15323] by darin

3 edits in trunk/JavaScriptCore

fix the release build

kjs/value.h:
kjs/value.cpp: (KJS::JSValue::toInt32Inline): Move the code here to an inline. (KJS::JSValue::toInt32): Call the inline from both overloaded toInt32 functions.

8:33 PM Changeset in webkit [15322] by thatcher

6 edits in /

Versioning

8:16 PM Changeset in webkit [15321] by ddkilzer

20 edits
6 adds in trunk

JavaScriptCore:

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Implement select.options.add() method

JavaScriptCore.exp: Added overloaded KJS::JSValue::toInt32() method.
JavaScriptCore.xcodeproj/project.pbxproj: Altered attributes metadata for kjs/value.h to make it available as a forwarded header.
kjs/lookup.h: (KJS::lookupPut): Extracted a lookupPut() method from the existing lookupPut() method. The new method returns a boolean value if no entry is found in the lookup table.
kjs/value.cpp: (KJS::JSValue::toInt32): Overloaded toInt32() method with boolean "Ok" argument.
kjs/value.h: Ditto.

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Implement select.options.add() method

fast/dom/select-selectedIndex-multiple-expected.txt: Updated test results.
fast/dom/select-selectedIndex-multiple.html: Updated to print comments between tests to make failures easier to track down.
fast/dom/select-selectedIndex-expected.txt: Mirrored updates from select-selectedIndex-multiple.html
fast/dom/select-selectedIndex.html: Ditto.
fast/js/resources/select-options-add.js: Added.
fast/js/select-options-add-expected.txt: Added.
fast/js/select-options-add.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Implement select.options.add() method

Tests:

fast/dom/select-selectedIndex-multiple.html
fast/dom/select-selectedIndex.html
fast/js/select-options-add.html

DerivedSources.make: Added JSHTMLOptionsCollection.h.
ForwardingHeaders/kjs/operations.h: Added.
WebCore.xcodeproj/project.pbxproj: Added new source files.
bindings/js/JSHTMLOptionsCollectionCustom.cpp: Added. (WebCore::JSHTMLOptionsCollection::length): (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::indexSetter):
bindings/js/kjs_html.cpp: Removed JSHTMLOptionsCollection implementation. Renamed classes and methods for consistency. (KJS::JSHTMLElement::selectGetter): (KJS::JSHTMLElement::put): (KJS::JSHTMLElement::selectSetter): (KJS::JSHTMLCollection::JSHTMLCollection): (KJS::JSHTMLCollectionProtoFunc::callAsFunction): (KJS::getHTMLOptionsCollection):
bindings/js/kjs_html.h: Ditto.
bindings/scripts/CodeGeneratorJS.pm: Added support for HasCustomIndexSetter class attribute. Added support for Optional parameter attribute, which makes generated code assume overloaded implementation methods are available for a JavaScript function with optional arguments. Changed local 'impl' variables to 'imp' so that impl() methods could be called without class designation.
html/HTMLOptionElement.idl: Added GenerateNativeConverter attribute.
html/HTMLOptionsCollection.cpp: Added methods used by generated JSHTMLOptionsCollection class. (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): (WebCore::HTMLOptionsCollection::add): (WebCore::HTMLOptionsCollection::selectedIndex): (WebCore::HTMLOptionsCollection::setSelectedIndex): (WebCore::HTMLOptionsCollection::setLength):
html/HTMLOptionsCollection.h: Ditto.
html/HTMLOptionsCollection.idl: Added.

7:02 PM Changeset in webkit [15320] by harrison

6 edits in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/4602408> -webkit-highlight needs to support images and elements other than text

rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
rendering/RenderBox.h: Utility for subclasses.

rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Custom highlight in front of images.

rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): Custom highlight in front of list markers.

rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Custom highlight in front of objects.

6:22 PM Changeset in webkit [15319] by hyatt

6 edits in trunk/WebCore

Better fix for repainting issue with positioned objects when height
changes. Optimize when only a positioned child changes so that we don't
incorrectly do normal flow layout.

Reviewed by darin

WebCore.xcodeproj/project.pbxproj:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
rendering/RenderView.cpp: (WebCore::RenderView::layout):
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

5:27 PM Changeset in webkit [15318] by ggaren

1 edit
1 delete in trunk/JavaScriptCore

No review necessary. Removed bogus file I accidentally checked in before.

API/JSInternalSringRef.h: Removed.

5:26 PM Changeset in webkit [15317] by ggaren

15 edits in trunk/JavaScriptCore

Reviewed by Darin.

Added exception out parameter to API object callbacks, removed semi-bogus
JSContext(.*)Exception functions.

To make these calls syntactically simple, I added an exceptionSlot()
method to the ExecState class, which provides a JSValue slot in which to
store a JSValue* exception.

API/APICast.h: (toRef):
API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
API/JSContextRef.cpp: (JSCheckSyntax):
API/JSContextRef.h:
API/JSNode.c: (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild): (JSNode_construct):
API/JSNode.h:
API/JSNodeList.c: (JSNodeListPrototype_item): (JSNodeList_length): (JSNodeList_getProperty):
API/JSObjectRef.h:
API/minidom.c: (print):
API/testapi.c: (MyObject_initialize): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_callAsFunction): (MyObject_callAsConstructor): (MyObject_convertToType): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
JavaScriptCore.exp:
kjs/ExecState.h: (KJS::ExecState::exceptionHandle):

4:52 PM Changeset in webkit [15316] by adele

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Beth.

Test for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com

fast/forms/select-style-expected.checksum: Added.
fast/forms/select-style-expected.png: Added.
fast/forms/select-style-expected.txt: Added.
fast/forms/select-style.html: Added.

WebCore:

Reviewed by Beth.

Fix for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com

Test: fast/forms/select-style.html

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled): Don't let popups be style-able for now. We'll allow it later, when we have a good way to handle border & backgrounds and still having it look like a control.

4:50 PM Changeset in webkit [15315] by sullivan

2 edits in trunk/WebKit

Reviewed by John Sullivan.

fix <rdar://problem/4621541>, aka <http://bugzilla.opendarwin.org/show_bug.cgi?id=9838> REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache

WebView/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]): Set our data only if the frame loader is has just loaded it (when coming from the back/forward cache, it hasn't).

3:29 PM Changeset in webkit [15314] by justing

3 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4619260>
9A213 + Safari 521.15.1 Crash with To Do's alarm icon (WebCore::maxDeepOffset(WebCore::Node const*) )
<rdar://problem/4619841>
REGRESSION: Dragging selection over input field results in a crash (WebCore::maxDeepOffset(WebCore::Node const*)

WebCore.xcodeproj/project.pbxproj:
editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Iterate using next/previousVisuallyDistinctCandidate instead of traverseNext/Previous node because we were skipping positions. Jump out of shadow trees. Migrate to isEditablePosition instead of isContentEditable.

3:25 PM Changeset in webkit [15313] by bdakin

3 edits in trunk/WebCore

Reviewed by Adele.

Shuffling comments around from my last check-in to make things read
more clearly.

page/DOMWindow.h:
page/DOMWindow.idl:

3:05 PM Changeset in webkit [15312] by bdakin

5 edits
4 adds in trunk

Reviewed by Darin.

Fix for <rdar://problem/4621095> The should be a way to
access the user interface scale factor through the DOM

window.devicePixelRatio returns the user interface scale factor.

page/DOMWindow.cpp: (WebCore::DOMWindow::devicePixelRatio):
page/DOMWindow.h:
page/DOMWindow.idl:

2:39 PM Changeset in webkit [15311] by spadma

8 edits in S60/trunk

2006-07-10 David Carson <david.carson@nokia.com>

Reviewed by Sachin/Zalan.

Fix for network connection, remove use of InternetConnectionManager
http://bugzilla.opendarwin.org/show_bug.cgi?id=9451

WebKit\BrowserView\src\HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequest) Added check fo NULL pointer as aConnectionPtr could be null after the cb

S60WebUi\WebUi\src\WebUiSessionAndSecurity.cpp
S60WebUi\WebUi\inc\WebUiSessionAndSecurity.h Removed dependancy on InternetConnectionManager, and removed ShowSessionInfo as the information is available from the Connection Manager application. Constructor no longer takes a InternetConnectionManager reference.

S60WebUi\WebUi\data\WebUi.rss
S60WebUi\WebUi\inc\WebUi.hrh Removed ShowSessionInfo menu option

S60WebUi\WebUi\src\WebUiWindowContainer.cpp
- S60WebUi\WebUi\inc\WebUiWindowContainer.h (CWebUiWindowContainer::HandleCommandL): Removed ShowSessionInfo option (CWebUiWindowContainer::NetworkConnectionNeededL): Made function empty as Symbian default handler does the work.

2:17 PM Changeset in webkit [15310] by ggaren

13 edits in trunk/JavaScriptCore

Reviewed by Darin.

Improved type safety by implementing opaque JSValue/JSObject typing through
abuse of 'const', not void*. Also fixed an alarming number of bugs
exposed by this new type safety.

I made one design change in JavaScriptCore, which is that the JSObject
constructor should take a JSValue* as its prototype argument, not a JSObject*,
since we allow the prototype to be any JSValue*, including jsNull(), for
example.

API/APICast.h: (toJS):
API/JSBase.h:
API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::staticFunctionGetter):
API/JSCallbackObject.h:
API/JSContextRef.cpp: (JSEvaluate):
API/JSNode.c: (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild):
API/JSObjectRef.cpp: (JSObjectMake): (JSFunctionMakeWithBody): (JSObjectGetProperty): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
API/JSObjectRef.h:
API/testapi.c: (main):
ChangeLog:
kjs/object.h: (KJS::JSObject::JSObject):

1:53 PM Changeset in webkit [15309] by adele

37 edits in trunk/LayoutTests

http://bugzilla.opendarwin.org/show_bug.cgi?id=9830
More pixel test results need updating since switching to native popup

editing/selection/replaced-boundaries-3-expected.checksum:
editing/selection/replaced-boundaries-3-expected.png:
fast/block/margin-collapse/103-expected.checksum:
fast/block/margin-collapse/103-expected.png:
fast/forms/001-expected.checksum:
fast/forms/001-expected.png:
fast/forms/HTMLOptionElement_label01-expected.checksum:
fast/forms/HTMLOptionElement_label01-expected.png:
fast/forms/HTMLOptionElement_label02-expected.checksum:
fast/forms/HTMLOptionElement_label02-expected.png:
fast/forms/HTMLOptionElement_label03-expected.checksum:
fast/forms/HTMLOptionElement_label03-expected.png:
fast/forms/HTMLOptionElement_label04-expected.checksum:
fast/forms/HTMLOptionElement_label04-expected.png:
fast/forms/form-element-geometry-expected.checksum:
fast/forms/form-element-geometry-expected.png:
fast/forms/option-script-expected.checksum:
fast/forms/option-script-expected.png:
fast/forms/option-strip-whitespace-expected.checksum:
fast/forms/option-strip-whitespace-expected.png:
fast/invalid/014-expected.checksum:
fast/invalid/014-expected.png:
fast/parser/document-write-option-expected.checksum:
fast/parser/document-write-option-expected.png:
tables/mozilla/bugs/bug2479-3-expected.checksum:
tables/mozilla/bugs/bug2479-3-expected.png:
tables/mozilla/bugs/bug29326-expected.checksum:
tables/mozilla/bugs/bug29326-expected.png:
tables/mozilla/bugs/bug33855-expected.checksum:
tables/mozilla/bugs/bug33855-expected.png:
tables/mozilla/bugs/bug96334-expected.checksum:
tables/mozilla/bugs/bug96334-expected.png:
tables/mozilla/core/margins-expected.checksum:
tables/mozilla/core/margins-expected.png:
tables/mozilla/dom/tableDom-expected.checksum:
tables/mozilla/dom/tableDom-expected.png:

10:47 AM Changeset in webkit [15308] by beidson

4 edits in trunk

WebCore:

Reviewed by Alexey

Resolved the console error messages people got from the new DB even if they didn't have it enabled

icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnreferencedIcons): (WebCore::IconDatabase::pruneUnretainedIcons): Added quick check to bail if the DB isn't open

WebKit:

Reviewed by Alexey

Resolved the console error messages people got from the new DB even if they didn't have it enabled

Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Disabled initializing the IconDatabaseBridge if user is living on the old DB

10:41 AM Changeset in webkit [15307] by ggaren

16 edits
1 copy
2 moves in trunk/JavaScriptCore

Approved by Maciej, Darin.

Renamed JSStringBufferRef to JSInternalStringRef. "Internal string" means the
JavaScript engine's internal string representation, which is the most
low-level and efficient representation to use when interfacing with JavaScript.

API/APICast.h: (toJS): (toRef):
API/JSBase.h:
API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
API/JSContextRef.cpp: (JSEvaluate): (JSCheckSyntax):
API/JSContextRef.h:
API/JSInternalStringRef.cpp: Added. (JSStringMake): (JSInternalStringCreate): (JSInternalStringCreateUTF8): (JSInternalStringRetain): (JSInternalStringRelease): (JSValueCopyStringValue): (JSInternalStringGetLength): (JSInternalStringGetCharactersPtr): (JSInternalStringGetCharacters): (JSInternalStringGetMaxLengthUTF8): (JSInternalStringGetCharactersUTF8): (JSInternalStringIsEqual): (JSInternalStringIsEqualUTF8): (JSInternalStringCreateCF): (CFStringCreateWithJSInternalString):
API/JSInternalStringRef.h: Added.
API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild):
API/JSNodeList.c: (JSNodeList_length): (JSNodeList_getProperty):
API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectGetDescription): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSPropertyEnumeratorGetNext): (JSPropertyListAdd):
API/JSObjectRef.h:
API/JSStringBufferRef.cpp: Removed.
API/JSStringBufferRef.h: Removed.
API/JSValueRef.h:
API/JavaScriptCore.h:
API/minidom.c: (main): (print):
API/testapi.c: (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:

9:48 AM Changeset in webkit [15306] by harrison

2 edits in trunk/WebCore

9:18 AM Changeset in webkit [15305] by darin

2 edits
1 add in trunk/WebCore

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9808 REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text

manual-tests/ATSU-bad-layout.html: Added.
platform/mac/FontMac.mm: (WebCore::Font::floatWidthForComplexText): Return 0 immediately for empty runs.

8:54 AM Changeset in webkit [15304] by darin

2 edits in trunk/WebCore

try to fix the no-SVG build

ksvg2/misc/SVGImageLoader.cpp: Move namespace brace inside the #if.

8:53 AM Changeset in webkit [15303] by darin

3 edits
1 add in trunk/WebCore

Reviewed by Anders.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9833 REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first'

manual-tests/empty-title-popup.html: Added.

rendering/RenderMenuList.h: Add createInnerBlock.
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createInnerBlock): Factored out of addChild. (WebCore::RenderMenuList::addChild): Call createInnerBlock. (WebCore::RenderMenuList::setText): Changed parameter type. (WebCore::RenderMenuList::showPopup): Call createInnerBlock before calling the parent class's addChild.

8:34 AM Changeset in webkit [15302] by darin

2 edits in trunk/WebKitTools

try to fix Windows build

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove include paths with "khtml" in them. Add one for "html" subdir or WebCore.

8:00 AM Changeset in webkit [15301] by darin

2 edits in trunk/LayoutTests

tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Updated one more result for Adele's 4463835 change last night.

5:57 AM Changeset in webkit [15300] by ddkilzer

3 edits in trunk/WebCore

WebCore:

Reviewed by Maciej via IRC. Patch by Rob Buis.

Make sure the attributes are calculated against viewport width value,
as defined in the spec. http://paste.lisp.org/display/22342

ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::rx): Changed LM_HEIGHT to LM_WIDTH.
ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::x2): Ditto.

4:39 AM Changeset in webkit [15299] by bdakin

10 edits
13 adds in trunk

Reviewed by Maciej.

Fix for <rdar://problem/4610314> Support the CSS3 content property
for images

This patch provides initial support for the CSS3 content property.
It lacks support for any content other than images, and only allows
content for elements that seemed safe for now.

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove restrictions for just :before and :after
html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::createRenderer):
html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::createRenderer):
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createRenderer):
html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::createRenderer):
rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::setCachedImage): Don't allow the image to be set this way if it was already set with the content property.
rendering/RenderImage.h: (WebCore::RenderImage::setIsAnonymousImage): Anonymous images are those set through the content property. (WebCore::RenderImage::isAnonymousImage):
rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): If there is content specified, create a RenderImage with the content and initialize the cached image to whatever was specified in the CSS.

3:31 AM Changeset in webkit [15298] by beidson

2 edits in trunk/WebCore

Reviewed by NOBODY (Build Fix!)

icon/SiteIcon.cpp: (SiteIcon::getImage): Release build made an "unused variable" warning, which is, of course, an error. fixed that.

2:57 AM Changeset in webkit [15297] by beidson

4 edits in trunk/WebCore

Reviewed by Maciej

SQLite Icon DB now fully replicates functionality of the old DB, including pruning to keep unused
information out to keep down disk usage. For now, it is still off by default, as the critical
feature of importing old icons into the new DB is still unrealized.
If you'd like to test, add #define ICONDEBUG to your WebKitPrefix.h

icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): -Sets up a timer for initial pruning (WebCore::IconDatabase::iconForPageURL): -Switched away from "dirty blob hack" as the problem is provisionally solved (WebCore::IconDatabase::retainIconForURL): (WebCore::IconDatabase::releaseIconForURL): -Same as found in WebKit (WebCore::IconDatabase::totalRetainCountForIconURL): -Adds up all retainers of icon (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): -Wipes an Icon table entry out (WebCore::IconDatabase::establishTemporaryIconIDForIconURL): (WebCore::IconDatabase::establishTemporaryIconIDForEscapedIconURL): (WebCore::IconDatabase::establishIconIDForIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): -Added ability to get an iconID without creating a new one if a lookup is all

that is genuinely wanted

(WebCore::IconDatabase::pruneUnreferencedIcons):
(WebCore::IconDatabase::pruneUnretainedIcons):

-Called on a timer on DB startup to clean it out

icon/IconDatabase.h:
icon/SiteIcon.cpp: (SiteIcon::SiteIcon): (SiteIcon::~SiteIcon): -Deletes the image on deletion (SiteIcon::getImage): -Cut down on no-longer-necessary debug info

2:02 AM Changeset in webkit [15296] by andersca

4 edits
2 adds in trunk

WebCore:

2006-07-10 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adele.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9245
Quirksmode: Incorrect handling of disabled BUTTON elements

html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't call prepareSubmit if the element is disabled.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Don't call prepareSubmit if the element is disabled.

LayoutTest:

2006-07-09 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adele.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9245
Quirksmode: Incorrect handling of disabled BUTTON elements

fast/forms/activate-and-disabled-elements-expected.txt: Added.
fast/forms/activate-and-disabled-elements.html: Added.

1:01 AM Changeset in webkit [15295] by darin

3 edits in trunk/WebCore

try to fix Windows build

platform/win/TemporaryLinkStubs.cpp: Put a few functions in the WebCore namespace.
platform/gdk/TemporaryLinkStubs.cpp: Ditto.

12:59 AM Changeset in webkit [15294] by darin

2 edits in trunk/WebCore

Reviewed by Geoff.

fix failures seen in layout tests

bindings/js/kjs_dom.cpp: (KJS::toJS): Restore one of the few WebCore:: prefixes that really needed to be there -- because we have two classes named JSHTMLDocument at the moment! (One in KJS and one in WebCore namespace.)

12:40 AM Changeset in webkit [15293] by darin

2 edits in trunk/WebCore

try to fix Windows build

rendering/RenderLayer.h: Correct a forward declaration of ScrollBar.

12:33 AM Changeset in webkit [15292] by darin

2 edits in trunk/WebKit

try to fix Windows build

COM/WebFrame.h: Qualify DeprecatedString and KURL with WebCore:: prefixes.

12:19 AM Changeset in webkit [15291] by adele

1 edit in trunk/LayoutTests/ChangeLog

Reviewed by Maciej.

Updated results for:
<rdar://problem/4463835> Switch to use new popup menu implementation for <select>

editing/selection/replaced-boundaries-3-expected.txt:
editing/selection/select-box-expected.txt:
fast/block/margin-collapse/103-expected.txt:
fast/dom/option-properties-expected.txt:
fast/forms/003-expected.txt:
fast/forms/004-expected.txt:
fast/forms/HTMLOptionElement_label01-expected.txt:
fast/forms/HTMLOptionElement_label02-expected.txt:
fast/forms/HTMLOptionElement_label03-expected.txt:
fast/forms/HTMLOptionElement_label04-expected.txt:
fast/forms/HTMLOptionElement_label06-expected.txt:
fast/forms/HTMLOptionElement_label07-expected.txt:
fast/forms/form-element-geometry-expected.txt:
fast/forms/option-script-expected.txt:
fast/forms/option-strip-whitespace-expected.txt:
fast/forms/select-remove-option-expected.txt:
fast/forms/select-replace-option-expected.txt:
fast/forms/select-reset-expected.txt:
fast/invalid/014-expected.txt:
fast/parser/document-write-option-expected.txt:
fast/replaced/width100percent-expected.txt:
tables/mozilla/bugs/bug1188-expected.txt:
tables/mozilla/bugs/bug18359-expected.txt:
tables/mozilla/bugs/bug2479-3-expected.txt:
tables/mozilla/bugs/bug2479-4-expected.txt:
tables/mozilla/bugs/bug29326-expected.txt:
tables/mozilla/bugs/bug33855-expected.txt:
tables/mozilla/bugs/bug4382-expected.txt:
tables/mozilla/bugs/bug96334-expected.txt:
tables/mozilla/core/margins-expected.txt:
tables/mozilla/dom/tableDom-expected.txt:

12:19 AM Changeset in webkit [15290] by adele

41 edits in trunk

Reviewed by Maciej.

Fix for <rdar://problem/4463835> Switch to use new popup menu implementation for <select>

css/html4.css: Added style for new selects, and for list boxes.
html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Removed check for appearance so new popups can be styled.

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Removed padding. This is now set by the theme. (WebCore::RenderMenuList::calcMinMaxWidth): Now takes minimum text size into account.
rendering/RenderMenuList.h: Removed baselinePosition since we're letting the theme calculate that.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlContainer): Added menuList as a ControlContainer, so RenderThemeMac will compute its baseline.
rendering/RenderTheme.h: (WebCore::RenderTheme::minimumTextSize): Added.
rendering/RenderThemeMac.h: Added minimumTextSize, setPopupPaddingFromControlSize, popupButtonSizes, popupButtonMargins, popupButtonPadding. Removed sizeOfArrowControl.
rendering/RenderThemeMac.mm: (WebCore::): Added enum for padding. (WebCore::RenderThemeMac::adjustRepaintRect): Now inflates rect to account for control shadow. (WebCore::RenderThemeMac::baselinePosition): Now calculates baseline for menulist. (WebCore::RenderThemeMac::popupButtonMargins): Tweaked values. (WebCore::RenderThemeMac::popupButtonSizes): Added. (WebCore::RenderThemeMac::popupButtonPadding): Added, so different padding can be set for different control sizes. (WebCore::RenderThemeMac::setPopupPaddingFromControlSize): Added. (WebCore::RenderThemeMac::paintMenuList): Now inflates rect to account for control shadow. (WebCore::RenderThemeMac::adjustMenuListStyle): Resets border, sets padding, sets control size. (WebCore::RenderThemeMac::setPopupButtonCellState): Removed unnecessary class name. (WebCore::RenderThemeMac::minimumTextSize): Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed