⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 14, 2006:

11:53 PM Changeset in webkit [15449] by ap
  • 9 edits
    2 copies
    12 adds
    3 deletes in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4195
REGRESSION: KOI8-U encoding no longer supported.

Tests:

  • http/tests/misc/BOM-override.pl
  • http/tests/misc/BOM-override-script.html
  • fast/encoding/charset-koi8-u.html
  • fast/encoding/charset-x-nextstep.html

Restored a TEC code path for encodings that are not supported by ICU (but which currently
passes all layout tests even by itself with ICU disabled). A lot of refactoring is
still needed - most importantly, round-tripping encoding names via CFStringEncoding
makes little sense now.

  • WebCore.exp:
  • bridge/mac/WebCoreTextDecoder.h: Removed.
  • bridge/mac/WebCoreTextDecoder.mm: Removed. WebCoreTextDecoder was not used anywhere since WebTextView was moved into WebCore.
  • loader/Decoder.cpp: (Decoder::Decoder): (Decoder::setEncodingName): (Decoder::decode): Use StreamingTextDecoder::create().
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::create): (WebCore::StreamingTextDecoder::~StreamingTextDecoder):
  • platform/StreamingTextDecoder.h: StreamingTextDecoder is just an abstract interface to implementations now.
  • platform/StreamingTextDecoderICU.cpp: Added. (WebCore::StreamingTextDecoderICU::StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::~StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::releaseICUConverter): (WebCore::StreamingTextDecoderICU::textEncodingSupported): (WebCore::StreamingTextDecoderICU::convertUTF16): (WebCore::StreamingTextDecoderICU::convertIfASCII): (WebCore::StreamingTextDecoderICU::createICUConverter): (WebCore::StreamingTextDecoderICU::appendOmittingBOM): (WebCore::StreamingTextDecoderICU::convertUsingICU): (WebCore::StreamingTextDecoderICU::convert): (WebCore::StreamingTextDecoderICU::toUnicode): (WebCore::StreamingTextDecoderICU::fromUnicode):
  • platform/StreamingTextDecoderICU.h: Added. Renamed from StreamingTextDecoder; added a way to tell whether the encoding is actually supported by the decoder; minor cleanup.
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::effectiveEncoding): Moved from StreamingTextDecoder. (WebCore::TextEncoding::toUnicode): Use StreamingTextDecoder::create(). (WebCore::TextEncoding::fromUnicode): Moved to StreamingTextDecoderICU.


  • platform/TextEncoding.h: Changed APPLE to PLATFORM(MAC); added effectiveEncoding().
  • platform/mac/StreamingTextDecoderMac.cpp: Added. (WebCore::StreamingTextDecoderMac::StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::~StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::releaseTECConverter): (WebCore::StreamingTextDecoderMac::textEncodingSupported): (WebCore::StreamingTextDecoderMac::convertUTF16): (WebCore::StreamingTextDecoderMac::convertIfASCII): (WebCore::StreamingTextDecoderMac::createTECConverter): (WebCore::StreamingTextDecoderMac::appendOmittingBOM): (WebCore::StreamingTextDecoderMac::convertOneChunkUsingTEC): (WebCore::StreamingTextDecoderMac::convertUsingTEC): (WebCore::StreamingTextDecoderMac::convert): (WebCore::StreamingTextDecoderMac::toUnicode): (WebCore::StreamingTextDecoderMac::fromUnicode):
  • platform/mac/StreamingTextDecoderMac.h: Added. (WebCore::StreamingTextDecoderMac::convert): This is a TEC+CFString code path for decoding, basically restored from a year-old revision.
  • platform/mac/TextEncodingMac.cpp: Removed. Code moved to StreamingTextDecoderMac.
  • WebCore.xcodeproj/project.pbxproj:
11:37 PM Changeset in webkit [15448] by thatcher
  • 2 edits in tags/JavaScriptCore-521.17.1/JavaScriptCore

Build fix and versioning.

11:36 PM Changeset in webkit [15447] by thatcher
  • 1 copy in tags/JavaScriptCore-521.17.1/JavaScriptCore

New tag (part 2)

11:35 PM Changeset in webkit [15446] by thatcher
  • 1 add in tags/JavaScriptCore-521.17.1

new tag.

11:32 PM Changeset in webkit [15445] by thatcher
  • 1 edit in trunk/JavaScriptCore/API/JSBase.cpp

Build fix for case-sensitive file systems.

9:16 PM Changeset in webkit [15444] by ggaren
  • 11 edits in trunk/JavaScriptCore

RS by Maciej.


Global replace in the API of argc/argv with argumentCount/arguments.

9:10 PM Changeset in webkit [15443] by ggaren
  • 11 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Finalized exception handling in the API.


setProperty can throw because it throws for built-in arrays. getProperty
and deleteProperty can throw because setProperty can throw and we want
to be consistent, and also because they seem like "actions." callAsFunction,
callAsConstructor, and hasInstance can throw, because they caan throw for
all built-ins.


toBoolean can't throw because it's defined that way in the spec.


  • Documented that toBoolean and toObject can't be overridden by custom objects because they're defined that way in the spec.
7:32 PM Changeset in webkit [15442] by thatcher
  • 5 copies in tags/Safari-521.17

New tag.

7:25 PM Changeset in webkit [15441] by thatcher
  • 5 edits
    4 deletes in trunk

LayoutTests:

Rolling out this fix from r15358 since it isn't resolved.

2006-07-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by levi & thatcher

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/subframe-with-selection-expected.checksum: Added.
  • editing/selection/subframe-with-selection-expected.png: Added.
  • editing/selection/subframe-with-selection-expected.txt: Added.
  • editing/selection/subframe-with-selection.html: Added.

WebKit:

Rolling out this fix from r15358 since it isn't resolved.

2006-07-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by levi & thatcher

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection when resigning as first responder if the selection is editable or if the WebView tells us to.
  • WebView/WebView.m: (-[WebView maintainsInactiveSelection]): Just because a WebView is editable doesn't mean selections inside subframes will be. Return NO by default.
7:14 PM Changeset in webkit [15440] by thatcher
  • 8 edits in /

Versioning

5:53 PM Changeset in webkit [15439] by thatcher
  • 9 edits in trunk/WebKit

<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure

Build fix with the new GCC. Removes forward declarations of protocols.

  • Misc/WebSearchableTextView.h:
  • WebCoreSupport/WebSubresourceLoader.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentInternal.h:
  • WebView/WebDocumentPrivate.h:
  • WebView/WebHTMLView.h:
  • WebView/WebPDFView.h:
  • WebView/WebScriptDebugDelegatePrivate.h:
5:24 PM Changeset in webkit [15438] by thatcher
  • 34 edits in trunk/WebCore

<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure

Made a DOMNode category in DOMEvents.h that lets DOMNode conform to the
DOMEventTarget protocol that works with GCC 5412.

Removed forward declarations of WebCoreWidgetHolder and imported WebCoreWidgetHolder.h.

Removed all <Cocoa/Cocoa.h> and <Foundation/Foundation.h> imports in other headers,
we import <Cocoa/Cocoa.h> in the prefix header for ObjC.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.h:
  • bridge/mac/FormDataMac.h:
  • bridge/mac/WebCoreAXObject.h:
  • bridge/mac/WebCoreCache.h:
  • bridge/mac/WebCoreEncodings.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameNamespaces.h:
  • bridge/mac/WebCoreJavaScript.h:
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageState.h:
  • bridge/mac/WebCoreResourceLoader.h:
  • bridge/mac/WebCoreScriptDebugger.h:
  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreStringTruncator.h:
  • bridge/mac/WebCoreStringTruncator.mm:
  • bridge/mac/WebCoreTextDecoder.h:
  • bridge/mac/WebDashboardRegion.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • platform/mac/CookieJar.mm:
  • platform/mac/DeprecatedStringMac.mm:
  • platform/mac/FontDataMac.mm:
  • platform/mac/FoundationExtras.h:
  • platform/mac/TextBoundaries.mm:
  • platform/mac/WebCoreHistory.h:
  • platform/mac/WebCoreHistory.m:
  • platform/mac/WebCoreKeyGenerator.h:
  • platform/mac/WebCoreTextArea.h:
  • platform/mac/WebCoreTextField.h:
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreView.h:
  • platform/mac/WebCoreWidgetHolder.h:
3:39 PM Changeset in webkit [15437] by ggaren
  • 22 edits in trunk

JavaScriptCore:

Reviewed by Maciej.


  • Implemented ref-counting of JSContexts by splitting into two datatypes: JSGlobalContext, which you can create/retain/release, and JSContext, which you can't.


Internally, you retain a JSGlobalContext/ExecState by retaining its
interpreter, which, in the case of a global ExecState, owns it.


  • Also made ~Interpreter() protected to catch places where Interpreter is manually deleted. (Can't make it private because some crazy fool decided it would be a good idea to subclass Interpreter in other frameworks. I pity da fool.)
  • API/APICast.h: (toJS): Added cast for new JSGlobalContext
  • API/JSStringRef.h: Changed vague "you must" language to more specific (but, ultimately, equally vague) "behavior is undefined if you don't" language. (KJS::Interpreter::Interpreter): Factored more common initialization into init()
  • kjs/interpreter.h: (KJS::Interpreter::ref): new (KJS::Interpreter::deref): new (KJS::Interpreter::refCount): new
  • kjs/testkjs.cpp: (doIt): Ref-count the interpreter.

JavaScriptGlue:

Reviewed by Maciej.


  • Updated JSInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(JSInterpreter::JSInterpreter::~JSInterpreter): Now protected to catch
manual delete.

WebCore:

Reviewed by Maciej.

  • Updated ScriptInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(KJS::ScriptInterpreter::~ScriptInterpreter): Now protected to catch
manual delete.

2:21 PM Changeset in webkit [15436] by brmorris
  • 2 edits
    1 add in S60/trunk/S60Tools

2006-07-14 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com. Fix for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9919


  • prepare-ChangeLog.bat: Match Changelog subdir location on '/'
  • refresh_zips.bat: Added.
1:54 PM Changeset in webkit [15435] by andersca
  • 3 edits
    1 add in trunk/WebCore

2006-07-14 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele and Justin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9658
<rdar://problem/4613948>
REGRESSION: Check Spelling does not work in textarea elements


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Don't use setStartBefore or setEndAfter on the search range because for shadow trees, there is no notion of before and after. Instead, use setStart and setEnd and pass in the start and end indices respectively.


  • dom/Range.cpp: (WebCore::Range::checkNodeBA): Allow range operations on shadow trees.
  • manual-tests/form-element-spelling.html: Added.
1:53 PM Changeset in webkit [15434] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.


  • removed bool return value from JSObjectSetProperty, since it is inefficient and also doesn't work quite right
  • added JSObjectGetPropertyAtIndex and JSObjectSetPropertyAtIndex
  • API/JSObjectRef.cpp: (JSObjectSetProperty): Removed return value and canPut stuff. (JSObjectGetPropertyAtIndex): Added. (JSObjectSetPropertyAtIndex): Added.
  • API/JSObjectRef.h: Prototyped and documented new functions.
1:35 PM Changeset in webkit [15433] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4621660> REGRESSION: Safari crashing in
WebCore::FrameView::updateOverflowStatus

m_viewportRenderer is never initialized for framesets, and it
shouldn't be. So we just need to nil-check for it in
updateOverflowStatus() and return early.

  • page/FrameView.cpp: (WebCore::FrameView::updateOverflowStatus): Nil check.
1:29 PM Changeset in webkit [15432] by brmorris
  • 3 edits
    7 adds in S60/trunk

2006-07-11 brmorris <​bradley.morrison@nokia.com>

Reviewed by dacarson.


Fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9755


  • ChangeLog: Re-arranged all ChangeLog entry locations.
  • JavaScriptCore/ChangeLog: Stripped to S60WebKit only.
  • MemoryManager/ChangeLog: Added.
  • S60Internals/ChangeLog: Added.
  • S60Tools/ChangeLog: Added.
  • S60WebUi/ChangeLog: Added.
  • WebCore/ChangeLog: Added.
  • WebKit/ChangeLog: Re-arranged.
1:07 PM Changeset in webkit [15431] by brmorris
  • 3 edits in S60/trunk

2006-07-11 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com.


Fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9852


  • runATF.bat: Now supports SDK 3rd ed maintenance release.

Calls Epoc.exe directly

  • emu.bat: Calls Epoc.exe directly
12:09 PM Changeset in webkit [15430] by adele
  • 4 edits in trunk

WebCore:

RS by Darin.

Backing out fix for <rdar://problem/4604703>
REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field

Darin had a better fix in WebKit for this.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):

WebKit:

Reviewed by Adele.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Set handlingMouseDownEvent to YES while calling sendContextMenuEvent: on the bridge.
11:53 AM Changeset in webkit [15429] by adele
  • 5 edits in trunk/WebCore

Reviewed by Darin.

  • Fix for <rdar://problem/4614054> REGRESSION: Safari submits forms when the Return key is hit to complete inline inputs
  • page/Frame.h: (WebCore::Frame::inputManagerHasMarkedText): Added.
  • bridge/mac/FrameMac.h: ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::inputManagerHasMarkedText): Added. Asks the input manager if there's marked text.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): For text fields, don't submit the form on Enter if the input manager says there's marked text. I added this code for all text field paths. For widgets, WebCoreTextField.mm has code to deal with this case. But as we convert search, password, and isindex, they will need to do this check too.
10:41 AM Changeset in webkit [15428] by ggaren
  • 7 edits
    1 add in trunk/JavaScriptCore

Reviewed by Beth.


Moved JSCheckScriptSyntax, JSEvaluateScript, and JSGarbageCollect into
JSBase.h/.cpp. They don't belong in the value-specific or context-specific
files because they're not part of the value or context implementations.

  • API/JSBase.h:
  • API/JSContextRef.cpp: (JSContextGetGlobalObject):
  • API/JSContextRef.h:
  • API/JSValueRef.cpp: (JSValueUnprotect):
  • API/JSValueRef.h:
  • JavaScriptCore.xcodeproj/project.pbxproj:
6:18 AM Changeset in webkit [15427] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by Mitz.

  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): Fixed the calculation of the max/min allowed caret position.
6:14 AM Changeset in webkit [15426] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • editing/deleting/delete-at-start-or-end-expected.checksum: Added.
  • editing/deleting/delete-at-start-or-end-expected.png: Added.
  • editing/deleting/delete-at-start-or-end-expected.txt: Added.
  • editing/deleting/delete-at-start-or-end.html: Added.

WebCore:

Reviewed by Darin.

Test: editing/deleting/delete-at-start-or-end.html

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Added null check. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
5:33 AM Changeset in webkit [15425] by ddkilzer
  • 1 edit
    4 adds in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

NOTE: Only the layout test part of this patch was landed since an alternate
fix was committed in r15401: <rdar://problem/4509393> selected DOM range
starts with <object>, 0 offset but selection should include the <object>

  • fast/table/click-near-anonymous-table-expected.checksum: Added.
  • fast/table/click-near-anonymous-table-expected.png: Added.
  • fast/table/click-near-anonymous-table-expected.txt: Added.
  • fast/table/click-near-anonymous-table.html: Added.
5:05 AM Changeset in webkit [15424] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Geoffrey.

No test cases since there is no change in functionality.

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): Simplified logic by using the no-argument getNumber() method.
1:07 AM Changeset in webkit [15423] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • Build fix: don't need BLOCK_OBJC_EXCEPTIONS because we already have one surrounding this function, and the nested one makes the compiler think our local variable is volatile (seems like a compiler bug to me).


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):
12:46 AM Changeset in webkit [15422] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Make JavaScriptCore a public framework. Adjusted the paths.

  • WebCore.xcodeproj/project.pbxproj:
12:45 AM Changeset in webkit [15421] by mjs
  • 5 edits
    24 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test cases for <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)


I included the test case from the bug plus variants for other broken cases that
were similar but needed separate fixes.

  • fast/table/cell-in-row-before-misnested-text-crash-expected.txt: Added.
  • fast/table/cell-in-row-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-row-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-row-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-table-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-table-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-tbody-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-tbody-before-misnested-text-crash.xhtml: Added.
  • fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: Added.
  • fast/table/row-in-tbody-before-misnested-text-crash.xhtml: Added.
  • fast/table/section-in-table-before-misnested-text-crash-expected.txt: Added.
  • fast/table/section-in-table-before-misnested-text-crash.xhtml: Added.

WebCore:

Reviewed by Hyatt.

  • fixed <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)


I also fixed all the similar crash / assertion failure cases I could think of.

  • dom/Node.cpp: (WebCore::Node::nextRendererWithSameParent): Helper function for some of the above.
  • dom/Node.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Don't allow inserting forms when not in an HTML document, since we don't need that quirk and because parsing won't do certain render tree fixups. Also watch out for case when inserting before the renderer of a misnested child.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): ditto
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): ditto
12:15 AM Changeset in webkit [15420] by thatcher
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Moved JavaScriptCore to be a public framework.

WebKit:

Reviewed by Maciej.

Moved JavaScriptCore to be a public framework.

  • WebKit.xcodeproj/project.pbxproj:

Jul 13, 2006:

11:48 PM Changeset in webkit [15419] by adele
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Maciej.

  • Fix for <rdar://problem/4604703> REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field

Test:

  • manual-tests/password-ctrl-click-lose-focus.html: Added.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): If we're about to set a selection in the current view, make sure its the first responder. In this case, this will cause the password field to resign first responder at the right time.
9:42 PM Changeset in webkit [15418] by ddkilzer
  • 20 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • editing/deleting/delete-to-select-table-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/italicizeByCharacter-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/print-expected.txt:
  • editing/execCommand/selectAll-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/inserting/insert-div-027-expected.txt:
  • editing/selection/after-line-wrap-expected.txt:
  • editing/selection/mixed-editability-1-expected.txt:
  • editing/selection/select-all-001-expected.txt:
  • editing/selection/select-all-002-expected.txt:
  • editing/selection/select-all-003-expected.txt:
  • fast/clip/outline-overflowClip-expected.txt:
  • fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
  • fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
  • fast/text/international/rtl-white-space-pre-wrap-expected.txt: Added.
  • fast/text/international/rtl-white-space-pre-wrap.html: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:

WebCore:

Reviewed by Hyatt. Patch by Mitz.

Test: fast/text/international/rtl-white-space-pre-wrap.html

  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): Fixed LTR case and added the RTL case of clipping the caret position to the text box when the caret is after the trailing space of an autowrapped line.
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed to truncate- to-fit the logically last text box if it contains the trailing spaces of an autowrapped line. (WebCore::RenderBlock::bidiReorderLine): Remember the logically last text run. In the case of autowrapped text with white space that overflows beyond the line, the last text run is the one containing the overflowing white space. (WebCore::RenderBlock::findNextLineBreak): Split overflowing white space on a line that autowraps only after white space into a separate text run.
8:29 PM Changeset in webkit [15417] by ddkilzer
  • 7 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoffrey. Patch by Mark Rowe.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
Bug 9742: REGRESSION: WebKit hangs when loading <​http://www.vtbook.com>

  • kjs/value.h: (KJS::JSValue::getUInt32): Only types tagged as numeric can be converted to UInt32.

LayoutTests:

Reviewed by Geoffrey. Patch by Mark Rowe.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
Bug 9742: REGRESSION: WebKit hangs when loading <​http://www.vtbook.com>

This includes tests for indexing an array with immediate types, and for
setting selectField.options.length to immediate types.

  • fast/dom/select-selectedIndex-expected.txt:
  • fast/dom/select-selectedIndex-multiple-expected.txt:
  • fast/dom/select-selectedIndex-multiple.html: Update to test setting length to true and false.
  • fast/dom/select-selectedIndex.html: Ditto.
  • fast/js/array-index-immediate-types-expected.txt: Added.
  • fast/js/array-index-immediate-types.html: Added.
  • fast/js/resources/array-index-immediate-types.js: Added.
7:37 PM Changeset in webkit [15416] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): Return immediately if the view has already been closed.
4:17 PM Changeset in webkit [15415] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/4624203> -webkit-highlight should be behind images

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Call custom highlighter before painting the image, marker, or widget.
2:08 PM Changeset in webkit [15414] by harrison
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by Justin and Levi.

<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

  • editing/deleting/delete-by-word-001-expected.checksum: Added.
  • editing/deleting/delete-by-word-001-expected.png: Added.
  • editing/deleting/delete-by-word-001-expected.txt: Added.
  • editing/deleting/delete-by-word-001.html: Added.
  • editing/deleting/delete-by-word-002-expected.checksum: Added.
  • editing/deleting/delete-by-word-002-expected.png: Added.
  • editing/deleting/delete-by-word-002-expected.txt: Added.
  • editing/deleting/delete-by-word-002.html: Added.

WebCore:

Reviewed by Justin and Levi.

<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

  • Tests: editing/deleting/delete-by-word-001.html editing/deleting/delete-by-word-002.html
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::doApply):
  • editing/TypingCommand.h: Delete and forward delete to use specified granularity. Undo of delete and forward delete to select what had been deleted (non-char granularity only).


  • page/Frame.cpp: (WebCore::Frame::setSelection): Close typing and end style even if selection is not changing.
  • page/Frame.h: Remove unused setSelection parameter keepTypingStyle.

WebKit:

Reviewed by Justin and Levi.

<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

  • Tests: editing/deleting/delete-by-word-001.html editing/deleting/delete-by-word-002.html
  • WebView/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
11:45 AM Changeset in webkit [15413] by thatcher
  • 3 edits in tags/WebKit-521.16.4/WebKit

Reviewed by Darin.

<rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
to next control instead of inserting a tab space.

Change editible WebView's tabKeyCyclesThroughElements to NO only
if the setTabKeyCyclesThroughElements SPI wasn't called.

  • WebView/WebView.m: (-[WebView setEditable:]):
11:44 AM Changeset in webkit [15412] by thatcher
  • 3 edits in tags/WebCore-521.16.1/WebCore

Reviewed by Brady Eidson


  • fixed <rdar://problem/4611164> REGRESSION: Crash occurs when undoing a series of misspelled words (WebCore::RenderObject::repaint(bool)
  • dom/Document.cpp: (WebCore::Document::removeMarkers): put (it - markers.begin()) in a local variable before altering markers, in every case where this was happening. One of the cases like this was fixed a while back, but other cases were either missed at that time or crept in since.
11:34 AM Changeset in webkit [15411] by thatcher
  • 1 copy in tags/WebKit-521.16.4

New tag.

11:33 AM Changeset in webkit [15410] by thatcher
  • 1 copy in tags/WebCore-521.16.1/WebCore

New tag (part 2)

11:32 AM Changeset in webkit [15409] by thatcher
  • 1 add in tags/WebCore-521.16.1

New tag.

11:28 AM Changeset in webkit [15408] by lweintraub
  • 11 edits
    8 adds in trunk

LayoutTests:

Reviewed by justin

<rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table

  • editing/deleting/delete-block-table-expected.checksum: Added.
  • editing/deleting/delete-block-table-expected.png: Added.
  • editing/deleting/delete-block-table-expected.txt: Added.
  • editing/deleting/delete-block-table.html: Added.
  • editing/deleting/delete-hr-expected.checksum: Added.
  • editing/deleting/delete-hr-expected.png: Added.
  • editing/deleting/delete-hr-expected.txt: Added.
  • editing/deleting/delete-hr.html: Added.
  • editing/deleting/delete-to-select-table-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.txt:
  • fast/lists/markers-in-selection-expected.txt:

WebCore:

Reviewed by justin

<rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Added selection expansion for HRs. (WebCore::DeleteSelectionCommand::initializePositionData): Now uses enclosingBlockFlowOrTableElement instead of enclosingBlockFlowElement. (WebCore::DeleteSelectionCommand::removeNode): Use to identify that we need a placeholder when the start or end block is removed. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Added check for canHaveChildrenForEditing to keep things like HRs from being given children. (WebCore::DeleteSelectionCommand::doApply): Switched to use member variable for needPlaceholder.
  • editing/DeleteSelectionCommand.h: Made needPlaceholder a member variable.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Fixed selection bug for tables and open typing commands. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): Added check for HRs, since it's not considered a widget.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Fix for HRs and tables. (WebCore::endOfParagraph): Ditto.
11:27 AM Changeset in webkit [15407] by thatcher
  • 3 edits in trunk/WebKit

Rolling out this earlier change (r15378) now that it is fixed on AGL's end.
Fixes <rdar://problem/4624865> Restore 64-bit OpenGL plug-in support once AGL is 64-bit

<rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m:
11:06 AM Changeset in webkit [15406] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
to next control instead of inserting a tab space.

Change editible WebView's tabKeyCyclesThroughElements to NO only
if the setTabKeyCyclesThroughElements SPI wasn't called.

  • WebView/WebView.m: (-[WebView setEditable:]):
8:54 AM Changeset in webkit [15405] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

No change in behavior, thus no test included.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setStatusBarText): Use a local autorelease pool to release the temporaries - the test runs non-stop, and the enclosing pool doesn't get a chance to be drained.
1:56 AM Changeset in webkit [15404] by ggaren
  • 14 edits in trunk/JavaScriptCore

Pleasing to Maciej.


  • Renamed JSEvaluate -> JSEvaluateScript, JSCheckSyntax -> JSCheckScriptSyntax
  • Added exception out parameters to JSValueTo* and JSValueIsEqual because they can throw
  • Removed JSObjectGetDescription because it's useless and vague, and JSValueToString/JSValueIsObjectOfClass do a better job, anyway
  • Clarified comments about "IsFunction/Constructor" to indicate that they are true of all functions/constructors, not just those created by JSObjectMake*
12:11 AM Changeset in webkit [15403] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Timothy.

Bug 9889: [Drosera] Stepping out when paused after last statement in function skips a frame
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9889

  • Drosera/debugger.js: Track whether we paused during the execution of willLeaveFrame. If so, have stepOut pause on the next call to willExecuteStatement rather than second.
Note: See TracTimeline for information about the timeline view.