⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 15, 2006:

10:45 PM Changeset in webkit [15467] by thatcher
  • 1 edit in trunk/JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj

JavaScriptGlue has no need to look for frameworks in WebKit's umbrella framework path anymore.

10:22 PM Changeset in webkit [15466] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

WebCore has no need to look for frameworks in WebKit's umbrella framework path anymore.

7:26 PM Changeset in webkit [15465] by darin
  • 6 edits in trunk/JavaScriptCore
  • oops, missed a few more arrays that had to be const
  • API/JSNode.c: (JSNodePrototype_appendChild): Added const. (JSNodePrototype_removeChild): Ditto. (JSNodePrototype_replaceChild): Ditto. (JSNode_construct): Ditto.
  • API/JSNodeList.c: (JSNodeListPrototype_item): Ditto.
  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody): Ditto. (JSObjectCallAsFunction): Ditto. (JSObjectCallAsConstructor): Ditto.
  • API/minidom.c: (print): Ditto.
  • API/testapi.c: (MyObject_callAsFunction): Ditto. (MyObject_callAsConstructor): Ditto. (print_callAsFunction): Ditto. (myConstructor_callAsConstructor): Ditto.
7:18 PM Changeset in webkit [15464] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • API/JSNode.h: Made an array parameter const.
  • API/JSObjectRef.h: Made array parameters const. Fixed a comment.
6:40 PM Changeset in webkit [15463] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • JSObjectMakeFunctionWithBody includes a function name and named parameters now.
  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody):
  • API/JSObjectRef.h:
  • API/testapi.c: (assertEqualsAsUTF8String): More informative failure reporting. (main): Test more function cases.
6:28 PM Changeset in webkit [15462] by ggaren
  • 11 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • Moved the arguments passed to JSClassCreate into a single structure, called JSClassDefinition. This will enable easier structure migration/versioning in the future, if necessary.


  • Added support for class names.


  • kJSClassDefinitionNull replaces kJSObjectCallbacksNone.


  • JSClass is becoming a fairly complex struct, so I migrated all of its implementation other than reference counting to the sruct.


  • Also moved JSClass* functions in the API to JSObjectRef.cpp, since they're declared in JSObjectRef.h


  • Also added some more informative explanation to the class structure doc.
2:03 PM Changeset in webkit [15461] by darin
  • 2 edits in trunk/WebCore
  • fix mistake from fix for 8952 that was breaking layout tests
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Justin was right! I changed the behavior of the function by accident. Changed it back so that it doesn't blow away the selection on the DOM side in the case where it didn't before.

I will write 100 times on the blackboard: "When Justin says something about editing,
assume he is right."

1:00 PM Changeset in webkit [15460] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added StreamingTextDecoderICU.cpp/h.
12:41 PM Changeset in webkit [15459] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/dynamic/move-node-with-selection-expected.checksum: Added.
  • fast/dynamic/move-node-with-selection-expected.png: Added.
  • fast/dynamic/move-node-with-selection-expected.txt: Added.
  • fast/dynamic/move-node-with-selection.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/dynamic/move-node-with-selection.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Call updateRendering before calling clearSelection(), since it's important to do any work beforehand, and there are calls inside clearSelection that will indirectly do an updateRendering. Also change code to make fewer assumptions about object lifetime.
12:27 PM Changeset in webkit [15458] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/lists/numeric-markers-outside-list-expected.checksum: Added.
  • fast/lists/numeric-markers-outside-list-expected.png: Added.
  • fast/lists/numeric-markers-outside-list-expected.txt: Added.
  • fast/lists/numeric-markers-outside-list.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/lists/numeric-markers-outside-list.html

  • rendering/RenderListItem.cpp: (WebCore::previousListItem): Look for list items, even when we're outside any list.
10:22 AM Changeset in webkit [15457] by adele
  • 7 edits in trunk/WebCore

Reviewed by John.

  • Fix for <rdar://problem/4593970> REGRESSION (NativeTextField): autofill menu disappears after typing a 2nd character

This was caused by composite editing commands, (like typing or pasting) that include a DeleteCommand, being
interpreted by the form delegate as an actual delete. This fix doesn't notify the form delegate if the deletion is
part of an editing command to replace the selected text.

  • editing/DeleteSelectionCommand.h: Added m_replace to keep track of whether this deletion is part of a composite command to replace the text being deleted.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize m_replace. (WebCore::DeleteSelectionCommand::doApply): Only notify the form delegate of the deletion if the text is not being replaced.
  • editing/CompositeEditCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteSelection): Added replace argument to construct DeleteSelectionCommand.


  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call deleteSelection with replace argument.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): ditto.
9:31 AM Changeset in webkit [15456] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.


Layout test for crash when setting the dir property on a document with no body.

  • fast/dom/dir-no-body-expected.txt: Added.
  • fast/dom/dir-no-body.html: Added.

WebCore:

Reviewed by Maciej, tweaked to match Darin's patch.


  • Fixed <rdar://problem/4631837> REGRESSION: Reproducible crash on FCKeditor demo (9911)


  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Check for a null body element before forwarding the put request to it. I confirmed that no other parts of the file use 'body' or 'bodyElement' without checking for null.


Also, use 'body' rather than 'bodyElement' because dir can bet set on
any element, not just HTMLBodyElement.

8:30 AM Changeset in webkit [15455] by darin
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

Test: fast/js/regexp-extended-characters-more.html

  • pcre/pcre_exec.c: (match): Got rid of utf16Length local variable to guarantee there's no extra stack usage in recursive calls. Fixed two places in the PCRE_UTF16 code that were using the length variable, which is the UTF-8 length of a character in the pattern, to move in the UTF-16 subject string. Instead they hardcode lengths of 1 and 2 since the code already handles BMP characters and surrogate pairs separately. Also fixed some DPRINTF so I could compile with DEBUG on. (pcre_exec): Changed a place that was checking for multibyte characters in the subject string to use ISMIDCHAR. Instead it was using hardcoded logic that was right for UTF-8 but wrong for UTF-16.
  • pcre/pcre_compile.c: (pcre_compile2): Fixed a DPRINTF so I could compile with DEBUG on.

LayoutTests:

Reviewed by Geoff.

  • fast/js/regexp-extended-characters-more-expected.txt: Added.
  • fast/js/regexp-extended-characters-more.html: Added.
  • fast/js/resources/regexp-extended-characters-more.js: Added.
8:21 AM Changeset in webkit [15454] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/input-text-enter-expected.txt: Added.
  • fast/forms/input-text-enter.html: Added.

WebCore:

Reviewed by Adele.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::doTextFieldCommandFromEvent): Add a null check to fix the crash, and a FIXME explaining why this is not necessarily enough for the future.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Consume Enter key keypress events even if the element is not in a form.
  • platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): Added \n to the characters that turn into "Enter". Actual keyboard events always are \r or \003 on the Macintosh, but in layout tests we can use \n, and everything other than the code path here works, so worth fixing.
8:14 AM Changeset in webkit [15453] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/forms/select-selected-expected.checksum: Added.
  • fast/forms/select-selected-expected.png: Added.
  • fast/forms/select-selected-expected.txt: Added.
  • fast/forms/select-selected.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/forms/select-selected.html

  • rendering/RenderMenuList.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Added code to map the selected option index to a list index before using it to index into the list. (WebCore::RenderMenuList::showPopup): Added code to map the selection option index to a list index before passing it to the menu renderer. (WebCore::RenderMenuList::valueChanged): Added code to map the list index back to a option index before calling setSelectedIndex (that function takes an option index).
8:09 AM Changeset in webkit [15452] by darin
  • 6 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • bindings/objc/DOM.mm: (-[DOMNode addEventListener:::]): Moved into DOMEventTarget category. (-[DOMNode removeEventListener:::]): Ditto. (-[DOMNode dispatchEvent:]): Ditto.
  • WebCore.xcodeproj/project.pbxproj: Allow Xcode to do its thing.

WebKit:

Reviewed by John Sullivan.

  • WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): Moved into WebHTMLViewFileInternal category. (-[WebHTMLView selectionRect]): Moved into WebDocumentPrivateProtocols category. (-[WebHTMLView selectionView]): Ditto. (-[WebHTMLView selectionImageForcingWhiteText:]): Ditto. (-[WebHTMLView selectionImageRect]): Ditto. (-[WebHTMLView pasteboardTypesForSelection]): Ditto. (-[WebHTMLView selectAll]): Ditto. (-[WebHTMLView deselectAll]): Ditto. (-[WebHTMLView string]): Ditto. (-[WebHTMLView _attributeStringFromDOMRange:]): Ditto. (-[WebHTMLView attributedString]): Ditto. (-[WebHTMLView selectedString]): Ditto. (-[WebHTMLView selectedAttributedString]): Ditto. (-[WebHTMLView supportsTextEncoding]): Ditto. (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Moved into WebDocumentInternalProtocols. (-[WebHTMLView _isMoveDrag]): Ditto. (-[WebHTMLView _isNSColorDrag:]): Ditto. (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView elementAtPoint:]): Ditto. (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode 2.3 do its thing.
2:36 AM Changeset in webkit [15451] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Anders.

<rdar://problem/4632144> REGRESSION: table column tests failing as a result of very recent fix

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): columns and colgroups are valid children of a table too, not just table sections!
2:04 AM Changeset in webkit [15450] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-07-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.


  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Add null check for contentFrame() since content frames won't be created for invalid URLs.

LayoutTests:

2006-07-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.

  • http/tests/misc/iframe-invalid-source-crash-expected.txt: Added.
  • http/tests/misc/iframe-invalid-source-crash.html: Added.

Jul 14, 2006:

11:53 PM Changeset in webkit [15449] by ap
  • 9 edits
    2 copies
    12 adds
    3 deletes in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4195
REGRESSION: KOI8-U encoding no longer supported.

Tests:

  • http/tests/misc/BOM-override.pl
  • http/tests/misc/BOM-override-script.html
  • fast/encoding/charset-koi8-u.html
  • fast/encoding/charset-x-nextstep.html

Restored a TEC code path for encodings that are not supported by ICU (but which currently
passes all layout tests even by itself with ICU disabled). A lot of refactoring is
still needed - most importantly, round-tripping encoding names via CFStringEncoding
makes little sense now.

  • WebCore.exp:
  • bridge/mac/WebCoreTextDecoder.h: Removed.
  • bridge/mac/WebCoreTextDecoder.mm: Removed. WebCoreTextDecoder was not used anywhere since WebTextView was moved into WebCore.
  • loader/Decoder.cpp: (Decoder::Decoder): (Decoder::setEncodingName): (Decoder::decode): Use StreamingTextDecoder::create().
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::create): (WebCore::StreamingTextDecoder::~StreamingTextDecoder):
  • platform/StreamingTextDecoder.h: StreamingTextDecoder is just an abstract interface to implementations now.
  • platform/StreamingTextDecoderICU.cpp: Added. (WebCore::StreamingTextDecoderICU::StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::~StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::releaseICUConverter): (WebCore::StreamingTextDecoderICU::textEncodingSupported): (WebCore::StreamingTextDecoderICU::convertUTF16): (WebCore::StreamingTextDecoderICU::convertIfASCII): (WebCore::StreamingTextDecoderICU::createICUConverter): (WebCore::StreamingTextDecoderICU::appendOmittingBOM): (WebCore::StreamingTextDecoderICU::convertUsingICU): (WebCore::StreamingTextDecoderICU::convert): (WebCore::StreamingTextDecoderICU::toUnicode): (WebCore::StreamingTextDecoderICU::fromUnicode):
  • platform/StreamingTextDecoderICU.h: Added. Renamed from StreamingTextDecoder; added a way to tell whether the encoding is actually supported by the decoder; minor cleanup.
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::effectiveEncoding): Moved from StreamingTextDecoder. (WebCore::TextEncoding::toUnicode): Use StreamingTextDecoder::create(). (WebCore::TextEncoding::fromUnicode): Moved to StreamingTextDecoderICU.


  • platform/TextEncoding.h: Changed APPLE to PLATFORM(MAC); added effectiveEncoding().
  • platform/mac/StreamingTextDecoderMac.cpp: Added. (WebCore::StreamingTextDecoderMac::StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::~StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::releaseTECConverter): (WebCore::StreamingTextDecoderMac::textEncodingSupported): (WebCore::StreamingTextDecoderMac::convertUTF16): (WebCore::StreamingTextDecoderMac::convertIfASCII): (WebCore::StreamingTextDecoderMac::createTECConverter): (WebCore::StreamingTextDecoderMac::appendOmittingBOM): (WebCore::StreamingTextDecoderMac::convertOneChunkUsingTEC): (WebCore::StreamingTextDecoderMac::convertUsingTEC): (WebCore::StreamingTextDecoderMac::convert): (WebCore::StreamingTextDecoderMac::toUnicode): (WebCore::StreamingTextDecoderMac::fromUnicode):
  • platform/mac/StreamingTextDecoderMac.h: Added. (WebCore::StreamingTextDecoderMac::convert): This is a TEC+CFString code path for decoding, basically restored from a year-old revision.
  • platform/mac/TextEncodingMac.cpp: Removed. Code moved to StreamingTextDecoderMac.
  • WebCore.xcodeproj/project.pbxproj:
11:37 PM Changeset in webkit [15448] by thatcher
  • 2 edits in tags/JavaScriptCore-521.17.1/JavaScriptCore

Build fix and versioning.

11:36 PM Changeset in webkit [15447] by thatcher
  • 1 copy in tags/JavaScriptCore-521.17.1/JavaScriptCore

New tag (part 2)

11:35 PM Changeset in webkit [15446] by thatcher
  • 1 add in tags/JavaScriptCore-521.17.1

new tag.

11:32 PM Changeset in webkit [15445] by thatcher
  • 1 edit in trunk/JavaScriptCore/API/JSBase.cpp

Build fix for case-sensitive file systems.

9:16 PM Changeset in webkit [15444] by ggaren
  • 11 edits in trunk/JavaScriptCore

RS by Maciej.


Global replace in the API of argc/argv with argumentCount/arguments.

9:10 PM Changeset in webkit [15443] by ggaren
  • 11 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Finalized exception handling in the API.


setProperty can throw because it throws for built-in arrays. getProperty
and deleteProperty can throw because setProperty can throw and we want
to be consistent, and also because they seem like "actions." callAsFunction,
callAsConstructor, and hasInstance can throw, because they caan throw for
all built-ins.


toBoolean can't throw because it's defined that way in the spec.


  • Documented that toBoolean and toObject can't be overridden by custom objects because they're defined that way in the spec.
7:32 PM Changeset in webkit [15442] by thatcher
  • 5 copies in tags/Safari-521.17

New tag.

7:25 PM Changeset in webkit [15441] by thatcher
  • 5 edits
    4 deletes in trunk

LayoutTests:

Rolling out this fix from r15358 since it isn't resolved.

2006-07-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by levi & thatcher

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/subframe-with-selection-expected.checksum: Added.
  • editing/selection/subframe-with-selection-expected.png: Added.
  • editing/selection/subframe-with-selection-expected.txt: Added.
  • editing/selection/subframe-with-selection.html: Added.

WebKit:

Rolling out this fix from r15358 since it isn't resolved.

2006-07-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by levi & thatcher

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection when resigning as first responder if the selection is editable or if the WebView tells us to.
  • WebView/WebView.m: (-[WebView maintainsInactiveSelection]): Just because a WebView is editable doesn't mean selections inside subframes will be. Return NO by default.
7:14 PM Changeset in webkit [15440] by thatcher
  • 8 edits in /

Versioning

5:53 PM Changeset in webkit [15439] by thatcher
  • 9 edits in trunk/WebKit

<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure

Build fix with the new GCC. Removes forward declarations of protocols.

  • Misc/WebSearchableTextView.h:
  • WebCoreSupport/WebSubresourceLoader.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentInternal.h:
  • WebView/WebDocumentPrivate.h:
  • WebView/WebHTMLView.h:
  • WebView/WebPDFView.h:
  • WebView/WebScriptDebugDelegatePrivate.h:
5:24 PM Changeset in webkit [15438] by thatcher
  • 34 edits in trunk/WebCore

<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure

Made a DOMNode category in DOMEvents.h that lets DOMNode conform to the
DOMEventTarget protocol that works with GCC 5412.

Removed forward declarations of WebCoreWidgetHolder and imported WebCoreWidgetHolder.h.

Removed all <Cocoa/Cocoa.h> and <Foundation/Foundation.h> imports in other headers,
we import <Cocoa/Cocoa.h> in the prefix header for ObjC.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.h:
  • bridge/mac/FormDataMac.h:
  • bridge/mac/WebCoreAXObject.h:
  • bridge/mac/WebCoreCache.h:
  • bridge/mac/WebCoreEncodings.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameNamespaces.h:
  • bridge/mac/WebCoreJavaScript.h:
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageState.h:
  • bridge/mac/WebCoreResourceLoader.h:
  • bridge/mac/WebCoreScriptDebugger.h:
  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreStringTruncator.h:
  • bridge/mac/WebCoreStringTruncator.mm:
  • bridge/mac/WebCoreTextDecoder.h:
  • bridge/mac/WebDashboardRegion.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • platform/mac/CookieJar.mm:
  • platform/mac/DeprecatedStringMac.mm:
  • platform/mac/FontDataMac.mm:
  • platform/mac/FoundationExtras.h:
  • platform/mac/TextBoundaries.mm:
  • platform/mac/WebCoreHistory.h:
  • platform/mac/WebCoreHistory.m:
  • platform/mac/WebCoreKeyGenerator.h:
  • platform/mac/WebCoreTextArea.h:
  • platform/mac/WebCoreTextField.h:
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreView.h:
  • platform/mac/WebCoreWidgetHolder.h:
3:39 PM Changeset in webkit [15437] by ggaren
  • 22 edits in trunk

JavaScriptCore:

Reviewed by Maciej.


  • Implemented ref-counting of JSContexts by splitting into two datatypes: JSGlobalContext, which you can create/retain/release, and JSContext, which you can't.


Internally, you retain a JSGlobalContext/ExecState by retaining its
interpreter, which, in the case of a global ExecState, owns it.


  • Also made ~Interpreter() protected to catch places where Interpreter is manually deleted. (Can't make it private because some crazy fool decided it would be a good idea to subclass Interpreter in other frameworks. I pity da fool.)
  • API/APICast.h: (toJS): Added cast for new JSGlobalContext
  • API/JSStringRef.h: Changed vague "you must" language to more specific (but, ultimately, equally vague) "behavior is undefined if you don't" language. (KJS::Interpreter::Interpreter): Factored more common initialization into init()
  • kjs/interpreter.h: (KJS::Interpreter::ref): new (KJS::Interpreter::deref): new (KJS::Interpreter::refCount): new
  • kjs/testkjs.cpp: (doIt): Ref-count the interpreter.

JavaScriptGlue:

Reviewed by Maciej.


  • Updated JSInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(JSInterpreter::JSInterpreter::~JSInterpreter): Now protected to catch
manual delete.

WebCore:

Reviewed by Maciej.

  • Updated ScriptInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(KJS::ScriptInterpreter::~ScriptInterpreter): Now protected to catch
manual delete.

2:21 PM Changeset in webkit [15436] by brmorris
  • 2 edits
    1 add in S60/trunk/S60Tools

2006-07-14 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com. Fix for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9919


  • prepare-ChangeLog.bat: Match Changelog subdir location on '/'
  • refresh_zips.bat: Added.
1:54 PM Changeset in webkit [15435] by andersca
  • 3 edits
    1 add in trunk/WebCore

2006-07-14 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele and Justin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9658
<rdar://problem/4613948>
REGRESSION: Check Spelling does not work in textarea elements


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Don't use setStartBefore or setEndAfter on the search range because for shadow trees, there is no notion of before and after. Instead, use setStart and setEnd and pass in the start and end indices respectively.


  • dom/Range.cpp: (WebCore::Range::checkNodeBA): Allow range operations on shadow trees.
  • manual-tests/form-element-spelling.html: Added.
1:53 PM Changeset in webkit [15434] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.


  • removed bool return value from JSObjectSetProperty, since it is inefficient and also doesn't work quite right
  • added JSObjectGetPropertyAtIndex and JSObjectSetPropertyAtIndex
  • API/JSObjectRef.cpp: (JSObjectSetProperty): Removed return value and canPut stuff. (JSObjectGetPropertyAtIndex): Added. (JSObjectSetPropertyAtIndex): Added.
  • API/JSObjectRef.h: Prototyped and documented new functions.
1:35 PM Changeset in webkit [15433] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4621660> REGRESSION: Safari crashing in
WebCore::FrameView::updateOverflowStatus

m_viewportRenderer is never initialized for framesets, and it
shouldn't be. So we just need to nil-check for it in
updateOverflowStatus() and return early.

  • page/FrameView.cpp: (WebCore::FrameView::updateOverflowStatus): Nil check.
1:29 PM Changeset in webkit [15432] by brmorris
  • 3 edits
    7 adds in S60/trunk

2006-07-11 brmorris <​bradley.morrison@nokia.com>

Reviewed by dacarson.


Fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9755


  • ChangeLog: Re-arranged all ChangeLog entry locations.
  • JavaScriptCore/ChangeLog: Stripped to S60WebKit only.
  • MemoryManager/ChangeLog: Added.
  • S60Internals/ChangeLog: Added.
  • S60Tools/ChangeLog: Added.
  • S60WebUi/ChangeLog: Added.
  • WebCore/ChangeLog: Added.
  • WebKit/ChangeLog: Re-arranged.
1:07 PM Changeset in webkit [15431] by brmorris
  • 3 edits in S60/trunk

2006-07-11 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com.


Fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9852


  • runATF.bat: Now supports SDK 3rd ed maintenance release.

Calls Epoc.exe directly

  • emu.bat: Calls Epoc.exe directly
12:09 PM Changeset in webkit [15430] by adele
  • 4 edits in trunk

WebCore:

RS by Darin.

Backing out fix for <rdar://problem/4604703>
REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field

Darin had a better fix in WebKit for this.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):

WebKit:

Reviewed by Adele.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Set handlingMouseDownEvent to YES while calling sendContextMenuEvent: on the bridge.
11:53 AM Changeset in webkit [15429] by adele
  • 5 edits in trunk/WebCore

Reviewed by Darin.

  • Fix for <rdar://problem/4614054> REGRESSION: Safari submits forms when the Return key is hit to complete inline inputs
  • page/Frame.h: (WebCore::Frame::inputManagerHasMarkedText): Added.
  • bridge/mac/FrameMac.h: ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::inputManagerHasMarkedText): Added. Asks the input manager if there's marked text.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): For text fields, don't submit the form on Enter if the input manager says there's marked text. I added this code for all text field paths. For widgets, WebCoreTextField.mm has code to deal with this case. But as we convert search, password, and isindex, they will need to do this check too.
10:41 AM Changeset in webkit [15428] by ggaren
  • 7 edits
    1 add in trunk/JavaScriptCore

Reviewed by Beth.


Moved JSCheckScriptSyntax, JSEvaluateScript, and JSGarbageCollect into
JSBase.h/.cpp. They don't belong in the value-specific or context-specific
files because they're not part of the value or context implementations.

  • API/JSBase.h:
  • API/JSContextRef.cpp: (JSContextGetGlobalObject):
  • API/JSContextRef.h:
  • API/JSValueRef.cpp: (JSValueUnprotect):
  • API/JSValueRef.h:
  • JavaScriptCore.xcodeproj/project.pbxproj:
6:18 AM Changeset in webkit [15427] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by Mitz.

  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): Fixed the calculation of the max/min allowed caret position.
6:14 AM Changeset in webkit [15426] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • editing/deleting/delete-at-start-or-end-expected.checksum: Added.
  • editing/deleting/delete-at-start-or-end-expected.png: Added.
  • editing/deleting/delete-at-start-or-end-expected.txt: Added.
  • editing/deleting/delete-at-start-or-end.html: Added.

WebCore:

Reviewed by Darin.

Test: editing/deleting/delete-at-start-or-end.html

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Added null check. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
5:33 AM Changeset in webkit [15425] by ddkilzer
  • 1 edit
    4 adds in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

NOTE: Only the layout test part of this patch was landed since an alternate
fix was committed in r15401: <rdar://problem/4509393> selected DOM range
starts with <object>, 0 offset but selection should include the <object>

  • fast/table/click-near-anonymous-table-expected.checksum: Added.
  • fast/table/click-near-anonymous-table-expected.png: Added.
  • fast/table/click-near-anonymous-table-expected.txt: Added.
  • fast/table/click-near-anonymous-table.html: Added.
5:05 AM Changeset in webkit [15424] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Geoffrey.

No test cases since there is no change in functionality.

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): Simplified logic by using the no-argument getNumber() method.
1:07 AM Changeset in webkit [15423] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • Build fix: don't need BLOCK_OBJC_EXCEPTIONS because we already have one surrounding this function, and the nested one makes the compiler think our local variable is volatile (seems like a compiler bug to me).


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):
12:46 AM Changeset in webkit [15422] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Make JavaScriptCore a public framework. Adjusted the paths.

  • WebCore.xcodeproj/project.pbxproj:
12:45 AM Changeset in webkit [15421] by mjs
  • 5 edits
    24 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test cases for <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)


I included the test case from the bug plus variants for other broken cases that
were similar but needed separate fixes.

  • fast/table/cell-in-row-before-misnested-text-crash-expected.txt: Added.
  • fast/table/cell-in-row-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-row-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-row-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-table-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-table-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-tbody-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-tbody-before-misnested-text-crash.xhtml: Added.
  • fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: Added.
  • fast/table/row-in-tbody-before-misnested-text-crash.xhtml: Added.
  • fast/table/section-in-table-before-misnested-text-crash-expected.txt: Added.
  • fast/table/section-in-table-before-misnested-text-crash.xhtml: Added.

WebCore:

Reviewed by Hyatt.

  • fixed <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)


I also fixed all the similar crash / assertion failure cases I could think of.

  • dom/Node.cpp: (WebCore::Node::nextRendererWithSameParent): Helper function for some of the above.
  • dom/Node.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Don't allow inserting forms when not in an HTML document, since we don't need that quirk and because parsing won't do certain render tree fixups. Also watch out for case when inserting before the renderer of a misnested child.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): ditto
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): ditto
12:15 AM Changeset in webkit [15420] by thatcher
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Moved JavaScriptCore to be a public framework.

WebKit:

Reviewed by Maciej.

Moved JavaScriptCore to be a public framework.

  • WebKit.xcodeproj/project.pbxproj:
Note: See TracTimeline for information about the timeline view.