⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 16, 2006:

9:41 PM Changeset in webkit [15480] by ggaren
  • 11 edits in trunk/JavaScriptCore

Approved by Maciej, RS by Beth.


JSObjectMakeFunction -> JSObjectMakeFunctionWithCallback
JSObjectMakeFunctionWithBody -> JSObjectMakeFunction


because the latter is more common, and more fundamental, than the former.

  • API/APICast.h: (toJS):
  • API/JSBase.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::getPropertyNames): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::staticFunctionGetter):
  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): (OpaqueJSClass::~OpaqueJSClass):
  • API/JSClassRef.h:
  • API/JSObjectRef.cpp: (JSClassCreate): (JSObjectMakeFunctionWithCallback): (JSObjectMakeFunction): (OpaqueJSPropertyNameArray::OpaqueJSPropertyNameArray): (JSObjectCopyPropertyNames):
  • API/JSObjectRef.h:
  • API/minidom.c: (main):
  • API/testapi.c: (main):
  • ChangeLog:
  • JavaScriptCore.exp:
9:21 PM Changeset in webkit [15479] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/document-dir-property-expected.txt: Added.
  • fast/dom/document-dir-property.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/document-dir-property.html

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty): Return an empty string instead of an undefined value for an unset document.dir property.
9:15 PM Changeset in webkit [15478] by ddkilzer
  • 8 edits in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/move-node-with-selection-expected.checksum: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.

WebCore:

Reviewed by Darin.

  • dom/NodeFilter.idl: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.
  • manual-tests/input-empty-on-focus.html: Removed "Property changes" that snuck in as part of the "apply patch" process.

WebKitTools:

Reviewed by Darin.

  • BuildSlaveSupport/build.webkit.org-config/buildbot.css: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.
  • GdkLauncher/mk: Removed "Property changes" that snuck in as part of the "apply patch" process.
8:59 PM Changeset in webkit [15477] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-apply: (addDirectoriesIfNeeded): Don't try to add a directory that's already in svn. (checksum): Added. (patch): Use patch(1) for non-binary additions and deletions.
  • Scripts/svn-unapply: (checksum): Added. (patch): Use patch(1) for reverting non-binary additions and deletions. (revertDirectories): Don't try to revert a directory that hasn't changed in svn.
8:59 PM Changeset in webkit [15476] by darin
  • 2 edits in trunk/JavaScriptCore
  • try to fix Windows build
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added some recently added files, removed some recently removed.
7:51 PM Changeset in webkit [15475] by darin
  • 3 edits in trunk/LayoutTests
  • fixed a couple of files I checked in wrong
  • fast/html/body-offset-properties-expected.txt: Removed property cruft.
  • fast/html/body-offset-properties.html: Ditto.
7:00 PM Changeset in webkit [15474] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Change getProperty* to return undefined, rather than NULL, for missing properties, since that's what the spec says. Also added exception out parameters to the *Index functions, because they can call through to the regular functions, which can throw for custom objects.
  • API/JSObjectRef.cpp: (JSObjectGetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex):
  • API/JSObjectRef.h:
  • API/testapi.c: (main):
6:48 PM Changeset in webkit [15473] by ggaren
  • 6 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Properly document and handle NULL callbacks for static properties. We throw an exception in any case other than a ReadOnly property with a NULL setProperty callback, because a NULL callback almost certainly indicates a programming error. Also throw an exception if hasProperty returns true for a property that getProperty can't get.


  • If a static setProperty callback returns 'false', to indicate that the property was not set, we no longer forward the set request up the class chain, because that's almost certainly not what the programmer expected.
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::staticFunctionGetter): (KJS::JSCallbackObject::callbackGetter):
  • API/JSObjectRef.h:
  • API/minidom.js:
  • API/testapi.c: (MyObject_hasProperty):
  • API/testapi.js:
6:47 PM Changeset in webkit [15472] by mjs
  • 2 edits in trunk/LayoutTests
  • fixed typo in expected results
  • fast/js/for-in-avoid-duplicates-expected.txt:
5:37 PM Changeset in webkit [15471] by darin
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by John Sullivan (new test, not the changes to existing ones).

  • fast/html/body-offset-properties-expected.txt: Added.
  • fast/html/body-offset-properties.html: Added.
  • editing/execCommand/findString-2.html: Update to not depend on the buggy body.offseLeft/Top. Instead hardcode the default body margin of 8.
  • editing/pasteboard/drop-text-without-selection.html: Ditto.
  • editing/selection/click-before-and-after-table.html: Ditto.
  • editing/selection/mixed-editability-1.html: Ditto.
  • fast/table/click-near-anonymous-table.html: Ditto.
  • editing/selection/drag-to-contenteditable-iframe.html: Remove unnecessary use of body.offsetLeft/Top that are always 0.

WebCore:

Reviewed by John Sullivan.

The problem turns out to be the fact that body.offsetLeft is returning a non-zero value.
I have no idea why the menus worked in Tiger Safari, because body.offsetLeft behavior has not changed.
Presumably some other bug that we fixed had been compensating.

Test: fast/html/body-offset-properties.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): Always return 0 for any object without an offsetParent. (WebCore::RenderObject::offsetTop): Ditto. (WebCore::RenderObject::offsetParent): Return 0 for the body (treat as a special case).
5:25 PM Changeset in webkit [15470] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4616595> REGRESSION: Problems with world
clock widget clock hand motion on 9A211 + 4604574

The second hand on the widget was jiggling because the rotation was
messing up the use of the affine transformation matrix while
rounding to pixel boundaries in device space. We are mainly
concerned with rounding to pixel boundaries with the scale in mind,
so this patch extracts the scale to device space from the matrix,
and rounds to pixel boundaries using only the scale. This doesn't
seem like it is a perfect solution, but it definitely solves the
immediate problem. We will probably need to re-address what should
happen to avoid pixel cracks with rotations at non-integral scale
factors.

  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
3:17 PM Changeset in webkit [15469] by ggaren
  • 10 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Added names to functions.


  • Removed GetPrivate/SetPrivate from callbackFunctions and callbackConstructors. The private data idiom is that a JS object stores its native implementation as private data. For functions and constructors, the native implementation is nothing more than the callback they already store, so supporting private data, too, confuses the idiom. If you *really* want, you can still create a custom function with private data.
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction):
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeFunctionWithBody): (JSObjectGetPrivate): (JSObjectSetPrivate):
  • API/JSObjectRef.h:
  • API/minidom.c: (main):
  • API/testapi.c: (main):
2:06 PM Changeset in webkit [15468] by mjs
  • 31 edits
    5 adds
    5 deletes in trunk

JavaScriptCore:

Reviewed by Darin.


  • switch property lists to be vector+set of Identifiers instead of list of References


This has the following benefits:


  • no duplicates in property lists
  • simplifies API calls
  • probably more efficient, since linked list is gone
  • entirely removed Reference, ReferenceList and ProtectedReference types from the API
  • kjs/PropertyNameArray.cpp: Added. (KJS::PropertyNameArray::add): Check set, if not already there, add to vector.
  • kjs/PropertyNameArray.h: Added. (KJS::PropertyNameArray::PropertyNameArray): Newly added type, combines a set and a vector to make a unique but ordered list of identifiers. (KJS::PropertyNameArray::begin): ditto (KJS::PropertyNameArray::end): ditto (KJS::PropertyNameArray::size): ditto (KJS::PropertyNameArray::operator[]): ditto
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::getPropertyNames): renamed from getPropertyList, updated for PropertyNameArray (ArrayInstance::setLength): updated for PropertyNameArray (ArrayInstance::pushUndefinedObjectsToEnd): ditto
  • kjs/nodes.cpp: (ForInNode::execute): updated for PropertyNameArray
  • kjs/nodes.h:
  • kjs/object.cpp: (KJS::JSObject::getPropertyNames): renamed from getPropertyList, updated for PropertyNameArray
  • kjs/object.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::getEnumerablePropertyNames): updated for PropertyNameArray (KJS::PropertyMap::getSparseArrayPropertyNames): ditto
  • kjs/property_map.h:
  • kjs/protected_reference.h: Removed.
  • kjs/reference.cpp: Removed.
  • kjs/reference.h: Removed.
  • kjs/reference_list.cpp: Removed.
  • kjs/reference_list.h: Removed.
  • kjs/scope_chain.cpp: (KJS::ScopeChain::print): Use PropertyNamesArray instead of ReferenceList.
  • kjs/string_object.cpp: (StringInstance::getPropertyNames): Updated for new approach.
  • kjs/string_object.h:
  • kjs/ustring.h:
  • API/APICast.h: (toJS): Added overload for PropertyNameAccumulatorRef / PropertyNameArray* (toRef): ditto
  • API/JSBase.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getPropertyNames): Fixed for new API.
  • API/JSCallbackObject.h:
  • API/JSObjectRef.cpp: (JSPropertyNameArray::JSPropertyNameArray): Type used for a publicly vended JSPropertyNameArrayRef. (JSObjectCopyPropertyNames): New API call - renamed / refactored from JSObjectCreatePropertyList (JSPropertyNameArrayRetain): new retain call for JSPropertyNameArray. (JSPropertyNameArrayRelease): new release call for - " -. (JSPropertyNameArrayGetCount): Instead of having to use a stateful enumerator you can now get the count and items in any order. (JSPropertyNameArrayGetNameAtIndex): See above. (JSPropertyNameAccumulatorAddName): What you add properties to is now an opaque accumulator object.
  • API/JSObjectRef.h: Prototyped new functions, removed old ones
  • JavaScriptCore.exp: Updated exported symbols.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new files, removed old.
  • API/testapi.c: (MyObject_getPropertyNames): Renamed / fixed callback to fit new paradigm. (main): Updated for new API.

JavaScriptGlue:

Reviewed by Darin.

  • switch property lists to be vector+set of Identifiers instead of list of References


  • JSUtils.cpp: (KJSValueToCFTypeInternal): updated for JSC SPI changes
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): ditto
  • UserObjectImp.cpp: (UserObjectImp::getPropertyNames): ditto
  • UserObjectImp.h:

LayoutTests:

Reviewed by Darin.


  • new test case and updated results for property list changes
  • fast/js/for-in-avoid-duplicates-expected.txt: Added.
  • fast/js/for-in-avoid-duplicates.html: Added.
  • fast/js/kde/Array-expected.txt:
  • fast/js/resources/for-in-avoid-duplicates.js: Added.

Jul 15, 2006:

10:45 PM Changeset in webkit [15467] by thatcher
  • 1 edit in trunk/JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj

JavaScriptGlue has no need to look for frameworks in WebKit's umbrella framework path anymore.

10:22 PM Changeset in webkit [15466] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

WebCore has no need to look for frameworks in WebKit's umbrella framework path anymore.

7:26 PM Changeset in webkit [15465] by darin
  • 6 edits in trunk/JavaScriptCore
  • oops, missed a few more arrays that had to be const
  • API/JSNode.c: (JSNodePrototype_appendChild): Added const. (JSNodePrototype_removeChild): Ditto. (JSNodePrototype_replaceChild): Ditto. (JSNode_construct): Ditto.
  • API/JSNodeList.c: (JSNodeListPrototype_item): Ditto.
  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody): Ditto. (JSObjectCallAsFunction): Ditto. (JSObjectCallAsConstructor): Ditto.
  • API/minidom.c: (print): Ditto.
  • API/testapi.c: (MyObject_callAsFunction): Ditto. (MyObject_callAsConstructor): Ditto. (print_callAsFunction): Ditto. (myConstructor_callAsConstructor): Ditto.
7:18 PM Changeset in webkit [15464] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • API/JSNode.h: Made an array parameter const.
  • API/JSObjectRef.h: Made array parameters const. Fixed a comment.
6:40 PM Changeset in webkit [15463] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • JSObjectMakeFunctionWithBody includes a function name and named parameters now.
  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody):
  • API/JSObjectRef.h:
  • API/testapi.c: (assertEqualsAsUTF8String): More informative failure reporting. (main): Test more function cases.
6:28 PM Changeset in webkit [15462] by ggaren
  • 11 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • Moved the arguments passed to JSClassCreate into a single structure, called JSClassDefinition. This will enable easier structure migration/versioning in the future, if necessary.


  • Added support for class names.


  • kJSClassDefinitionNull replaces kJSObjectCallbacksNone.


  • JSClass is becoming a fairly complex struct, so I migrated all of its implementation other than reference counting to the sruct.


  • Also moved JSClass* functions in the API to JSObjectRef.cpp, since they're declared in JSObjectRef.h


  • Also added some more informative explanation to the class structure doc.
2:03 PM Changeset in webkit [15461] by darin
  • 2 edits in trunk/WebCore
  • fix mistake from fix for 8952 that was breaking layout tests
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Justin was right! I changed the behavior of the function by accident. Changed it back so that it doesn't blow away the selection on the DOM side in the case where it didn't before.

I will write 100 times on the blackboard: "When Justin says something about editing,
assume he is right."

1:00 PM Changeset in webkit [15460] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added StreamingTextDecoderICU.cpp/h.
12:41 PM Changeset in webkit [15459] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/dynamic/move-node-with-selection-expected.checksum: Added.
  • fast/dynamic/move-node-with-selection-expected.png: Added.
  • fast/dynamic/move-node-with-selection-expected.txt: Added.
  • fast/dynamic/move-node-with-selection.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/dynamic/move-node-with-selection.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Call updateRendering before calling clearSelection(), since it's important to do any work beforehand, and there are calls inside clearSelection that will indirectly do an updateRendering. Also change code to make fewer assumptions about object lifetime.
12:27 PM Changeset in webkit [15458] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/lists/numeric-markers-outside-list-expected.checksum: Added.
  • fast/lists/numeric-markers-outside-list-expected.png: Added.
  • fast/lists/numeric-markers-outside-list-expected.txt: Added.
  • fast/lists/numeric-markers-outside-list.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/lists/numeric-markers-outside-list.html

  • rendering/RenderListItem.cpp: (WebCore::previousListItem): Look for list items, even when we're outside any list.
10:22 AM Changeset in webkit [15457] by adele
  • 7 edits in trunk/WebCore

Reviewed by John.

  • Fix for <rdar://problem/4593970> REGRESSION (NativeTextField): autofill menu disappears after typing a 2nd character

This was caused by composite editing commands, (like typing or pasting) that include a DeleteCommand, being
interpreted by the form delegate as an actual delete. This fix doesn't notify the form delegate if the deletion is
part of an editing command to replace the selected text.

  • editing/DeleteSelectionCommand.h: Added m_replace to keep track of whether this deletion is part of a composite command to replace the text being deleted.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize m_replace. (WebCore::DeleteSelectionCommand::doApply): Only notify the form delegate of the deletion if the text is not being replaced.
  • editing/CompositeEditCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteSelection): Added replace argument to construct DeleteSelectionCommand.


  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call deleteSelection with replace argument.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): ditto.
9:31 AM Changeset in webkit [15456] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.


Layout test for crash when setting the dir property on a document with no body.

  • fast/dom/dir-no-body-expected.txt: Added.
  • fast/dom/dir-no-body.html: Added.

WebCore:

Reviewed by Maciej, tweaked to match Darin's patch.


  • Fixed <rdar://problem/4631837> REGRESSION: Reproducible crash on FCKeditor demo (9911)


  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Check for a null body element before forwarding the put request to it. I confirmed that no other parts of the file use 'body' or 'bodyElement' without checking for null.


Also, use 'body' rather than 'bodyElement' because dir can bet set on
any element, not just HTMLBodyElement.

8:30 AM Changeset in webkit [15455] by darin
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

Test: fast/js/regexp-extended-characters-more.html

  • pcre/pcre_exec.c: (match): Got rid of utf16Length local variable to guarantee there's no extra stack usage in recursive calls. Fixed two places in the PCRE_UTF16 code that were using the length variable, which is the UTF-8 length of a character in the pattern, to move in the UTF-16 subject string. Instead they hardcode lengths of 1 and 2 since the code already handles BMP characters and surrogate pairs separately. Also fixed some DPRINTF so I could compile with DEBUG on. (pcre_exec): Changed a place that was checking for multibyte characters in the subject string to use ISMIDCHAR. Instead it was using hardcoded logic that was right for UTF-8 but wrong for UTF-16.
  • pcre/pcre_compile.c: (pcre_compile2): Fixed a DPRINTF so I could compile with DEBUG on.

LayoutTests:

Reviewed by Geoff.

  • fast/js/regexp-extended-characters-more-expected.txt: Added.
  • fast/js/regexp-extended-characters-more.html: Added.
  • fast/js/resources/regexp-extended-characters-more.js: Added.
8:21 AM Changeset in webkit [15454] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/input-text-enter-expected.txt: Added.
  • fast/forms/input-text-enter.html: Added.

WebCore:

Reviewed by Adele.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::doTextFieldCommandFromEvent): Add a null check to fix the crash, and a FIXME explaining why this is not necessarily enough for the future.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Consume Enter key keypress events even if the element is not in a form.
  • platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): Added \n to the characters that turn into "Enter". Actual keyboard events always are \r or \003 on the Macintosh, but in layout tests we can use \n, and everything other than the code path here works, so worth fixing.
8:14 AM Changeset in webkit [15453] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/forms/select-selected-expected.checksum: Added.
  • fast/forms/select-selected-expected.png: Added.
  • fast/forms/select-selected-expected.txt: Added.
  • fast/forms/select-selected.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/forms/select-selected.html

  • rendering/RenderMenuList.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Added code to map the selected option index to a list index before using it to index into the list. (WebCore::RenderMenuList::showPopup): Added code to map the selection option index to a list index before passing it to the menu renderer. (WebCore::RenderMenuList::valueChanged): Added code to map the list index back to a option index before calling setSelectedIndex (that function takes an option index).
8:09 AM Changeset in webkit [15452] by darin
  • 6 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • bindings/objc/DOM.mm: (-[DOMNode addEventListener:::]): Moved into DOMEventTarget category. (-[DOMNode removeEventListener:::]): Ditto. (-[DOMNode dispatchEvent:]): Ditto.
  • WebCore.xcodeproj/project.pbxproj: Allow Xcode to do its thing.

WebKit:

Reviewed by John Sullivan.

  • WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): Moved into WebHTMLViewFileInternal category. (-[WebHTMLView selectionRect]): Moved into WebDocumentPrivateProtocols category. (-[WebHTMLView selectionView]): Ditto. (-[WebHTMLView selectionImageForcingWhiteText:]): Ditto. (-[WebHTMLView selectionImageRect]): Ditto. (-[WebHTMLView pasteboardTypesForSelection]): Ditto. (-[WebHTMLView selectAll]): Ditto. (-[WebHTMLView deselectAll]): Ditto. (-[WebHTMLView string]): Ditto. (-[WebHTMLView _attributeStringFromDOMRange:]): Ditto. (-[WebHTMLView attributedString]): Ditto. (-[WebHTMLView selectedString]): Ditto. (-[WebHTMLView selectedAttributedString]): Ditto. (-[WebHTMLView supportsTextEncoding]): Ditto. (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Moved into WebDocumentInternalProtocols. (-[WebHTMLView _isMoveDrag]): Ditto. (-[WebHTMLView _isNSColorDrag:]): Ditto. (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView elementAtPoint:]): Ditto. (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode 2.3 do its thing.
2:36 AM Changeset in webkit [15451] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Anders.

<rdar://problem/4632144> REGRESSION: table column tests failing as a result of very recent fix

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): columns and colgroups are valid children of a table too, not just table sections!
2:04 AM Changeset in webkit [15450] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-07-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.


  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Add null check for contentFrame() since content frames won't be created for invalid URLs.

LayoutTests:

2006-07-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.

  • http/tests/misc/iframe-invalid-source-crash-expected.txt: Added.
  • http/tests/misc/iframe-invalid-source-crash.html: Added.
Note: See TracTimeline for information about the timeline view.