⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 19, 2006:

10:11 PM Changeset in webkit [15540] by thatcher
  • 1 edit in tags/Safari-521.19/JavaScriptCore/Info.plist

Versioning

10:02 PM Changeset in webkit [15539] by thatcher
  • 3 edits in tags/Safari-521.19

Versioning

9:58 PM Changeset in webkit [15538] by thatcher
  • 16 edits
    3 copies
    17 deletes in tags/Safari-521.19

Rolled out changes that CCC denied.

<rdar://problem/4404312> REGRESSION: KOI8-U encoding no longer supported (4195)
<rdar://problem/4613467> REGRESSION: RegEx seems broken for hex escaped non breaking space (8395)
<rdar://problem/4613948> REGRESSION: Check Spelling does not work in textarea elements (9658)
<rdar://problem/4616595> REGRESSION: Problems with world clock widget clock hand motion on 9A211 + 4604574
<rdar://problem/4638376> lots of transparent 1x1 drawing in page load test (Image::checkSolidColor failing?)

9:15 PM Changeset in webkit [15537] by mjs
  • 5 edits in trunk/LayoutTests

Reviewed by Adele.


  • fixed layout test results that were affected by editing input paste patch -- new results are actually more correct, handling text fields properly as a replaced element.
  • editing/selection/3690703-2-expected.txt:
  • editing/selection/3690703-expected.txt:
  • fast/events/div-focus-expected.txt:
  • fast/text/textIteratorNilRenderer-expected.txt:
7:01 PM Changeset in webkit [15536] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10021
Bug 10021: REGRESSION: Stack overflow due to infinite recursion in
Image::checkForSolidColor

  • platform/Image.cpp: (WebCore::Image::cacheFrame): Don't call checkForSolidColor unless the frame was decoded successfully.
5:59 PM Changeset in webkit [15535] by thatcher
  • 1 copy in tags/Safari-521.19

new tag

5:47 PM Changeset in webkit [15534] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4523432> safari crashed right after disabling "block pop up windows" (or other WebPreferences changes)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): Stop the plug-in when it is removed from its superview. It is not sufficient to do this in -viewWillMoveToWindow:nil, because the WebView might still has a hostWindow at that point, which prevents the plug-in from being destroyed. There is no need to start the plug-in when moving into a superview. -viewDidMoveToWindow takes care of that.
4:56 PM Changeset in webkit [15533] by ggaren
  • 2 edits in trunk/JavaScriptGlue

Fixed by Darin & Maciej, reviewed by me.


  • Fixed <rdar://problem/4638934> Leopard 9A227: Installer crashes right after LCA and while preparing Installation

Compile release/production with NDEBUG set, to ensure binary compatibility
between JavaScriptGlue and JavaScriptCore. In debug builds, JavaScriptCore
includes an extra debug data member in HashSet.


  • JavaScriptGlue.xcodeproj/project.pbxproj:
4:54 PM Changeset in webkit [15532] by adele
  • 14 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4614181> REGRESSION: Crash in WebCore::RenderTextField::text() when quoting post at the Ars Technica forum (9707)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9707

Needs an http test. (​http://bugzilla.opendarwin.org/show_bug.cgi?id=10020)

These bugs were both cases where focus() was called on an element which didn't have a renderer yet because stylesheets hadn't finished loading yet.
Now, we detect this case and let setFocusNode be called. And when the stylesheet finishes loading, and the element attaches, a timer will fire,
which will cause the correct selection & scrolling behavior to occur.

This fix removes selection and scrolling behavior from the focus method. This code is now in a new method, updateFocusAppearance.
updateFocusAppearance can now be called directly from focus(), but it can also be called when a timer fires. This timer gets set
up when an element attaches, and its already been focused by the focus method. We have to use a timer, because updateFocusAppearance can cause
a layout to happen, and we don't want that to happen in the middle of attach().

  • bindings/objc/DOM.mm: (-[DOMElement isFocused]): Added SPI for autofill.
  • bindings/objc/DOMPrivate.h:
  • dom/Element.cpp: (WebCore::Element::Element): Initializes timer and needFocusAppearanceUpdate bool. (WebCore::Element::attach): Checks needsFocusAppearanceUpdate, and if the node is focused, then starts the timer. (WebCore::Element::focus): Updated to check supportsFocus before calling setFocusNode, and only requiring the element to be focusable now before updating focus appearance. (WebCore::Element::updateFocusAppearance): Added. Separates the selection, and the scrolling from focusing the node. (WebCore::Element::updateFocusAppearanceTimerFired): Stops the timer, and if the element is focusable, calls updateFocusAppearance. (WebCore::Element::stopUpdateFocusAppearanceTimer): Cancels timer, and setsNeedsFocusAppearanceUpdate(false). (WebCore::Element::detach): Calls stopUpdateFocusAppearanceTimer. (WebCore::Element::blur): ditto.
  • dom/Element.h: (WebCore::Element::needsFocusAppearanceUpdate): Added so the timer only fires when focus() methods have caused an element to be focused. (WebCore::Element::setNeedsFocusAppearanceUpdate): Added so focus methods can set this flag.
  • dom/Node.h: (WebCore::Node::supportsFocus): Added. Base class just calls isFocusable.
  • html/HTMLAnchorElement.h: Added supportsFocus.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): Added. Checks for the case where stylesheets haven't loaded yet, so we can still focus the node without a renderer, and when it gets a renderer, we'll update the focus appearance.
  • html/HTMLGenericFormElement.h: (WebCore::HTMLGenericFormElement::supportsFocus): ditto.
  • html/HTMLGenericFormElement.cpp: Removed include of Document.h since this is now in the header.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Updated to check supportsFocus before calling setFocusNode, and only requiring the element to be focusable now before updating focus appearance. (WebCore::HTMLInputElement::updateFocusAppearance): Added. Separates the selection, and the scrolling from focusing the node.
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Updated to check supportsFocus before calling setFocusNode, and only requiring the element to be focusable now before updating focus appearance. (WebCore::HTMLTextAreaElement::updateFocusAppearance): Added. Separates the selection, and the scrolling from focusing the node.
  • html/HTMLTextAreaElement.h:
3:55 PM Changeset in webkit [15531] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4631972>
REGRESSION: Mail crashes when pasting entire contents of ​http://www.apple.com/support/ into a new mail message

  • editing/pasteboard/4631972-expected.checksum: Added.
  • editing/pasteboard/4631972-expected.png: Added.
  • editing/pasteboard/4631972-expected.txt: Added.
  • editing/pasteboard/4631972.html: Added.
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/replaced-boundaries-3-expected.checksum:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/selection/select-box-expected.txt:

WebCore:

Reviewed by levi


<rdar://problem/4631972>
REGRESSION: Mail crashes when pasting entire contents of ​http://www.apple.com/support/ into a new mail message

  • dom/Position.cpp: (WebCore::Position::upstream): Deployed isBlock and enclosingBlock. (WebCore::Position::downstream): Ditto.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Ditto.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added !iframe. (WebCore::isBlock): Added, returns !node->renderer()->isInline() (WebCore::enclosingBlock): Added.
  • editing/htmlediting.h:
3:32 PM Changeset in webkit [15530] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-07-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

<rdar://problem/4631272> REGRESSION: Crash tabbing out of hostname field at autorestore.apple.com


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame): Take into account that focus handlers can cause a node to be destroyed.

LayoutTests:

2006-07-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

<rdar://problem/4631272> REGRESSION: Crash tabbing out of hostname field at autorestore.apple.com


  • fast/forms/display-none-in-onchange-keyboard-expected.txt: Added.
  • fast/forms/display-none-in-onchange-keyboard.html: Added.
2:49 PM Changeset in webkit [15529] by hyatt
  • 5 edits in trunk/WebCore

Fix for 4638376. The 1x1 solid color image optimization was broken when
I re-architected image. This patch restores the optimization for CG. Cairo
will still need the optimization.

Reviewed by darin

WARNING: NO TEST CASES ADDED OR CHANGED (need test cases still)

  • platform/Image.cpp: (WebCore::Image::Image): (WebCore::Image::invalidateData): (WebCore::Image::cacheFrame):
  • platform/Image.h: (WebCore::Image::setIsPDF):
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::checkForSolidColor):
  • platform/mac/ImageMac.mm: (WebCore::Image::initNativeData): (WebCore::Image::invalidateNativeData): (WebCore::Image::checkForSolidColor): (WebCore::Image::draw): (WebCore::Image::drawTiled):
12:01 PM Changeset in webkit [15528] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4613519>
REGRESSION: Pasting text in native text area inserts text one character before it should (9527)

  • fast/forms/paste-into-textarea-expected.checksum: Added.
  • fast/forms/paste-into-textarea-expected.png: Added.
  • fast/forms/paste-into-textarea-expected.txt: Added.
  • fast/forms/paste-into-textarea.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4613519>
REGRESSION: Pasting text in native text area inserts text one character before it should (9527)

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Turn into an InsertLineBreakCommand instead of bailing if the enclosingBlockFlowElement doesn't have a parent.
11:30 AM Changeset in webkit [15527] by andersca
  • 3 edits in trunk/LayoutTests

2006-07-19 Anders Carlsson <​acarlsson@apple.com>

  • fast/js/pretty-print-expected.txt: Update result.


  • fast/js/resources/pretty-print.js: Fix description string.
10:32 AM Changeset in webkit [15526] by andersca
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2006-07-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

<rdar://problem/4620655> REGRESSION(10.4.7-10.5): preview button for a blogger.com post doesn't work


  • kjs/nodes2string.cpp: (StringNode::streamTo): Return the escaped string.


(RegExpNode::streamTo):
Use the correct syntax.


  • kjs/function.cpp: (KJS::escapeStringForPrettyPrinting):
  • kjs/function.h: Add escape function which escapes a string for pretty-printing so it can be parsed again.


  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isPrintableChar): New function.

LayoutTests:

2006-07-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

<rdar://problem/4620655> REGRESSION(10.4.7-10.5): preview button for a blogger.com post doesn't work


  • fast/js/pretty-print-expected.txt: Added.
  • fast/js/pretty-print.html: Added.
  • fast/js/resources/pretty-print.js: Added.
10:24 AM Changeset in webkit [15525] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

<rdar://problem/4629307> -[DOMRange markupString] does not include the initial table element if it is at the beginning of the range
<rdar://problem/4062218> pasting in contents of web.apple.com strips off the <table> element from the first table

(this really only tests the symptoms of <rdar://problem/4062218>, because -[DOMRange markupString] is not testable)


  • editing/pasteboard/paste-table-003-expected.checksum: Added.
  • editing/pasteboard/paste-table-003-expected.png: Added.
  • editing/pasteboard/paste-table-003-expected.txt: Added.
  • editing/pasteboard/paste-table-003.html: Added.

WebCore:

Reviewed by Tim Hatcher.

<rdar://problem/4629307> -[DOMRange markupString] does not include the initial table element if it is at the beginning of the range
<rdar://problem/4062218> pasting in contents of web.apple.com strips off the <table> element from the first table


Better patch than previous checkin.

  • test: editing/pasteboard/paste-table-003.html


  • editing/markup.cpp: (WebCore::createMarkup): Make sure to include the table when including a tbody.
8:26 AM Changeset in webkit [15524] by thatcher
  • 6 edits in /

Versioning

7:50 AM Changeset in webkit [15523] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

<rdar://problem/4629307> -[DOMRange markupString] does not include the initial table element if it is at the beginning of the range

No test case as this can only be reproduced through ObjC APIs.

  • editing/markup.cpp: (WebCore::createMarkup): Adjust the range for ancestor markup handling when main loop skips first node.
12:06 AM Changeset in webkit [15522] by mjs
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Adele Peterson.


<rdar://problem/4589530> REGRESSION: null character in JS string causes parse error (works in Tiger and in other browsers)

  • kjs/lexer.cpp: (Lexer::shift): (Lexer::lex): (Lexer::record16): (Lexer::scanRegExp):
  • kjs/lexer.h:

LayoutTests:

Reviewed by Adele Peterson.


Test case for:


<rdar://problem/4620646> REGRESSION(10.4.7-10.5): can't type into editing region when creating or editing a blogger.com post

  • fast/js/null-char-in-string-expected.txt: Added.
  • fast/js/null-char-in-string.html: Added.
  • fast/js/resources/null-char-in-string.js: Added.

Jul 18, 2006:

10:38 PM Changeset in webkit [15521] by thatcher
  • 4 edits in /

Adding versioning and markers from earlier.

9:39 PM Changeset in webkit [15520] by thatcher
  • 2 edits in tags/JavaScriptCore-521.18.1/JavaScriptCore

Fix hard wrap issue that I forogt to check in before submitting.

9:37 PM Changeset in webkit [15519] by thatcher
  • 1 copy in tags/JavaScriptCore-521.18.1/JavaScriptCore

New tag (part 2)

9:36 PM Changeset in webkit [15518] by thatcher
  • 1 add in tags/JavaScriptCore-521.18.1

new tag.

9:05 PM Changeset in webkit [15517] by hyatt
  • 4 deletes in trunk/LayoutTests/fast/css

Remove the font property compatibility test, since we no longer want to be compatible.

7:44 PM Changeset in webkit [15516] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Timothy.

  • Scripts/prepare-ChangeLog: Added --[no-]update switch.
5:32 PM Changeset in webkit [15515] by hyatt
  • 1 edit in trunk/WebCore/css/cssparser.cpp

Tweak a comment in cssparser.

5:16 PM Changeset in webkit [15514] by hyatt
  • 6 edits in trunk/WebCore

Fix for radar 4611287, make resizable text fields opt-in rather than
opt-out. Open source users will need to write the pref into their defaults
to see the resizers on textareas now.

Reviewed by mjs and adele

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setTextAreasAreResizable:]):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/html4.css:
4:03 PM Changeset in webkit [15513] by thatcher
  • 12 edits in tags/Safari-521.18

Merging important fixes.

3:56 PM Changeset in webkit [15512] by tomernic
  • 2 edits in trunk/JavaScriptCore

Reviewed by Tim Hatcher.

Removed a misleading comment; we recently added support for the NPNVPluginElementNPObject
variable.

  • bindings/npapi.h:
3:09 PM Changeset in webkit [15511] by thatcher
  • 77 edits
    6 copies
    7 deletes in tags/Safari-521.18

Merged urgent fixes to a new tag.

1:43 PM Changeset in webkit [15510] by brmorris
  • 33 edits in S60/trunk/WebKit

2006-07-18 Bradley <​bradley.morrison@nokia.com>

Reviewed by Sachin/Zalan.


Various fixes - see ChangeLogs for details.
Part 4 of 4.

1:38 PM Changeset in webkit [15509] by brmorris
  • 34 edits in S60/trunk/WebKit

2006-07-17 Bradley <​bradley.morrison@nokia.com>

Reviewed by Sachin/Zalan.


Various fixes - see ChangeLogs for details.
Part 3 of 4.

1:31 PM Changeset in webkit [15508] by brmorris
  • 26 edits in S60/trunk/WebCore

2006-07-17 Bradley <​bradley.morrison@nokia.com>

Reviewed by Sachin/Zalan.


Various fixes - see ChangeLogs for details.
Part 2 of 4.

1:22 PM Changeset in webkit [15507] by brmorris
  • 21 edits
    5 adds
    1 delete in S60/trunk

2006-07-17 Bradley <​bradley.morrison@nokia.com>

Reviewed by Sachin/Zalan.

Various fixes - see ChangeLogs for details.
Part 1 of 4.

1:22 PM Changeset in webkit [15506] by andersca
  • 5 edits
    2 adds in trunk

WebCore:

2006-07-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9959
REGRESSION: iframes stop rendering after 200th one on successive reloads


  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::attach): (WebCore::HTMLFrameElement::close):
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::willRemove): Remove calls to incrementFrameCount and decrementFrameCount.


  • page/Frame.cpp: (WebCore::Frame::Frame): Call incrementFrameCount here.


(WebCore::Frame::~Frame):
Call disconnectOwnerElement.


(WebCore::Frame::disconnectOwnerElement):
Call decrementFrameCount here.


LayoutTests:

2006-07-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9959
REGRESSION: iframes stop rendering after 200th one on successive reloads

  • fast/frames/frame-limit-expected.txt: Added.
  • fast/frames/frame-limit.html: Added.
12:56 PM Changeset in webkit [15505] by ap
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9013
Let correct CSS custom cursor declarations parse

  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Ignore any values following a custom CSS cursor URI, instead of requiring that it is the only one in the list (which is actually illegal, according to the spec). This is only a temporary hack, with a real implementation to follow in bug 6001/6002.
  • manual-tests/custom-cursors.html: Added a test for this issue.
  • manual-tests/resources/helpCursor.tiff: A cursor image used in the test.
12:28 PM Changeset in webkit [15504] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Anders.


<rdar://problem/4636216> NetNewsWire fails to launch on 9A224 - missing symbols


WebCore needs to add -sub_library libobjc to maintain
backwards compatibility with binaries linked with WebKit
before JavaScriptCore moved out of WebKit.

  • WebCore.xcodeproj/project.pbxproj:
10:56 AM Changeset in webkit [15503] by thatcher
  • 1 copy in tags/Safari-521.18

New tag.

10:03 AM Changeset in webkit [15502] by darin
  • 5 edits
    4 deletes in trunk/LayoutTests

Reviewed by Alice.

  • convert a couple of tests to "dump as text" tests
  • fast/dom/css-selectorText-expected.checksum: Removed.
  • fast/dom/css-selectorText-expected.png: Removed.
  • fast/dom/css-selectorText-expected.txt: Replaced render tree results with text results.
  • fast/dom/css-selectorText.html: Added a call to layoutTestController.dumpAsText.
  • fast/dom/css-shortHands-expected.checksum: Removed.
  • fast/dom/css-shortHands-expected.png: Removed.
  • fast/dom/css-shortHands-expected.txt: Replaced render tree results with text results.
  • fast/dom/css-shortHands.html: Added a call to layoutTestController.dumpAsText.
9:01 AM Changeset in webkit [15501] by thatcher
  • 2 edits in trunk/JavaScriptCore

Made the following headers public:

  • JavaScriptCore.h
  • JSBase.h
  • JSContextRef.h
  • JSObjectRef.h
  • JSStringRef.h
  • JSValueRef.h
3:55 AM Changeset in webkit [15500] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin. Patch by Mitz.

  • editing/selection/click-start-of-line-expected.checksum: Added.
  • editing/selection/click-start-of-line-expected.png: Added.
  • editing/selection/click-start-of-line-expected.txt: Added.
  • editing/selection/click-start-of-line.html: Added.

WebCore:

Reviewed by Justin. Patch by Mitz.

Test: editing/selection/click-start-of-line.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Changed to return downstream affinity if the x coordinate is to the left of the middle of the first character in the text box.
2:24 AM Changeset in webkit [15499] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-07-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9695
<rdar://problem/4614085>
TOT REGRESSION: NativeTextArea: Text area does not respond to Cmd-UpArrow/Cmd-DownArrow (9695)


  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): If the caret is inside an editable region, the beginning/end of the document should actually be the beginning/end of the editable region.

LayoutTests:

2006-07-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9695
<rdar://problem/4614085>
TOT REGRESSION: NativeTextArea: Text area does not respond to Cmd-UpArrow/Cmd-DownArrow (9695)


  • editing/selection/move-begin-end-expected.txt: Added.
  • editing/selection/move-begin-end.html: Added.
Note: See TracTimeline for information about the timeline view.