Timeline

Jul 22, 2006:

6:37 PM Changeset in webkit [15580] by thatcher

• 2 edits in trunk/WebKit

Rolling out r15572.

Bug 10062: REGRESSION: dom/xhtml/level2/html/HTMLIFrameElement11.xhtml asserts/crashes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10062

2006-07-21 Timothy Hatcher <​timothy@apple.com>

Reviewed by Maciej.

<rdar://problem/4609195> Help Viewer loads empty window
(not getting didFailLoadingWithError: callback)

Call super's didFailWithError before _receivedMainResourceError
because _receivedMainResourceError will cause the datasource's
frame to be set to nil before the didFailLoadingWithError delegate
callback is sent. (This order is needed now that WebDataSource does
not hold on to the WebView; it uses the WebFrame to get to the WebView.
If the WebFrame is nil we can't get to the WebView's resource load delegate.)

• WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]):

4:06 PM Changeset in webkit [15579] by thatcher

• 2 edits in tags/Safari-521.20/WebKit

Merging in '<rdar://problem/4646318> REGRESSION: Ctrl-clicking on a selection containing a word doesn't display a complete contextual menu' and build fixes.

3:56 PM Changeset in webkit [15578] by thatcher

• 2 edits in trunk/WebKit

Reviewed by Adele.

<rdar://problem/4646318> REGRESSION: Ctrl-clicking on a selection containing a word doesn't display a complete contextual menu

Show the editing context menu if the WebView is editible.
The original change only checked if the DOM element was editable,
and isContentEditable returns NO if entire WebView is editable.

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):

3:45 PM Changeset in webkit [15577] by thatcher

• 4 edits in tags/Safari-521.20/WebCore/platform

Rolling out r15529 because of <rdar://problem/4646196> REGRESSION: Artifacts are painted around Business, Calendar, Address Book, Translation, and Stocks

3:24 PM Changeset in webkit [15576] by thatcher

• 1 edit in tags/Safari-521.20/WebCore/platform/cg/GraphicsContextCG.cpp

Rolling back in <rdar://problem/4616595> REGRESSION: Problems with world clock widget clock hand motion on 9A211 + 4604574 now that is was CCC approved.

10:45 AM Changeset in webkit [15575] by thatcher

• 9 edits in tags/Safari-521.20

Rolling out changes that are not CCC approved. r15435, r15455, r15470 and r15553

10:41 AM Changeset in webkit [15574] by thatcher

• 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix.

12:39 AM Changeset in webkit [15573] by ap

• 3 edits
  3 adds in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10038
REGRESSION: Length of navigator.mimeTypes collection returns number of installed plugins, not number
of registered mime types

Test: fast/js/navigator-mimeTypes-length.html

• bindings/js/kjs_navigator.cpp: (KJS::MimeTypes::getValueProperty): Return the length of the mime types vector, not the plugins one. (KJS::MimeTypes::getOwnPropertySlot): Fixed another typo, which prevented MimeTypes::getValueProperty() from even being called.

Jul 21, 2006:

11:34 PM Changeset in webkit [15572] by thatcher

• 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4609195> Help Viewer loads empty window
(not getting didFailLoadingWithError: callback)

Call super's didFailWithError before _receivedMainResourceError
because _receivedMainResourceError will cause the datasource's
frame to be set to nil before the didFailLoadingWithError delegate
callback is sent. (This order is needed now that WebDataSource does
not hold on to the WebView; it uses the WebFrame to get to the WebView.
If the WebFrame is nil we can't get to the WebView's resource load delegate.)

• WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]):

10:31 PM Changeset in webkit [15571] by mjs

• 12 edits
  1 add in trunk/WebCore

Reviewed by Adele and Tim Omernick.

<rdar://problem/4641004> 9A224: Safari crashes in WebCore::RenderMenuList::showPopup when changing a input select field to input text field

Couldn't figure out how to make layout test, here's a manual test:

• manual-tests/remove-select-onchange.html: Added.

• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::showPopup): Don't add the RenderPopupMenu to the render tree so it doesn't get destroyed if we do.

The remaining changes are to let the RenderPopupMenu know its menu list w/o having
to be in the render tree:

• rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::RenderPopupMenu):
• rendering/RenderPopupMenu.h: (WebCore::RenderPopupMenu::menuList):
• rendering/RenderPopupMenuMac.h:
• rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::RenderPopupMenuMac):
• rendering/RenderPopupMenuWin.h: (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
• rendering/RenderTheme.h:
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::createPopupMenu):
• rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::createPopupMenu):
• rendering/RenderThemeWin.h:

8:05 PM Changeset in webkit [15570] by darin

• 1 edit in trunk/WebCore/ChangeLog

Removed a stray conflict marker.

7:24 PM Changeset in webkit [15569] by adele

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for: <rdar://problem/4643238> REGRESSION: Can't set insertion point at the end of a line of text

• fast/forms/textarea-scrolled-endline-caret-expected.txt: Added.
• fast/forms/textarea-scrolled-endline-caret.html: Added.

WebCore:

Reviewed by Darin.

Fix for: <rdar://problem/4643238> REGRESSION: Can't set insertion point at the end of a line of text

Test: fast/forms/textarea-scrolled-endline-caret.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): When looking for the closest line box, take the scroll offset into account.

7:17 PM Changeset in webkit [15568] by ggaren

• 1 edit
  2 adds in trunk/LayoutTests

RS by Adele.

Test for whether focusing and/or blurring a frame before its content has loaded causes
a crash. <rdar://problem/4632505> REGRESSION: Crash at
WebCore::Widget::getView() const + 6

• http/tests/incremental/frame-focus-before-load-expected.txt: Added.
• http/tests/incremental/frame-focus-before-load.html: Added.

7:14 PM Changeset in webkit [15567] by ggaren

• 1 edit in trunk/WebCore/bridge/mac/FrameMac.mm

minor comment fixup

6:48 PM Changeset in webkit [15566] by tomernic

• 2 edits in trunk/WebCore

Reviewed by Geoff & Maciej.

<rdar://problem/4632505> REGRESSION: Crash at WebCore::Widget::getView() const + 6

Geoff is working on a layout test for this.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::focusWindow): (WebCore::FrameMac::unfocusWindow): Check for a NULL view. The view can be NULL if the frame has not yet loaded any data. This fixes the crash, but the behavior is still wrong -- we should focus the frame once it gets a view. I've filed <rdar://problem/4645685> to track that. It's not as urgent as this crasher.

5:45 PM Changeset in webkit [15565] by mjs

• 4 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4523976> REGRESSION (NativeTextField): Crash occurs when choosing "Undo Typing" after typing and setting the value

• fast/forms/text-field-setvalue-crash-expected.txt: Added.
• fast/forms/text-field-setvalue-crash.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4523976> REGRESSION (NativeTextField): Crash occurs when choosing "Undo Typing" after typing and setting the value

• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): Clear the undo chain when the text control contents have been set programmatically.
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::clearUndoRedoOperations): Before clearing undo stack, close all open undo groups and then open an equal number, since otherwise NSUndoManager ends up in an inconsistent state leading to uncaught ObjC exceptions.

4:47 PM Changeset in webkit [15564] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Darin.

Just moving this assertion down a couple of lines. It was hitting
every time you try to print a page because we put it too early in
the function.

• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):

4:38 PM Changeset in webkit [15563] by justing

• 10 edits
  4 adds in trunk

LayoutTests:

Reviewed by levi

<rdar://problem/4548238>
REGRESSION: Can't remove the first OL/UL list item in a Mail's compose window

• editing/deleting/delete-first-list-item-expected.checksum: Added.
• editing/deleting/delete-first-list-item-expected.png: Added.
• editing/deleting/delete-first-list-item-expected.txt: Added.
• editing/deleting/delete-first-list-item.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4548238>
REGRESSION: Can't remove the first OL/UL list item in a Mail's compose window

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Moved from InsertParagraphSeparator. Does its own typing style restoration.
• editing/CompositeEditCommand.h:
• editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Call breakOutOfEmptyListItem.
• editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Call breakOutOfEmptyListItem if the endingSelection is at the start of an editable region.
• editing/htmlediting.cpp: (WebCore::embeddedSublist): Moved from InsertParagraphSeparator. (WebCore::appendedSublist): Ditto. (WebCore::enclosingEmptyListItem): Ditto.
• editing/htmlediting.h:

4:10 PM Changeset in webkit [15562] by thatcher

• 10 copies in tags/Safari-521.20

New tag.

3:55 PM Changeset in webkit [15561] by thatcher

• 9 edits in /

Versioning

2:36 PM Changeset in webkit [15560] by thatcher

• 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/4607572> REGRESSION (521.10.1 - 521.13): most context menu items missing when a form field is focused (common on google.com) (9680)

Do not use _isEditable call since that only checks if the current
selection or frame is editible. We now check if the currently clicked element
is a content editible area, a textarea, an isindex or an input element that
return YES to _isTextField.

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):

1:16 PM Changeset in webkit [15559] by tomernic

• 2 edits in trunk/WebCore

Reviewed by Beth Dakin & John Sullivan.

<rdar://problem/4633717> 9A218: Reproducible crash in -[NSScroller mouseDown:]

Beth is in the middle of making a layout test for this; she will land it soon.

• platform/mac/ScrollBarMac.mm: (ScrollBar::~ScrollBar): Call Widget::removeFromSuperview() rather than -removeFromSuperview directly on the scroll bar view. Widget::removeFromSuperview() obeys the "mustStayInWindow" flag, which is set while tracking the mouse in view-based widgets to prevent their destruction while the tracking is in progress. I searched around WebCore and this is the only Widget subclass that directly removes its view rather than using removeFromSuperview().

1:01 PM Changeset in webkit [15558] by adele

• 9 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

• editing/selection/select-all-iframe-expected.txt:
• editing/selection/select-from-textfield-outwards-expected.checksum: Added.
• editing/selection/select-from-textfield-outwards-expected.png: Added.
• editing/selection/select-from-textfield-outwards-expected.txt: Added.
• editing/selection/select-from-textfield-outwards.html: Added.
• fast/events/drag-outside-window-expected.txt:

WebCore:

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9312 REGRESSION: Selection bug in new text fields when selecting past the first letter

Test: editing/selection/select-from-textfield-outwards.html

• editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Added code to handle the case where the selection starts (resp. ends) in the last (resp. first) visual position inside an editable root.
• editing/htmlediting.cpp: (WebCore::comparePositions): Fixed the case of comparing a position inside a shadow tree with a position in the shadow ancestor.
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): For coordinates outside a replaced object, return the position just before (after) the element if the coordinates are above or to the left (below or to the right).
• rendering/RenderObject.cpp: (WebCore::RenderObject::caretMaxOffset): Changed to return 1 for replaced objects.
• rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Changed to return the last position in the lowest text box if the y coordinate is below all text boxes.

11:50 AM Changeset in webkit [15557] by ggaren

• 7 edits
  3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

• Added support for strings that masquerade as undefined. Currently used by WebCore to implement undetectable style.filter.

The name is a little long, but it's only used in one line of code, so I
thought clarity should win over brevity.

• JavaScriptCore.exp:
• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/object.h:
• kjs/string_object.h: (KJS::StringInstanceThatMasqueradesAsUndefined::StringInstanceThatMasqueradesAsUndefined): (KJS::StringInstanceThatMasqueradesAsUndefined::masqueradeAsUndefined): (KJS::StringInstanceThatMasqueradesAsUndefined::toBoolean):

LayoutTests:

Test for undetectable style.filter property.

• fast/dom/undetectable-style-filter-expected.txt: Added.
• fast/dom/undetectable-style-filter.html: Added.

WebCore:

Reviewed by Darin.

• Fixed <rdar://problem/4507265> REGRESSION: overlays don't work on HousingMaps.com (Google Maps-based site)

• Made style.filter undetectable, like document.all.

Unfortunately, the SVG spec-makers invented a CSS attribute named 'filter',
which conflicts with IE's custom CSS attribute by the same name. Web programs
like the Google maps API test for style.filter, and assume it's the IE
style.filter if they find it, so we need to make style.filter undetectable
to avoid breaking them.

An alternative solution would be to hotwire a delorean, go back in time,
and beg the web standards makers to make standards that work on the web.

• bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::cssPropertyGetter):

11:39 AM Changeset in webkit [15556] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4641033>
REGRESSION: Pasting from web pages into Mail (or Blot) often loses most of the content

• editing/pasteboard/4641033-expected.checksum: Added.
• editing/pasteboard/4641033-expected.png: Added.
• editing/pasteboard/4641033-expected.txt: Added.
• editing/pasteboard/4641033.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4641033>
REGRESSION: Pasting from web pages into Mail (or Blot) often loses most of the content

• editing/markup.cpp: (WebCore::createMarkup): We surround the currently accumulated markup with markup for ancestors of the startNode when the pre-order traversal leaves the trees rooted at those ancestors. We assumed that any ancestors of the current node not in the ancestorsToClose list were those kind of ancestors. But we don't add renderer-less containers to the ancestorsToClose list. So, we were incorrectly surrounding the currently accumulated markup with markup for render-less containers. Most of the content at apple.com was being put inside an <optgroup> inside a <select> element. Then on Paste createContextualFragment would drop it.

11:06 AM Changeset in webkit [15555] by brmorris

• 1 edit
  1 delete in S60/trunk/JavaScriptCore

2006-07-21 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.

• JavaScriptCore/.cvsignore: Removed.

8:28 AM Changeset in webkit [15554] by brmorris

• 15 edits
  25 adds
  3 deletes in S60/trunk

2006-07-20 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin/Zalan.

• Distribution.Policy.S60 files: Added.
• Cleaned JavaScriptCore
• Minor fixes (see ChangeLogs)

12:56 AM Changeset in webkit [15553] by andersca

• 5 edits in trunk/WebCore

2006-07-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

• dom/Document.h: (WebCore::Document::):
• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::addEventListener):
• page/FrameView.cpp: (WebCore::FrameView::layout):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Only dispatch overflowchanged events if overflowchanged event listeners have been registered on the document.

12:52 AM Changeset in webkit [15552] by andersca

• 4 edits
  2 adds in trunk

WebCore:

2006-07-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

<rdar://problem/4637807> REGRESSION: "Features & Options" page at volvocars.us fails

• xml/XSLTProcessor.cpp: (WebCore::xsltParamArrayFromParameterMap): Turns out parameters never worked. String parameters need to be escaped so we create a transform context, add the parameters to it quoted and then use xsltApplyStylesheetUser which lets us pass the transform context to it. This also works around a bug in libxslt where a hash table isn't allocated.

LayoutTests:

2006-07-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

<rdar://problem/4637807> REGRESSION: "Features & Options" page at volvocars.us fails

• fast/xsl/xslt-processer-expected.txt: This passes now.

• fast/xsl/xslt-string-parameters-expected.txt: Added.
• fast/xsl/xslt-string-parameters.html: Added.