⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 23, 2006:

11:06 PM Changeset in webkit [15593] by thatcher
  • 16 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9686

JavaScriptCore portion of the fix.

  • JavaScriptCore.exp: Update symbol for change in argument type.
  • kjs/debugger.cpp: (Debugger::detach): Clear map of recent exceptions. (Debugger::hasHandledException): Track the most recent exception thrown by an interpreter. (Debugger::exception): Change exception argument to a JSValue.
  • kjs/debugger.h:
  • kjs/nodes.cpp: (Node::debugExceptionIfNeeded): Notify the debugger of an exception if it hasn't seen it before. (ThrowNode::execute): Notify the debugger that an exception is being thrown.
  • kjs/nodes.h:

2006-07-23 Geoffrey Garen <​ggaren@apple.com>

Patch by Eric Albert, reviewed by Darin and me.


  • Fixed <rdar://problem/4645931> JavaScriptCore stack-scanning code crashes (Collector::markStackObjectsConservatively)


  • bindings/jni/jni_jsobject.cpp: On 64bit systems, jint is a long, not an int. (JavaJSObject::getSlot): (JavaJSObject::setSlot):
  • kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): Use a pointer instead of an int as 'dummy,' because on LP64 systems, an int is not pointer-aligned, and we want to scan the stack for pointers.
  • JavaScriptCore.xcodeproj/project.pbxproj: After a tense cease-fire, the XCode war has started up again!

WebCore:

Reviewed by maciej.

Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9686

WebCore portion of the fix.

  • bridge/mac/WebCoreScriptDebugger.h: (-[WebScriptDebugger exceptionRaised:sourceId:line::]): Add delegate method.
  • bridge/mac/WebCoreScriptDebugger.mm: (WebCoreScriptDebuggerImp::exception): Call delegate method when an exception is raised.

WebKit:

Reviewed by Maciej.

Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9686

WebKit portion of the fix.

  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: (-[WebDefaultScriptDebugDelegate webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServer.h:
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]): Notify listeners that an exception has been raised.
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame exceptionRaised:sourceId:line:]): Dispatch through to delegate and WebScriptDebugServer.
8:21 PM Changeset in webkit [15592] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Reviewed by Adele.
Actually Adele figured out how to fix the layout test failures. Landing this patch for her. Layout test failures exposed but not caused by r15584 (my patch earlier today).

  • editing/visible_units.cpp: (WebCore::previousLinePosition): When setting selection endpoints, don't traverse down into nodes where editing would ignore its contents. Use the parent node instead. (WebCore::nextLinePosition): same as above
7:53 PM Changeset in webkit [15591] by aliceli1
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Adele.
Actually Adele figured out how to fix the layout test failures. Landing this patch for her. Layout test failures exposed but not caused by r15584 (my patch earlier today).

  • editing/visible_units.cpp: (WebCore::previousLinePosition): When setting selection endpoints, don't traverse down into nodes where editing would ignore its contents. Use the parent node instead. (WebCore::nextLinePosition): same as above
7:51 PM Changeset in webkit [15590] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Adele.
Actually Adele figured out how to fix the layout test failures. Landing this patch for her.

  • editing/visible_units.cpp: (WebCore::previousLinePosition): When setting selection endpoints, don't traverse down into nodes where editing would ignore its contents. Use the parent node instead. (WebCore::nextLinePosition): same as above
7:43 PM Changeset in webkit [15589] by thatcher
  • 13 edits
    4 deletes in branches/Safari-521

Rolling out CCC denied changes. r15553, r15536, r15529, r15455 and r15435.

6:41 PM Changeset in webkit [15588] by thatcher
  • 5 copies in branches/Safari-521

New branch

5:16 PM Changeset in webkit [15587] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by timo.

<rdar://problem/4646759> Mail crash editing To Do - WebCore::InsertTextCommand::prepareForTextInsertion

  • editing/deleting/delete-mixed-editable-content-001-expected.checksum: Added.
  • editing/deleting/delete-mixed-editable-content-001-expected.png: Added.
  • editing/deleting/delete-mixed-editable-content-001-expected.txt: Added.
  • editing/deleting/delete-mixed-editable-content-001.html: Added.

WebCore:

Reviewed by timo.

<rdar://problem/4646759> Mail crash editing To Do - WebCore::InsertTextCommand::prepareForTextInsertion


  • Test: editing/deleting/delete-mixed-editable-content-001.html
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Respect editable boundary the same way endOfParagraph does.
4:40 PM Changeset in webkit [15586] by adele
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • Fix for <rdar://problem/4646276> CrashTracer: 7 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 155
  • WebView/WebHTMLView.m: (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): needsDisplay was returning NO even though the view has a dirty rect (see <rdar://problem/4647062>). Since we know about the dirty rect, we don't actually need to check needsDisplay.
4:36 PM Changeset in webkit [15585] by bdakin
  • 7 edits in trunk/WebCore

Reviewed by Maciej. (Patch by me, Maciej, and Harrison.)

Fix for <rdar://problem/4529398> WebCore crashes when pasting rich
text - WebCore::InlineBox::root()

The initial rendering crash was due to a render object having a
stale reference to an inline box that had already been deleted and
then recreated in the exact same location in memory. (Crazy, I
know.) The situation seemed pretty specific to list markers
according to Hyatt according to Maciej, so that is what I patched
specifically. Fixing this crash unearthed a separate editing crash
where we were trying to insert a block into itself. I worked on
that with Maciej and Harrison, and Harrison came up with a fix.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): This is the fix for the editing crash. If paragraphStart is an atomic node, insert the new block into the parent instead.
  • rendering/InlineBox.cpp: (WebCore::InlineBox::isChildOfParent): This function is for posterity. It will help keep the linebox tree in check.
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::addToLine): Added assert. (WebCore::InlineFlowBox::deleteLine): Added assert.
  • rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::destroy): If this has a parent, call removeChild on this. (WebCore::ListMarkerBox::operator delete):
  • rendering/ListMarkerBox.h:
4:17 PM Changeset in webkit [15584] by aliceli1
  • 4 edits in trunk/WebCore

Reviewed by Darin.

fixed <rdar://problem/4617841> REGRESSION (NativeTextField): You can move keyboard focus to a field without getting insertion point

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): removed some unnecessary vertical position checks and added a fudge factor to be more forgiving for clicks near lines.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): added implementation
  • rendering/RenderTextControl.h: added function protocol
2:59 PM Changeset in webkit [15583] by ggaren
  • 4 edits in trunk/JavaScriptCore

2006-07-23 Geoffrey Garen <​ggaren@apple.com>

Patch by Eric Albert, reviewed by Darin and me.


  • Fixed <rdar://problem/4645931> JavaScriptCore stack-scanning code crashes (Collector::markStackObjectsConservatively)


  • bindings/jni/jni_jsobject.cpp: On 64bit systems, jint is a long, not an int. (JavaJSObject::getSlot): (JavaJSObject::setSlot):
  • kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): Use a pointer instead of an int as 'dummy,' because on LP64 systems, an int is not pointer-aligned, and we want to scan the stack for pointers.
  • JavaScriptCore.xcodeproj/project.pbxproj: After a tense cease-fire, the XCode war has started up again!
10:28 AM Changeset in webkit [15582] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Updating fix from last checkin.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Only tell the view about this flexbox if there isn't another flexbox already cached.
1:52 AM Changeset in webkit [15581] by adele
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for: <rdar://problem/4644614> REGRESSION: Typing, pasting or dragging in new text areas causes unnecessary scrolling

  • fast/forms/textarea-scrolled-type-expected.checksum: Added.
  • fast/forms/textarea-scrolled-type-expected.png: Added.
  • fast/forms/textarea-scrolled-type-expected.txt: Added.
  • fast/forms/textarea-scrolled-type.html: Added.

WebCore:

Reviewed by Maciej.

  • Fix for <rdar://problem/4644614> REGRESSION: Typing, pasting or dragging in new text areas causes unnecessary scrolling
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Don't updateScrollInfoAfterLayout if an ancestor flexible box is just on its first layout.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): ditto. (WebCore::RenderFlexibleBox::layoutVerticalBox): Let the view know if this flex box is doing its first pass at layout.
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): Caches a flexible box that's doing its first layout.
  • rendering/RenderView.h: (WebCore::RenderView::setFlexBoxInFirstLayout): (WebCore::RenderView::flexBoxInFirstLayout):

Jul 22, 2006:

6:37 PM Changeset in webkit [15580] by thatcher
  • 2 edits in trunk/WebKit

Rolling out r15572.


Bug 10062: REGRESSION: dom/xhtml/level2/html/HTMLIFrameElement11.xhtml asserts/crashes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10062

2006-07-21 Timothy Hatcher <​timothy@apple.com>

Reviewed by Maciej.

<rdar://problem/4609195> Help Viewer loads empty window
(not getting didFailLoadingWithError: callback)

Call super's didFailWithError before _receivedMainResourceError
because _receivedMainResourceError will cause the datasource's
frame to be set to nil before the didFailLoadingWithError delegate
callback is sent. (This order is needed now that WebDataSource does
not hold on to the WebView; it uses the WebFrame to get to the WebView.
If the WebFrame is nil we can't get to the WebView's resource load delegate.)

  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]):
4:06 PM Changeset in webkit [15579] by thatcher
  • 2 edits in tags/Safari-521.20/WebKit

Merging in '<rdar://problem/4646318> REGRESSION: Ctrl-clicking on a selection containing a word doesn't display a complete contextual menu' and build fixes.

3:56 PM Changeset in webkit [15578] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Adele.

<rdar://problem/4646318> REGRESSION: Ctrl-clicking on a selection containing a word doesn't display a complete contextual menu


Show the editing context menu if the WebView is editible.
The original change only checked if the DOM element was editable,
and isContentEditable returns NO if entire WebView is editable.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
3:45 PM Changeset in webkit [15577] by thatcher
  • 4 edits in tags/Safari-521.20/WebCore/platform

Rolling out r15529 because of <rdar://problem/4646196> REGRESSION: Artifacts are painted around Business, Calendar, Address Book, Translation, and Stocks

3:24 PM Changeset in webkit [15576] by thatcher
  • 1 edit in tags/Safari-521.20/WebCore/platform/cg/GraphicsContextCG.cpp

Rolling back in <rdar://problem/4616595> REGRESSION: Problems with world clock widget clock hand motion on 9A211 + 4604574 now that is was CCC approved.

10:45 AM Changeset in webkit [15575] by thatcher
  • 9 edits in tags/Safari-521.20

Rolling out changes that are not CCC approved. r15435, r15455, r15470 and r15553

10:41 AM Changeset in webkit [15574] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix.

12:39 AM Changeset in webkit [15573] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10038
REGRESSION: Length of navigator.mimeTypes collection returns number of installed plugins, not number
of registered mime types

Test: fast/js/navigator-mimeTypes-length.html

  • bindings/js/kjs_navigator.cpp: (KJS::MimeTypes::getValueProperty): Return the length of the mime types vector, not the plugins one. (KJS::MimeTypes::getOwnPropertySlot): Fixed another typo, which prevented MimeTypes::getValueProperty() from even being called.
Note: See TracTimeline for information about the timeline view.