⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 26, 2006:

10:26 PM Changeset in webkit [15646] by eseidel
  • 11 edits
    12 adds in trunk

2006-07-27 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.

Enables getSVGDocument() support for HTMLObjectElement and HTMLEmbedElement
This patch does not try to autogenerate anything, but enables the SVG functionality.
Also fix HTMLObjectElement vspace and hspace to be numbers instead of strings to match IE & Firefox.

  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::objectGetter): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::objectSetter):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • dom/Document.h: (WebCore::Document::isSVGDocument):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::contentDocument): (WebCore::HTMLEmbedElement::getSVGDocument):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::contentDocument): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::createRenderer): (WebCore::HTMLObjectElement::setCode): (WebCore::HTMLObjectElement::setArchive): (WebCore::HTMLObjectElement::setBorder): (WebCore::HTMLObjectElement::setCodeBase): (WebCore::HTMLObjectElement::setCodeType): (WebCore::HTMLObjectElement::setData): (WebCore::HTMLObjectElement::hspace): (WebCore::HTMLObjectElement::setHspace): (WebCore::HTMLObjectElement::setStandby): (WebCore::HTMLObjectElement::setType): (WebCore::HTMLObjectElement::setUseMap): (WebCore::HTMLObjectElement::vspace): (WebCore::HTMLObjectElement::setVspace): (WebCore::HTMLObjectElement::getSVGDocument):
  • html/HTMLObjectElement.h:
  • ksvg2/svg/SVGDocument.h: (WebCore::SVGDocument::isSVGDocument):
  • rendering/RenderWidget.h: (WebCore::RenderWidget::frameView):
9:31 PM Changeset in webkit [15645] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9901
XSLTProcessor cannot parse text nodes for INPUT ELEMENTS in an XSLT stylesheet

Test: fast/js/xhtml-serialize.html

  • editing/markup.cpp: (WebCore::endMarkup): If the element has child nodes, write a closing tag even if it is not permitted in HTML, to make it valid XML.
6:43 PM Changeset in webkit [15644] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan (and Kevin and Timo).

landing this patch for John et al.
Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard

  • page/FrameView.cpp: (WebCore::FrameView::layout): moved the call to didFirstLayout to above the check for needsLayout because we need to call didFirstLayout for every webview, not just ones we think need layout.
5:42 PM Changeset in webkit [15643] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • editing/style/designmode-expected.checksum: Added.
  • editing/style/designmode-expected.png: Added.
  • editing/style/designmode-expected.txt: Added.
  • editing/style/designmode.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
5:26 PM Changeset in webkit [15642] by thatcher
  • 1 copy in tags/Safari-521.23

New tag.

5:07 PM Changeset in webkit [15641] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Versioning

4:22 PM Changeset in webkit [15640] by thatcher
  • 6 edits in branches/Safari-521

WebCore:

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 David Harrison <​harrison@apple.com>

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Add matchStyle parameter for use by WebKit.

WebKit:

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 David Harrison <​harrison@apple.com>

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView replaceSelectionWithNode:]): (-[WebView _replaceSelectionWithNode:matchStyle:]):
  • WebView/WebViewPrivate.h: (-[WebView _replaceSelectionWithNode:matchStyle::]): New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
12:33 PM Changeset in webkit [15639] by ap
  • 2 edits in trunk/WebCore

Fix by Mitz Pettel, reviewed by ap.

  • fix debug-only information() string for table cells
  • rendering/RenderObject.cpp: (WebCore::RenderObject::information):
11:31 AM Changeset in webkit [15638] by brmorris
  • 5 edits
    1 add in S60/trunk

2006-06-26 David Carson <​david.carson@nokia.com>

Reviewed by Sachin & Zalan.


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9073
Soft hyphens not breaking words


  • WebCore/WebCore/khtml/rendering/break_lines.cpp (isBreakable): Added check for soft hyphen character when determining where to break a word. Based on similar change made by Hyatt in Windows port of WebKit. Added copyright notice to the file, copied from same file in current Mac WebKit tree.


Testcases

  • LayoutTests/fast/js/global/encode-URI-test-mobile-expected.txt:
  • LayoutTests/fast/text/basic/014-mobile-expected.txt: Updated these results as the test now passes, and the results are different.
  • LayoutTests/fas/text/basic/013-mobile-expected.txt Added missing results file.
9:31 AM Changeset in webkit [15637] by brmorris
  • 5 edits
    2 adds in S60/trunk

2006-07-26 David Carson <​david.carson@nokia.com>


Implement location.assign.
Reviewed by Zalan.


Test cases added:

  • layout-tests/fast/js/location-assign.html: Added.
  • layout-tests/fast/js/location-assign-expected.txt: Added.
  • layout-tests/fast/js/resources/new-location.html: Added.
  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::isSafeScript): (WindowFunc::tryCall): (ScheduledAction::execute): (Location::get): (LocationFunc::tryCall):
  • khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Location::):
  • khtml/ecma/kjs_window.lut.h: (KJS::): Implement location.assign.

Jul 25, 2006:

8:04 PM Changeset in webkit [15636] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Maciej, inspired by John.


  • Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to repeated requests for non-existent favicon


An optimization to avoid serializing favicon data for missing icons had stomped an
optimization to avoid GETing a missing favicon more than once. The solution
is a happy marriage of optimizations, ensuring that we *retain* the missing
favicon's "i am missing" data without posting a notification or saving it to disk.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
7:23 PM Changeset in webkit [15635] by thatcher
  • 1 copy in tags/Safari-521.22

New tag.

7:18 PM Changeset in webkit [15634] by thatcher
  • 6 edits in branches/Safari-521

Versioning

5:30 PM Changeset in webkit [15633] by harrison
  • 6 edits in trunk

WebCore:

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Add matchStyle parameter for use by WebKit.

WebKit:

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView replaceSelectionWithNode:]): (-[WebView _replaceSelectionWithNode:matchStyle:]):
  • WebView/WebViewPrivate.h: (-[WebView _replaceSelectionWithNode:matchStyle::]): New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
5:27 PM Changeset in webkit [15632] by thatcher
  • 3 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • Fix for <rdar://problem/4632132> Changing style of content with mixed editability fails

Test: * editing/style/apple-style-editable-mix.html

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Doesn't need to check the editable root. It now just checks the user modify property of its own renderer, since that is inherited.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): If the end position is in a table, Adjust the end node to the last descendant of the table, so we don't skip over any runs.
5:23 PM Changeset in webkit [15631] by thatcher
  • 3 edits in branches/Safari-521/WebKit

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.


  • WebView/WebLoader.h:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]): Copy in some code from the base class to do it in the proper order, surrounding the call to [ds _receivedMainResourceError:error complete:YES].
5:17 PM Changeset in webkit [15630] by thatcher
  • 3 edits in branches/Safari-521/WebKit

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Timothy Hatcher <​timothy@apple.com>

Reviewed by John and Darin.

<rdar://problem/4634290> Cannot selectively install a custom
scroller that differs from the default Aqua frame size.

Adds two new private methods to WebFrameView that allows
an application to set a custom scroll view class. This is needed
if the application wants to install a custom scroller that is wider
than the typical scroller, because NSScrollView does the content
rect calculations in a class method (ignoring custom scrollers.)
The _setScrollViewClass method requires the class to be a subclass
of WebDynamicScrollBarView, or nil can be passed to reset to the default class.
A new scroll view of the specified class will then replace the previous
one without the need to reload content of the frame.

  • WebView/WebFrameView.m: (-[WebFrameView _customScrollViewClass]): (-[WebFrameView _setCustomScrollViewClass:]):
  • WebView/WebFrameViewPrivate.h:
5:09 PM Changeset in webkit [15629] by thatcher
  • 5 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 David Hyatt <​hyatt@apple.com>

Two bug fixes.

(1) Make sure to mark positioned objects that depend on line position to
mark themselves as needing layout when their line box placeholder gets
repositioned.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::position):


(2) Improve highlighting to factor the inflation into overflow so that
invalidation and repainting will work properly.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow):
  • rendering/RootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
5:06 PM Changeset in webkit [15628] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

<rdar://problem/4641824> REGRESSION: Wikipedia widget fails to complete a search after pressing return key


  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Don't eat enter events for search fields that have no enclosing form; they need to be passed to AppKit so that onsearch can be invoked.


  • manual-tests/onsearch-enter.html: Added.
4:13 PM Changeset in webkit [15627] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by adele


<rdar://problem/4649560>
REGRESSION: Can't Select All when the body is contentEditable="true"

  • editing/selection/select-all-005-expected.checksum: Added.
  • editing/selection/select-all-005-expected.png: Added.
  • editing/selection/select-all-005-expected.txt: Added.
  • editing/selection/select-all-005.html: Added.
  • editing/selection/select-all-006-expected.checksum: Added.
  • editing/selection/select-all-006-expected.png: Added.
  • editing/selection/select-all-006-expected.txt: Added.
  • editing/selection/select-all-006.html: Added.

WebCore:

Reviewed by adele


<rdar://problem/4649560>
REGRESSION: Can't Select All when the body is contentEditable="true"

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Allow descent from a non-editable html element into an editable body as a convenience.
3:06 PM Changeset in webkit [15626] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-07-25 brmorris <​bradley.morrison@nokia.com>

Quickfix for RD_32_BROWSER build


Reviewed by Sachin.

  • BrowserView/inc/WebKitToolBarInterface.h: Removed errant "\no newline at end of file" :-)
2:24 PM Changeset in webkit [15625] by brmorris
  • 3 edits
    1 add in S60/trunk

2006-07-25 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.

  • build.bat: restores variant.cfg to default at END
  • variant_default.cfg: Added.
2:06 PM Changeset in webkit [15624] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin


<rdar://problem/4468458> Incoming HTML message is editable <body contenteditable="true">

  • dom/Document.cpp: (WebCore::Document::inDesignMode): Removed some spaces.
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): Just add CSS properties needed for editing. (WebCore::Frame::removeEditingStyleFromElement): Made this a no-op, we'll remove it eventually.
1:56 PM Changeset in webkit [15623] by spadma
  • 19 edits
    2 adds in S60/trunk

2006-07-25 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin


WARNING: NO TEST CASES ADDED OR CHANGED


Implement webkit changes for toolbar.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10101


  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::AddCommandObserverL): (CBrCtl::RemoveCommandObserver): (CBrCtl::SendCommandsToClient):
  • BrowserView/inc/WebKitToolBarInterface.h: Added.
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
  • BrowserView/src/WebKitToolBarInterface.cpp: Added. (CWebKitToolBarInterface::NewL): (CWebKitToolBarInterface::CWebKitToolBarInterface): (CWebKitToolBarInterface::ConstructL): (CWebKitToolBarInterface::~CWebKitToolBarInterface): (CWebKitToolBarInterface::CursorPosition): (CWebKitToolBarInterface::SetAndUpdateCursorPosition): (CWebKitToolBarInterface::SendCommandsToClient): (CWebKitToolBarInterface::ResolveUrlL): (CWebKitToolBarInterface::OpenPageViewL): (CWebKitToolBarInterface::HandleHistoryCommandL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::~CWebKitView): (CWebKitView::Draw): (CWebKitView::DrawToolTip): (CWebKitView::LaunchToolBarL): (CWebKitView::CloseToolBarL):
  • group/BWINSCW/WebKit_30U.def:
  • group/BrowserView.mmp:
  • group/EABI/browserengineU.def:
  • group/webkit.mmp:
  • rom/webkit.iby:
  • rom/webkitResources.iby:
1:32 PM Changeset in webkit [15622] by brmorris
  • 2 edits in S60/trunk

2006-07-25 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9941


  • build.bat: Correct build drive print statement.

Allow BUILD_DRIVE env var support.

10:26 AM Changeset in webkit [15621] by brmorris
  • 2 edits in S60/trunk

2006-07-25 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10104

  • runATF.bat: Restore emulator startup on SIGINT
10:23 AM Changeset in webkit [15620] by spadma
  • 2 edits in S60/trunk/WebKit

2006-07-25 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin & Sriram.

Changes to CreateStream to allow Plugins to make additional content requests.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10091

  • Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::OfferKeyEventL): (CPluginWin::DestroyStream): (CPluginWin::CreateStreamL): (CPluginWin::WriteStreamL): (CPluginWin::WriteStreamToPluginL): (CPluginWin::DestroyStreamL): (CPluginWin::LoadRequestL): (CPluginWin::SetPluginFocusL): (CPluginWin::PluginConstructedL): (CPluginData::CPluginData): (CPluginData::NewL): (CPluginData::SetUrlL):
8:35 AM Changeset in webkit [15619] by ddkilzer
  • 7 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

No test added because there is no change in functionality.

  • bindings/js/kjs_binding.cpp: Removed valueToBooleanTreatUndefinedAsTrue() method.
  • bindings/js/kjs_binding.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Removed support for ConvertUndefinedToTrue parameter attribute.
  • dom/Element.h: Set default value to true for scrollIntoView() and scrollIntoViewIfNeeded() arguments.
  • dom/Element.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute. Fixed name of scrollIntoViewIfNeeded() argument to match implementation.
  • page/DOMWindow.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute.
Note: See TracTimeline for information about the timeline view.