⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 27, 2006:

10:13 PM Changeset in webkit [15666] by adele
  • 9 edits in trunk/WebCore

Reviewed by Anders.

No test possible (no functionality change)

  • rendering/RenderBox.cpp: (WebCore::RenderBox::position):
  • rendering/RenderBox.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::position):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::position):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::position):
  • rendering/RenderText.cpp: (WebCore::RenderText::position):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeVerticalPositionsForLine):
9:53 PM Changeset in webkit [15665] by adele
  • 14 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test case for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9753>
SVG with width and height 100% leaves room for scrollbar on the right.

  • svg/custom/width-full-percentage-expected.txt: Added.
  • svg/custom/width-full-percentage-expected.checksum: Added.
  • svg/custom/width-full-percentage-expected.png: Added.
  • svg/custom/width-full-percentage.svg: Added.

WebCore:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9753
SVG with width and height 100% leaves room for scrollbar on the right.

Relayout children of svg containers, except svg shapes that do not depend on percentages.

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::hasPercentageValues):
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::hasPercentageValues):
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::hasPercentageValues):
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::hasPercentageValues):
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::hasPercentageValues):
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasPercentageValues):
6:07 PM Changeset in webkit [15664] by thatcher
  • 1 edit in tags/Safari-521.24/WebCore/Info.plist

Versioning

6:03 PM Changeset in webkit [15663] by thatcher
  • 4 edits in tags/Safari-521.24/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-26 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
6:02 PM Changeset in webkit [15662] by thatcher
  • 4 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-26 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
5:47 PM Changeset in webkit [15661] by thatcher
  • 1 copy in tags/Safari-521.24

New tag.

5:45 PM Changeset in webkit [15660] by thatcher
  • 4 edits in branches/Safari-521

Versioning

5:40 PM Changeset in webkit [15659] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-26 Alice Liu <​alice.liu@apple.com>

Reviewed by John Sullivan (and Kevin and Timo).

landing this patch for John et al.
Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard

  • page/FrameView.cpp: (WebCore::FrameView::layout): moved the call to didFirstLayout to above the check for needsLayout because we need to call didFirstLayout for every webview, not just ones we think need layout.
5:38 PM Changeset in webkit [15658] by thatcher
  • 2 edits in branches/Safari-521/WebKit

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej, inspired by John.


  • Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to repeated requests for non-existent favicon


An optimization to avoid serializing favicon data for missing icons had stomped an
optimization to avoid GETing a missing favicon more than once. The solution
is a happy marriage of optimizations, ensuring that we *retain* the missing
favicon's "i am missing" data without posting a notification or saving it to disk.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
5:36 PM Changeset in webkit [15657] by thatcher
  • 3 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/4468458> Incoming HTML message is editable <body contenteditable="true">

  • dom/Document.cpp: (WebCore::Document::inDesignMode): Removed some spaces.
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): Just add CSS properties needed for editing. (WebCore::Frame::removeEditingStyleFromElement): Made this a no-op, we'll remove it eventually.
4:50 PM Changeset in webkit [15656] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4242293>
Poor paste fidelity of ​http://www.google.com/

  • editing/pasteboard/styled-element-markup-expected.checksum: Added.
  • editing/pasteboard/styled-element-markup-expected.png: Added.
  • editing/pasteboard/styled-element-markup-expected.txt: Added.
  • editing/pasteboard/styled-element-markup.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4242293>
Poor paste fidelity of ​http://www.google.com/

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Fixed crasher with nil-check.
  • editing/markup.cpp: (WebCore::startMarkup): Style information wasn't added to an element if it had attributes but no style attribute.
2:56 PM Changeset in webkit [15655] by spadma
  • 2 edits in S60/trunk/WebKit

2006-07-27 zhalu <​Zhaosong.lu@nokia.com>

Reviewed by Sachin

  • BrowserCore/Formcontrols/src/FControlSelectSkin.cpp: (CFormSelectSkin::CalculateVisualClipTextL): Work around if Font returns zero for MaxNormalCharWidth


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10133

2:06 PM Changeset in webkit [15654] by lypanov
  • 4 edits
    2 adds in trunk

2006-07-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by Darin.

  • bindings/scripts/CodeGeneratorJS.pm: add new attribute - HasOverridingNameGetter
  • html/HTMLFormElement.idl:

2006-07-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9867
REGRESSION: code that modifies form element in Firefox modifies form attribute in WebKit

  • fast/forms/input-named-action-overrides-action-attribute-expected.txt: Added.
  • fast/forms/input-named-action-overrides-action-attribute.html: Added.
1:18 PM Changeset in webkit [15653] by rwlbuis
  • 8 edits
    2 adds in trunk

Reviewed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8992
Some HTML DOM attributes have incorrect types

Adjust idl and dom source code for HTMLImageElement and
HTMLBaseFontElement to choose correct type for
HTMLImageElement::border and HTMLBaseFontElement::size
attributes.

1:01 PM Changeset in webkit [15652] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4628409>
Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form

  • fast/forms/4628409-expected.txt: Added.
  • fast/forms/4628409.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4628409>
Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeBlockPlaceholder): A script on the page shrinks the textarea down to zero rows just before insertion. That gives the shadow div a zero height, removing [div, 0] as a candidate for a VisiblePosition. Then InsertTextCommand::input() tries to create a VisiblePosition from [div, 0] and fails. A nil check is a quick fix. Another might be to make positions where there is a caret selection candidates. Another might be to make any [div, 0] where div is a shadow div inside a form element a candidate.
11:58 AM Changeset in webkit [15651] by ap
  • 3 edits
    4 adds in trunk

Fix by Graham Dennis, reviewed by Darin.


Test: fast/encoding/denormalised-voiced-japanese-chars.html

  • platform/Font.cpp: (WebCore::WidthIterator::advance): pass currentCharacter to normalizeVoicingMarks (WebCore::WidthIterator::normalizeVoicingMarks): turn the currentCharacter variable into an argument as WidthIterator::advance doesn't update m_currentCharacter while looping
11:11 AM Changeset in webkit [15650] by thatcher
  • 2 edits in tags/Safari-521.23/WebKit

Versioning

11:09 AM Changeset in webkit [15649] by thatcher
  • 2 edits in branches/Safari-521/WebKit

Versioning

2:22 AM Changeset in webkit [15648] by eseidel
  • 13 edits in trunk

2006-07-27 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.

Complex entities seem to fail on TOT
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6390
Use an alternative work-around to an XML Entity parsing bug.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write): (WebCore::hackAroundLibXMLEntityBug): added. (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::getEntityHandler):
12:46 AM Changeset in webkit [15647] by rwlbuis
  • 3 edits
    8 adds in trunk

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9938
Fix viewBox issues in Hixie's test

Do a more accurate and quicker job of parsing the viewBox
attribute. Handle properly on negative width/height and
invalid syntax in general.

  • ksvg2/svg/SVGFitToViewBox.cpp: (SVGFitToViewBox::parseViewBox):

Jul 26, 2006:

10:26 PM Changeset in webkit [15646] by eseidel
  • 11 edits
    12 adds in trunk

2006-07-27 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.

Enables getSVGDocument() support for HTMLObjectElement and HTMLEmbedElement
This patch does not try to autogenerate anything, but enables the SVG functionality.
Also fix HTMLObjectElement vspace and hspace to be numbers instead of strings to match IE & Firefox.

  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::objectGetter): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::objectSetter):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • dom/Document.h: (WebCore::Document::isSVGDocument):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::contentDocument): (WebCore::HTMLEmbedElement::getSVGDocument):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::contentDocument): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::createRenderer): (WebCore::HTMLObjectElement::setCode): (WebCore::HTMLObjectElement::setArchive): (WebCore::HTMLObjectElement::setBorder): (WebCore::HTMLObjectElement::setCodeBase): (WebCore::HTMLObjectElement::setCodeType): (WebCore::HTMLObjectElement::setData): (WebCore::HTMLObjectElement::hspace): (WebCore::HTMLObjectElement::setHspace): (WebCore::HTMLObjectElement::setStandby): (WebCore::HTMLObjectElement::setType): (WebCore::HTMLObjectElement::setUseMap): (WebCore::HTMLObjectElement::vspace): (WebCore::HTMLObjectElement::setVspace): (WebCore::HTMLObjectElement::getSVGDocument):
  • html/HTMLObjectElement.h:
  • ksvg2/svg/SVGDocument.h: (WebCore::SVGDocument::isSVGDocument):
  • rendering/RenderWidget.h: (WebCore::RenderWidget::frameView):
9:31 PM Changeset in webkit [15645] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9901
XSLTProcessor cannot parse text nodes for INPUT ELEMENTS in an XSLT stylesheet

Test: fast/js/xhtml-serialize.html

  • editing/markup.cpp: (WebCore::endMarkup): If the element has child nodes, write a closing tag even if it is not permitted in HTML, to make it valid XML.
6:43 PM Changeset in webkit [15644] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan (and Kevin and Timo).

landing this patch for John et al.
Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard

  • page/FrameView.cpp: (WebCore::FrameView::layout): moved the call to didFirstLayout to above the check for needsLayout because we need to call didFirstLayout for every webview, not just ones we think need layout.
5:42 PM Changeset in webkit [15643] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • editing/style/designmode-expected.checksum: Added.
  • editing/style/designmode-expected.png: Added.
  • editing/style/designmode-expected.txt: Added.
  • editing/style/designmode.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
5:26 PM Changeset in webkit [15642] by thatcher
  • 1 copy in tags/Safari-521.23

New tag.

5:07 PM Changeset in webkit [15641] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Versioning

4:22 PM Changeset in webkit [15640] by thatcher
  • 6 edits in branches/Safari-521

WebCore:

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 David Harrison <​harrison@apple.com>

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Add matchStyle parameter for use by WebKit.

WebKit:

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 David Harrison <​harrison@apple.com>

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView replaceSelectionWithNode:]): (-[WebView _replaceSelectionWithNode:matchStyle:]):
  • WebView/WebViewPrivate.h: (-[WebView _replaceSelectionWithNode:matchStyle::]): New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
12:33 PM Changeset in webkit [15639] by ap
  • 2 edits in trunk/WebCore

Fix by Mitz Pettel, reviewed by ap.

  • fix debug-only information() string for table cells
  • rendering/RenderObject.cpp: (WebCore::RenderObject::information):
11:31 AM Changeset in webkit [15638] by brmorris
  • 5 edits
    1 add in S60/trunk

2006-06-26 David Carson <​david.carson@nokia.com>

Reviewed by Sachin & Zalan.


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9073
Soft hyphens not breaking words


  • WebCore/WebCore/khtml/rendering/break_lines.cpp (isBreakable): Added check for soft hyphen character when determining where to break a word. Based on similar change made by Hyatt in Windows port of WebKit. Added copyright notice to the file, copied from same file in current Mac WebKit tree.


Testcases

  • LayoutTests/fast/js/global/encode-URI-test-mobile-expected.txt:
  • LayoutTests/fast/text/basic/014-mobile-expected.txt: Updated these results as the test now passes, and the results are different.
  • LayoutTests/fas/text/basic/013-mobile-expected.txt Added missing results file.
9:31 AM Changeset in webkit [15637] by brmorris
  • 5 edits
    2 adds in S60/trunk

2006-07-26 David Carson <​david.carson@nokia.com>


Implement location.assign.
Reviewed by Zalan.


Test cases added:

  • layout-tests/fast/js/location-assign.html: Added.
  • layout-tests/fast/js/location-assign-expected.txt: Added.
  • layout-tests/fast/js/resources/new-location.html: Added.
  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::isSafeScript): (WindowFunc::tryCall): (ScheduledAction::execute): (Location::get): (LocationFunc::tryCall):
  • khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Location::):
  • khtml/ecma/kjs_window.lut.h: (KJS::): Implement location.assign.
Note: See TracTimeline for information about the timeline view.