⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 1, 2006:

4:06 PM Changeset in webkit [15750] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4480737> Flash crashes after it replaces itself via a document.write()


I kind of hate to do this, but this is the best way to work around buggy plug-ins like Flash that assume that
NPP_Destroy() cannot be called while the browser is calling one of its other plug-in functions. The classic
situation is a plug-in that replaces itself via an NPN_Invoke() that executes a document.write().

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView setWindowIfNecessary]): ditto (-[WebBaseNetscapePluginView start]): It should not be possible to start a plug-in instance while we are calling into it (one of those chicken/egg problems). Added a sanity-checking assertion. (-[WebBaseNetscapePluginView stop]): If we're already calling a plug-in function, do not call NPP_Destroy(). The plug-in function we are calling may assume that its instance->pdata, or other memory freed by NPP_Destroy(), is valid and unchanged until said plugin-function returns. (-[WebBaseNetscapePluginView pluginScriptableObject]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView willCallPlugInFunction]): Increment plug-in function call depth. (-[WebBaseNetscapePluginView didCallPlugInFunction]): Decrement plug-in function call depth. Stop if we're supposed to stop. (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): ditto (-[WebBaseNetscapePluginView _printedPluginBitmap]): ditto
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream _deliverData]): ditto
4:04 PM Changeset in webkit [15749] by brmorris
  • 1 copy in S60/tags/s60-RnD-06wk31_rc1

Tagging S60 RnD w31 '06 release candidate 1

3:58 PM Changeset in webkit [15748] by brmorris
  • 3 edits in S60/trunk/WebKit

2006-08-01 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10184
Sound continues after page closes in Bookmark view.

  • Plugin/inc/PluginAdapterInterface.h: (MPluginNotifier::): Added EPluginInvisible
  • Plugin/src/PluginWin.cpp: (CPluginWin::MakeVisible): Sends message to Plugin notifier
3:53 PM Changeset in webkit [15747] by mjs
  • 2 edits in trunk/WebKit
  • fix build after last change
  • WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]):
3:43 PM Changeset in webkit [15746] by brmorris
  • 6 edits in S60/trunk/WebKit

2006-07-31 vbradley <​vincent.bradley@nokia.com>

Reviewed by Yongun & Sachin

Add changes to allow the user to send plugin content to viewer.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10130

  • BrowserControl/src/BrCtl.cpp:
  • BrowserView/inc/PluginControl.h:
  • BrowserView/src/PluginControl.cpp:
  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginWin.cpp:
3:08 PM Changeset in webkit [15745] by brmorris
  • 5 edits in S60/trunk

2006-08-01 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin/Youngjun.


Horizontal scroll not working with WML pages.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10092

  • BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::ResizeBrCtlView): Set the view rectangle in WML view.
3:05 PM Changeset in webkit [15744] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Beth.

  • revert part of my last fix that broke the Safari bookmarks view


  • WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]): still send layout message for non-HTML views
1:20 PM Changeset in webkit [15743] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Anders.

Fixed an assertion failure I ran into while debugging <rdar://problem/4652683>.

  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView redeliverStream]): Don't clear the "instance" ivar here. This code was refactored here from the old WebNetscapePluginRepresentation, which also had an "instance" ivar. It is never appropriate to clear a plug-in view's instance. That is done when the plug-in is destroyed.
1:17 PM Changeset in webkit [15742] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-07-28 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Youngjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10149

  • BrowserView/src/WebKitView.cpp: (CWebKitView::ProgressAndImageDecodeComplete): Now calls ScheduleRepaint()
1:06 PM Changeset in webkit [15741] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-08-01 naguo <​George.Guo@nokia.com>

Reviewed by Yongjun.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10189

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::FindDownloadL): Make sure the download is not completed before start it
12:09 PM Changeset in webkit [15740] by brmorris
  • 2 edits in S60/trunk/WebCore

2006-08-01 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10185

www.euromaster.fi crash due to memory corruption.

  • kwq/KWQKURL.cpp: (KURL::KURL): free buffer (KURL::parse): free path_buffer not buffer
11:41 AM Changeset in webkit [15739] by ggaren
  • 2 edits
    3 adds in trunk/WebKitSite

Reviewed by Beth.


  • Added instructions for debugging in Xcode
  • building/build-window.png: Added.
  • building/build.html:
  • building/custom-executable.png: Added.
  • building/info-tab.png: Added.
11:38 AM Changeset in webkit [15738] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Geoff.


  • some refactoring in preparation for moving more stuff to WebFrameLoader.
  • WebView/WebFrame.m: (-[WebFrame _clearDataSource]): (-[WebFrame _detachFromParent]): (-[WebFrame _commitProvisionalLoad]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _clearProvisionalLoad]): (-[WebFrame _markLoadComplete]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _startProvisionalLoad:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame stopLoading]):
11:03 AM Changeset in webkit [15737] by brmorris
  • 5 edits in S60/trunk/WebKit

2006-08-01 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10131

Implemented MCoeForegroundObserver at CPluginWin to process
background/foreground events independently of changes in focus.

  • Plugin/inc/PluginLoader.h:
  • Plugin/inc/PluginSkin.h:
  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::ProcessEventL): (CPluginWin::HandleControlEventL): (CPluginWin::ViewFocusChanged): (CPluginWin::SetPluginFocusL): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
10:57 AM Changeset in webkit [15736] by brmorris
  • 4 edits in S60/trunk

2006-08-01 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Yongjun.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10174

  • BrowserCore/Formcontrols/src/FControlButtonSkin.cpp: (CFormButtonSkin::Draw): Now sets alpha
9:40 AM Changeset in webkit [15735] by darin
  • 4 edits in trunk

LayoutTests:

  • updated a test affected by changes to the DumpRenderTree tool to return a current mouse position
  • fast/inline/dirtyLinesForInline-expected.txt: Updated.

WebKitTools:

  • fix a bug in my recent change where the mouse position at the end of the last test would affect the results of the next test
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Set lastMousePosition to 0.

Jul 31, 2006:

11:15 PM Changeset in webkit [15734] by darin
  • 12 edits in trunk

LayoutTests:

Reviewed by Darin.

  • fast/css/hsl-color-expected.checksum:
  • fast/css/hsl-color-expected.png:
  • fast/css/hsl-color-expected.txt:
  • fast/forms/input-disabled-color-expected.checksum:
  • fast/forms/input-disabled-color-expected.png:
  • fast/forms/input-disabled-color-expected.txt:

WebCore:

Reviewed by Darin.


Fixes scaling issue and fixes Color to follow style guidelines.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • platform/Color.cpp: (WebCore::calcHue): (WebCore::makeRGBAFromHSLA): (WebCore::Color::Color): (WebCore::Color::name): (WebCore::Color::setNamedColor): (WebCore::Color::light): (WebCore::Color::dark): (WebCore::blend):
  • platform/Color.h: (WebCore::Color::Color): (WebCore::Color::isValid): (WebCore::Color::red): (WebCore::Color::green): (WebCore::Color::blue): (WebCore::Color::alpha): (WebCore::Color::rgb): (WebCore::Color::setRGB): (WebCore::operator==): (WebCore::operator!=):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):
11:13 PM Changeset in webkit [15733] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/backgrounds/solid-color-context-restore-expected.checksum: Added.
  • fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • fast/backgrounds/solid-color-context-restore-expected.txt: Added.
  • fast/backgrounds/solid-color-context-restore.html: Added.

WebCore:

Reviewed by Darin.

Pixel test: fast/backgrounds/solid-color-context-restore.html

  • platform/mac/ImageMac.mm: (WebCore::Image::draw): Added calls to preserve the graphics context around the painting of a solid color image. (WebCore::Image::drawTiled): Ditto.
11:10 PM Changeset in webkit [15732] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10182
Bug 10182: [Drosera] Evaluating expressions in Console is slow when current frame has many variables

  • Drosera/console.js: String.indexOf returns -1 when the string is not found. Correct the logic to not reload local variable list unless an '=' character is in the expression.
11:00 PM Changeset in webkit [15731] by darin
  • 5 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/events/objc-event-api-expected.txt: Updated test results for changes in the DumpRenderTree tool.

WebKitTools:

Reviewed by Maciej.

  • DumpRenderTree/DumpRenderTree.m: (main): Add pose so we can implement +[NSEvent mouseLocation]. Put the window at a predictable location in flipped coordinates, since those are the coordinates that we use. (+[DumpRenderTreeEvent mouseLocation]): Implement this, since it's used for mouse event handling inside WebHTMLView.
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController initialize]): Removed unused webkitDomEventProperties array. (-[EventSendingController init]): Removed, since the whole thing was a no-op. (-[EventSendingController mouseMoveToX:Y:]): Convert the x,y pair to window coordinates. The old code probably worked OK, but this is needed to be correct. (-[EventSendingController handleEvent:]): Put clientX/Y before screenX/Y and removed the flipping code from screenY. We didn't really need to flip screenY -- what was actually happening was that the position that DumpRenderTree chose was in non-flipped coordinates, and with that fixed we can just dump the screenY as-is.
10:15 PM Changeset in webkit [15730] by mjs
  • 25 edits
    10 moves in trunk

WebCore:

Rubber-stamped by Tim Hatcher.

  • renamed TransferJob to ResourceLoader
  • Projects/gdk/webcore-gdk.bkl:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreResourceLoaderImp.h:
  • bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp redirectedToURL:]): (-[WebCoreResourceLoaderImp addData:]): (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
  • bridge/win/FrameWin.cpp:
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • loader/Cache.cpp:
  • loader/LoaderFunctions.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::receivedData): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
  • loader/loader.h:
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • platform/ResourceLoader.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::isErrorPage): (WebCore::ResourceLoader::error): (WebCore::ResourceLoader::setError): (WebCore::ResourceLoader::queryMetaData): (WebCore::ResourceLoader::addMetaData): (WebCore::ResourceLoader::kill): (WebCore::ResourceLoader::url): (WebCore::ResourceLoader::postData): (WebCore::ResourceLoader::method): (WebCore::ResourceLoader::client):
  • platform/ResourceLoader.h: Added. (WebCore::ResourceLoader::getInternal):
  • platform/ResourceLoaderClient.h: Added. (WebCore::ResourceLoaderClient::~ResourceLoaderClient): (WebCore::ResourceLoaderClient::receivedRedirect): (WebCore::ResourceLoaderClient::receivedResponse): (WebCore::ResourceLoaderClient::receivedData): (WebCore::ResourceLoaderClient::receivedAllData):
  • platform/ResourceLoaderInternal.h: Added. (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/TransferJob.cpp: Removed.
  • platform/TransferJob.h: Removed.
  • platform/TransferJobClient.h: Removed.
  • platform/TransferJobInternal.h: Removed.
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::urlSelected): (WebCore::FrameGdk::receivedData): (WebCore::FrameGdk::receivedAllData):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/ResourceLoaderCurl.cpp: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
  • platform/gdk/ResourceLoaderManager.cpp: Added. (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::get): (WebCore::ResourceLoaderManager::useSimpleTransfer): (WebCore::writeCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add): (WebCore::ResourceLoaderManager::cancel):
  • platform/gdk/ResourceLoaderManager.h: Added.
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset):
  • platform/gdk/TransferJobCurl.cpp: Removed.
  • platform/gdk/TransferJobManager.cpp: Removed.
  • platform/gdk/TransferJobManager.h: Removed.
  • platform/mac/ResourceLoaderMac.mm: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::setLoader): (WebCore::ResourceLoader::receivedResponse): (WebCore::ResourceLoader::cancel):
  • platform/mac/TransferJobMac.mm: Removed.
  • platform/win/ResourceLoaderWin.cpp: Added. (WebCore::addToOutstandingJobs): (WebCore::lookupResourceLoader): (WebCore::ResourceLoaderWndProc): (WebCore::initializeOffScreenResourceLoaderWindow): (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
  • platform/win/ResourceLoaderWin.h: Added.
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset):
  • platform/win/TransferJobWin.cpp: Removed.
  • platform/win/TransferJobWin.h: Removed.
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData):
  • xml/xmlhttprequest.h:

WebKit:

Reviewed by Tim Hatcher.


  • renamed TransferJob to ResourceLoader in WebCore
  • COM/WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData): (WebFrame::receivedAllData): (WebFrame::setStatusText):
  • COM/WebFrame.h:
9:54 PM Changeset in webkit [15729] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • omit the margin and padding boxes for display types where they are ignored
  • use CSS instead of properties for table spacing and padding as suggested by Tim H.
  • WebInspector/webInspector/inspector.css: Added rules for spacing and padding. Added rules that hide the margin and padding boxes (borders and all but the center cell) when the hide attribute is present.
  • WebInspector/webInspector/inspector.html: Added classes for the rules above. Removed cellpadding and cellspacing attributes.
  • WebInspector/webInspector/inspector.js: Added code to hide/show the margin and padding boxes based on the display type.
9:14 PM Changeset in webkit [15728] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

  • removed obsolete cell margin hack
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcVerticalMargins): Set top and bottom margins to 0 for table cells instead of -16384. No effect on layout (including layout tests).
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a few comments about differences between this class and the what the CSS specification says about computed style.
9:00 PM Changeset in webkit [15727] by thatcher
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
Bug 9738: Unqualified :hover selector ignored in strict parsing mode

  • fast/selectors/unqualified-hover-quirks-expected.checksum: Added.
  • fast/selectors/unqualified-hover-quirks-expected.png: Added.
  • fast/selectors/unqualified-hover-quirks-expected.txt: Added.
  • fast/selectors/unqualified-hover-quirks.html: Added.
  • fast/selectors/unqualified-hover-strict-expected.checksum: Added.
  • fast/selectors/unqualified-hover-strict-expected.png: Added.
  • fast/selectors/unqualified-hover-strict-expected.txt: Added.
  • fast/selectors/unqualified-hover-strict.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
Bug 9738: Unqualified :hover selector ignored in strict parsing mode

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Restrict the :hover and :active exclusion based on onlyHoverActive to quirks mode.
8:54 PM Changeset in webkit [15726] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=10159>
"REGRESSION: delegate returning no menu elements crashes webkit"

No automated test, because there's no way to programmatically open a context menu,
no manual test because there's no way to customize the context menu delegate.

  • WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]): Make sure the context menu returned some menu items before accessing the first one.
8:51 PM Changeset in webkit [15725] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10178
Bug 10178: [Drosera] Selecting a frame in the stack list should take you to that location in the source

  • Drosera/debugger.js: Keep a stack that contains the source file and line number references for outer frames. Use this stack to determine which file and line to highlight when a stack frame is selected.
8:48 PM Changeset in webkit [15724] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10175
Bug 10175: [Drosera] Anonymous functions show up as "(global scope)" in stack list

  • Drosera/DebuggerDocument.m: (-[WebScriptObject currentFunctionStack]): If the frame has a caller it isn't the global scope.
7:27 PM Changeset in webkit [15723] by hyatt
  • 1 add in trunk/WebCore/platform/ScrollBar.cpp

Add ScrollBar.cpp to fix the build.

7:25 PM Changeset in webkit [15722] by hyatt
  • 7 edits in trunk/WebCore

Fix for bug 10179, digg.com scrolls slowly. Improve fixed positioning
and fixed backgrounds so that a count of them is kept on the FrameView.
This allows us to switch slow scrolling on and off as these objects come
and go.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject):
  • page/FrameView.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
6:50 PM Changeset in webkit [15721] by hyatt
  • 11 edits
    2 adds
    1 delete in trunk/WebCore

Begin disentangling of scrollbar logic in preparation for engine-implemented
scrollbars. Split ScrollBar into two classes, an abstract base (still named
ScrollBar) and a new PlatformScrollBar subclass. This subclass is used only
by platforms that want to continue to use a platform scrollbar (rather than
the engine one).

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLCanvasElement.h:
  • page/Frame.cpp:
  • platform/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget):
  • platform/ScrollBar.h: (WebCore::ScrollBarClient::~ScrollBarClient): (WebCore::ScrollBar::~ScrollBar): (WebCore::ScrollBar::orientation): (WebCore::ScrollBar::value): (WebCore::ScrollBar::client):
  • platform/mac/PlatformScrollBarMac.mm: Added. (-[WebCoreScrollBar initWithPlatformScrollBar:]): (-[WebCoreScrollBar detachPlatformScrollBar]): (-[WebCoreScrollBar scroll:]): (-[WebCoreScrollBar widget]): (-[WebCoreScrollBar mouseDown:]): (WebCore::PlatformScrollBar::PlatformScrollBar): (WebCore::PlatformScrollBar::~PlatformScrollBar): (WebCore::PlatformScrollBar::setScrollBarValue): (WebCore::PlatformScrollBar::setKnobProportion): (WebCore::PlatformScrollBar::scrollbarHit): (WebCore::PlatformScrollBar::width): (WebCore::PlatformScrollBar::height): (WebCore::PlatformScrollBar::setRect): (WebCore::PlatformScrollBar::setEnabled): (WebCore::PlatformScrollBar::paint):
  • platform/mac/ScrollBarMac.mm: Removed.
  • platform/mac/WebCoreTextArea.mm:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar):
  • rendering/RenderFormElement.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::horizontalScrollbarWidget): (WebCore::RenderLayer::verticalScrollbarWidget): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::positionScrollbars):
  • rendering/RenderLayer.h:
  • rendering/RenderWidget.h:
5:05 PM Changeset in webkit [15720] by adele
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by John and Anders.

  • Test for <rdar://problem/4380576> onChange does not get called when field changed by return key
  • fast/forms/onchange-enter-submit-expected.txt: Added.
  • fast/forms/onchange-enter-submit.html: Added.

WebCore:

Reviewed by John and Anders.

  • Fix for <rdar://problem/4380576> onChange does not get called when field changed by return key

Test: fast/forms/onchange-enter-submit.html

Blur (which will fire onChange appropriately) before submitting a form when pressing Enter.
This matches the sequence of events fired in WinIE.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):
4:55 PM Changeset in webkit [15719] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/4658194> REGRESSION: "Search in Google"
and "Search in Spotlight" fail to work on text selected in a frame

Use selectedFrame to get the frame with the text selection.

  • WebView/WebView.m: (-[WebView _searchWithGoogleFromMenu:]): (-[WebView _searchWithSpotlightFromMenu:]):
3:27 PM Changeset in webkit [15718] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

Moved string debug function outside of the WebCore namespace so that it's
easier to call in the debugger. I will never doubt Darin again (x100).

  • platform/String.cpp: (string):
2:06 PM Changeset in webkit [15717] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderLayer.cpp

Get rid of the -50000 nonsense on scrollbars when they're first added to overflow blocks.

1:59 PM Changeset in webkit [15716] by hyatt
  • 2 edits in trunk/WebCore

Partial fix for 5453. Improve overflow so that when it changes
dynamically from scroll/auto to hidden that we properly hide the
scrollbars. Also refine the dirty dashboard region updating so that
it only happens if the scrollbars genuinely come and go.

Also eliminate the extra repaint of the entire block. This should not be
necessary, since the scrollbars repaint themselves already and children
will repaint already if they move.

Reviewed by darin

Adding test case from bug into fast/overflow/dynamic-hidden.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
1:58 PM Changeset in webkit [15715] by hyatt
  • 4 adds in trunk/LayoutTests/fast/overflow

Add layout test for bug 5453.

12:49 PM Changeset in webkit [15714] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
Empty style spans created in applyInlineStyle
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page

  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/testcase-9507-expected.checksum: Added.
  • editing/pasteboard/testcase-9507-expected.png: Added.
  • editing/pasteboard/testcase-9507-expected.txt: Added.
  • editing/pasteboard/testcase-9507.html: Added.
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/selection/selectNode-expected.png:
  • editing/selection/selectNode-expected.checksum:
  • editing/selection/selectNode-expected.txt:

WebCore:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
Empty style spans created in applyInlineStyle


Improves paste fidelity because some of these empty font/style spans had a non-zero
size and were messing up the layout of pasted content:
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use the adjusted start node instead of start.node(). Don't do any application if the endpoints are swapped. Adjust endNode if the start node is a descendant of it, so that the pre-order traversal will terminate properly.
12:14 PM Changeset in webkit [15713] by darin
  • 4 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • WebInspector/webInspector/inspector.css: Add styles for the new metrics pane.
  • WebInspector/webInspector/inspector.html: Add the new metrics pane, starting with the table to show the box model.
  • WebInspector/webInspector/inspector.js: Add the new metrics pane. Add back some "title" attributes so we have more tooltips. Removed the optional parameter to getComputedStyle.
11:44 AM Changeset in webkit [15712] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • platform/String.cpp: (WebCore::string): Added a debugging function to create a String from a const char*.
11:21 AM Changeset in webkit [15711] by thatcher
  • 1 edit in trunk/WebKit/ChangeLog

Update ChangeLog with bug link.

9:13 AM Changeset in webkit [15710] by andersca
  • 2 edits in trunk/WebKit

2006-07-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Create a mutable set instead of a mutable array.
8:43 AM Changeset in webkit [15709] by andersca
  • 2 edits in trunk/WebCore

2006-07-31 Anders Carlsson <​acarlsson@apple.com>

  • css/CSSPrimitiveValue.cpp: Fix windows build.
1:44 AM Changeset in webkit [15708] by ggaren
  • 2 edits
    1 copy
    1 move
    1 delete in trunk/WebCore

Reinstating my last change. Everything builds now.

1:41 AM Changeset in webkit [15707] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10167
Bug 10167: REGRESSION(r15688): ASSERTION FAILED: _private->mouseDownEvent != nil in layout tests

  • fast/events/objc-event-api-expected.txt: Update test results.

WebKitTools:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10167
Bug 10167: REGRESSION(r15688): ASSERTION FAILED: _private->mouseDownEvent != nil in layout tests

  • DumpRenderTree/EventSendingController.m: Don't set the mouse down flag in keyDown handler.
1:31 AM Changeset in webkit [15706] by ggaren
  • 2 edits
    2 copies
    2 deletes in trunk/WebCore

Backing out my last change because it causes a build failure in some
configurations. This seems to be the cleanest way to get svn to cooperate.

12:26 AM Changeset in webkit [15705] by darin
  • 3 edits
    2 deletes in trunk/LayoutTests
  • editing/pasteboard/paste-table-002-expected.txt: Corrected one result affected by my recent change to getComputedStyle.
  • editing/pasteboard/paste-table-002.html: Converted to a text test, since it dumps the serialized form of hte result.
  • editing/pasteboard/paste-table-002-expected.checksum: Removed.
  • editing/pasteboard/paste-table-002-expected.png: Removed.
12:17 AM Changeset in webkit [15704] by ggaren
  • 2 edits
    1 copy
    1 move
    1 delete in trunk/WebCore

Reviewed by Maciej.

Moved files around to make WebCore's structure clearer
and easier to explain.

DerivedSources/JS* -> bindings/js/DerivedSources/ (so JS* files
show up when you search inside bindings/js/, but are marked, at
the same time, as files that you should not edit manually)

WebCore+SVG/DOMList.h -> ksvg2/svg/ (only files inside ksvg2/svg/
use DOMList.h)

icon -> loader/icon

I tested that everything still builds.

12:07 AM Changeset in webkit [15703] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • WebInspector/webInspector/inspector.js: Fix bug where a null property value leads to an empty style pane.
Note: See TracTimeline for information about the timeline view.