Context Navigation

← Previous Period
Next Period →

Timeline

Aug 2, 2006:

11:08 PM Changeset in webkit [15763] by thatcher

2 edits in trunk/WebKit

Rubber stamped by Maciej.

Adding back resultsWithXpathQuery, removed by Darin's earlier change.
This function is called from ObjC, but not used from JavaScript.

WebInspector/webInspector/inspector.js:

4:18 PM Changeset in webkit [15762] by thatcher

2 edits in trunk/WebKitTools

Reviewed by Darin.

Bug 9632: [Drosera] syntax highlighting is slow (reproducible 40 second hang)
http://bugzilla.opendarwin.org/show_bug.cgi?id=9632

Do not change the file source when normalizing the line endings.
We use this file source to compare against new versions of the source
as it comes in, so we can skip re-syntax highlighting if they are the same.
The problem is apparent on yahoo.com since they have mixed line endings and
once we normalize them the source will always be different. This was
compounded by the fact that yahoo has around 40 inline scripts. Each
inline script causes us to check if the main document has more loaded,
that is when we compare the source strings. Since they are always different
we would syntax highlight yahoo.com 40 times! We do check source length before
doing a more expensive string comparison, but the lengths were the same.

Drosera/debugger.js:

4:15 PM Changeset in webkit [15761] by thatcher

3 edits in trunk/WebKit

Reviewed by Darin.

Bug 10200: [Drosera] Deadlock between Drosera and Safari while loading page
http://bugzilla.opendarwin.org/show_bug.cgi?id=10200

Prevent reentrancy in our debugger callbacks. This was causing a deadlock in Drosera because
suspendProcessIfPaused was being called during a DO call into Safari.

Preventing reentrancy also prevents scripts that Drosera injects and evaluates from showing
up in rare cases (such as a iframe loading about:blank). I thought this would prevent cases
where you call a function from the console and expect it to break on a breakpoint in them, but
this appears to never have worked even without this change. When that is figured out we can
reconsider a better solution to reentrancy. I have filed that as bug 10214.

I also removed the NSRunLoop runMode:beforeDate: calls since DO handles this for us since
we don't use "onway void" as the return type for the callbacks. Note: using onway void for
the listener callbacks causes bad synchronization issues and obscure crashes.

DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]): (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
DefaultDelegates/WebScriptDebugServerPrivate.h:

3:59 PM Changeset in webkit [15760] by hyatt

4 edits in trunk/WebCore

Abstract RenderLayer scrollbar creation and destruction so that there
is a clean spot in which to drop in engine scrollbar stuff.

Reviewed by timo

platform/ScrollBar.h: (WebCore::ScrollBar::hasPlatformScrollBars):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
rendering/RenderLayer.h:

3:58 PM Changeset in webkit [15759] by ggaren

2 edits
1 add in trunk/WebKitSite

Reviewed by TimO.

Tweaked the build instructions a bit.

building/build.html:
building/debug.png: Added.

3:47 PM RecentChanges created by trac

3:47 PM SandBox created by trac

3:47 PM TitleIndex created by trac

3:47 PM CamelCase created by trac

3:47 PM TracAccessibility created by trac

3:47 PM TracAdmin created by trac

3:47 PM TracBackup created by trac

3:47 PM TracBrowser created by trac

3:47 PM TracCgi created by trac

3:47 PM TracInstall created by trac

3:47 PM TracInterfaceCustomization created by trac

3:47 PM TracLinks created by trac

3:47 PM TracChangeset created by trac

3:47 PM TracEnvironment created by trac

3:47 PM TracFastCgi created by trac

3:47 PM TracGuide created by trac

3:47 PM TracRss created by trac

3:47 PM TracImport created by trac

3:47 PM TracIni created by trac

3:47 PM TracLogging created by trac

3:47 PM TracModPython created by trac

3:47 PM TracNotification created by trac

3:47 PM TracPermissions created by trac

3:47 PM TracPlugins created by trac

3:47 PM TracQuery created by trac

3:47 PM TracReports created by trac

3:47 PM TracRoadmap created by trac

3:47 PM TracSearch created by trac

3:47 PM TracStandalone created by trac

3:47 PM TracSupport created by trac

3:47 PM TracSyntaxColoring created by trac

3:47 PM TracTickets created by trac

3:47 PM WikiHtml created by trac

3:47 PM TracTicketsCustomFields created by trac

3:47 PM TracTimeline created by trac

3:47 PM TracUnicode created by trac

3:47 PM TracUpgrade created by trac

3:47 PM TracWiki created by trac

3:47 PM WikiDeletePage created by trac

3:47 PM WikiFormatting created by trac

3:47 PM WikiMacros created by trac

3:47 PM WikiPageNames created by trac

3:47 PM WikiProcessors created by trac

3:47 PM WikiRestructuredText created by trac

3:47 PM WikiRestructuredTextLinks created by trac

3:47 PM WikiStart created by trac

3:47 PM InterWiki edited by trac

(diff)

3:47 PM TracFineGrainedPermissions created by trac

3:47 PM TracFastCgi edited by trac

(diff)

3:47 PM TracEnvironment edited by trac

(diff)

3:47 PM TracChangeset edited by trac

(diff)

3:47 PM TracCgi edited by trac

(diff)

3:47 PM InterTrac edited by trac

(diff)

3:47 PM TracRevisionLog edited by trac

(diff)

3:47 PM TracUpgrade edited by trac

(diff)

3:47 PM TracUnicode edited by trac

(diff)

3:47 PM TracTimeline edited by trac

(diff)

3:47 PM TracTicketsCustomFields edited by trac

(diff)

3:47 PM TracTickets edited by trac

(diff)

3:47 PM WikiProcessors edited by trac

(diff)

3:47 PM WikiMacros edited by trac

(diff)

3:47 PM WikiFormatting edited by trac

(diff)

3:47 PM WikiRestructuredTextLinks edited by trac

(diff)

3:47 PM WikiRestructuredText edited by trac

(diff)

3:47 PM WikiPageNames edited by trac

(diff)

3:47 PM WikiHtml edited by trac

(diff)

3:47 PM WikiDeletePage edited by trac

(diff)

3:47 PM TracWorkflow created by trac

3:47 PM TracWiki edited by trac

(diff)

3:47 PM TracSyntaxColoring edited by trac

(diff)

3:47 PM TracSupport edited by trac

(diff)

3:47 PM TracStandalone edited by trac

(diff)

3:47 PM TracSearch edited by trac

(diff)

3:47 PM TracRss edited by trac

(diff)

3:47 PM TracRoadmap edited by trac

(diff)

3:47 PM TracReports edited by trac

(diff)

3:47 PM TracQuery edited by trac

(diff)

3:47 PM TracPlugins edited by trac

(diff)

3:47 PM TracPermissions edited by trac

(diff)

3:47 PM TracNotification edited by trac

(diff)

3:47 PM TracNavigation created by trac

3:47 PM TracModPython edited by trac

(diff)

3:47 PM TracLogging edited by trac

(diff)

3:47 PM TracLinks edited by trac

(diff)

3:47 PM TracInterfaceCustomization edited by trac

(diff)

3:47 PM TracInstall edited by trac

(diff)

3:47 PM TracIni edited by trac

(diff)

3:47 PM TracImport edited by trac

(diff)

3:47 PM TracGuide edited by trac

(diff)

3:47 PM TracBrowser edited by trac

(diff)

3:47 PM TracBackup edited by trac

(diff)

3:47 PM TracAdmin edited by trac

(diff)

3:47 PM TracAccessibility edited by trac

(diff)

3:47 PM TitleIndex edited by trac

(diff)

3:47 PM RecentChanges edited by trac

(diff)

3:47 PM PageTemplates created by trac

3:47 PM CamelCase edited by trac

(diff)

1:32 PM Changeset in webkit [15758] by ap

3 edits
4 adds
4 deletes in trunk

Fix by Mitz Pettel, reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3438 incorrect display of transparent 1x1 PNGs

Test: fast/replaced/image-solid-color-with-alpha.html

platform/mac/ImageMac.mm: (WebCore::Image::checkForSolidColor): Changed to divide each color component by the alpha component. You need to do that since the bitmap context has premultiplied alpha but m_solidColor should be non-premultiplied.

1:26 PM Changeset in webkit [15757] by aroben

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fixed build

kjs/date_object.cpp: (KJS::formatTime):

12:06 PM Changeset in webkit [15756] by mjs

3 edits in trunk/WebKit

Reviewed by John.

fix assertion failure on layout tests by stopping plugins from loading at a clearly defined time
add more assertions for safety

WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Removed obsolete comment. (-[WebDataSource _updateLoading]): Add assertion ensuring this method is only called at a time when this data source is the one that might be loading for a frame. (-[WebDataSource _stopLoading]): Stop loading plugins as a FIXME suggests we should.
WebView/WebFrameLoader.m: (-[WebFrameLoader isLoadingPlugIns]): New helper method. (-[WebFrameLoader isLoading]): Consider plugin loads too - otherwise we won't stop them at stopLoading time.

11:35 AM Changeset in webkit [15755] by darin

2 edits in trunk/WebKitSite

building/checkout.html: Fix a typo: "OpenSource" instead of "Open Source".

11:14 AM Changeset in webkit [15754] by aroben

4 edits in trunk

WebCore:

Reviewed by Brady.

Remove redundant #include

loader/loader.cpp:

WebKit:

Reviewed by Brady.

Rename TransferJob to ResourceLoader (this file was forgotten in an earlier change by Maciej)

COM/WebView.cpp:

11:13 AM Changeset in webkit [15753] by thatcher

3 edits
1 add in trunk/WebKitTools

Reviewed by Timothy.

Bug 9931: [Drosera] Needs a cool icon
http://bugzilla.opendarwin.org/show_bug.cgi?id=9931

Drosera/Drosera.icns: Added.
Drosera/Drosera.xcodeproj/project.pbxproj:
Drosera/Info.plist:

11:07 AM Changeset in webkit [15752] by brmorris

2 edits in S60/trunk/WebKit

2006-08-02 ligman <joseph.ligman@nokia.com>

Reviewed by Yongjun, landed by Bradley.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10194
Assigned a default element type to keep the focus from being undefined.
TWebCoreFocusedElementType elType = EWebCoreElementNone;

BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):

1:11 AM Changeset in webkit [15751] by mjs

8 edits in trunk/WebKit

Reviewed by Adele.

Change things around so WebFrameLoader tracks the main and provisional data source, as well as the frame load state, pulling much code out of WebFrame along the way.

The most significant aspects of this change are:

management of WebDataSources and WebFrameState was moved into WebFrameLoader
there is now just one WebFrameLoader shared between the primary and provisional data source

WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
WebView/WebFrame.m: (-[WebFramePrivate init]): (-[WebFramePrivate dealloc]): (-[WebFrame _closeOldDataSources]): (-[WebFrame _detachFromParent]): (-[WebFrame _makeDocumentView]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueAfterWillSubmitForm:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _frameLoader]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame stopLoading]):
WebView/WebFrameInternal.h:
WebView/WebFrameLoader.h:
WebView/WebFrameLoader.m: (-[WebFrameLoader initWithWebFrame:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader _setDataSource:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader _setProvisionalDataSource:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader state]): (+[WebFrameLoader timeOfLastCompletedLoad]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader markLoadComplete]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]):
WebView/WebFramePrivate.h:

Aug 1, 2006:

4:06 PM Changeset in webkit [15750] by tomernic

4 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4480737> Flash crashes after it replaces itself via a document.write()

I kind of hate to do this, but this is the best way to work around buggy plug-ins like Flash that assume that
NPP_Destroy() cannot be called while the browser is calling one of its other plug-in functions. The classic
situation is a plug-in that replaces itself via an NPN_Invoke() that executes a document.write().

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView setWindowIfNecessary]): ditto (-[WebBaseNetscapePluginView start]): It should not be possible to start a plug-in instance while we are calling into it (one of those chicken/egg problems). Added a sanity-checking assertion. (-[WebBaseNetscapePluginView stop]): If we're already calling a plug-in function, do not call NPP_Destroy(). The plug-in function we are calling may assume that its instance->pdata, or other memory freed by NPP_Destroy(), is valid and unchanged until said plugin-function returns. (-[WebBaseNetscapePluginView pluginScriptableObject]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView willCallPlugInFunction]): Increment plug-in function call depth. (-[WebBaseNetscapePluginView didCallPlugInFunction]): Decrement plug-in function call depth. Stop if we're supposed to stop. (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): ditto (-[WebBaseNetscapePluginView _printedPluginBitmap]): ditto

Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream _deliverData]): ditto

4:04 PM Changeset in webkit [15749] by brmorris

1 copy in S60/tags/s60-RnD-06wk31_rc1

Tagging S60 RnD w31 '06 release candidate 1

3:58 PM Changeset in webkit [15748] by brmorris

3 edits in S60/trunk/WebKit

2006-08-01 hongzhao <hong.a.zhao@nokia.com>

Reviewed by Yongjun.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10184
Sound continues after page closes in Bookmark view.

Plugin/inc/PluginAdapterInterface.h: (MPluginNotifier::): Added EPluginInvisible
Plugin/src/PluginWin.cpp: (CPluginWin::MakeVisible): Sends message to Plugin notifier

3:53 PM Changeset in webkit [15747] by mjs

2 edits in trunk/WebKit

fix build after last change

WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]):

3:43 PM Changeset in webkit [15746] by brmorris

6 edits in S60/trunk/WebKit

2006-07-31 vbradley <vincent.bradley@nokia.com>

Reviewed by Yongun & Sachin

Add changes to allow the user to send plugin content to viewer.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10130

BrowserControl/src/BrCtl.cpp:
BrowserView/inc/PluginControl.h:
BrowserView/src/PluginControl.cpp:
Plugin/inc/PluginWin.h:
Plugin/src/PluginWin.cpp:

3:08 PM Changeset in webkit [15745] by brmorris

5 edits in S60/trunk

2006-08-01 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Sachin/Youngjun.

Horizontal scroll not working with WML pages.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10092

BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::ResizeBrCtlView): Set the view rectangle in WML view.

3:05 PM Changeset in webkit [15744] by mjs

2 edits in trunk/WebKit

Reviewed by Beth.

revert part of my last fix that broke the Safari bookmarks view

WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]): still send layout message for non-HTML views

1:20 PM Changeset in webkit [15743] by tomernic

2 edits in trunk/WebKit

Reviewed by Anders.

Fixed an assertion failure I ran into while debugging <rdar://problem/4652683>.

Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView redeliverStream]): Don't clear the "instance" ivar here. This code was refactored here from the old WebNetscapePluginRepresentation, which also had an "instance" ivar. It is never appropriate to clear a plug-in view's instance. That is done when the plug-in is destroyed.

1:17 PM Changeset in webkit [15742] by brmorris

2 edits in S60/trunk/WebKit

2006-07-28 zhalu <zhaosong.lu@nokia.com>

Reviewed by Youngjun.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10149

BrowserView/src/WebKitView.cpp: (CWebKitView::ProgressAndImageDecodeComplete): Now calls ScheduleRepaint()

1:06 PM Changeset in webkit [15741] by brmorris

2 edits in S60/trunk/WebKit

2006-08-01 naguo <George.Guo@nokia.com>

Reviewed by Yongjun.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10189

ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::FindDownloadL): Make sure the download is not completed before start it

12:09 PM Changeset in webkit [15740] by brmorris

2 edits in S60/trunk/WebCore

2006-08-01 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10185

www.euromaster.fi crash due to memory corruption.

kwq/KWQKURL.cpp: (KURL::KURL): free buffer (KURL::parse): free path_buffer not buffer

11:41 AM Changeset in webkit [15739] by ggaren

2 edits
3 adds in trunk/WebKitSite

Reviewed by Beth.

Added instructions for debugging in Xcode

building/build-window.png: Added.
building/build.html:
building/custom-executable.png: Added.
building/info-tab.png: Added.

11:38 AM Changeset in webkit [15738] by mjs

2 edits in trunk/WebKit

Reviewed by Geoff.

some refactoring in preparation for moving more stuff to WebFrameLoader.

WebView/WebFrame.m: (-[WebFrame _clearDataSource]): (-[WebFrame _detachFromParent]): (-[WebFrame _commitProvisionalLoad]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _clearProvisionalLoad]): (-[WebFrame _markLoadComplete]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _startProvisionalLoad:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame stopLoading]):

11:03 AM Changeset in webkit [15737] by brmorris

5 edits in S60/trunk/WebKit

2006-08-01 ligman <joseph.ligman@nokia.com>

Reviewed by Yongjun.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10131

Implemented MCoeForegroundObserver at CPluginWin to process
background/foreground events independently of changes in focus.

Plugin/inc/PluginLoader.h:
Plugin/inc/PluginSkin.h:
Plugin/inc/PluginWin.h:
Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::ProcessEventL): (CPluginWin::HandleControlEventL): (CPluginWin::ViewFocusChanged): (CPluginWin::SetPluginFocusL): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):

10:57 AM Changeset in webkit [15736] by brmorris