⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 12, 2006:

6:38 PM Changeset in webkit [15845] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that have already been drawn and are not expected to be redrawn in the same update.

Aug 11, 2006:

10:59 PM Changeset in webkit [15844] by eseidel
  • 3 edits in trunk/WebCore

2006-08-12 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt and mjs.

Fix two missing null checks causing layout test crashes.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): check e for null (null for pseudo styles)
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::requiresLayer): check parent()->element() for null
10:46 PM Changeset in webkit [15843] by ddkilzer
  • 4 edits in trunk/LayoutTests

LayoutTests:

Reviewed by NOBODY (layout test fix).

Additional layout test fixes from hyatt's "Eliminate RenderImageButton" change
in r15839. See also r15840 for more layout test fixes.

  • tables/mozilla/bugs/bug19599-expected.txt: Changed RenderImageButton to RenderImage.
  • tables/mozilla/bugs/bug24200-expected.txt: Ditto.
  • tables/mozilla/bugs/bug4527-expected.txt: Ditto.
9:07 PM Changeset in webkit [15842] by eseidel
  • 15 edits
    4 adds in trunk

2006-08-11 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

The outermost <svg> element needs to clip itself
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5358

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): adjust for SVG overflow rules
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::requiresLayer): only require layers for absolute/relative positioning of outermost SVG (WebCore::RenderSVGContainer::paint):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h: remove dead methods
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: remove dead methods (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
  • ksvg2/svg/SVGPaint.cpp: spacing changes (WebCore::SVGPaint::SVGPaint): spacing cleanup
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute): spacing cleanup
  • platform/GraphicsContext.h: Added concatCTM
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): Added.
8:22 PM Changeset in webkit [15841] by beidson
  • 7 edits in trunk

WebCore:

Reviewed by Maciej

Renamed a method/parameter for clarity and consistency, as well as some style
cleanups and removing some ridiculously verbose log messages.
Also added an _isEmpty method to the database and bridge for WebKit's use.
Finally, added a central way for both WebKit and WebCore to get the icon database filename

  • bridge/mac/WebCoreIconDatabaseBridge.h: Added _isEmpty and defaultDatabaseFilename
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Removed an unnecessary semicolon off most of these methods (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]): (-[WebCoreIconDatabaseBridge closeSharedDatabase]): (-[WebCoreIconDatabaseBridge isOpen]): (-[WebCoreIconDatabaseBridge _isEmpty]): Added (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]): (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]): (-[WebCoreIconDatabaseBridge defaultDatabaseFilename]): Added
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Added (WebCore::IconDatabase::open): (WebCore::IconDatabase::isEmpty): Added (WebCore::IconDatabase::retainIconForURL): Removed log message (WebCore::IconDatabase::releaseIconForURL): Removed log message
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John, Timo, Adele, and Darin

In addition to a few style/good-practice cleanups, this patch will convert the old icon database
format to the WebCore format if the WebCore db is empty (implying this conversion has yet to take
place). After the conversion, it will delete all traces of the old format to free the unneeded space

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase _setIconURL:forURL:]): Changed the bridge's name for this method to be more clear (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _iconDataForIconURL:]): This grabs the raw data for use in the conversion function (-[WebIconDatabase _convertToWebCoreFormat]): This does the actual conversion
4:53 PM Changeset in webkit [15840] by hyatt
  • 5 edits in trunk/LayoutTests/fast/forms

Update layout tests for removal of RenderImageButton

4:52 PM Changeset in webkit [15839] by hyatt
  • 5 edits in trunk/WebCore

Eliminate RenderImageButton.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isImageButton]):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer):
  • rendering/RenderImage.h: (WebCore::RenderImage::isImage):
4:49 PM Changeset in webkit [15838] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady.

Test case for <rdar://problem/4656274>
REGRESSION: option elements are selected when added regardless of "selected" property

  • fast/forms/option-constructor-selected-expected.txt: Added.
  • fast/forms/option-constructor-selected.html: Added.

WebCore:

Reviewed by Brady.

  • Fix for <rdar://problem/4656274> REGRESSION: option elements are selected when added regardless of "selected" property

Test: fast/forms/option-constructor-selected.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): When adding an option element, check that the option element is selected before calling setSelectedIndex.
4:06 PM Changeset in webkit [15837] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.


Needed for <rdar://problem/4678070>.

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Changed an assertion to an early return. It should be possible to send events, especially updateEvt (for image capturing purposes), to off-screen plug-ins. It just doesn't work right now. See <rdar://problem/4318269>.
3:35 PM Changeset in webkit [15836] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin


  • fixed <rdar://problem/4522894> Would be nice if Safari shrank pages a little if necessary to avoid printing an almost-empty page
  • WebView/WebHTMLView.m: (-[NSArray knowsPageRange:]): If the last page has a short-enough orphan (< 1/10 of the page height is the number I pulled out of ... the air), then we adjust the scale factor slightly and check whether this reduces the page count and thus eliminates the orphan.
2:26 PM Changeset in webkit [15835] by hyatt
  • 4 adds in trunk/LayoutTests/fast/dynamic

Add layout test for link bug.

2:18 PM Changeset in webkit [15834] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 10349, make sure to call setChanged when an anchor changes
from not being a link to being a link (and vice versa).

Test is in fast/dynamic/link-href-change.html

Reviewed by darin

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::parseMappedAttribute):
  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
1:58 PM Changeset in webkit [15833] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Revert an over-optimization step that messed up the HashSet lookup.

10:46 AM Changeset in webkit [15832] by oliver
  • 2 edits in trunk/WebCore

Removing unnecessary comment from patch for bug 10346

10:15 AM Changeset in webkit [15831] by oliver
  • 2 edits in trunk/WebCore

Fix for bug #10346, fixes regression in svg image layout

Note: See TracTimeline for information about the timeline view.