Timeline

Aug 13, 2006:

11:50 PM Changeset in webkit [15851] by beidson

• 2 edits
  2 moves in trunk/WebKit

Reviewed by Maciej

Relocated the WebIconLoaders

• Misc/WebIconLoader.h: Moved to Loader/
• Misc/WebIconLoader.m: Moved to Loader/
• WebKit.xcodeproj/project.pbxproj:

11:46 PM Changeset in webkit [15850] by beidson

• 1 edit in trunk/WebKit/ChangeLog

Fixed my inaccurately stated Changelog

11:45 PM Changeset in webkit [15849] by mjs

• 3 edits in trunk/WebKit

Reviewed by Beth.

• removed non-Loader WebKit dependencies from WebDataProtocol for real (whoops) and fix some typos.

• Loader/WebDataProtocol.m: (isCaseInsensitiveEqual): Added. (+[WebDataProtocol _webIsDataProtocolURL:]): Avoid WebKit calls. (-[WebDataProtocol startLoading]): ditto
• Loader/WebFrameLoader.m: (isCaseInsensitiveEqual): Fixed spelling from isCaseSensitiveEqual. (-[WebFrameLoader _canUseResourceForRequest:]): Use proper call.

11:44 PM Changeset in webkit [15848] by beidson

• 2 edits in trunk/WebKit

Reviewed by Maciej

The way of detecting a failed icon load before was to try and construct
an image from the icon and if that image construction failed, mark the icon
as missing.
A much more efficient way is to check for a 404 response. We'll still
check for invalid image data, but most servers will correctly return 404
on a missing icon.

• Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): Added check for 404 response

8:22 PM Changeset in webkit [15847] by mjs

• 9 edits
  2 moves in trunk/WebKit

Reviewed by Darin.

• remove all non-Loader dependencies from WebLoader

As part of this I moved WebDataProtocol to the loader directory
and removed dependencies on the rest of WebKit from that too.

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader clearArchivedResources]): (-[WebFrameLoader deliverArchivedResources]): (-[WebFrameLoader deliverArchivedResourcesAfterDelay]): (isCaseSensitiveEqual): (-[WebFrameLoader _canUseResourceForRequest:]): (-[WebFrameLoader _canUseResourceWithResponse:]): (-[WebFrameLoader pendingArchivedResources]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
• Loader/WebLoader.h:
• Loader/WebLoader.m: (-[NSURLProtocol releaseResources]): (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol setDefersCallbacks:]): (-[NSURLProtocol addData:allAtOnce:]): (-[NSURLProtocol resourceData]): (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]): (-[NSURLProtocol connection:didReceiveData:lengthReceived:]): (-[NSURLProtocol cancelWithError:]): (-[NSURLProtocol cancelledError]):
• Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader addData:allAtOnce:]): (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
• Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:allAtOnce:]):
• Loader/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveData:lengthReceived:allAtOnce:]):
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDataProtocol.h: Removed.
• WebView/WebDataProtocol.m: Removed.

8:06 PM Changeset in webkit [15846] by mjs

• 22 edits
  1 copy
  2 adds in trunk

JavaScriptCore:

Reviewed (and tweaked a little) by Maciej.

• shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting in a 1.2% speed improvement on JS iBench (and probably overall memory savings).

This was done by removing _scope and _internalValue data members
from JSObject and moving them only to the subclasses that actually
make use of them.

• kjs/object.cpp: (KJS::JSObject::mark): No need to mark scope or internal value here.
• kjs/object.h: (KJS::JSObject::JSObject): Don't initialize them.
• kjs/JSWrapperObject.cpp: Added. New base class for object types that wrap primitive values (Number, String, Boolean, Date). (KJS::JSWrapperObject::mark):
• kjs/JSWrapperObject.h: Added. (KJS::JSWrapperObject::JSWrapperObject): (KJS::JSWrapperObject::internalValue): (KJS::JSWrapperObject::setInternalValue):
• kjs/array_object.cpp: (ArrayPrototype::ArrayPrototype): Don't set useless internal value.
• kjs/bool_object.cpp: (BooleanInstance::BooleanInstance): Inherit from JSWrapperObject. (BooleanProtoFunc::callAsFunction): Fixed to account for fact that not all JSObjects have an internal value. (BooleanObjectImp::construct): ditto.
• kjs/bool_object.h:
• kjs/collector.cpp: Lowered cell size to 48. (KJS::Collector::allocate): meaningless whitespace change
• kjs/date_object.cpp: (KJS::DateInstance::DateInstance): Inherit from JSWrapperObject. (KJS::DateProtoFunc::callAsFunction): adjusted for move of internalValue (KJS::DateObjectImp::construct): ditto
• kjs/date_object.h:
• kjs/error_object.cpp: (ErrorPrototype::ErrorPrototype): don't set internal value
• kjs/function.cpp: move _scope and related handling here (KJS::FunctionImp::mark): mark scope
• kjs/function.h: (KJS::FunctionImp::scope): moved here from JSObject (KJS::FunctionImp::setScope): ditto
• kjs/number_object.cpp: (NumberInstance::NumberInstance): inherit from JSWrapperObject (NumberProtoFunc::callAsFunction): adjusted (NumberObjectImp::construct): adjusted
• kjs/number_object.h: shring RegExp-related objects a little
• kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): Adjust for size tweaks (RegExpObjectImp::RegExpObjectImp): ditto
• kjs/regexp_object.h:
• kjs/string_object.cpp: (StringInstance::StringInstance): inherit from JSWrapperObject (StringProtoFunc::callAsFunction): adjusted
• kjs/string_object.h:
• JavaScriptCore.exp: Exported new methods as needed.
• JavaScriptCore.xcodeproj/project.pbxproj: Added new files to build.

WebCore:

Reviewed (and tweaked a little) by Maciej.

• shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting in a 1.2% speed improvement on JS iBench (and probably overall memory savings).

The WebCore part of this is to expect only FunctionImp to have a scope, not all JSObjects.

• bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):

Aug 12, 2006:

6:38 PM Changeset in webkit [15845] by tomernic

• 2 edits in trunk/WebKit

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

• Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that have already been drawn and are not expected to be redrawn in the same update.