⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 18, 2006:

10:35 PM Changeset in webkit [15945] by sfalken
  • 2 edits in trunk/WebCore

2006-08-18 Steve Falkenburg <​sfalken@apple.com>

Rubber stamped by adele.


Fix call to WebFormDelegate's textFieldDidBeginEditing.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged):


4:26 PM Changeset in webkit [15944] by rwlbuis
  • 1 edit
    3 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Next chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

WebKit should have Qt platform support

4:20 PM Changeset in webkit [15943] by rwlbuis
  • 1 edit
    7 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Next chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

3:47 PM Changeset in webkit [15942] by rwlbuis
  • 1 edit
    6 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

First chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

3:34 PM Changeset in webkit [22113] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-08-18 Anders Carlsson <​acarlsson@apple.com>

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::destroyStream): Another attempt at fixing the build. Make these two functions into instance methods of PluginViewWin.
3:27 PM Changeset in webkit [22112] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

2006-08-18 Anders Carlsson <​acarlsson@apple.com>

  • plugins/win/PluginViewWin.cpp: (WebCore::write): (WebCore::destroyStream):
  • plugins/win/PluginViewWin.h: Fix build by removing unneeded parameters.
3:16 PM Changeset in webkit [15941] by rwlbuis
  • 7 adds in trunk/WebCore/platform/qt

Reviewed by Eric. Landed by rwlbuis.

First chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

3:08 PM Changeset in webkit [22111] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-08-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

Have the NPN functions call into the plugin view. Implement some of the plugin view methods.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::setCurrentPluginView): (WebCore::PluginViewWin::currentPluginView): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::postURLNotify): (WebCore::PluginViewWin::postURL): (WebCore::PluginViewWin::newStream): (WebCore::write): (WebCore::destroyStream): (WebCore::PluginViewWin::userAgent): (WebCore::PluginViewWin::status): (WebCore::PluginViewWin::getValue): (WebCore::PluginViewWin::setValue): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
  • plugins/win/npapi.cpp: (pluginViewForInstance): (NPN_ReloadPlugins): (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_UserAgent): (NPN_Status): (NPN_GetValue): (NPN_SetValue):
12:33 PM Changeset in webkit [15940] by rwlbuis
  • 1 edit in trunk/JavaScriptCore/wtf/unicode/UnicodeDirection.h

I hope I got this finally right, learning all the time :|

12:26 PM Changeset in webkit [15939] by rwlbuis
  • 3 edits in trunk/JavaScriptCore/wtf/unicode

Accidently doubly applied patch for:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
Sorry for any inconvenience!

12:11 PM Changeset in webkit [15938] by rwlbuis
  • 1 edit
    17 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10470
The Qt platform needs a KCanvas device.

11:53 AM Changeset in webkit [15937] by rwlbuis
  • 3 edits
    3 adds in trunk/JavaScriptCore

Reviewed by Maciej. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WTF Changes needed for Qt platform code.

11:27 AM Changeset in webkit [22110] by andersca
  • 7 edits
    4 adds in branches/WindowsMerge/WebCore

2006-08-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Steve and Maciej.

Add initial implementation of plugin view.

  • WebCore.vcproj/WebCore.vcproj: Add files.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::objectContentType): (WebCore::FrameWin::createPlugin): Implement these functions.


  • platform/win/TemporaryLinkStubs.cpp: Remove implemented functions.


  • platform/win/WidgetWin.cpp: Add this file from the open source repo (WebCore::Widget::~Widget): Call DestroyWindow on the hWnd.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): New function which creates a plugin view.


  • plugins/win/PluginDatabaseWin.h:


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Assign the browser functions. They are just stubs for now.


  • plugins/win/PluginViewWin.cpp: Added. (WebCore::registerPluginView): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::invokeSetWindow): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::createUTF8String): (WebCore::createUTF8StringArray): (WebCore::freeStringArray): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h: Added. (WebCore::PluginViewWin::plugin): (WebCore::PluginViewWin::instance):
  • plugins/win/npapi.cpp: Added. (NPN_MemAlloc): (NPN_MemFree): (NPN_MemFlush): (NPN_ReloadPlugins): (NPN_RequestRead): (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_UserAgent): (NPN_Status): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw): (NPN_GetValue): (NPN_SetValue): (NPN_GetJavaEnv): (NPN_GetJavaPeer):
9:23 AM Changeset in webkit [15936] by brmorris
  • 2 edits in S60/trunk/group

2006-08-18 brmorris <​bradley.morrison@nokia.com>

Reviewed by me.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10484

  • Distribution.Policy.S60: Set to 0
6:03 AM Changeset in webkit [15935] by rwlbuis
  • 3 edits
    1 add in trunk

Fixing my mistakes with landing of:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10466

4:58 AM Changeset in webkit [15934] by rwlbuis
  • 1 add in trunk/CMakeLists.txt

I forgot to commit this as part of:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10464

4:45 AM Changeset in webkit [15933] by rwlbuis
  • 20 edits in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10466
WebKit should have Qt platform support.

4:21 AM Changeset in webkit [15932] by rwlbuis
  • 10 edits in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10465
General WebKit Linux build fixes.

4:04 AM Changeset in webkit [15931] by rwlbuis
  • 2 edits
    2 adds in trunk

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10464
Offer a cmake build system for Qt platform.

Aug 17, 2006:

4:05 PM Changeset in webkit [15930] by harrison
  • 6 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4671069> REGRESSION: Popup buttons in web pages aren't exposed as AXPopupButtons

Accessorized RenderMenuList objects.


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject mouseButtonListener]): Trivial formatting.


(-[WebCoreAXObject actionElement]):
Return the HTMLSelectElement.


(-[WebCoreAXObject firstChild]):
(-[WebCoreAXObject lastChild]):
(-[WebCoreAXObject previousSibling]):
(-[WebCoreAXObject nextSibling]):
(-[WebCoreAXObject parentObject]):
(-[WebCoreAXObject parentObjectUnignored]):
(-[WebCoreAXObject isAttachment]):
(-[WebCoreAXObject attachmentView]):
Trivial formatting.

(-[WebCoreAXObject role]):
Return NSAccessibilityPopUpButtonRole.

(-[WebCoreAXObject subrole]):
Trivial formatting.


(-[WebCoreAXObject roleDescription]):
Return NSAccessibilityPopUpButtonRole.


(-[WebCoreAXObject textUnderElement]):
Trivial formatting.

(-[WebCoreAXObject value]):
Return the RenderMenuList::text().


(-[WebCoreAXObject position]):

Trivial formatting.

(-[WebCoreAXObject accessibilityIsIgnored]):

  • Ignore popup menu items because AppKit does.
  • Remove redundant check for buttonTag (earlier isControl() check suffices).


(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityActionNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Trivial formatting.


(-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
Removed old debugging code that is no longer needed.
Trivial formatting.


(-[WebCoreAXObject doAXSentenceTextMarkerRangeForTextMarker:]):
(-[WebCoreAXObject doAXParagraphTextMarkerRangeForTextMarker:]):
(-[WebCoreAXObject removeAXObjectID]):
Trivial formatting.


  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): Call click() instead of focus().


  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text): Added for easy access to popup's current text.


  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::isMenuList):
  • rendering/RenderObject.h: (WebCore::RenderObject::isMenuList): Added so popups can be identified.
3:23 PM Changeset in webkit [15929] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4606857> WebKit: WebPreferencesChangedNotification not exported in 64-bit

  • WebKit.LP64.exp:
2:13 PM Changeset in webkit [22109] by andersca
  • 5 edits
    8 adds in branches/WindowsMerge

WebCoreWin:

2006-08-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej.

Add initial implementation of plugin database.


  • WebCore.vcproj/WebCore.vcproj: Add new files.


  • platform/win/TemporaryLinkStubs.cpp: Get rid of the PlugInInfoStore stubs.
  • plugins/win/PlugInInfoStoreWin.cpp: Added. (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins):
  • plugins/win/PluginDatabaseWin.cpp: Added. (WebCore::PluginDatabaseWin::installedPlugins): (WebCore::PluginDatabaseWin::refresh): (WebCore::PluginDatabaseWin::plugins): (WebCore::PluginDatabaseWin::getPluginsInPaths): (WebCore::PluginDatabaseWin::defaultPluginPaths): (WebCore::PluginDatabaseWin::isMIMETypeRegistered): (WebCore::PluginDatabaseWin::pluginForMIMEType): (WebCore::PluginDatabaseWin::pluginForExtension):
  • plugins/win/PluginDatabaseWin.h: Added. (WebCore::PluginDatabaseWin::setPluginPaths):
  • plugins/win/PluginPackageWin.cpp: Added. (WebCore::PluginPackageWin::~PluginPackageWin): (WebCore::getVersionInfo): (WebCore::splitString): (WebCore::PluginPackageWin::PluginPackageWin): (WebCore::PluginPackageWin::fetchInfo): (WebCore::PluginPackageWin::load): (WebCore::PluginPackageWin::unload): (WebCore::PluginPackageWin::unloadWithoutShutdown): (WebCore::PluginPackageWin::createPackage): (WebCore::PluginPackageWin::hash): (WebCore::PluginPackageWin::equal):
  • plugins/win/PluginPackageWin.h: Added. (WebCore::PluginPackageWin::name): (WebCore::PluginPackageWin::description): (WebCore::PluginPackageWin::fileName): (WebCore::PluginPackageWin::mimeToDescriptions): (WebCore::PluginPackageWin::mimeToExtensions): (WebCore::PluginPackageWin::pluginFuncs): (WebCore::PluginPackageWinHash::hash): (WebCore::PluginPackageWinHash::equal): (WTF::):
  • plugins/win/npfunctions.h: Added.

WebKitWin:

2006-08-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej.

  • WebKit.vcproj/WebKit.vcproj: Add version.lib
1:37 PM Changeset in webkit [15928] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-08-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

  • bindings/npapi.h: Fix ifdef.
1:06 PM Changeset in webkit [15927] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4527201> REGRESSION: AXTextMarkerRangeForUnorderedTextMarkers returns out of order range

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::visiblePositionForTextMarker): Validate the marker by comparing the node and offset to those of the resulting VisiblePosition.
12:58 PM Changeset in webkit [15926] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4633896> -[WebView close] should clear all delegates and call setHostWindow:nil
<rdar://problem/4649759> Crash when selecting View Source menu using Chinese (-[WebView _close])

Check to make sure _private is not null. A WebView can be dealloced before _private is setup.
Set the _private->closed flag at the beginning of _close to prevent reentry.
Set the host window and all the delegates to nil in _close.

  • WebView/WebView.m: (-[WebView _close]):
7:55 AM Changeset in webkit [15925] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-16 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10325
There is no data supplier provided for external links in LoadPage, so the data is not
loaded. Also, client "leaves" are not handled from ResolveLinkL in the BufferTransaction's
DoSubmit.function. Cleaned up the indentation

  • BrowserView/src/WebKitLoader.cpp: (CWebKitOOMStopper::Priority): (CWebKitLoader::ConstructL): (CWebKitLoader::NewL): (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadFavicon):
  • ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::CancelTransactionCB): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::DoSubmitL): (CBufferTransaction::HandleResolveComplete): (CBufferTransaction::HandleNextDataChunk): (CBufferTransaction::HandleNextDataChunkL): (CBufferTransaction::HandleClientDataChunkL):
Note: See TracTimeline for information about the timeline view.