⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 28, 2006:

6:13 PM Changeset in webkit [16089] by ggaren
  • 14 edits
    3 adds in trunk

Reviewed by Maciej.


Added support for experimental CFNetwork-based loader (not turned on yet).


While I was there, I did the following platform cleanup:

  • Windows now uses USE(WININET) instead of PLATFORM(WIN_OS), to match the USE(CFNETWORK) idiom.
  • Removed some #includes of windows.h in platform-independent headers.
  • Changed #ifdef APPLE to PLATFORM(MAC)
  • Fixed some build bustage, including case-sensitive filesystem bustage.
  • loader/loader.cpp: (WebCore::Loader::receivedAllData):
  • platform/Cursor.h:
  • platform/KURL.h:
  • platform/ResourceLoader.h:
  • platform/ResourceLoaderClient.h:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/cfnet/KURLCFNet.cpp: Added. (WebCore::KURL::createCFURL):
  • platform/cfnet/ResourceLoaderCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveChallenge): (WebCore::didCancelChallenge): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::addHeadersFromString): (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::arrayFromFormData): (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
  • platform/win/CursorWin.cpp:
6:05 PM Changeset in webkit [22126] by ggaren
  • 14 edits in branches/WindowsMerge

Reviewed by Maciej.

Landed CFNetwork loader, off by default. To enable, define:

KXMLCORE_PLATFORM_CF
KXMLCORE_USE_CFNETWORK

CFNetwork uses winsock2. If you do this, you need to make sure that winsock2.h
is included before windows.h in any translation unit in which it's used.
A lot of the jiggering in this patch is devoted to that.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ResourceLoaderWin.cpp: Removed reliance on PlatformData since it wasn't being used, and removing it made easy work of integrating CFNetwork in a Windows-independent way. (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
  • platform/win/TemporaryLinkStubs.cpp: (Path::contains):
  • platform/win/WidgetWin.cpp:
  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/win/PluginPackageWin.h:
  • plugins/win/PluginViewWin.h:
  • plugins/win/npapi.cpp:
  • rendering/RenderPopupMenuWin.cpp:
  • rendering/RenderPopupMenuWin.h:
  • rendering/RenderThemeWin.cpp:
5:59 PM Changeset in webkit [22125] by adachan
  • 4 edits in branches/WindowsMerge
5:35 PM Changeset in webkit [16088] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/inserting/redo-expected.checksum: Added.
  • editing/inserting/redo-expected.png: Added.
  • editing/inserting/redo-expected.txt: Added.
  • editing/inserting/redo.html: Added.
  • editing/pasteboard/copy-paste-bidi-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4700341>
REGRESSION: In new mail message, caret isn't placed at end of line after redoing typing

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Added a FIXME.
  • page/Frame.cpp: (WebCore::Frame::reappliedEditing): Restore the endingSelection(), not the startingSelection().
5:30 PM Changeset in webkit [16087] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Removed a bogus typecast.
4:18 PM Changeset in webkit [16086] by tomernic
  • 7 edits in trunk

WebCore:

Reviewed by John Sullivan.

Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox

No test cases added, since this is essentially a leak fix.

A brief history of NPP_GetValue(), NPObjects, and reference counting.

Earlier versions of WebKit incorrectly interpreted the NPRuntime reference counting rules. We failed to take
into account the fact that plug-ins are required to retain NPObjects before returning them. This creates several
classes of interesting plug-ins:

1) Plug-ins tested in WebKit and other browsers. These plug-ins may have WebKit-specific workarounds to not retain

the returned NPObject, thus avoiding the memory leak in WebKit.

2) Plug-ins tested only in other browsers. These plug-ins must already retain their NPObjects, since other browsers

implemented the NPRuntime retain/release rules correctly. These plug-ins likely work in WebKit, but probably leak
NPObjects since WebKit adds its own retain in addition to the plug-in's retain.

3) Plug-ins tested only in WebKit, that fail to retain their NPObjects before returning them.

Such plug-ins are guaranteed to crash in other browsers due to the missing expected retain. These plug-ins
work in older WebKits because WebKit did not expect the plug-in to retain the NPObject. Now that our retain
rules match other browsers, these plug-ins may crash due to the difference in retain/release behavior. We could
potentially detect that situation and correct it here, but I consider it a bug that the plug-in did not follow the
documented NPRuntime reference counting rules. Furthermore, it is extremely unlikely that someone would develop
a Netscape plug-in and test it *only* in WebKit. The entire purpose of creating a Netscape plugin is so that it
works in all browsers!

4) Plug-ins tested only in WebKit, that properly retain their NPObjects before returning them.

These plug-ins probably work in other browsers, and leak their NPObjects in older WebKits because of WebKit's
extra retain. A developer of this type of plug-in is probably unaware of the NPObject leak. A more savvy developer
would create a plug-in that fits into category #1.


I am changing our NPP_GetValue() behavior to match Firefox and other browsers -- the plug-in is now expected to retain the
returned NPObject, and the browser is expected to release it when done. This means that plug-ins in category #3 need to be
changed so that they don't crash in Safari. However, such plug-ins already crash in every other browser, so I do not feel that
this needs to be handled specifically by WebKit.

  • bridge/mac/FrameMac.mm: Changed -pluginScriptableObject to -createPluginScriptableObject to make clearer the contract that the method must return a retained NPObject. Also changed it to return an actual NPObject* instead of a void*. There is only one caller of this method, and only one implementor. Using void* here is a needless abstraction. It's an NPObject*! Admit it! (WebCore::getInstanceForView): Release the NPObject after creating the bindings instance. This is the actual bug fix.

WebKit:

Reviewed by John Sullivan.

Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Renamed this method (see corresponding WebCore ChangeLog entry for an explanation). Style changes.

WebKitTools:

Reviewed by John Sullivan.

Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_GetValue): WebKit's NPP_GetValue() reference counting behavior has been changed to match Firefox. NPObject return values are expected to be retained by the plug-in, and released by the caller.
3:56 PM Changeset in webkit [16085] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-28 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Some foreign site encoding errors -- due to encoding alias "X-MS950-HKSCS".
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10607

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQCharsetData.c:
3:48 PM Changeset in webkit [16084] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-25 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan.

WARNING: NO TEST CASES ADDED OR CHANGED

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10573


  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle):
2:19 PM Changeset in webkit [16083] by brmorris
  • 18 edits in S60/branches/printing_sabina

2006-08-28 sabina <​sabina.siddiqi@nokia.com>

Reviewed by Bradley.


First cut at print implementation.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9739

  • S60.hrh: Print flags
  • S60StaticLibs.zip: Printing libs
  • WebUi/data/WebUi.rss:
    • WebUi/inc/WebUi.hrh:
    • WebUi/inc/WebUiAppUi.h:
    • WebUi/inc/WebUiLoadObserver.h: (CWebUiLoadObserver::OffScreenBitmapH):
    • WebUi/inc/WebUiWindow.h: (CWebUiWindow::DialogsProvider): (CWebUiWindow::LoadObserver):
    • WebUi/src/WebUiAppUi.cpp: (CWebUiAppUi::ConstructL): (CWebUiAppUi::HandleCommandL): (CWebUiAppUi::ActiveView):
    • WebUi/src/WebUiLoadObserver.cpp: (CWebUiLoadObserver::NewL): (CWebUiLoadObserver::HandleBrowserLoadEventL): (CWebUiLoadObserver::GetProgressInfo):
    • khtml/khtml_part.cpp: (KHTMLPart::print):
    • BrowserView/inc/webkitbridge.h:
    • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
    • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::Print): (CWebKitBridge::PrintBandL): (CWebKitBridge::NotifyBandPrinted): (CWebKitBridge::NotifyPrintStarted): (CWebKitBridge::NotifyPrintEnded):
    • group/webkit.mmp:
2:08 PM Changeset in webkit [16082] by brmorris
  • 1 copy in S60/branches/printing_sabina

New feature branch

1:43 PM Changeset in webkit [16081] by aliceli1
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Added tests for <rdar://problem/4548537> Document.domain and other attributes are blank for an iframe created with document.write

  • http/tests/misc/iframe-domain-test-expected.txt: Added.
  • http/tests/misc/iframe-domain-test.html: Added.

WebCore:

Reviewed by Geoff.

Fixed <rdar://problem/4548537> Document.domain and other attributes are blank for an iframe created with document.write

  • dom/Document.cpp: (WebCore::Document::open): set the document's url to the parent's url and re-located the code that does this to occur before calling the frame's didExplicitOpen()
  • page/Frame.cpp: (WebCore::Frame::didExplicitOpen): set the frame's url to the document's url
12:00 PM Changeset in webkit [16080] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele and Adam

Added an optimization to return early if there's no replacements to be made

  • platform/StringImpl.cpp: (WebCore::StringImpl::replace):
11:49 AM Changeset in webkit [16079] by ap
  • 3 edits
    2 adds in trunk/WebCore

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Provide stub implementation of RenderPopupMenuQt.

  • CMakeLists.txt:
  • platform/qt/RenderPopupMenuQt.cpp: Added. (WebCore::RenderPopupMenuQt::RenderPopupMenuQt): (WebCore::RenderPopupMenuQt::~RenderPopupMenuQt): (WebCore::RenderPopupMenuQt::clear): (WebCore::RenderPopupMenuQt::populate): (WebCore::RenderPopupMenuQt::showPopup): (WebCore::RenderPopupMenuQt::hidePopup): (WebCore::RenderPopupMenuQt::addSeparator): (WebCore::RenderPopupMenuQt::addGroupLabel): (WebCore::RenderPopupMenuQt::addOption):
  • platform/qt/RenderPopupMenuQt.h: Added.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::systemFont): (WebCore::RenderThemeQt::createPopupMenu):
11:40 AM Changeset in webkit [16078] by ap
  • 3 edits in trunk/WebCore

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Offer QString -> DeprecatedString conversion.

  • platform/DeprecatedString.h:
  • platform/qt/StringQt.cpp: (WebCore::DeprecatedString::DeprecatedString):
11:37 AM Changeset in webkit [16077] by ap
  • 5 edits in trunk

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Tim Hatcher.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

WebCore:

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::systemFont): Remove annoying notImplemented() usage in systemFont()

WebKitTools:

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::checkLoaded): Faster polling for isLoaded() in Qt's DumpRenderTree.
  • Scripts/run-webkit-tests: Use -expected-qt.txt etc.. output in run-webkit-test if isQt().
11:25 AM Changeset in webkit [16076] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • kjs/list.h: Use explicit in constructor (as appropriate).
11:22 AM Changeset in webkit [16075] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/build-drosera: Fix behavior when there are multiple options.
11:22 AM Changeset in webkit [16074] by beidson
  • 5 edits
    2 copies in trunk/WebKit

Reviewed by Tim Hatcher's rubberstamp

Rolled out my last change (16070 - pruning WebFileDatabase code) as it caused a difficult-to-track down
failure in layout tests on a release build.

  • Misc/WebFileDatabase.h:
  • Misc/WebFileDatabase.m: (+[WebFileDatabaseOp opWithCode:key:object:]): (-[WebFileDatabaseOp initWithCode:key:object:]): (-[WebFileDatabaseOp opcode]): (-[WebFileDatabaseOp key]): (-[WebFileDatabaseOp object]): (-[WebFileDatabaseOp perform:]): (-[WebFileDatabaseOp dealloc]): (SetThreadPriority): (-[WebFileDatabase _createLRUList:]): (-[WebFileDatabase _truncateToSizeLimit:]): (+[WebFileDatabase _syncLoop:]): (databaseInit): (-[WebFileDatabase setTimer]): (-[WebFileDatabase setObject:forKey:]): (-[WebFileDatabase removeObjectForKey:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase open]): (-[WebFileDatabase close]): (-[WebFileDatabase lazySync:]): (-[WebFileDatabase sync]): (-[WebFileDatabase sizeLimit]): (-[WebFileDatabase count]): (-[WebFileDatabase usage]): (-[WebFileDatabase setSizeLimit:]):
  • Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _loadIconDictionaries]):
  • WebKit.xcodeproj/project.pbxproj:
11:18 AM Changeset in webkit [16073] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • WebInspector/webInspector/inspector.js: Add "resize: none" to the list of default values for CSS properties so it will be omitted from most displays of computed style.
8:54 AM Changeset in webkit [16072] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3942647> Support AXStyleTextMarkerRangeForTextMarker parameterized attribute

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityParameterizedAttributeNames]): Add AXStyleTextMarkerRangeForTextMarker.


(startOfStyleRange):
(endOfStyleRange):
Return first/last VisiblePosition in range having the same style has the specified VisiblePosition.

(-[WebCoreAXObject doAXStyleTextMarkerRangeForTextMarker:]):
Return AXTextMarkerRange for startOfStyleRange/endOfStyleRange of the specified AXTextMarker.


(-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
Call doAXStyleTextMarkerRangeForTextMarker for AXStyleTextMarkerRangeForTextMarker.

8:46 AM Changeset in webkit [16071] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4517383> Hide all images used for spacing purpose in AX

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]): Check for one-dimensional image Check whether rendered image was stretched from one-dimensional file image
2:18 AM Changeset in webkit [16070] by beidson
  • 5 edits
    2 deletes in trunk/WebKit

Reviewed by Maciej

Major prune of unnecessary WebFileDatabase code. In the end, what
useful code that remains in WebFileDatabase will likely be moved directly
into WebIconDatabase

  • Misc/WebFileDatabase.h:
  • Misc/WebFileDatabase.m: (-[WebFileDatabase initWithPath:]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase open]): (-[WebFileDatabase close]):
  • Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _loadIconDictionaries]):
  • Misc/WebLRUFileList.h: Removed.
  • Misc/WebLRUFileList.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:

Aug 27, 2006:

10:59 PM Changeset in webkit [16069] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Rewrote StringImpl::replace(UChar, StringImpl*)

  • platform/StringImpl.cpp: (WebCore::StringImpl::replace):
8:33 PM Changeset in webkit [16068] by weinig
  • 31 edits
    10 adds in trunk

WebCore:

Reviewed by Tim H.

First round of auto-generated Objective C DOM bindings, starting
with the DOM Core.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMNode description]): (-[DOMNode KJS::Bindings::]): (-[DOMNode dispatchEvent:]): (-[DOMNamedNodeMap _initWithNamedNodeMap:]): (+[DOMNamedNodeMap _namedNodeMapWith:]): (-[DOMNodeList _initWithNodeList:]): (+[DOMNodeList _nodeListWith:]): (-[DOMImplementation _initWithDOMImplementation:]): (+[DOMImplementation _DOMImplementationWith:]): (-[DOMImplementation _DOMImplementation]): (+[DOMDocumentFragment _documentFragmentWith:]): (-[DOMDocumentFragment _fragment]): (-[DOMDocument createCSSStyleDeclaration]): (+[DOMDocument _documentWith:]): (-[DOMDocument _document]): (-[DOMDocument _ownerElement]): (+[DOMAttr _attrWith:]): (-[DOMAttr _attr]): (+[DOMDocumentType _documentTypeWith:WebCore::]): (-[DOMDocumentType WebCore::]): (+[DOMText _textWith:WebCore::]): (+[DOMComment _commentWith:WebCore::]): (+[DOMCDATASection _CDATASectionWith:WebCore::]): (+[DOMProcessingInstruction _processingInstructionWith:WebCore::]): (+[DOMEntityReference _entityReferenceWith:WebCore::]):
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.mm: (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/objc/DOMImplementationFront.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMNode.h: Added.
  • bindings/objc/DOMNode.mm: Added. (-[DOMNode dealloc]): (-[DOMNode finalize]): (-[DOMNode nodeName]): (-[DOMNode nodeValue]): (-[DOMNode setNodeValue:]): (-[DOMNode nodeType]): (-[DOMNode parentNode]): (-[DOMNode childNodes]): (-[DOMNode firstChild]): (-[DOMNode lastChild]): (-[DOMNode previousSibling]): (-[DOMNode nextSibling]): (-[DOMNode attributes]): (-[DOMNode ownerDocument]): (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]): (-[DOMNode hasChildNodes]): (-[DOMNode cloneNode:]): (-[DOMNode normalize]): (-[DOMNode isSupported::]): (-[DOMNode namespaceURI]): (-[DOMNode prefix]): (-[DOMNode setPrefix:]): (-[DOMNode localName]): (-[DOMNode hasAttributes]): (-[DOMNode isSameNode:]): (-[DOMNode isEqualNode:]): (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): (-[DOMNode textContent]): (-[DOMNode setTextContent:]): (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]):
  • bindings/objc/DOMObject.h: Added.
  • bindings/objc/DOMObject.mm: Added. (-[DOMObject init]): (-[DOMObject dealloc]): (-[DOMObject finalize]): (-[DOMObject copyWithZone:]): (-[DOMObject sheet]):
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRange.h:
  • bindings/objc/DOMStylesheets.h:
  • bindings/objc/DOMTraversal.h:
  • bindings/objc/DOMViews.h:
  • bindings/objc/DOMViews.mm:
  • bindings/objc/DOMXPath.h:
  • bindings/objc/DOMXPath.mm:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm: Added.
  • dom/Attr.idl:
  • dom/CDATASection.idl: Added.
  • dom/Comment.idl: Added.
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/EntityReference.idl: Added.
  • dom/NamedNodeMap.idl: Added.
  • dom/NodeList.idl: Added.
  • dom/ProcessingInstruction.idl:

WebKit:

Reviewed by Tim H.

First round of auto-generated Objective C DOM bindings, starting
with the DOM Core.

  • WebKit.xcodeproj/project.pbxproj:
5:26 PM Changeset in webkit [16067] by thatcher
  • 2 edits
    3 adds in trunk

Reviewed by Anders.

Drosera will be built when you type make.

  • Drosera/Makefile: Added.
  • Makefile: Added.
  • Makefile.shared: Added.
4:12 PM Changeset in webkit [16066] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

Fix crash in LayoutTests/css1/font_properties/font.html,
by implementing FontData::smallCapsFontData.

  • platform/qt/FontDataQt.cpp: (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData):
3:57 PM Changeset in webkit [16065] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Plugged a leak in StringImpl::replace()

  • platform/StringImpl.cpp: (WebCore::StringImpl::replace):
3:29 PM Changeset in webkit [16064] by andersca
  • 5 edits in trunk/WebCore

2006-08-27 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Remove most annoying notImplemented() usages and
implement some missing ScrollViewQt functions.
Much nicer output when invoking run-webkit-tests.

  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::saveDocumentState): (WebCore::FrameQt::restoreDocumentState): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::partClearedInBegin):
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::headerCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateContents): (WebCore::ScrollView::suppressScrollBars): (WebCore::ScrollView::setStaticBackground): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::historyContains): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (loadResourceIntoArray): (WebCore::PlugInInfoStore::supportsMIMEType):
3:18 PM Changeset in webkit [16063] by andersca
  • 1 edit in trunk/CMakeLists.txt

Forgot this too (doh!)

3:07 PM Changeset in webkit [16062] by andersca
  • 1 edit in trunk/WebKitTools/Scripts/install-win-extras

Didn't mean to commit this!

3:03 PM Changeset in webkit [16061] by andersca
  • 1 edit
    5 adds in trunk/WebKitTools

2006-08-27 Anders Carlsson <​acarlsson@apple.com>

Forgot to add these.


  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added. (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
  • DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added. (main):
2:53 PM Changeset in webkit [16060] by andersca
  • 5 edits in trunk/WebKitTools

2006-08-27 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric, landed by Anders.

Add DumpRenderTree support for Qt/Linux.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added. (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
  • DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added. (main):
  • Scripts/build-dumprendertree:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
2:47 PM Changeset in webkit [16059] by andersca
  • 2 edits in trunk/WebCore

2006-08-27 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Fix Qt build (add SVGMetaDataElement.cpp to build system)

  • CMakeLists.txt:
2:40 PM Changeset in webkit [16058] by eseidel
  • 5 edits
    2 deletes in trunk/WebCore

2006-08-27 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

No logic changes. Just cleanup.

  • ksvg2/svg/SVGAngle.cpp: (SVGAngle::SVGAngle): (SVGAngle::unitType): (SVGAngle::valueAsString): (SVGAngle::newValueSpecifiedUnits): (SVGAngle::convertToSpecifiedUnits):
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::unitType): (WebCore::SVGLength::newValueSpecifiedUnits): (WebCore::SVGLength::convertToSpecifiedUnits): (WebCore::SVGLength::updateValue): (WebCore::SVGLength::updateValueInSpecifiedUnits):
  • ksvg2/svg/SVGLength.h:
  • platform/BitmapImage.cpp: Removed.
  • platform/BitmapImage.h: Removed.
2:30 PM Changeset in webkit [16057] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

God, that ChangeLog entry was bad...

2:28 PM Changeset in webkit [16056] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Anders

-Changed all of the commonly used queries to keep around pre-prepared statements and bind
their arguments instead of constructing a messy.
-Changed some code in pruneUnretainedIconsOnStartup regarding transactions

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Initializers (WebCore::IconDatabase::close): Wipe all the preprepared statements (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Better handling of transactions (WebCore::readySQLStatement): Make sure a preprepared statement is ready to go for a fooQuery() (WebCore::IconDatabase::pageURLTableIsEmptyQuery): Added a comment (WebCore::IconDatabase::imageDataForIconURLQuery): Use preprepared statement + binding (WebCore::IconDatabase::timeStampForIconURLQuery): ditto (WebCore::IconDatabase::iconURLForPageURLQuery): ditto (WebCore::IconDatabase::forgetPageURLQuery): ditto (WebCore::IconDatabase::setIconIDForPageURLQuery): ditto (WebCore::IconDatabase::getIconIDForIconURLQuery): ditto (WebCore::IconDatabase::addIconForIconURLQuery): ditto (WebCore::IconDatabase::hasIconForIconURLQuery): ditto
  • loader/icon/IconDatabase.h: Added fooQuery() and *m_fooStatements
  • loader/icon/SQLStatement.h: (WebCore::SQLStatement::database): Added
12:27 PM Changeset in webkit [16055] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fix switch logic.

3:47 AM Changeset in webkit [16054] by rwlbuis
  • 58 edits
    6 deletes in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10557
KCanvasPath should be replace by platform/Path

Refactoring out the KCanvasPath class.

12:09 AM Changeset in webkit [16053] by eseidel
  • 7 edits
    4 adds in trunk

2006-08-26 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.

pointer-events attribute does not work.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10415

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::pointerEventsHitRules): new function to contain pointer-events hit logic (WebCore::RenderPath::nodeAtPoint): respect pointer-events property
  • kcanvas/RenderPath.h: (WebCore::RenderPath::PointerEventsHitRules::PointerEventsHitRules):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
  • ksvg2/svg/SVGPaint.cpp: Fix this to use a real enum value (WebCore::SVGPaint::SVGPaint): (WebCore::SVGPaint::paintType): (WebCore::SVGPaint::uri): (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::setPaint):
  • ksvg2/svg/SVGPaint.h:
Note: See TracTimeline for information about the timeline view.