⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 30, 2006:

11:22 PM Changeset in webkit [16138] by beidson
  • 2 edits in trunk/WebCore

Reviewed by "common sense" (and Maciej)

Fixed two logging typos

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncDatabase):
7:09 PM Changeset in webkit [16137] by adele
  • 2 edits in trunk/WebCore

Adding missing nil check for focus node.

  • page/Frame.cpp: (WebCore::Frame::setIsActive):
6:50 PM Changeset in webkit [16136] by adele
  • 14 edits in trunk

WebCore:

Reviewed by Hyatt.

WebCore part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields

  • WebCore.exp: Added wkSetSecureEventInput and wkSecureEventInput.
  • platform/mac/WebCoreSystemInterface.h: ditto.
  • platform/mac/WebCoreSystemInterface.mm: ditto.
  • page/Frame.cpp: (WebCore::Frame::setIsActive): Enables and disables secure keyboard entry based on whether the frame becomes active.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Added. Calls wkSetSecureEventInput. (WebCore::FrameMac::secureKeyboardEntry): Added. Calls wkSecureEventInput.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): For password fields, enable secure keyboard entry. (WebCore::HTMLInputElement::dispatchBlurEvent): For password fields, disable secure keyboard entry.
  • page/Frame.h: (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::secureKeyboardEntry):

WebKit:

Reviewed by Hyatt.

WebKit part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Hyatt.

Updated for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields

  • WebKitSystemInterface.h: Added WKSetSecureEventInput and WKSecureEventInput;
  • libWebKitSystemInterface.a:
6:15 PM Changeset in webkit [16135] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebIconDatabaseBridge.m

Build fix.

5:20 PM Changeset in webkit [16134] by darin
  • 15 edits
    1 add in trunk/WebCore

Reviewed by Tim Hatcher.

  • eliminated the need for UsesPassRefPtr in IDL files
  • got rid of the category mechanism for ObjC generated DOM headers (after discussions with Tim H where we decided it's not needed)
  • simplified use of macro inside ObjC generated code
  • ForwardingHeaders/wtf/GetPtr.h: Added.
  • bindings/scripts/CodeGeneratorObjC.pm: Removed code to handle categories. Eliminated use of DOM_cast since that's for the protection of human programmers -- the script won't make mistakes that it needs to catch. Changed macro to always be named IMPL instead of incorporating the class name. Use WTF::getPtr to extract the pointer, and removed the code that uses .get() to extract the pointer in the PassRefPtr case.
  • dom/Attr.idl: Removed all uses of UsesPassRefPtr and ObjCCatagory.
  • dom/DOMImplementation.idl: Ditto.
  • dom/Document.idl: Ditto.
  • dom/Element.idl: Ditto.
  • dom/NamedNodeMap.idl: Ditto.
  • html/HTMLDocument.idl: Ditto.
  • html/HTMLElement.idl: Ditto.
  • html/HTMLFormElement.idl: Ditto.
  • html/HTMLMapElement.idl: Ditto.
  • html/HTMLSelectElement.idl: Ditto.
  • html/HTMLTableElement.idl: Ditto.
  • html/HTMLTableRowElement.idl: Ditto.
  • html/HTMLTableSectionElement.idl: Ditto.
5:12 PM Changeset in webkit [16133] by darin
  • 7 edits
    1 add in trunk/JavaScriptCore

Reviewed by Tim Hatcher.

  • add WTF::getPtr, a function template that makes it possible to write generic code that gets a raw pointer out of any of our pointer types
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/GetPtr.h: Added.
  • wtf/ListRefPtr.h: (WTF::getPtr): Added.
  • wtf/OwnArrayPtr.h: (WTF::getPtr): Added.
  • wtf/OwnPtr.h: (WTF::getPtr): Added.
  • wtf/PassRefPtr.h: (WTF::getPtr): Added.
  • wtf/RefPtr.h: (WTF::getPtr): Added.
4:32 PM Changeset in webkit [16132] by beidson
  • 7 edits in trunk

WebCore:

Reviewed by John

<rdar://problem/4707718> - Instead of faking the user out with an in-memory icon database if their
~/Library/Safari/Icons is unwritable, we'll actually fail to open the icon database and the app will
run as if it was disabled via a preference.
Also took the opportunity to change some ASSERTS() to reasonable behavior

  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]): NSLog on failure so the user has a chance to figure out there's a problem. (-[WebCoreIconDatabaseBridge closeSharedDatabase]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): From here on, just replaced ASSERTS() with reasonable behavior (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]): (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): If we fail to open, return false (WebCore::IconDatabase::~IconDatabase): cleanup better
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John

<rdar://problem/4707718> Change behavior so if the WebCore::IconDatabase can't open, WebKit releases the bridge and
continues on as if the IconDatabase is disabled.


  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Release the bridge on failure to open
  • WebCoreSupport/WebIconDatabaseBridge.m: (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved static shared instance out as a global (-[WebIconDatabaseBridge dealloc]): Clear pointer to the shared instance
4:27 PM Changeset in webkit [16131] by thatcher
  • 2 edits
    1 add in trunk/WebKit

Reviewed by Darin.

Simplify the header copies from WebCore and JavaScriptCore.
Headers that need to be migrated from the other projects need
to be added to MigrateHeaders.make.

  • MigrateHeaders.make: Added.
  • WebKit.xcodeproj/project.pbxproj:
3:09 PM Changeset in webkit [16130] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4708007> REGRESSION: text field inside a webpage no longer has settable AXValueAttribute
<rdar://problem/4707479> REGRESSION: controls inside a webpage no longer have settable AXFocusedAttribute

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject canSetFocusAttribute]): (-[WebCoreAXObject canSetValueAttribute]): New utility methods. Text fields and buttons are focusable. Text fields can have their value set. We need not make popupbutton value settable because AppKit does not.


(-[WebCoreAXObject accessibilityIsAttributeSettable:]):
Call new utility methods.


(-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
Set focus for text field or button.
Set value for text field.

2:46 PM Changeset in webkit [16129] by hyatt
  • 6 edits in trunk/WebCore

Fix for bugs 9000 and 10606. Add code to suppress painting when
a FOUC situation would otherwise occur. There will still typically be
a flash to white, but at least the wrong content won't show.

Reviewed by darin

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::preferredStylesheetSet): (WebCore::Document::selectedStylesheetSet): (WebCore::Document::setSelectedStylesheetSet): (WebCore::Document::stylesheetLoaded): (WebCore::Document::updateStyleSelector):
  • dom/Document.h: (WebCore::Document::haveStylesheetsLoaded):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::isSubframe): (WebCore::RenderLayer::hitTest):
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):
2:19 PM Changeset in webkit [16128] by weinig
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Fix build for Drosera.

2:12 PM Changeset in webkit [16127] by spadma
  • 17 edits in S60/trunk/WebKit

2006-08-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Requests that are not handled by ResolveLinkL or ResolveEmbeddedLinkL need a status
returned from BufferLoader's RequestL method. The following methods are modified to return
a status code: QueueTransaction, SubmitTransaction, DoSubmitTransaction, SubmitTransaction, DoSubmit.
If the return type is not KErrNone (which can only happen in the case of a BufferTransaction) try
to request the transaction from another transaction type.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10605

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/AboutTransaction.h:
  • ResourceLoader/inc/BaseTransaction.h:
  • ResourceLoader/inc/BufferTransaction.h:
  • ResourceLoader/inc/DataTransaction.h:
  • ResourceLoader/inc/FileTransaction.h:
  • ResourceLoader/inc/HttpTransaction.h: (CHttpTransaction::SetIsRedirected): (CHttpTransaction::IsRedirected):
  • ResourceLoader/inc/UrlLoader.h:
  • ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
  • ResourceLoader/src/BaseTransaction.cpp: (CBaseTransaction::BaseConstructL): (CBaseTransaction::SubmitTransaction):
  • ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::SubmitTransaction): (CBufferTransaction::DoSubmitL): (CBufferTransaction::HandleClientDataChunkL):
  • ResourceLoader/src/DataTransaction.cpp: (CDataTransaction::DoSubmitL): (CDataTransaction::CreateHeaderResponseLC):
  • ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::DoSubmitL): (CFileTransaction::CreateHeaderResponseLC): (CFileTransaction::MHFRunL): (CFileTransaction::ParseFileNameLC): (CFileTransaction::ContentEncoding):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::DoSubmitL):
  • ResourceLoader/src/RequestDispatcher.cpp: (CRequestDispatcher::DispatchL):
  • ResourceLoader/src/UrlLoader.cpp: (CUrlLoader::RequestL): (CUrlLoader::QueueTransaction): (CUrlLoader::SubmitNextTransaction): (CUrlLoader::DoSubmitTransaction):
1:47 PM Changeset in webkit [16126] by rwlbuis
  • 4 edits in trunk/WebCore

2006-08-31 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric. Landed by rwlbuis.

Apply Rob's fixes in RenderPathQt too -> unbreak build.

1:36 PM Changeset in webkit [16125] by weinig
  • 12 edits
    2 adds in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMHTMLBaseElement, DOMHTMLBodyElement, DOMHTMLHeadElement,
DOMHTMLHtmlElement, DOMHTMLIsIndexElement, DOMHTMLLinkElement,
DOMHTMLMetaElement, DOMHTMLStyleElement and DOMHTMLTitleElement.

Splits DOMHTMLDocument into it's own files.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLDocument.h: Added.
  • bindings/objc/DOMHTMLDocument.mm: Added. (-[DOMHTMLDocument WebCore::]): (-[DOMHTMLDocument title]): (-[DOMHTMLDocument setTitle:]): (-[DOMHTMLDocument referrer]): (-[DOMHTMLDocument domain]): (-[DOMHTMLDocument URL]): (-[DOMHTMLDocument body]): (-[DOMHTMLDocument setBody:]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]): (-[DOMHTMLDocument cookie]): (-[DOMHTMLDocument setCookie:]): (-[DOMHTMLDocument open]): (-[DOMHTMLDocument close]): (-[DOMHTMLDocument write:]): (-[DOMHTMLDocument writeln:]): (-[DOMHTMLDocument getElementById:]): (-[DOMHTMLDocument getElementsByName:]): (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): (-[DOMHTMLDocument createDocumentFragmentWithText:]):
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLDocument.idl:

WebKit:

Reviewed by Tim H.

  • WebKit.xcodeproj/project.pbxproj:
1:24 PM Changeset in webkit [16124] by eseidel
  • 3 edits in trunk/WebCore

2006-08-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel.

Use QColor <-> Color conversion operator, instead of faking it.

  • platform/qt/FontQt.cpp: (WebCore::Font::drawGlyphs):
  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):
1:20 PM Changeset in webkit [16123] by rwlbuis
  • 9 edits in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10586
pointer-events has issues when things are not stroked/filled

Add a param to fillContains/strokeContains to indicate
whether we still want hit testing when there is no fill/stroke.

1:00 PM Changeset in webkit [16122] by justing
  • 15 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4700297>
REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line


Fixed:

  • editing/pasteboard/smart-paste-002-expected.checksum:
  • editing/pasteboard/smart-paste-002-expected.png:
  • editing/pasteboard/smart-paste-002-expected.txt: Added to demonstrate fix:
  • editing/pasteboard/4700297-expected.checksum: Added.
  • editing/pasteboard/4700297-expected.png: Added.
  • editing/pasteboard/4700297-expected.txt: Added.
  • editing/pasteboard/4700297.html: Added. Removed a superfluous style span:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt: Accidently checked in bad results yesterday:
  • editing/pasteboard/copy-paste-bidi-expected.txt: Equivalent render tree:
  • editing/pasteboard/smart-paste-001-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4700297>
REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Rebalance whitespace around insertionPos before insertion because the content might cause a collapse, e.g. inserting <div>foo</div> at hello world.
  • editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode): Rebalance with all nbsps for simplicity, we can produce sequences of regular spaces and nbsps on serialization (10636).
12:37 PM Changeset in webkit [16121] by eseidel
  • 3 edits in trunk/WebCore

2006-08-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel.

The old solution was slow & does not work correctly.
Move the QString -> DeprecatedString conversion into
DeprectedString.cpp, to be able to access allocateHandle().

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::DeprecatedString):
  • platform/qt/StringQt.cpp:
12:16 PM Changeset in webkit [16120] by aroben
  • 2 edits in trunk/WebCore

Reviewed/landed by Adam.

Implement containsCharacters() / determinePitch() functions.

  • platform/qt/FontDataQt.cpp: (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch):
11:58 AM Changeset in webkit [16119] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Darin's rubberstamp

We apparently have a fancy delateAllValues() helper for HashMap/Sets - I'll use that instead

  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::removeAllIcons):
11:48 AM Changeset in webkit [16118] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by ggaren.

  • Verification of exceptions thrown in a plugin. Test for bug 10114.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ObjCPlugin.m: (+[ObjCPlugin isSelectorExcludedFromWebScript:]): (+[ObjCPlugin webScriptNameForSelector:]): (-[ObjCPlugin throwIfArgumentIsNotHello:]):
11:45 AM Changeset in webkit [16117] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed, tweaked by ggaren.


  • kjs/ExecState.cpp: (KJS::ExecState::ExecState):
  • kjs/ExecState.h:
  • kjs/context.h: (KJS::Context::setExecState): (KJS::Context::execState):

LayoutTests:

Reviewed by ggaren.

WebCore:

Reviewed, tweaked by ggaren.


11:32 AM Changeset in webkit [16116] by adele
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

  • page/Frame.cpp: (WebCore::Frame::mayCopy): Added. Checks to see if the selection is within a password field.
  • page/Frame.h: Added mayCopy.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMouseMoveEvent): Checks mayCopy before starting a drag. (WebCore::FrameMac::mayDHTMLCut): Renamed to match the bridge method. This also checks mayCopy now. (WebCore::FrameMac::mayDHTMLCopy): ditto. (WebCore::FrameMac::tryDHTMLCut): ditto. (WebCore::FrameMac::tryDHTMLCopy): ditto. (WebCore::FrameMac::mayDHTMLPaste): Renamed to match the bridge function. (WebCore::FrameMac::tryDHTMLPaste): ditto.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge mayCopy]): Calls the renamed method on frame. (-[WebCoreFrameBridge mayDHTMLCut]): ditto. (-[WebCoreFrameBridge mayDHTMLCopy]): ditto. (-[WebCoreFrameBridge mayDHTMLPaste]): ditto. (-[WebCoreFrameBridge tryDHTMLCut]): ditto. (-[WebCoreFrameBridge tryDHTMLCopy]): ditto. (-[WebCoreFrameBridge tryDHTMLPaste]): ditto.
  • css/html4.css: Added !important to the -webkit-text-security property for password fields.

WebKit:

Reviewed by Darin.

WebKit part of fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
Disallow copy from new password fields

  • WebView/WebHTMLView.m: (-[WebHTMLView _canCopy]): Now also calls across the bridge to ask if it mayCopy. (-[WebHTMLView _canCut]): Calls _canCopy now. (-[NSArray validateUserInterfaceItem:]): Calls _canCut when validating the "Cut" menu item. This used to call _canDelete (which used to be the same as _canCut), but now _canCut also checks _canCopy.
11:29 AM Changeset in webkit [16115] by thatcher
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.

  • CMakeLists.txt: Install wtf-unity library.
  • wtf/Platform.h: Add define for the KDE platform.

WebCore:

Reviewed by Tim H.

Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.

  • CMakeLists.txt: Move global variables up to trunk/CMakeLists.txt.

Also rename USE_WEBKIT_SVG_SUPPORT to WEBKIT_USE_SVG_SUPPORT.

WebKitTools:

Reviewed by Tim H.

Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Add ksvg2/ includes.
  • QtLauncher/CMakeLists.txt: Add ksvg2/ includes.
11:24 AM Changeset in webkit [16114] by thatcher
  • 3 edits in trunk/WebCore

Rubber-stamped by Brady.

Fix for the generated headers to make the build work
during "installhdrs" builds. Also export DOM headers
using the #import <WebCore/DOM*.h> syntax.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:
11:15 AM Changeset in webkit [16113] by brmorris
  • 1 copy in S60/branches/s60-RnD-06wk35

Branching for release S60 RnD release 2006w35

9:50 AM Changeset in webkit [16112] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Eric and Tim H.

Bug 10634: -webView:dragDestinationActionMaskForDraggingInfo: is ignored
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10634


Remove the check for canShowFile: from _web_bestURL: since
it shouldn't be concerned with whether or not the view
can show the URL, merely return the most appropriate URL.

  • Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • Misc/WebNSViewExtras.m: (-[NSView _web_dragOperationForDraggingInfo:]):
1:11 AM Changeset in webkit [16111] by beidson
  • 9 edits in trunk

WebCore:

Reviewed by Kevin Decker (Sarge)

<rdar://problem/4678414> - New IconDB needs to delete icons when asked
<rdar://problem/4707718> - If user's Icon directory is unwritable, Safari will crash at startup

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge removeAllIcons]): Added
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): If DB file is not writeable, create an in-memory DB for this session (WebCore::IconDatabase::close): Use new deleteAllPreparedStatements() (WebCore::IconDatabase::removeAllIcons): Actually implemented (WebCore::IconDatabase::deleteAllPreparedStatements): Added for convinience/consistency (WebCore::IconDatabase::setPrivateBrowsingEnabled): Use new SQLDatabase::clearAllTables()
  • loader/icon/IconDatabase.h:
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::clearAllTables): Moved this from IconDatabase as it actually belongs here (WebCore::SQLDatabase::vacuum): Added
  • loader/icon/SQLDatabase.h: (WebCore::SQLDatabase::path): changed name from getPath()

WebKit:

Reviewed by Kevin Decker (Sarge)

<rdar://problem/4678414> - New IconDB needs to delete icons when asked

  • Misc/WebIconDatabase.m: (-[WebIconDatabase removeAllIcons]): Call through to WebCore to remove icons, then send notification

Aug 29, 2006:

10:07 PM Changeset in webkit [16110] by beidson
  • 7 edits in trunk

WebCore:

Reviewed by Alice

Added a truth value to setIconURLForPageURL so WebKit can avoid sending a notification
This is a win on the iBench

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconURLForPageURL):
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by Alice

Added a truth value check for to setIconURL:forURL so WebKit can avoid sending a notification
This is a win on the iBench

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
9:59 PM Changeset in webkit [16109] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Fixed <rdar://problem/4702021> REGRESSION: WebClip and Weather widgets shift downward vertically on screen after I drag them out from dashboard configure bar

  • platform/mac/ScreenMac.mm: (WebCore::flipScreenRect): reverted the one line in this method back to what it was before r15765. This changed caused window.screenY to be incorrect.
5:48 PM Changeset in webkit [16108] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • test for <rdar://problem/4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)
  • fast/css/computed-style-negative-top-expected.txt: Added.
  • fast/css/computed-style-negative-top.html: Added.

WebCore:

Reviewed by Hyatt.

  • fix <rdar://problem/4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)

The bug was that we would return "none" for computed style properties when they were
exactly "-1px".

Test: fast/css/computed-style-negative-top.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForLength): Moved special case for "undefined length" out of here. (WebCore::valueForMaxLength): Moved it into here. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Use valueForMaxLength only for max-height and max-width.
4:35 PM Changeset in webkit [16107] by eseidel
  • 2 edits in trunk/WebCore

2006-08-29 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel.

Add path-related SVG JavaScript bindings to generation.

  • CMakeLists.txt:
4:19 PM Changeset in webkit [16106] by eseidel
  • 8 edits
    9 copies
    14 moves in trunk/WebCore

2006-08-29 Eric Seidel <​eric@eseidel.com>

Reviewed by kevin.

Re-enable path-related SVG JavaScript bindings.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10623
Split all SVGPathSeg*.idl files into Abs and Rel pieces.
Move all SVGPath*.idl files into ksvg2/svg

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm: Special case Abs and Rel header includes
  • ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathElement.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSeg.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegList.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Removed.
  • ksvg2/ksvg.h: move SVGPathSegment enum
  • ksvg2/svg/SVGPathElement.cpp: move SVGPathSegment enum (WebCore::SVGPathElement::toPathData):
  • ksvg2/svg/SVGPathSeg.cpp: (WebCore::SVGPathSeg::SVGPathSeg):
  • ksvg2/svg/SVGPathSeg.h: (WebCore::SVGPathSeg::):
  • ksvg2/svg/SVGPathSegArcAbs.idl: Added.
  • ksvg2/svg/SVGPathSegArcRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoAbs.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoRel.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoVerticalRel.idl: Added.
  • ksvg2/svg/SVGPathSegMovetoAbs.idl: Added.
  • ksvg2/svg/SVGPathSegMovetoRel.idl: Added.
4:13 PM Changeset in webkit [16105] by andersca
  • 1 edit in trunk/CMakeLists.txt

Forgot this

3:52 PM Changeset in webkit [16104] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/gdb-safari: Set DYLD_FRAMEWORK_PATH inside gdb instead of setting it in gdb's environment to work around what seems to be a bug in some versions of gdb.
3:49 PM Changeset in webkit [16103] by andersca
  • 7 edits
    1 add
    1 delete in trunk/WebCore

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric, landed by Anders.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

Finish Unity merging. Remove libcurl usage, in favour of KIO.
This makes the regression testing fly! IO processing is way faster now.

  • CMakeLists.txt:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::createEmptyDocument): (WebCore::FrameQt::receivedData): (WebCore::FrameQt::receivedAllData):
  • platform/qt/FrameQt.h:
  • platform/qt/ResourceLoaderCurl.cpp: Removed.
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::~ResourceLoaderManager): (WebCore::ResourceLoaderManager::self): (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::slotResult): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add):
  • platform/qt/ResourceLoaderManager.h:
  • platform/qt/ResourceLoaderQt.cpp: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::receivedResponse):
3:37 PM Changeset in webkit [16102] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatchers rubber stamp

Removed some accidentally left-in console spew during the conversion to the new DB


  • Misc/WebIconDatabase.m: (objectFromPathForKey): Nuked some NSLogs
3:24 PM Changeset in webkit [22131] by sfalken
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build

3:14 PM Changeset in webkit [16101] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4688618> REGRESSION(10.4.7-9A241): JMol java applet fails in Safari not Firefox

No layout test for now because Java doesn't work in DumpRenderTree.

  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Add each plug-in MIME type to registeredMIMETypes, even if we don't register a document view class for the MIME type. This fixes -[WebPluginDatabase isMIMETypeRegistered:] and thus fallback content for Java applets (we were always rendering fallback content, if any, for Java applets).
2:58 PM Changeset in webkit [16100] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Bug 10632: Objective-C DOM should use the @property syntax for DOM attributes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10632

Generate @property when MACOSX_DEPLOYMENT_TARGET is >= 10.5.
This is backwards compatible with the getter/setter methods.
Generate setter arguments with a "new" prefix to avoid the property
name conflict warning. Also removes some whitespace and the comments
that we added to the headers. This makes the headers look like what we ship now.

  • bindings/objc/DOMCSS.mm: (-[DOMDocument getComputedStyle::]): renamed a local variable to avoid the property name conflict. (-[DOMDocument getMatchedCSSRules::]): ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: generate @property in the headers.
2:57 PM Changeset in webkit [22130] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Land remaining CG integration patch.

2:40 PM Changeset in webkit [16099] by andersca
  • 2 edits in trunk/WebCore

2006-08-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Fix time calculation, by using a correct calculation. Calling time()
returns a number of seconds, aka. an integer. Fix it by using gettimeofday().
Patch originally proposed by Ronan Meneu <​rmeneu@origyn.fr>

  • platform/qt/SystemTimeQt.cpp: (WebCore::currentTime):
1:43 PM Changeset in webkit [22129] by hyatt
  • 5 edits
    11 adds in branches/WindowsMerge/WebCore

This patch lands all the font changes. It does not patch the project file
yet, since this was done on Mac. Will switch to Win32 after landing this
and then fix any glitches.

  • platform/cairo/cairo-all.c: Added.
  • platform/cairo/pixman-all.c: Added.
  • platform/image-decoders/jpeg/jpeg-part1.c: Added.
  • platform/image-decoders/jpeg/jpeg-part2.c: Added.
  • platform/image-decoders/jpeg/jpeg-part3.c: Added.
  • platform/image-decoders/png/png-part1.c: Added.
  • platform/image-decoders/png/png-part2.c: Added.
  • platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::platformWidthForGlyph):
  • platform/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::cgFont): (WebCore::FontPlatformData::operator==):
  • platform/win/FontPlatformDataWin.cpp: (WebCore::m_size):
  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
1:33 PM Changeset in webkit [16098] by weinig
  • 29 edits
    12 adds in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
and DOMHTMLOptionsCollection, and lays groundwork for the rest of the
HTML DOM bindings by adding/fixing the appropriate IDL's and updating
the CodeGeneratorObjC.pm build script.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCollection.idl: Added.
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl: Added.
  • html/HTMLFrameSetElement.idl: Added.
  • html/HTMLIFrameElement.idl: Added.
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLObjectElement.idl: Added.
  • html/HTMLOptionsCollection.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLSelectElement.idl: Added.
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl: Added.
  • html/HTMLTableCellElement.idl: Added.
  • html/HTMLTableColElement.idl: Added.
  • html/HTMLTableElement.idl: Added.
  • html/HTMLTableRowElement.idl: Added.
  • html/HTMLTableSectionElement.idl: Added.
  • html/HTMLTextAreaElement.idl:

WebKit:

Reviewed by Tim H.

Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
and DOMHTMLOptionsCollection.

  • WebKit.xcodeproj/project.pbxproj:
1:05 PM Changeset in webkit [16097] by ap
  • 2 edits in trunk/WebCore

2006-08-29 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10629.
Drawing convex polygons is broken in the Qt platform.

  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon):
12:16 PM Changeset in webkit [16096] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Implementing font hashing properly, fixes weird crashes in HashMap.

  • platform/qt/FontPlatformData.h:
  • platform/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash):
12:11 PM Changeset in webkit [16095] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by ggaren.

Fix scrollbars to reappear after the first layouting.

  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::suppressScrollBars):
11:58 AM Changeset in webkit [16094] by andersca
  • 6 edits
    2 copies
    3 adds
    1 delete in trunk/WebCore

2006-08-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin and Geoff.

Move the CF String functions to separate files in platform/cf.
Also, move the files in platform/cfnet to platform/cf.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformString.h:
  • platform/StringImpl.h:
  • platform/cf/StringCF.cpp: Added. (WebCore::String::String):
  • platform/cf/StringImplCF.cpp: Added. (WebCore::StringImpl::createCFString):
  • platform/cfnet/KURLCFNet.cpp: Removed.
  • platform/cfnet/ResourceLoaderCFNet.cpp: Removed.
  • platform/mac/StringImplMac.mm:
  • platform/mac/StringMac.mm:
11:57 AM Changeset in webkit [22128] by hyatt
  • 2 edits
    4 adds in branches/WindowsMerge/WebCore

Forking the font files in preparation for dropping in CG code.

Reviewed by adam

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/FontDataWin.cpp: Added. (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch): (WebCore::FontData::platformWidthForGlyph):
  • platform/win/FontPlatformData.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/win/FontPlatformDataWin.cpp: Added. (WebCore::m_size): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/win/FontWin.cpp: Added. (WebCore::notImplemented): (WebCore::Font::drawGlyphs): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
11:56 AM Changeset in webkit [16093] by ggaren
  • 3 edits in trunk/WebCore

Rolling out a change I included by accident in my last commit.


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::passMouseDownEventToWidget):
  • platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFireTime):
10:30 AM Changeset in webkit [16092] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-29 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
Fix build warnings and export cache header file

  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
  • group/bld.inf:
10:25 AM Changeset in webkit [16091] by beidson
  • 6 edits
    4 deletes in trunk/WebKit

Reviewed by Darin

Short of a few small snippets that still need to be pushed to WebCore, this
is a final prune of WebIconDatabase. WebFileDatabase and WebLRUFileList are gone
and the small remaining snippets of WebFileDatabase code that were still important
are now in static functions in WebIconDatabase.m

  • Loader/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): Removed the flag
  • Misc/WebFileDatabase.h: Removed.
  • Misc/WebFileDatabase.m: Removed.
  • Misc/WebIconDatabase.m: (+[WebIconDatabase sharedIconDatabase]): (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (uniqueFilePathForKey): Added from WebFileDatabase (objectFromPathForKey): Added from WebFileDatabase (iconDataFromPathForIconURL): (-[WebIconDatabase _convertToWebCoreFormat]): Make use of static functions and local variables instead of using WebFileDatabase and WebIconDatabase variables that are now obsolete
  • Misc/WebIconDatabasePrivate.h: Removed alot of obsoleted members
  • Misc/WebLRUFileList.h: Removed.
  • Misc/WebLRUFileList.m: Removed.
  • WebKit.xcodeproj/project.pbxproj: Deleted 4 files
  • WebKitPrefix.h: Removed ICONDEBUG
10:07 AM Changeset in webkit [22127] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-08-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Ada.

  • WebKitDLL.cpp: (DllMain): Set the global instance handle.
8:33 AM Changeset in webkit [16090] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-28 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC: Update the minimap setting from pagescaler
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10504

  • BrowserView/src/WebKitView.cpp: (CWebKitView::InitializePageScalerL):
Note: See TracTimeline for information about the timeline view.