⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 2, 2006:

7:10 PM Changeset in webkit [16195] by weinig
  • 17 edits
    11 adds in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMCSSCharsetRule, DOMCSSFontFaceRule, DOMCSSImportRule,
DOMCSSMediaRule, DOMCSSPageRule, DOMCSSPrimitiveValue, DOMCSSRule,
DOMCSSRuleList, DOMCSSStyleDeclaration, DOMCSSStyleRule, DOMCSSStyleSheet,
DOMCSSUnknownRule, DOMCSSValue, DOMCSSValueList, DOMCounter, and DOMRect.

Splits DOMRGBColor into its own files.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCSS.mm: (+[DOMCSSStyleSheet _CSSStyleSheetWith:]): (+[DOMCSSPrimitiveValue _valueWith:]):
  • bindings/objc/DOMCSSInternal.h:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMRGBColor.h: Added.
  • bindings/objc/DOMRGBColor.mm: Added. (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSCharsetRule.idl: Added.
  • css/CSSFontFaceRule.idl: Added.
  • css/CSSImportRule.idl: Added.
  • css/CSSMediaRule.idl: Added.
  • css/CSSPageRule.idl: Added.
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl: Added.
  • css/CSSStyleSheet.idl: Added.
  • css/CSSUnknownRule.idl: Added.
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/RGBColor.idl: Added.
  • css/Rect.idl:
  • css/RectImpl.h:

WebKit:

Reviewed by Tim H.

  • MigrateHeaders.make:
12:19 PM Changeset in webkit [16194] by thatcher
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

Testcase for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

  • editing/style/table-selection-expected.checksum: Added.
  • editing/style/table-selection-expected.png: Added.
  • editing/style/table-selection-expected.txt: Added.
  • editing/style/table-selection.html: Added.

WebCore:

Reviewed by Justin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Prevent a crash by making sure that the 'beyondEnd' node is after the start node.
12:15 PM Changeset in webkit [16193] by thatcher
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

  • JavaScriptCoreSources.bkl:

WebCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

  • WebCoreSources.bkl:
  • platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::RenderPopupMenuGdk::RenderPopupMenuGdk):
  • platform/gdk/RenderPopupMenuGdk.h:
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): (WebCore::RenderThemeGdk::systemFont):
  • platform/gdk/RenderThemeGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • webcore-base.bkl:
10:25 AM Changeset in webkit [16192] by adele
  • 6 edits in trunk/WebCore

Reviewed by Anders.

Test: fast/forms/password-doubleclick-selection.html

  • editing/visible_units.cpp: (WebCore::previousBoundary): When searching for boundaries in renderers that use the textSecurity property, convert characters in strings to alpha-numeric characters (in this case, all 'x's) so that every character isn't treated as a punctuation boundary. (WebCore::nextBoundary): ditto.
  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Updated to use the renderer's string instead of the node value. This matches the base class implementation of handleTextNode.

Code cleanup.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Avoid unnecessary check for password field case if the smart replace condition is false.
  • page/Frame.cpp: (WebCore::Frame::mayCopy): Removed duplicate code. Calls isSelectionInPasswordField now.
  • rendering/RenderText.cpp: (WebCore::RenderText::setText): Updated formatting.

Sep 1, 2006:

6:43 PM Changeset in webkit [16191] by hyatt
  • 6 edits in trunk/WebCore

Fix for 10682, refine the FOUC paint suppression logic so that it
is only triggered when FOUC would really have occurred.

Reviewed by aroben

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::updateStyleSelector):
  • dom/Document.h: (WebCore::Document::haveStylesheetsLoaded): (WebCore::Document::): (WebCore::Document::didLayoutWithPendingStylesheets):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
6:10 PM Changeset in webkit [16190] by aroben
  • 11 edits in trunk

2006-09-01 MorganL <​morlmor@yahoo.com>

Reviewed by Darin. Updated/landed by Adam.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10553
Windows build fixes

5:57 PM Changeset in webkit [16189] by beidson
  • 6 edits in trunk/WebCore

Reviewed by Tim Omernick

Added an SQLDatabase logging channel. Changed all SQLDatabase and SQLStatement errors to use this new channel.
Also, as a popular request from other contributers, added a log for all prepare(), step(), finalize(), and reset()s
Also, fixed a grammar error in my previous ChangeLog entry.

  • bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): Initialize the new channel
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::setBusyTimeout): Use SQLDatabase logging channel (WebCore::SQLDatabase::setBusyHandler): ditto (WebCore::SQLDatabase::clearAllTables): ditto (WebCore::SQLDatabase::runVacuumCommand): ditto
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Added a log (WebCore::SQLStatement::step): ditto (WebCore::SQLStatement::finalize): ditto (WebCore::SQLStatement::reset): ditto (WebCore::SQLStatement::getColumnBlob): Use SQLDatabase logging channel (WebCore::SQLStatement::returnTextResults): ditto (WebCore::SQLStatement::returnTextResults16): ditto (WebCore::SQLStatement::returnIntResults): ditto (WebCore::SQLStatement::returnInt64Results): ditto (WebCore::SQLStatement::returnDoubleResults): ditto
  • platform/Logging.cpp: (WebCore::): Added new logging channel
  • platform/Logging.h: ditto
5:55 PM Changeset in webkit [16188] by adele
  • 20 edits in trunk

LayoutTests:

Reviewed by Tim Omernick.

Updated results for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6990
Switch to use new text field implementation for <input type="password">

  • dom/html/level2/html/HTMLInputElement22-expected.txt:
  • dom/xhtml/level2/html/HTMLInputElement22-expected.txt:
  • fast/events/event-sender-mouse-click.html:
  • fast/forms/input-appearance-height-expected.checksum:
  • fast/forms/input-appearance-height-expected.txt:
  • fast/forms/input-type-change-in-onfocus-mouse-expected.txt:
  • fast/forms/input-value-expected.checksum:
  • fast/forms/input-value-expected.png:
  • fast/forms/input-value-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

Updated from switch to style-able selects

  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/option-strip-whitespace-expected.txt:

WebCore:

Reviewed by Tim Omernick.

  • css/html4.css: Give input[password] the same style properties as normal text fields.
  • html/HTMLInputElement.cpp: Removed checks for TextFieldAppearance. (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::setSelectionRange): (WebCore::HTMLInputElement::createRenderer):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField):
5:03 PM Changeset in webkit [16187] by beidson
  • 8 edits in trunk/WebCore

Reviewed by John (though Sarge review a previous patch of mine in an attempt to review this one)

Added some constants for SQL Result Codes to SQLDatabase.h
This way, users of SQLDatabase can access all necessary SQLite functionality
without having access to sqlite3.h.
Also reordered some files in the xcodeproj and some #includes

  • WebCore.xcodeproj/project.pbxproj: Reordered some files
  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase): Use our new result codes
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): Use our new result codes (WebCore::IconDatabase::retainIconForPageURL): Use our new result codes (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Use our new result codes (WebCore::IconDatabase::addIconForIconURLQuery): Use our new result codes (WebCore::IconDatabase::hasIconForIconURLQuery): Use our new result codes
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::lastError): Moved from header to eliminate dependency on sqlite3.h in header (WebCore::SQLDatabase::lastErrorMsg): Ditto
  • loader/icon/SQLDatabase.h: Removed #include <sqlite3.h>
  • loader/icon/SQLStatement.cpp: Added #include <sqlite3.h>
  • loader/icon/SQLStatement.h: Removed #include <sqlite3.h>
4:53 PM Changeset in webkit [16186] by beidson
  • 1 edit in trunk/WebKit/ChangeLog

My ChangeLog grammar needs reviewing, apparently (fixed last ChangeLog)

4:20 PM Changeset in webkit [16185] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Darin

A "never should be reach" method was reached - lets not release the shared database bridge, esp
since we never retain it!

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]): Don't release the bridge
3:57 PM Changeset in webkit [16184] by hyatt
  • 4 adds in trunk/LayoutTests/fast/flexbox

Add flexbox test.

3:56 PM Changeset in webkit [16183] by hyatt
  • 2 edits in trunk/WebCore

Fix for 10680, contrained flexbox is not shrinking flexible children
properly. (Fixing in case it's hit by the file upload control.)

Reviewed by aroben

Adding 026.html to fast/flexbox.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::allowedChildFlex):
2:52 PM Changeset in webkit [16182] by eseidel
  • 4 edits in trunk/WebCore

2006-09-01 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Implement support for multiple parents in the SVG idls.

For class "FooBar" go through all parents recursively,
collect their attributes & functions & constants and
add them directly into the class "FooBar".

(Note: It is NOT enabled by default for now - still some things related to SVGAnimated* need to be solved first)

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/generate-bindings.pl:
2:50 PM Changeset in webkit [16181] by eseidel
  • 6 edits in trunk

2006-09-02 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by hyatt. Landed by eseidel.

Fix build on Linux.

  • CMakeLists.txt: Add platform/CString.cpp.
  • platform/qt/FrameQt.cpp: Correct repsondToChangedContents() signature
  • platform/qt/FrameQt.h:: Correct respondToChangedContents() signature
2:41 PM Changeset in webkit [16180] by darin
  • 9 edits in trunk

WebCore:

Reviewed by Brady.

  • a few small tweaks to the icon database bridge
  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed unnecessary declarations. Renamed sharedBridgeInstance to sharedInstance.
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Put functions inside WebCore namespace. (WebCore::IconDatabase::loadIconFromURL): Updated for sharedInstance namespace.

WebKit:

Reviewed by Brady.

  • a few small tweaks to the icon database bridge
  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Updated for name change.
  • WebCoreSupport/WebIconDatabaseBridge.h: Removed unneeded declarations.
  • WebCoreSupport/WebIconDatabaseBridge.m: (-[WebIconDatabaseBridge init]): Added. Always returns nil since you're not supposed to allocate one of these. (-[WebIconDatabaseBridge _init]): Renamed from init. Used internally to make the shared instance. Added the "self = [super init]" idiom even though it's not important in this case just to be consistent. (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]): Moved this up in the file so it can be called without declaring it in the header. (+[WebIconDatabaseBridge sharedInstance]): Renamed. Calls the new _init. Also use CFRetain for compatibility. (-[WebIconDatabaseBridge dealloc]): Emptied this out and made it just assert (false). (-[WebIconDatabaseBridge finalize]): Added and made it assert (false) too.
2:21 PM Changeset in webkit [16179] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Adele.

Bug 10677: Omit "-webkit-text-security: none;" from the computed style list
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10677

2:00 PM Changeset in webkit [22139] by sfalken
  • 5 edits in branches/WindowsMerge
1:09 PM Changeset in webkit [16178] by thatcher
  • 5 edits in trunk

LayoutTests:

Reviewed by Darin.

  • updated results, null is not round-tripped through the bindings because of regressions the original change caused in other applications.
  • added an echo for "undefined".
  • plugins/bindings-test-expected.txt:
  • plugins/bindings-test.html:

WebCore:

Reviewed by Darin.

<rdar://problem/4651318> REGRESSION: can't drag library items to widget in Dashcode
<rdar://problem/4701626> REGRESSION: Unit Converter widget doesn't work convert data in its fields

jsNull should not be returned as NSNull because existing applications do not
expect that return value. Return as nil for backwards compatibility.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
1:05 PM Changeset in webkit [16177] by ap
  • 4 edits in trunk/JavaScriptCore

2006-09-01 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fix build on Linux (C89 without gcc extensions enabled).

  • pcre/pcre_internal.h: Use C style comments.
  • wtf/Assertions.h: Use C style comments.
  • wtf/Platform.h: Use C style comments.
12:48 PM Changeset in webkit [16176] by ap
  • 2 edits in trunk/WebCore

Build fix.

  • loader/Decoder.cpp: (Decoder::Decoder): Use String::latin1().
12:36 PM Changeset in webkit [16175] by ap
  • 12 edits
    18 adds in trunk

Reviewed by Eric.

WebCore:

  • loader/Decoder.cpp: (Decoder::Decoder): Decoder now knows what kind of content it is decoding. Also, the browser default encoding can now be passed directly to the constructor, to streamline the logic. (Decoder::decode): Add support for @charset, differentiate between HTML and XML. (Decoder::setEncodingName): Style cleanup. (Decoder::encodingName): Ditto. (Decoder::flush): Ditto.
  • loader/Decoder.h: (WebCore::Decoder::):
  • bridge/mac/WebCoreEncodings.mm: Pass a content type of text/html to Decoder.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::setCharset): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h: Use Decoder instead of TextEncoding::toUnicode() to enable @charset support.
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument): Pass a content type.
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): Ditto. (WebCore::CachedXSLStyleSheet::data): Flush the decoder to be safe.
  • page/Frame.cpp: (WebCore::Frame::write): Pass a content type and a default encoding to the Decoder.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Pass the output document MIME type.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedData): Ditto.

LayoutTests:

  • fast/encoding/css-charset-expected.txt: Added.
  • fast/encoding/css-charset.css: Added.
  • fast/encoding/css-charset.html: Added.
  • fast/encoding/css-charset-evil-expected.txt: Added.
  • fast/encoding/css-charset-evil.css: Added.
  • fast/encoding/css-charset-evil.html: Added.
  • fast/encoding/default-xhtml-encoding-expected.txt: Added.
  • fast/encoding/default-xhtml-encoding.xhtml: Added.
  • fast/encoding/meta-in-xhtml-expected.txt: Added.
  • fast/encoding/meta-in-xhtml.xhtml: Added.
  • fast/encoding/pseudo-xml-2-expected.txt: Added.
  • fast/encoding/pseudo-xml-2.html: Added.
  • fast/encoding/pseudo-xml-3-expected.txt: Added.
  • fast/encoding/pseudo-xml-3.html: Added.
  • fast/encoding/pseudo-xml-4-expected.txt: Added.
  • fast/encoding/pseudo-xml-4.html: Added.
  • fast/encoding/pseudo-xml-expected.txt: Added.
  • fast/encoding/pseudo-xml.html: Added.
12:01 PM Changeset in webkit [16174] by adele
  • 5 edits in trunk/WebCore

Reviewed by John.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Enable and disable Roman keyboards when switching in and out of this mode. (WebCore::FrameMac::isSecureKeyboardEntry): Changed secureKeyboardEntry to isSecureKeyboardEntry.
  • bridge/mac/FrameMac.h: ditto.
  • page/Frame.cpp: (WebCore::Frame::setIsActive): ditto.
  • page/Frame.h: (WebCore::Frame::isSecureKeyboardEntry): ditto.
11:07 AM Changeset in webkit [22138] by adachan
  • 3 edits in branches/WindowsMerge/WebCore

2006-09-01 Ada Chan <​adachan@apple.com>

Reviewed by lamadio.

Fixed build break.

10:21 AM Changeset in webkit [16173] by adele
  • 2 edits in trunk/WebCore

Reviewed by John.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't smart replace when the selection being replaces is in a password field.
Note: See TracTimeline for information about the timeline view.