⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 3, 2006:

7:11 PM Changeset in webkit [16210] by weinig
  • 13 edits
    2 adds in trunk

WebCore:

Reviewed by Darin and Tim H.

Auto-generates DOMMediaList, DOMStyleSheet, and DOMStyleSheetList.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm: (+[DOMStyleSheet _styleSheetWith:]): (+[DOMCSSStyleSheet _CSSStyleSheetWith:]):
  • bindings/objc/DOMCSSInternal.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMObject.mm: (-[DOMObject sheet]):
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMStylesheets.h:
  • bindings/objc/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/StyleSheet.idl: Added.
  • css/StyleSheetList.idl: Added.

WebKit:

Reviewed by Darin and Tim H.

  • MigrateHeaders.make:
6:00 PM Changeset in webkit [16209] by weinig
  • 1 add in trunk/WebCore/platform/Path.cpp

Build fix.

3:19 PM Changeset in webkit [16208] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: More renaming plans.
2:46 PM Changeset in webkit [16207] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOMHTML.mm

Build fix to avoid warning about property name conflict.

2:31 PM Changeset in webkit [16206] by rwlbuis
  • 38 edits in trunk/WebCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
RenderPathQuartz and RenderPathQt should not be needed

Cleanup of code related to RenderPath.

2:20 PM Changeset in webkit [16205] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Fix a typo Darin called out, but I forgot to change.

2:11 PM Changeset in webkit [16204] by thatcher
  • 1 edit in trunk/WebCore/bindings/scripts/CodeGeneratorObjC.pm

Build fix.

1:48 PM Changeset in webkit [16203] by thatcher
  • 5 edits in trunk

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:42 PM Changeset in webkit [16202] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:38 PM Changeset in webkit [16201] by thatcher
  • 30 edits in trunk/WebCore

Reviewed by Darin.

Bug 10685: ObjC DOM should have no unnamed parameters
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10685

  • The ObjC code generation script now outputs parameter prefixes for methods that have more than 1 parameter. This prefix is simply the parameter name. Some parameter names have been changed in the IDL files to produce better prefixes. If an extended attribute of "ObjCPrefix" exists on a parameter we will use that for the prefix.
  • A backwards compatible version of the method is placed in a category with a deprecation marco for 10.5 and later. This step only happens if the IDL extended attribute "OldStyleObjC" is defined. All new functions in IDL should not get this attribute.
  • Made the $interfaceMethodSelector regex in IDLStructure.pm allow "=" so parameter extended attributes can have values.
  • Moved RemoveExcludedAttributesAndFunctions to CodeGenerator.pm so it can be shared between the two generators.


  • Removed the die when we encounter a getter that uses exceptions. Sam Weinig added support for this in an earlier change.
  • Check if $ENV{"MACOSX_DEPLOYMENT_TARGET"} is defined before we compare. This caused a perl warning when generating on other platforms.
  • The ObjC generation will not happen on platforms other than Mac OS. This is determined by the "OS" env variable Xcode sets. This check is in the DerivedSources.make.
  • Added a way to skip generation if the constructor of the specific generator returns undef. Not used yet.
  • Many cleanup tweaks in CodeGeneratorObjC.pm.
  • Removed IDL and CSS files from the project's resource copy phase, these do no need to be in WebCore's resources.
  • DerivedSources.make
  • WebCore.xcodeproj/project.pbxproj
  • bindings/scripts/CodeGenerator.pm
  • bindings/scripts/CodeGeneratorJS.pm
  • bindings/scripts/CodeGeneratorObjC.pm
  • bindings/scripts/IDLStructure.pm
  • css/CSSMediaRule.idl
  • css/CSSPrimitiveValue.idl
  • css/CSSStyleDeclaration.idl
  • css/CSSStyleSheet.idl
  • dom/CharacterData.idl
  • dom/DOMImplementation.idl
  • dom/Document.idl
  • dom/Element.idl
  • dom/KeyboardEvent.idl
  • dom/MouseEvent.idl
  • dom/MutationEvent.idl
  • dom/NamedNodeMap.idl
  • dom/UIEvent.idl
  • html/HTMLCanvasElement.idl
  • html/HTMLSelectElement.idl
  • ksvg2/bindings/idl/svg/SVGLengthList.idl
  • ksvg2/bindings/idl/svg/SVGNumberList.idl
  • ksvg2/bindings/idl/svg/SVGPointList.idl
  • ksvg2/bindings/idl/svg/SVGStringList.idl
  • ksvg2/bindings/idl/svg/SVGTextContentElement.idl
  • ksvg2/bindings/idl/svg/SVGTransformList.idl
  • ksvg2/svg/SVGSVGElement.idl
  • page/DOMWindow.idl
12:08 PM Changeset in webkit [16200] by ap
  • 11 edits in trunk

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10693
Convert JavaScript arrays to AppleScript lists

JavaScriptCore:

  • JavaScriptCore.exp: Export ArrayInstance::info and ArrayInstance::getItem().
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::getItem): Added a method to access array items from C++.

WebCore:

  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Added a case for ArrayInstance.

LayoutTests:

  • fast/AppleScript/array-expected.txt:
  • fast/AppleScript/array.html: Updated results, added a test for circular dependencies.

WebKitTools:

  • DumpRenderTree/AppleScriptController.m: (convertAEDescToObject): (-[AppleScriptController doJavaScript:]): Support printing AEDescLists.
10:28 AM Changeset in webkit [16199] by ap
  • 1 edit in trunk/LayoutTests/http/tests/incremental/slow-utf8-html.pl

http/tests/incremental/slow-utf8-html-diffs.txt
Set executable bit that was lost when re-applying the patch.

9:59 AM Changeset in webkit [16198] by ap
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10697
REGRESSION (r16175): Errors in incremental decoding of UTF-8

Tests:

  • http/tests/incremental/slow-utf8-html.pl
  • fast/encoding/charset-invalid.html
  • loader/Decoder.cpp: (Decoder::Decoder): Ensure that we have a valid encoding. Get its name via TextEncoding, to match the logic in setEncodingName(). (Decoder::setEncodingName): Only set m_encodingName if the encoding is valid. Rely on TextEncoding constructor to lowercase it if necessary. (Decoder::decode): Use setEncodingName() to apply encoding from BOM. Don't try to ensure the validity of encoding - it is enforced by class constructor and setEncodingName().
6:45 AM Changeset in webkit [16197] by weinig
  • 1 edit in trunk/WebCore/bindings/objc/DOMRGBColor.h

Fixes build for regression tests.

2:25 AM Changeset in webkit [16196] by ap
  • 4 edits
    2 moves
    1 add
    2 deletes in trunk/LayoutTests

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4508
Layout tests access an external server

  • fast/backgrounds/repeat/noRepeatCorrectClip.html: Use a local resource (it was already present, but the test still pointed to a remote one).
  • fast/dom/HTMLImageElement/image-src-absolute-url-expected.txt:
  • fast/dom/HTMLImageElement/image-src-absolute-url.html: Use a non-existent file URL instead of a non-existent http one.
  • fast/loader/docLoaderFrame-expected.checksum: Removed.
  • fast/loader/docLoaderFrame-expected.png: Removed.
  • fast/loader/docLoaderFrame-expected.txt: Removed.
  • fast/loader/docLoaderFrame.html: Removed.
  • http/tests/xmlhttprequest/docLoaderFrame-expected.txt: Added.
  • http/tests/xmlhttprequest/docLoaderFrame.html: Added.
  • http/tests/xmlhttprequest/resources/docLoaderFrame-data.html: Added. Use a local resource. Also, turned the test into a text one, and used waitUntilDone to make it actually work.

Sep 2, 2006:

7:10 PM Changeset in webkit [16195] by weinig
  • 17 edits
    11 adds in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMCSSCharsetRule, DOMCSSFontFaceRule, DOMCSSImportRule,
DOMCSSMediaRule, DOMCSSPageRule, DOMCSSPrimitiveValue, DOMCSSRule,
DOMCSSRuleList, DOMCSSStyleDeclaration, DOMCSSStyleRule, DOMCSSStyleSheet,
DOMCSSUnknownRule, DOMCSSValue, DOMCSSValueList, DOMCounter, and DOMRect.

Splits DOMRGBColor into its own files.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCSS.mm: (+[DOMCSSStyleSheet _CSSStyleSheetWith:]): (+[DOMCSSPrimitiveValue _valueWith:]):
  • bindings/objc/DOMCSSInternal.h:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMRGBColor.h: Added.
  • bindings/objc/DOMRGBColor.mm: Added. (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSCharsetRule.idl: Added.
  • css/CSSFontFaceRule.idl: Added.
  • css/CSSImportRule.idl: Added.
  • css/CSSMediaRule.idl: Added.
  • css/CSSPageRule.idl: Added.
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl: Added.
  • css/CSSStyleSheet.idl: Added.
  • css/CSSUnknownRule.idl: Added.
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/RGBColor.idl: Added.
  • css/Rect.idl:
  • css/RectImpl.h:

WebKit:

Reviewed by Tim H.

  • MigrateHeaders.make:
12:19 PM Changeset in webkit [16194] by thatcher
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

Testcase for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

  • editing/style/table-selection-expected.checksum: Added.
  • editing/style/table-selection-expected.png: Added.
  • editing/style/table-selection-expected.txt: Added.
  • editing/style/table-selection.html: Added.

WebCore:

Reviewed by Justin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Prevent a crash by making sure that the 'beyondEnd' node is after the start node.
12:15 PM Changeset in webkit [16193] by thatcher
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

  • JavaScriptCoreSources.bkl:

WebCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

  • WebCoreSources.bkl:
  • platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::RenderPopupMenuGdk::RenderPopupMenuGdk):
  • platform/gdk/RenderPopupMenuGdk.h:
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): (WebCore::RenderThemeGdk::systemFont):
  • platform/gdk/RenderThemeGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • webcore-base.bkl:
10:25 AM Changeset in webkit [16192] by adele
  • 6 edits in trunk/WebCore

Reviewed by Anders.

Test: fast/forms/password-doubleclick-selection.html

  • editing/visible_units.cpp: (WebCore::previousBoundary): When searching for boundaries in renderers that use the textSecurity property, convert characters in strings to alpha-numeric characters (in this case, all 'x's) so that every character isn't treated as a punctuation boundary. (WebCore::nextBoundary): ditto.
  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Updated to use the renderer's string instead of the node value. This matches the base class implementation of handleTextNode.

Code cleanup.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Avoid unnecessary check for password field case if the smart replace condition is false.
  • page/Frame.cpp: (WebCore::Frame::mayCopy): Removed duplicate code. Calls isSelectionInPasswordField now.
  • rendering/RenderText.cpp: (WebCore::RenderText::setText): Updated formatting.
Note: See TracTimeline for information about the timeline view.