⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 4, 2006:

10:05 PM Changeset in webkit [16226] by ap
  • 9 edits in trunk

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10716
XMLHttpRequest.responseText is null if HTTP response is empty

Extended existing tests:

  • http/tests/xmlhttrequest/zero-length-response.html
  • http/tests/xmlhttrequest/zero-length-response-sync.html
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): Initialize responseText to an empty string. (WebCore::XMLHttpRequest::open): Reset responseText to an empty string.
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Return null rather than undefined for nil responseXML.
7:45 PM Changeset in webkit [16225] by thatcher
  • 27 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10714


  • New PublicDOMInterfaces.h file is consulted when generating the ObjC DOM files. All public DOM class interfaces, properties and methods need to be in this file. Anything not in the file will be generated into the appropriate private header file. During generation if something changed or is missing in the public API a build error will occur. New interfaces added to the IDLs files will now not automatically be reflected in the public ObjC API. Methods commented out in PublicDOMInterfaces.h are pending public and will be uncommented once approved.
  • Removed most of the Exclude=ObjC uses from the IDL files. This attribute was mostly used to prevent changes to the public headers.
  • Make a new parameter name if the original conflicts with a property name.
  • Simplified the generation code for dealing with exceptions.
  • Moved file opens to WriteData. Files are unlinked before being opened to work around a Leopard file truncation bug.
  • Fixed #imports for DOMImplementation to be DOMDOMImplementation.h
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h: Added.
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • dom/ProcessingInstruction.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTextAreaElement.idl:

WebKit:

Reviewed by Darin.

Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10714

  • Added the new private DOM headers.
  • Factored out the common commands into variables.
  • Made WebDashboardRegion.h private again.
  • Rename DOMDOMImplementation.h to DOMImplementation.h when files are migrated. Also fixes up #imports.
  • MigrateHeaders.make:
4:36 PM Changeset in webkit [16224] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: More renaming plans.
4:16 PM Changeset in webkit [16223] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Another build fix now that the old style ObjC methods are deprecated.

4:10 PM Changeset in webkit [16222] by thatcher
  • 7 edits in trunk

Build fixes now that the old style ObjC methods are deprecated.

3:57 PM Changeset in webkit [16221] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

Continue fixing the build, I forgot this in my previous patch!

  • platform/qt/PathQt.cpp: (WebCore::Path::apply):
3:43 PM Changeset in webkit [16220] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Tim H.

Fix build on Qt/Linux.

  • CMakeLists.txt:
  • platform/qt/PathQt.cpp: (WebCore::Path::transform):
3:28 PM Changeset in webkit [16219] by weinig
  • 3 edits
    3 adds
    1 delete in trunk

WebKitQt:

Reviewed by Tim H.

Fixes last part of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Move QtLauncher down to WebKitQt.

  • QtLauncher/CMakeLists.txt: Added.
  • QtLauncher/main.cpp: Added. (main):

WebKitTools:

Reviewed by Tim H.

Fixes last part of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Move QtLauncher down to WebKitQt.

  • QtLauncher/CMakeLists.txt: Removed.
  • QtLauncher/main.cpp: Removed.
12:49 PM Changeset in webkit [16218] by ap
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

The project file didn't get committed with my last checking.

11:34 AM Changeset in webkit [16217] by ap
  • 12 edits
    3 adds in trunk

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10676
@charset rules not accessible via DOM

Test: fast/encoding/css-charset-dom.html

  • WebCore.xcodeproj/project.pbxproj: Added CSSCharsetRule.cpp
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleSheet::getValueProperty): Separated Rules and CssRules, since now they behave differently.
  • css/CSSCharsetRule.h: Make the constructor take an encoding.
  • css/CSSCharsetRule.cpp: Added.
  • css/CSSGrammar.y: Create CSSStylesheetRules as necessary.
  • css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList):
  • css/CSSRuleList.h:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
  • css/CSSStyleSheet.h: Skip charset rules in IE compatibility mode.
  • css/StyleBase.h: (WebCore::StyleBase::isCharsetRule): Fixed a typo.
  • css/cssparser.cpp: (WebCore::CSSParser::createCharsetRule):
  • css/cssparser.h: Added createCharsetRule().
10:37 AM Changeset in webkit [16216] by weinig
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Darin.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Let FrameQt operate on a FrameQtClient, just like Win/Mac handle it.

  • CMakeLists.txt:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQtClient.cpp: Added. (WebCore::FrameQtClientDefault::FrameQtClientDefault): (WebCore::FrameQtClientDefault::~FrameQtClientDefault): (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::receivedResponse): (WebCore::FrameQtClientDefault::receivedData): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/FrameQtClient.h: Added. (WebCore::FrameQtClient::~FrameQtClient):
10:34 AM Changeset in webkit [16215] by weinig
  • 4 edits
    2 adds in trunk/WebKitTools

Reviewed by Darin.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Adjust DumpRenderTree to the FrameQtClient changes.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::frame):
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp: Added. (WebCore::DumpRenderTreeClient::DumpRenderTreeClient): (WebCore::DumpRenderTreeClient::~DumpRenderTreeClient):
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h: Added.
10:11 AM Changeset in webkit [16214] by weinig
  • 1 edit
    16 adds in trunk
2:31 AM Changeset in webkit [16213] by eseidel
  • 2 edits in trunk/WebCore

2006-09-04 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Clean-up style and spacing.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10724
No tests needed, no functional changes.

  • ksvg2/svg/svgpathparser.cpp: (WebCore::parseCoord): (WebCore::SVGPolyParser::parsePoints): (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc): (WebCore::SVGPathParser::svgLineToHorizontal): (WebCore::SVGPathParser::svgLineToVertical): (WebCore::SVGPathParser::svgCurveToCubicSmooth): (WebCore::SVGPathParser::svgCurveToQuadratic): (WebCore::SVGPathParser::svgCurveToQuadraticSmooth): (WebCore::SVGPathParser::svgArcTo):
2:22 AM Changeset in webkit [16212] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6546
clipPath data does not respect transforms

Get the transform from the dom element and adjust
the clip path with it.

12:57 AM Changeset in webkit [16211] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Eric.

This code should have gone in as part of:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
It addresses the comments there, also we use double instead
of float now in calculations.

Sep 3, 2006:

7:11 PM Changeset in webkit [16210] by weinig
  • 13 edits
    2 adds in trunk

WebCore:

Reviewed by Darin and Tim H.

Auto-generates DOMMediaList, DOMStyleSheet, and DOMStyleSheetList.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm: (+[DOMStyleSheet _styleSheetWith:]): (+[DOMCSSStyleSheet _CSSStyleSheetWith:]):
  • bindings/objc/DOMCSSInternal.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMObject.mm: (-[DOMObject sheet]):
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMStylesheets.h:
  • bindings/objc/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/StyleSheet.idl: Added.
  • css/StyleSheetList.idl: Added.

WebKit:

Reviewed by Darin and Tim H.

  • MigrateHeaders.make:
6:00 PM Changeset in webkit [16209] by weinig
  • 1 add in trunk/WebCore/platform/Path.cpp

Build fix.

3:19 PM Changeset in webkit [16208] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: More renaming plans.
2:46 PM Changeset in webkit [16207] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOMHTML.mm

Build fix to avoid warning about property name conflict.

2:31 PM Changeset in webkit [16206] by rwlbuis
  • 38 edits in trunk/WebCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
RenderPathQuartz and RenderPathQt should not be needed

Cleanup of code related to RenderPath.

2:20 PM Changeset in webkit [16205] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Fix a typo Darin called out, but I forgot to change.

2:11 PM Changeset in webkit [16204] by thatcher
  • 1 edit in trunk/WebCore/bindings/scripts/CodeGeneratorObjC.pm

Build fix.

1:48 PM Changeset in webkit [16203] by thatcher
  • 5 edits in trunk

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:42 PM Changeset in webkit [16202] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:38 PM Changeset in webkit [16201] by thatcher
  • 30 edits in trunk/WebCore

Reviewed by Darin.

Bug 10685: ObjC DOM should have no unnamed parameters
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10685

  • The ObjC code generation script now outputs parameter prefixes for methods that have more than 1 parameter. This prefix is simply the parameter name. Some parameter names have been changed in the IDL files to produce better prefixes. If an extended attribute of "ObjCPrefix" exists on a parameter we will use that for the prefix.
  • A backwards compatible version of the method is placed in a category with a deprecation marco for 10.5 and later. This step only happens if the IDL extended attribute "OldStyleObjC" is defined. All new functions in IDL should not get this attribute.
  • Made the $interfaceMethodSelector regex in IDLStructure.pm allow "=" so parameter extended attributes can have values.
  • Moved RemoveExcludedAttributesAndFunctions to CodeGenerator.pm so it can be shared between the two generators.


  • Removed the die when we encounter a getter that uses exceptions. Sam Weinig added support for this in an earlier change.
  • Check if $ENV{"MACOSX_DEPLOYMENT_TARGET"} is defined before we compare. This caused a perl warning when generating on other platforms.
  • The ObjC generation will not happen on platforms other than Mac OS. This is determined by the "OS" env variable Xcode sets. This check is in the DerivedSources.make.
  • Added a way to skip generation if the constructor of the specific generator returns undef. Not used yet.
  • Many cleanup tweaks in CodeGeneratorObjC.pm.
  • Removed IDL and CSS files from the project's resource copy phase, these do no need to be in WebCore's resources.
  • DerivedSources.make
  • WebCore.xcodeproj/project.pbxproj
  • bindings/scripts/CodeGenerator.pm
  • bindings/scripts/CodeGeneratorJS.pm
  • bindings/scripts/CodeGeneratorObjC.pm
  • bindings/scripts/IDLStructure.pm
  • css/CSSMediaRule.idl
  • css/CSSPrimitiveValue.idl
  • css/CSSStyleDeclaration.idl
  • css/CSSStyleSheet.idl
  • dom/CharacterData.idl
  • dom/DOMImplementation.idl
  • dom/Document.idl
  • dom/Element.idl
  • dom/KeyboardEvent.idl
  • dom/MouseEvent.idl
  • dom/MutationEvent.idl
  • dom/NamedNodeMap.idl
  • dom/UIEvent.idl
  • html/HTMLCanvasElement.idl
  • html/HTMLSelectElement.idl
  • ksvg2/bindings/idl/svg/SVGLengthList.idl
  • ksvg2/bindings/idl/svg/SVGNumberList.idl
  • ksvg2/bindings/idl/svg/SVGPointList.idl
  • ksvg2/bindings/idl/svg/SVGStringList.idl
  • ksvg2/bindings/idl/svg/SVGTextContentElement.idl
  • ksvg2/bindings/idl/svg/SVGTransformList.idl
  • ksvg2/svg/SVGSVGElement.idl
  • page/DOMWindow.idl
12:08 PM Changeset in webkit [16200] by ap
  • 11 edits in trunk

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10693
Convert JavaScript arrays to AppleScript lists

JavaScriptCore:

  • JavaScriptCore.exp: Export ArrayInstance::info and ArrayInstance::getItem().
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::getItem): Added a method to access array items from C++.

WebCore:

  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Added a case for ArrayInstance.

LayoutTests:

  • fast/AppleScript/array-expected.txt:
  • fast/AppleScript/array.html: Updated results, added a test for circular dependencies.

WebKitTools:

  • DumpRenderTree/AppleScriptController.m: (convertAEDescToObject): (-[AppleScriptController doJavaScript:]): Support printing AEDescLists.
10:28 AM Changeset in webkit [16199] by ap
  • 1 edit in trunk/LayoutTests/http/tests/incremental/slow-utf8-html.pl

http/tests/incremental/slow-utf8-html-diffs.txt
Set executable bit that was lost when re-applying the patch.

9:59 AM Changeset in webkit [16198] by ap
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10697
REGRESSION (r16175): Errors in incremental decoding of UTF-8

Tests:

  • http/tests/incremental/slow-utf8-html.pl
  • fast/encoding/charset-invalid.html
  • loader/Decoder.cpp: (Decoder::Decoder): Ensure that we have a valid encoding. Get its name via TextEncoding, to match the logic in setEncodingName(). (Decoder::setEncodingName): Only set m_encodingName if the encoding is valid. Rely on TextEncoding constructor to lowercase it if necessary. (Decoder::decode): Use setEncodingName() to apply encoding from BOM. Don't try to ensure the validity of encoding - it is enforced by class constructor and setEncodingName().
6:45 AM Changeset in webkit [16197] by weinig
  • 1 edit in trunk/WebCore/bindings/objc/DOMRGBColor.h

Fixes build for regression tests.

2:25 AM Changeset in webkit [16196] by ap
  • 4 edits
    2 moves
    1 add
    2 deletes in trunk/LayoutTests

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4508
Layout tests access an external server

  • fast/backgrounds/repeat/noRepeatCorrectClip.html: Use a local resource (it was already present, but the test still pointed to a remote one).
  • fast/dom/HTMLImageElement/image-src-absolute-url-expected.txt:
  • fast/dom/HTMLImageElement/image-src-absolute-url.html: Use a non-existent file URL instead of a non-existent http one.
  • fast/loader/docLoaderFrame-expected.checksum: Removed.
  • fast/loader/docLoaderFrame-expected.png: Removed.
  • fast/loader/docLoaderFrame-expected.txt: Removed.
  • fast/loader/docLoaderFrame.html: Removed.
  • http/tests/xmlhttprequest/docLoaderFrame-expected.txt: Added.
  • http/tests/xmlhttprequest/docLoaderFrame.html: Added.
  • http/tests/xmlhttprequest/resources/docLoaderFrame-data.html: Added. Use a local resource. Also, turned the test into a text one, and used waitUntilDone to make it actually work.
Note: See TracTimeline for information about the timeline view.