⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 8, 2006:

6:56 PM Changeset in webkit [16273] by eseidel
  • 51 edits in trunk/WebCore

2006-09-08 Eric Seidel <​eric@eseidel.com>

Reviewed by darin.

Replace incorrect fooBaseValue() calls with foo() calls instead.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10746


With the previously broken animation system, we had both base and anim values
but they were not automatically connected/disconnected when animation started and stopped.
So the animVals were basically never used (since they were always wrong).
Now, animVal and baseVal are handled correctly.


There are only 3 places in the code where we will ever need to use the BaseValue accessor variants.

  1. SVGAnimated* DOM bindings
  2. Animation Code
  3. parseMappedAttribute implementations
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::relativeBBox): (WebCore::RenderSVGImage::getAbsoluteRepaintRect): (WebCore::RenderSVGImage::translationForAttributes):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::translationForAttributes):
  • ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement):
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
  • ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::parseMappedAttribute): (SVGCircleElement::toPathData): (SVGCircleElement::pushAttributeContext): (SVGCircleElement::hasPercentageValues):
  • ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::transferFunction):
  • ksvg2/svg/SVGCursorElement.cpp: (SVGCursorElement::parseMappedAttribute):
  • ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::parseMappedAttribute): (WebCore::SVGEllipseElement::toPathData): (WebCore::SVGEllipseElement::pushAttributeContext): (WebCore::SVGEllipseElement::hasPercentageValues):
  • ksvg2/svg/SVGFEBlendElement.cpp: (SVGFEBlendElement::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElement.cpp: (SVGFEComponentTransferElement::filterEffect):
  • ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::filterEffect):
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::filterEffect):
  • ksvg2/svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::lightSource):
  • ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::filterEffect):
  • ksvg2/svg/SVGFEImageElement.cpp: (SVGFEImageElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEMergeElement.cpp: (SVGFEMergeElement::SVGFEMergeElement): (SVGFEMergeElement::filterEffect):
  • ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::filterEffect):
  • ksvg2/svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::SVGFEPointLightElement): (WebCore::SVGFEPointLightElement::lightSource):
  • ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::filterEffect):
  • ksvg2/svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::lightSource):
  • ksvg2/svg/SVGFETileElement.cpp: (SVGFETileElement::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::filterEffect):
  • ksvg2/svg/SVGFilterElement.cpp: (SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp: (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
  • ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport):
  • ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::toPathData): (SVGLineElement::pushAttributeContext): (SVGLineElement::hasPercentageValues):
  • ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::attributeChanged): (WebCore::SVGMaskElement::drawMaskerContent):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::pushAttributeContext): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::notifyAttributeChange): (WebCore::SVGPatternElement::getCTM):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::toPathData): (WebCore::SVGRectElement::pushAttributeContext): (WebCore::SVGRectElement::hasPercentageValues):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::parseMappedAttribute): (WebCore::SVGSVGElement::getCTM): (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::createRenderer):
  • ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::updateReferencedText):
  • ksvg2/svg/SVGUseElement.cpp: (SVGUseElement::closeRenderer):
6:46 PM Changeset in webkit [16272] by eseidel
  • 2 edits in trunk/WebCore

2006-09-08 Eric Seidel <​eric@eseidel.com>

Reviewed by beth.

Remove the last vestiges of KDOM (KDOMCSSValue and KDOMCSSValueList)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10778

  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
6:35 PM Changeset in webkit [16271] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by Brady Eidson.

Rolled out Maciej's code cleanup from 8/22. It turns out that keeping the "loading" flag
is a useful optimization, as it avoids many Objective-C method calls while polling resources
for their load state.

This fixes a 3-4% PLT performance regression (as measured on my MacBook Pro).

  • Loader/WebFrameLoader.m: (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]):
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _setLoading:]): (-[WebDataSource _updateLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopLoading]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource isLoading]):
  • WebView/WebDataSourceInternal.h:
5:11 PM Changeset in webkit [16270] by kmccullo
  • 2 edits in trunk/WebKitSite

Reviewed by Adel.

  • this patch brought to you by the letter 'c'
  • coding/coding-style.html:
3:48 PM Changeset in webkit [22150] by beidson
  • 4 edits in branches/WindowsMerge/WebKitWin

Stubs for Icon Database Path preferences

5:51 AM Changeset in webkit [16269] by zbujtas
  • 5 edits in S60/trunk

2006-09-08 ligman <​joseph.ligman@nokia.com>

Reviewed by Zalan Bujtas.
DESC: The text buffer returned from CWebCoreBridge::GetNextRenderTextForSmartLinksL
was getting prematurely deleted. To resolve, store a copy in the WebCore and remove
the copy from Webkit since it is no longer needed.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10498

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::~CWebCoreBridge): (CWebCoreBridge::GetNextRenderTextForSmartLinksL): (CWebCoreBridge::GetRenderTextArea):
  • bridge/WebCoreBridge.h:

Sep 7, 2006:

4:48 PM Changeset in webkit [16268] by bdakin
  • 4 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Darin sort of and Maciej definitely.

Fix for <rdar://problem/4719149> Crash caused by malformed frame
setup. This is the same bug as 3853672, which has been fixed on TOT
for a while. We feel like this fix is much safer for the branch
though.

  • WebKit.xcodeproj/project.pbxproj: Version wars.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[NSURLProtocol releaseResources]): Added comment for assertion that will be hit. (-[NSURLProtocol didFailWithError:]): Added comment for assertion that will be hit.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): Retain and release all of the pieces involved with sending the error.
3:06 PM Changeset in webkit [16267] by weinig
  • 13 edits
    1 add in trunk

WebCore:

Reviewed by Darin and Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
Auto-generate the Objective-C DOM Traversal bindings

  • Auto-generates DOMNodeIterator and DOMTreeWalker.
  • Splits out DOMNodeFilter into its own file.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMNodeFilter.h: Added.
  • bindings/objc/DOMTraversal.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/NodeFilter.idl:
  • dom/NodeIterator.idl:
  • dom/Range.idl:
  • dom/TreeWalker.idl:

WebKit:

Reviewed by Darin and Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
Auto-generate the Objective-C DOM Traversal bindings

  • MigrateHeaders.make:
3:06 PM Changeset in webkit [16266] by spadma
  • 2 edits in S60/trunk/WebKit

2006-09-07 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Check if the pageUrl is Null before setting it as currentUrl
​http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadResourceL):
12:40 PM Changeset in webkit [16265] by spadma
  • 5 edits in S60/trunk/WebKit

2006-09-07 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC: Disable the form autofill feature for embedded browser and make sure there is no crash on accessing the autofill database.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10754

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::CFormInputSkin): (CFormInputSkin::SetText): (CFormInputSkin::ActivateL):
  • BrowserView/inc/WebKitControl.h: (CWebKitControl::FormDataManagerL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
11:45 AM Changeset in webkit [16264] by aroben
  • 5 edits in trunk/WebCore

2006-09-07 MorganL <​morlmor@yahoo.com>

Reviewed by Darin, landed by Adam.

Fixes part of bug 10743: Windows build busted.

  • platform/win/FontCacheWin.cpp: Add missing #include, set svn:eol-style to native (WebCore::FontCache::getFontLinkInterface): (WebCore::FontCache::getFontDataForCharacters):
  • platform/win/FontDataWin.cpp: Ditto. (WebCore::FontData::platformWidthForGlyph):
  • platform/win/FontWin.cpp: Add missing #include, band-aid over const problem with GlyphBufferGlyph (WebCore::Font::drawGlyphs):
  • platform/win/ResourceLoaderWin.cpp: Add missing #include, change .ascii() to .latin1() (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::start):
11:27 AM Changeset in webkit [22149] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-07 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou Amadio.


Fix CFArray allocator usage for cases where we store CF types in the array.

  • WebHistory.cpp: (WebHistory::WebHistory): (WebHistory::datesArray):
10:37 AM Changeset in webkit [16263] by ap
  • 4 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10753
REGRESSION: The beginning of a CSS file is missing

Test: http/tests/incremental/slow-utf8-css.pl

  • loader/Decoder.cpp: (WebCore::Decoder::checkForCSSCharset): Use the same buffering logic as used for HTML. (WebCore::Decoder::decode):
  • loader/Decoder.h: Added a return value and a movedDataToBuffer parameter to checkForCSSCharset().
10:08 AM Changeset in webkit [16262] by weinig
  • 17 edits
    4 adds
    1 delete in trunk

WebCore:

Reviewed by Darin.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
Auto-generate the Objective-C DOM Events bindings

  • Auto-generates DOMEvent, DOMKeyboardEvent, DOMMouseEvent, DOMMutationEvent, DOMOverflowEvent, DOMUIEvent, and DOMWheelEvent.


  • Splits out DOMEventListener and DOMEventTarget into their own files.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMEventListener.h: Added.
  • bindings/objc/DOMEventTarget.h: Added.
  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm: (-[DOMEvent WebCore::]): (-[DOMEvent _initWithEvent:WebCore::]): (+[DOMEvent _eventWith:WebCore::]):
  • bindings/objc/DOMEventsNonstandard.mm: Removed.
  • bindings/objc/DOMNode.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Event.idl:
  • dom/EventListener.idl: Added.
  • dom/EventTarget.idl: Added.
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:

WebKit:

Reviewed by Darin.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
Auto-generate the Objective-C DOM Events bindings

  • MigrateHeaders.make:
  • WebKit.xcodeproj/project.pbxproj:
8:48 AM Changeset in webkit [16261] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-09-07 bujtas <​zbujtas@gmail.com>

Reviewed by Sriram Yadavalli.
DESC: do not call tabbednavigation when the document
is null.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10767

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::TabbedNavigation):
7:33 AM Changeset in webkit [16260] by spadma
  • 2 edits in S60/trunk/WebKit

2006-09-07 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Sachin.
DESC: [S60] OfferKeyEventL() doesn't return a correct response value if it doesn't do anything
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10737

  • Plugin/src/PluginWin.cpp: (CPluginWin::OfferKeyEventL):
2:03 AM Changeset in webkit [16259] by rwlbuis
  • 227 edits
    4 adds in trunk

WebCore:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9753
SVG with width and height 100% leaves room for scrollbar on the right.

Relayout children of svg containers, except svg shapes that do not depend on percentages.

LayoutTests:

Reviewed by Maciej.

New test case for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9753>
SVG with width and height 100% leaves room for scrollbar on the right.

Also Updated .txt files (all text blocks are wider) and some updated
pixel tests (some text is layouted differently because of wider text blocks).

Note: See TracTimeline for information about the timeline view.