Timeline
Sep 9, 2006:
- 11:28 PM Changeset in webkit [22151] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Reviewed by hyatt.
Remove unnecessary calls to setAffectedBy{Active,Hover}Rules
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustMenuListStyle): Remove unnecessary calls
- 10:52 PM Changeset in webkit [16282] by
-
- 4 adds in trunk/LayoutTests/fast/forms
Add test for textarea scrollwidth and height.
- 10:47 PM Changeset in webkit [16281] by
-
- 4 adds in trunk/LayoutTests/fast/block/positioning
Add layout test for bug 10719.
- 10:37 PM Changeset in webkit [16280] by
-
- 8 edits in trunk/WebCore
Fix for Bugzilla bug 5500, scrollLeft/Top/Width/Height properties not supported
on textarea. Refactored the DOM getters and setters to go through the renderer
instead of right to the layer. The renderer functions are virtual so that the
text control can subclass and forward to its anonymous div.
Fix for Bugzilla bug 10719, When positioned objects are sizing using their
containing block width as a guide, they should not ever use the line width like
non-positioned objects do.
Reviewed by aroben
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp: (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):
- rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned):
- rendering/RenderObject.cpp: (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight): (WebCore::RenderObject::scrollWidth): (WebCore::RenderObject::scrollHeight): (WebCore::RenderObject::scrollLeft): (WebCore::RenderObject::scrollTop): (WebCore::RenderObject::setScrollLeft): (WebCore::RenderObject::setScrollTop): (WebCore::RenderObject::hasStaticX): (WebCore::RenderObject::hasStaticY):
- rendering/RenderObject.h: (WebCore::RenderObject::clientLeft): (WebCore::RenderObject::clientTop):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::scrollWidth): (WebCore::RenderTextControl::scrollHeight): (WebCore::RenderTextControl::scrollLeft): (WebCore::RenderTextControl::scrollTop): (WebCore::RenderTextControl::setScrollLeft): (WebCore::RenderTextControl::setScrollTop):
- rendering/RenderTextControl.h:
- 9:55 PM Changeset in webkit [16279] by
-
- 4 edits in trunk/WebCore
Implement support for the WinIE clientLeft and clientTop extensions.
Reviewed by aroben
- dom/Element.cpp: (WebCore::Element::clientLeft): (WebCore::Element::clientTop):
- dom/Element.h:
- dom/Element.idl:
- rendering/RenderObject.h: (WebCore::RenderObject::clientLeft): (WebCore::RenderObject::clientTop):
- 7:36 PM Changeset in webkit [16278] by
-
- 12 edits in trunk
WebCore:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings
- Auto-generates DOMXPathExpression, DOMXPathNSResolver and DOMXPathResult.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMPrivate.h:
- bindings/objc/DOMXPath.h:
- bindings/objc/DOMXPath.mm:
- bindings/objc/PublicDOMInterfaces.h:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- xml/XPathResult.idl:
WebKit:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings
- MigrateHeaders.make:
- 3:05 PM Changeset in webkit [16277] by
-
- 23 edits3 adds1 delete in trunk
WebCore:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup
- Auto-generate some remaining extension methods for DOMDocument and DOMCSSStyleDeclaration.
- Split DOMHTMLEmbedElement into it's own files. It can't be auto-generated yet because the Objective-C interface is significantly different from the implementation interface. Since HTMLEmbedElement is not in the W3C spec, this is somewhat of a gray area.
- Auto-generate DOMEventListener protocol.
- Clean up the IDL files by separating the extensions from the specified methods and attributes.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
- bindings/objc/DOMCSS.mm:
- bindings/objc/DOMEventListener.h: Removed.
- bindings/objc/DOMExtensions.h:
- bindings/objc/DOMHTML.h:
- bindings/objc/DOMHTML.mm:
- bindings/objc/DOMHTMLEmbedElement.h: Added.
- bindings/objc/DOMHTMLEmbedElement.mm: Added. (-[DOMHTMLEmbedElement align]): (-[DOMHTMLEmbedElement setAlign:]): (-[DOMHTMLEmbedElement height]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement name]): (-[DOMHTMLEmbedElement setName:]): (-[DOMHTMLEmbedElement src]): (-[DOMHTMLEmbedElement setSrc:]): (-[DOMHTMLEmbedElement type]): (-[DOMHTMLEmbedElement setType:]): (-[DOMHTMLEmbedElement width]): (-[DOMHTMLEmbedElement setWidth:]):
- bindings/objc/DOMPrivate.h:
- bindings/objc/PublicDOMInterfaces.h:
- css/CSSStyleDeclaration.idl:
- dom/Document.idl:
- dom/KeyboardEvent.h:
- dom/KeyboardEvent.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/OverflowEvent.idl:
- dom/UIEvent.idl:
- dom/WheelEvent.idl:
- html/HTMLEmbedElement.idl: Added.
WebKit:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup
- MigrateHeaders.make:
WebKitTools:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup
- Change to use new, more Objectice-C'ish version of DOMKeyboardEvent's initKeyboardEvent. Fixes an error with regression test for fast/events/dblclick-addEventListener.html.
- DumpRenderTree/EventSendingController.m: (-[EventSendingController fireKeyboardEventsToElement:]):
- 1:29 PM Changeset in webkit [16276] by
-
- 47 edits in trunk/WebCore
2006-09-09 Eric Seidel <eric@eseidel.com>
Reviewed by Tim H.
Remove DeprecatedString usage and fix style.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10787
No tests were harmed in the making of this patch.
- kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilterEffect::in): (WebCore::KCanvasFilterEffect::setIn): (WebCore::KCanvasFilterEffect::result): (WebCore::KCanvasFilterEffect::setResult): (WebCore::KCanvasFEMerge::externalRepresentation):
- kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEBlend::in2): (WebCore::KCanvasFEBlend::setIn2): (WebCore::KCanvasFEComposite::in2): (WebCore::KCanvasFEComposite::setIn2): (WebCore::KCanvasFEDisplacementMap::in2): (WebCore::KCanvasFEDisplacementMap::setIn2): (WebCore::KCanvasFEMerge::mergeInputs): (WebCore::KCanvasFEMerge::setMergeInputs):
- kcanvas/KCanvasResources.cpp: (WebCore::KCanvasResource::idInRegistry): (WebCore::KCanvasResource::setIdInRegistry): (WebCore::getResourceById):
- kcanvas/KCanvasResources.h:
- kcanvas/RenderPath.cpp: (WebCore::RenderPath::getAbsoluteRepaintRect): (WebCore::RenderPath::paint): (WebCore::RenderPath::drawMarkersIfNeeded):
- kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
- kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
- kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
- kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::idInRegistry): (WebCore::KRenderingPaintServer::setIdInRegistry):
- kcanvas/device/quartz/KCanvasFilterQuartz.h:
- kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::imageForName): (WebCore::KCanvasFilterQuartz::setImageForName): (WebCore::KCanvasFEMergeQuartz::getCIFilter):
- ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- ksvg2/css/SVGRenderStyle.cpp:
- ksvg2/css/SVGRenderStyle.h:
- ksvg2/css/SVGRenderStyleDefs.h:
- ksvg2/ecma/GlobalObject.cpp: (GlobalObject::get):
- ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
- ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::SVGDescElement): (WebCore::SVGDescElement::description):
- ksvg2/svg/SVGDescElement.h:
- ksvg2/svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::filterEffect):
- ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::SVGFEColorMatrixElement): (SVGFEColorMatrixElement::filterEffect):
- ksvg2/svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::filterEffect):
- ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::SVGFECompositeElement): (SVGFECompositeElement::filterEffect):
- ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::filterEffect):
- ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (SVGFEDisplacementMapElement::filterEffect):
- ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::filterEffect):
- ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (SVGFEGaussianBlurElement::filterEffect):
- ksvg2/svg/SVGFELightElement.cpp:
- ksvg2/svg/SVGFEMergeElement.cpp: (SVGFEMergeElement::filterEffect):
- ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::SVGFEOffsetElement): (SVGFEOffsetElement::filterEffect):
- ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::SVGFESpecularLightingElement): (SVGFESpecularLightingElement::filterEffect):
- ksvg2/svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::filterEffect):
- ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::SVGFETurbulenceElement):
- ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp: (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::parseMappedAttribute):
- ksvg2/svg/SVGFitToViewBox.h:
- ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::buildGradient):
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::notifyAttributeChange):
- ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::getCTM):
- ksvg2/svg/SVGPreserveAspectRatio.h:
- ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
- ksvg2/svg/SVGStyleElement.cpp:
- ksvg2/svg/SVGStyledTransformableElement.cpp:
- ksvg2/svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::parseMappedAttribute):
- ksvg2/svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::SVGZoomAndPan):
- 8:35 AM Changeset in webkit [16275] by
-
- 3 edits2 adds in trunk
LayoutTests:
Adds a test for the CSS URL quoting logic.
- fast/inspector/cssURLQuotes-expected.txt: Added.
- fast/inspector/cssURLQuotes.html: Added.
WebCore:
Reviewed by Tim H.
<rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load
Fixes the quoting logic. The previous logic did not account for the
CSS tokenizer's regex character range between * and ~ as valid in URL types.
- css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerURL):
- 3:54 AM Changeset in webkit [16274] by
-
- 4 edits in trunk
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10759 fast/AppleScript/array.html test failing
WebCore:
- bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Convert integer values to typeSInt32 AE descriptors.
LayoutTests:
- fast/AppleScript/001-expected.txt: Updated results.
Sep 8, 2006:
- 6:56 PM Changeset in webkit [16273] by
-
- 51 edits in trunk/WebCore
2006-09-08 Eric Seidel <eric@eseidel.com>
Reviewed by darin.
Replace incorrect fooBaseValue() calls with foo() calls instead.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10746
With the previously broken animation system, we had both base and anim values
but they were not automatically connected/disconnected when animation started and stopped.
So the animVals were basically never used (since they were always wrong).
Now, animVal and baseVal are handled correctly.
There are only 3 places in the code where we will ever need to use the BaseValue accessor variants.
- SVGAnimated* DOM bindings
- Animation Code
- parseMappedAttribute implementations
- kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes):
- kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::relativeBBox): (WebCore::RenderSVGImage::getAbsoluteRepaintRect): (WebCore::RenderSVGImage::translationForAttributes):
- kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::translationForAttributes):
- ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement):
- ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
- ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::parseMappedAttribute): (SVGCircleElement::toPathData): (SVGCircleElement::pushAttributeContext): (SVGCircleElement::hasPercentageValues):
- ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
- ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::transferFunction):
- ksvg2/svg/SVGCursorElement.cpp: (SVGCursorElement::parseMappedAttribute):
- ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::parseMappedAttribute): (WebCore::SVGEllipseElement::toPathData): (WebCore::SVGEllipseElement::pushAttributeContext): (WebCore::SVGEllipseElement::hasPercentageValues):
- ksvg2/svg/SVGFEBlendElement.cpp: (SVGFEBlendElement::filterEffect):
- ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::filterEffect):
- ksvg2/svg/SVGFEComponentTransferElement.cpp: (SVGFEComponentTransferElement::filterEffect):
- ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::filterEffect):
- ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::filterEffect):
- ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::filterEffect):
- ksvg2/svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::lightSource):
- ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
- ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::filterEffect):
- ksvg2/svg/SVGFEImageElement.cpp: (SVGFEImageElement::parseMappedAttribute):
- ksvg2/svg/SVGFEMergeElement.cpp: (SVGFEMergeElement::SVGFEMergeElement): (SVGFEMergeElement::filterEffect):
- ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::filterEffect):
- ksvg2/svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::SVGFEPointLightElement): (WebCore::SVGFEPointLightElement::lightSource):
- ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::filterEffect):
- ksvg2/svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::lightSource):
- ksvg2/svg/SVGFETileElement.cpp: (SVGFETileElement::filterEffect):
- ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::filterEffect):
- ksvg2/svg/SVGFilterElement.cpp: (SVGFilterElement::canvasResource):
- ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp: (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
- ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport):
- ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::toPathData): (SVGLineElement::pushAttributeContext): (SVGLineElement::hasPercentageValues):
- ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::buildGradient):
- ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
- ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::attributeChanged): (WebCore::SVGMaskElement::drawMaskerContent):
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::pushAttributeContext): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::notifyAttributeChange): (WebCore::SVGPatternElement::getCTM):
- ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
- ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::toPathData): (WebCore::SVGRectElement::pushAttributeContext): (WebCore::SVGRectElement::hasPercentageValues):
- ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::parseMappedAttribute): (WebCore::SVGSVGElement::getCTM): (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::createRenderer):
- ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::updateReferencedText):
- ksvg2/svg/SVGUseElement.cpp: (SVGUseElement::closeRenderer):
- 6:46 PM Changeset in webkit [16272] by
-
- 2 edits in trunk/WebCore
2006-09-08 Eric Seidel <eric@eseidel.com>
Reviewed by beth.
Remove the last vestiges of KDOM (KDOMCSSValue and KDOMCSSValueList)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10778
- ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
- 6:35 PM Changeset in webkit [16271] by
-
- 4 edits in trunk/WebKit
Reviewed by Brady Eidson.
Rolled out Maciej's code cleanup from 8/22. It turns out that keeping the "loading" flag
is a useful optimization, as it avoids many Objective-C method calls while polling resources
for their load state.
This fixes a 3-4% PLT performance regression (as measured on my MacBook Pro).
- Loader/WebFrameLoader.m: (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]):
- WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _setLoading:]): (-[WebDataSource _updateLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopLoading]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource isLoading]):
- WebView/WebDataSourceInternal.h:
- 5:11 PM Changeset in webkit [16270] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Adel.
- this patch brought to you by the letter 'c'
- coding/coding-style.html:
- 3:48 PM Changeset in webkit [22150] by
-
- 4 edits in branches/WindowsMerge/WebKitWin
Stubs for Icon Database Path preferences
- 5:51 AM Changeset in webkit [16269] by
-
- 5 edits in S60/trunk
2006-09-08 ligman <joseph.ligman@nokia.com>
Reviewed by Zalan Bujtas.
DESC: The text buffer returned from CWebCoreBridge::GetNextRenderTextForSmartLinksL
was getting prematurely deleted. To resolve, store a copy in the WebCore and remove
the copy from Webkit since it is no longer needed.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10498
WARNING: NO TEST CASES ADDED OR CHANGED
- bridge/WebCoreBridge.cpp: (CWebCoreBridge::~CWebCoreBridge): (CWebCoreBridge::GetNextRenderTextForSmartLinksL): (CWebCoreBridge::GetRenderTextArea):
- bridge/WebCoreBridge.h: