⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 10, 2006:

11:37 PM Changeset in webkit [16296] by hyatt
  • 15 edits in trunk/WebCore

Rework the printer font stuff a little bit so that the Font API doesn't
have to be changed.

Reviewed by eseidel

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreStringTruncator.mm: (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • platform/Font.cpp: (WebCore::Font::drawSimpleText):
  • platform/Font.h:
  • platform/TextStyle.h: (WebCore::TextStyle::TextStyle): (WebCore::TextStyle::attemptFontSubstitution): (WebCore::TextStyle::setRTL):
  • platform/mac/FontMac.mm: (WebCore::m_wordSpacing): (WebCore::Font::drawGlyphs):
  • platform/mac/ListBoxMac.mm: (itemTextRenderer): (groupLabelTextRenderer): (-[WebCoreTableView drawRow:clipRect:]):
  • platform/mac/PopUpButtonMac.mm: (PopUpButton::sizeHint):
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
11:32 PM Changeset in webkit [22156] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Remove usePrinterFont param from Cairo drawGlyphs code path. (CG code path was unpatched so no need to revert it.

11:16 PM Changeset in webkit [16295] by beidson
  • 3 edits in trunk/WebCore
10:23 PM Changeset in webkit [16294] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Added specialized HashTraits

  • platform/IntSizeHash.h:
9:42 PM Changeset in webkit [22155] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Remove the addIntrinsicMargins code from the theme. I did this
in the open source version but forgot to do it in the internal
version.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle): (WebCore::RenderThemeWin::adjustMenuListStyle):
7:48 PM Changeset in webkit [16293] by darin
  • 3 edits
    2 deletes in trunk/LayoutTests
  • converted a text to plain text (makes it platform independent; fixes a failure)
  • fast/text/plain-text-line-breaks-expected.checksum: Removed.
  • fast/text/plain-text-line-breaks-expected.png: Removed.
  • fast/text/plain-text-line-breaks-expected.txt: Regenerated.
  • fast/text/plain-text-line-breaks.html: Added a call to dumpAsText().
7:26 PM Changeset in webkit [16292] by beidson
  • 3 edits in trunk/WebCore

Forgetting header #define protection is BAAAAAD
(and re-alphabatized the project file)

  • WebCore.xcodeproj/project.pbxproj:
  • platform/IntSizeHash.h:
7:13 PM Changeset in webkit [16291] by beidson
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Maciej

Moved the custom IntSize hash out of IconDatabase into a more generally useful file

  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDatabase.h:
  • platform/IntSizeHash.h: Added.
5:14 PM Changeset in webkit [22154] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

4:33 PM Changeset in webkit [16290] by hyatt
  • 58 edits in trunk/LayoutTests/fast/forms

Land new results.

4:27 PM Changeset in webkit [16289] by hyatt
  • 11 edits in trunk/WebCore

Fix for bug 10801, form controls that get styled suddenly lose their
intrinsic margins. Move the intrinsic margin addition code into
adjustRenderStyle and get it out of the theme code and the old form control
code.

Reviewed by aroben

  • css/cssstyleselector.cpp: (WebCore::addIntrinsicMargins): (WebCore::CSSStyleSelector::adjustRenderStyle):
  • css/html4.css:
  • rendering/DeprecatedRenderSelect.h: (WebCore::DeprecatedRenderSelect::calcReplacedHeight):
  • rendering/DeprecatedSlider.h:
  • rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::setStyle):
  • rendering/RenderFormElement.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::adjustTextFieldStyle): (WebCore::RenderThemeMac::adjustTextAreaStyle): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle):
1:22 PM Changeset in webkit [16288] by darin
  • 2 edits in trunk/WebKit

Reviewed by Brady.

  • WebView/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Changed a mistaken "self" to "frame", which was the cause of the bug. Also fixed the method so that it won't crash if createWebViewWithRequest does something that has a side effect of releasing this WebView or this frame by retaining "self" and "frame" as needed. Also fixed a problem where the code to set "opener" was backwards, and would set the opener of the old frame to point to the new frame instead of vice versa.
1:21 PM Changeset in webkit [16287] by darin
  • 1 edit
    2 adds in trunk/WebCore
  • manual-tests/target-test.html: Added.
  • manual-tests/targeted.html: Added.
12:53 PM Changeset in webkit [16286] by eseidel
  • 18 edits in trunk/WebCore

2006-09-10 Eric Seidel <​eric@eseidel.com>

Reviewed by darin.


Remove a bunch more NSGraphicsContext related code.
Add a LocalCurrentGraphicsContext to simplify methods which need to call up into AppKit controls (and thus depend on the [NSGraphicsContext currentContext] being set correctly)
Add an "isPrinting" flag to many of the text drawing functions in order to avoid the need for a GraphicsContext::isPrinting() function.

No tests were harmed in the making of this patch.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h: (WebCore::KRenderingDeviceContextQuartz::cgContext): (WebCore::KRenderingDeviceQuartz::isBuffered):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz): (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • platform/Font.cpp: (WebCore::Font::drawSimpleText): (WebCore::Font::drawText):
  • platform/Font.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText):
  • platform/GraphicsContext.h:
  • platform/mac/FileButtonMac.mm: (-[WebFileChooserButton drawRect:]):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/mac/ListBoxMac.mm: (-[WebCoreTableView drawRow:clipRect:]):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderThemeMac.mm: (WebCore::WebCoreNSGraphicsContextBridge::WebCoreNSGraphicsContextBridge): (WebCore::WebCoreNSGraphicsContextBridge::~WebCoreNSGraphicsContextBridge): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea):
11:17 AM Changeset in webkit [16285] by ap
  • 2 edits in trunk/WebKitQt

Reviewed and landed by ap.

Fix QtLauncher - it is supposed to create a FrameView on its own nowadays.

  • QtLauncher/main.cpp: (main):
12:54 AM Changeset in webkit [22153] by sfalken
  • 4 edits in branches/WindowsMerge
12:41 AM Changeset in webkit [16284] by sfalken
  • 4 edits in trunk/WebCore

2006-09-09 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.

Fixes to work with string API changes.

  • platform/cf/ResourceLoaderCFNet.cpp: (WebCore::arrayFromFormData): (WebCore::ResourceLoader::start):
  • platform/cf/StringCF.cpp:
  • platform/cf/StringImplCF.cpp:
12:40 AM Changeset in webkit [16283] by sfalken
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

2006-09-09 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.


Add missing copy command.
Support finding icu headers in multiple locations.

12:19 AM Changeset in webkit [22152] by sfalken
  • 7 edits in branches/WindowsMerge

Sep 9, 2006:

11:28 PM Changeset in webkit [22151] by aroben
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by hyatt.

Remove unnecessary calls to setAffectedBy{Active,Hover}Rules

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustMenuListStyle): Remove unnecessary calls
10:52 PM Changeset in webkit [16282] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

Add test for textarea scrollwidth and height.

10:47 PM Changeset in webkit [16281] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for bug 10719.

10:37 PM Changeset in webkit [16280] by hyatt
  • 8 edits in trunk/WebCore

Fix for Bugzilla bug 5500, scrollLeft/Top/Width/Height properties not supported
on textarea. Refactored the DOM getters and setters to go through the renderer
instead of right to the layer. The renderer functions are virtual so that the
text control can subclass and forward to its anonymous div.

Fix for Bugzilla bug 10719, When positioned objects are sizing using their
containing block width as a guide, they should not ever use the line width like
non-positioned objects do.

Reviewed by aroben

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp: (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight): (WebCore::RenderObject::scrollWidth): (WebCore::RenderObject::scrollHeight): (WebCore::RenderObject::scrollLeft): (WebCore::RenderObject::scrollTop): (WebCore::RenderObject::setScrollLeft): (WebCore::RenderObject::setScrollTop): (WebCore::RenderObject::hasStaticX): (WebCore::RenderObject::hasStaticY):
  • rendering/RenderObject.h: (WebCore::RenderObject::clientLeft): (WebCore::RenderObject::clientTop):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::scrollWidth): (WebCore::RenderTextControl::scrollHeight): (WebCore::RenderTextControl::scrollLeft): (WebCore::RenderTextControl::scrollTop): (WebCore::RenderTextControl::setScrollLeft): (WebCore::RenderTextControl::setScrollTop):
  • rendering/RenderTextControl.h:
9:55 PM Changeset in webkit [16279] by hyatt
  • 4 edits in trunk/WebCore

Implement support for the WinIE clientLeft and clientTop extensions.

Reviewed by aroben

  • dom/Element.cpp: (WebCore::Element::clientLeft): (WebCore::Element::clientTop):
  • dom/Element.h:
  • dom/Element.idl:
  • rendering/RenderObject.h: (WebCore::RenderObject::clientLeft): (WebCore::RenderObject::clientTop):
7:36 PM Changeset in webkit [16278] by weinig
  • 12 edits in trunk

WebCore:

Reviewed by Eric.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings

  • Auto-generates DOMXPathExpression, DOMXPathNSResolver and DOMXPathResult.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMXPath.h:
  • bindings/objc/DOMXPath.mm:
  • bindings/objc/PublicDOMInterfaces.h:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:

WebKit:

Reviewed by Eric.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings

  • MigrateHeaders.make:
3:05 PM Changeset in webkit [16277] by weinig
  • 23 edits
    3 adds
    1 delete in trunk

WebCore:

Reviewed by Eric.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup

  • Auto-generate some remaining extension methods for DOMDocument and DOMCSSStyleDeclaration.
  • Split DOMHTMLEmbedElement into it's own files. It can't be auto-generated yet because the Objective-C interface is significantly different from the implementation interface. Since HTMLEmbedElement is not in the W3C spec, this is somewhat of a gray area.
  • Auto-generate DOMEventListener protocol.
  • Clean up the IDL files by separating the extensions from the specified methods and attributes.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMEventListener.h: Removed.
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLEmbedElement.h: Added.
  • bindings/objc/DOMHTMLEmbedElement.mm: Added. (-[DOMHTMLEmbedElement align]): (-[DOMHTMLEmbedElement setAlign:]): (-[DOMHTMLEmbedElement height]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement name]): (-[DOMHTMLEmbedElement setName:]): (-[DOMHTMLEmbedElement src]): (-[DOMHTMLEmbedElement setSrc:]): (-[DOMHTMLEmbedElement type]): (-[DOMHTMLEmbedElement setType:]): (-[DOMHTMLEmbedElement width]): (-[DOMHTMLEmbedElement setWidth:]):
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • css/CSSStyleDeclaration.idl:
  • dom/Document.idl:
  • dom/KeyboardEvent.h:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • html/HTMLEmbedElement.idl: Added.

WebKit:

Reviewed by Eric.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup

  • MigrateHeaders.make:

WebKitTools:

Reviewed by Eric.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup

  • Change to use new, more Objectice-C'ish version of DOMKeyboardEvent's initKeyboardEvent. Fixes an error with regression test for fast/events/dblclick-addEventListener.html.
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController fireKeyboardEventsToElement:]):
1:29 PM Changeset in webkit [16276] by eseidel
  • 47 edits in trunk/WebCore

2006-09-09 Eric Seidel <​eric@eseidel.com>

Reviewed by Tim H.


Remove DeprecatedString usage and fix style.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10787

No tests were harmed in the making of this patch.

  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilterEffect::in): (WebCore::KCanvasFilterEffect::setIn): (WebCore::KCanvasFilterEffect::result): (WebCore::KCanvasFilterEffect::setResult): (WebCore::KCanvasFEMerge::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEBlend::in2): (WebCore::KCanvasFEBlend::setIn2): (WebCore::KCanvasFEComposite::in2): (WebCore::KCanvasFEComposite::setIn2): (WebCore::KCanvasFEDisplacementMap::in2): (WebCore::KCanvasFEDisplacementMap::setIn2): (WebCore::KCanvasFEMerge::mergeInputs): (WebCore::KCanvasFEMerge::setMergeInputs):
  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasResource::idInRegistry): (WebCore::KCanvasResource::setIdInRegistry): (WebCore::getResourceById):
  • kcanvas/KCanvasResources.h:
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::getAbsoluteRepaintRect): (WebCore::RenderPath::paint): (WebCore::RenderPath::drawMarkersIfNeeded):
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::idInRegistry): (WebCore::KRenderingPaintServer::setIdInRegistry):
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::imageForName): (WebCore::KCanvasFilterQuartz::setImageForName): (WebCore::KCanvasFEMergeQuartz::getCIFilter):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.cpp:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/ecma/GlobalObject.cpp: (GlobalObject::get):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
  • ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::SVGDescElement): (WebCore::SVGDescElement::description):
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::SVGFEColorMatrixElement): (SVGFEColorMatrixElement::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::filterEffect):
  • ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::SVGFECompositeElement): (SVGFECompositeElement::filterEffect):
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (SVGFEDisplacementMapElement::filterEffect):
  • ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (SVGFEGaussianBlurElement::filterEffect):
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.cpp: (SVGFEMergeElement::filterEffect):
  • ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::SVGFEOffsetElement): (SVGFEOffsetElement::filterEffect):
  • ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::SVGFESpecularLightingElement): (SVGFESpecularLightingElement::filterEffect):
  • ksvg2/svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::SVGFETurbulenceElement):
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp: (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::parseMappedAttribute):
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::notifyAttributeChange):
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::getCTM):
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGStyleElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::parseMappedAttribute):
  • ksvg2/svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::SVGZoomAndPan):
8:35 AM Changeset in webkit [16275] by thatcher
  • 3 edits
    2 adds in trunk

LayoutTests:

Adds a test for the CSS URL quoting logic.

  • fast/inspector/cssURLQuotes-expected.txt: Added.
  • fast/inspector/cssURLQuotes.html: Added.

WebCore:

Reviewed by Tim H.

<rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load


Fixes the quoting logic. The previous logic did not account for the
CSS tokenizer's regex character range between * and ~ as valid in URL types.

  • css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerURL):
3:54 AM Changeset in webkit [16274] by ap
  • 4 edits in trunk

Reviewed by Darin.

WebCore:

  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Convert integer values to typeSInt32 AE descriptors.

LayoutTests:

  • fast/AppleScript/001-expected.txt: Updated results.
Note: See TracTimeline for information about the timeline view.