⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 11, 2006:

10:39 PM Changeset in webkit [16317] by aroben
  • 2 edits in trunk/WebKit

2006-09-11 MorganL <morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10765
Windows build busted due to std::copy usage in Vector.h

  • WebKit.vcproj/WebKit.vcproj: Define _SCL_SECURE_NO_DEPRECATE to get rid of deprecation warnings on std::copy
10:06 PM Changeset in webkit [16316] by hyatt
  • 3 edits in trunk/LayoutTests/fast/table

Land updated table test.

9:52 PM Changeset in webkit [16315] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 8126, column widths apply to the border boxes of cells.

Reviewed by aroben

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::styleOrColWidth):
8:58 PM Changeset in webkit [16314] by thatcher
  • 1 edit in trunk/JavaScriptCore/bindings/objc/objc_utility.mm

Better Tiger build fix.

8:53 PM Changeset in webkit [16313] by beidson
  • 2 edits in trunk/WebKit

Despite the fact that some people built okay without this change, it sure was biting me,
probably because I just wiped my build directory for a fresh build -
Today's earlier removal of DOMList.h needed to occur in MigrateHeaders.make, as well

  • MigrateHeaders.make: removed DOMList.h
7:45 PM Changeset in webkit [16312] by beidson
  • 2 edits in trunk/JavaScriptCore

Build fix - I think Tim's last checkin wasn't tested on Tiger, possibly. I simply
commented out the undefined constants until he can have a chance to make the right call

  • bindings/objc/objc_utility.mm: (KJS::Bindings::objcValueTypeForType): Commented out undefined symbols
5:22 PM Changeset in webkit [16311] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/FrameMac.mm

Build fix. KeyScript is deprecated in Leopard, we need a new solution for this <rdar://problem/4727607>

4:57 PM Changeset in webkit [16310] by thatcher
  • 4 edits in trunk/JavaScriptCore

Reviewed by Tim O. and Darin.

Add support for more method signatures affecting ObjC methods called from JavaScript:

  • Added unsigned types and long long.
  • Allow methods that use const, oneway, bycopy and byref type modifiers.
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_utility.h: (KJS::Bindings::):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue): (KJS::Bindings::objcValueTypeForType):
4:11 PM Changeset in webkit [16309] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fix Qt/Linux build.

  • CMakeLists.txt: Add dom/RangeException.idl to build & fix feature defines.
2:42 PM Changeset in webkit [16308] by eseidel
  • 104 edits
    14 adds
    34 deletes in trunk

2006-09-11 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10750

This finally fixes the SVGAnimated* classes JS bindings!

  • Move all SVGAnimated*.idl files from ksvg2/bindings/idl/svg to ksvg2/svg
  • Adjust XCode/Qt build files to generate the new idl files
  • Remove all SVGAnimated* primitives cpp implementations (Angle/Boolean/Color/Enumeration/Integer/Length/

LengthList/Number/NumberList/PreserveAspectRatio/
Rect/String/TransformList)

  • Remove unneeded methods from CodeGenerator.pm and add new helper function: IsSVGAnimatedType
  • Adjust CodeGeneratorJS.pm to the new SVGAnimated* tear-off concept
  • Add two new macros: ANIMATED_PROPERTY_EMPTY_DECLARATIONS / ANIMATED_PROPERTY_FORWARD_DECLARATIONS. This is used to fix multiple-inheritance issues in SVG with properties, similar like SVGTests::isValid() was fixed.
  • Rewrote SVGList using WTF::Vector, instead of DeprecatedPtrList and killed DOMList. (SVGAnimated*Lists work again now)
  • Adjust macros in SVGElement to create the "*Animated" tear-off classes.
  • Adjust all SVG classes which use the ANIMATED macros to include the ClassName as first param in the header.
  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio): (WebCore::RenderSVGImage::paint):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::translationForAttributes):
  • ksvg2/ksvg.h:
  • ksvg2/misc/SVGDocumentExtensions.h: (WebCore::FloatRect):
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAnimateColorElement.cpp:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (SVGComponentTransferFunctionElement::transferFunction):
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::SVGElementInstanceList):
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::SVGFEColorMatrixElement): (SVGFEColorMatrixElement::parseMappedAttribute): (SVGFEColorMatrixElement::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::SVGFitToViewBox): (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::SVGGradientElement):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLength.cpp:
  • ksvg2/svg/SVGLengthList.cpp: (WebCore::SVGLengthList::SVGLengthList): (WebCore::SVGLengthList::parse):
  • ksvg2/svg/SVGLengthList.h:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGList.h: (WebCore::SVGListBase::SVGListBase): (WebCore::SVGListBase::~SVGListBase): (WebCore::SVGListBase::numberOfItems): (WebCore::SVGListBase::clear): (WebCore::SVGListBase::initialize): (WebCore::SVGListBase::getFirst): (WebCore::SVGListBase::getLast): (WebCore::SVGListBase::getItem): (WebCore::SVGListBase::insertItemBefore): (WebCore::SVGListBase::replaceItem): (WebCore::SVGListBase::removeItem): (WebCore::SVGListBase::appendItem): (WebCore::SVGList::nullItem): (WebCore::):
  • ksvg2/svg/SVGLocatable.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGNumberList.cpp: (SVGNumberList::SVGNumberList): (SVGNumberList::parse):
  • ksvg2/svg/SVGNumberList.h:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::pathSegList):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::SVGPathSegList):
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPointList.cpp: (SVGPointList::SVGPointList):
  • ksvg2/svg/SVGPointList.h:
  • ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::points): (SVGPolyElement::svgPolyTo): (SVGPolyElement::notifyAttributeChange):
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.cpp: (SVGPolygonElement::toPathData):
  • ksvg2/svg/SVGPolylineElement.cpp: (SVGPolylineElement::toPathData):
  • ksvg2/svg/SVGPreserveAspectRatio.h: (WebCore::SVGPreserveAspectRatio::):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::parseMappedAttribute): (WebCore::SVGSVGElement::createRenderer):
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStringList.cpp: (WebCore::SVGStringList::SVGStringList): (WebCore::SVGStringList::reset):
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (SVGStyledTransformableElement::SVGStyledTransformableElement):
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.cpp: (SVGTextPositioningElement::SVGTextPositioningElement): (SVGTextPositioningElement::parseMappedAttribute):
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate): (SVGTransformList::concatenate):
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.h:
2:09 PM Changeset in webkit [22159] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <acarlsson@apple.com>

  • WebCore.vcproj/WebCore.vcproj: Fix build.
2:07 PM Changeset in webkit [16307] by kmccullo
  • 1 edit in trunk/WebCore/platform/mac/LocalCurrentGraphicsContext.h

Build fix

1:58 PM Changeset in webkit [16306] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog date fix

1:48 PM Changeset in webkit [16305] by aroben
  • 3 edits
    2 moves in trunk/WebCore

Rubberstamped by Adele.

Rename LocalGraphicsContext.{h,mm} to
LocalCurrentGraphicsContext.{h,mm} to match the class name.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/LocalCurrentGraphicsContext.mm: Added.
  • platform/mac/LocalCurrentGraphicsContext.h: Added.
  • platform/mac/LocalGraphicsContext.h: Removed.
  • platform/mac/LocalGraphicsContext.mm: Removed.
  • rendering/RenderThemeMac.mm: Fix #include to match renamed file
1:36 PM Changeset in webkit [22158] by andersca
  • 1 edit
    2 adds in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O and Maciej.

Add plugin stream object.


  • plugins/win/PluginStreamWin.cpp: Added. (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::setRequestHeaders): (WebCore::PluginStreamWin::setPostData): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::cancelAndDestroyStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::delayDeliveryTimerFired): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::receivedData): (WebCore::PluginStreamWin::receivedAllData):
  • plugins/win/PluginStreamWin.h: Added.
1:34 PM Changeset in webkit [16304] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Conflict marker removed

1:29 PM Changeset in webkit [16303] by beidson
  • 2 edits in trunk/WebCore

Build fix

  • WebCore.xcodeproj/project.pbxproj:
11:46 AM Changeset in webkit [16302] by kmccullo
  • 11 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • ChangeLog:
  • fast/dom/Range/range-compareNode-expected.txt: Added.
  • fast/dom/Range/range-compareNode.html: Added.
  • fast/dom/Range/range-comparePoint.html:

WebCore:

Reviewed by Darin.

  • Implements comparePoint on the Range class
  • Exposes RangeExceptions in JavaScript
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp:
  • bindings/objc/DOMInternal.mm:
  • dom/Range.cpp: (WebCore::Range::comparePoint): (WebCore::Range::compareNode):
  • dom/Range.h: (WebCore::Range::):
  • dom/Range.idl:
  • dom/RangeException.h: Added. (WebCore::):
  • dom/RangeException.idl: Added.
  • page/DOMWindow.idl:
11:41 AM Changeset in webkit [16301] by aroben
  • 3 edits
    2 adds in trunk/WebCore

Reviewed by timo.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10812
Move LocalGraphicsContext out of RenderThemeMac

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/LocalGraphicsContext.h: Added.
  • platform/mac/LocalGraphicsContext.mm: Added. (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
  • rendering/RenderThemeMac.mm:
11:20 AM Changeset in webkit [22157] by beidson
  • 7 edits
    1 add in branches/WindowsMerge

Initial IconDatabase hookup for Boomer
(Don't expect to have icons till I hook up the loaders!)

10:38 AM Changeset in webkit [16300] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/javascript-backslash-expected.txt: Added.
  • fast/dom/javascript-backslash.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/javascript-backslash.html

  • platform/KURL.cpp: (WebCore::KURL::init): Don't do backslash substitution in JavaScript URLs.
10:11 AM Changeset in webkit [16299] by weinig
  • 28 edits in trunk/WebCore

Reviewed by Darin and Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators
for something better

  • Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE) idiom.
  • Assorted whitespace changes to IDL files.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMEvents.h:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/NodeFilter.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLOptionsCollection.idl:
7:49 AM Changeset in webkit [16298] by darin
  • 3 edits
    2 deletes in trunk/LayoutTests
  • converted a test to plain text (makes it platform independent; fixes a failure)
  • fast/events/ondragenter-expected.checksum: Removed.
  • fast/events/ondragenter-expected.png: Removed.
  • fast/events/ondragenter-expected.txt:
  • fast/events/ondragenter.html:
12:28 AM Changeset in webkit [16297] by hyatt
  • 3 edits in trunk/WebCore

Fix an unwitting victim of the kMin->min change. calcBlockMinMaxWidth
was accidentally renamed to calcBlominMaxWidth.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::RenderBlock::calcBlockMinMaxWidth):
  • rendering/RenderBlock.h:

Sep 10, 2006:

11:37 PM Changeset in webkit [16296] by hyatt
  • 15 edits in trunk/WebCore

Rework the printer font stuff a little bit so that the Font API doesn't
have to be changed.

Reviewed by eseidel

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreStringTruncator.mm: (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • platform/Font.cpp: (WebCore::Font::drawSimpleText):
  • platform/Font.h:
  • platform/TextStyle.h: (WebCore::TextStyle::TextStyle): (WebCore::TextStyle::attemptFontSubstitution): (WebCore::TextStyle::setRTL):
  • platform/mac/FontMac.mm: (WebCore::m_wordSpacing): (WebCore::Font::drawGlyphs):
  • platform/mac/ListBoxMac.mm: (itemTextRenderer): (groupLabelTextRenderer): (-[WebCoreTableView drawRow:clipRect:]):
  • platform/mac/PopUpButtonMac.mm: (PopUpButton::sizeHint):
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
11:32 PM Changeset in webkit [22156] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Remove usePrinterFont param from Cairo drawGlyphs code path. (CG code path was unpatched so no need to revert it.

11:16 PM Changeset in webkit [16295] by beidson
  • 3 edits in trunk/WebCore
10:23 PM Changeset in webkit [16294] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Added specialized HashTraits

  • platform/IntSizeHash.h:
9:42 PM Changeset in webkit [22155] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Remove the addIntrinsicMargins code from the theme. I did this
in the open source version but forgot to do it in the internal
version.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle): (WebCore::RenderThemeWin::adjustMenuListStyle):
7:48 PM Changeset in webkit [16293] by darin
  • 3 edits
    2 deletes in trunk/LayoutTests
  • converted a text to plain text (makes it platform independent; fixes a failure)
  • fast/text/plain-text-line-breaks-expected.checksum: Removed.
  • fast/text/plain-text-line-breaks-expected.png: Removed.
  • fast/text/plain-text-line-breaks-expected.txt: Regenerated.
  • fast/text/plain-text-line-breaks.html: Added a call to dumpAsText().
7:26 PM Changeset in webkit [16292] by beidson
  • 3 edits in trunk/WebCore

Forgetting header #define protection is BAAAAAD
(and re-alphabatized the project file)

  • WebCore.xcodeproj/project.pbxproj:
  • platform/IntSizeHash.h:
7:13 PM Changeset in webkit [16291] by beidson
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Maciej

Moved the custom IntSize hash out of IconDatabase into a more generally useful file

  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDatabase.h:
  • platform/IntSizeHash.h: Added.
5:14 PM Changeset in webkit [22154] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

4:33 PM Changeset in webkit [16290] by hyatt
  • 58 edits in trunk/LayoutTests/fast/forms

Land new results.

4:27 PM Changeset in webkit [16289] by hyatt
  • 11 edits in trunk/WebCore

Fix for bug 10801, form controls that get styled suddenly lose their
intrinsic margins. Move the intrinsic margin addition code into
adjustRenderStyle and get it out of the theme code and the old form control
code.

Reviewed by aroben

  • css/cssstyleselector.cpp: (WebCore::addIntrinsicMargins): (WebCore::CSSStyleSelector::adjustRenderStyle):
  • css/html4.css:
  • rendering/DeprecatedRenderSelect.h: (WebCore::DeprecatedRenderSelect::calcReplacedHeight):
  • rendering/DeprecatedSlider.h:
  • rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::setStyle):
  • rendering/RenderFormElement.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::adjustTextFieldStyle): (WebCore::RenderThemeMac::adjustTextAreaStyle): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle):
1:22 PM Changeset in webkit [16288] by darin
  • 2 edits in trunk/WebKit

Reviewed by Brady.

  • WebView/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Changed a mistaken "self" to "frame", which was the cause of the bug. Also fixed the method so that it won't crash if createWebViewWithRequest does something that has a side effect of releasing this WebView or this frame by retaining "self" and "frame" as needed. Also fixed a problem where the code to set "opener" was backwards, and would set the opener of the old frame to point to the new frame instead of vice versa.
1:21 PM Changeset in webkit [16287] by darin
  • 1 edit
    2 adds in trunk/WebCore
  • manual-tests/target-test.html: Added.
  • manual-tests/targeted.html: Added.
12:53 PM Changeset in webkit [16286] by eseidel
  • 18 edits in trunk/WebCore

2006-09-10 Eric Seidel <eric@eseidel.com>

Reviewed by darin.


Remove a bunch more NSGraphicsContext related code.
Add a LocalCurrentGraphicsContext to simplify methods which need to call up into AppKit controls (and thus depend on the [NSGraphicsContext currentContext] being set correctly)
Add an "isPrinting" flag to many of the text drawing functions in order to avoid the need for a GraphicsContext::isPrinting() function.

No tests were harmed in the making of this patch.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h: (WebCore::KRenderingDeviceContextQuartz::cgContext): (WebCore::KRenderingDeviceQuartz::isBuffered):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz): (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • platform/Font.cpp: (WebCore::Font::drawSimpleText): (WebCore::Font::drawText):
  • platform/Font.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText):
  • platform/GraphicsContext.h:
  • platform/mac/FileButtonMac.mm: (-[WebFileChooserButton drawRect:]):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/mac/ListBoxMac.mm: (-[WebCoreTableView drawRow:clipRect:]):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderThemeMac.mm: (WebCore::WebCoreNSGraphicsContextBridge::WebCoreNSGraphicsContextBridge): (WebCore::WebCoreNSGraphicsContextBridge::~WebCoreNSGraphicsContextBridge): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea):
11:17 AM Changeset in webkit [16285] by ap
  • 2 edits in trunk/WebKitQt

Reviewed and landed by ap.

Fix QtLauncher - it is supposed to create a FrameView on its own nowadays.

  • QtLauncher/main.cpp: (main):
12:54 AM Changeset in webkit [22153] by sfalken
  • 4 edits in branches/WindowsMerge
12:41 AM Changeset in webkit [16284] by sfalken
  • 4 edits in trunk/WebCore

2006-09-09 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.

Fixes to work with string API changes.

  • platform/cf/ResourceLoaderCFNet.cpp: (WebCore::arrayFromFormData): (WebCore::ResourceLoader::start):
  • platform/cf/StringCF.cpp:
  • platform/cf/StringImplCF.cpp:
12:40 AM Changeset in webkit [16283] by sfalken
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

2006-09-09 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.


Add missing copy command.
Support finding icu headers in multiple locations.

12:19 AM Changeset in webkit [22152] by sfalken
  • 7 edits in branches/WindowsMerge
Note: See TracTimeline for information about the timeline view.