⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 12, 2006:

11:23 PM Changeset in webkit [16341] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 3244, implement html4 label support.

Reviewed by mjs, aroben

Added fast/events/label-focus.html

  • css/html4.css:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::formElement): (WebCore::HTMLLabelElement::setActive): (WebCore::HTMLLabelElement::setHovered): (WebCore::HTMLLabelElement::defaultEventHandler):
  • html/HTMLLabelElement.h:
11:20 PM Changeset in webkit [16340] by hyatt
  • 4 adds in trunk/LayoutTests/fast/events

New label layout test.

10:37 PM Changeset in webkit [16339] by eseidel
  • 3 edits
    4 adds in trunk

2006-09-12 Julien Palmas <​julien.palmas@gmail.com>

Reviewed by darin. Landed by eseidel.

  • ksvg2/svg/svgpathparser.cpp: (WebCore::SVGPolyParser::parsePoints):
6:28 PM Changeset in webkit [16338] by kmccullo
  • 5 edits
    3 adds in trunk

LayoutTests:

Reviewed by Andersca, Maciej, Brady.

  • fast/dom/Range/range-intersectsNode-expected.txt: Added.
  • fast/dom/Range/range-intersectsNode.html: Added.
  • fast/dom/Range/resources/intersectsNode.js: Added.

WebCore:

Reviewed by Andersca, Maciej, Brady.

  • Implemented intersectsNode in the Range Class to be compliant with Mozilla standard
  • dom/Range.cpp: (WebCore::Range::intersectsNode):
  • dom/Range.h:
  • dom/Range.idl:
6:18 PM Changeset in webkit [16337] by eseidel
  • 19 edits
    84 adds
    1 delete in trunk

2006-09-12 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10826


Also finally fixes some long outstanding bugs:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10413

Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
  • ksvg2/svg/SVGAElement.idl: Added.
  • ksvg2/svg/SVGAngle.idl:
  • ksvg2/svg/SVGAnimateColorElement.idl: Added.
  • ksvg2/svg/SVGAnimateElement.idl: Added.
  • ksvg2/svg/SVGAnimateTransformElement.idl: Added.
  • ksvg2/svg/SVGAnimatedLengthList.idl: Added.
  • ksvg2/svg/SVGAnimatedNumberList.idl: Added.
  • ksvg2/svg/SVGAnimatedTransformList.idl: Added.
  • ksvg2/svg/SVGAnimationElement.idl: Added.
  • ksvg2/svg/SVGCircleElement.idl: Added.
  • ksvg2/svg/SVGClipPathElement.idl: Added.
  • ksvg2/svg/SVGColor.idl:
  • ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
  • ksvg2/svg/SVGCursorElement.idl: Added.
  • ksvg2/svg/SVGDefsElement.idl: Added.
  • ksvg2/svg/SVGDescElement.idl: Added.
  • ksvg2/svg/SVGEllipseElement.idl: Added.
  • ksvg2/svg/SVGEvent.idl:
  • ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
  • ksvg2/svg/SVGFEBlendElement.idl: Added.
  • ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
  • ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
  • ksvg2/svg/SVGFECompositeElement.idl: Added.
  • ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
  • ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
  • ksvg2/svg/SVGFEDistantLightElement.idl: Added.
  • ksvg2/svg/SVGFEFloodElement.idl: Added.
  • ksvg2/svg/SVGFEFuncAElement.idl: Added.
  • ksvg2/svg/SVGFEFuncBElement.idl: Added.
  • ksvg2/svg/SVGFEFuncGElement.idl: Added.
  • ksvg2/svg/SVGFEFuncRElement.idl: Added.
  • ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
  • ksvg2/svg/SVGFEImageElement.idl: Added.
  • ksvg2/svg/SVGFEMergeElement.idl: Added.
  • ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
  • ksvg2/svg/SVGFEOffsetElement.idl: Added.
  • ksvg2/svg/SVGFEPointLightElement.idl: Added.
  • ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
  • ksvg2/svg/SVGFESpotLightElement.idl: Added.
  • ksvg2/svg/SVGFETileElement.idl: Added.
  • ksvg2/svg/SVGFETurbulenceElement.idl: Added.
  • ksvg2/svg/SVGFilterElement.idl: Added.
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
  • ksvg2/svg/SVGFitToViewBox.idl: Added.
  • ksvg2/svg/SVGForeignObjectElement.idl: Added.
  • ksvg2/svg/SVGGElement.idl: Added.
  • ksvg2/svg/SVGGradientElement.idl: Added.
  • ksvg2/svg/SVGImageElement.idl: Added.
  • ksvg2/svg/SVGLangSpace.idl: Added.
  • ksvg2/svg/SVGLength.idl:
  • ksvg2/svg/SVGLengthList.idl: Added.
  • ksvg2/svg/SVGLineElement.idl: Added.
  • ksvg2/svg/SVGLinearGradientElement.idl: Added.
  • ksvg2/svg/SVGLocatable.idl: Added.
  • ksvg2/svg/SVGMarkerElement.idl: Added.
  • ksvg2/svg/SVGMaskElement.idl: Added.
  • ksvg2/svg/SVGNumberList.idl: Added.
  • ksvg2/svg/SVGPaint.idl: Added.
  • ksvg2/svg/SVGPathElement.idl:
  • ksvg2/svg/SVGPathSeg.idl:
  • ksvg2/svg/SVGPatternElement.idl: Added.
  • ksvg2/svg/SVGPointList.idl: Added.
  • ksvg2/svg/SVGPolygonElement.idl: Added.
  • ksvg2/svg/SVGPolylineElement.idl: Added.
  • ksvg2/svg/SVGPreserveAspectRatio.idl:
  • ksvg2/svg/SVGRadialGradientElement.idl: Added.
  • ksvg2/svg/SVGRectElement.idl: Added.
  • ksvg2/svg/SVGRenderingIntent.idl: Added.
  • ksvg2/svg/SVGSVGElement.idl:
  • ksvg2/svg/SVGScriptElement.idl: Added.
  • ksvg2/svg/SVGSetElement.idl: Added.
  • ksvg2/svg/SVGStopElement.idl: Added.
  • ksvg2/svg/SVGStringList.idl: Added.
  • ksvg2/svg/SVGStylable.idl: Added.
  • ksvg2/svg/SVGStyleElement.idl: Added.
  • ksvg2/svg/SVGSwitchElement.idl: Added.
  • ksvg2/svg/SVGSymbolElement.idl: Added.
  • ksvg2/svg/SVGTRefElement.idl: Added.
  • ksvg2/svg/SVGTSpanElement.idl: Added.
  • ksvg2/svg/SVGTests.idl: Added.
  • ksvg2/svg/SVGTextContentElement.idl: Added.
  • ksvg2/svg/SVGTextElement.idl: Added.
  • ksvg2/svg/SVGTextPositioningElement.idl: Added.
  • ksvg2/svg/SVGTitleElement.idl: Added.
  • ksvg2/svg/SVGTransform.idl:
  • ksvg2/svg/SVGTransformList.idl: Added.
  • ksvg2/svg/SVGTransformable.idl: Added.
  • ksvg2/svg/SVGURIReference.idl: Added.
  • ksvg2/svg/SVGUnitTypes.idl: Added.
  • ksvg2/svg/SVGUseElement.idl: Added.
  • ksvg2/svg/SVGViewElement.idl: Added.
  • ksvg2/svg/SVGZoomAndPan.idl: Added.
  • ksvg2/svg/SVGZoomEvent.idl: Added.
5:25 PM Changeset in webkit [16336] by aroben
  • 5 edits in trunk/WebCore

Reviewed by timo, ggaren.

Make Icon ref-counted.

  • platform/FileChooser.h: Store m_icon as a RefPtr instead of auto_ptr.
  • platform/Icon.h: Inherit from Shared<Icon>
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::chooseFile): Update m_icon usage
  • platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile): Return a RefPtr instead of an auto_ptr
5:08 PM Changeset in webkit [16335] by thatcher
  • 6 edits
    9 copies
    12 adds in tags/Safari-521.26

New tag.

4:57 PM Changeset in webkit [16334] by thatcher
  • 8 edits in /

Fixing the versioning.

3:33 PM Changeset in webkit [16333] by thatcher
  • 12 adds in tags/Safari-521.21/WebKit/DOM

Old DOM headers for 521.21 until the new DOM API is approved.

3:30 PM Changeset in webkit [16332] by thatcher
  • 6 edits
    9 copies in tags/Safari-521.21/OpenSource

Tagging for version 521.21

3:26 PM Changeset in webkit [16331] by thatcher
  • 8 edits in /

Versioning

2:19 PM Changeset in webkit [16330] by rwlbuis
  • 85 edits
    2 adds in trunk/WebCore

Reviewed by Anders.

Add exception codes to SVGList functions, adjust all code using it.

Move SVGPaintType enums from ksvg.h into SVGPaint (needed for js generation)
Move SVGUnitTypes enums from ksvg.h into it's own file SVGUnitType.h (ditto)
Move SVGRenderingIntent enums from ksvg.h into it's own file SVGRenderingIntent.h (ditto)
Move SVGZoomAndPan enums from ksvg.h into SVGSVGElement (ditto)
Move SVGFE* related enums into their respecitive classes.

Fix JSSVGNumber to operator on doubles, instead of floats.

2:11 PM Changeset in webkit [16329] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::doTextFieldCommandFromEvent): Don't call textField:doCommandBySelector: with a nil selector. This was indirectly causing a (valid) assertion failure in some Safari code.
2:09 PM Changeset in webkit [16328] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4717841> Setting AXFocused to true does not activate the insertion point in text field

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilitySetValue:forAttribute:]): For AXFocus, use focus() if the node is an element, so that selection is set. Matches tabbing behavior in text fields and text areas.
1:59 PM Changeset in webkit [16327] by thatcher
  • 1 edit in trunk/WebCore/bindings/scripts/generate-bindings.pl

Build fix for the the no-svg bot.

1:57 PM Changeset in webkit [16326] by aroben
  • 6 edits in trunk/WebCore

Reviewed by adele.

Make uploading work with the new file upload control.

  • css/html4.css: Remove unnecessary style (this is already done in RenderFileUpload.cpp)
  • html/HTMLInputElement.cpp: Don't get the button text from the value attribute for file controls. (WebCore::HTMLInputElement::valueWithDefault):
  • platform/mac/FileChooserMac.mm: Call RenderFileUploadControl::valueChanged when the user selects a file. (WebCore::FileChooser::chooseFile):
  • rendering/RenderFileUploadControl.cpp: Add valueChanged() method to update the form and fire the onChange event. (WebCore::RenderFileUploadControl::valueChanged): (WebCore::RenderFileUploadControl::updateFromElement):
  • rendering/RenderFileUploadControl.h: Add valueChanged() declaration.
1:52 PM Changeset in webkit [16325] by zbujtas
  • 15 edits
    1 add in S60/trunk

2006-09-11 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas
DESC:Toolbar not working in 3.1
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10668

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::SendCommandsToClient):
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::~CWebKitView): (CWebKitView::Draw):
  • group/BrowserView.mmp:
  • group/webkit.mmp:
  • rom/webkit.iby:
  • rom/webkitResources.iby:
1:43 PM Changeset in webkit [22162] by andersca
  • 6 edits in branches/WindowsMerge/WebCore

2006-09-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

Add scripting support for plugins.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::addPluginRootObject): (WebCore::FrameWin::cleanupPluginObjects): (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::windowScriptNPObject):
  • bridge/win/FrameWin.h:
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue):
  • plugins/win/npapi.cpp: (NPN_RequestRead): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw):
12:59 PM Changeset in webkit [16324] by aroben
  • 2 edits in trunk/WebCore

Adding rules to html4.css to style the button in file upload controls.

  • css/html4.css:
12:42 PM Changeset in webkit [16323] by aroben
  • 14 edits
    6 adds
    4 deletes in trunk/WebCore

Reviewed many times by darin, hyatt.

Switch to new engine-based implementation of <input type="file">

  • WebCore.exp: Remove obsolete symbol WebCoreFileButton
  • WebCore.xcodeproj/project.pbxproj: Remove files for old widget-based control, add files for new engine-based control
  • css/CSSSelector.cpp: Add support for new '-webkit-file-upload-button' pseudo element (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: Ditto. (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: Ditto. (WebCore::CSSStyleSelector::checkOneSelector):
  • html/HTMLInputElement.cpp: Send click events to new control (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::click): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLTextFieldInnerElement.h: Add 'virtual' keyword (WebCore::HTMLTextFieldInnerElement::shadowParentNode):
  • platform/FileButton.h: Removed.
  • platform/FileChooser.h: Added. This is the replacement for FileButton.h (WebCore::FileChooser::filename): (WebCore::FileChooser::icon): (WebCore::FileChooser::uploadControl): (WebCore::FileChooser::document):
  • platform/Icon.h: Added new platform-specific class representing a file icon.
  • platform/LocalizedStrings.h:
  • platform/mac/FileButtonMac.mm: Removed.
  • platform/mac/FileChooserMac.mm: Added. This is the replacement for FileButtonMac.mm (-[OpenPanelController initWithFileChooser:]): (-[OpenPanelController fileChooserDetachingSoon]): (-[OpenPanelController beginSheet]): (-[OpenPanelController chooseFilename:]): (-[OpenPanelController cancel]): (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::~FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
  • platform/mac/IconMac.mm: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
  • platform/mac/LocalizedStringsMac.mm: Call across bridge to get localized strings. (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel):
  • rendering/RenderButton.cpp: Extract method setText() from updateFromElement. (WebCore::RenderButton::updateFromElement): (WebCore::RenderButton::setText):
  • rendering/RenderButton.h: Add declaration for new setText method.
  • rendering/RenderFileButton.cpp: Removed.
  • rendering/RenderFileButton.h: Removed.
  • rendering/RenderFileUploadControl.cpp: Added. This is the replacement for RenderFileButton.cpp. (WebCore::RenderFileUploadInnerFileBox::renderName): (WebCore::HTMLFileUploadInnerButtonElement::isShadowNode): (WebCore::HTMLFileUploadInnerButtonElement::shadowParentNode): (WebCore::RenderFileUploadControl::RenderFileUploadControl): (WebCore::RenderFileUploadControl::~RenderFileUploadControl): (WebCore::RenderFileUploadControl::setStyle): (WebCore::RenderFileUploadControl::updateIconAndFilename): (WebCore::RenderFileUploadControl::click): (WebCore::RenderFileUploadControl::updateFromElement): (WebCore::RenderFileUploadControl::maxFilenameWidth): (WebCore::RenderFileUploadControl::createButtonStyle): (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadInnerFileBox::RenderFileUploadInnerFileBox): (WebCore::RenderFileUploadInnerFileBox::setStyle): (WebCore::RenderFileUploadInnerFileBox::layout): (WebCore::RenderFileUploadInnerFileBox::setHasIcon): (WebCore::RenderFileUploadInnerFileBox::setFilename): (WebCore::RenderFileUploadInnerFileBox::calcMinMaxWidth): (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement): (WebCore::HTMLFileUploadInnerButtonElement::createRenderer):
  • rendering/RenderFileUploadControl.h: Added. This is the replacement for RenderFileButton.h. (WebCore::RenderFileUploadControl::renderName):
  • rendering/RenderStyle.cpp: Add support for -webkit-file-upload-button pseudo element. (WebCore::): (WebCore::pseudoBit):
  • rendering/RenderStyle.h: Ditto. (WebCore::RenderStyle::):
12:37 PM Changeset in webkit [22161] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed many times by darin, hyatt.

Add stubs for new engine-based file upload control implementation and
Icon class.

  • WebCore.vcproj/WebCore.vcproj: Add new engine-based files, remove old widget-based files.
  • platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser and Icon methods, and add two new LocalizedString methods. (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (Icon::~Icon): (Icon::paint):
10:48 AM Changeset in webkit [16322] by andersca
  • 5 edits in trunk/WebCore

2006-09-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John Sullivan.

Do the plugin object cleanup in Frame::clear instead of setView.


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView): (WebCore::FrameMac::cleanupPluginObjects):
  • page/Frame.cpp: (WebCore::Frame::clear):
  • page/Frame.h:
9:43 AM Changeset in webkit [16321] by aroben
  • 2 edits in trunk/WebCore

2006-09-12 MorganL <​morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10822
windows build is busted

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add missing JSRangeException.{cpp,h} to project
9:31 AM Changeset in webkit [22160] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

Add stream and URL handling to PluginViewWin. Include PluginStreamWin.cpp in the build.
Also fix a number of bugs discovered when loading various plugins.


  • WebCore.vcproj/WebCore.vcproj:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::url): (WebCore::PluginRequestWin::target): (WebCore::PluginRequestWin::notifyData): (WebCore::PluginRequestWin::sendNotification): (WebCore::scriptStringIfJavaScriptURL): (WebCore::registerPluginView): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::updateSize): (WebCore::PluginViewWin::setFrameGeometry): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::createUTF8String): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::requestTimerFired): (WebCore::PluginViewWin::scheduleRequest): (WebCore::PluginViewWin::loadURL): (WebCore::makeURL): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::newStream): (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::destroyStream): (WebCore::PluginViewWin::userAgent): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
12:28 AM Changeset in webkit [16320] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

Add fieldset layout test.

12:26 AM Changeset in webkit [16319] by hyatt
  • 5 edits in trunk/WebCore

Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. The bug is 3898.

Reviewed by mjs

Added fast/forms/fieldset-with-float.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderFieldset.h: (WebCore::RenderFieldset::renderName): (WebCore::RenderFieldset::expandsToEncloseOverhangingFloats):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):
12:02 AM Changeset in webkit [16318] by eseidel
  • 2 edits in trunk/WebCore

2006-09-11 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.


REGRESSION: When dragging a link on a page, the selected link doesn't display it's name or URL
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10819
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10814

No test cases were harmed in the coding of the patch.

  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):

Sep 11, 2006:

10:39 PM Changeset in webkit [16317] by aroben
  • 2 edits in trunk/WebKit

2006-09-11 MorganL <​morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10765
Windows build busted due to std::copy usage in Vector.h

  • WebKit.vcproj/WebKit.vcproj: Define _SCL_SECURE_NO_DEPRECATE to get rid of deprecation warnings on std::copy
10:06 PM Changeset in webkit [16316] by hyatt
  • 3 edits in trunk/LayoutTests/fast/table

Land updated table test.

9:52 PM Changeset in webkit [16315] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 8126, column widths apply to the border boxes of cells.

Reviewed by aroben

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::styleOrColWidth):
8:58 PM Changeset in webkit [16314] by thatcher
  • 1 edit in trunk/JavaScriptCore/bindings/objc/objc_utility.mm

Better Tiger build fix.

8:53 PM Changeset in webkit [16313] by beidson
  • 2 edits in trunk/WebKit

Despite the fact that some people built okay without this change, it sure was biting me,
probably because I just wiped my build directory for a fresh build -
Today's earlier removal of DOMList.h needed to occur in MigrateHeaders.make, as well

  • MigrateHeaders.make: removed DOMList.h
7:45 PM Changeset in webkit [16312] by beidson
  • 2 edits in trunk/JavaScriptCore

Build fix - I think Tim's last checkin wasn't tested on Tiger, possibly. I simply
commented out the undefined constants until he can have a chance to make the right call

  • bindings/objc/objc_utility.mm: (KJS::Bindings::objcValueTypeForType): Commented out undefined symbols
5:22 PM Changeset in webkit [16311] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/FrameMac.mm

Build fix. KeyScript is deprecated in Leopard, we need a new solution for this <rdar://problem/4727607>

4:57 PM Changeset in webkit [16310] by thatcher
  • 4 edits in trunk/JavaScriptCore

Reviewed by Tim O. and Darin.

Add support for more method signatures affecting ObjC methods called from JavaScript:

  • Added unsigned types and long long.
  • Allow methods that use const, oneway, bycopy and byref type modifiers.
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_utility.h: (KJS::Bindings::):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue): (KJS::Bindings::objcValueTypeForType):
4:11 PM Changeset in webkit [16309] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fix Qt/Linux build.

  • CMakeLists.txt: Add dom/RangeException.idl to build & fix feature defines.
2:42 PM Changeset in webkit [16308] by eseidel
  • 104 edits
    14 adds
    34 deletes in trunk

2006-09-11 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10750

This finally fixes the SVGAnimated* classes JS bindings!

  • Move all SVGAnimated*.idl files from ksvg2/bindings/idl/svg to ksvg2/svg
  • Adjust XCode/Qt build files to generate the new idl files
  • Remove all SVGAnimated* primitives cpp implementations (Angle/Boolean/Color/Enumeration/Integer/Length/

LengthList/Number/NumberList/PreserveAspectRatio/
Rect/String/TransformList)

  • Remove unneeded methods from CodeGenerator.pm and add new helper function: IsSVGAnimatedType
  • Adjust CodeGeneratorJS.pm to the new SVGAnimated* tear-off concept
  • Add two new macros: ANIMATED_PROPERTY_EMPTY_DECLARATIONS / ANIMATED_PROPERTY_FORWARD_DECLARATIONS. This is used to fix multiple-inheritance issues in SVG with properties, similar like SVGTests::isValid() was fixed.
  • Rewrote SVGList using WTF::Vector, instead of DeprecatedPtrList and killed DOMList. (SVGAnimated*Lists work again now)
  • Adjust macros in SVGElement to create the "*Animated" tear-off classes.
  • Adjust all SVG classes which use the ANIMATED macros to include the ClassName as first param in the header.
  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio): (WebCore::RenderSVGImage::paint):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::translationForAttributes):
  • ksvg2/ksvg.h:
  • ksvg2/misc/SVGDocumentExtensions.h: (WebCore::FloatRect):
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAnimateColorElement.cpp:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (SVGComponentTransferFunctionElement::transferFunction):
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::SVGElementInstanceList):
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::SVGFEColorMatrixElement): (SVGFEColorMatrixElement::parseMappedAttribute): (SVGFEColorMatrixElement::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::SVGFitToViewBox): (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::SVGGradientElement):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLength.cpp:
  • ksvg2/svg/SVGLengthList.cpp: (WebCore::SVGLengthList::SVGLengthList): (WebCore::SVGLengthList::parse):
  • ksvg2/svg/SVGLengthList.h:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGList.h: (WebCore::SVGListBase::SVGListBase): (WebCore::SVGListBase::~SVGListBase): (WebCore::SVGListBase::numberOfItems): (WebCore::SVGListBase::clear): (WebCore::SVGListBase::initialize): (WebCore::SVGListBase::getFirst): (WebCore::SVGListBase::getLast): (WebCore::SVGListBase::getItem): (WebCore::SVGListBase::insertItemBefore): (WebCore::SVGListBase::replaceItem): (WebCore::SVGListBase::removeItem): (WebCore::SVGListBase::appendItem): (WebCore::SVGList::nullItem): (WebCore::):
  • ksvg2/svg/SVGLocatable.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGNumberList.cpp: (SVGNumberList::SVGNumberList): (SVGNumberList::parse):
  • ksvg2/svg/SVGNumberList.h:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::pathSegList):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::SVGPathSegList):
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPointList.cpp: (SVGPointList::SVGPointList):
  • ksvg2/svg/SVGPointList.h:
  • ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::points): (SVGPolyElement::svgPolyTo): (SVGPolyElement::notifyAttributeChange):
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.cpp: (SVGPolygonElement::toPathData):
  • ksvg2/svg/SVGPolylineElement.cpp: (SVGPolylineElement::toPathData):
  • ksvg2/svg/SVGPreserveAspectRatio.h: (WebCore::SVGPreserveAspectRatio::):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::parseMappedAttribute): (WebCore::SVGSVGElement::createRenderer):
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStringList.cpp: (WebCore::SVGStringList::SVGStringList): (WebCore::SVGStringList::reset):
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (SVGStyledTransformableElement::SVGStyledTransformableElement):
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.cpp: (SVGTextPositioningElement::SVGTextPositioningElement): (SVGTextPositioningElement::parseMappedAttribute):
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate): (SVGTransformList::concatenate):
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.h:
2:09 PM Changeset in webkit [22159] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <​acarlsson@apple.com>

  • WebCore.vcproj/WebCore.vcproj: Fix build.
2:07 PM Changeset in webkit [16307] by kmccullo
  • 1 edit in trunk/WebCore/platform/mac/LocalCurrentGraphicsContext.h

Build fix

1:58 PM Changeset in webkit [16306] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog date fix

1:48 PM Changeset in webkit [16305] by aroben
  • 3 edits
    2 moves in trunk/WebCore

Rubberstamped by Adele.

Rename LocalGraphicsContext.{h,mm} to
LocalCurrentGraphicsContext.{h,mm} to match the class name.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/LocalCurrentGraphicsContext.mm: Added.
  • platform/mac/LocalCurrentGraphicsContext.h: Added.
  • platform/mac/LocalGraphicsContext.h: Removed.
  • platform/mac/LocalGraphicsContext.mm: Removed.
  • rendering/RenderThemeMac.mm: Fix #include to match renamed file
1:36 PM Changeset in webkit [22158] by andersca
  • 1 edit
    2 adds in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O and Maciej.

Add plugin stream object.


  • plugins/win/PluginStreamWin.cpp: Added. (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::setRequestHeaders): (WebCore::PluginStreamWin::setPostData): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::cancelAndDestroyStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::delayDeliveryTimerFired): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::receivedData): (WebCore::PluginStreamWin::receivedAllData):
  • plugins/win/PluginStreamWin.h: Added.
1:34 PM Changeset in webkit [16304] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Conflict marker removed

1:29 PM Changeset in webkit [16303] by beidson
  • 2 edits in trunk/WebCore

Build fix

  • WebCore.xcodeproj/project.pbxproj:
11:46 AM Changeset in webkit [16302] by kmccullo
  • 11 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • ChangeLog:
  • fast/dom/Range/range-compareNode-expected.txt: Added.
  • fast/dom/Range/range-compareNode.html: Added.
  • fast/dom/Range/range-comparePoint.html:

WebCore:

Reviewed by Darin.

  • Implements comparePoint on the Range class
  • Exposes RangeExceptions in JavaScript
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp:
  • bindings/objc/DOMInternal.mm:
  • dom/Range.cpp: (WebCore::Range::comparePoint): (WebCore::Range::compareNode):
  • dom/Range.h: (WebCore::Range::):
  • dom/Range.idl:
  • dom/RangeException.h: Added. (WebCore::):
  • dom/RangeException.idl: Added.
  • page/DOMWindow.idl:
11:41 AM Changeset in webkit [16301] by aroben
  • 3 edits
    2 adds in trunk/WebCore

Reviewed by timo.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10812
Move LocalGraphicsContext out of RenderThemeMac

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/LocalGraphicsContext.h: Added.
  • platform/mac/LocalGraphicsContext.mm: Added. (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
  • rendering/RenderThemeMac.mm:
11:20 AM Changeset in webkit [22157] by beidson
  • 7 edits
    1 add in branches/WindowsMerge

Initial IconDatabase hookup for Boomer
(Don't expect to have icons till I hook up the loaders!)

10:38 AM Changeset in webkit [16300] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/javascript-backslash-expected.txt: Added.
  • fast/dom/javascript-backslash.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/javascript-backslash.html

  • platform/KURL.cpp: (WebCore::KURL::init): Don't do backslash substitution in JavaScript URLs.
10:11 AM Changeset in webkit [16299] by weinig
  • 28 edits in trunk/WebCore

Reviewed by Darin and Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators
for something better

  • Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE) idiom.
  • Assorted whitespace changes to IDL files.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMEvents.h:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/NodeFilter.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLOptionsCollection.idl:
7:49 AM Changeset in webkit [16298] by darin
  • 3 edits
    2 deletes in trunk/LayoutTests
  • converted a test to plain text (makes it platform independent; fixes a failure)
  • fast/events/ondragenter-expected.checksum: Removed.
  • fast/events/ondragenter-expected.png: Removed.
  • fast/events/ondragenter-expected.txt:
  • fast/events/ondragenter.html:
12:28 AM Changeset in webkit [16297] by hyatt
  • 3 edits in trunk/WebCore

Fix an unwitting victim of the kMin->min change. calcBlockMinMaxWidth
was accidentally renamed to calcBlominMaxWidth.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::RenderBlock::calcBlockMinMaxWidth):
  • rendering/RenderBlock.h:
Note: See TracTimeline for information about the timeline view.