⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 13, 2006:

10:10 PM Changeset in webkit [22170] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-13 Steve Falkenburg <​sfalken@apple.com>

Fixes for submission of WebCore. Doesn't affect build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/merge-opensource.sh:
10:03 PM Changeset in webkit [16358] by bdash
  • 2 edits in trunk/WebCore

2006-09-13 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Adam.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller

  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
9:47 PM Changeset in webkit [16357] by aroben
  • 30 edits in trunk/LayoutTests

Rubberstamped by hyatt.

Updating tables results after hyatt landed a fix for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8126
Padding must not apply to columns

  • tables/mozilla/bugs/bug139524-2-expected.txt:
  • tables/mozilla/bugs/bug139524-4-expected.txt:
  • tables/mozilla/bugs/bug32841-expected.txt:
  • tables/mozilla/dom/appendCol2-expected.txt:
  • tables/mozilla/dom/deleteCol1-expected.txt:
  • tables/mozilla/dom/deleteCol2-expected.txt:
  • tables/mozilla/dom/deleteCol3-expected.txt:
  • tables/mozilla/dom/deleteColGroup1-expected.txt:
  • tables/mozilla/dom/deleteColGroup2-expected.txt:
  • tables/mozilla/dom/insertColGroups1-expected.txt:
  • tables/mozilla/dom/insertColGroups2-expected.txt:
  • tables/mozilla/dom/insertCols1-expected.txt:
  • tables/mozilla/dom/insertCols2-expected.txt:
  • tables/mozilla/dom/insertCols3-expected.txt:
  • tables/mozilla/dom/insertCols4-expected.txt:
  • tables/mozilla/dom/insertCols5-expected.txt:
  • tables/mozilla/marvin/body_col-expected.txt:
  • tables/mozilla/marvin/x_col_span-expected.txt:
  • tables/mozilla/marvin/x_col_width_px-expected.txt:
  • tables/mozilla/marvin/x_colgroup_span-expected.txt:
  • tables/mozilla/other/body_col-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • tables/mozilla_expected_failures/core/cols1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
  • tables/mozilla_expected_failures/other/test4-expected.txt:
9:41 PM Changeset in webkit [16356] by bdash
  • 2 edits in trunk/WebCore

2006-09-13 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef

  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): Release CGColorRef after use. (WebCore::Font::drawGlyphs): Ditto.
7:27 PM Changeset in webkit [16355] by andersca
  • 3 edits in trunk/WebCore

2006-09-14 Anders Carlsson <​acarlsson@apple.com>

Try fixing the Win32 build.


  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::bindingRootObject):
6:59 PM Changeset in webkit [16354] by sfalken
  • 5 edits
    1 add in trunk/JavaScriptCore

2006-09-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


Build tweaks (doing JavaScriptCore now since it doesn't have
dependencies).

6:57 PM Changeset in webkit [22169] by sfalken
  • 24 edits
    3 adds in branches/WindowsMerge
6:56 PM Changeset in webkit [16353] by andersca
  • 14 edits in trunk/WebCore

2006-09-14 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.


  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::createLanguageInstanceForValue):
  • bindings/js/kjs_dom.cpp: (KJS::getRuntimeObject):
  • bridge/mac/FrameMac.h:
  • config.h:
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::~HTMLAppletElement): (WebCore::HTMLAppletElement::detach):
  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::~HTMLEmbedElement): (WebCore::HTMLEmbedElement::detach):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::detach):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::createNPObject):
  • html/HTMLPlugInElement.h:
  • page/Frame.h:
6:13 PM Changeset in webkit [22168] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-09-13 Ada Chan <​adachan@apple.com>

Reviewed by sfalken


  • WebBackForwardList::containsItem()
    • we can break once we've found the item
  • Fixed a crashing bug with WebNotificationCenter::addObserver.
4:56 PM Changeset in webkit [22167] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/WebCore.vcproj: Rename KHTML_XSLT to XSLT_SUPPORT, remove KHTML_NO_XBL
  • config.h: Ditto.
4:01 PM Changeset in webkit [16352] by thatcher
  • 1 edit in tags/WebCore-521.26.1/WebCore/Info.plist

Versioning

3:59 PM Changeset in webkit [16351] by thatcher
  • 1 copy in tags/WebCore-521.26.1/WebCore

New tag part two.

3:58 PM Changeset in webkit [16350] by thatcher
  • 1 add in tags/WebCore-521.26.1

New tag.

3:55 PM Changeset in webkit [22166] by aroben
  • 3 edits
    2 adds in branches/WindowsMerge/WebCore

Reviewed by beidson.

Initial implementation of Icon, FileChooser on Windows.

  • WebCore.vcproj/WebCore.vcproj: Added FileChooserWin.cpp, IconWin.cpp
  • platform/win/FileChooserWin.cpp: Added. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
  • platform/win/IconWin.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
  • platform/win/TemporaryLinkStubs.cpp: Removed FileChooser, Icon stub functions
3:18 PM Changeset in webkit [16349] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4726416> obsolete confusing "ADVISORY NOTE" comment in WebHistory.h

Removed the "ADVISORY NOTE: This method may change for the 1.0 SDK" comments.

  • History/WebHistory.h:
3:10 PM Changeset in webkit [16348] by hyatt
  • 33 edits in trunk/WebCore

Clean up the XBL and XSLT ifdefs to be consistent with the SVG
and XPath ifdefs. KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
KHTML_XSLT is now XSLT_SUPPORT.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXSLTProcessor.cpp:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • config.h:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h: (WebCore::Document::bindingManager):
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setStyleSheet):
  • dom/ProcessingInstruction.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::processingInstruction): (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • dom/XMLTokenizer.h:
  • loader/Cache.cpp: (WebCore::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedResourceClient.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==):
  • rendering/RenderStyle.h:
  • xml/XSLImportRule.cpp:
  • xml/XSLImportRule.h:
  • xml/XSLStyleSheet.cpp:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessor.h:
3:07 PM Changeset in webkit [16347] by eseidel
  • 4 edits in trunk/WebCore

2006-09-13 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix newly introduced memory leaks in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10835

  • ksvg2/svg/SVGList.h: (WebCore::SVGListBase::~SVGListBase): (WebCore::SVGListBase::clearVector): (WebCore::SVGListBase::clear): (WebCore::SVGList::clearVector): (WebCore::):
  • ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that! (SVGNumberList::SVGNumberList):
  • ksvg2/svg/SVGNumberList.h: Ditto.
2:30 PM Changeset in webkit [22165] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-09-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

Implement postURL and postURLNotify.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::cancelAndDestroyStream):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::loadURL): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::startsWithBlankLine): (WebCore::locationAfterFirstBlankLine): (WebCore::findEOL): (WebCore::capitalizeRFC822HeaderFieldName): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost): (WebCore::PluginViewWin::postURLNotify): (WebCore::PluginViewWin::postURL):
  • plugins/win/PluginViewWin.h:
2:10 PM Changeset in webkit [22164] by lamadio
  • 2 edits in branches/WindowsMerge/WebCore
11:37 AM Changeset in webkit [16346] by aroben
  • 3 edits in trunk/WebCore

2006-09-13 MorganL <​morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
Windows build needs fixed after move to engine-rendered file upload widget

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files, remove RenderFileButton files
  • platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (FileChooser::chooseFile): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint):
11:15 AM Changeset in webkit [16345] by aroben
  • 2 edits in trunk/WebCore

2006-09-13 MorganL <​morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/attachment.cgi?id=10537
Webkit WebCore build fails on Windows

  • WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT variable
9:16 AM Changeset in webkit [16344] by thatcher
  • 2 adds in trunk/WebCore/platform/qt

Forgot these added files.

9:12 AM Changeset in webkit [16343] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Tim H.

Fix Qt/Linux build.

  • CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
  • platform/Icon.h: Add wtf/Platform.h include
  • platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::~FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
  • platform/qt/IconQt.cpp: Added as stub. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
  • platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed (searchableIndexIntroduction): (fileButtonChooseFileLabel): (fileButtonNoFileSelectedLabel):
12:47 AM Changeset in webkit [22163] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/build-generated-files.sh: Export SOURCE_ROOT which is now used by CodeGenerator.pm
12:08 AM Changeset in webkit [16342] by aroben
  • 3 edits in trunk/WebCore

Reviewed by eseidel.

Switch back to passing relative paths to generate-bindings.pl when
generating JS bindings.

  • DerivedSources.make: Pass in relative paths to generate-bindings.pl
  • bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call chdir and always construct absolute paths instead.

Sep 12, 2006:

11:23 PM Changeset in webkit [16341] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 3244, implement html4 label support.

Reviewed by mjs, aroben

Added fast/events/label-focus.html

  • css/html4.css:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::formElement): (WebCore::HTMLLabelElement::setActive): (WebCore::HTMLLabelElement::setHovered): (WebCore::HTMLLabelElement::defaultEventHandler):
  • html/HTMLLabelElement.h:
11:20 PM Changeset in webkit [16340] by hyatt
  • 4 adds in trunk/LayoutTests/fast/events

New label layout test.

10:37 PM Changeset in webkit [16339] by eseidel
  • 3 edits
    4 adds in trunk

2006-09-12 Julien Palmas <​julien.palmas@gmail.com>

Reviewed by darin. Landed by eseidel.

  • ksvg2/svg/svgpathparser.cpp: (WebCore::SVGPolyParser::parsePoints):
6:28 PM Changeset in webkit [16338] by kmccullo
  • 5 edits
    3 adds in trunk

LayoutTests:

Reviewed by Andersca, Maciej, Brady.

  • fast/dom/Range/range-intersectsNode-expected.txt: Added.
  • fast/dom/Range/range-intersectsNode.html: Added.
  • fast/dom/Range/resources/intersectsNode.js: Added.

WebCore:

Reviewed by Andersca, Maciej, Brady.

  • Implemented intersectsNode in the Range Class to be compliant with Mozilla standard
  • dom/Range.cpp: (WebCore::Range::intersectsNode):
  • dom/Range.h:
  • dom/Range.idl:
6:18 PM Changeset in webkit [16337] by eseidel
  • 19 edits
    84 adds
    1 delete in trunk

2006-09-12 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10826


Also finally fixes some long outstanding bugs:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10413

Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
  • ksvg2/svg/SVGAElement.idl: Added.
  • ksvg2/svg/SVGAngle.idl:
  • ksvg2/svg/SVGAnimateColorElement.idl: Added.
  • ksvg2/svg/SVGAnimateElement.idl: Added.
  • ksvg2/svg/SVGAnimateTransformElement.idl: Added.
  • ksvg2/svg/SVGAnimatedLengthList.idl: Added.
  • ksvg2/svg/SVGAnimatedNumberList.idl: Added.
  • ksvg2/svg/SVGAnimatedTransformList.idl: Added.
  • ksvg2/svg/SVGAnimationElement.idl: Added.
  • ksvg2/svg/SVGCircleElement.idl: Added.
  • ksvg2/svg/SVGClipPathElement.idl: Added.
  • ksvg2/svg/SVGColor.idl:
  • ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
  • ksvg2/svg/SVGCursorElement.idl: Added.
  • ksvg2/svg/SVGDefsElement.idl: Added.
  • ksvg2/svg/SVGDescElement.idl: Added.
  • ksvg2/svg/SVGEllipseElement.idl: Added.
  • ksvg2/svg/SVGEvent.idl:
  • ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
  • ksvg2/svg/SVGFEBlendElement.idl: Added.
  • ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
  • ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
  • ksvg2/svg/SVGFECompositeElement.idl: Added.
  • ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
  • ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
  • ksvg2/svg/SVGFEDistantLightElement.idl: Added.
  • ksvg2/svg/SVGFEFloodElement.idl: Added.
  • ksvg2/svg/SVGFEFuncAElement.idl: Added.
  • ksvg2/svg/SVGFEFuncBElement.idl: Added.
  • ksvg2/svg/SVGFEFuncGElement.idl: Added.
  • ksvg2/svg/SVGFEFuncRElement.idl: Added.
  • ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
  • ksvg2/svg/SVGFEImageElement.idl: Added.
  • ksvg2/svg/SVGFEMergeElement.idl: Added.
  • ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
  • ksvg2/svg/SVGFEOffsetElement.idl: Added.
  • ksvg2/svg/SVGFEPointLightElement.idl: Added.
  • ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
  • ksvg2/svg/SVGFESpotLightElement.idl: Added.
  • ksvg2/svg/SVGFETileElement.idl: Added.
  • ksvg2/svg/SVGFETurbulenceElement.idl: Added.
  • ksvg2/svg/SVGFilterElement.idl: Added.
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
  • ksvg2/svg/SVGFitToViewBox.idl: Added.
  • ksvg2/svg/SVGForeignObjectElement.idl: Added.
  • ksvg2/svg/SVGGElement.idl: Added.
  • ksvg2/svg/SVGGradientElement.idl: Added.
  • ksvg2/svg/SVGImageElement.idl: Added.
  • ksvg2/svg/SVGLangSpace.idl: Added.
  • ksvg2/svg/SVGLength.idl:
  • ksvg2/svg/SVGLengthList.idl: Added.
  • ksvg2/svg/SVGLineElement.idl: Added.
  • ksvg2/svg/SVGLinearGradientElement.idl: Added.
  • ksvg2/svg/SVGLocatable.idl: Added.
  • ksvg2/svg/SVGMarkerElement.idl: Added.
  • ksvg2/svg/SVGMaskElement.idl: Added.
  • ksvg2/svg/SVGNumberList.idl: Added.
  • ksvg2/svg/SVGPaint.idl: Added.
  • ksvg2/svg/SVGPathElement.idl:
  • ksvg2/svg/SVGPathSeg.idl:
  • ksvg2/svg/SVGPatternElement.idl: Added.
  • ksvg2/svg/SVGPointList.idl: Added.
  • ksvg2/svg/SVGPolygonElement.idl: Added.
  • ksvg2/svg/SVGPolylineElement.idl: Added.
  • ksvg2/svg/SVGPreserveAspectRatio.idl:
  • ksvg2/svg/SVGRadialGradientElement.idl: Added.
  • ksvg2/svg/SVGRectElement.idl: Added.
  • ksvg2/svg/SVGRenderingIntent.idl: Added.
  • ksvg2/svg/SVGSVGElement.idl:
  • ksvg2/svg/SVGScriptElement.idl: Added.
  • ksvg2/svg/SVGSetElement.idl: Added.
  • ksvg2/svg/SVGStopElement.idl: Added.
  • ksvg2/svg/SVGStringList.idl: Added.
  • ksvg2/svg/SVGStylable.idl: Added.
  • ksvg2/svg/SVGStyleElement.idl: Added.
  • ksvg2/svg/SVGSwitchElement.idl: Added.
  • ksvg2/svg/SVGSymbolElement.idl: Added.
  • ksvg2/svg/SVGTRefElement.idl: Added.
  • ksvg2/svg/SVGTSpanElement.idl: Added.
  • ksvg2/svg/SVGTests.idl: Added.
  • ksvg2/svg/SVGTextContentElement.idl: Added.
  • ksvg2/svg/SVGTextElement.idl: Added.
  • ksvg2/svg/SVGTextPositioningElement.idl: Added.
  • ksvg2/svg/SVGTitleElement.idl: Added.
  • ksvg2/svg/SVGTransform.idl:
  • ksvg2/svg/SVGTransformList.idl: Added.
  • ksvg2/svg/SVGTransformable.idl: Added.
  • ksvg2/svg/SVGURIReference.idl: Added.
  • ksvg2/svg/SVGUnitTypes.idl: Added.
  • ksvg2/svg/SVGUseElement.idl: Added.
  • ksvg2/svg/SVGViewElement.idl: Added.
  • ksvg2/svg/SVGZoomAndPan.idl: Added.
  • ksvg2/svg/SVGZoomEvent.idl: Added.
5:25 PM Changeset in webkit [16336] by aroben
  • 5 edits in trunk/WebCore

Reviewed by timo, ggaren.

Make Icon ref-counted.

  • platform/FileChooser.h: Store m_icon as a RefPtr instead of auto_ptr.
  • platform/Icon.h: Inherit from Shared<Icon>
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::chooseFile): Update m_icon usage
  • platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile): Return a RefPtr instead of an auto_ptr
5:08 PM Changeset in webkit [16335] by thatcher
  • 6 edits
    9 copies
    12 adds in tags/Safari-521.26

New tag.

4:57 PM Changeset in webkit [16334] by thatcher
  • 8 edits in /

Fixing the versioning.

3:33 PM Changeset in webkit [16333] by thatcher
  • 12 adds in tags/Safari-521.21/WebKit/DOM

Old DOM headers for 521.21 until the new DOM API is approved.

3:30 PM Changeset in webkit [16332] by thatcher
  • 6 edits
    9 copies in tags/Safari-521.21/OpenSource

Tagging for version 521.21

3:26 PM Changeset in webkit [16331] by thatcher
  • 8 edits in /

Versioning

2:19 PM Changeset in webkit [16330] by rwlbuis
  • 85 edits
    2 adds in trunk/WebCore

Reviewed by Anders.

Add exception codes to SVGList functions, adjust all code using it.

Move SVGPaintType enums from ksvg.h into SVGPaint (needed for js generation)
Move SVGUnitTypes enums from ksvg.h into it's own file SVGUnitType.h (ditto)
Move SVGRenderingIntent enums from ksvg.h into it's own file SVGRenderingIntent.h (ditto)
Move SVGZoomAndPan enums from ksvg.h into SVGSVGElement (ditto)
Move SVGFE* related enums into their respecitive classes.

Fix JSSVGNumber to operator on doubles, instead of floats.

2:11 PM Changeset in webkit [16329] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::doTextFieldCommandFromEvent): Don't call textField:doCommandBySelector: with a nil selector. This was indirectly causing a (valid) assertion failure in some Safari code.
2:09 PM Changeset in webkit [16328] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4717841> Setting AXFocused to true does not activate the insertion point in text field

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilitySetValue:forAttribute:]): For AXFocus, use focus() if the node is an element, so that selection is set. Matches tabbing behavior in text fields and text areas.
1:59 PM Changeset in webkit [16327] by thatcher
  • 1 edit in trunk/WebCore/bindings/scripts/generate-bindings.pl

Build fix for the the no-svg bot.

1:57 PM Changeset in webkit [16326] by aroben
  • 6 edits in trunk/WebCore

Reviewed by adele.

Make uploading work with the new file upload control.

  • css/html4.css: Remove unnecessary style (this is already done in RenderFileUpload.cpp)
  • html/HTMLInputElement.cpp: Don't get the button text from the value attribute for file controls. (WebCore::HTMLInputElement::valueWithDefault):
  • platform/mac/FileChooserMac.mm: Call RenderFileUploadControl::valueChanged when the user selects a file. (WebCore::FileChooser::chooseFile):
  • rendering/RenderFileUploadControl.cpp: Add valueChanged() method to update the form and fire the onChange event. (WebCore::RenderFileUploadControl::valueChanged): (WebCore::RenderFileUploadControl::updateFromElement):
  • rendering/RenderFileUploadControl.h: Add valueChanged() declaration.
1:52 PM Changeset in webkit [16325] by zbujtas
  • 15 edits
    1 add in S60/trunk

2006-09-11 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas
DESC:Toolbar not working in 3.1
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10668

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::SendCommandsToClient):
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::~CWebKitView): (CWebKitView::Draw):
  • group/BrowserView.mmp:
  • group/webkit.mmp:
  • rom/webkit.iby:
  • rom/webkitResources.iby:
1:43 PM Changeset in webkit [22162] by andersca
  • 6 edits in branches/WindowsMerge/WebCore

2006-09-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

Add scripting support for plugins.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::addPluginRootObject): (WebCore::FrameWin::cleanupPluginObjects): (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::windowScriptNPObject):
  • bridge/win/FrameWin.h:
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue):
  • plugins/win/npapi.cpp: (NPN_RequestRead): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw):
12:59 PM Changeset in webkit [16324] by aroben
  • 2 edits in trunk/WebCore

Adding rules to html4.css to style the button in file upload controls.

  • css/html4.css:
12:42 PM Changeset in webkit [16323] by aroben
  • 14 edits
    6 adds
    4 deletes in trunk/WebCore

Reviewed many times by darin, hyatt.

Switch to new engine-based implementation of <input type="file">

  • WebCore.exp: Remove obsolete symbol WebCoreFileButton
  • WebCore.xcodeproj/project.pbxproj: Remove files for old widget-based control, add files for new engine-based control
  • css/CSSSelector.cpp: Add support for new '-webkit-file-upload-button' pseudo element (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: Ditto. (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: Ditto. (WebCore::CSSStyleSelector::checkOneSelector):
  • html/HTMLInputElement.cpp: Send click events to new control (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::click): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLTextFieldInnerElement.h: Add 'virtual' keyword (WebCore::HTMLTextFieldInnerElement::shadowParentNode):
  • platform/FileButton.h: Removed.
  • platform/FileChooser.h: Added. This is the replacement for FileButton.h (WebCore::FileChooser::filename): (WebCore::FileChooser::icon): (WebCore::FileChooser::uploadControl): (WebCore::FileChooser::document):
  • platform/Icon.h: Added new platform-specific class representing a file icon.
  • platform/LocalizedStrings.h:
  • platform/mac/FileButtonMac.mm: Removed.
  • platform/mac/FileChooserMac.mm: Added. This is the replacement for FileButtonMac.mm (-[OpenPanelController initWithFileChooser:]): (-[OpenPanelController fileChooserDetachingSoon]): (-[OpenPanelController beginSheet]): (-[OpenPanelController chooseFilename:]): (-[OpenPanelController cancel]): (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::~FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
  • platform/mac/IconMac.mm: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
  • platform/mac/LocalizedStringsMac.mm: Call across bridge to get localized strings. (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel):
  • rendering/RenderButton.cpp: Extract method setText() from updateFromElement. (WebCore::RenderButton::updateFromElement): (WebCore::RenderButton::setText):
  • rendering/RenderButton.h: Add declaration for new setText method.
  • rendering/RenderFileButton.cpp: Removed.
  • rendering/RenderFileButton.h: Removed.
  • rendering/RenderFileUploadControl.cpp: Added. This is the replacement for RenderFileButton.cpp. (WebCore::RenderFileUploadInnerFileBox::renderName): (WebCore::HTMLFileUploadInnerButtonElement::isShadowNode): (WebCore::HTMLFileUploadInnerButtonElement::shadowParentNode): (WebCore::RenderFileUploadControl::RenderFileUploadControl): (WebCore::RenderFileUploadControl::~RenderFileUploadControl): (WebCore::RenderFileUploadControl::setStyle): (WebCore::RenderFileUploadControl::updateIconAndFilename): (WebCore::RenderFileUploadControl::click): (WebCore::RenderFileUploadControl::updateFromElement): (WebCore::RenderFileUploadControl::maxFilenameWidth): (WebCore::RenderFileUploadControl::createButtonStyle): (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadInnerFileBox::RenderFileUploadInnerFileBox): (WebCore::RenderFileUploadInnerFileBox::setStyle): (WebCore::RenderFileUploadInnerFileBox::layout): (WebCore::RenderFileUploadInnerFileBox::setHasIcon): (WebCore::RenderFileUploadInnerFileBox::setFilename): (WebCore::RenderFileUploadInnerFileBox::calcMinMaxWidth): (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement): (WebCore::HTMLFileUploadInnerButtonElement::createRenderer):
  • rendering/RenderFileUploadControl.h: Added. This is the replacement for RenderFileButton.h. (WebCore::RenderFileUploadControl::renderName):
  • rendering/RenderStyle.cpp: Add support for -webkit-file-upload-button pseudo element. (WebCore::): (WebCore::pseudoBit):
  • rendering/RenderStyle.h: Ditto. (WebCore::RenderStyle::):
12:37 PM Changeset in webkit [22161] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed many times by darin, hyatt.

Add stubs for new engine-based file upload control implementation and
Icon class.

  • WebCore.vcproj/WebCore.vcproj: Add new engine-based files, remove old widget-based files.
  • platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser and Icon methods, and add two new LocalizedString methods. (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (Icon::~Icon): (Icon::paint):
10:48 AM Changeset in webkit [16322] by andersca
  • 5 edits in trunk/WebCore

2006-09-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John Sullivan.

Do the plugin object cleanup in Frame::clear instead of setView.


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView): (WebCore::FrameMac::cleanupPluginObjects):
  • page/Frame.cpp: (WebCore::Frame::clear):
  • page/Frame.h:
9:43 AM Changeset in webkit [16321] by aroben
  • 2 edits in trunk/WebCore

2006-09-12 MorganL <​morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10822
windows build is busted

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add missing JSRangeException.{cpp,h} to project
9:31 AM Changeset in webkit [22160] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

Add stream and URL handling to PluginViewWin. Include PluginStreamWin.cpp in the build.
Also fix a number of bugs discovered when loading various plugins.


  • WebCore.vcproj/WebCore.vcproj:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::url): (WebCore::PluginRequestWin::target): (WebCore::PluginRequestWin::notifyData): (WebCore::PluginRequestWin::sendNotification): (WebCore::scriptStringIfJavaScriptURL): (WebCore::registerPluginView): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::updateSize): (WebCore::PluginViewWin::setFrameGeometry): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::createUTF8String): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::requestTimerFired): (WebCore::PluginViewWin::scheduleRequest): (WebCore::PluginViewWin::loadURL): (WebCore::makeURL): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::newStream): (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::destroyStream): (WebCore::PluginViewWin::userAgent): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
12:28 AM Changeset in webkit [16320] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

Add fieldset layout test.

12:26 AM Changeset in webkit [16319] by hyatt
  • 5 edits in trunk/WebCore

Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. The bug is 3898.

Reviewed by mjs

Added fast/forms/fieldset-with-float.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderFieldset.h: (WebCore::RenderFieldset::renderName): (WebCore::RenderFieldset::expandsToEncloseOverhangingFloats):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):
12:02 AM Changeset in webkit [16318] by eseidel
  • 2 edits in trunk/WebCore

2006-09-11 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.


REGRESSION: When dragging a link on a page, the selected link doesn't display it's name or URL
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10819
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10814

No test cases were harmed in the coding of the patch.

  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
Note: See TracTimeline for information about the timeline view.