⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 14, 2006:

11:09 PM Changeset in webkit [16368] by bdash
  • 4 edits in trunk/WebCore

2006-09-14 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Adam.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate

FrameMac relies on its cleanupPluginObjects being called to perform cleanup. The virtual
Frame::cleanupPluginObjects method is called from Frame's destructor, which results
in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects will be called from Frame::clear
  • page/Frame.cpp: (WebCore::Frame::~Frame): Use cancelAndClear. (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that FrameMac can use.
  • page/Frame.h:
4:44 PM Changeset in webkit [16367] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej's rubber stamp

Exact same fix I just made, but in the other method I horked up
Also added a reference to the bugzilla in comments

  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): (WebCore::Frame::stop):
3:58 PM Changeset in webkit [16366] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fixed a bad iFrame crash, resolving some of the layout test badness


  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading):
  • Added a RefPtr to protect the frame itself to prevent its destruction during this method
12:52 PM Changeset in webkit [16365] by justing
  • 9 edits
    12 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4655880> Up/Down arrows skip over To Do

  • editing/selection/mixed-editability-3-expected.checksum: Added.
  • editing/selection/mixed-editability-3-expected.png: Added.
  • editing/selection/mixed-editability-3-expected.txt: Added.
  • editing/selection/mixed-editability-3.html: Added.
  • editing/selection/mixed-editability-4-expected.checksum: Added.
  • editing/selection/mixed-editability-4-expected.png: Added.
  • editing/selection/mixed-editability-4-expected.txt: Added.
  • editing/selection/mixed-editability-4.html: Added.
  • editing/selection/mixed-editability-5-expected.checksum: Added.
  • editing/selection/mixed-editability-5-expected.png: Added.
  • editing/selection/mixed-editability-5-expected.txt: Added.
  • editing/selection/mixed-editability-5.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4655880> Up/Down arrows skip over To Do

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
  • dom/Node.cpp: Removed the unused inSameRootEditableElement.
  • dom/Node.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
  • editing/visible_units.cpp: (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from editable content into editable content that's embedded in non-editable content. (WebCore::nextLinePosition): Ditto. (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot. This is the behavior that callers desire. This fixes Command + Up/Down. (WebCore::endOfEditableContent): Ditto.
  • editing/visible_units.h:
10:34 AM Changeset in webkit [22173] by sfalken
  • 4 edits in branches/WindowsMerge

2006-09-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou Amadio.

iBench fix - fix null deref in form submission case without a form element.

  • WebFrame.cpp: (WebFrame::submitForm):

2006-09-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou Amadio.

iBench fix - fix WinInet form post code to not reference a stale pointer.
(found by Application Verifier)

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc):
10:30 AM Changeset in webkit [22172] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by sfalken.

A little #include cleanup

  • WebCore.vcproj/WebCore.vcproj: Add loader/icon to AdditionalIncludeDirectories
  • platform/win/TemporaryLinkStubs.cpp: Remove "loader/icon" from #include of IconLoader.h
10:07 AM Changeset in webkit [16364] by aroben
  • 3 edits in trunk/WebCore

2006-09-14 Karthik Kumar <​karthikkumar@gmail.com>

Reviewed by timothy. Landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
Windows build fixes after r16360

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to AdditionalIncludeDirectories
  • platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader, IconDatabase (IconLoader::stopLoading): (IconLoader::startLoading): (IconLoader::createForFrame): (IconDatabase::isIconExpiredForIconURL): (IconDatabase::hasEntryForIconURL): (IconDatabase::sharedIconDatabase):
2:00 AM Changeset in webkit [16363] by beidson
  • 4 edits in trunk/WebCore

Part of a build fix - rest will be filling in some temporary link stubs

1:50 AM Changeset in webkit [22171] by beidson
  • 3 edits in branches/WindowsMerge/WebCore

Build Fix

1:08 AM Changeset in webkit [16362] by bdash
  • 7 edits in trunk

2006-09-14 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Justin Garcia.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by makeing sure that the 'beyondEnd' node is after the start node.

2006-09-14 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Justin Garcia.

Modified testcase for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
Crash in ApplyStyleCommand::applyRelativeFontStyleChange

  • editing/style/table-selection-expected.checksum:
  • editing/style/table-selection-expected.png:
  • editing/style/table-selection-expected.txt:
  • editing/style/table-selection.html: This testcase was for 10579, which is very similar to this bug (10726) Now the testcase tests both bugs.
12:29 AM Changeset in webkit [16361] by bdash
  • 3 edits in trunk/WebCore

2006-09-14 MorganL <​morlmor@yahoo.com>

Reviewed by Brady.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
Various bugs/crashes in ResourceLoaderWin with local files.

  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::fileLoadTimer):
12:20 AM Changeset in webkit [16360] by beidson
  • 17 edits
    3 adds in trunk

WebCore:

Reviewed by Maciej

Icon loads now take place in WebCore

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm:
  • Moved enforcement of a Mozilla Favicon extension elsewhere


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::originalRequestURL):
  • Added accessor to "original request URL"


  • bridge/mac/WebCoreFrameBridge.h:
  • Removed methods to set the iconURL as all loading is now done in WebCore
  • Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL


  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • Moved enforcement of a Mozilla Favicon extension elsewhere


  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconURLForPageURL):
  • Changed an ASSERT to correctly handle a sketchy (invalid) situation
  • loader/icon/IconLoader.h: Added.
  • loader/icon/IconLoader.cpp: Added. (IconLoader::IconLoader): (IconLoader::createForFrame):
  • Static factory method with a private constructor to enforce "you MUST have a Frame to create an IconLoader" semantics (IconLoader::~IconLoader): (IconLoader::startLoading): (IconLoader::stopLoading): (IconLoader::receivedData):
  • ResourceLoaderClient delegate (IconLoader::receivedAllData):
  • Ditto
  • loader/mac/IconLoaderMac.mm: Added. (IconLoader::receivedResponse): (IconLoader::notifyIconChanged):
  • For now, these are platform specific methods
  • One to get the HTTP response code of an icon load
  • The other to call through to the app when the icon has changed (loaded)
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::iconURL): (WebCore::Frame::setIconURL):
  • Frame objects now have an inherent icon URL and a way to calculate/access it (WebCore::Frame::endIfNotLoading):
  • This is where we actually kick off the IconLoader (WebCore::Frame::stop):
  • Added call to stop loading the icon
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
  • Added the icon URL as a private member
  • Added the IconLoader as a private member, and clean it up on deletion
  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Added a valuable ASSERT

WebKit:

Reviewed by Maciej

Add infrastructure to support icon loads taking place in WebCore
Will remove WebKit icon loaders in a later patch

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]):
  • Nuked two old, obsolete methods
  • Added bridge for notifying of an icon change
  • Added bridge for getting the "original request URL" which is still needed until that info is available in the WebCore loaders
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]):
  • Empty body just for now, as it still gets called - next patch will prune all the old impl out
12:01 AM Changeset in webkit [16359] by hyatt
  • 5 edits in trunk/WebCore

Fix for 10841, unable to check checkboxes inside labels.

Reviewed by xenon, bradee-oh

  • css/html4.css:
  • dom/Element.cpp: (WebCore::Element::contains):
  • dom/Element.h:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):

Sep 13, 2006:

10:10 PM Changeset in webkit [22170] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-13 Steve Falkenburg <​sfalken@apple.com>

Fixes for submission of WebCore. Doesn't affect build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/merge-opensource.sh:
10:03 PM Changeset in webkit [16358] by bdash
  • 2 edits in trunk/WebCore

2006-09-13 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Adam.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller

  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
9:47 PM Changeset in webkit [16357] by aroben
  • 30 edits in trunk/LayoutTests

Rubberstamped by hyatt.

Updating tables results after hyatt landed a fix for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8126
Padding must not apply to columns

  • tables/mozilla/bugs/bug139524-2-expected.txt:
  • tables/mozilla/bugs/bug139524-4-expected.txt:
  • tables/mozilla/bugs/bug32841-expected.txt:
  • tables/mozilla/dom/appendCol2-expected.txt:
  • tables/mozilla/dom/deleteCol1-expected.txt:
  • tables/mozilla/dom/deleteCol2-expected.txt:
  • tables/mozilla/dom/deleteCol3-expected.txt:
  • tables/mozilla/dom/deleteColGroup1-expected.txt:
  • tables/mozilla/dom/deleteColGroup2-expected.txt:
  • tables/mozilla/dom/insertColGroups1-expected.txt:
  • tables/mozilla/dom/insertColGroups2-expected.txt:
  • tables/mozilla/dom/insertCols1-expected.txt:
  • tables/mozilla/dom/insertCols2-expected.txt:
  • tables/mozilla/dom/insertCols3-expected.txt:
  • tables/mozilla/dom/insertCols4-expected.txt:
  • tables/mozilla/dom/insertCols5-expected.txt:
  • tables/mozilla/marvin/body_col-expected.txt:
  • tables/mozilla/marvin/x_col_span-expected.txt:
  • tables/mozilla/marvin/x_col_width_px-expected.txt:
  • tables/mozilla/marvin/x_colgroup_span-expected.txt:
  • tables/mozilla/other/body_col-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • tables/mozilla_expected_failures/core/cols1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
  • tables/mozilla_expected_failures/other/test4-expected.txt:
9:41 PM Changeset in webkit [16356] by bdash
  • 2 edits in trunk/WebCore

2006-09-13 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef

  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): Release CGColorRef after use. (WebCore::Font::drawGlyphs): Ditto.
7:27 PM Changeset in webkit [16355] by andersca
  • 3 edits in trunk/WebCore

2006-09-14 Anders Carlsson <​acarlsson@apple.com>

Try fixing the Win32 build.


  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::bindingRootObject):
6:59 PM Changeset in webkit [16354] by sfalken
  • 5 edits
    1 add in trunk/JavaScriptCore

2006-09-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


Build tweaks (doing JavaScriptCore now since it doesn't have
dependencies).

6:57 PM Changeset in webkit [22169] by sfalken
  • 24 edits
    3 adds in branches/WindowsMerge
6:56 PM Changeset in webkit [16353] by andersca
  • 14 edits in trunk/WebCore

2006-09-14 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.


  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::createLanguageInstanceForValue):
  • bindings/js/kjs_dom.cpp: (KJS::getRuntimeObject):
  • bridge/mac/FrameMac.h:
  • config.h:
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::~HTMLAppletElement): (WebCore::HTMLAppletElement::detach):
  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::~HTMLEmbedElement): (WebCore::HTMLEmbedElement::detach):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::detach):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::createNPObject):
  • html/HTMLPlugInElement.h:
  • page/Frame.h:
6:13 PM Changeset in webkit [22168] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-09-13 Ada Chan <​adachan@apple.com>

Reviewed by sfalken


  • WebBackForwardList::containsItem()
    • we can break once we've found the item
  • Fixed a crashing bug with WebNotificationCenter::addObserver.
4:56 PM Changeset in webkit [22167] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/WebCore.vcproj: Rename KHTML_XSLT to XSLT_SUPPORT, remove KHTML_NO_XBL
  • config.h: Ditto.
4:01 PM Changeset in webkit [16352] by thatcher
  • 1 edit in tags/WebCore-521.26.1/WebCore/Info.plist

Versioning

3:59 PM Changeset in webkit [16351] by thatcher
  • 1 copy in tags/WebCore-521.26.1/WebCore

New tag part two.

3:58 PM Changeset in webkit [16350] by thatcher
  • 1 add in tags/WebCore-521.26.1

New tag.

3:55 PM Changeset in webkit [22166] by aroben
  • 3 edits
    2 adds in branches/WindowsMerge/WebCore

Reviewed by beidson.

Initial implementation of Icon, FileChooser on Windows.

  • WebCore.vcproj/WebCore.vcproj: Added FileChooserWin.cpp, IconWin.cpp
  • platform/win/FileChooserWin.cpp: Added. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
  • platform/win/IconWin.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
  • platform/win/TemporaryLinkStubs.cpp: Removed FileChooser, Icon stub functions
3:18 PM Changeset in webkit [16349] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4726416> obsolete confusing "ADVISORY NOTE" comment in WebHistory.h

Removed the "ADVISORY NOTE: This method may change for the 1.0 SDK" comments.

  • History/WebHistory.h:
3:10 PM Changeset in webkit [16348] by hyatt
  • 33 edits in trunk/WebCore

Clean up the XBL and XSLT ifdefs to be consistent with the SVG
and XPath ifdefs. KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
KHTML_XSLT is now XSLT_SUPPORT.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXSLTProcessor.cpp:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • config.h:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h: (WebCore::Document::bindingManager):
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setStyleSheet):
  • dom/ProcessingInstruction.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::processingInstruction): (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • dom/XMLTokenizer.h:
  • loader/Cache.cpp: (WebCore::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedResourceClient.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==):
  • rendering/RenderStyle.h:
  • xml/XSLImportRule.cpp:
  • xml/XSLImportRule.h:
  • xml/XSLStyleSheet.cpp:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessor.h:
3:07 PM Changeset in webkit [16347] by eseidel
  • 4 edits in trunk/WebCore

2006-09-13 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix newly introduced memory leaks in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10835

  • ksvg2/svg/SVGList.h: (WebCore::SVGListBase::~SVGListBase): (WebCore::SVGListBase::clearVector): (WebCore::SVGListBase::clear): (WebCore::SVGList::clearVector): (WebCore::):
  • ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that! (SVGNumberList::SVGNumberList):
  • ksvg2/svg/SVGNumberList.h: Ditto.
2:30 PM Changeset in webkit [22165] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-09-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

Implement postURL and postURLNotify.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::cancelAndDestroyStream):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::loadURL): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::startsWithBlankLine): (WebCore::locationAfterFirstBlankLine): (WebCore::findEOL): (WebCore::capitalizeRFC822HeaderFieldName): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost): (WebCore::PluginViewWin::postURLNotify): (WebCore::PluginViewWin::postURL):
  • plugins/win/PluginViewWin.h:
2:10 PM Changeset in webkit [22164] by lamadio
  • 2 edits in branches/WindowsMerge/WebCore
11:37 AM Changeset in webkit [16346] by aroben
  • 3 edits in trunk/WebCore

2006-09-13 MorganL <​morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
Windows build needs fixed after move to engine-rendered file upload widget

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files, remove RenderFileButton files
  • platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (FileChooser::chooseFile): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint):
11:15 AM Changeset in webkit [16345] by aroben
  • 2 edits in trunk/WebCore

2006-09-13 MorganL <​morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/attachment.cgi?id=10537
Webkit WebCore build fails on Windows

  • WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT variable
9:16 AM Changeset in webkit [16344] by thatcher
  • 2 adds in trunk/WebCore/platform/qt

Forgot these added files.

9:12 AM Changeset in webkit [16343] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Tim H.

Fix Qt/Linux build.

  • CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
  • platform/Icon.h: Add wtf/Platform.h include
  • platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::~FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
  • platform/qt/IconQt.cpp: Added as stub. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
  • platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed (searchableIndexIntroduction): (fileButtonChooseFileLabel): (fileButtonNoFileSelectedLabel):
12:47 AM Changeset in webkit [22163] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/build-generated-files.sh: Export SOURCE_ROOT which is now used by CodeGenerator.pm
12:08 AM Changeset in webkit [16342] by aroben
  • 3 edits in trunk/WebCore

Reviewed by eseidel.

Switch back to passing relative paths to generate-bindings.pl when
generating JS bindings.

  • DerivedSources.make: Pass in relative paths to generate-bindings.pl
  • bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call chdir and always construct absolute paths instead.
Note: See TracTimeline for information about the timeline view.