⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 15, 2006:

9:19 PM Changeset in webkit [16390] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

My ChangeLog msg got out of order. *sigh*

9:17 PM Changeset in webkit [16389] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Make new style ObjC methods public API.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h:
9:04 PM Changeset in webkit [16388] by thatcher
  • 6 edits in trunk

WebCore:

Reviewed by Brady.

Make new style ObjC methods public API.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h:

WebKit:

Reviewed by Brady.

Make new style ObjC methods public API.

  • MigrateHeaders.make:
8:30 PM Changeset in webkit [16387] by weinig
  • 11 edits
    2 deletes in trunk

WebCore:

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
Auto-generate DOMNode for the Objective-C bindings

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]):
  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMNode.h: Removed.
  • bindings/objc/DOMNode.mm: Removed.
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Node.idl:

WebKit:

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
Auto-generate DOMNode for the Objective-C bindings

  • MigrateHeaders.make:
7:24 PM Changeset in webkit [16386] by thatcher
  • 10 edits in trunk

WebCore:

Reviewed by Justin.

Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge centerSelectionInVisibleArea]): (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]): (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]): (-[WebCoreFrameBridge decreaseSelectionListLevel]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]): (createMouseEventFromDraggingInfo):
  • editing/SelectionController.cpp: (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::modify): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent):
  • editing/SelectionController.h:
  • page/Frame.cpp: (WebCore::Frame::revealSelection): (WebCore::Frame::revealCaret):
  • page/Frame.h:

WebKit:

Reviewed by Justin.

Call the bridge directly for alter selection calls. All of this logic is now
in WebCore's SelectionController.

  • WebView/WebHTMLView.m: (-[NSArray moveBackward:]): (-[NSArray moveBackwardAndModifySelection:]): (-[NSArray moveDown:]): (-[NSArray moveDownAndModifySelection:]): (-[NSArray moveForward:]): (-[NSArray moveForwardAndModifySelection:]): (-[NSArray moveLeft:]): (-[NSArray moveLeftAndModifySelection:]): (-[NSArray moveRight:]): (-[NSArray moveRightAndModifySelection:]): (-[NSArray moveToBeginningOfDocument:]): (-[NSArray moveToBeginningOfDocumentAndModifySelection:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToBeginningOfLine:]): (-[NSArray moveToBeginningOfLineAndModifySelection:]): (-[NSArray moveToBeginningOfParagraph:]): (-[NSArray moveToBeginningOfParagraphAndModifySelection:]): (-[NSArray moveToEndOfDocument:]): (-[NSArray moveToEndOfDocumentAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfLine:]): (-[NSArray moveToEndOfLineAndModifySelection:]): (-[NSArray moveToEndOfParagraph:]): (-[NSArray moveToEndOfParagraphAndModifySelection:]): (-[NSArray moveParagraphBackwardAndModifySelection:]): (-[NSArray moveParagraphForwardAndModifySelection:]): (-[NSArray moveUp:]): (-[NSArray moveUpAndModifySelection:]): (-[NSArray moveWordBackward:]): (-[NSArray moveWordBackwardAndModifySelection:]): (-[NSArray moveWordForward:]): (-[NSArray moveWordForwardAndModifySelection:]): (-[NSArray moveWordLeft:]): (-[NSArray moveWordLeftAndModifySelection:]): (-[NSArray moveWordRight:]): (-[NSArray moveWordRightAndModifySelection:]): (-[NSArray pageUp:]): (-[NSArray pageDown:]): (-[NSArray pageUpAndModifySelection:]): (-[NSArray pageDownAndModifySelection:]):
6:40 PM Changeset in webkit [16385] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Anders

Added the ability to get a mutable char* from a CString, which will copy the internal
buffer if the ref count is greater than 1 so your mutable char* won't affect any other
referrer of that buffer.

  • platform/CString.cpp: (WebCore::CString::mutableData): (WebCore::CString::copyBufferIfNeeded):
  • platform/CString.h:
6:17 PM Changeset in webkit [16384] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4674869>
REGRESSION: selecting text to write over results in cursor jumping to middle of next line

  • editing/deleting/whitespace-pre-1-expected.checksum: Added.
  • editing/deleting/whitespace-pre-1-expected.png: Added.
  • editing/deleting/whitespace-pre-1-expected.txt: Added.
  • editing/deleting/whitespace-pre-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4674869>
REGRESSION: selecting text to write over results in cursor jumping to middle of next line

  • editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added lineBoundary to test fix.
  • editing/visible_units.cpp: (WebCore::endOfLine): If the last box on the line is a lineBreak, return the position before it, not after it.
5:55 PM Changeset in webkit [16383] by bdash
  • 4 edits in trunk/WebKitTools

2006-09-15 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Brady.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10635
Bug 10635: Buildbot configuration in SVN is out of sync with build.webkit.org

  • BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Reorder build slaves within build factories in an attempt to spread the load evenly.
  • BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Return to sending status emails to <svnuser>@opensource.apple.com addresses.
  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Update configuration to match changes in Buildbot. Always do clean SVG builds.
5:39 PM Changeset in webkit [16382] by bdash
  • 18 edits
    1 add in trunk

2006-09-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Adam.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
Bug 10864: Linux\GDK build fixes

  • JavaScriptCoreSources.bkl:
  • jscore.bkl:

2006-09-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Adam.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
Bug 10864: Linux\GDK build fixes

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • platform/gdk/FontCacheGdk.cpp:
  • platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit):
  • platform/gdk/FontGdk.cpp: (WebCore::Font::drawGlyphs):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/ImageGdk.cpp: Added. (WebCore::Image::initPlatformData): (WebCore::Image::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::supportsType):
  • platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::RenderPopupMenuGdk::hidePopup):
  • platform/gdk/RenderPopupMenuGdk.h:
  • platform/gdk/ScreenGdk.cpp: (WebCore::drawableForPage): (WebCore::screenRect): (WebCore::screenDepth): (WebCore::usableScreenRect): (WebCore::scaleFactor):
  • platform/gdk/SystemTimeLinux.cpp: (WebCore::currentTime):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::bindingRootObject): (FrameGdk::markMisspellings): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (FrameGdk::shouldChangeSelection): (FrameGdk::respondToChangedSelection): (FrameGdk::respondToChangedContents): (Path::contains): (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::~PlatformScrollBar): (PlatformScrollBar::width): (PlatformScrollBar::height): (PlatformScrollBar::setEnabled): (PlatformScrollBar::paint): (PlatformScrollBar::setScrollBarValue): (PlatformScrollBar::setKnobProportion): (PlatformScrollBar::setRect): (ScrollBar::ScrollBar): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (FileChooser::chooseFile): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (IconLoader::stopLoading): (IconLoader::startLoading): (IconLoader::createForFrame): (IconDatabase::isIconExpiredForIconURL): (IconDatabase::hasEntryForIconURL): (IconDatabase::sharedIconDatabase):
  • platform/gdk/WidgetGdk.cpp:
  • webcore-base.bkl:
5:36 PM Changeset in webkit [16381] by thatcher
  • 3 edits in trunk/LayoutTests

Reviewed by Justin.

Updating results to new expected values.

  • fast/lists/drag-into-marker-expected.txt:
  • fast/repaint/selection-after-delete-expected.txt:
5:26 PM Changeset in webkit [16380] by aroben
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

4:57 PM Changeset in webkit [16379] by thatcher
  • 3 edits in trunk/LayoutTests

Reviewed by Justin.

Updating results to new expected values.

  • editing/inserting/4278698-expected.txt:
  • fast/dom/window-xy-properties-expected.txt:
4:55 PM Changeset in webkit [16378] by bdash
  • 18 edits
    1 add in trunk/WebCore

2006-09-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
Fix svg memory leaks.

Reworked SVGList to deal with RefPtr's for ptr types
which makes manual refcounting unnecessary, and is much safer.

Removing all virtual functions (nullItem) from SVGList, and
also remove SVGListBase. Switch to a similar concept like
Vector/VectorTraits (see new file SVGListTraits.h).

Credits go to Eric/Maciej for the inspiration.

  • CMakeLists.txt: Add SVGListTraits.cpp to build
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
  • kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now. (WebCore::RenderSVGText::translationForAttributes):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now. (WebCore::SVGAnimateTransformElement::handleTimerEvent):
  • ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based. (WebCore::SVGElementInstanceList::SVGElementInstanceList):
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGLengthList.cpp: Ditto. (WebCore::SVGLengthList::SVGLengthList):
  • ksvg2/svg/SVGLengthList.h: Ditto.
  • ksvg2/svg/SVGList.h: Rewrote, as described above. (WebCore::SVGListTypeOperations::nullItem): (WebCore::SVGList::SVGList): (WebCore::SVGList::~SVGList): (WebCore::SVGList::clear): (WebCore::SVGList::getFirst): (WebCore::SVGList::getLast): (WebCore::SVGList::getItem): (WebCore::SVGList::replaceItem): (WebCore::SVGList::removeItem):
  • ksvg2/svg/SVGListTraits.cpp: Added.
  • ksvg2/svg/SVGListTraits.h: Added. (WebCore::):
  • ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now. (WebCore::SVGPathElement::toPathData):
  • ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based. (WebCore::SVGPathSegList::SVGPathSegList):
  • ksvg2/svg/SVGPathSegList.h: Ditto.
  • ksvg2/svg/SVGTransform.cpp: Style cleanup. (SVGTransform::SVGTransform):
  • ksvg2/svg/SVGTransformList.cpp: Be RefPtr based. (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate):
  • ksvg2/svg/SVGTransformList.h: Ditto.
  • ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform. (SVGTransformable::parseTransformAttribute):
4:30 PM Changeset in webkit [16377] by eseidel
  • 5 edits in trunk/WebCore

2006-09-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix build on Qt/Linux and implement Frame::addMessageToConsole to
be able to see javascript errors for instance.

  • CMakeLists.txt:
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQt.cpp: Implement addMessageToConsole. (WebCore::FrameQt::bindingRootObject):
  • platform/qt/TemporaryLinkStubs.cp (WebCore::IconDatabase::hasEntryForIconURL): (WebCore::IconDatabase::sharedIconDatabase):
3:47 PM Changeset in webkit [16376] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-09-15 Anders Carlsson <​acarlsson@apple.com>

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Fix the release build.
3:31 PM Changeset in webkit [16375] by aroben
  • 2 edits in trunk/WebKit

Reviewed by eseidel.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10876
containsItemForURLUnicode uses matchLetter instead of
matchUnicodeLetter

Small fixes for _WebCoreHistoryProvider.

  • History/WebHistory.m: Consistently use BUFFER_SIZE #define (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]): Replace incorrect call to matchLetter to matchUnicodeLetter
3:23 PM Changeset in webkit [16374] by weinig
  • 35 edits in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
Auto-generate the internal methods for the Objective-C bindings

  • Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods) implementations where standard. For cases where a custom implementation was needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
  • Some general cleanup of some of the non-generated bindings, to bring them in- line with what the generated bindings look like.
  • bindings/objc/DOM.mm: (-[DOMNode description]):
  • bindings/objc/DOMCSS.mm: (-[DOMCSSPrimitiveValue WebCore::]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
  • bindings/objc/DOMEvents.mm: (-[DOMEvent WebCore::]):
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLDocument.mm: (-[DOMHTMLDocument title]): (-[DOMHTMLDocument setTitle:]): (-[DOMHTMLDocument referrer]): (-[DOMHTMLDocument domain]): (-[DOMHTMLDocument URL]): (-[DOMHTMLDocument body]): (-[DOMHTMLDocument setBody:]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]): (-[DOMHTMLDocument cookie]): (-[DOMHTMLDocument setCookie:]): (-[DOMHTMLDocument open]): (-[DOMHTMLDocument close]): (-[DOMHTMLDocument write:]): (-[DOMHTMLDocument writeln:]): (-[DOMHTMLDocument getElementById:]): (-[DOMHTMLDocument getElementsByName:]): (-[DOMHTMLDocument WebCore::]): (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
  • bindings/objc/DOMHTMLOptionElement.mm: (-[DOMHTMLOptionElement form]): (-[DOMHTMLOptionElement defaultSelected]): (-[DOMHTMLOptionElement setDefaultSelected:]): (-[DOMHTMLOptionElement text]): (-[DOMHTMLOptionElement index]): (-[DOMHTMLOptionElement disabled]): (-[DOMHTMLOptionElement setDisabled:]): (-[DOMHTMLOptionElement label]): (-[DOMHTMLOptionElement setLabel:]): (-[DOMHTMLOptionElement selected]): (-[DOMHTMLOptionElement setSelected:]): (-[DOMHTMLOptionElement value]): (-[DOMHTMLOptionElement setValue:]): (-[DOMHTMLOptionElement WebCore::]): (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMNode.mm: (-[DOMNode dealloc]): (-[DOMNode finalize]): (-[DOMNode nodeName]): (-[DOMNode nodeValue]): (-[DOMNode setNodeValue:]): (-[DOMNode nodeType]): (-[DOMNode parentNode]): (-[DOMNode childNodes]): (-[DOMNode firstChild]): (-[DOMNode lastChild]): (-[DOMNode previousSibling]): (-[DOMNode nextSibling]): (-[DOMNode attributes]): (-[DOMNode ownerDocument]): (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]): (-[DOMNode hasChildNodes]): (-[DOMNode cloneNode:]): (-[DOMNode normalize]): (-[DOMNode isSupported::]): (-[DOMNode namespaceURI]): (-[DOMNode prefix]): (-[DOMNode setPrefix:]): (-[DOMNode localName]): (-[DOMNode hasAttributes]): (-[DOMNode isSameNode:]): (-[DOMNode isEqualNode:]): (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): (-[DOMNode textContent]): (-[DOMNode setTextContent:]): (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]):
  • bindings/objc/DOMObject.mm: (-[DOMObject _init]):
  • bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver dealloc]): (-[DOMNativeXPathNSResolver finalize]): (-[DOMNativeXPathNSResolver WebCore::]): (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]): (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
  • css/CSSCharsetRule.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSStyleRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSUnknownRule.idl:
  • css/CSSValue.idl:
  • css/CSSValueList.idl:
  • css/StyleSheet.idl:
  • dom/Event.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NodeIterator.idl:
  • dom/OverflowEvent.idl:
  • dom/TreeWalker.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
3:10 PM Changeset in webkit [16373] by aroben
  • 7 edits in trunk

WebCore:

Reviewed by timothy.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
New file upload control should match the width of the old one

Make width of new file upload control match the old one as closely as
possible.

  • rendering/RenderFileUploadControl.cpp:

LayoutTests:

Reviewed by timothy.

Part of ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
New file upload control should match the width of the old one

Update tests to match new file upload control.

  • fast/forms/file-input-disabled-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/input-appearance-height-expected.txt:
  • fast/forms/input-value-expected.txt:
3:01 PM Changeset in webkit [16372] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Eric.

Remove the SVG IDL files from the Copy Resources phase.

  • WebCore.xcodeproj/project.pbxproj:
2:52 PM Changeset in webkit [16371] by andersca
  • 11 edits
    1 add in trunk/JavaScriptCore

2006-09-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Steve.

Add JavaScriptCore API to the build.

  • API/JSBase.cpp:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObject.cpp:
  • API/JSClassRef.cpp:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSStringRef.cpp:
  • API/JSValueRef.cpp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • os-win32/stdbool.h: Added.
2:48 PM Changeset in webkit [22175] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Steve.

1:58 PM Changeset in webkit [22174] by aroben
  • 6 edits
    3 adds in branches/WindowsMerge

WebCore:

Reviewed by sfalken.

Implement historyContains() on Windows (rdar://4733770)

  • WebCore.vcproj/WebCore.vcproj: Add platform\win\WebCoreHistory.{cpp,h} and bridge\win\HistoryWin.cpp to project.
  • bridge/win/HistoryWin.cpp: Added. (WebCore::historyContains):
  • platform/win/TemporaryLinkStubs.cpp: Remove stub for WebCore::historyContains()
  • platform/win/WebCoreHistory.cpp: Added. (WebCore::WebCoreHistory::setHistoryProvider): (WebCore::WebCoreHistory::historyProvider):
  • platform/win/WebCoreHistory.h: Added.

WebKit:

Reviewed by sfalken.

Implement historyContains() on Windows (rdar://4733770)

  • WebHistory.cpp: Add new private _WebCoreHistoryProvider class. (WebHistory::setOptionalSharedHistory): Call WebCore::WebCoreHistory::setHistoryProvider so that WebCore can access history. (WebHistory::itemForURL): Extract itemForURLString method. (WebHistory::itemForURLString): Added. (WebHistory::containsItemForURLString): Added. (_WebCoreHistoryProvider::_WebCoreHistoryProvider): Added. (_WebCoreHistoryProvider::~_WebCoreHistoryProvider): Added. (matchLetter): Ported from Mac's WebHistory.m. (matchUnicodeLetter): Ditto. (_WebCoreHistoryProvider::containsItemForURLLatin1): Ditto. (_WebCoreHistoryProvider::containsItemForURLUnicode): Ditto.
  • WebHistory.h: Fix typo: IID_WebHistoryItemPrivate --> IID_WebHistoryPrivate, added new methods to IWebHistoryPrivate and WebHistory
11:09 AM Changeset in webkit [16370] by kmccullo
  • 3 edits in trunk/LayoutTests
  • just layout test result changes
  • fast/dom/Range/range-compareNode-expected.txt:
  • fast/dom/Range/range-intersectsNode-expected.txt:
2:38 AM Changeset in webkit [16369] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Eric Siedel

Dumped the use of CGColorRef and directly use the floating point data from
WebCore::Color

This fixes the performance regression found between 16285 and 16286

  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):

Sep 14, 2006:

11:09 PM Changeset in webkit [16368] by bdash
  • 4 edits in trunk/WebCore

2006-09-14 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Adam.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate

FrameMac relies on its cleanupPluginObjects being called to perform cleanup. The virtual
Frame::cleanupPluginObjects method is called from Frame's destructor, which results
in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects will be called from Frame::clear
  • page/Frame.cpp: (WebCore::Frame::~Frame): Use cancelAndClear. (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that FrameMac can use.
  • page/Frame.h:
4:44 PM Changeset in webkit [16367] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej's rubber stamp

Exact same fix I just made, but in the other method I horked up
Also added a reference to the bugzilla in comments

  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): (WebCore::Frame::stop):
3:58 PM Changeset in webkit [16366] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fixed a bad iFrame crash, resolving some of the layout test badness


  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading):
  • Added a RefPtr to protect the frame itself to prevent its destruction during this method
12:52 PM Changeset in webkit [16365] by justing
  • 9 edits
    12 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4655880> Up/Down arrows skip over To Do

  • editing/selection/mixed-editability-3-expected.checksum: Added.
  • editing/selection/mixed-editability-3-expected.png: Added.
  • editing/selection/mixed-editability-3-expected.txt: Added.
  • editing/selection/mixed-editability-3.html: Added.
  • editing/selection/mixed-editability-4-expected.checksum: Added.
  • editing/selection/mixed-editability-4-expected.png: Added.
  • editing/selection/mixed-editability-4-expected.txt: Added.
  • editing/selection/mixed-editability-4.html: Added.
  • editing/selection/mixed-editability-5-expected.checksum: Added.
  • editing/selection/mixed-editability-5-expected.png: Added.
  • editing/selection/mixed-editability-5-expected.txt: Added.
  • editing/selection/mixed-editability-5.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4655880> Up/Down arrows skip over To Do

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
  • dom/Node.cpp: Removed the unused inSameRootEditableElement.
  • dom/Node.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
  • editing/visible_units.cpp: (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from editable content into editable content that's embedded in non-editable content. (WebCore::nextLinePosition): Ditto. (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot. This is the behavior that callers desire. This fixes Command + Up/Down. (WebCore::endOfEditableContent): Ditto.
  • editing/visible_units.h:
10:34 AM Changeset in webkit [22173] by sfalken
  • 4 edits in branches/WindowsMerge

2006-09-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou Amadio.

iBench fix - fix null deref in form submission case without a form element.

  • WebFrame.cpp: (WebFrame::submitForm):

2006-09-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou Amadio.

iBench fix - fix WinInet form post code to not reference a stale pointer.
(found by Application Verifier)

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc):
10:30 AM Changeset in webkit [22172] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by sfalken.

A little #include cleanup

  • WebCore.vcproj/WebCore.vcproj: Add loader/icon to AdditionalIncludeDirectories
  • platform/win/TemporaryLinkStubs.cpp: Remove "loader/icon" from #include of IconLoader.h
10:07 AM Changeset in webkit [16364] by aroben
  • 3 edits in trunk/WebCore

2006-09-14 Karthik Kumar <​karthikkumar@gmail.com>

Reviewed by timothy. Landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
Windows build fixes after r16360

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to AdditionalIncludeDirectories
  • platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader, IconDatabase (IconLoader::stopLoading): (IconLoader::startLoading): (IconLoader::createForFrame): (IconDatabase::isIconExpiredForIconURL): (IconDatabase::hasEntryForIconURL): (IconDatabase::sharedIconDatabase):
2:00 AM Changeset in webkit [16363] by beidson
  • 4 edits in trunk/WebCore

Part of a build fix - rest will be filling in some temporary link stubs

1:50 AM Changeset in webkit [22171] by beidson
  • 3 edits in branches/WindowsMerge/WebCore

Build Fix

1:08 AM Changeset in webkit [16362] by bdash
  • 7 edits in trunk

2006-09-14 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Justin Garcia.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by makeing sure that the 'beyondEnd' node is after the start node.

2006-09-14 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Justin Garcia.

Modified testcase for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
Crash in ApplyStyleCommand::applyRelativeFontStyleChange

  • editing/style/table-selection-expected.checksum:
  • editing/style/table-selection-expected.png:
  • editing/style/table-selection-expected.txt:
  • editing/style/table-selection.html: This testcase was for 10579, which is very similar to this bug (10726) Now the testcase tests both bugs.
12:29 AM Changeset in webkit [16361] by bdash
  • 3 edits in trunk/WebCore

2006-09-14 MorganL <​morlmor@yahoo.com>

Reviewed by Brady.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
Various bugs/crashes in ResourceLoaderWin with local files.

  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::fileLoadTimer):
12:20 AM Changeset in webkit [16360] by beidson
  • 17 edits
    3 adds in trunk

WebCore:

Reviewed by Maciej

Icon loads now take place in WebCore

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm:
  • Moved enforcement of a Mozilla Favicon extension elsewhere


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::originalRequestURL):
  • Added accessor to "original request URL"


  • bridge/mac/WebCoreFrameBridge.h:
  • Removed methods to set the iconURL as all loading is now done in WebCore
  • Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL


  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • Moved enforcement of a Mozilla Favicon extension elsewhere


  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconURLForPageURL):
  • Changed an ASSERT to correctly handle a sketchy (invalid) situation
  • loader/icon/IconLoader.h: Added.
  • loader/icon/IconLoader.cpp: Added. (IconLoader::IconLoader): (IconLoader::createForFrame):
  • Static factory method with a private constructor to enforce "you MUST have a Frame to create an IconLoader" semantics (IconLoader::~IconLoader): (IconLoader::startLoading): (IconLoader::stopLoading): (IconLoader::receivedData):
  • ResourceLoaderClient delegate (IconLoader::receivedAllData):
  • Ditto
  • loader/mac/IconLoaderMac.mm: Added. (IconLoader::receivedResponse): (IconLoader::notifyIconChanged):
  • For now, these are platform specific methods
  • One to get the HTTP response code of an icon load
  • The other to call through to the app when the icon has changed (loaded)
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::iconURL): (WebCore::Frame::setIconURL):
  • Frame objects now have an inherent icon URL and a way to calculate/access it (WebCore::Frame::endIfNotLoading):
  • This is where we actually kick off the IconLoader (WebCore::Frame::stop):
  • Added call to stop loading the icon
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
  • Added the icon URL as a private member
  • Added the IconLoader as a private member, and clean it up on deletion
  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Added a valuable ASSERT

WebKit:

Reviewed by Maciej

Add infrastructure to support icon loads taking place in WebCore
Will remove WebKit icon loaders in a later patch

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]):
  • Nuked two old, obsolete methods
  • Added bridge for notifying of an icon change
  • Added bridge for getting the "original request URL" which is still needed until that info is available in the WebCore loaders
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]):
  • Empty body just for now, as it still gets called - next patch will prune all the old impl out
12:01 AM Changeset in webkit [16359] by hyatt
  • 5 edits in trunk/WebCore

Fix for 10841, unable to check checkboxes inside labels.

Reviewed by xenon, bradee-oh

  • css/html4.css:
  • dom/Element.cpp: (WebCore::Element::contains):
  • dom/Element.h:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):
Note: See TracTimeline for information about the timeline view.