Context Navigation

platform/Image.cpp: (WebCore::Image::shouldAnimate): Don't check that there is more than one frame, maybe the rest just hasn't been loaded yet. (WebCore::Image::startAnimation): Move the frame count check here - there is no need to start animating before we get at least two frames.

9:46 PM Changeset in webkit [16416] by eseidel

1 edit
2 adds in trunk/LayoutTests

2006-09-17 Eric Seidel <eric@eseidel.com>

Add a textual dump of the window object property tree.

Reviewed by Sarge.

fast/js/window-properties-expected.txt: Added.
fast/js/window-properties.html: Added.

5:48 PM Changeset in webkit [16415] by hyatt

6 edits in trunk/LayoutTests/tables/mozilla/bugs

Land updated tests for font changes.

5:46 PM Changeset in webkit [16414] by hyatt

3 edits in trunk/LayoutTests/css2.1

Land updated tests for font changes.

5:45 PM Changeset in webkit [16413] by hyatt

6 edits in trunk/LayoutTests/css1/font_properties

Land updated tests for font changes.

4:17 PM Changeset in webkit [16412] by beidson

2 edits in trunk/WebCore

Reviewed by Sarge

IconLoader now gracefully handles the condition where there's no document in the frame
(ie. PDFs)

loader/icon/IconLoader.cpp: (IconLoader::startLoading):

4:06 PM Changeset in webkit [16411] by hyatt

5 edits in trunk/WebCore

Fix for bug 10899, rework how CSS keywords work to be smarter about
using the correct size when generic families change (e.g., monospace to
serif and vice versa).

Reviewed by aroben

Added fast/text/basic/generic-family-changes.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::fontSizeForKeyword):
css/cssstyleselector.h:
dom/Document.cpp: (WebCore::Document::recalcStyle):
platform/FontDescription.h: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::keywordSize): (WebCore::FontDescription::setKeywordSize): (WebCore::FontDescription::operator==):

4:04 PM Changeset in webkit [16410] by hyatt

1 edit
4 adds in trunk/LayoutTests

Adding layout test for bug 10899.

fast/text/basic/generic-family-changes-expected.checksum: Added.
fast/text/basic/generic-family-changes-expected.png: Added.
fast/text/basic/generic-family-changes-expected.txt: Added.
fast/text/basic/generic-family-changes.html: Added.

2:39 PM Changeset in webkit [16409] by aroben

4 edits in trunk/WebKitTools

Reviewed by hyatt, sfalken.

Get DumpRenderTree compiling and limping along on Windows.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (loadResourceIntoArray): Added this function that WebCore::ImageWin needs from WebKit (main): Add NULL argument to Page constructor.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove incorrect "wininet.dll" argument to CC, fix JavaScriptCore.lib path, add *_SECURE_NO_DEPRECATE #defines
Scripts/webkitdirs.pm: Fix JavaScriptCore.lib path

1:18 PM Changeset in webkit [16408] by ap

4 edits
2 adds in trunk

Reviewed by Brady.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
REGRESSION: Reproducible crash in XMLHttpRequest::abort()

Test: http/tests/xmlhttprequest/xhr-onunload.html

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().

loader/icon/IconLoader.cpp: (IconLoader::startLoading): Fix a similar latent bug here.

12:37 PM Changeset in webkit [16407] by aroben

2 edits in trunk/WebCore

Build fix.

loader/icon/IconDatabase.cpp:

12:29 PM Changeset in webkit [22176] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebView.cpp: (WebView::keyPress): Add new "userTriggered" argument to calls to SelectionController::modify

12:24 PM Changeset in webkit [16406] by hyatt

1 edit in trunk/LayoutTests/fast/text/whitespace/013-expected.txt

Land updated results from font fix yesterday.

11:36 AM Changeset in webkit [16405] by andersca

29 edits in trunk/WebCore

2006-09-17 Anders Carlsson <acarlsson@apple.com>

Reviewed by Brady.

Add simplifyWhiteSpace and stripWhiteSpace to the String class.
Change the XSLT Parameter Map to use Strings instead of StringImpls.
General cleanup.

bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
css/MediaList.cpp: (WebCore::MediaList::setMediaText):
dom/Document.cpp: (WebCore::Document::processHttpEquiv):
editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init):
html/HTMLDocument.cpp: (WebCore::parseDocTypeDeclaration):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute):
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::setComplete): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::recalcStyle): (WebCore::HTMLObjectElement::childrenChanged): (WebCore::HTMLObjectElement::isImageType):
html/HTMLObjectElement.h:
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::value):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::appendFormData):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::description):
platform/PlatformString.h:
platform/String.cpp: (WebCore::String::stripWhiteSpace): (WebCore::String::simplifyWhiteSpace):
platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace): (WebCore::StringImpl::toInt):
platform/StringImpl.h:
platform/mac/ClipboardMac.mm: (WebCore::cocoaTypeFromMIMEType):
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
xml/XPathFunctions.cpp: (WebCore::XPath::FunNormalizeSpace::doEvaluate):
xml/XPathGrammar.y:
xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches):
xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): (WebCore::XSLStyleSheet::locateStylesheetSubResource):
xml/XSLTProcessor.cpp: (WebCore::xsltParamArrayFromParameterMap): (WebCore::XSLTProcessor::setParameter): (WebCore::XSLTProcessor::getParameter): (WebCore::XSLTProcessor::removeParameter):
xml/XSLTProcessor.h:
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getStatusText):

8:28 AM Changeset in webkit [16404] by hyatt

4 adds in trunk/LayoutTests/fast/forms

Add fieldset layout test.

8:27 AM Changeset in webkit [16403] by hyatt

7 edits in trunk/WebCore

Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
are declared right before the fieldsets. It turns out fieldsets in other
browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
adding that behavior to fieldset fixes the bug.

Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
and fieldsets all subclass.

Reviewed by anders

Added fast/forms/float-before-fieldset.html

rendering/RenderFieldset.h: (WebCore::RenderFieldset::avoidsFloats):
rendering/RenderFlexibleBox.h: (WebCore::RenderFlexibleBox::avoidsFloats):
rendering/RenderObject.cpp: (WebCore::RenderObject::avoidsFloats):
rendering/RenderObject.h:
rendering/RenderTable.h: (WebCore::RenderTable::avoidsFloats):

7:35 AM Changeset in webkit [16402] by hyatt

1 edit in trunk/LayoutTests/tables/mozilla/bugs/bug24200.html

Update buggy table test to not have a degenrate column structure.

7:35 AM Changeset in webkit [16401] by hyatt

1 edit in trunk/LayoutTests/tables/mozilla_expected_failures/core/table_rules.html

Update buggy table test to say rules=groups and not rules=group

1:00 AM Changeset in webkit [16400] by hyatt

4 adds in trunk/LayoutTests/fast/table

Add frame/rules layout test.

12:57 AM Changeset in webkit [16399] by hyatt

9 edits in trunk/WebCore

Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
"rules" attributes on tables.

Reviewed by bradee-oh

Well-covered by existing layout tests.

html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
html/HTMLTableColElement.h:
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::~HTMLTableElement): (WebCore::HTMLTableElement::setCaption): (WebCore::HTMLTableElement::setTHead): (WebCore::HTMLTableElement::setTFoot): (WebCore::HTMLTableElement::setTBody): (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::deleteTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::deleteTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::deleteCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::deleteRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::childrenChanged): (WebCore::HTMLTableElement::mapToEntry): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecl): (WebCore::HTMLTableElement::getSharedCellDecl): (WebCore::HTMLTableElement::getSharedGroupDecl): (WebCore::HTMLTableElement::attach):
html/HTMLTableElement.h: (WebCore::HTMLTableElement::caption): (WebCore::HTMLTableElement::tHead): (WebCore::HTMLTableElement::tFoot): (WebCore::HTMLTableElement::):
html/HTMLTableRowElement.h:
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
html/HTMLTableSectionElement.h:

12:43 AM Changeset in webkit [16398] by hyatt

4 adds in trunk/LayoutTests/fast/text/basic

Add layout test for bug 4192.

12:39 AM Changeset in webkit [16397] by hyatt

1 edit in trunk/WebCore/ChangeLog

Fix for bugzilla bug 4192, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):

12:39 AM Changeset in webkit [16396] by hyatt

2 edits in trunk/WebCore

Fix for bugzilla bug 4129, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):

12:29 AM Changeset in webkit [16395] by beidson

18 edits
2 deletes in trunk

WebCore:

Reviewed by Hyatt

Pruning code relating to WebKit's icon loader

bridge/mac/WebCoreIconDatabaseBridge.h:
bridge/mac/WebCoreIconDatabaseBridge.mm:
loader/icon/IconDatabase.h:
page/Frame.cpp: (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to its new home

WebKit:

Reviewed by Hyatt

WebIconLoader is dead, long live WebCore::IconLoader
(code prune)

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader commitProvisionalLoad]):
Loader/WebIconLoader.h: Removed.
Loader/WebIconLoader.m: Removed.
Misc/WebIconDatabase.h:
Misc/WebIconDatabase.m:
Misc/WebIconDatabasePrivate.h:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge notifyIconChanged:]):
WebCoreSupport/WebIconDatabaseBridge.h:
WebCoreSupport/WebIconDatabaseBridge.m: (-[WebIconDatabaseBridge _init]): (-[WebIconDatabaseBridge _setIconData:forIconURL:]): (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]):
WebKit.exp:
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _stopLoading]): (-[WebDataSource _setPrimaryLoadComplete:]):
WebView/WebDataSourceInternal.h: